grafana

Commit Graph

Author	SHA1	Message	Date
George Robinson	d6ed5d295e	Alerting: Fix NoDataFound for alert rules using the AND operator (#41305 ) This commit fixes an issue in alerting where NoDataFound is false when using the AND operator to compare two conditions in an alert rule and one of the conditions has no data.	4 years ago
ying-jeanne	54de1078c8	remove the global log error/warn etc functions (#41404 ) * remove the global log error/warn etc functions and use request context logger whenever possible	4 years ago
ying-jeanne	a404a311da	add context in the alert_notification (#41307 )	4 years ago
idafurjes	9340430723	Chore: Add alert ctx (#41161 ) * Add context for alert * Remove context.TODO * Remove xorm * Remove context.TODO * Fix UsageStatsQuerier interface	4 years ago
Santiago	6987ad7b4d	Fix issues with invalid Slack contact points (#41062 ) * Add validation when creating/updating a contact point * Change 201 status code for 200 (as it was before)	4 years ago
Will Browne	8157d3564b	remove println (#41139 )	4 years ago
Ryan McKinley	7319efe077	Dashboard: replace datasource name with a reference object (#33817 ) Co-authored-by: Torkel Ödegaard <torkel@grafana.com> Co-authored-by: Elfo404 <me@giordanoricci.com>	4 years ago
Santiago	c9654c4bc0	Fix issues with Slack contact points (#40953 ) * recipient validation regex modified, validation at creation/modification implemented * Remove validation for recipient, fix tests * Log level changed from Warn to Error	4 years ago
Serge Zaitsev	24a74cd06e	Chore: Refactor GoConvey tests in alerting/conditions (#40843 ) * refactor goconvery tests * use more meaningful assertion * use more meaningful assertions	4 years ago
Skye	bce1011361	Alerting: Option for Discord notifier to use webhook name (#40463 ) * Added an option to discord notifier to use discord's webhook name (useful for customizing notifications). * Support ngalert system with discord username toggle * Added ngalert discord test * Apply suggestions from code review Co-authored-by: gotjosh <josue.abreu@gmail.com> * Docs updated with discord username setting * Fix api integration test Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com> Co-authored-by: gotjosh <josue.abreu@gmail.com>	4 years ago
ying-jeanne	681218275e	remove crit and trace (#40320 )	4 years ago
Serge Zaitsev	5409c88fb8	Chore: Refactor GoConvey in alerting tests (#40845 )	4 years ago
Santiago	1095f69740	Fix slack contact point panic (code review changes) (#40770 ) * panic when unexpected Slack response fixed, tests added * fix linting errors, add test * Code review changes * Apply PR comments Co-authored-by: Armand Grillet <armand.grillet@outlook.com>	4 years ago
Serge Zaitsev	76e30c5e97	Chore: Refactor alerting notifier tests to remove goconvey (#40758 )	4 years ago
Santiago	e54fe220e5	Fix panic when Slack API sends unexpected response (#40721 ) * panic when unexpected Slack response fixed, tests added * fix linting errors, add test	4 years ago
Will Browne	e4297006f6	Chore: Propagate context for data source provisioning (#40235 ) * context all the things * apply feedback * rollback some alerting changes * rollback some alerting changes #2 * more rollbacks * more rollbacks #2 * more rollbacks #3 * more rollbacks #4 * fix integration test * add missing context * add missing and remove incorrect dispatch	4 years ago
Joan López de la Franca Beltran	722c414fef	Encryption: Refactor securejsondata.SecureJsonData to stop relying on global functions (#38865 ) * Encryption: Add support to encrypt/decrypt sjd * Add datasources.Service as a proxy to datasources db operations * Encrypt ds.SecureJsonData before calling SQLStore * Move ds cache code into ds service * Fix tlsmanager tests * Fix pluginproxy tests * Remove some securejsondata.GetEncryptedJsonData usages * Add pluginsettings.Service as a proxy for plugin settings db operations * Add AlertNotificationService as a proxy for alert notification db operations * Remove some securejsondata.GetEncryptedJsonData usages * Remove more securejsondata.GetEncryptedJsonData usages * Fix lint errors * Minor fixes * Remove encryption global functions usages from ngalert * Fix lint errors * Minor fixes * Minor fixes * Remove securejsondata.DecryptedValue usage * Refactor the refactor * Remove securejsondata.DecryptedValue usage * Move securejsondata to migrations package * Move securejsondata to migrations package * Minor fix * Fix integration test * Fix integration tests * Undo undesired changes * Fix tests * Add context.Context into encryption methods * Fix tests * Fix tests * Fix tests * Trigger CI * Fix test * Add names to params of encryption service interface * Remove bus from CacheServiceImpl * Add logging * Add keys to logger Co-authored-by: Emil Tullstedt <emil.tullstedt@grafana.com> * Add missing key to logger Co-authored-by: Emil Tullstedt <emil.tullstedt@grafana.com> * Undo changes in markdown files * Fix formatting * Add context to secrets service * Rename decryptSecureJsonData to decryptSecureJsonDataFn * Name args in GetDecryptedValueFn * Add template back to NewAlertmanagerNotifier * Copy GetDecryptedValueFn to ngalert * Add logging to pluginsettings * Fix pluginsettings test Co-authored-by: Tania B <yalyna.ts@gmail.com> Co-authored-by: Emil Tullstedt <emil.tullstedt@grafana.com>	4 years ago
Sofia Papagiannaki	012d4f0905	Alerting: Remove `ngalert` feature toggle and introduce two new settings for enabling Grafana 8 alerts and disabling them for specific organisations (#38746 ) * Remove `ngalert` feature toggle * Update frontend Remove all references of ngalert feature toggle * Update docs * Disable unified alerting for specific orgs * Add backend tests * Apply suggestions from code review Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com> * Disabled unified alerting by default * Ensure backward compatibility with old ngalert feature toggle * Apply suggestions from code review Co-authored-by: gotjosh <josue@grafana.com>	4 years ago
Tania B	990911a3b9	Chore: Cleanup usageStatsMock duplication (#39710 ) * Chore: Cleanup usageStatsMock duplication * Remove making a new slice for UsageStatsMock	4 years ago
Tania B	b9acdce837	Chore: Fix grafana live stats reset when sending usage stats (#39558 )	4 years ago
Joan López de la Franca Beltran	b891af935a	Usage Stats: Decouple from alerting.UsageStatsQuerier (#39515 ) * Usage Stats: Decouple from alerting.UsageStatsQuerier Co-authored-by: Tania B <yalyna.ts@gmail.com>	4 years ago
Todd Treece	6e667cacee	Alerting: Skip query cache for alert queries (#39010 )	4 years ago
Giordano Ricci	dc36f15fbb	Prometheus: Revert stepMode functionality (#38982 ) * Revert "Prometheus: add functionality to specify desired step interval in dashboards panels (#36422)" This reverts commit `ddf5b65c51`. Co-authored-by: Ivana Huckova <ivana.huckova@gmail.com> * Revert "Explore: add functionality for supporting different step modes in prometheus (#37829)" This reverts commit `f433cfd8d9`. Co-authored-by: Ivana Huckova <ivana.huckova@gmail.com> * Revert stepMode BE implementation from #36796 Co-authored-by: "Ivana Huckova" <ivana.huckova@gmail.com>	4 years ago
Gábor Farkas	01f1c550bf	old-alert: interval calculation: apply default-min-interval of 1ms (#38835 )	4 years ago
Serge Zaitsev	643c7fa0cb	Chore: update all +build statements (#38782 )	4 years ago
Gábor Farkas	aa7a6633b8	old-alert: set interval and max-data-points (#38434 ) * alerting: old-alerting: handle interval + maxdatapoints better * fixed failing test * refactor: use interval instead of tsdb * fix typo * added unit-test * added comment * refactor	4 years ago
idafurjes	568549e810	Bug: Return empty plugins.DataTimeSeriesSlice when the frame field vector is epmty (#38587 ) * Add check if the vector is empty * Use Rows() instead of Len() on field * Remove redundant condition	4 years ago
Arve Knudsen	78596a6756	Migrate to Wire for dependency injection (#32289 ) Fixes #30144 Co-authored-by: dsotirakis <sotirakis.dim@gmail.com> Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com> Co-authored-by: Ida Furjesova <ida.furjesova@grafana.com> Co-authored-by: Jack Westbrook <jack.westbrook@gmail.com> Co-authored-by: Will Browne <wbrowne@users.noreply.github.com> Co-authored-by: Leon Sorokin <leeoniya@gmail.com> Co-authored-by: Andrej Ocenas <mr.ocenas@gmail.com> Co-authored-by: spinillos <selenepinillos@gmail.com> Co-authored-by: Karl Persson <kalle.persson@grafana.com> Co-authored-by: Leonard Gram <leo@xlson.com>	4 years ago
Chip Wolf ‮	fe09879ff5	Alerting: correct property names for Slack bot icons (#33376 )	4 years ago
Dimitris Sotirakis	db91a55d49	Remove duplicated title from slack notification (#37834 )	4 years ago
Djairho Geuens	4cadbba686	Email: Allow configuration of content types for email notifications (#34530 ) * Alerting: Allow configuration of content types for email notifications * Fix lint error * Improves email templates * Improve configuration documentation Co-authored-by: Diana Payton <52059945+oddlittlebird@users.noreply.github.com> * Improve code comments Co-authored-by: Diana Payton <52059945+oddlittlebird@users.noreply.github.com> * Improve configuration documentation Co-authored-by: Diana Payton <52059945+oddlittlebird@users.noreply.github.com> * Improve email template * Remove unnecessary predeclaration Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com> * Adds handling for unrecognized content type Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com> * Move utility function outside of util package * Fixes syntax * Remove unused package * Fix lint error * improve email templates * Fix test * Alerting: Allow configuration of content types for email notifications * Fix lint error * Improves email templates * Improve configuration documentation Co-authored-by: Diana Payton <52059945+oddlittlebird@users.noreply.github.com> * Improve code comments Co-authored-by: Diana Payton <52059945+oddlittlebird@users.noreply.github.com> * Improve configuration documentation Co-authored-by: Diana Payton <52059945+oddlittlebird@users.noreply.github.com> * Improve email template * Remove unnecessary predeclaration Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com> * Adds handling for unrecognized content type Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com> * Move utility function outside of util package * Fixes syntax * Remove unused package * Fix lint error * improve email templates * Fix test * Fix comment style Co-authored-by: Ganesh Vernekar <15064823+codesome@users.noreply.github.com> * Fix template formatting * Add test and improve error handling * Fix test * Fix formatting * Fix formatting * Improve documentation and regenerates txt template * Update docs/sources/administration/configuration.md Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com> Co-authored-by: Djairho Geuens <djairho.geuens@ae.be> Co-authored-by: Diana Payton <52059945+oddlittlebird@users.noreply.github.com> Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com> Co-authored-by: Ganesh Vernekar <15064823+codesome@users.noreply.github.com> Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com>	4 years ago
Marcus Efraimsson	11d03f7961	Chore: Use context.Context for the get home dashboard API endpoint (#36735 ) Use context.Context for the get home dashboard API endpoint. Ref #36734	4 years ago
Kevin Song	0b95fd8ae6	Legacy Alerting: Replace simplejson with a struct in webhook notification channel (#34952 ) * Add type for webhook body * Update pkg/services/alerting/notifiers/webhook.go Co-authored-by: Sofia Papagiannaki <papagian@users.noreply.github.com>	4 years ago
Marcus Efraimsson	477d4197fb	Chore: Improve save dashboard error messages (#35780 ) Includes panel and dashboard id in alert extractor errors. Logs all non-400 dashboard errors. Fixes #35751	4 years ago
Agnès Toulet	5f6c172b5a	Renderer: add version information (#34964 ) * Renderer: add version information * fix alerting test	4 years ago
Chip Wolf ‮	badec6c6ad	Alerting: Add support for configuring avatar URL for the Discord notifier (#33355 ) Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com>	4 years ago
Danilo Bargen	83a83de10a	Clarify that Threema Gateway Alerts support only Basic IDs (#34828 ) Threema Gateway supports two types of IDs: Basic IDs (where the encryption is managed by the API server) and End-to-End IDs (where the keys are managed by the user). This plugin currently does not support End-to-End IDs (since it's much more complex to implement, because the encryption needs to happen locally). Add a few clarifications to the UI. Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>	4 years ago
Agnès Toulet	ec71919e7b	Rendering: add CSV support (#33729 ) * Rendering: add CSV rendering support * Rendering: save csv files into a separate folder * add missing field * Renderer: get filename from renderer plugin * apply PR suggestions * Rendering: remove old PhantomJS error * Rendering: separate RenderCSV and Render functions * fix alerting test * Rendering: fix handling error in HTTP mode * apply PR feedback * Update pkg/services/rendering/http_mode.go Co-authored-by: Joan López de la Franca Beltran <joanjan14@gmail.com> * apply PR feedback * Update rendering metrics with type label * Rendering: return error if not able to parse header * Rendering: update grpc generated file * Rendering: use context.WithTimeout to render CSV too Co-authored-by: Joan López de la Franca Beltran <joanjan14@gmail.com>	4 years ago
Kyle Brandt	8feeaab996	Alerting: Disable dash alerting if NG enabled (#33794 )	4 years ago
Ganesh Vernekar	918552d34b	NGAlert: Send list of available ngalert notification channels via API (#33489 ) Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>	4 years ago
Arve Knudsen	567b852072	PagerDuty: Omit empty message (#33614 ) Co-authored by pkoenig10 Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	4 years ago
Torkel Ödegaard	cbf30aac82	Revert "Omit empty message in PagerDuty notifier (#31359 )" (#33604 ) This reverts commit `d652d035ab`.	4 years ago
Patrick Koenig	d652d035ab	Omit empty message in PagerDuty notifier (#31359 )	4 years ago
Ryan McKinley	7627b55ef4	TSDB: add deprecation comments to many tsdb structs (#33281 )	4 years ago
Arve Knudsen	6408b55a7c	Slack: Use chat.postMessage API by default (#32511 ) * Slack: Use only chat.postMessage API Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> * Slack: Check for response error Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> * Slack: Support custom webhook URL Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> * Simplify Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> * Fix tests Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> * Rewrite tests to use stdlib Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> * Update pkg/services/alerting/notifiers/slack.go Co-authored-by: Dimitris Sotirakis <sotirakis.dim@gmail.com> * Clarify URL field name Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> * Fix linting issue Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> * Fix test Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> * Fix up new Slack notifier Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> * Improve tests Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> * Fix lint Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> * Slack: Make token not required Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> * Alerting: Send validation errors back to client Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> * Document how token is required Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> * Make recipient required when using Slack API Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> * Fix field description Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> Co-authored-by: Dimitris Sotirakis <sotirakis.dim@gmail.com>	4 years ago
Dimitris Sotirakis	b3ce655b67	Remove field limitation from slack notification (#33113 )	4 years ago
n-wbrown	d0ad2931fa	Dashboard: Fix issue where Slack notifications won't link to users (#32861 )	4 years ago
Dimitris Sotirakis	258578766b	Alerting: Add checks for non supported units - disable defaulting to seconds (#32477 ) * Add error handling for unknown units * Fix test cases * Add case for empty string * Changed tests from convey to testify * Fix lints * Move regex vars * Add regex as ng-patterns on alert_tab.html * Update public/app/features/alerting/partials/alert_tab.html Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com> * Update public/app/features/alerting/partials/alert_tab.html Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com> * Make zero and empty string not throw errors * Updated validation error comments * Frequency should allow zero or empty strings * use checkFrequency instead of ng-pattern checkFrequency is not triggered if ng-pattern is defined. * Extract getForValue func - add tests * Fix linting Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com>	4 years ago
Dewald Viljoen	6fa53a1ee4	Alerting: Allow sending notification tags to Opsgenie as extra properties (#30332 ) * Alerting: Opsgenie send tags as extra properties Allow users to select where to send notification tags when alerting via OpsGenie. Supports sending tags as key/value details, concatenated strings in tags or both. Users will be able to see their tags as key/values under extra properties in an alert on the Opsgenie UI. These key/values can then be used in the platform for routing, templating etc. * Configurable delivery to either tags, extra properties or both * Default to current behaviour (tags only) * Support both so users can transition from tags to details Add docs and clean up references * Alerting: Add additional arg for Opsgenie tests The NewEvalContext function now requires a 'PluginRequestValidator' argument. As our test does not use the validator we can specify 'nil' to satisfy the function and allow our test to pass as expected. * Alerting: Opsgenie doc fixes Accept suggested changes for Opsgenie docs Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com> * Alerting: Opsgenie provisioning settings docs Add the new setting to the provisioning docs * Alerting: Opsgenie doc typo correction Move the comma (,) out of the preformatting tags for the setting value * Alerting: Opsgenie refactor send switches Refactor the send switches to be methods on the OpsgenieNotiefier itself. This also cleans up the method names so that the code reads a bit more logically as: if we should send details: send details if we should send tags: send tags This avoids the calling code needing to care about passing the state and allows an engineer working in the `createAlert` function to focus on the results of applying the logic instead. * Alerting: Opsgenie docs rename note Rename the note heading to match the number to more clearly link them. * Alerting: Opsgenie use standard reference to note Refer to the note below as per recommendation and standards. Fixes #30331 Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com>	4 years ago
Ottavio M. Hartman	7a9a52c317	Alerting: Enable Alert rule `severity` tag to override VictorOps Severity setting (#29392 ) * add severity to victorops * Update docs, add test * Fix spelling and lint * fix resolving not working * Update docs/sources/alerting/notifications.md * Update docs/sources/alerting/notifications.md * Update docs/sources/alerting/notifications.md Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com> * Update docs/sources/alerting/notifications.md Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com> * remove table, update supported alert notifiers * add docs * 7.4->7.5 * fix * Update docs/sources/alerting/notifications.md Co-authored-by: Diana Payton <52059945+oddlittlebird@users.noreply.github.com> Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com> Co-authored-by: Diana Payton <52059945+oddlittlebird@users.noreply.github.com>	4 years ago

1 2 3 4 5 ...

888 Commits (46004037e23bb273e12d7a7b1e9f3e7163f4bee7)