grafana

Commit Graph

Author	SHA1	Message	Date
Yuri Tseretyan	06d5850396	Alerting: Update alerting state history API to authorize access using RBAC (#89579 ) * add method CanReadAllRules to rule authorization service * add alias type Namespace for Folder in ngalert's models package. It implements the Namespacer interface that is used by authz logic * update state history's backends to authorize access to rules. * update Loki to add folders UIDs to query. * Update BuildLogQuery to drop filter by folders if it's too long and fall back to in-memory filtering.	11 months ago
Santiago	fe1309dd96	Alerting: Send external URL to the remote Alertmanager (#89701 ) * Alerting: Send external URL to the remote Alertmanager * test that the URL is sent to the remote Alertmanager * AppURL -> ExternalURL	11 months ago
Nihal	b1ce7e8a83	Alerting: Reduce cyclomatic complexity of PrepareRuleGroupStatuses (#89649 ) * reduce cyclomatic complexity of PrepareRuleGroupStatuses. see https://github.com/grafana/grafana/issues/88670 Signed-off-by: Syed Nihal <syed.nihal@nokia.com> * reduce cyclomatic complexity for PrepareRuleGroupStatuses in pkg/services/ngalert/api/api_prometheus.go Signed-off-by: Syed Nihal <syed.nihal@nokia.com> * reduce cyclomatic complexity for PrepareRuleGroupStatuses in pkg/services/ngalert/api/api_prometheus.go Signed-off-by: Syed Nihal <syed.nihal@nokia.com> --------- Signed-off-by: Syed Nihal <syed.nihal@nokia.com>	11 months ago
Matthew Jacobson	83d05ea777	Alerting: Fix broken state tests (#89712 )	11 months ago
Matthew Jacobson	47c9259d75	Alerting: Ensure we update State.LastSentAt before persisting (#89427 )	11 months ago
William Wernert	fcfa89f864	Alerting: Implement Prometheus remote write for recording rules (#89189 ) * Fix timestamp recorded by rule * Implement prometheus remote write * Create http client instead of transport * Address PR comments * Remove status code label	11 months ago
Yuri Tseretyan	4a5aab54a5	Alerting: Add max limit for Loki query size in state history API (#89646 ) * add setting for query limit * update BuildLogQuery to return error if limit is exceeded * move tests for BuildLogQuery to separate suite	11 months ago
Alexander Akhmetov	2035814059	Alerting: fix updating error in the alert rule state during error to error transitions and restarts (#89557 ) Alerting: fix preserving errors in the alert rule state during error to error transitions Alert state transition from one error to another did not update state.Error correctly. The error in state.Error remained as the initial error encountered. This led to another issue, where after a Grafana restart, the error was lost because the state of the alert rule did not change, but the Error is not preserved in the database between restarts. This could happen if the expression service returned an error or the alert routine panicked during querying.	11 months ago
Yuri Tseretyan	b075926202	Alerting: Time Intervals API (#88201 ) * expose ngalert API to public * add delete action to time-intervals * introduce time-interval model generated by app-platform-sdk from CUE model the fields of the model are chosen to be compatible with the current model * implement api server * add feature flag alertingApiServer ---- Test Infra * update helper to support creating custom users with enterprise permissions * add generator for Interval model	11 months ago
Matthew Jacobson	3228b64fe6	Alerting: Resend resolved notifications for ResolvedRetention duration (#88938 ) * Simple replace of State.Resolved with State.ResolvedAt * Retain ResolvedAt time between Normal->Normal transition * Introduce ResolvedRetention to keep sending recently resolved alerts * Make ResolvedRetention configurable with resolved_alert_retention * Tick-based LastSentAt for testing of ResendDelay and ResolvedRetention * Do not reset ResolvedAt during Normal->Pending transition Initially this was done to be inline with Prom ruler. However, Prom ruler doesn't keep track of Inactive->Pending/Alerting using the same alert instance, so it's more understandable that they choose not to retain ResolvedAt. In our case, since we use the same cached instance to represent the transition, it makes more sense to retain it. This should help alleviate some odd situations where temporarily entering Pending will stop future resolved notifications that would have happened because of ResolvedRetention. * Pointers for ResolvedAt & LastSentAt To avoid awkward time.Time{}.Unix() defaults on persist	11 months ago
Yuri Tseretyan	92f10b73a8	Alerting: Move interface Namespaced from accesscontrol to models package (#89439 ) move Namespaced interface from accesscontrol to models	11 months ago
Steve Simpson	8eabef1f91	Alerting: Update remote alertmanager to use extended receivers API. (#89253 ) * Alerting: Update remote alertmanager to use extended receivers API. * Update integration test and Mimir image * Update Mimir image in more places	11 months ago
Steve Simpson	43a246f431	Alerting: Improve performance of /api/prometheus for large numbers of alerts. (#89268 ) * Alerting: Optimize sorting alert instances. * Also change other Labels fields for consistency	12 months ago
Alexander Weaver	8491e02caf	Alerting: Instrument outbound requests for Loki Historian and Remote Alertmanager with tracing (#89185 ) * Add TracedClient * Handle errors and status codes * Wire up tracing to normal ASH and loki annotation mapping * Add tracing to remote alertmanager * one more spot * and not or * More consistency with other grafana traces, lower cardinality name	12 months ago
Dave Henderson	6262c56132	chore(perf): Pre-allocate where possible (enable prealloc linter) (#88952 ) * chore(perf): Pre-allocate where possible (enable prealloc linter) Signed-off-by: Dave Henderson <dave.henderson@grafana.com> * fix TestAlertManagers_buildRedactedAMs Signed-off-by: Dave Henderson <dave.henderson@grafana.com> * prealloc a slice that appeared after rebase Signed-off-by: Dave Henderson <dave.henderson@grafana.com> --------- Signed-off-by: Dave Henderson <dave.henderson@grafana.com>	12 months ago
Steve Simpson	dd3c3b5857	Alerting: Update grafana/alerting. (#88914 )	12 months ago
Ryan McKinley	99d8025829	Chore: Move identity and errutil to apimachinery module (#89116 )	12 months ago
William Wernert	c62cc25513	Alerting: Configure recording rule writer from config.ini (#89056 )	12 months ago
Santiago	b7120c5a30	Alerting: Fix missing argument in call to createRemoteAlertmanager() (#89101 )	12 months ago
Santiago	12d5251c12	Alerting: Alertmanager configuration sync loop (#88822 ) * make the config sync happen on each call to ApplyConfig(), fix tests * send autogen config * add fake autogen function for tests * update stale comments, tidy things up, make linter happy * add auto-gen routes only if the feature toggle is enabled * remove unnecessary fake autogen function * throttle configuration syncs * restore pkg/services/store/entity/sqlstash/sql_storage_server.go * test sync loop in ApplyConfig, skip invalid autogen routes * restore conf/defaults.ini * restore conf/defaults.ini * avoid skipping invalid auto-gen routes in SaveAndApplyConfig * test that autogenFn is called and its errors are returned * add debug message about the sync interval not having elapsed * collapse two log lines into one	12 months ago
Jacob Valdemar	eb76ea47a0	Alerting: Add ha_reconnect_timeout configuration option (#88823 ) * Docs: Update "Configure high availability" guide with ha_reconnect_timeout configuration --------- Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>	12 months ago
Alexander Akhmetov	667fea6623	Alerting: use hash of labels instead of labels string as the alert state cache key (#88956 ) * Alerting: use hash instead of labels as the cache key * Use data.Labels.Fingerprint to calculate the cache key	12 months ago
Alexander Weaver	d004f8a98d	Alerting: Recording rules understands errors embedded in dataframes (#88946 ) * Make MakeDependencyError public for tests in another package * Create tests for errors in eval results * Extract logic to pull frame errors out into exported function * Maybe we can drop cyclomatic complexity lint suppression now? * extract frame errors and fail recording rules if frames contain error * Fix up retry logic to actually work * Do not retry non retryable errors	12 months ago
Steve Simpson	d440d86bbb	Alerting: Fix erroneous use of grafana-cli/logger. (#89037 ) Can't see how this was intentional, likely just a typo.	12 months ago
Santiago	cdbc9d801f	Alerting: Use the internal Alertmanager to test templates and receivers (remote primary) (#88988 )	12 months ago
Yuri Tseretyan	d4b0ac5973	Alerting: Fix rule storage to filter by group names using case-sensitive comparison (#88992 ) * add test for the bug * remove unused struct * update db store to post process filters by group using go-lang's case-sensitive string comparison -------- Co-authored-by: Alexander Weaver <weaver.alex.d@gmail.com>	12 months ago
Santiago	5f4d07bb75	Alerting: Enable remote primary mode using feature toggles (#88976 )	12 months ago
Santiago	e15e40fbd3	Alerting: Skip setting up clustering in remote primary/only modes (#88968 ) * Alerting: Skip setting up clustering in remote primary mode * Update pkg/services/ngalert/notifier/multiorg_alertmanager.go Co-authored-by: Steve Simpson <steve.simpson@grafana.com> --------- Co-authored-by: Steve Simpson <steve.simpson@grafana.com>	12 months ago
William Wernert	63e9969c1b	Alerting: Recording rule mapping logic for data frames to Prometheus metrics (#88550 ) * Add stub Prometheus writer with mapping logic * Add tests	12 months ago
Alexander Weaver	58fdb24b0b	Alerting: Recording rules appear as type=recording in Prometheus API + better abstraction for type (#88805 ) * Wire status through to prom API * Regenerate swagger	12 months ago
Yuri Tseretyan	32ea1801aa	Alerting: Support AWS SNS integration in Grafana (#88867 )	12 months ago
Alexander Weaver	f1dc63565e	Alerting: Fix go-swagger extraction and several embedded types from Alertmanager in Swagger docs (#88879 ) Drop redundant swagger model comments	12 months ago
Yuri Tseretyan	003e3efce9	Alerting: Update mute timings provisioning API to support optimistic locking (#88731 ) * add version to time-interval models * set time interval fingerprint as version * update to check provided version * delete to check if version is provided in query parameter 'version' * update integration tests * update specs	12 months ago
Alexander Weaver	a2e21d61f8	Alerting: Remove dead `evalRunning` guard in rule routine (#88312 ) Remove dead guard	12 months ago
William Wernert	d359591dac	Alerting: Support recording rule struct in provisioning API (#87849 ) * Support record struct in provisioning API * Update api spec * Use record field * Restrict API endpoints following toggle * Fix swagger spec * Add recording rule validation to store validator	12 months ago
Alexander Weaver	820ee6e9db	Alerting: Make all in api generator tooling now actually makes all (#88793 ) * Make all now actually makes all * Clean depends on clean-go	12 months ago
Fayzal Ghantiwala	80f54778f3	Alerting: Add option to use Redis in cluster mode for Alerting HA (#88696 ) * Add config option to use Redis in cluster mode * Use UniversalOptions	12 months ago
Dave Henderson	df784917e4	Alerting: Improve performance of tupleLablesToLabels function (#88736 ) * Alerting: Improve performance of tupleLablesToLabels function Signed-off-by: Dave Henderson <dave.henderson@grafana.com> * use %s for string rather than %v Co-authored-by: Sofia Papagiannaki <1632407+papagian@users.noreply.github.com> --------- Signed-off-by: Dave Henderson <dave.henderson@grafana.com> Co-authored-by: Sofia Papagiannaki <1632407+papagian@users.noreply.github.com>	12 months ago
Santiago	9f9928d41a	Alerting: Update grafana/alerting (#88363 ) * Alerting: Update grafana/alerting * make tests pass by implementing yaml unmarshallers and deleting fields with omitempty in their yaml tags * go mod tidy * fix tests by implementing not calling GettableApiAlertingConfig.UnmarshalYAML from GettableApiAlertingConfig.UnmarshalJSON * cleanup, reduce diff * fix more tests * update grafana/alerting to latest commit, delete global section from configs in tests * bring back YAML unmarshaller for GettableApiAlertingConfig * update alerting package dependency to point to main * skip test for sns notifier	12 months ago
Yuri Tseretyan	a63ef42816	Alerting: Mute Timing service to prevent changing provenance status to none (#88462 ) * use relaxed validation to not introduce breaking changes for now but to be able to use the service in non-provisioning APIs.	12 months ago
Fayzal Ghantiwala	b66cd7ef79	Alerting: Add filters for RouteGetRuleStatuses (#88295 ) * Placeholder commit with rule_uid change * Add new filters to grafana rule state API * Revert type change * Split rule_group and rule_name params * remove debug line * Change how query params are parsed * Comment	12 months ago
Matthew Jacobson	31d5dd0a12	Alerting: Prevent updating rule uid matcher for silences (#88519 ) Prevents updating the `__alert_rule_uid__` equality matcher (used for rule-specific silences) on existing silences	12 months ago
Fayzal Ghantiwala	67b9e3b269	Alerting: Update HA Redis TLS docs (#88538 ) * Update HA Redis TLS doc * Add test for regular TLS * Update docs * Update prom registry	1 year ago
Sofia Papagiannaki	17ca61d7f8	Alerting: Export and provisioning rules into subfolders (#77450 ) * Folders: Optionally include fullpath in service responses * Alerting: Export folder fullpath instead of title * Escape separator in folder title * Add support for provisiong alret rules into subfolders * Use FolderService for creating folders during provisioning * Export WithFullpath() folder service function --------- Co-authored-by: Tania B <yalyna.ts@gmail.com> Co-authored-by: Yuri Tseretyan <yuriy.tseretyan@grafana.com>	1 year ago
Matthew Jacobson	09cb3a6048	Alerting: Add optional metadata via query param to silence GET requests (#88000 ) * Alerting: Add optional metadata to GET silence responses - ruleMetadata: to request rule metadata. - accesscontrol: to request access control metadata.	1 year ago
William Wernert	5de7d4d06d	Alerting: Create writer interface for recording rules (#88459 ) * Create writer interface for recording rules Also create fake impl + use it for stub in scheduler	1 year ago
Fayzal Ghantiwala	543f0ae37e	Alerting: Update ListAlertRulesQuery to take a slice of RuleGroups (#88385 ) * Change ListAlertRulesQuery to take RuleGroup slice instead * Change func name * Change func name * Fix fakes * Fix function arg	1 year ago
Alexander Weaver	b926b6336d	Alerting: Scheduled recording rules execute their queries (#88309 ) * Basic eval flow * Wiring-up * fix * Extend todo * Start with tests * Include some relevant tests, skip ones that seem to have timing-based race conditions * Some tests, touch up linter and todo * Solve TODO * Add tracing * Tests to make sure an eval went through * Wire up feature toggles * Update pkg/services/ngalert/schedule/recording_rule.go Co-authored-by: Steve Simpson <steve.simpson@grafana.com> * Update pkg/services/ngalert/schedule/recording_rule_test.go Co-authored-by: Steve Simpson <steve.simpson@grafana.com> * Update pkg/services/ngalert/schedule/recording_rule_test.go Co-authored-by: Steve Simpson <steve.simpson@grafana.com> * Update pkg/services/ngalert/schedule/recording_rule_test.go Co-authored-by: Steve Simpson <steve.simpson@grafana.com> --------- Co-authored-by: Steve Simpson <steve.simpson@grafana.com>	1 year ago
Matthew Jacobson	8418aca823	Alerting: Add single rule checks to alert rule access control (#88307 ) * Alerting: Add single rule checks to alert rule access control Modifies ruler api single rule read to no longer fetch entire groups and instead use the new single rule ac check. Simplifies provisioning api getAlertRuleAuthorized logic to always load a single rule instead of conditionally loading the entire group when provisioning permissions are not present. * Swap out Has/AuthorizeAccessToRule for Has/AuthorizeAccessInFolder	1 year ago
Kyle Brandt	a738cb42d8	Prometheus: Update dependency to v0.52.0 (#87809 ) * Prometheus: Update dependency to v0.52.0 * go work sync * fix panics in tests * go work sync * prometheus v0.52.0 * handle errors * Update pkg/services/ngalert/sender/sender_test.go Co-authored-by: Santiago <santiagohernandez.1997@gmail.com> * Update pkg/services/ngalert/sender/sender_test.go Co-authored-by: Santiago <santiagohernandez.1997@gmail.com> --------- Co-authored-by: Santiago <santiagohernandez.1997@gmail.com> Co-authored-by: ismail simsek <ismailsimsek09@gmail.com>	1 year ago

1 2 3 4 5 ...

1479 Commits (4d49cc31185e7085a289bba7f3263db47033ddd5)