grafana

Commit Graph

Author	SHA1	Message	Date
Sam Jewell	4aa7d67edd	Server-side expressions: Improve error message (#103968 ) This error message is more correct	1 year ago
Kevin Yu	fd6fd91115	Prometheus: Add support for cloud partners Prometheus data sources (#103482 ) * wip * Add prom flavor support for data source variables and export/import dashboards (#103321) * add dashboard and data source var selection * use match plugin id instead * use updated matchpluginid * formatting * cleanup * regex anchor * update error msg * Alerting: Clean up prometheus-flavored types and functions (#103703) * clean up types and utility functions for dealing with prometheus-flavored data sources * Refactor alerting datasource types to use constants as source of truth * Alerting: Clean up prometheus-flavored types and functions on the bac… (#103716) Alerting: Clean up prometheus-flavored types and functions on the backend * add matchPluginId tests * Update matchPluginId func to bidirectional (#103746) * update matchpluginid func to bidirectional * lint * formatting * use actual isSupportedExternalRulesSourceType in test * add tests in datasource_srv * betterer * remove type assertion * remove unnecessary case * use satisifies to not have to convert tuple to an array of string * add prometheus_flavor test --------- Co-authored-by: Andrew Hackmann <5140848+bossinc@users.noreply.github.com> Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com> Co-authored-by: Alexander Akhmetov <me@alx.cx>	1 year ago
Sarah Zinger	acd843303e	SQL Expression: Add instrumentation for sql expressions (#103758 )	1 year ago
Mariell Hoversholm	757be6365a	CI: Bump golangci-lint to 2.0.2 (#103572 )	1 year ago
Scott Lepper	aea8f27c59	Sql Expressions - remove references to poc database (#103618 ) Sql Expressions - remove DuckDB references	1 year ago
Sam Jewell	f8a72214cf	SQL Expressions: Add more functions to the allowlist (#103546 ) * SQL Expressions: Allow many more functions and nodes * Also allow the `REGEXP_SUBSTR` function * Add window functions * add more JSON support, remove now and current time (for now) --------- Co-authored-by: Kyle Brandt <kyle@grafana.com>	1 year ago
Kyle Brandt	b1490a10e8	SQL Expressions / Alerting: Do not allow duplicates (#103394 )	1 year ago
Kyle Brandt	4a0ec27e5d	SQL Expressions: Query Service Support (#101955 ) --------- Co-authored-by: Adam Simpson <adam@adamsimpson.net> Co-authored-by: Sarah Zinger <sarah.zinger@grafana.com>	1 year ago
Kyle Brandt	c6e52c4766	SQL Expressions: Make SQL Expressions work with Alerting (#101820 ) Initial support for alerting with SQL expressions - When `format` is set to `alerting`, SQL expressions output in a format suitable for alerting evaluation. - Outstanding TODOs: - Deduplicate output rows - Add more tests - Fix broken alerting UI rendering (likely due to shape change to undocumented full-long format) - Basic usage: - SQL must return one numeric column and one or more string columns. - Each row may become an alert. - The alert fires if the numeric value is non-zero. - String columns are treated as labels. --------- Co-authored-by: Konrad Lalik <konradlalik@gmail.com> Co-authored-by: Tom Ratcliffe <tom.ratcliffe@grafana.com> Co-authored-by: Sam Jewell <sam.jewell@grafana.com>	1 year ago
Kyle Brandt	856dcfd6fe	SQL Expressions: Permit range conditions (between) in queries (#103238 )	1 year ago
Sam Jewell	af08a9fae2	SQL Expressions: Add JSON support (#103157 ) - Support bi-directional mapping of frame JSON fields and GMS (go-mysql-server) columns - Permit GMS json functions Co-authored-by: Kyle Brandt <kyle@grafana.com>	1 year ago
Kyle Brandt	e6480a050c	SQL Expressions: Allow substring_index func (#103021 )	1 year ago
Sam Jewell	c9e929e2e6	SQL Expressions: Allow more MySQL AST node-types (#102973 ) * SQL Expressions: Add Null-literal node * Retain some order in the code - put NullVal with BoolVal * Add support for `IN` keyword * Add GROUP_CONCAT keyword * Add COLLATE keyword From Claude: The test case demonstrates a simple use of COLLATE with a string literal, but in real MySQL queries, COLLATE is often used in more complex scenarios like: 1. String comparisons: `SELECT * FROM table WHERE name COLLATE utf8mb4_bin = 'John'` 2. Sorting: `SELECT * FROM table ORDER BY name COLLATE utf8mb4_unicode_ci` 3. JOINs: `SELECT * FROM table1 JOIN table2 ON table1.name COLLATE utf8mb4_bin = table2.name` The COLLATE clause is particularly useful when you need case-sensitive comparisons (utf8mb4_bin) or specific language-aware sorting rules.	1 year ago
Sam Jewell	6be7829acf	SQL Expressions: Allow `IS` keyword (#102841 )	1 year ago
Kyle Brandt	0f6aff2057	SQL Expressions: allow ParenSelect in queries (#102807 ) sql_expressions: allow ParenSelect	1 year ago
Kyle Brandt	f4849eabc7	SQL Expressions: Change metric conversion to full long (#102728 ) When querying metric data (non-table data) with SQL Expressions, we need to convert the data to table format. This is alternative format which does not have the same issues with sparse data. There is now a __metric_name__ column and one __value__ column. Also a __display_name__ column if there is DisplayNameFromDS metadata. --------- Co-authored-by: Adam Simpson <adam@adamsimpson.net>	1 year ago
Todd Treece	1b1f626edd	SQL Expressions: Fix error handling (#102650 )	1 year ago
Kyle Brandt	3f2ef07872	SSE: Fix goroutine leak in math operation expression parsing (#102380 ) --------- Co-authored-by: Sam Jewell <sam.jewell@grafana.com>	1 year ago
Sam Jewell	d7aeebe5e3	Sql Expressions: State when error is from GMS (#102112 )	1 year ago
Sam Jewell	21b9d45ca6	SQL Expressions: Add CASE/WHEN nodes and fixes (and test) for functions just added to allowlist (#102040 ) * SQL Expressions: Add CASE/WHEN SQL nodes to allowlist * Fixed and test for functions added in #102011 * Add remaining functions to the test-case These are mostly aliases, so the LLM chose to omit them originally. But adding now for completeness * Fix ordering of allowed nodes	1 year ago
Sam Jewell	4bd5f29e05	SQL Expressions: Allow more functions (#102011 ) I used Cursor and Claude 3.7 thinking to expand the list of functions we allow. Specifically I needed `abs`. TODO: Check each of these in the official MySQL docs to ensure they are all safe: eg. this doc: https://dev.mysql.com/doc/refman/8.4/en/flow-control-functions.html#operator_case	1 year ago
Sam Jewell	7a3415148e	SQL Expressions: Add cell-limit for input dataframes (#101700 ) * expr: Add row limit to SQL expressions Adds a configurable row limit to SQL expressions to prevent memory issues with large result sets. The limit is configured via the `sql_expression_row_limit` setting in the `[expressions]` section of grafana.ini, with a default of 100,000 rows. The limit is enforced by checking the total number of rows across all input tables before executing the SQL query. If the total exceeds the limit, the query fails with an error message indicating the limit was exceeded. * revert addition of newline * Switch to table-driven tests * Remove single-frame test-cases. We only need to test for the multi frame case. Single frame is a subset of the multi-frame case * Add helper function Simplify the way tests are set up and written * Support convention, that limit: 0 is no limit * Set the row-limit in one place only * Update default limit to 20k rows As per some discussion here: https://raintank-corp.slack.com/archives/C071A5XCFST/p1741611647001369?thread_ts=1740047619.804869&cid=C071A5XCFST * Test row-limit is applied from config Make sure we protect this from regressions This is perhaps a brittle test, somewhat coupled to the code here. But it's good enough to prevent regressions at least. * Add public documentation for the limit * Limit total number of cells instead of rows * Use named-return for totalRows As @kylebrandt requested during review of #101700 * Leave DF cells as zero values during limits tests When testing the cell limit we don't interact with the cell values at all, so we leave them at their zero values both to speed up tests, and to simplify and clarify that their values aren't used. * Set SQLCmd limit at object creation - don't mutate * Test that SQL node receives limit when built And that it receives it from the Grafana config * Improve TODO message for new Expression Parser * Fix failing test by always creating config on the Service	1 year ago
Sam Jewell	0eafd0641f	SQL Expressions: Simplify test code (#101718 ) Simplify, by retaining quotes when escaping query We also don't need to convert to string when passing to fmt.Sprintf a slice of Bytes is accepted by Sprintf instead.	1 year ago
Matheus Macabu	3539764008	Hackaton: Add more unit tests, take 3 (#101525 ) * serviceaccounts/secretscan: test Service more thoroughly * middleware/cookies: add tests for CookieOptions * anonymous/anonimpl: cover a couple more methods * components/imguploader: Implement WebDAV integration tests * components/apikeygen: also check IsValid method * bus: cover invalid callback signature cases * cloudmigration/objectstorage: add basic unit tests * login/social/connectors: add test case for GitHub OAuth fetch emails+orgs * expr/classic: cover more evaluator types in tests	1 year ago
Paulo Dias	2d2e595555	Alerting: Add multiple threshold operators (#99516 ) The following operators are being added: - Equal - Not Equal - Greater or Equal - Less or Equal - Within Range Inclusive - Outside Range Inclusive	1 year ago
Kyle Brandt	4d7b9a3c77	SQL Expressions: Improve response to frame conversion handling (#100625 ) - use types.Convert to get a more normalized type returned from GMS. After syncing with GMS maintainers, the underlying type of the row could be different things (e.g. int when unit32, so this calls the Convert method from the GMS types library to normalize the interface. - Clean up fieldValFromRow more - Use IsText to capture different string types - Add more types to test, also update test to use same cmp.Diff method as others --------- Co-authored-by: Sam Jewell <2903904+samjewell@users.noreply.github.com>	1 year ago
Kyle Brandt	c291ec7ba9	SQL Expressions: Include SQL Parser/Syntax error in the public message (#100725 ) fixes #100721	1 year ago
Kyle Brandt	f7588376df	SQL Expressions: (Chore) Update code for latest plugin-sdk data pkg (#100425 ) Use new NilAt and SetRefId methods	1 year ago
Kyle Brandt	6dc98dbbcc	SQL Expressions: Add str_to_date function and unskip test (#100226 )	1 year ago
Kyle Brandt	d196b789e2	SQL Expressions: Add more SQLNodes and funcs to allow list (#100227 ) sql_expr: Add more Nodes and funcs to allow list	1 year ago
Kyle Brandt	d64f41afdc	SQL Expressions: Re-implement feature using go-mysql-server (#99521 ) * Under feature flag `sqlExpressions` and is experimental * Excluded from arm32 * Will not work with the Query Service yet * Does not have limits in place yet * Does not working with alerting yet * Currently requires "prepare time series" Transform for time series viz --------- Co-authored-by: Sam Jewell <sam.jewell@grafana.com>	1 year ago
Karl Persson	76f052e8de	Requester: Remove duplicated function (#97038 ) * Remove duplicated function * Remove GetDisplayName from interface * Use GetName	1 year ago
Sam Jewell	1915efbc95	SQL Expressions: Simplify where code is being stubbed out (#96227 ) * Rename from DuckDB * Remove unused function	1 year ago
Sam Jewell	ea71201ddc	ServerSideExpressions: Disable SQL Expressions to prevent RCE and LFI vulnerability (#94942 ) * disable sql expressions remove duckdb ref * Run `make update-workspace` --------- Co-authored-by: Scott Lepper <scott.lepper@gmail.com>	2 years ago
Gábor Farkas	cbe1e7d63f	expr: add explicit strict-mode const (#94838 ) expr: add explicit strict-mode value	2 years ago
Gábor Farkas	34bb959835	expr: improved test (#94837 )	2 years ago
Gábor Farkas	2cea7af2f5	datasources: querier: handle reducer-settings-mode correctly (#94595 ) * datasources: querier: handle reducer-settings-mode correctly * Try to fix linting error "unnecessary leading newline (whitespace)" --------- Co-authored-by: Sam Jewell <sam.jewell@grafana.com>	2 years ago
Andrew Hackmann	3df62c28bb	InfluxDB: Add Influx to check if series need to be fixed labels (#93299 ) add influx to check if series need to be fixed labels	2 years ago
Dave Henderson	df3d8915ba	Chore: Bump Go to 1.23.0 (#92105 ) * chore: Bump Go to 1.23.0 Signed-off-by: Dave Henderson <dave.henderson@grafana.com> * update swagger files Signed-off-by: Dave Henderson <dave.henderson@grafana.com> * chore: update .bingo/README.md formatting to satisfy prettier Signed-off-by: Dave Henderson <dave.henderson@grafana.com> * chore(lint): Fix new lint errors found by golangci-lint 1.60.1 and Go 1.23 Signed-off-by: Dave Henderson <dave.henderson@grafana.com> * keep golden file * update openapi * add name to expected output * chore(lint): rearrange imports to a sensible order Signed-off-by: Dave Henderson <dave.henderson@grafana.com> --------- Signed-off-by: Dave Henderson <dave.henderson@grafana.com> Co-authored-by: Ryan McKinley <ryantxu@gmail.com>	2 years ago
Lu Shueh Chou	126169f3ca	Alerting: Add LogicOr operation option (#89258 ) --------- Co-authored-by: brendamuir <100768211+brendamuir@users.noreply.github.com>	2 years ago
Alexander Akhmetov	a32854549c	Alerting: Support median in reduce expressions (#91119 ) * Alerting: support median in reduce expressions	2 years ago
Yuri Tseretyan	9c05b30489	Chore: Add more logs and tracing to hysteresis flows (#90369 )	2 years ago
Fabrizio	612ebf5508	Dynatrace: Add to list of DS with custom label logic (#90258 )	2 years ago
Alexander Weaver	b3d863c11e	Expr: Make math expression scalars compliant with dataplane contract (#90350 ) * Specify frame type for scalars arbitrarily * Update alerting tests which assert on entire dataframe fields	2 years ago
Dave Henderson	6262c56132	chore(perf): Pre-allocate where possible (enable prealloc linter) (#88952 ) * chore(perf): Pre-allocate where possible (enable prealloc linter) Signed-off-by: Dave Henderson <dave.henderson@grafana.com> * fix TestAlertManagers_buildRedactedAMs Signed-off-by: Dave Henderson <dave.henderson@grafana.com> * prealloc a slice that appeared after rebase Signed-off-by: Dave Henderson <dave.henderson@grafana.com> --------- Signed-off-by: Dave Henderson <dave.henderson@grafana.com>	2 years ago
Kyle Brandt	82aa000e9d	SSE: (Chore) Update log line with context (trace) (#89172 ) Improves log line to help with debugging in Server Side Expressions. In particular, the traceId, datasourceType, and datasourceUid will now be included.	2 years ago
Ryan McKinley	99d8025829	Chore: Move identity and errutil to apimachinery module (#89116 )	2 years ago
Alexander Weaver	d004f8a98d	Alerting: Recording rules understands errors embedded in dataframes (#88946 ) * Make MakeDependencyError public for tests in another package * Create tests for errors in eval results * Extract logic to pull frame errors out into exported function * Maybe we can drop cyclomatic complexity lint suppression now? * extract frame errors and fail recording rules if frames contain error * Fix up retry logic to actually work * Do not retry non retryable errors	2 years ago
Marcus Efraimsson	2403665998	Chore: Remove legacydata package (#88790 ) * Chore: Remove legacydata package * remove unused dependency * sdk v0.234.0	2 years ago
Yuri Tseretyan	043e19afb5	SSE: Fix threshold unmarshal to avoid panic (#88521 )	2 years ago

1 2 3 4 5

210 Commits (4ea56b2cfba360e7cd01223cbeb38ee571a144d2)