3391 Commits (556219b19243ae5a954c77ec00311d98ea15c2b1)

Author	SHA1	Message	Date
Mario Trangoni	556219b192	pkg/tsdb: fix ineffassign isues	7 years ago
bergquist	03a9650c57	cli: adds os and arch headers ... this makes it possible for the plugin repo to provide the correct package if arch and os matters	7 years ago
Mario Trangoni	33ae8d35ea	comment unused struct fields	7 years ago
Mario Trangoni	c1742df9ac	remove unused variables detected by varcheck	7 years ago
bergquist	dbf61355b3	style: code simplifications	7 years ago
Dan Cech	3fedcb1e4b	cleanup, make sure users are always synced with ldap	7 years ago
Dan Cech	33760b5c3b	make sure user's default org is kept up to date	7 years ago
Dan Cech	00e74990ed	remove old comment	7 years ago
Dan Cech	857830d981	org role sync tests	7 years ago
Dan Cech	52503d9cb5	refactor authproxy & ldap integration, address comments	7 years ago
Dan Cech	c8a0c1e6b8	pass DN in ldap test	7 years ago
Dan Cech	daeba40b3b	tests for user auth module	7 years ago
Dan Cech	59f83ca5d8	fix ldap test	7 years ago
Dan Cech	e53e039b1b	restructure GetUserByAuthInfo	7 years ago
Dan Cech	c4168c2396	error handling	7 years ago
Dan Cech	65847da1df	use Result in GetAuthInfoQuery	7 years ago
Dan Cech	d837be91ec	switch to passing ReqContext as a property	7 years ago
Dan Cech	e53315dce8	cleanup	7 years ago
Dan Cech	a1b1d2fe80	switch to Result	7 years ago
Dan Cech	d5dd1c9bca	update auth proxy	7 years ago
Dan Cech	23f163e8cf	fixes	7 years ago
Dan Cech	d2eab2ff4c	fix tests	7 years ago
Dan Cech	1c5afa731f	shared library for managing external user accounts	7 years ago
Dan Cech	e07de80b75	Fix issues with metric reporting (#11518) ... * report active users in graphite stats * use bus to publish system stats * metrics: avoid using events unless we have to this commit also changes the default interval for updating the stats gauges. Seems like the old values was a product of previous metrics implementation	7 years ago
Sven Klemm	5dc36afe71	calculate datetime for timeFrom and timeTo macro in go	7 years ago
Karsten Weiss	ed46efa081	Use sort.Strings() (gosimple) ... This fixes: pkg/tsdb/cloudwatch/metric_find_query.go:257:2: should use sort.Strings(...) instead of sort.Sort(sort.StringSlice(...)) (S1032) pkg/tsdb/cloudwatch/metric_find_query.go:286:2: should use sort.Strings(...) instead of sort.Sort(sort.StringSlice(...)) (S1032) pkg/tsdb/cloudwatch/metric_find_query.go:315:2: should use sort.Strings(...) instead of sort.Sort(sort.StringSlice(...)) (S1032)	7 years ago
Karsten Weiss	25bb0b5569	Remove unused return value assignment (gosimple) ... This fixes: pkg/tsdb/sql_engine.go:54:6: should write version := engineCache.versions[dsInfo.Id] instead of version, _ := engineCache.versions[dsInfo.Id] (S1005)	7 years ago
Karsten Weiss	de084e5891	Remove unnecessary fmt.Sprintf() calls (gosimple) ... This fixes: pkg/services/sqlstore/migrator/migrations.go:116:18: the argument is already a string, there's no need to use fmt.Sprintf (S1025) pkg/services/sqlstore/migrator/types.go:49:16: the argument is already a string, there's no need to use fmt.Sprintf (S1025)	7 years ago
Karsten Weiss	5d95601720	Merge variable declaration with assignment (gosimple) ... This fixes: pkg/cmd/grafana-cli/commands/upgrade_all_command.go:56:3: should merge variable declaration with assignment on next line (S1021) pkg/login/ldap.go:406:4: should merge variable declaration with assignment on next line (S1021) pkg/services/sqlstore/migrator/dialect.go:87:2: should merge variable declaration with assignment on next line (S1021) pkg/services/sqlstore/migrator/dialect.go:165:2: should merge variable declaration with assignment on next line (S1021) pkg/tsdb/cloudwatch/metric_find_query_test.go:185:2: should merge variable declaration with assignment on next line (S1021)	7 years ago
Karsten Weiss	4d6386e97b	Use fmt.Errorf() (gosimple) ... This fixes: pkg/cmd/grafana-cli/commands/install_command.go:36:11: should use fmt.Errorf(...) instead of errors.New(fmt.Sprintf(...)) (S1028) pkg/models/org_user.go:53:11: should use fmt.Errorf(...) instead of errors.New(fmt.Sprintf(...)) (S1028) pkg/services/notifications/mailer.go:138:16: should use fmt.Errorf(...) instead of errors.New(fmt.Sprintf(...)) (S1028)	7 years ago
Karsten Weiss	4d87cb03c5	Simplify make() (gosimple) ... This fixes: pkg/api/http_server.go:142:89: should use make(map[string]func(*http.Server, *tls.Conn, http.Handler)) instead (S1019) pkg/services/alerting/scheduler.go:18:30: should use make(map[int64]*Job) instead (S1019) pkg/services/alerting/scheduler.go:26:31: should use make(map[int64]*Job) instead (S1019)	7 years ago
Karsten Weiss	cb3b9f8b66	Use raw strings to avoid double escapes (gosimple) ... This fixes: pkg/services/alerting/rule.go:58:21: should use raw string (`...`) with regexp.MustCompile to avoid having to escape twice (S1007\) pkg/services/alerting/rule.go:59:21: should use raw string (`...`) with regexp.MustCompile to avoid having to escape twice (S1007)	7 years ago
Karsten Weiss	da5654ad04	Simplify if expression (gosimple) ... pkg/util/shortid_generator.go:20:2: should use 'return <expr>' instead of 'if <expr> { return <bool> }; return <bool>' (S1008)	7 years ago
Karsten Weiss	f61e69ce75	Simplify comparison to bool constant (gosimple) ... This fixes: build.go:553:6: should omit comparison to bool constant, can be simplified to !strings.Contains(path, ".sha256") (S1002) pkg/cmd/grafana-cli/commands/ls_command.go:27:5: should omit comparison to bool constant, can be simplified to !pluginDirInfo.IsDir() (S1002) pkg/components/dynmap/dynmap_test.go:24:5: should omit comparison to bool constant, can be simplified to !value (S1002) pkg/components/dynmap/dynmap_test.go:122:14: should omit comparison to bool constant, can be simplified to b (S1002) pkg/components/dynmap/dynmap_test.go:125:14: should omit comparison to bool constant, can be simplified to !b (S1002) pkg/components/dynmap/dynmap_test.go:128:14: should omit comparison to bool constant, can be simplified to !b (S1002) pkg/models/org_user.go:51:5: should omit comparison to bool constant, can be simplified to !(*r).IsValid() (S1002) pkg/plugins/datasource/wrapper/datasource_plugin_wrapper_test.go:77:12: should omit comparison to bool constant, can be simplified to !haveBool (S1002) pkg/services/alerting/conditions/evaluator.go:23:9: should omit comparison to bool constant, can be simplified to !reducedValue.Valid (S1002) pkg/services/alerting/conditions/evaluator.go:48:5: should omit comparison to bool constant, can be simplified to !reducedValue.Valid (S1002) pkg/services/alerting/conditions/evaluator.go:91:5: should omit comparison to bool constant, can be simplified to !reducedValue.Valid (S1002) pkg/services/alerting/conditions/query.go:56:6: should omit comparison to bool constant, can be simplified to !reducedValue.Valid (S1002) pkg/services/alerting/extractor.go:107:20: should omit comparison to bool constant, can be simplified to !enabled.MustBool() (S1002) pkg/services/alerting/notifiers/telegram.go:222:41: should omit comparison to bool constant, can be simplified to this.UploadImage (S1002) pkg/services/sqlstore/apikey.go:58:12: should omit comparison to bool constant, can be simplified to !has (S1002) pkg/services/sqlstore/apikey.go:72:12: should omit comparison to bool constant, can be simplified to !has (S1002) pkg/services/sqlstore/dashboard.go:66:33: should omit comparison to bool constant, can be simplified to !cmd.Overwrite (S1002) pkg/services/sqlstore/dashboard.go:175:12: should omit comparison to bool constant, can be simplified to !has (S1002) pkg/services/sqlstore/dashboard.go:311:13: should omit comparison to bool constant, can be simplified to !has (S1002) pkg/services/sqlstore/dashboard.go:444:12: should omit comparison to bool constant, can be simplified to !exists (S1002) pkg/services/sqlstore/dashboard.go:472:12: should omit comparison to bool constant, can be simplified to !exists (S1002) pkg/services/sqlstore/dashboard.go:554:32: should omit comparison to bool constant, can be simplified to !cmd.Overwrite (S1002) pkg/services/sqlstore/dashboard_snapshot.go:83:12: should omit comparison to bool constant, can be simplified to !has (S1002) pkg/services/sqlstore/plugin_setting.go:39:12: should omit comparison to bool constant, can be simplified to !has (S1002) pkg/services/sqlstore/quota.go:34:12: should omit comparison to bool constant, can be simplified to !has (S1002) pkg/services/sqlstore/quota.go:111:6: should omit comparison to bool constant, can be simplified to !has (S1002) pkg/services/sqlstore/quota.go:136:12: should omit comparison to bool constant, can be simplified to !has (S1002) pkg/services/sqlstore/quota.go:213:6: should omit comparison to bool constant, can be simplified to !has (S1002) pkg/services/sqlstore/temp_user.go:129:12: should omit comparison to bool constant, can be simplified to !has (S1002) pkg/services/sqlstore/user.go:157:12: should omit comparison to bool constant, can be simplified to !has (S1002) pkg/services/sqlstore/user.go:182:5: should omit comparison to bool constant, can be simplified to !has (S1002) pkg/services/sqlstore/user.go:191:12: should omit comparison to bool constant, can be simplified to !has (S1002) pkg/services/sqlstore/user.go:212:12: should omit comparison to bool constant, can be simplified to !has (S1002) pkg/services/sqlstore/user.go:307:12: should omit comparison to bool constant, can be simplified to !has (S1002) pkg/social/generic_oauth.go:185:5: should omit comparison to bool constant, can be simplified to !s.extractToken(&data, token) (S1002) pkg/tsdb/mssql/mssql.go:148:39: should omit comparison to bool constant, can be simplified to ok (S1002) pkg/tsdb/mssql/mssql.go:212:6: should omit comparison to bool constant, can be simplified to !query.Model.Get("fillNull").MustBool(false) (S1002) pkg/tsdb/mssql/mssql.go:247:56: should omit comparison to bool constant, can be simplified to ok (S1002) pkg/tsdb/mssql/mssql.go:274:7: should omit comparison to bool constant, can be simplified to !exist (S1002) pkg/tsdb/mssql/mssql.go:282:8: should omit comparison to bool constant, can be simplified to !exist (S1002) pkg/tsdb/mysql/mysql.go:221:6: should omit comparison to bool constant, can be simplified to !query.Model.Get("fillNull").MustBool(false) (S1002) pkg/tsdb/mysql/mysql.go:256:56: should omit comparison to bool constant, can be simplified to ok (S1002) pkg/tsdb/mysql/mysql.go:283:7: should omit comparison to bool constant, can be simplified to !exist (S1002) pkg/tsdb/mysql/mysql.go:291:8: should omit comparison to bool constant, can be simplified to !exist (S1002) pkg/tsdb/postgres/postgres.go:134:39: should omit comparison to bool constant, can be simplified to ok (S1002) pkg/tsdb/postgres/postgres.go:201:6: should omit comparison to bool constant, can be simplified to !query.Model.Get("fillNull").MustBool(false) (S1002) pkg/tsdb/postgres/postgres.go:236:56: should omit comparison to bool constant, can be simplified to ok (S1002) pkg/tsdb/postgres/postgres.go:263:7: should omit comparison to bool constant, can be simplified to !exist (S1002) pkg/tsdb/postgres/postgres.go:271:8: should omit comparison to bool constant, can be simplified to !exist (S1002)	7 years ago
Karsten Weiss	be2d635078	Simplify error returns (gosimple) ... This fixes: pkg/api/avatar/avatar.go:261:2: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) pkg/log/file.go:102:2: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) pkg/metrics/graphitebridge/graphite.go:298:2: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) pkg/services/provisioning/provisioning.go:23:2: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) pkg/services/sqlstore/alert_notification.go:27:3: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) pkg/services/sqlstore/alert_notification.go:27:3: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) pkg/services/sqlstore/annotation.go:105:3: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) pkg/services/sqlstore/annotation.go:105:3: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) pkg/services/sqlstore/dashboard.go:351:2: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) pkg/services/sqlstore/dashboard.go:435:2: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) pkg/services/sqlstore/dashboard_acl.go:38:3: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) pkg/services/sqlstore/dashboard_acl.go:38:3: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) pkg/services/sqlstore/stats.go:22:2: 'if err != nil { return err }; return err' can be simplified to 'return err' (S1013) pkg/services/sqlstore/team.go:213:2: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) pkg/services/sqlstore/user.go:256:3: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) pkg/services/sqlstore/user.go:256:3: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) pkg/services/sqlstore/user.go:274:3: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) pkg/services/sqlstore/user.go:274:3: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) pkg/services/sqlstore/user.go:482:3: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) pkg/services/sqlstore/user.go:482:3: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013)	7 years ago
Karsten Weiss	c5a09a3dc1	Remove redundant break statements (gosimple) ... This fixes: pkg/components/dynmap/dynmap.go:588:3: redundant break statement (S1023) pkg/components/dynmap/dynmap.go:610:3: redundant break statement (S1023) pkg/components/dynmap/dynmap.go:641:3: redundant break statement (S1023) pkg/components/dynmap/dynmap.go:690:3: redundant break statement (S1023) pkg/components/dynmap/dynmap.go:712:3: redundant break statement (S1023) pkg/components/dynmap/dynmap.go:749:3: redundant break statement (S1023) pkg/components/dynmap/dynmap.go:785:3: redundant break statement (S1023) pkg/tsdb/cloudwatch/cloudwatch.go:74:3: redundant break statement (S1023) pkg/tsdb/cloudwatch/cloudwatch.go:77:3: redundant break statement (S1023) pkg/tsdb/cloudwatch/cloudwatch.go:82:3: redundant break statement (S1023) pkg/tsdb/cloudwatch/metric_find_query.go:178:3: redundant break statement (S1023) pkg/tsdb/cloudwatch/metric_find_query.go:181:3: redundant break statement (S1023) pkg/tsdb/cloudwatch/metric_find_query.go:184:3: redundant break statement (S1023) pkg/tsdb/cloudwatch/metric_find_query.go:187:3: redundant break statement (S1023) pkg/tsdb/cloudwatch/metric_find_query.go:190:3: redundant break statement (S1023) pkg/tsdb/cloudwatch/metric_find_query.go:193:3: redundant break statement (S1023) pkg/tsdb/cloudwatch/metric_find_query.go:196:3: redundant break statement (S1023)	7 years ago
Mario Trangoni	ce941a004d	fix unconvert issues	7 years ago
Sven Klemm	a2a7d3d436	add GetFromAsTimeUTC and GetToAsTimeUTC and use them in timeFilter macro	7 years ago
David Kaltschmidt	5a29c17282	moved version in help menu to top	7 years ago
David Kaltschmidt	712212d6aa	Show Grafana version and build in Help menu ... * establishes Help as the single place to look for the Grafana version * version is passed as menu sub-title to side menu * added rendering of sub-title, plus styles * sub-title was used by profile menu (its value is the login string), but was not shown; now showing this value on condition that login name is different from user name	7 years ago
Daniel Lee	9337972a0f	sqlds: fix text in comments for tests	7 years ago
Sven Klemm	6d3da9a73d	remove postgresversion and convert unix timestamp in go	7 years ago
Kim Christensen	7534f0bff6	Support deleting empty playlist	7 years ago
Matthew McGinn	ee623e2091	Grafana-CLI: mention the plugins directory is not writable on failure	7 years ago
Sven Klemm	9b61ffb48a	make timefilter macro aware of pg version	7 years ago
Mario Trangoni	91fb2e07ce	pkg: fix codespell issues	7 years ago
Marcus Efraimsson	ff4e38c1d8	provisioned dashboard validation should be made when importing a dashboard ... Had to add the validate before save command before validating provisioned dashboard so that the import would get a proper dashboard id	7 years ago
Marcus Efraimsson	79d8937ce5	provisioned dashboard validation should not be made from provisioning service ... Provisioned dashboard validation should not be made when creating/updating a folder or when provisioning service are trying to provision/create/update dashboard	7 years ago
Marcus Efraimsson	4f44376564	remove comment/unused variable	7 years ago
Patrick O'Carroll	9ad8a77a21	ordered user orgs alphabeticaly fixes #11556	7 years ago