grafana

Commit Graph

Author	SHA1	Message	Date
Yuri Tseretyan	9735a8a080	Alerting: Distinguish conflict violation errors (#86634 ) * update generator to set ID = 0 and do not set 0 if unique is needed * return proper message when the constraint violation	2 years ago
Julian Siebert	14f018e3fc	Docs: Use correct description for "og_priority" (#80889 )	2 years ago
Kristina	2247d6c415	Short Links: Add setting for changing expiration time (#86003 ) * Add setting for changing shortlink expiration time * Add docs, add better language * put all the numbers in the duration 🤷 * 🙄 * update language to be correct and clear * Add max limit and more documentation	2 years ago
Steve Simpson	54290f2ac4	Alerting: Fix TestRouteGetRuleStatuses as much as possible. (#86666 ) This test has been skipped for a long time, so it doesn't work anymore. I've fixed the test so it works again, but left some tests disabled which were apparently flaky. If we see the other test cases flaking, we'll have to disable it again. Fixes: - Use fake access control for most test cases, and real one for FGAC test cases. - Check that "file" in API responses the full folder path, not folder title.	2 years ago
Timur Olzhabayev	951916c668	Chore: Making the plugin install commands respect the config parameter (#86578 ) Currently the grafana cli plugin commands are not reacting to the --config parameter. This PR make it possible to use config to define the plugin endpoints via config as an alternative to providing the --repo flag.	2 years ago
Steve Simpson	f07f48616a	Alerting: Fix panic when limit_alerts=0. (#86640 ) Oversight in the TopK function meant if k=0, then we'd panic when checking element zero in the heap, because no items are ever allowed into the heap.	2 years ago
Michael Mandrus	45a7f649fe	CMS: Create local implementation of cloud migration for dev use (#86637 ) * add developer mode property to config * create cms stub * cleanup * implement and wire up gcom stub * fix errors * don't document the flag	2 years ago
Andreas Christou	ae84d16a6f	MSSQL: Simplify proxy logic (#86278 ) * Simplify proxy dialer creation - Set new dialer on connector - Create MSSQL connector in a similar fashion to postgres * Update test * Fix lint * More lint * Use correct driver name	2 years ago
Steve Simpson	6ea97e41fb	Alerting: Consistently return Prometheus-style responses from rules APIs. (#86600 ) * Alerting: Consistently return Prometheus-style responses from rules APIs. This commit is part refactor and part fix. The /rules API occasionally returns error responses which are inconsistent with other error responses. This fixes that, and adds a function to map from Prometheus error type and HTTP code. * Fix integration tests * Linter happiness * Make linter more happy * Fix up one more place returning non-Prometheus responses	2 years ago
Robert Horvath	86a9533863	Chore: Replace backend platform codeownership (#86010 ) * Replace backend platform codeownership * fix go.mod with work sync * fix go.mod Signed-off-by: Dave Henderson <dave.henderson@grafana.com> --------- Signed-off-by: Dave Henderson <dave.henderson@grafana.com> Co-authored-by: Dave Henderson <dave.henderson@grafana.com>	2 years ago
Eric Leijonmarck	ddabef9895	RBAC: Add actionsets struct and write path (#86108 ) * Add actionsets struct and failing test * update from review * review comments * review comments update * refactor: create interface * actionset service * fix tests * move from wireoss to wire * Apply suggestions from code review remove unnecessary comments Co-authored-by: Ieva <ieva.vasiljeva@grafana.com> * nil for the actionsetservice * Revert "nil for the actionsetservice" This reverts commit `e3d3cc8171`. --------- Co-authored-by: Ieva <ieva.vasiljeva@grafana.com>	2 years ago
Santiago	529f55cfe8	Alerting: Remove isDefault field from receivers (Alertmanager configuration) (#86605 ) Alerting: Remove isDefault field from receivers in the Alertmanager configuration	2 years ago
Santiago	309a7e7684	Alerting: Implement SaveAndApplyDefaultConfig in the remote Alertmanager struct (#85005 ) * Alerting: Implement SaveAndApplyDefaultConfig in the remote Alertmanager struct * send the hash of the encrypted configuration * tests, default config hash in AM struct * add missing default config to test * restore build directory * go work file... * fix broken test * remove unnecessary conversion to []byte * go work again... * make things work again with latest main branch changes * update error messages in tests for decrypting config	2 years ago
Santiago	a2ce8fefed	Alerting: Use a struct when sending a Grafana AM configuration to the remote Alertmanager (#86451 ) * Alerting: Use a struct when sending a Grafana AM configuration to the remote Alertmanager * remove '-distroless' from mimir image name	2 years ago
Steve Simpson	5f7612834e	Alerting: Refactoring in api_prometheus.go to allow code reuse. (#86575 ) Preparing these functions to be used by some other part of the codebase, which does not have a `contextmodel.ReqContext`, only the normal request structure (`url.Values`, etc). This is slightly messy because of how Grafana allows url parameters to be in the URL or in the request body, so we need to make sure to invoke the form parsing logic in `ReqContext`.	2 years ago
Alex Khomenko	44e1bce55a	Feature toggles: Remove dashboardEmbed toggle (#86587 )	2 years ago
Steve Simpson	73873f5a8a	Alerting: Optimize rule status gathering APIs when a limit is applied. (#86568 ) * Alerting: Optimize rule status gathering APIs when a limit is applied. The frontend very commonly calls the `/rules` API with `limit_alerts=16`. When there are a very large number of alert instances present, this API is quite slow to respond, and profiling suggests that a big part of the problem is sorting the alerts by importance, in order to select the first 16. This changes the application of the limit to use a more efficient heap-based top-k algorithm. This maintains a slice of only the highest ranked items whilst iterating the full set of alert instances, which substantially reduces the number of comparisons needed. This is particularly effective, as the `AlertsByImportance` comparison is quite complex. I've included a benchmark to compare the new TopK function to the existing Sort/limit strategy. It shows that for small limits, the new approach is much faster, especially at high numbers of alerts, e.g. 100K alerts / limit 16: 1.91s vs 0.02s (-99%) For situations where there is no effective limit, sorting is marginally faster, therefore in the API implementation, if there is either a) no limit or b) no effective limit, then we just sort the alerts as before. There is also a space overhead using a heap which would matter for large limits. * Remove commented test cases * Make linter happy	2 years ago
Ryan McKinley	5a8384a245	QueryService: Add feature toggles to better support testing (#86493 )	2 years ago
Will Browne	8a5c0cfdc0	Plugins: Pass cancellable context during API server creation (#86545 )	2 years ago
Sofia Papagiannaki	aa825f5dee	Chore: Fix Swagger/OpenAPI instructions (#86541 ) Update README.md	2 years ago
Matthew Jacobson	a20197229e	Alerting: Prevent simplified routing zero duration GroupInterval and RepeatInterval (#86561 ) Prevent zero duration GroupInterval and RepeatInterval	2 years ago
Matthew Jacobson	71445002b7	Alerting: Fix simplified routing group by override (#86552 ) * Alerting: Fix simplified routing custom group by override Custom group by overrides for simplified routing were missing required fields GroupBy and GroupByAll normally set during upstream Route validation. This fix ensures those missing fields are applied to the generated routes. * Inline GroupBy and GroupByAll initialization instead of normalize after	2 years ago
ismail simsek	28a683cf28	InfluxDB: Remove influxdbSqlSupport feature toggle (#86518 ) Remove influxdbSqlSupport feature toggle	2 years ago
Vanilla	817f787947	Cli: Check missing plugin parameter of plugin update command (#86410 ) Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com>	2 years ago
Andres Martinez Gotor	eac02a61e1	Return plugin error when requesting settings (#86052 )	2 years ago
Mihai Doarna	57848bbe23	Auth: encrypt/decrypt SAML secrets in SSO settings service (#85253 ) encrypt/decrypt saml secrets in sso settings service	2 years ago
Andres Martinez Gotor	0f4a47b180	Plugin load errors: Add more well-known errors (#85960 )	2 years ago
Andreas Christou	420067a7e1	MSSQL: Add `SQL_VARIANT` converter and update test (#85823 ) Add SQL_VARIANT converter and update test	2 years ago
Michael Mandrus	df4c8c3cbc	CloudMigrations: Move business logic out of api layer (#86406 ) * move run migration to the cloudmigrationimpl layer * add migration run list logic down a layer * remove useless comments * pull cms calls into their own service	2 years ago
Kyle Brandt	46efe41e33	Prometheus: (Instrumentation) Add rawExpr (pre-interpolation) to traces (#86449 )	2 years ago
Will Browne	dceb83ab42	Plugins: Expose backendplugin for client proto interface (#86207 ) * first pass * tidy * add err check * remove comment * simplify * remove unused stuff * add backend() * use SDK commit * add codeowners for go.mod * fix go.mod * bump SDK * go work sync	2 years ago
Leonor Oliveira	9baf96dbd2	Storage: dualwriter update implementation (#85844 ) * Add update methods for the dual writer * improve errors * [WIP] add tests for the update method * Move example package to its own package so it can be used by the rest package. Finish tests * Add codeowners * Use Pod as a dummy resource * :int * Lint * [REVIEW] rename var * [REVIEW] don't rely on legacy storage at all in mode4 * Update pkg/apiserver/rest/dualwriter_mode2.go Co-authored-by: Arati R. <33031346+suntala@users.noreply.github.com> * [REVIEW] improve comment * Update pkg/apiserver/rest/dualwriter_mode1.go Co-authored-by: Dan Cech <dcech@grafana.com> * [REVIEW] improve mode3 * Lint * Move test files * Update pkg/apiserver/rest/dualwriter_mode2.go Co-authored-by: Arati R. <33031346+suntala@users.noreply.github.com> * Lint * Update pkg/apiserver/rest/dualwriter_mode4_test.go Co-authored-by: Arati R. <33031346+suntala@users.noreply.github.com> * Fix error * Lint * Update pkg/apiserver/rest/dualwriter_mode2.go Co-authored-by: Arati R. <33031346+suntala@users.noreply.github.com> * Don't set the flag to true as updatedObj creates an object in case it's not found * Lint * Lint * Add tests on update * Lint --------- Co-authored-by: Arati R. <33031346+suntala@users.noreply.github.com> Co-authored-by: Dan Cech <dcech@grafana.com>	2 years ago
Aaron Godin	d409d8e860	IAM - Fix error messages for resource permissions endpoints (#85773 ) * IAM: fix many error messages in access-related code to provide more information * Remove debug statement * Refactor resourcepermissions package to use errutil * Replace a few more errors with errutil and wrap errors found in users and teams services * Apply diff of openAPI spec	2 years ago
Karl Persson	1a6777cb93	User: use update function for password updates (#86419 ) * Update password through Update function instead * Remove duplicated to lower * Refactor password code	2 years ago
Andre Pereira	93c24403b3	Explore: Move app to under explore > traces (#86436 ) Move app to under explore > traces	2 years ago
Kristin Laemmert	03b795844c	SQLStore: Improve recursive CTE support detection (#86397 ) sqlstore: improve recursive CTE support detection Vitess returns a not supported error, not a parse error Co-authored-by: Derek Perkins <derek@nozzle.io>	2 years ago
Leonor Oliveira	dcfaf7e434	Storage: Add dualwriter test mocks (#86243 ) * WIP: add mocks for dual writer * Test dualwriter mode1 * Re-add non implementation errors * Use testify assert * Write tests for mode2. * Lint * Remove comment * Update pkg/apiserver/rest/dualwriter_mode2_test.go Co-authored-by: Arati R. <33031346+suntala@users.noreply.github.com> * [REVIEW improve readability and call fn legacy fn * [REVIEW] rename mocks and setupFns * [REVIEW add missing test case * [REVIEW] add test case with getting object from storage and not legacy * Add deleteCollection * Test deleteCollection * Rename file --------- Co-authored-by: Arati R. <33031346+suntala@users.noreply.github.com>	2 years ago
Yuri Tseretyan	e9d6135e33	SSE: Threshold expression to use simple functions (#86062 ) * replace math expression with predicates	2 years ago
Eric Leijonmarck	9c1ef8b16e	Auth: Remove caseinsensitive check on update user (#86286 ) * Removal: case insensitive check on update * refactor and removal of test for duplicate user * refactor to still shadow user variable	2 years ago
Matthew Jacobson	533bed6d94	Alerting: Fix simplified routes '...' groupBy creating invalid routes (#86006 ) * Alerting: Fix simplified routes '...' groupBy creating invalid routes There were a few ways to go about this fix: 1. Modifying our copy of upstream validation to allow this 2. Modify our notification settings validation to prevent this 3. Normalize group by on save 4. Normalized group by on generate Option 4. was chosen as the others have a mix of the following cons: - Generated routes risk being incompatible with upstream/remote AM - Awkward FE UX when using '...' - Rule definition changing after save and potential pitfalls with TF With option 4. generated routes stay compatible with external/remote AMs, FE doesn't need to change as we allow mixed '...' and custom label groupBys, and settings we save to db are the same ones requested. In addition, it has the slight benefit of allowing us to hide the internal implementation details of `alertname, grafana_folder` from the user in the future, since we don't need to send them with every FE or TF request. * Safer use of DefaultNotificationSettingsGroupBy * Fix missed API tests	2 years ago
Arati R	79eab65f94	Storage: Add mode-specific DeleteCollection implementations (#86065 ) * Add DeleteCollection methods to modes 1 and 4 * Add DeleteCollection implementations for modes 2 and 3	2 years ago
Nick Richmond	d3fee607e2	Expressions: sort numeric metrics behind feature toggle (#85911 ) * feat: sort numeric metrics behind feature toggle * chore: upgrade `dataplane/sdata` to latest tag * chore: `go work sync`	2 years ago
Ieva	036f826b87	AuthZ: Further protect admin endpoints (#86285 ) * only users with Grafana Admin role can grant/revoke Grafana Admin role * check permissions to user amdin endpoints globally * allow checking global permissions for service accounts * use a middleware for checking whether the caller is Grafana Admin	2 years ago
Karl Persson	0f06120b56	User: Clean up update functions (#86341 ) * User: remove unused function * User: Remove UpdatePermissions and support IsGrafanaAdmin flag in Update function instead * User: Remove Disable function and use Update instead	2 years ago
owensmallwood	8c8885ef23	Storage Api: Adds traces (#85391 ) - adds traces and improved logging to the unified storage server - add a configurable logger to the gRPC server service	2 years ago
Kyle Brandt	a12669951b	Prometheus: Add BE support for Adhoc Filters (#85969 ) --------- Co-authored-by: ismail simsek <ismailsimsek09@gmail.com>	2 years ago
Karl Persson	8520892923	User: Fix GetByID (#86282 ) * Auth: Remove unused lookup param * Remove case sensitive lookup for GetByID	2 years ago
Gábor Farkas	2379498228	mysql additional decoupling steps (#86168 ) * mysql additional decoupling steps * updated snapshot test	2 years ago
Gábor Farkas	9015bfa3f4	mssql: decouple sqleng (#86130 ) * mssql: decouple sqleng * fix codeowners-file	2 years ago
Ryan McKinley	ba510d1a7d	Playlists: Enable kubernetesPlaylists by default in OSS (#86259 )	2 years ago

1 2 3 4 5 ...

13032 Commits (59eb302fc14e54b1889a5df0431d97b51f25bd7f)