1684 Commits (5be04f53368cce32a2bc7642957504b787187cfb)

Author	SHA1	Message	Date
Emil Tullstedt	647997cc4c	Alerting: Fix flaky test (#55551) ... The length of the identifier from the underlying library is 9 or more characters depending on the rate at which the identifiers are generated. See https://pkg.go.dev/github.com/teris-io/shortid The test previously made the assumption that the length will always be 10, which would intermittently fail.	3 years ago
ying-jeanne	7b4cea8151	Chore: StoreSplit tag service (#55453) ... * move tag service outside * fix dashboard * fix test * lint * fix linter * remove spew	3 years ago
Ieva	6d5bdf12e8	resolve merge conflicts (#55503)	3 years ago
Serge Zaitsev	305d494902	Chore: Switch over to team.Service instead of sqlstore (#55497) ... * switch to using team service * trying to fix tests * more tests to fix * add missing teamtest package	3 years ago
Marcus Efraimsson	862a6a2fa6	Logging: Introduce API for contextual logging (#55198) ... Introduces a FromContext method on the log.Logger interface that allows contextual key/value pairs to be attached, e.g. per request, so that any logger using this API will automatically get the per request context attached. The proposal makes the traceID available for contextual logger , if available, and would allow logs originating from a certain HTTP request to be correlated with traceID. In addition, when tracing not enabled, skip adding traceID=00000000000000000000000000000000 to logs.	3 years ago
idafurjes	eff4daacaf	Bug: Rollback change in search (#55443)	3 years ago
Serge Zaitsev	8f1e2ed658	Chore: Split temporary user (invite) service (#55397) ... * Chore: Split temporary users * change references to tempuser service * fix api tests * restore tests	3 years ago
idafurjes	7ce7c9b64c	Chore: Move SearchOrgs to org service (#55416) ... * Chore: Move SearchOrgs to org service * Fix lint * Fix lint 2	3 years ago
Serge Zaitsev	96b032e103	Chore: Split dashboard thumbnail service (#55344) ... * Chore: split dashboard thumbnail service * fix typo * move tests * make linter happy	3 years ago
Sofia Papagiannaki	754eea20b3	Chore: SQL store split for annotations (#55089) ... * Chore: SQL store split for annotations * Apply suggestion from code review	3 years ago
ying-jeanne	e4741ce8d6	remove datasource from sqlstore (#55288)	3 years ago
Piotr Jamróz	7352c181c2	Migrate user_id to BIGINT (#55084)	3 years ago
Alexander Weaver	9f45e2e706	Alerting: Fix legacy migration crash when rule name is too long (#55053) ... * Extract standardized UID field length to constant * Extract default length to constant * Truncate rule names that are too long * Add tests for name normalization * Fix whitespace lint error * Another linter fix * Empty commit to kick build	3 years ago
Emil Tullstedt	b287047052	Chore: Upgrade Go to 1.19.1 (#54902) ... * WIP * Set public_suffix to a pre Ruby 2.6 version * we don't need to install python * Stretch->Buster * Bump versions in lib.star * Manually update linter Sort of messy, but the .mod-file need to contain all dependencies that use 1.16+ features, otherwise they're assumed to be compiled with -lang=go1.16 and cannot access generics et al. Bingo doesn't seem to understand that, but it's possible to manually update things to get Bingo happy. * undo reformatting * Various lint improvements * More from the linter * goimports -w ./pkg/ * Disable gocritic * Add/modify linter exceptions * lint + flatten nested list Go 1.19 doesn't support nested lists, and there wasn't an obvious workaround. https://go.dev/doc/comment#lists	3 years ago
Misi	c5be9605a2	Chore: Use TimeNow instead of time.Now in user sql store to make it testable (#54983)	3 years ago
Joe Blubaugh	22c937340e	Revert "Alerting: Write and Delete multiple alert instances. (#54072)" (#54885) ... This reverts commit 5e4fd94413.	3 years ago
Carl Bergquist	b4e3c89f60	instrumentation: dont instrument ErrSkip at all (#54880) ... Signed-off-by: bergquist <carl.bergquist@gmail.com>	3 years ago
mhuangwm	39102c6656	Admin: Add support to configure default admin email (#54363)	3 years ago
Carl Bergquist	78978048c3	Instrumentation: log the total number of db queries per request (#54647) ... Signed-off-by: bergquist <carl.bergquist@gmail.com> Co-authored-by: Emil Tullstedt <emil.tullstedt@grafana.com> Co-authored-by: Dave Henderson <dave.henderson@grafana.com>	3 years ago
linoman	d2bb72fb3c	Login: Remove single admin team restriction (#54534) ... * Remove single member team restriction * Add label when permissions list is empty * Fix unit tests * Add co-author. Co-authored-by: Ieva <ieva.vasiljeva@grafana.com>	3 years ago
Joe Blubaugh	5e4fd94413	Alerting: Write and Delete multiple alert instances. (#54072) ... Prior to this change, all alert instance writes and deletes happened individually, in their own database transaction. This change batches up writes or deletes for a given rule's evaluation loop into a single transaction before applying it. Before: ``` goos: darwin goarch: arm64 pkg: github.com/grafana/grafana/pkg/services/ngalert/store BenchmarkAlertInstanceOperations-8 398 2991381 ns/op 1133537 B/op 27703 allocs/op --- BENCH: BenchmarkAlertInstanceOperations-8 util.go:127: alert definition: {orgID: 1, UID: FovKXiRVzm} with title: "an alert definition FTvFXmRVkz" interval: 60 created util.go:127: alert definition: {orgID: 1, UID: foDFXmRVkm} with title: "an alert definition fovFXmRVkz" interval: 60 created util.go:127: alert definition: {orgID: 1, UID: VQvFuigVkm} with title: "an alert definition VwDKXmR4kz" interval: 60 created PASS ok github.com/grafana/grafana/pkg/services/ngalert/store 1.619s ``` After: ``` goos: darwin goarch: arm64 pkg: github.com/grafana/grafana/pkg/services/ngalert/store BenchmarkAlertInstanceOperations-8 1440 816484 ns/op 352297 B/op 6529 allocs/op --- BENCH: BenchmarkAlertInstanceOperations-8 util.go:127: alert definition: {orgID: 1, UID: 302r_igVzm} with title: "an alert definition q0h9lmR4zz" interval: 60 created util.go:127: alert definition: {orgID: 1, UID: 71hrlmR4km} with title: "an alert definition nJ29_mR4zz" interval: 60 created util.go:127: alert definition: {orgID: 1, UID: Cahr_mR4zm} with title: "an alert definition ja2rlmg4zz" interval: 60 created PASS ok github.com/grafana/grafana/pkg/services/ngalert/store 1.383s ``` So we cut time by about 75% and memory allocations by about 60% when storing and deleting 100 instances. This change also updates some of our tests so that they run successfully against postgreSQL - we were using random Int64s, but postgres integers, which our tables use, max out at 2^31-1	3 years ago
Serge Zaitsev	927ddf9376	Chore: Move login attempt methods to separate service (#54479) ... * Chore: Move login attempt methods to separate service * attempt to fix tests * fix syntax * better time mocking * initialise now func	3 years ago
Dave Henderson	713075c494	Metrics: Fixed `grafana_database_conn_*` metrics, and added new `go_sql_stats_*` metrics as eventual replacement (#54405) ... * metrics: Fix broken DBStats metrics Signed-off-by: Dave Henderson <dave.henderson@grafana.com> * Register the sqlstats metrics by default Signed-off-by: Dave Henderson <dave.henderson@grafana.com> Signed-off-by: Dave Henderson <dave.henderson@grafana.com>	3 years ago
ying-jeanne	6227528ea0	Chore: SQL Store Split of datasource (#54262) ... * refectory datasource * fix linter	3 years ago
ying-jeanne	fd01161bcc	Chore: replace xorm by sqlx in dashboardversion service (#53869)	3 years ago
Valério Valério	b5142832fa	Alerting: Fix saving of screenshots uploaded with a signed url (#53933) ... The URL of screenshots uploaded to external image storages can be optionally signed, resulting in a long string (800+ chars).	3 years ago
ying-jeanne	4dbe0b4f02	Chore: Move updateorg out of sqlstore (#54111) ... * Chore: move updateorg out of sqlstore * fix api test	3 years ago
Jo	4a9137ac40	API Keys: Add revocation for SATs (#53896) ... * add apikey is_revoked field * add token store tests * Apply suggestions from code review * remove unused fields	3 years ago
ying-jeanne	82b63688d2	Chore: remove xorm from preference (#53803) ... * Chore: remove xorm from preference * separte feature toggle * fix comments * fix comments * remove the dublicated namedexec	3 years ago
ying-jeanne	c7212643c2	add sqlx_store into star service (#53430)	3 years ago
ying-jeanne	25de383540	Chore: Replace xorm with sqlx (#52575) ... * Change of sqlstore to use sqlx * Use sqlx in the playlist store * Refectory of the interface * update playlist service * go mod tidy * some refectory on interface * fix kyle	3 years ago
idafurjes	fa2e74cd6e	Chore: Remove GetSignedInUserWithCacheCtx from store interface (#53734) ... * Remove delete suer from store interface * Remove get signed in user with cache ctx from store interface * Support options when setting up access control tests * Fix broken tests * Fix lint * Add user fake to middleware * Fix middleware tests, remove usertest being initialised twice Co-authored-by: Karl Persson <kalle.persson@grafana.com>	3 years ago
idafurjes	1f442b419b	Chore: Remove disable user, disable batch users and searchusers methods from store interface (#53717) ... * Chore: Remove disable user and searchusers methods from store interface * Remove disable batch user from sqlstore interface * Remove sqlstore from search store * Fix lint	3 years ago
idafurjes	dfc75b1114	Remove delete suer from store interface (#53726)	3 years ago
Mihály Gyöngyösi	1c0ab501aa	UsersTable: Display Disabled flag in Organizations' Users table (#53656) ... * Add disabled column to Org's Users table * fix typo * Change column order * Add test for testing whether GetOrgUsers populates the DTO correctly * Remove type assertion	3 years ago
Giordano Ricci	c1b30c56c9	Correlations: Add GetCorrelation(s) HTTP APIs (#52517) ... * Correlations: Get Single correlations * Correlations: Get all correlations for given source ds * Correlations: Get all correlations * add tests * add DB indices * fix lint errors * remove skip from tests * use DatasourceService in test	3 years ago
Karl Persson	c08fe3a53c	RBAC: Enable rbac when creating new settings (#53531) ... * Settings: Set RBACEnabled to true by default * Remove accessControlEnabledFlag and explicitly set to false when needed * Disable rbac for tests	3 years ago
idafurjes	a14621fff6	Chore: Add user service method SetUsingOrg and GetSignedInUserWithCacheCtx (#53343) ... * Chore: Add user service method SetUsingOrg * Chore: Add user service method GetSignedInUserWithCacheCtx * Use method GetSignedInUserWithCacheCtx from user service * Fix lint after rebase * Fix lint * Fix lint error * roll back some changes * Roll back changes in api and middleware * Add xorm tags to SignedInUser ID fields	3 years ago
Serge Zaitsev	72367f99cf	Chore: Move plugin settings store code into a dedicated service (#53560)	3 years ago
Jo	062d255124	Handle ioutil deprecations (#53526) ... * replace ioutil.ReadFile -> os.ReadFile * replace ioutil.ReadAll -> io.ReadAll * replace ioutil.TempFile -> os.CreateTemp * replace ioutil.NopCloser -> io.NopCloser * replace ioutil.WriteFile -> os.WriteFile * replace ioutil.TempDir -> os.MkdirTemp * replace ioutil.Discard -> io.Discard	3 years ago
Serge Zaitsev	6e4b537ba6	Chore: Remove datasources from the Store interface (#53515)	3 years ago
idafurjes	6afad51761	Move SignedInUser to user service and RoleType and Roles to org (#53445) ... * Move SignedInUser to user service and RoleType and Roles to org * Use go naming convention for roles * Fix some imports and leftovers * Fix ldap debug test * Fix lint * Fix lint 2 * Fix lint 3 * Fix type and not needed conversion * Clean up messages in api tests * Clean up api tests 2	3 years ago
Karl Persson	aa484a60c9	RBAC: Fix dashboard filter in SQLBuilder (#53379) ... * Reuse DasbhoardPermissionFilter * Use rbac dashboard filter if enabled	3 years ago
ying-jeanne	ba89471598	Chore: Enable ANSI_QUOTES for Mysql Database (#53277) ... * remove the quote dialect * add environment variable	3 years ago
ying-jeanne	af09638a0d	remove the sqlstore playlist methods (#53415)	3 years ago
Kat Yang	62b4dbf52f	Chore: Remove pluginsettings methods from store and mockstore (#53347)	4 years ago
idafurjes	0c5b71694f	Chore: Add user service method UpdateLastSeenAt (#53309) ... * Chore: Add user service method UpdateLastSeenAt * Fix lint	4 years ago
idafurjes	20f4191e56	Chore: Add user service method ChangePassword (#53303) ... * Chore: Add user service method ChangePassword * Fix lint	4 years ago
idafurjes	6fdb6ea6f6	Chore: Add user service method Update (#53300) ... * Chore: Add user service method Update * Remove UpdateUser from store interface	4 years ago
Serge Zaitsev	191ab3bb01	Chore: Move api key models into apikey service package (#53241) ... * Chore: move api key models into apikey service package * force table name for api key	4 years ago