189 Commits (5be04f53368cce32a2bc7642957504b787187cfb)

Author	SHA1	Message	Date
Yuriy Tseretyan	2d38664fe6	Alerting: Improve validation of query and expressions on rule submit (#53258) ... * Improve error messages of server-side expression * move validation of alert queries and a condition to eval package	3 years ago
Marcus Efraimsson	862a6a2fa6	Logging: Introduce API for contextual logging (#55198) ... Introduces a FromContext method on the log.Logger interface that allows contextual key/value pairs to be attached, e.g. per request, so that any logger using this API will automatically get the per request context attached. The proposal makes the traceID available for contextual logger , if available, and would allow logs originating from a certain HTTP request to be correlated with traceID. In addition, when tracing not enabled, skip adding traceID=00000000000000000000000000000000 to logs.	3 years ago
Giordano Ricci	d815e2cb56	Correlations: Return 200 instead of 404 for empt correlation lists (#55242) ... * return 200 instead of 404 for empty correlations list * handle empty list response & improve consistency	3 years ago
Emil Tullstedt	b287047052	Chore: Upgrade Go to 1.19.1 (#54902) ... * WIP * Set public_suffix to a pre Ruby 2.6 version * we don't need to install python * Stretch->Buster * Bump versions in lib.star * Manually update linter Sort of messy, but the .mod-file need to contain all dependencies that use 1.16+ features, otherwise they're assumed to be compiled with -lang=go1.16 and cannot access generics et al. Bingo doesn't seem to understand that, but it's possible to manually update things to get Bingo happy. * undo reformatting * Various lint improvements * More from the linter * goimports -w ./pkg/ * Disable gocritic * Add/modify linter exceptions * lint + flatten nested list Go 1.19 doesn't support nested lists, and there wasn't an obvious workaround. https://go.dev/doc/comment#lists	3 years ago
Gabriel MABILLE	101349fe49	RBAC: Add permissions to install and configure plugins (#51829) ... * RBAC: Allow app plugins restriction Co-authored-by: Kalle Persson <kalle.persson@grafana.com> * Moving declaration to HttpServer Co-Authored-By: marefr <marcus.efraimsson@gmail.com> * Picking changes from the other branch Co-authored-by: Alexander Zobnin <alexanderzobnin@gmail.com> * Rename plugins.settings to plugins Co-authored-by: Kalle Persson <kalle.persson@grafana.com> * Account for PluginAdminExternalManageEnabled Co-authored-by: Will Browne <will.browne@grafana.com> * Set metadata on instantiation Co-authored-by: Jguer <joao.guerreiro@grafana.com> Co-authored-by: Kalle Persson <kalle.persson@grafana.com> Co-authored-by: marefr <marcus.efraimsson@gmail.com> Co-authored-by: Alexander Zobnin <alexanderzobnin@gmail.com> Co-authored-by: Will Browne <will.browne@grafana.com> Co-authored-by: Jguer <joao.guerreiro@grafana.com>	3 years ago
ismail simsek	9c6a6ca487	graphite and opentsdb integration tests (#54733)	3 years ago
ismail simsek	e912029ad3	influxdb integration tests (#54700)	3 years ago
Marcus Efraimsson	87afd9cadc	Plugins: Remove various custom headers logic (#54146) ... Removes various custom headers logic sprinkled around in the backend. It should automatically be applied to outgoing HTTP requests via the CustomHeadersMiddleware. This also removes decryption of SecureJSONData to populate custom headers in ngalert which seemed to have caused a ton of CPU usage.	3 years ago
George Robinson	e163a976fa	Alerting: Fix width of Adapative Cards in Teams notifications (#53996)	3 years ago
Karl Persson	1b933ff3ed	RBAC: Move resource permissions store to service package (#53815) ... * Rename file to store * Move resource permission specific database functions to resourcepermissions package * Wire: Remove interface bind * RBAC: Remove injection of resourcepermission Store * RBAC: Export store constructor * Tests: Use resource permission package to initiate store used in tests * RBAC: Remove internal types package and move to resourcepermissions package * RBAC: Run database tests as itegration tests	3 years ago
George Robinson	6d69d7acb8	Alerting: Fix notifications for Microsoft Teams (#53810) ... This commit fixes notifications for Microsoft Teams where notifications would just contain "Card" rather than the title.	3 years ago
Drew Slobodnjak	e9e5c97807	Geomap: Update language to match documentation and remove beta (#53703) ... Co-authored-by: nmarrs <nathanielmarrs@gmail.com>	3 years ago
Giordano Ricci	6b84dddee8	Fix build error (#53615)	3 years ago
Giordano Ricci	c1b30c56c9	Correlations: Add GetCorrelation(s) HTTP APIs (#52517) ... * Correlations: Get Single correlations * Correlations: Get all correlations for given source ds * Correlations: Get all correlations * add tests * add DB indices * fix lint errors * remove skip from tests * use DatasourceService in test	3 years ago
George Robinson	5e1d628f21	Alerting: Use Adaptive Cards in Teams notifications (#53532) ... This commit changes the cards in Teams notifications from Office 365 Connector cards to Adaptive Cards to fix an issue where images were not shown in Teams for desktop and web. Since Office 365 Connector cards are deprecated, it made sense to move to Adapative Cards and fix this bug at the same time. The Adaptive Card messages maintain the design of the Office 365 Connector Card with a number of minor differences: - In Adaptive Card messages the color of the title is red or green depending on the status of the alerts, where as with Office 365 connector cards there was a colored border at the top of the title - In Adaptive Card messages the title is bold to make it easier to read when the color is red or green - In Adaptive Card messages the thumbnails for images are medium size if there are more than two images, otherwise large size	3 years ago
Jo	062d255124	Handle ioutil deprecations (#53526) ... * replace ioutil.ReadFile -> os.ReadFile * replace ioutil.ReadAll -> io.ReadAll * replace ioutil.TempFile -> os.CreateTemp * replace ioutil.NopCloser -> io.NopCloser * replace ioutil.WriteFile -> os.WriteFile * replace ioutil.TempDir -> os.MkdirTemp * replace ioutil.Discard -> io.Discard	3 years ago
idafurjes	6afad51761	Move SignedInUser to user service and RoleType and Roles to org (#53445) ... * Move SignedInUser to user service and RoleType and Roles to org * Use go naming convention for roles * Fix some imports and leftovers * Fix ldap debug test * Fix lint * Fix lint 2 * Fix lint 3 * Fix type and not needed conversion * Clean up messages in api tests * Clean up api tests 2	3 years ago
sh0rez	534ece064b	pkg/web: closure-style middlewares (#51238) ... * pkg/web: closure-style middlewares Switches the middleware execution model from web.Handlers in a slice to web.Middleware. Middlewares are temporarily kept in a slice to preserve ordering, but prior to execution they are applied, forming a giant call-stack, giving granular control over the execution flow. * pkg/middleware: adapt to web.Middleware * pkg/middleware/recovery: use c.Req over req c.Req gets updated by future handlers, while req stays static. The current recovery implementation needs this newer information * pkg/web: correct middleware ordering * pkg/webtest: adapt middleware * pkg/web/hack: set w and r onto web.Context By adopting std middlewares, it may happen they invoke next(w,r) without putting their modified w,r into the web.Context, leading old-style handlers to operate on outdated fields. pkg/web now takes care of this * pkg/middleware: selectively use future context * pkg/web: accept closure-style on Use() * webtest: Middleware testing adds a utility function to web/webtest to obtain a http.ResponseWriter, http.Request and http.Handler the same as a middleware that runs would receive * *: cleanup * pkg/web: don't wrap Middleware from Router * pkg/web: require chain to write response * *: remove temp files * webtest: don't require chain write * *: cleanup	3 years ago
Giordano Ricci	09c4dbdb9f	Correlations: Add UpdateCorrelation HTTP API (#52444) ... * Correlations: add UpdateCorrelation HTTP API * handle correlation not found * add tests * fix lint errors * add bad request to API spec * change casing * fix casing in docs * fix tests * update spec	4 years ago
Sofia Papagiannaki	7ba076de10	Chore: Move swagger definitions to the handlers (#52643)	4 years ago
Giordano Ricci	9a06b00e92	Correlations: Add DeleteCorrelation HTTP API (#51801) ... * Correlations: add DeleteCorrelation HTTP API * fix error message copy * add readonly check * add source_uid in delete condition * make path singular * Revert "make path singular" This reverts commit d15be89578e202e5cb64a3e964ee09521b72d87c. * add tests * fix lint errors * fix lint errors * change casing * update spec * Remove transaction * change casing in param name in docs	4 years ago
Giordano Ricci	4b2144fe40	Correlations: change casing of *UID properties (#52836) ... * Correlations: change casing of *UID properties * add link to correlations HTTP API	4 years ago
Giordano Ricci	5ce4baf6f5	Correlations: Add CreateCorrelation HTTP API (#51630) ... * Correlations: add migration * Correlations: Add CreateCorrelation API * Correlations: Make correlations work with provisioning * Handle version changes * Fix lining error * lint fixes * rebuild betterer results * add a UID to each correlation * Fix lint errors * add docs * better wording in API docs * remove leftover comment * handle ds updates * Fix error message typo * add bad data test * make correlations a separate table * skip readonly check when provisioning correlations * delete stale correlations when datasources are deleted * restore provisioned readonly ds * publish deletion event with full data * generate swagger and HTTP API docs * apply source datasource permission to create correlation API * Fix tests & lint errors * ignore empty deletion events * fix last lint errors * fix more lint error * Only publish deletion event if datasource was actually deleted * delete DS provisioning deletes correlations, added & fixed tests * Fix unmarshalling tests * Fix linting errors * Fix deltion event tests * fix small linting error * fix lint errors * update betterer * fix test * make path singular * Revert "make path singular" This reverts commit 420c3d315e. * add integration tests * remove unneeded id from correlations table * update spec * update leftover references to CorrelationDTO * fix tests * cleanup tests * fix lint error	4 years ago
Jean-Philippe Quéméner	ba9c18d9c3	Alerting: use static channel configuration to determinate secure fields (#52527) ... * Alerting: use static channel configuration to determinate secure fields * move to channels package * introduce channel_config package to fix cyclic import * add missing changes * compare type to type	4 years ago
Jean-Philippe Quéméner	50ae42130b	Alerting: take datasources as external alertmanagers into consideration (#52534)	4 years ago
George Robinson	094dfd0d4d	Alerting: Fix Slack push notifications (#52391) ... This commit fixes push notifications for Slack which used to show "This content cannot be displayed". The text field is shown in both the message and the push notification.	4 years ago
Yuriy Tseretyan	054fe54b03	Alerting: Split Scheduler and AlertRouter tests (#52416) ... * move fake FakeExternalAlertmanager to sender package * move tests from scheduler to router * update alerts router to have all fields private * update scheduler tests to use sender mock	4 years ago
Matthew Jacobson	434e94ef2b	Alerting: Update default route groupBy to [grafana_folder, alertname] (#50052) ... * Alerting: Update default route groupBy to [grafana_folder, alertname] Default group by for new routes and migrations is now [grafana_folder, alertname]	4 years ago
Jean-Philippe Quéméner	e64cde8727	Alerting: validate that the receiver exist when updating routing tree (#51561) ... * Alerting: validate that the receiver exist when updating routing tree * rename interface * add missing file * change constructor * fix e2e tests * only import package once * add unit test for bug * wording * close response body * Update pkg/services/ngalert/api/tooling/definitions/alertmanager_validation.go * refactor to remove database roundtrip	4 years ago
Yuriy Tseretyan	8b3b667a47	Alerting: Fix rule API to accept 0 duration of field `For` (#50992) ... * make 'for' pointer to distinguish between missing field and 0 * set 'for' to -1 if the value is missing but not allow negative in the request + path -1 with the value from original rule * update store validation to not allow negative 'for' * update usages to use pointer	4 years ago
Kristin Laemmert	9de00c8eb2	chore/backend: move dashboard errors to dashboard service (#51593) ... * chore/backend: move dashboard errors to dashboard service Dashboard-related models are slowly moving out of the models package and into dashboard services. This commit moves dashboard-related errors; the rest will come in later commits. There are no logical code changes, this is only a structural (package) move. * lint lint lint	4 years ago
idafurjes	6c43eb0b4d	Split Create User (#50502) ... * Split Create User * Use new create user and User from package user * Add service to wire * Making create user work * Replace user from user pkg * One more * Move Insert to orguser Service/Store * Remove unnecessary conversion * Cleaunp * Fix Get User and add fakes * Fixing get org id for user logic, adding fakes and other adjustments * Add some tests for ourguser service and store * Fix insert org logic * Add comment about deprecation * Fix after merge with main * Move orguser service/store to org service/store * Remove orguser from wire * Unimplement new Create user and use User from pkg user * Fix wire generation * Fix lint * Fix lint - use only User and CrateUserCommand from user pkg * Remove User and CreateUserCommand from models * Fix lint 2	4 years ago
George Robinson	5053468c65	Alerting: Add support for images in Telegram (#51433)	4 years ago
Yuriy Tseretyan	4a9872d108	reload permissions after create folder (#51288)	4 years ago
Ryan McKinley	dd5a3b7747	Heatmap: Replace the heatmap panel with new implementation (#50229)	4 years ago
Yuriy Tseretyan	ba00d12c0f	fix test TestRuleGroupSequence to work in Enterprise environment (#51284)	4 years ago
Yuriy Tseretyan	4d02f73e5f	Alerting: Persist rule position in the group (#50051) ... Migrations: * add a new column alert_group_idx to alert_rule table * add a new column alert_group_idx to alert_rule_version table * re-index existing rules during migration API: * set group index on update. Use the natural order of items in the array as group index * sort rules in the group on GET * update the version of all rules of all affected groups. This will make optimistic lock work in the case of multiple concurrent request touching the same groups. UI: * update UI to keep the order of alerts in a group	4 years ago
Yuriy Tseretyan	53d03aec78	Alerting: Add api client to integration tests (#50970)	4 years ago
Matthew Jacobson	5dee2ed24c	Alerting: Add first Grafana reserved label grafana_folder (#50262) ... * Alerting: Add first Grafana reserved label g_label g_label holds the title of the folder container the alert. The intention of this label is to use it as part of the new default notification policy groupBy. * Add nil check on updateRule labels map * Disable gocyclo lint on schedule.ruleRoutine will remove later in a separate refactoring PR to reduce complexity. * Address doc suggestions * Update g_folder for rules in folder when folder title changes * Remove global bus in FolderService * Modify tests to fit new common g_folder label * Add changelog entry * Fix merge conflicts * Switch GrafanaReservedLabelPrefix from `g_` to `grafana_`	4 years ago
Serge Zaitsev	ae9491c3a7	Chore: Make test tracer noop and return no errors (#50797)	4 years ago
Ryan McKinley	c5547fde59	Open Heatmap: update plugin snapshot testdata (#50747)	4 years ago
Alexander Weaver	28a47b56d2	Bump provisioning to admin-only in lieu of dedicated RBAC permissions (#50366)	4 years ago
Dan Cech	9350ab781c	clean up duplicated user creation code (#50178) ... * clean up duplicated user creation code * remove unused duplicate getOrCreateOrg function * fix up tests	4 years ago
Jean-Philippe Quéméner	4b8a4449ed	Alerting: remove feature toggle for provisioning API (#50167) ... * Alerting: remove feature toggle for provisioning API * remove missed code parts * remove unused import * remove empty line * mark routes as stable	4 years ago
Alexander Weaver	67290aa49f	Alerting: Add version segment to all provisioning routes (#49121) ... Co-authored-by: Jean-Philippe Quémémer <jeanphilippe.quemener@grafana.com>	4 years ago
Ieva	5dbea9996b	RBAC: Make RBAC action names more consistent (#49730) ... * update action names * correctly retrieve teams for signed in user * remove test * undo swagger changes * undo swagger changes pt2 * add migration from old action names to the new ones * rename from list to read * linting * also update alertign actions * fix migration	4 years ago
Karl Persson	1796a1d277	AccessControl: Grant data source reader to all users when running oss (#49514) ... * grant data source reader to all users when running oss or enterprise without license * fix asserts in alerting tests * add oss licensing service for test setup * fix tests to pass in enterprise * lint * fix tests * set setting.IsEnterprise flag for tests Co-authored-by: Yuriy Tseretyan <yuriy.tseretyan@grafana.com>	4 years ago
Gilles De Mey	86871807d2	Alerting: Make alertmanager datasource stable (#49485)	4 years ago
Alexander Weaver	81e368dbb5	Fix flaky test. Sort records and only test the important fields (#49120)	4 years ago
Alexander Weaver	9af30f6570	Alerting: Provisioning GET routes for mute timings (#49044) ... * Define GET routes and run codegen * Wire up forked and non-generated API * Implement and wire * Tests, authorization * Fix linter error	4 years ago