grafana

Commit Graph

Author	SHA1	Message	Date
Joe Blubaugh	5e4fd94413	Alerting: Write and Delete multiple alert instances. (#54072 ) Prior to this change, all alert instance writes and deletes happened individually, in their own database transaction. This change batches up writes or deletes for a given rule's evaluation loop into a single transaction before applying it. Before: ``` goos: darwin goarch: arm64 pkg: github.com/grafana/grafana/pkg/services/ngalert/store BenchmarkAlertInstanceOperations-8 398 2991381 ns/op 1133537 B/op 27703 allocs/op --- BENCH: BenchmarkAlertInstanceOperations-8 util.go:127: alert definition: {orgID: 1, UID: FovKXiRVzm} with title: "an alert definition FTvFXmRVkz" interval: 60 created util.go:127: alert definition: {orgID: 1, UID: foDFXmRVkm} with title: "an alert definition fovFXmRVkz" interval: 60 created util.go:127: alert definition: {orgID: 1, UID: VQvFuigVkm} with title: "an alert definition VwDKXmR4kz" interval: 60 created PASS ok github.com/grafana/grafana/pkg/services/ngalert/store 1.619s ``` After: ``` goos: darwin goarch: arm64 pkg: github.com/grafana/grafana/pkg/services/ngalert/store BenchmarkAlertInstanceOperations-8 1440 816484 ns/op 352297 B/op 6529 allocs/op --- BENCH: BenchmarkAlertInstanceOperations-8 util.go:127: alert definition: {orgID: 1, UID: 302r_igVzm} with title: "an alert definition q0h9lmR4zz" interval: 60 created util.go:127: alert definition: {orgID: 1, UID: 71hrlmR4km} with title: "an alert definition nJ29_mR4zz" interval: 60 created util.go:127: alert definition: {orgID: 1, UID: Cahr_mR4zm} with title: "an alert definition ja2rlmg4zz" interval: 60 created PASS ok github.com/grafana/grafana/pkg/services/ngalert/store 1.383s ``` So we cut time by about 75% and memory allocations by about 60% when storing and deleting 100 instances. This change also updates some of our tests so that they run successfully against postgreSQL - we were using random Int64s, but postgres integers, which our tables use, max out at 2^31-1	3 years ago
Michael Mandrus	39c31416a4	improve log in plugin check (#54599 )	3 years ago
Timur Olzhabayev	b5b41988cf	Docs: Deprecating packages_api and removing it from our pipelines (#54473 )	3 years ago
Serge Zaitsev	927ddf9376	Chore: Move login attempt methods to separate service (#54479 ) * Chore: Move login attempt methods to separate service * attempt to fix tests * fix syntax * better time mocking * initialise now func	3 years ago
Karl Persson	be6b8d91eb	Correlations: Use correct fallback handlers (#54511 ) * Correlations: Use correct fallback handlers * Add signed in middleware to all routes	3 years ago
Kat Yang	58449d42ed	Chore: Add dashboard thumbnails service (#54500 ) * Chore: Add dashboard thumbnails service * Fix errors in dashboard thumbs impl * Inject dashboardThumbsService into wire	3 years ago
owensmallwood	f4bbce15a0	Public Dashboards: Add Expressions Support (#54336 ) Adds support for expressions with public dashboards	3 years ago
Yuriy Tseretyan	76ea0b15ae	Alerting: Scheduler to fetch folders along with rules (#52842 ) * Update GetAlertRulesForScheduling to query for folders (if needed) * Update scheduler's alertRulesRegistry to cache folder titles along with rules * Update rule eval loop to take folder title from the * Extract interface RuleStore * Pre-fetch the rule keys with the version to detect changes, and query the full table only if there are changes.	3 years ago
Kristina	38c1f3d054	Explore: Add Mixed Datasource (#53429 ) * Toggle on the mixed mode option * Ensure switching to mixed gives existing query prev datasource * WIP - Populate datasource when switching between mixed and not * WIP - handle change from mixed * Remove preimport filter, refine filter to work for queries * WIP debugging datasource transition * Ensure creating a new query gets target data source if switching with no matches between * Add mixed datasource to rich history display * Cleanup console logs, add relevant comments * Add feature toggle for mixed datasource * Fix Wrapper tests * Fix tests! * Fix test types and add feature tracking * Remove unnecessary default, remove explore/mixed workarounds for D2E * Move display text logic to mixed datasource file * Add in the default query parameters to a generated empty query * Condense some code * Apply suggestions from code review Co-authored-by: Giordano Ricci <me@giordanoricci.com> * Add more logic around mixed datasource being off for explore * Build out logic to handle different datasource scenarios * Add tests * Finalize last test * Fix mixed URL with mixed ds off, and relevant test * Fix datasource to explore workflow * Add datasource change function, call import queries if needed * add logic for changing single query ds Co-authored-by: Giordano Ricci <me@giordanoricci.com>	3 years ago
Dave Henderson	713075c494	Metrics: Fixed `grafana_database_conn_` metrics, and added new `go_sql_stats_` metrics as eventual replacement (#54405 ) * metrics: Fix broken DBStats metrics Signed-off-by: Dave Henderson <dave.henderson@grafana.com> * Register the sqlstats metrics by default Signed-off-by: Dave Henderson <dave.henderson@grafana.com> Signed-off-by: Dave Henderson <dave.henderson@grafana.com>	3 years ago
Artur Wierzbicki	9284216880	Search: ordering tests (#54432 ) * search ordering tests * lintt	3 years ago
Will Browne	4a707e2a88	Plugins: Split plugin manager into smaller components (#54384 ) * split out plugin manager * remove whitespace * fix tests * split up tests * updating naming conventions * simplify manager * tidy * add more fakes * testing time * add query verif to int test * renaming * add process tests * tidy up manager tests * add extra case to int test * add more coverage to store and process tests * remove comment * fix capatilization * init on provide * remove addfromsource from API	3 years ago
Artur Wierzbicki	7a340f486b	Storage: add `WithContents` option to `storage.Get()` (#53105 ) * Storage: add `WithContents` option to `storage.Get()` * fix tests Co-authored-by: Ryan McKinley <ryantxu@gmail.com>	3 years ago
Joan López de la Franca Beltran	6ec06f66b9	Rendering: Add support for renderer token (#54425 ) (cherry picked from commit a4f75cc0438712c90b02d24740416f8615e3a0cb)	3 years ago
Ezequiel Victorero	722aca5c53	Public Dashboards: use intervalMs and maxDataPoints from request (#53613 )	3 years ago
ying-jeanne	fe062f2eaa	Chore: Use db.DB interface instead of sqlstore (#54358 ) * use db.DB interface instead of sqlstore * make store service depends on db.DB instead of sqlstore	3 years ago
Jean-Philippe Quéméner	a932428057	Alerting: use raw query data in provisioning to bypass interpolation of macros (#54293 )	3 years ago
Jean-Philippe Quéméner	49b1182f34	Alerting: add missing yaml tag to mute time struct (#54287 )	3 years ago
Jeff Levin	5cb9fca990	public-dashboards: Add log statement when public dashboard enabled or disabled (#54133 ) * refactor apis for consistent outputs * add dashboardUid validation at API layer * add check for empty dashboardUid on SavePublicDashboard * remove public dashboard errors from models package. Co-authored-by: Ezequiel Victorero <evictorero@gmail.com>	3 years ago
Karl Persson	9d2f5ef62f	RBAC: Add function to generate wildcards from prefix (#54275 ) * RBAC: Move metadata to own file * RBAC: Rename test files * RBAC: Add wildcard structure and helper function to generate wildcards from prefix * RBAC: Refactor filter to use WildcardsFromPrefix * RBAC: Refactor GetResourceMetadata to use WildcardsFromPrefix	3 years ago
ying-jeanne	6227528ea0	Chore: SQL Store Split of datasource (#54262 ) * refectory datasource * fix linter	3 years ago
Yuriy Tseretyan	db09a76125	update test environment to create folders (#54254 )	3 years ago
Giordano Ricci	c68d7f1e35	Correlations: Add CorrelationSettings Page (#53821 ) * GrafanaUI: add option to close DeleteButton on confirm click * add datasource readOnly info to frontend settings * move isTruthy utility type guard * add generic non-visualization table component * Add correlations settings page * add missing readOnly in mock * Fix typo * avoid reloading correlations after add/remove * use DeepPartial from rhf * validate source data source * fix validation logic * fix navmodel test * add missing readonly property * remove unused styles * handle multiple clicks on elements * better UX for loading states * fix remove handler * add glue icon	3 years ago
Marcus Efraimsson	87afd9cadc	Plugins: Remove various custom headers logic (#54146 ) Removes various custom headers logic sprinkled around in the backend. It should automatically be applied to outgoing HTTP requests via the CustomHeadersMiddleware. This also removes decryption of SecureJSONData to populate custom headers in ngalert which seemed to have caused a ton of CPU usage.	3 years ago
Jeff Levin	681bdf1a2d	public-dashboards: refactor query method (#54119 ) This PR refactors the GetPublicDashboard method so we don't need to make extra database calls. Also adds general documentation	3 years ago
Artur Wierzbicki	74158ed66b	Search: use SQL search as a fallback during bluge's initial indexing (#54095 ) * Search: use SQL search as a fallback when bluge indexing is ongoing * Search: lint * Search: feedback fixes - return an empty frame with a special name * Search: revert readiness check query type * Search: remove println * remove sleep, get coffee	3 years ago
Karl Persson	5a1b9d2283	RBAC: Remove DeclareFixedRoles wrapper on Access control and inject service (#54153 ) * RBAC: Remove DeclareFixedRoles wrapper on Access control and inject service when needed	3 years ago
Guilherme Caulada	f25c7f6ddd	Chore: Refactor secrets kvstore to organize testing and migrations (#54249 ) * Refactor migrations and tests for secrets kvstore * Use fake secrets store as a shortcut on tests * Update wire * Use global migration logger * Fix ds proxy tests * Fix linting issues * Rename data source test setup function	3 years ago
ying-jeanne	fd01161bcc	Chore: replace xorm by sqlx in dashboardversion service (#53869 )	3 years ago
Michael Mandrus	8deababa50	Chore: Refactor secrets plugin unit tests code (#54231 ) * refactor test setup to return struct rather than many values * changes to code style from review * apply diff from Leandro for logging	3 years ago
Yuriy Tseretyan	03e746d9df	Alerting: Delete state from the database on reset (#53919 ) * make ResetStatesByRuleUID return states * delete rule states when reset * rule eval routine to clean up the state only when rule is deleted	3 years ago
Emil Tullstedt	0ffbf901d7	ContextHandler: Use stdlib format for middleware (#54219 )	3 years ago
Karl Persson	552d3fec8d	RBAC: Fix resolver issue on wildcard resulting in wrong status code for endpoints (#54208 ) * RBAC: Test evaluation before attaching mutator * RBAC: Return error if no resolver is found for scope * RBAC: Sync changes to evaluation in mock * RBAC: Check for resolver not found error and just fail the evaluation in that case	3 years ago
Jeff Levin	6128cb60b4	cleanup unused fields (#54115 ) This PR removes unused struct fields in SavePublicDashboardCommand	3 years ago
Michael Mandrus	277ea836b6	Secrets: Implement migration of secrets from plugin back to unified secrets (#53561 ) * initial cut at migration from plugin * create new migration from plugin * only migrate to or from, not both * remove cfg check from plugin migration itself * update comments, clean up secret after migration * add better error handling * hook up REST API with migrations * Minor fixes * fix wire injection issue * modify migrator to access plugin calls directly. create unit tests * change pre-migration checks in admin api * stop plugin after migrating from it * fix compile issues after merge * add comment about migration * fix linting issue * bleh, fix unit test * fix another unit test * update plugin error fatal flag after a migration from the plugin * add extra logging to migration * make linter happy Co-authored-by: Leandro Deveikis <leandro.deveikis@gmail.com>	3 years ago
Yuriy Tseretyan	41bd36eb97	Alerting: Update rules delete endpoint to handle rules in group (#53790 ) * update RouteDeleteAlertRules rules to update as a group * remove expecter from scheduler mock to support variadic function * create function to check for provisioning status + tests Co-authored-by: Alexander Weaver <weaver.alex.d@gmail.com>	3 years ago
Santiago	4fad827acd	Alerting: log external alertmanager URLs #54127	3 years ago
Andre Pereira	c8f2148f75	Tempo: Basic PoC of the upcoming TraceQL editor in Explore (#54028 ) * First working version of the TraceQL editor with syntax highlighting and autocomplete * Add feature flag around the new editor option * Fix tests and cleanup * Fix misspelling	3 years ago
Valério Valério	b5142832fa	Alerting: Fix saving of screenshots uploaded with a signed url (#53933 ) The URL of screenshots uploaded to external image storages can be optionally signed, resulting in a long string (800+ chars).	3 years ago
Karl Persson	55c7b8add2	RBAC: Split up service into several components (#54002 ) * RBAC: Rename interface to Store * RBAC: Move ranme scopeInjector * RBAC: Rename files to service * RBAC: Rename to service * RBAC: Split up accesscontrol into two components * RBAC: Add DeclareFixedRoles to AccessControl interface * Wire: Fix wire bindings * RBAC: Move resolvers to root * RBAC: Remove invalid test * RBAC: Inject access control service * RBAC: Implement the RoleRegistry interface in fake	3 years ago
ying-jeanne	4dbe0b4f02	Chore: Move updateorg out of sqlstore (#54111 ) * Chore: move updateorg out of sqlstore * fix api test	3 years ago
Guilherme Caulada	d90600c454	Secrets: Add fallback to secrets kvstore plugin (#54056 ) * Add fallback to secrets kvstore plugin * Fix linter issues * Fix linter issues * Add deletion error to bool to fake secrets kvstore * Add fallback to fake secrets kvstore * Fix fake secrets kvstore fallback setter * Use Key on Item message for secrets manager protobuf * Add clarifying comment about fallback	3 years ago
ying-jeanne	ebcdf402b2	Chore: move from xorm to sqlx apikey store (#53434 ) * migrate from xorm to sqlx * fix tests * fix comments * fix some comments on the PR * fix CI * fix the comments	3 years ago
Jo	5c1f614d3c	Service Accounts: Separate metrics logic from store (#54085 ) * separate stats logic from store * remove in_teams unused stat * use init instead	3 years ago
Karl Persson	cc78486535	RBAC: Display indicator if a permission is inherited (#54080 ) * RBAC: Add IsInherited property * PermissionList: Display inherited indicator	3 years ago
George Robinson	e163a976fa	Alerting: Fix width of Adapative Cards in Teams notifications (#53996 )	3 years ago
Guilherme Caulada	2e9edf4592	Secrets: Refactor code duplicity on secrets sql kvstore (#54032 )	3 years ago
George Robinson	c960301aa8	Alerting: Fix links in Microsoft Teams notifications (#54003 )	3 years ago
Alexander Weaver	c7b93ec331	Make channels_config no longer depend on legacy alerting (#53799 )	3 years ago
Jo	4a9137ac40	API Keys: Add revocation for SATs (#53896 ) * add apikey is_revoked field * add token store tests * Apply suggestions from code review * remove unused fields	3 years ago

1 2 3 4 5 ...

4136 Commits (5e4fd94413387e3f9692acc49aa5de9442bb2951)