4844 Commits (6144c0f51d8a678839eaaf600a410d2a30a1703b)

Author	SHA1	Message	Date
Oleg Gaidarenko	1e5fc76601	LDAP: improve POSIX support (#18235) ... * LDAP: improve POSIX support * Correctly abtain DN attributes result * Allow more flexibility with comparison mapping between POSIX group & user * Add devenv for POSIX LDAP server * Correct the docs Fixes #18140	6 years ago
Dima Kurguzov	a4b0ccc138	Instrumentation: Add failed notifications metric (#18089)	6 years ago
Markus Blaschke	31547597d3	remote_cache: Fix redis connstr parsing (#18204) ... * Fix redis connstr parsing * Don’t log the password	6 years ago
Oleg Gaidarenko	d16fd58bdb	Auth: do not expose disabled user disabled status (#18229) ... Fixes #17947	6 years ago
Kyle Brandt	ea0cee4c35	alerting: more specific error when missing threshold (#18221) ... fixes #18184	6 years ago
Kyle Brandt	172464e91e	alerting: return err when SetAlertState fails to save to sql (#18216) ... fix duplicate alert states when the alert fails to save to the database. fixes #18176	6 years ago
Leonard Gram	2014549fa5	PhantomJS: Fixes rendering on Debian Buster (#18162) ... Closes #17588	6 years ago
Raphael Couto	bc0da1bbfc	Plugin: AzureMonitor - Reapply MetricNamespace support (#17282) ... * Reapply MetricNamespace support * Fixing tests * refactor: move metricnamespace param to backend * refactor: remove unused function * azuremonitor: migration for new metric namespace field * azuremonitor: add template query for metric namespace with a sub * docs: template queries for azure monitor Adds new lines for the metricnamespace template function and fixes some messed up lines	6 years ago
Alexander Zobnin	ccf11fb7a2	SAML: add auth provider label (#18197)	6 years ago
Ryan McKinley	0ca1e90b2e	Plugins: fix previous commit, output "build" property in json	6 years ago
Alexander Zobnin	214195441f	SAML: add metrics (#18194)	6 years ago
Ryan McKinley	3e0625ff3d	Plugins: add build info to plugin metadata (#18164)	6 years ago
Kyle Brandt	7cac393ddc	datasource: testdata - add predicatable csv wave scenario (#18183)	6 years ago
Kyle Brandt	ed099d5ca0	datasource: testdata - add predictable pulse scenario (#18142) ... Adds pulse waveform. Is predictable in the sense that the start of the waveform is aligned to epoch time (instead of the start of the query time). This makes a useful signal for manual testing of alerting in the devenv.	6 years ago
Oleg Gaidarenko	d9f01cb822	SQLStore: use bool pointer instead of string (#18111)	6 years ago
Oleg Gaidarenko	75fa1f0207	Metrics: use consistent naming for exported variables (#18134) ... * Metrics: remove unused metrics Metric `M_Grafana_Version` is not used anywhere, nor the mentioned `M_Grafana_Build_Version`. Seems to be an artefact? * Metrics: make the naming consistent * Metrics: add comments to exported vars * Metrics: use proper naming Fixes #18110	6 years ago
Oleg Gaidarenko	8e0f091f14	SQLStore: allow to look for `is_disabled` flag (#18032) ... * Add support for `is_disabled` to `CreateUser()` * Add support for `is_disabled` to `SearchUsers()` Had to add it as a `string` type not as `bool`, since if that's property is omitted, we would have add it to SQL request, which might be dangerous * Restructure desctructive tests and add more	6 years ago
Oleg Gaidarenko	09eb9a45ce	Metrics: add LDAP active sync summary metric (#18079)	6 years ago
Kyle Brandt	76d08989f0	provisioning: escape literal '$' with '$$' to avoid interpolation (#18045) ... fixes #17986	6 years ago
Anthony Templeton	3680b95b44	Auth: Duplicate API Key Name Handle With Useful HTTP Code (#17905) ... * API: Duplicate API Key Name Handle With Useful HTTP Code * 17447: make changes requested during review - use dialect.IsUniqueContraintViolation - change if statement to match others - return error properly * Revert "17447: make changes requested during review" This reverts commit a4a674ea83. * API: useful http code on duplicate api key error w/ tests * API: API Key Duplicate Handling fixed small typo associated with error	6 years ago
Sofia Papagiannaki	f2ad3242be	API: Minor fix for nil pointer when trying to log error during creating new dashboard via the API (#18003) ... * Minor fix for nil pointer when trying to log error * Do not return error if a dashboard is created Only log the failures * Do not return error if the folder is created Only log the failures	6 years ago
Marcus Efraimsson	6a3a2f5f94	CLI: Fix encrypt-datasource-passwords fails with sql error (#18014) ... Now handles secure_json_data stored as null in database when running the encrypt-datasource-passwords migration. Fixes #17948	6 years ago
Leonard Gram	5d3a60d46e	LDAP: Adds bind before searching LDAP for non-login cases. (#18023)	6 years ago
Alexander Zobnin	5f0a7f43c3	Users: show badges for each auth provider (#17869) ... * Users: show badges for each auth provider * Chore: don't use functions in angular bindings * Users: minor style changes to labels * Chore: convert auth labels on the backed side, deduplicate frontend code * Users: use authLabels everywhere instead of authModule * User: fix edit user page style * Users: minor fixes after review	6 years ago
Ryan McKinley	81ff856568	grafana-cli: allow installing plugins from a local zip file (#18021)	6 years ago
Leonard Gram	25506829be	LDAP: Adds back support for single bind. (#17999)	6 years ago
gotjosh	332920954e	SAML: Show SAML login button even if OAuth is disabled (#17993) ... * Move the SAML button outside of the oauth div * Don't attempt to search cookies with an empty name	6 years ago
Sofia Papagiannaki	78ca55f3d7	Fix: Break redirect loop if oauth_auto_login = true and OAuth login fails (#17974) ... * Add tests for login view * Fix OAuth auto login redirect loop login_error cookie is only set when the OAuth login fails for some reason. Therefore, the login view should return immediately if a login_error cookie exists before trying to login the user using OAuth again. * Fix test Use 'index-template' instead of 'index' for testing * Add some comments	6 years ago
Marcus Efraimsson	962d4daabd	Api: Fix auth tokens returning wrong seenAt value (#17980) ... Changes so a non-set seenAt property gets the createdAt value. Fixes #17953	6 years ago
Oleg Gaidarenko	e2cf7c9698	LDAP: finishing touches (#17945) ... * LDAP:Docs: `active_sync_enabled` setting Mention `active_sync_enabled` setting and enable it by default * LDAP: move "disableExternalUser" method Idea behind new design of the LDAP module is to minimise conflation between other parts of the system, so it would decoupled as much as possible from stuff like database, HTTP transport and etc. Following "Do One Thing and Do It Well" Unix philosophy principal, other things could be better fitted on the consumer side of things. Which what this commit trying to archive * LDAP: correct user/admin binding The second binding was not happening, so if the admin login/password in LDAP configuration was correct, anyone could had login as anyone using incorrect password	6 years ago
Leonard Gram	b67905a963	Auth: saml enabled check. (#17960)	6 years ago
Leonard Gram	e574147b1e	Auth: SAML login button. (#17932) ... * Auth: SAML login button. * Fixed ts issue	6 years ago
gotjosh	e6b8a1529b	SAML: Configuration defaults, examples and dependencies (#17954) ... * Add SAML configuration options * Add crewjam/saml as a depdency Needed as part of the enterprise SAML integration. * Vendor github.com/stretchr/testify/require The package require implements the same assertions as the `assert` package but stops test execution when a test fails.	6 years ago
Alexander Zobnin	48d5a1bcd3	OAuth: deny login for disabled users (#17957)	6 years ago
Daniel Lee	7e95ded164	AzureMonitor: remove duplicate query logic on the frontend (#17198) ... * feat: AzureMonitor implements legend key on backend To be able to remove the duplicated query logic on the frontend, the backend code needs to implement alias patterns for legend keys as well as allowing the default list of allowed time grains to be overridden. Some metrics do not support all the time grains and the auto timegrain calculation can be incorrect if the list is not overridden. * feat: AzureMonitor - removes duplicate query logic on frontend * AzureMonitor small refactoring Extracted method and tidied up the auto time grain code. * azuremonitor: support for auto time grains for alerting Converts allowed timegrains into ms and saves in dashboard json. This makes queries for alerting with an auto time grain work in the same way as the frontend. * chore: typings -> implicitAny count down to 3413 * azuremonitor: add more typings	6 years ago
Oleg Gaidarenko	444c4d5999	LDAP: Divide the requests (#17885) ... * LDAP: Divide the requests Active Directory does indeed have a limitation with 1000 results per search (default of course). However, that limitation can be workaround with the pagination search feature, meaning `pagination` number is how many times LDAP compatible server will be requested by the client with specified amount of users (like 1000). That feature already embeded with LDAP compatible client (including our `go-ldap`). But slapd server has by default stricter settings. First, limitation is not 1000 but 500, second, pagination workaround presumably (information about it a bit scarce and I still not sure on some of the details from my own testing) cannot be workaround with pagination feature. See https://www.openldap.org/doc/admin24/limits.html https://serverfault.com/questions/328671/paging-using-ldapsearch hashicorp/vault#4162 - not sure why they were hitting the limit in the first place, since `go-ldap` doesn't have one by default. But, given all that, for me `ldapsearch` command with same request as with `go-ldap` still returns more then 500 results, it can even return as much as 10500 items (probably more). So either there is some differences with implementation of the LDAP search between `go-ldap` module and `ldapsearch` or I am missing a step :/. In the wild (see serverfault link), apparently, people still hitting that limitation even with `ldapsearch`, so it still seems to be an issue. But, nevertheless, I'm still confused by this incoherence. To workaround it, I divide the request by no more then 500 items per search	6 years ago
Alexander Zobnin	3d848d0fdf	Teams: show proper label for each auth provider (#17860) ... * Teams: show proper label for each auth provider Teams: don't sore AuthModule in team_member table, use JOIN to get it instead * Teams: fix AddTeamMember after last changes * Teams: add more auth provider labels * Teams: show external sync badge if LDAP is not enabled * Teams: tests for getting auth module	6 years ago
Anthony Templeton	0d2be0a7ed	Logging: Login and Logout logging actions (#17760) (#17883)	6 years ago
Sofia Papagiannaki	2ae6adef26	Codestyle: add guidelines for removing the m alias for models (#17890) ... * Add guidelines for avoiding use of m alias for models * Add suggestion for elimination of existing aliases	6 years ago
Oleg Gaidarenko	caa1314f44	Build: use golangci-lint as a make command (#17739) ... * Build: use golangci-lint as a make command * Since gometalinter was deprecated in favor of golangci-lint so it was replaced by it. Responsibilities held by the gometalinter was moved to golangci-lint * There was some changes in implementation (that was also mentioned in the code comment) between the tools, which uncovered couple errors in the code. Those issues were either solved or disabled by the inline comments * Introduce the golangci-lint config, to make their configuration more manageable * Build: replace backend-lint.sh script with make	6 years ago
Leonard Gram	8f150c67aa	Docs upgrading deps (#17657) ... * Docs: correct link to the Grafana build-container. * Docs: documents usage on the gopath when upgrading deps. * Dev docs: info for upgrading deps only in one location.	6 years ago
Leonard Gram	d71043609e	Testing: Include BatchRevoke for all tokens in the fake. (#17728)	6 years ago
Oleg Gaidarenko	ca136c7c22	Devenv:LDAP: couple simplifications for LDAP (#17807) ... * Add LDAP config instead sed use * Add container name * Add SizeLimit option to client and to server. Probably useless at this point, but it's better to have it then otherwise	6 years ago
Oleg Gaidarenko	5836427794	Login: divide login errors by pkg and service (#17835) ... Define errors in the login module only if they are used	6 years ago
Sofia Papagiannaki	f3f03ceb6a	Auth Proxy: Respect auto_sign_up setting (#17843) ... * Add test for disabled auth proxy auto signup option * Set correctly auth proxy auto signup	6 years ago
Alexander Zobnin	c2affdee1e	OAuth: return github teams as a part of user info (enable team sync) (#17797) ... * OAuth: github team sync POC * OAuth: minor refactor of github module * OAuth: able to use team shorthands for github team sync * support passing a list of groups via auth-proxy header	6 years ago
Marcus Efraimsson	0a3f977ea2	Usage Stats: Update known datasource plugins (#17787)	6 years ago
Sofia Papagiannaki	dc9ec7dc91	Auth: Allow expiration of API keys (#17678) ... * Modify backend to allow expiration of API Keys * Add middleware test for expired api keys * Modify frontend to enable expiration of API Keys * Fix frontend tests * Fix migration and add index for `expires` field * Add api key tests for database access * Substitude time.Now() by a mock for test usage * Front-end modifications * Change input label to `Time to live` * Change input behavior to comply with the other similar * Add tooltip * Modify AddApiKey api call response Expiration should be *time.Time instead of string * Present expiration date in the selected timezone * Use kbn for transforming intervals to seconds * Use `assert` library for tests * Frontend fixes Add checks for empty/undefined/null values * Change expires column from datetime to integer * Restrict api key duration input It should be interval not number * AddApiKey must complain if SecondsToLive is negative * Declare ErrInvalidApiKeyExpiration * Move configuration to auth section * Update docs * Eliminate alias for models in modified files * Omit expiration from api response if empty * Eliminate Goconvey from test file * Fix test Do not sleep, use mocked timeNow() instead * Remove index for expires from api_key table The index should be anyway on both org_id and expires fields. However this commit eliminates completely the index for now since not many rows are expected to be in this table. * Use getTimeZone function * Minor change in api key listing The frontend should display a message instead of empty string if the key does not expire.	6 years ago
Alexander Zobnin	dad894f1cc	API: get list of users with additional auth info (#17305) ... * batch disable users * batch revoke users tokens * split batch disable user and revoke token * API: get users with auth info and isExternal flag * fix tests for batch disable users * Users: refactor /api/users/search endpoint * Users: use alias for "user" table * Chore: add BatchDisableUsers() to the bus * Users: order user list by id explicitly * Users: return AuthModule from /api/users/:id endpoint * Users: do not return unused fields * Users: fix SearchUsers method after last changes * User: return auth module as array for future purposes * User: tests for SearchUsers() * User: return only latest auth module in SearchUsers() * User: fix JOIN, get only most recent auth module	6 years ago
Marcus Efraimsson	5713048f48	Alerting: Improve alert rule testing (#16286) ... * tsdb: add support for setting debug flag of tsdb query * alerting: adds debug flag in eval context Debug flag is set when testing an alert rule and this debug flag is used to return more debug information in test aler rule response. This debug flag is also provided to tsdb queries so datasources can optionally add support for returning additional debug data * alerting: improve test alert rule ui Adds buttons for expand/collapse json and copy json to clipboard, very similar to how the query inspector works. * elasticsearch: implement support for tsdb query debug flag * elasticsearch: embedding client response in struct * alerting: return proper query model when testing rule	6 years ago