grafana

Commit Graph

Author	SHA1	Message	Date
Leonor Oliveira	67b74e1e8a	Dual writer: mode 3 (#90045 ) * Dual writer: mode 3 * Add integration tests for playlits in mode 3 * Remove todo * Update pkg/apiserver/rest/dualwriter_mode3.go Co-authored-by: Arati R. <33031346+suntala@users.noreply.github.com> * Admin: Fixes an issue where user accounts could not be enabled (#88117) Fix: unable to enable user * [REVIEW] FInish mode 3 and add tests * Improve logging * Update dependencies * Update pkg/apiserver/rest/dualwriter_mode3_test.go Co-authored-by: maicon <maiconscosta@gmail.com> * remove test assertion * Use mode log when dual writer is initiated --------- Co-authored-by: Arati R. <33031346+suntala@users.noreply.github.com> Co-authored-by: gonvee <gonvee@qq.com> Co-authored-by: maicon <maiconscosta@gmail.com>	10 months ago
maicon	93221f12da	Unified Storage: Fix Compare method (#90455 ) * Unified Storage: Fix Compare method Signed-off-by: Maicon Costa <maiconscosta@gmail.com> --------- Signed-off-by: Maicon Costa <maiconscosta@gmail.com>	10 months ago
Todd Treece	66a384247c	Storage: Fix list in mode 4 (#90354 )	10 months ago
Ryan McKinley	d2bc4f3255	DualWrite: Cleanup and centralize the dual write creation (#90013 )	11 months ago
Leonor Oliveira	d0afa60feb	Remove unused metric (#90327 )	11 months ago
Leonor Oliveira	b75276c641	Fix outcome metric (#90322 )	11 months ago
Leonor Oliveira	ec6a939815	Compare results when reading/writing between unified_storage and legacy (#89773 ) * Compare results when reading/writing between unified_storage and legacy * Always use name when comparing objects * Compare on get method * Update pkg/apiserver/rest/dualwriter.go Co-authored-by: Dan Cech <dcech@grafana.com> * Add new metric to count how many times we read from legacy in mode 2 * Move counter * Add name in mode1 --------- Co-authored-by: Dan Cech <dcech@grafana.com>	11 months ago
Todd Treece	9c6d3590a2	Chore: Fix apiserver circular dependencies (#89918 )	11 months ago
Leonor Oliveira	2645958c8c	Use global function to compare any entity to both stores (#89282 ) * WIP implement generic compare interface * Use global compare fn for all entities * Lint * Update pkg/apiserver/rest/dualwriter.go Co-authored-by: Dan Cech <dcech@grafana.com> * Don't need to hash, just compare bytes * Fix tests --------- Co-authored-by: Dan Cech <dcech@grafana.com>	11 months ago
Leonor Oliveira	e216de56e6	Unified Storage: Always populate RV and UID on create (#89554 )	11 months ago
Ryan McKinley	9b7f9ae22e	K8s: Rename origin.key to origin.hash (#89337 )	11 months ago
Leonor Oliveira	1691d80412	Refactor enrichObj function (#89210 )	11 months ago
Leonor Oliveira	fd44f2ee4f	Init dualwriter metrics (#89003 ) * Pass prometheus registerer to the dual writer * Fix tests * Remove unused var * Fix tests * Uncomment test * Remove leading line * Fix tests. Reuse registerer if there's already one * Lint * Improve double registering logic * Rebase main	11 months ago
Ryan McKinley	3ae95a6eb1	K8s: Update grafana resource metadata accessor (#89074 )	11 months ago
Leonor Oliveira	b30c81b1ad	Add and fix tests for playlists in mode1 (#88543 ) * Add and fix tests for playlists in mode1 * Make etcd tests pass mode1 for now * Fix mode1 and add more tests for playlists in mode 1 * Remove repeated test * Fix test setup	12 months ago
Arati R	36f42853dd	Storage: Read desired mode from config instead of feature flags (#88353 ) * Read desired mode from config * Update playlist integration tests * Add mode 1 playlist integration tests * Add mode 0 dual writing to playlist integration tests * Add documentation for the different dual writing modes	12 months ago
Leonor Oliveira	ade96dbdbd	Introduce Comparator interface (#88016 ) * Introduce Comparator interface * Add compare implementation everywhere * Add comment explaining what Compare should do * Lint	12 months ago
Leonor Oliveira	ef07dfa3bb	Add latency metrics to mode2 (#88011 ) * Also call storage on mode1. Add metrics * Update comment * Don't use compare function for now * Remove very important space * Improve code readability on modes 1 and 2 * Fix tests * Return error from legacy write * Renume useless defer * Start adding logging for mode2 * Retrurn errors is storage read fails * Finish adding latency metrics to mode2 * Emit kind to metrics instead * Fix var name * Return if legacy delete list fails * Unify latency calls * Fix get function	12 months ago
Leonor Oliveira	502bd5612e	Storage: Extract returned object hydration into function (#88012 ) * Extract returned object hydration into function * Finish writing tests for utils func * Lint * Update pkg/apiserver/rest/dualwriter_mode2.go Co-authored-by: Arati R. <33031346+suntala@users.noreply.github.com> * Better var naming * Remove duplicated logic * Lint * Fix test * Lint * Make type private * Fix one more test * Fix test --------- Co-authored-by: Arati R. <33031346+suntala@users.noreply.github.com>	12 months ago
Arati R	0ffc4c441b	Storage: Add mode reconciliation for modes 1 and 2 (#87919 ) * Add skeleton implementation for mode reconciliation between 1 and 2 * Track mode for each dual writer * Add test for setting dual writer * Include context when setting dual writing mode --------- Co-authored-by: Dan Cech <dcech@grafana.com>	1 year ago
Leonor Oliveira	dd771e818e	Also call storage on mode1. Measure latency (#87739 ) * Also call storage on mode1. Add metrics * Update comment * Don't use compare function for now * Remove very important space * Finish add logging in mode2. Also call US in mode1 in a non blocking way * Improve code readability on modes 1 and 2 * Fix tests * Rename vars * Lint * Return error from legacy write * Renume useless defer * [REVIEW] improvements * Pass kind instead of name * Use kind instead of name in metrics * Only call latency metrics once * Return error on writes to legacystore in mode1 * Move accesssor logic into the goroutine as well	1 year ago
Arati R	6836bfe1ea	Storage: Customise setting dual writing modes (#87668 ) * Add feature toggles for mode 2 and 3 playlist dual writing * Make current mode customised based on kind * Check feature flags when initialising dual writer * Fix linting * Refactor NewDualWriter	1 year ago
Leonor Oliveira	b214f9cc3a	Add metrics utils to the dualwriter (#87693 ) * Add metrics utils * Ignore lint temporarily * Lint	1 year ago
Leonor Oliveira	ee2f6a7b49	Force interface implementation also on legacy storage (#87414 ) * Force interface implementation also on legacy storage * Add DeleteCollection to folders and dashboards * Fix integration tests * Fix tests	1 year ago
Leonor Oliveira	0a2c5065a0	Choose mode. Turn DualWriter into a real interface. Better Logging (#87291 ) * Choose mode. Add log field on top level dualwriter * Add logs * Turn DualWriter into a full interface. Fix tests * Lint * Use struct for dualWriter interface * Use struct * Default should be legacyStore for all entities * Fix test. Get rid of extra concrete type * Remove comment * Add comment * Temp set dualwriter mode 2 for playlists while configs are not in place * Add modes type + add comment on what each mode does * Don't require watcher interface for now * Use storage implementation on mode 2 * Update pkg/apiserver/rest/dualwriter_mode2.go Co-authored-by: Todd Treece <360020+toddtreece@users.noreply.github.com> * Pass log values to the context * test * Update pkg/apiserver/rest/dualwriter_mode3.go Co-authored-by: Dan Cech <dcech@grafana.com> --------- Co-authored-by: Todd Treece <360020+toddtreece@users.noreply.github.com> Co-authored-by: Dan Cech <dcech@grafana.com>	1 year ago
Arati R	9e6de035c0	Storage: Add mode 2 dual writing improvements (#87204 ) * Fix mode 2 List test * Set origin timestamp during conversion to k8s resource * Add instructions for updating a playlist * Handle partial deletions of a collection in mode 2	1 year ago
Arati R	61f3d08c3f	Storage: Add List support for pagination (#87093 ) * Add origin keys to List request * Check origin keys requirement in the sql entity server's List method * Refactor mode 2 List * Check origin keys before making Storage List call --------- Co-authored-by: Dan Cech <dcech@grafana.com>	1 year ago
Leonor Oliveira	9baf96dbd2	Storage: dualwriter update implementation (#85844 ) * Add update methods for the dual writer * improve errors * [WIP] add tests for the update method * Move example package to its own package so it can be used by the rest package. Finish tests * Add codeowners * Use Pod as a dummy resource * :int * Lint * [REVIEW] rename var * [REVIEW] don't rely on legacy storage at all in mode4 * Update pkg/apiserver/rest/dualwriter_mode2.go Co-authored-by: Arati R. <33031346+suntala@users.noreply.github.com> * [REVIEW] improve comment * Update pkg/apiserver/rest/dualwriter_mode1.go Co-authored-by: Dan Cech <dcech@grafana.com> * [REVIEW] improve mode3 * Lint * Move test files * Update pkg/apiserver/rest/dualwriter_mode2.go Co-authored-by: Arati R. <33031346+suntala@users.noreply.github.com> * Lint * Update pkg/apiserver/rest/dualwriter_mode4_test.go Co-authored-by: Arati R. <33031346+suntala@users.noreply.github.com> * Fix error * Lint * Update pkg/apiserver/rest/dualwriter_mode2.go Co-authored-by: Arati R. <33031346+suntala@users.noreply.github.com> * Don't set the flag to true as updatedObj creates an object in case it's not found * Lint * Lint * Add tests on update * Lint --------- Co-authored-by: Arati R. <33031346+suntala@users.noreply.github.com> Co-authored-by: Dan Cech <dcech@grafana.com>	1 year ago
Leonor Oliveira	dcfaf7e434	Storage: Add dualwriter test mocks (#86243 ) * WIP: add mocks for dual writer * Test dualwriter mode1 * Re-add non implementation errors * Use testify assert * Write tests for mode2. * Lint * Remove comment * Update pkg/apiserver/rest/dualwriter_mode2_test.go Co-authored-by: Arati R. <33031346+suntala@users.noreply.github.com> * [REVIEW improve readability and call fn legacy fn * [REVIEW] rename mocks and setupFns * [REVIEW add missing test case * [REVIEW] add test case with getting object from storage and not legacy * Add deleteCollection * Test deleteCollection * Rename file --------- Co-authored-by: Arati R. <33031346+suntala@users.noreply.github.com>	1 year ago
Arati R	79eab65f94	Storage: Add mode-specific DeleteCollection implementations (#86065 ) * Add DeleteCollection methods to modes 1 and 4 * Add DeleteCollection implementations for modes 2 and 3	1 year ago
Leonor Oliveira	d17af78e79	Storage: dualwriter delete implementation (#86000 ) * Add delete methods * Remove duplicated const * Add tests * Lint * Lint * Remove duplicated test file * Update pkg/apiserver/rest/dualwriter_mode2.go Co-authored-by: Arati R. <33031346+suntala@users.noreply.github.com> * Update pkg/apiserver/rest/dualwriter.go Co-authored-by: Arati R. <33031346+suntala@users.noreply.github.com> * Update pkg/apiserver/rest/dualwriter_mode2.go Co-authored-by: Arati R. <33031346+suntala@users.noreply.github.com> * Add missing dependency * Return if object deletion goes wrong * Add a more complete log --------- Co-authored-by: Arati R. <33031346+suntala@users.noreply.github.com>	1 year ago
Arati R	aba15646b6	Storage: Add DualWriter improvements (#85968 ) * Add Create tests * Adjust mode 2 and mode 3 Get behavior --------- Co-authored-by: Dan Cech <dcech@grafana.com>	1 year ago
Arati R	4e532b00e1	Storage: Add mode-specific List implementations (#85814 ) * Add List methods to mode 1 and 4 * Refactor errors	1 year ago
Leonor Oliveira	518d3341d5	Add Get method in dual writer (#85589 ) * Add Get method in dual writer * Update pkg/apiserver/rest/dualwriter_mode3.go Co-authored-by: Dan Cech <dcech@grafana.com> * Actually run the tests * no need for t.Run() * Update pkg/apiserver/rest/dualwriter_mode3.go Co-authored-by: Dan Cech <dcech@grafana.com> * Update pkg/apiserver/rest/dualwriter_mode3.go Co-authored-by: Dan Cech <dcech@grafana.com> * Update pkg/apiserver/rest/dualwriter_test.go Co-authored-by: Dan Cech <dcech@grafana.com> * Log improvements * Fix method name --------- Co-authored-by: Dan Cech <dcech@grafana.com>	1 year ago
Leonor Oliveira	8d75dcec04	Add better logging to the dual writer (#85594 ) * Make Legacy a public field * Remove duplicated Create method * Add logger to dualwriter * Use klog * Add comment about selecting the dual writer * Update pkg/apiserver/rest/dualwriter_mode1.go Co-authored-by: Arati R. <33031346+suntala@users.noreply.github.com> * Update pkg/apiserver/rest/dualwriter_mode2.go Co-authored-by: Arati R. <33031346+suntala@users.noreply.github.com> * Update pkg/apiserver/rest/dualwriter_mode3.go Co-authored-by: Arati R. <33031346+suntala@users.noreply.github.com> * Update pkg/apiserver/rest/dualwriter_mode3.go Co-authored-by: Arati R. <33031346+suntala@users.noreply.github.com> * Update pkg/apiserver/rest/dualwriter_mode2.go Co-authored-by: Arati R. <33031346+suntala@users.noreply.github.com> * Create error var * Lint --------- Co-authored-by: Arati R. <33031346+suntala@users.noreply.github.com>	1 year ago
Arati R	2232fe033b	Storage: Add mode-specific dual writers (#85551 ) * Set up skeleton dual writers for each mode * Add Create functionality to each of the mode-specific DualWriters * Add switch for selecting DualWriter	1 year ago
Leonor Oliveira	01afca9d99	Add setup and spies for the dual writer (#85568 ) * Add setup and spy client for dual writer * Get rid of reset method	1 year ago
Todd Treece	e5a26a3f7c	K8s: Add apimachinery and apiserver packages (#83190 )	1 year ago

38 Commits (67b74e1e8a7d26d24617b7313b90fa4649138318)