24 Commits (694600ed0472fb0c5acb1ffb408e36e1e2d091fa)

Author	SHA1	Message	Date
Jack Westbrook	694600ed04	Catalog: Provide default tab fallback in Plugin Details page (#41979) ... * feat(catalog): introduce defaultTab to usePluginDetailsTabs hook * feat(catalog): use defaultTab as fallback tab for PluginDetails * chore(catalog): remove hardcoded page query param in list items * refactor(catalog): prefer let over react ref when setting default tab in PluginDetails * refactor(catalog): pass pageId to plugin details body rather than duplicate logic * test(catalog): remove query param from List item test hrefs * test(catalog): introduce a test for default app config page for installed app plugins	4 years ago
Levente Balogh	35c2c95fdc	Plugins: remove deprecated code (components) (#41686) ... * refactor(plugins): use routes specific to the new plugins/admin * refactor(plugins): remove unused pages (PluginList, PluginItem) * refactor(plugins): remove PluginPage * refactor(plugins): remove UpdatePluginModal * refactor(plugins): move AppConfigWrapper under plugins/admin * refactor(plugins): move PluginDashboards under plugins/admin * refactor(plugins): rename the "specs" folder to "tests" * refactor(plugins): move test files to /tests folder * refactor(plugins): move AppRootPage into a /components folder * refactor(plugins): move PluginsErrorsInfo into a /plugins folder * refactor(plugins): move PluginSettingsCache into a /components folder * refactor(plugins): move PluginStateInfo into a /plugins folder * refactor(plugins): move AppRootPage.test.tsx next to the tested component * refactor(plugins): remove old snapshot tests * fix(plugins): fix tests * refactor(plugins/admin): move & rename PluginSettingsCache * fix(plugins): fix a few rebase issues * Plugins: remove deprecated code (state handling) (#41739) * refactor(plugins): use the plugins/admin reducer only * refactor(plugins): remove tests for the deprecated plugins reducer * refactor(plugins): remove tests for the deprecated plugins selectors * refactor(plugins/state): add a short comment note to selectors * feat(plugins/state): add a selector for selecting errors * feat(plugins/state): add a hook for getting plugin errors * refactor(plugins): udpate the PluginsErrorsInfo component to use the new state selectors * refactor(plugins/state): remove the old (deprecated) selectors * refactor(plugins/state): use the new actions under /admin * refactor(plugins/state): remove old (deprecated) reducers and actions * refactor(plugins): update component definition * fix(plugins): remove unnecessary {children} prop for PluginsErrorsInfo * Plugins: show / hide install controls based on the `pluginAdminEnabled` flag (#41749) * docs(plugins): update documentation for the `plugin_admin_enabled` flag * refactor(InstallControls): move the main component to a named module * feat(plugins): use the `pluginAdminEnable` flag to hide / show install controls in the UI * test(plugins): add tests for enabling/disabling install controls	4 years ago
Levente Balogh	9c2a947605	Plugins Catalog: add support for enable/disable app plugins (#41801) ... * refactor(plugins): add empty line between methods * feat(api): add an API function for updating plugin settings * feat(plugins): add a "getting started" guide for enabling / disabling app plugins * test(plugins/admin): add tests for enable/disable functionality * refactor(plugins/admin): update the name of the test cases Now that we have multiple type of post-installation steps it probably makes sense.	4 years ago
Marcus Andersson	487baf5a25	PluginsCatalog: hiding version history tab and install controls for plugins not published to grafana-com (#41634) ... * will hide the version tab for core plugins. * will not try to fetch the version list if plugin is local. * added the concept wheter or not a plugin is published or not. * Update public/app/features/plugins/admin/pages/PluginDetails.test.tsx Co-authored-by: Levente Balogh <balogh.levente.hu@gmail.com> * Update public/app/features/plugins/admin/types.ts Co-authored-by: Levente Balogh <balogh.levente.hu@gmail.com> * removed unused api functions. * fix(plugins/admin): fix a tiny linter issue Co-authored-by: Levente Balogh <balogh.levente.hu@gmail.com>	4 years ago
Jack Westbrook	3c3cf2eee9	Plugins Catalog: Install and show the latest compatible version of a plugin (#41003) ... * fix(catalog): prefer rendering installed version over latest version * feat(catalog): signify installed version in version history * feat(catalog): introduce installedVersion and latestVersion * refactor(catalog): use latestVersion for installation, simplify plugindetails header logic * refactor(catalog): clean up installedVersion and latestVersion * feat(catalog): use table-layout so versions list table has consistent column widths * test(catalog): update failing tests * removed the need of having a latest version in the plugin catalog type root level. * fixed flaky test depending on what locale it was being running with. * added missing test to verify version for a remote plugin. * fixed version in header. * preventing the UI from break if no versions are available. * fixed failing test due to missing mock data. * added todo as a reminder. * refactor(catalog): prefer grafana plugin icons over gcom notfound images * refactor(Plugins/Admin): change constant name * refactor(Plugins/Admin): add comment to make condition easier to understand * chore: update go modules * feat(Backend/Plugins): add "dependencies" field to `PluginListItem` * feat(Plugins/Admin): show the grafana dependency for the installed version * refactor(Plugins/Admin): use the local version of links * refactor(Plugins/Admin): prefer the local version for `.type` * refactor(Plugins/ADmin): prefer the local `.description` field * fix(Plugins/Admin): fix tests * test(plugins/api): update the expected response for the `api/plugins` tests * chore(Plugins/Admin): add todo comments to check preferation of remote/local values * feat(backend/api): always send the grafana version as a header when proxying to GCOM * feat(plugins/admin): use the `isCompatible` flag to get the latest compatible version * feat(plugins/admin): show the latest compatible version in the versions list * fix(plugins/admin): show the grafana dependency for the latest compatible version * fix(plugins/admin): update the version list when installing/uninstalling a plugin * test(plugins/admin): add some test-cases for the latest-compatible-version * fix(plugins/admin): show the grafana dependency for the installed version (if installed) * feat(plugins/backend): add the `dependencies.grafanaDependency` property to the plugin object * test(plugins/backend): fix tests by adjusting expected response json Co-authored-by: Marcus Andersson <marcus.andersson@grafana.com> Co-authored-by: Levente Balogh <balogh.levente.hu@gmail.com>	4 years ago
Will Browne	b80fbe03f0	Plugins: Refactor Plugin Management (#40477) ... * add core plugin flow * add instrumentation * move func * remove cruft * support external backend plugins * refactor + clean up * remove comments * refactor loader * simplify core plugin path arg * cleanup loggers * move signature validator to plugins package * fix sig packaging * cleanup plugin model * remove unnecessary plugin field * add start+stop for pm * fix failures * add decommissioned state * export fields just to get things flowing * fix comments * set static routes * make image loading idempotent * merge with backend plugin manager * re-use funcs * reorder imports + remove unnecessary interface * add some TODOs + remove unused func * remove unused instrumentation func * simplify client usage * remove import alias * re-use backendplugin.Plugin interface * re order funcs * improve var name * fix log statements * refactor data model * add logic for dupe check during loading * cleanup state setting * refactor loader * cleanup manager interface * add rendering flow * refactor loading + init * add renderer support * fix renderer plugin * reformat imports * track errors * fix plugin signature inheritance * name param in interface * update func comment * fix func arg name * introduce class concept * remove func * fix external plugin check * apply changes from pm-experiment * fix core plugins * fix imports * rename interface * comment API interface * add support for testdata plugin * enable alerting + use correct core plugin contracts * slim manager API * fix param name * fix filter * support static routes * fix rendering * tidy rendering * get tests compiling * fix install+uninstall * start finder test * add finder test coverage * start loader tests * add test for core plugins * load core + bundled test * add test for nested plugin loading * add test files * clean interface + fix registering some core plugins * refactoring * reformat and create sub packages * simplify core plugin init * fix ctx cancel scenario * migrate initializer * remove Init() funcs * add test starter * new logger * flesh out initializer tests * refactoring * remove unused svc * refactor rendering flow * fixup loader tests * add enabled helper func * fix logger name * fix data fetchers * fix case where plugin dir doesn't exist * improve coverage + move dupe checking to loader * remove noisy debug logs * register core plugins automagically * add support for renderer in catalog * make private func + fix req validation * use interface * re-add check for renderer in catalog * tidy up from moving to auto reg core plugins * core plugin registrar * guards * copy over core plugins for test infra * all tests green * renames * propagate new interfaces * kill old manager * get compiling * tidy up * update naming * refactor manager test + cleanup * add more cases to finder test * migrate validator to field * more coverage * refactor dupe checking * add test for plugin class * add coverage for initializer * split out rendering * move * fixup tests * fix uss test * fix frontend settings * fix grafanads test * add check when checking sig errors * fix enabled map * fixup * allow manual setup of CM * rename to cloud-monitoring * remove TODO * add installer interface for testing * loader interface returns * tests passing * refactor + add more coverage * support 'stackdriver' * fix frontend settings loading * improve naming based on package name * small tidy * refactor test * fix renderer start * make cloud-monitoring plugin ID clearer * add plugin update test * add integration tests * don't break all if sig can't be calculated * add root URL check test * add more signature verification tests * update DTO name * update enabled plugins comment * update comments * fix linter * revert fe naming change * fix errors endpoint * reset error code field name * re-order test to help verify * assert -> require * pm check * add missing entry + re-order * re-check * dump icon log * verify manager contents first * reformat * apply PR feedback * apply style changes * fix one vs all loading err * improve log output * only start when no signature error * move log * rework plugin update check * fix test * fix multi loading from cfg.PluginSettings * improve log output #2 * add error abstraction to capture errors without registering a plugin * add debug log * add unsigned warning * e2e test attempt * fix logger * set home path * prevent panic * alternate * ugh.. fix home path * return renderer even if not started * make renderer plugin managed * add fallback renderer icon, update renderer badge + prevent changes when renderer is installed * fix icon loading * rollback renderer changes * use correct field * remove unneccessary block * remove newline * remove unused func * fix bundled plugins base + module fields * remove unused field since refactor * add authorizer abstraction * loader only returns plugins expected to run * fix multi log output	4 years ago
Marcus Andersson	fe11a31175	PluginsCatalog: disable post-installation steps if user does not have sufficient permissions (#40853) ... * added missing permissions check * moved the permission check to the datasource component. * added test for checking permissions. * added tests with different permissions. * minor refactoring so the mockUserPermisson can be reused.	4 years ago
Marcus Andersson	79ce09ddee	PluginsCatalog: post installation, adding an "add datasource"-button. (#40155) ... * added post installation steps. * changes according to feedback. * removing return union null type. * added tests. * changing the wording of the button to 'create a..' * updated tests to check for the updated copy. * changing the back to be a regular back button. * updated snapshot	4 years ago
renovate[bot]	09587240ec	Update dependency @testing-library/react to v12 (#40382) ... * Update dependency @testing-library/react to v12 * Don't use wrapper syntax Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com>	4 years ago
Levente Balogh	c2754eb9cc	Plugins Catalog: Make the catalog the default way to interact with plugins (#39779) ... * chore(Plugins/Admin): make the Plugins Catalog the default way to interact with plugins * chore(defaults.ini): change the default value for `plugin_admin_enabled` * test(Plugins): make the tests pass	4 years ago
Jack Westbrook	fffcee7c1f	Plugin Catalog: support Grafana instances that cannot communicate with gcom (#39638) ... * added possibility to track if remote plugins could be fetched. * adding hook to detect if remote plugins are available. * feat(catalog): disable installed/all filter if remote plugins are unavailable * feat(Plugins/Admin): hide the install controls if GCOM is not available * refactor(Plugins/Admin): group `@grafana` dependencies * fix(Plugins/Admin): don't show an error alert if a remote plugin is not available * feat(Plugins/Admin): prefer to use the local version of the readme * chore(Plugins/Admin): type the mocked state properly * test(Plugins/Admin): add tests for the Plugin Details when GCOM is not available * test(Plugins/Admin): add tests for the Browse when GCOM is not available Co-authored-by: Marcus Andersson <marcus.andersson@grafana.com> Co-authored-by: Levente Balogh <balogh.levente.hu@gmail.com>	4 years ago
Jack Westbrook	4dc556445c	Plugin Catalog: Use routing for PluginDetails Tabs (#39555) ... * feat(catalog): introduce id and href to PluginDetailsTabs * feat(catalog): add hrefs and ids to PluginDetails tabs. Pass queryParams to PluginDetailsBody * feat(catalog): pass queryParams to PluginsDetailsBody and add page param to PluginListCard * fix(catalog): prevent flicker of content by waiting for fetch details to finish loading * feat(catalog): add tab icons to PluginDetails page * feat(catalog): make breadcrumbs in PluginDetailsHeader aware of page queryparam * fix(catalog): fix deeplinking to PluginDetails by comparing tabs length * test(catalog): update tests with correct props and wrap in router	4 years ago
Levente Balogh	660afc6279	Plugins Catalog: add a few more tests (#39433) ... * refactor(Plugins/Admin): add an extra line-break between tests * test(Plugins/Admin): add a couple of more tests for Plugin Details * fix(Plugins/Admin): fix accidental linting issue	4 years ago
Marcus Andersson	f3002931f4	PluginsCatalog: adding error information about disabled plugins. (#39171) ... * added errors in plugin list. * added error to details page. * adding badge on details page. * added some more tests. * Renamed to disabled and will handle the scenario in the plugin catalog. * Update public/app/features/plugins/admin/components/PluginDetailsDisabledError.tsx Co-authored-by: Levente Balogh <balogh.levente.hu@gmail.com> * fixing some nits * added missing isDisabeld to the mock. * adding tests to verify scenarios when plugin is disabled. * fixed issue with formatting after file changed on GH. Co-authored-by: Levente Balogh <balogh.levente.hu@gmail.com>	4 years ago
Levente Balogh	02f9564607	Plugins Catalog: show a confirmation modal when uninstalling a plugin (#39244) ... * feat(Plugins/Admin): show a confirmation modal when uninstalling a plugin * refactor(Plugins/Admin): use a helper function for showing/hiding the modal * test(Plugins/Admin): test if the modal disappears after an uninstall	4 years ago
Levente Balogh	3c433dc36d	Plugins Catalog: refactor the mocking for our tests (#39165) ... * refactor(Plugins/Admin): add a type for version coming back from the API * refactor(Plugins/Admin): only add necessary version information to the state * test(Plugins/Admin): add a mock for a CatalogPlugin * test(Plugins/ADmin): add a mock for a LocalPlugin * test(Plugins/Admin): add a test for a RemotePlugin * test(Plugins/Admin): add helpers for mocking plugin states * refactor(Plugins/Admin): mock the Redux state instead of the API responses This makes it simpler to add new test cases and also makes the tests easier to reason about. * refactor(Plugins/Admin): mock the Redux state instead of the API responses	4 years ago
Levente Balogh	9173898fd6	Plugins Catalog: show Grafana and plugin dependencies (#39062) ... * fix(@grafana/data): add a missing optional field to the plugin types * refactor(Plugins/ADmin): use the type from @grafana/data for plugin dependencies * fix(Datasources/Graphite): add missing `state` to useEffect dependencies * refactor(Plugins/Admin): remove unnecessary comment * feat(Plugins/Admin): add plugin and grafana dependencies to the CatalogPluginDetails * feat(Plugins/ADmin): show Grafana dependency under plugin details * feat(Plugins/Admin): show grafana and plugin dependencies for a plugin * test(Plugins/Admin): add a smoke test for plugin dependencies * refactor(Plugins/Admin): remove unused style from the header	4 years ago
Levente Balogh	1133e56006	Plugins Catalog: migrate state handling to Redux (#38876) ... * feat(Plugins/Catalog): start adding necessary apis * feat(PLugins/Catalog): add extra helpers for merging local & remote plugins * feat(Plugins/Catalog): add plugin details as an optional field of CatalogPlugin * feat(PLugins/Catalog): add scaffolding for the new redux model * feat(PLugins/Catalog): export reducers based on a feature-flag * refactor(Plugins/Admin): rename api methods * feat(Plugin/Catalog): add an api method for fetching a single plugin * feat(Plugins/Admin): try cleaning stuff around plugin fetching * ffeat(Plugins/Catalog): return the catalog reducer when the feature flag is set * refactor(Plugins/Admin): fix typings * feat(Plugins/Admin): use the new reducer for the browse page * feat(catalog): introduce selectors to search and filter plugins list * refactor(Plugins/Details): rename page prop type * refactor(Plugins/Admin): add a const for a state prefix * refactor(Plugins/Admin): use the state prefix in the actions * feat(Plugins/Admin): add types for the requests * refactor(Plugins/Admin): add request info to the reducer * refactor(Plugins/Admin): add request handling to the hooks & selectors * refactor(Plugins/Details): start using the data stored in Redux * refactor(Plugins/Admin): rename selector to start with "select" * fix(Plugins/Admin): only fetch plugins once * refactor(Plugins/Admin): make the tab selection work in details * refactor(catalog): put back loading and error states in plugin list * refactor(Plugins/Admin): use CatalogPlugin for <PluginDetailsSignature /> * feat(Plugins/Admin): add an api method for fetching plugin details * refactor(Plugins/Admin): add action for updating the details * irefactor(Plugins/Admin): show basic plugin details info * refactor(Plugin Details): migrate the plugin details header * refactor(Plugins/Admin): make the config and dashboards tabs work * refactor(Plugins/Admin): add old reducer state to the new one * feat(catalog): introduce actions, reducers and hooks for install & uninstall * refactor(catalog): wire up InstallControls component to redux * refactor(catalog): move parentUrl inside PluginDetailsHeader and uncomment InstallControls * feat(catalog): introduce code for plugin updates to install action * refactor(Plugins/Admin): add backward compatible actions * test(catalog): update PluginDetails and Browse tests to work with catalog store * refactor(Plugins/Admin): make the dashboards and panels work again * refactor(Plugins/Admin): fix linter and typescript errors * fix(Plugins/Admin): put the local-only plugins to the beginning of the list * fix(Plugins/Admin): fix the mocks in the tests for PluginDetails * refactor(Plugins/Admin): remove unecessary hook usePluginsByFilter() * refactor(Plugins/Admin): extract the useTabs() hook to its own file * refactor(Plugins/Admin): remove unused helpers and types * fix(Plugins/Admin): show the first tab when uninstalling an app plugin This can cause the user to find themselves on a dissappeared tab, as the config and dashboards tabs are removed. * fix(catalog): correct logic for checking if activeTabIndex is greater than total tabs * fix(Plugins/Admin): fix race-condition between fetching plugin details and all plugins * fix(Plugins): fix strict type errors * chore(catalog): remove todos * feat(catalog): render an alert in PluginDetails when a plugin cannot be found * feat(catalog): use the proper store state * refactor(Plugins/Admin): fetch local and remote plugins in parallell Co-authored-by: Marcus Andersson <marcus.andersson@grafana.com> * style(catalog): fix prettier error in api * fix(catalog): prevent throwing error if InstallControlsButton is unmounted during install * refactor(Plugins/Admin): add a separate hook for filtering & sorting plugins Co-authored-by: Jack Westbrook <jack.westbrook@gmail.com> Co-authored-by: Marcus Andersson <marcus.andersson@grafana.com>	4 years ago
Jack Westbrook	2cb141d4ec	Plugins: Refactor installation buttons component (#37642) ... * refactor(catalog): split out installcontrols into multiple components * test(catalog): update tests for plugindetails page * refactor(catalog): rename installcontrols -> index * refactor(catalog): remove redundant curlies Co-authored-by: Levente Balogh <balogh.levente.hu@gmail.com> * tests(plugindetails): fix assertions and naming of tests Co-authored-by: Levente Balogh <balogh.levente.hu@gmail.com> * refactor(installcontrols): prefer enum over duplicate union type, rename disabled prop * refactor(installcontrols): use PluginStatus enum for installcontrols pluginStatus * refactor(installcontrols): remove redundant curlies Co-authored-by: Levente Balogh <balogh.levente.hu@gmail.com>	4 years ago
Jack Westbrook	e21ecf237b	Catalog: Update enterprise license messaging in PluginDetails (#37547) ... * feat(catalog): change messaging if enterprise license is missing and add link * test(catalog): fix failing PluginDetails test	4 years ago
Jack Westbrook	cc7c54be0e	Plugins: Update Catalog Card UI (#37350) ... * feat(catalog): lazy load and add alt text to plugin logos * refactor(catalog): use plugin types, make sure data is available for new ui * test(catalog): fix up tests after types refactor * feat(catalog): introduce Tile and PluginBadge components for ui updates * refactor(catalog): update PluginList to use new components, lazy load images, add creditcard icon * test(catalog): update Browse.test types * fix(catalog): if local and remote make sure to get the correct local plugin from array * refactor(catalog): prefer grafana/ui components over custom Tile component * chore(catalog): delete redundant components * feat(catalog): introduce ascending descending name sort for Browse * refactor(catalog): prefer theme spacing over hardcoded values * refactor(catalog): update Local and Remote plugin types to match api responses * fix(catalog): prefer local.hasUpdate and local.signature so updateable plugin signature is valid * test(catalog): update test plugin mocks * test(catalog): add tests for sorting and categorise * test(catalog): add tests for plugin cards, remove grid component * test(catalog): add tests for PluginBadges component * refactor(catalog): change enterprise learn more link to open plugin page on website	4 years ago
Jack Westbrook	cdcccfcc53	Plugins: Fix catalog permissions for org and server admins (#37504) ... * simplify toggle + add link to server admin * feat(catalog): org admins can configure plugin apps, cannot install/uninstall plugins * fix(catalog): dont show buttons if user doesn't have install permissions * feat(catalog): cater for accessing catalog via /plugins and /admin/plugins * feat(catalog): use location for list links and match.url to define breadcrumb links * test(catalog): mock isGrafanaAdmin for PluginDetails tests * test(catalog): preserve default bootdata in PluginDetails mock * refactor(catalog): move orgAdmin check out of state and make easier to reason with Co-authored-by: Will Browne <will.browne@grafana.com>	4 years ago
Jack Westbrook	dcc6663801	Plugins: Don't show uninstall button for core plugins in catalog (#36671) ... * fix(catalog): don't show un/install buttons if core plugin * test(catalog): add PluginDetails test case for core plugins	4 years ago
Marcus Andersson	2fb385c192	Plugins: display enterprise plugins in the plugins catalog (#36599) ... * displaying enterprise plugins in the list. * added place holder for tests and removed unused code. * added test for the browse page. * added empty test file. * added some more tests.	4 years ago