grafana

Commit Graph

Author	SHA1	Message	Date
Arati R	20ffbbc41e	NestedFolders: Add library panels counting and deletion to folder registry (#69149 ) * Expose library element service's folder service * Register library panels, add count implementation * Expand folder counts test * Update registry deletion method interface * Allow getting library elements from any folder * Add test for library panel deletion * Add test for library panel counting	2 years ago
Arati R	6cb1a5e368	Nested folders: Add alert rule counts and deletion to folder registry (#67259 ) * Let alert rule service implement registry service * Add count method to RuleStore interface * Add implementation for deletion of alert rules * Rename uid to folderUID in registry methods * Check forceDeleteRule value for registry deletion * Register alerting store with folder service * Move folder test functions to separate package * Add testing for alert rule counting, deletion * Remove redundant count method * Fix deleteChildrenInFolder signature * Update pkg/services/ngalert/store/alert_rule.go Co-authored-by: Sofia Papagiannaki <1632407+papagian@users.noreply.github.com> * Add tests for nested folder deletion * Refactor TestIntegrationNestedFolderService * Add rules store as parameter for alertng provider --------- Co-authored-by: Sofia Papagiannaki <1632407+papagian@users.noreply.github.com>	2 years ago
Arati R	a5206a1cda	Nested folders: Provide count of all descendant dashboards and folders (#67184 ) * Add a method for getting descendant folders * Include dashboard count for descendant folders * Return subfolder count * Replace references to children with descendants * Update openapi specs * Add test for descendant counts * Add logging to GetDescendantCounts	2 years ago
Eric Leijonmarck	b93f26f29d	RBAC: Update TestIntegrationFolderService remove RBAC setting (#67052 ) * remove the RBAC configuration setting * add back tests	2 years ago
Arati R	fd434cab58	NestedFolders: Add API endpoint for descendant count in a folder (#66550 ) * Add CountInFolder to RegistryService interface * Add folder children counts api route * Update fake GetFolderChildrenCounts * Add test for getting folder children counts * Add validation to folder children counts handler * Update openapi specs * Update pkg/services/folder/folderimpl/folder.go Co-authored-by: Sofia Papagiannaki <1632407+papagian@users.noreply.github.com> --------- Co-authored-by: Sofia Papagiannaki <1632407+papagian@users.noreply.github.com>	2 years ago
Ieva	7860ca6c3d	RBAC: protect folder creation and moving (#64636 ) * protect moving folders to a subfolder and creating folders in a subfolder * folder update endpoint isn't used for folder parent update * lint * move permission check logic to services, fix tests * linting	2 years ago
ying-jeanne	6974f4340b	NestedFolders: Fix nested folder deletion (#63572 ) --------- Co-authored-by: suntala <arati.rana@grafana.com> Co-authored-by: ying-jeanne <ying-jeanne@users.noreply.github.com> Co-authored-by: jeanne0731 <jeanne0731@users.noreply.github.com>	2 years ago
Ieva	4570131fe5	Folders: simplify guardian permissions checks (#63183 ) simplify code	2 years ago
Sofia Papagiannaki	225c8dbba7	Chore: Fix fetching the General folder when nested folders is set and improve error handling (#62951 ) * Nested folders: Modify Get() not to fail fetching the General folder * Add test	2 years ago
Ieva	078639abcd	RBAC: add folder UID scope resolver (#62695 ) * add folder uid scope resolver * undo guardian change, move it to a separate PR * fix test + linting	2 years ago
Ryan McKinley	b1e58eb47e	Chore: Replace short UID generation with more standard UUIDs (#62731 )	2 years ago
Sofia Papagiannaki	f143b0a5b2	Chore: Move folder store interface, implementation and test under pkg/services/folder (#62586 ) * Chore: Move folder store into folder service package * Split folder and dashboard store implementations	2 years ago
Ieva	ee3d742c7d	RBAC: inherit folder permissions when resolving managed permissions (#62244 ) * add nested folder scope inheritance to managed permission services * add a more specific erorr * remove circular dependencies * use errutil for returning erorr * fix tests * fix tests * define a new error in ac package	2 years ago
idafurjes	b54b80f473	Chore: Remove Result from dashboard models (#61997 ) * Chore: Remove Result from dashboard models * Fix lint tests * Fix dashboard service tests * Fix API tests * Remove commented out code * Chore: Merge main - cleanup	2 years ago
idafurjes	421976e919	Chore: Remove folders from models pkg (#61853 )	2 years ago
Sofia Papagiannaki	c7a7ebd3e0	Chore: Drop search service dependency from folder service (#61789 ) * Chore: Drop search service dependency from folder service	2 years ago
Sofia Papagiannaki	c104cc7020	Chore: Split folder store and dashboard store interfaces (#61655 ) * update folder store mock * Split folder store and dashboard store interfaces	2 years ago
Sofia Papagiannaki	b80c9bb974	Chore: Drop dashboard service dependency from folder service (#61614 ) * Chore: Drop dashboard dependency from folder service	2 years ago
idafurjes	b573b19ca3	Chore: Remove dashboards from models pkg (#61578 ) * Copy dashboard models to dashboard pkg * Use some models from current pkg instead of models * Adjust api pkg * Adjust pkg services * Fix lint * Chore: Remove dashboards models * Remove dashboards from models pkg * Fix lint in tests * Fix lint in tests 2 * Fix for import in auth * Remove newline * Revert unused fix	2 years ago
Sofia Papagiannaki	f25d5199c5	Chore: Fix folder service tests (#61659 ) * Chore: Fix folder service tests	2 years ago
idafurjes	7c2522c477	Chore: Move dashboard models to dashboard pkg (#61458 ) * Copy dashboard models to dashboard pkg * Use some models from current pkg instead of models * Adjust api pkg * Adjust pkg services * Fix lint	2 years ago
Sofia Papagiannaki	4df78cebc2	Nested Folders: Unify folder services (#60390 ) * Nested Folders: Unify folder services	3 years ago
Sofia Papagiannaki	55b014974d	Nested folders: Refactor folder update (#60323 ) * Nested folders: Refactor folder update * Apply suggestions from code review	3 years ago
Sofia Papagiannaki	b1ef5ab320	Nested Folders: Support listing nested folder children (#58566 ) * Nested Folders: Support listing nested folder children * Filter out subfolders with no permissions * Apply suggestion from code review	3 years ago
ying-jeanne	b059296cb0	[nested folder]Add circular reference detection in create nested folder (#60163 ) * add circulic reference detection in create neste folder * redeclare mock * add log for getHeight when depassing limit	3 years ago
ying-jeanne	1131bac5da	[Nested Folder] Block move operation that could introduce more than 8 level of depth,… (#59832 ) * block move operation that could introduce more than 8 level of depth, forbid circular reference * move getHeight to store, mock store in service * fix linter	3 years ago
Sofia Papagiannaki	798a8ceb9c	Nested folders: Fix delete (#59627 ) * Fix deleting subfolder It used to fail with beause of missing signed in user * Add logging * fixup * Fail request if deleting nested folder has failed Before we only used to log the error * Fix failing test During failed nested folder creation call the dashboard store deletion instead of the service one.	3 years ago
Sofia Papagiannaki	8e6d343981	Nested Folders: Some API fixes (#59298 ) * Nested Folders: Fix API responses * Fix panic during deletions * Add test	3 years ago
Sofia Papagiannaki	ad96b240fc	Nested Folder: Enforce maximum nested folder depth (#59213 ) * Nested Folder: Enforce maximum nested folder depth * Cleanup * Fix logging	3 years ago
Sofia Papagiannaki	0af96936be	Nested Folders: Do not refer to the configuration for checking for the flag (#59197 ) * Nested Folders: Do not refer to the configuration for checking for the flag Use always features.IsEnabled() instead * Depend on the interface instead	3 years ago
Sofia Papagiannaki	02b6b09121	Nested Folders: Set user in the API level (#59148 )	3 years ago
idafurjes	080ea88af7	Nested Folders: Support getting of nested folder in folder service wh… (#58597 ) * Nested Folders: Support getting of nested folder in folder service when feature flag is set * Fix lint * Fix some tests * Fix ngalert test * ngalert fix * Fix API tests * Fix some tests and lint * Fix lint 2 * Fix library elements and panels * Add access control to get folder * Cleanup and minor test change	3 years ago
ying-jeanne	b13b58ebf8	Add move endpoint into folder service (#58575 ) * add move endpoint * change signatures	3 years ago
idafurjes	30f0d66983	Folder: Add implementation for Update for nested folder (#58479 ) * Add implementation for Update nested folder * Remove parent uid from Update * Fix update	3 years ago
Sofia Papagiannaki	bf5a08e039	API: Support creating a nested folder (#58508 ) * API: Support nested folder creation * Update swagger * fixup * Update pkg/api/dtos/folder.go Co-authored-by: Serge Zaitsev <serge.zaitsev@grafana.com> * Fix some tests * create legacy folder url from title and uid Co-authored-by: idafurjes <36131195+idafurjes@users.noreply.github.com> Co-authored-by: Serge Zaitsev <serge.zaitsev@grafana.com> Co-authored-by: Ida Furjesova <ida.furjesova@grafana.com>	3 years ago
ying-jeanne	accb4dea55	[Nested Folder] Delete folder methode (#58444 ) * transfer DeleteFolder changes from larger PR * finish some thingies * add the simplest delete logics * some intermedia steps * fix tests * add test * fix some comments Co-authored-by: yangkb09 <yangkb09@gmail.com>	3 years ago
Kristin Laemmert	a255c32e1a	nested folders: support creation of nested folders in folder service when feature flag is set (#58364 ) * nested folders: support creation of nested folders in folder service when feature flag is set	3 years ago
idafurjes	af2f51f196	Folder: Add folder service implementation (#58182 ) * Folder: Add folder service implementation * Add Move * Add tests * Add new servie method and adjust Update, Delete and Move * Remove contains * GetTree return children of depth one	3 years ago
Kristin Laemmert	706b301285	feat(nested folders): add CountDashboardsInFolder (#57847 ) * feat(nested folders): add CountDashboardsInFolder This commit adds a new method to the Dashboard service and stores: CountDashboardsInFolder. The command struct takes a folderUID, but the store implementation still depends on the parent folder ID. This is temporary; eventually we will replace all references to FolderIDs (associated with Dashboards) with folder UIDs. There are some unfortunate additional test changes that were necessary after generating the service & store mocks; it looks like that hasn't been generated since the last change(s). * more test updates * don't forget the service test * that didn't end up used, so bye for now * agree to disagree with the linter	3 years ago
ying-jeanne	ed98d7bc27	Chore: remove busmock (#57170 )	3 years ago
Serge Zaitsev	53baecd71f	Chore: Move folder service into a separate package (#56591 ) * Chore: move folder service interface into a separate package * copy implementation into a standalone package * move implementation and tests to the new folder package * remove leftovers from wire * add test doubles for folder service * fix tests in library panels/elements * fix provideservice in ngalert	3 years ago
Karl Persson	c08fe3a53c	RBAC: Enable rbac when creating new settings (#53531 ) * Settings: Set RBACEnabled to true by default * Remove accessControlEnabledFlag and explicitly set to false when needed * Disable rbac for tests	3 years ago
idafurjes	a14621fff6	Chore: Add user service method SetUsingOrg and GetSignedInUserWithCacheCtx (#53343 ) * Chore: Add user service method SetUsingOrg * Chore: Add user service method GetSignedInUserWithCacheCtx * Use method GetSignedInUserWithCacheCtx from user service * Fix lint after rebase * Fix lint * Fix lint error * roll back some changes * Roll back changes in api and middleware * Add xorm tags to SignedInUser ID fields	3 years ago
idafurjes	6afad51761	Move SignedInUser to user service and RoleType and Roles to org (#53445 ) * Move SignedInUser to user service and RoleType and Roles to org * Use go naming convention for roles * Fix some imports and leftovers * Fix ldap debug test * Fix lint * Fix lint 2 * Fix lint 3 * Fix type and not needed conversion * Clean up messages in api tests * Clean up api tests 2	3 years ago
Kristin Laemmert	9de00c8eb2	chore/backend: move dashboard errors to dashboard service (#51593 ) * chore/backend: move dashboard errors to dashboard service Dashboard-related models are slowly moving out of the models package and into dashboard services. This commit moves dashboard-related errors; the rest will come in later commits. There are no logical code changes, this is only a structural (package) move. * lint lint lint	3 years ago
Matthew Jacobson	5dee2ed24c	Alerting: Add first Grafana reserved label grafana_folder (#50262 ) * Alerting: Add first Grafana reserved label g_label g_label holds the title of the folder container the alert. The intention of this label is to use it as part of the new default notification policy groupBy. * Add nil check on updateRule labels map * Disable gocyclo lint on schedule.ruleRoutine will remove later in a separate refactoring PR to reduce complexity. * Address doc suggestions * Update g_folder for rules in folder when folder title changes * Remove global bus in FolderService * Modify tests to fit new common g_folder label * Add changelog entry * Fix merge conflicts * Switch GrafanaReservedLabelPrefix from `g_` to `grafana_`	3 years ago
Kat Yang	bd35e6917a	Chore: Exclude integration tests from running on test-backend step (#50359 ) * Chore: Exclude integration tests from running on test-backend step * Remove -v from go test command * Add check to skip integration tests before each integration test * Try to restart pipeline * Retrying to make pipeline run	3 years ago
Karl Persson	c4a75f9eb3	RBAC: Add scope resolvers for dashboards (#50110 ) * Inject access control into dashboard service * Add function to parse id scopes * Add dashboard as return value * Update mock * Return only err to keep service interface * Add scope resolvers for dashboard id scopes * Add function to parse uid scopes * Add dashboard uid scope resolver * Register scope resolvers for dashboards Co-authored-by: Gabriel MABILLE <gamab@users.noreply.github.com>	3 years ago
Kat Yang	c63ebc887b	Chore: Run integration tests without grabpl (#49448 ) * Chore: Run integration tests without grabpl * Add new step for integration tests in lib.star * Remove old integration test step from lib.star * Change drone signature * Fix: Edit starlark integration step to not affect enterprise * Remove all build tags & rename starlark integration test step * Resync .drone.yml with .drone.star * Fix lint errors * Fix lint errors * Fix lint errors * Fix more lint errors * Fix another lint error * Rename integration test step * Fix last lint error * Recomment enterprise step * Remove comment from Makefile Co-authored-by: Ida Furjesova <ida.furjesova@grafana.com>	3 years ago
Kat Yang	50c2b4682a	Chore: Rename integration tests (#49438 ) * Chore: Rename integration tests * Remove one Integration Co-authored-by: Ida Furjesova <ida.furjesova@grafana.com>	3 years ago

41 Commits (6d98d06f6e9680635515e16f8cb09c28c38aa104)