58 Commits (6e3a6cce61eb34e8d4c4441b7ceefa2ca29f1a7f)

Author	SHA1	Message	Date
Ezequiel Victorero	46093c1267	PublicDashboards: do not return errors when resource not found from store layer (#57838)	3 years ago
Jeff Levin	bf672f960a	public dashboards: rename api functions (#57789) ... This PR imposes better naming conventions on public dashboards api * rename api functions and remove use of _config_ noun * fix tests Co-authored-by: Ezequiel Victorero <ezequiel.victorero@grafana.com>	3 years ago
Jeff Levin	6b7d6fe0cb	public dashboards: rename route paths (#57787) ... This PR fixes the naming of routes for public dashboards to be more accurate and descriptive. Co-authored-by: Ezequiel Victorero <ezequiel.victorero@grafana.com>	3 years ago
Ezequiel Victorero	7b819284c1	PublicDashboards: use orgId when querying dashboards (#57696)	3 years ago
Ezequiel Victorero	fe9c0c881e	PublicDashboards: remove function with business logic from database layer and use it at service layer (#57684)	3 years ago
juanicabanas	e81ce1dae7	PublicDashboards: Fix GET public dashboard that doesn't match ... PublicDashboards: Fix GET public dashboard that doesn't match	3 years ago
Ezequiel Victorero	860380d893	PublicDashboards: refactor following naming convention for services (#57625)	3 years ago
Michael Mandrus	5879805e4b	PublicDashboards: Fix unsafe code snippets (#57641) ... * return an error if we can't extract queries from a panel * check for null or undefined	3 years ago
Ezequiel Victorero	c5e420a94c	PublicDashboards: move methods from store to service (#57599)	3 years ago
Ezequiel Victorero	1f3d34ecda	PublicDashboards: service and store methods rename (#57463)	3 years ago
owensmallwood	0b8fb543fc	Public Dashboards: Can toggle annotations in modal (#57312) ... adds toggle for pubdash annotations	3 years ago
Ezequiel Victorero	5b9959014c	PublicDashboards: refactor service (#57372)	3 years ago
lean.dev	552d9d70eb	PublicDashboards: Validate access token (#57298) ... Adding validation for access token	3 years ago
Ezequiel Victorero	3e6bdf0439	PublicDashboards: filter by permissions on audit list (#57228)	3 years ago
Kristin Laemmert	05709ce411	chore: remove sqlstore & mockstore dependencies from (most) packages (#57087) ... * chore: add alias for InitTestDB and Session Adds an alias for the sqlstore InitTestDB and Session, and updates tests using these to reduce dependencies on the sqlstore.Store. * next pass of removing sqlstore imports * last little bit * remove mockstore where possible	3 years ago
owensmallwood	b2408dd7c5	Publicdasboards: Add annotations support (#56413) ... adds annotations support for public dashboards	3 years ago
Misi	9c954d06ab	Auth: Refresh OAuth access_token automatically using the refresh_token (#56076) ... * Verify OAuth token expiration for oauth users in the ctx handler middleware * Use refresh token to get a new access token * Refactor oauth_token.go * Add tests for the middleware changes * Align other tests * Add tests, wip * Add more tests * Add InvalidateOAuthTokens method * Fix ExpiryDate update to default * Invalidate OAuth tokens during logout * Improve logout * Add more comments * Cleanup * Fix import order * Add error to HasOAuthEntry return values * add dev debug logs * Fix tests Co-authored-by: jguer <joao.guerreiro@grafana.com>	3 years ago
juanicabanas	71f79b9de0	PublicDashboards: Fix hidden queries execution (#57004) ... PublicDashboards: Fix hidden queries execution	3 years ago
Jeff Levin	7146f2731c	Public Dashboards: audit log paths and add traceId where user facing error is different (#56914) ... Audit all paths for publicdashboards and implement traces where user facing error is different from the internal error.	3 years ago
Kristin Laemmert	c61b5e85b4	chore: replace sqlstore.Store with db.DB (#57010) ... * chore: replace sqlstore.SQLStore with db.DB * more post-sqlstore.SQLStore cleanup	3 years ago
Michael Mandrus	ea8549b8c2	Datasources: Support mixed datasources in a single query (#56832) ... * initial cut at refactor - need to run more tests * fix unit tests * change newly unused function to test helper * create unit tests for parsing query requests that cover a range of cases * add some comments * rename function to avoid dev confusion	3 years ago
juanicabanas	75a5777e36	PublicDashboards: Validate access token not to be duplicated and add retries. (#56755) ... PublicDashboards: Validate access token not to be duplicated and add retries.	3 years ago
Jeff Levin	cc27214dca	Public Dashboards: Add audit table (#54508) ... This PR adds an audit table for public dashboards allowing a user to view all public dashboards on an instance of grafana. The public dashboards team is working on a proposal for adding RBAC support to the audit table for 9.3 Co-authored-by: juanicabanas <juan.cabanas@grafana.com>	3 years ago
Jeff Levin	331110bde5	refactor public dashboards middleware testing (#55706) ... This PR refactors how we add the orgId to the context on a public dashboard paths. We also split out accessToken handling into its own package and rework status code for "RequiresValidAccessToken". We will be modeling all endpoints to use these status codes going forward. Additionally, it includes a scaffold for better middleware testing and refactors existing tests to table drive tests.	3 years ago
Ezequiel Victorero	b370a8e366	PublicDashboards: Allow disabling an existent public dashboard if it has template variables (#55778)	3 years ago
ying-jeanne	2472777ce2	Chore: implement sqlx into tag service (#55908) ... * add sqlx store to tag service * add sqlx into tag service * fix test * change to camal cases * change in xorm camal case	3 years ago
owensmallwood	664aa795c1	PublicDashboards: Add metric for public dashboard datasource query success (#55701) ... Adds metric for which datasource queries are successful or not with pubdash.	3 years ago
Guilherme Caulada	9c2f3045b4	PublicDashboards: Resolve interval for public dashboard data source (#55489) ... * Resolve interval for public dashboard data source * Remove type assertions in favor of 'in' * Add org id to public dashboard requests	3 years ago
ying-jeanne	7b4cea8151	Chore: StoreSplit tag service (#55453) ... * move tag service outside * fix dashboard * fix test * lint * fix linter * remove spew	3 years ago
Guilherme Caulada	ee899e8c3a	PublicDashboards: Sanitize metadata from public dashboard queries (#55269) ... * Add function to remove metadata from queries * Add test for RemoveMetadataFromQueryData function * Remove only custom data and executed query string * Add sanity check to SanitizeMetadataFromQueryData	3 years ago
ying-jeanne	e4741ce8d6	remove datasource from sqlstore (#55288)	3 years ago
owensmallwood	e37420f0a8	PublicDashboards: Log api layer errors and which datasources fail/succeed (#55056) ... Adds pubdash api error logging and logs array of datasource names with success status when running pubdash queries.	3 years ago
owensmallwood	deb86e3250	PublicDashboards: Dont support exemplars (#54933) ... Don't support exemplars in public dashboards	3 years ago
Guilherme Caulada	b06eaf66b6	Public Dashboards: Replace simplejson with TimeSettings on dashboard struct (#55047) ... * Replace simplejson for TimeSettings on PublicDashboard struct * Implement xorm conversion interface to TimeSettings * Fix minor test assertion issue	3 years ago
Emil Tullstedt	b287047052	Chore: Upgrade Go to 1.19.1 (#54902) ... * WIP * Set public_suffix to a pre Ruby 2.6 version * we don't need to install python * Stretch->Buster * Bump versions in lib.star * Manually update linter Sort of messy, but the .mod-file need to contain all dependencies that use 1.16+ features, otherwise they're assumed to be compiled with -lang=go1.16 and cannot access generics et al. Bingo doesn't seem to understand that, but it's possible to manually update things to get Bingo happy. * undo reformatting * Various lint improvements * More from the linter * goimports -w ./pkg/ * Disable gocritic * Add/modify linter exceptions * lint + flatten nested list Go 1.19 doesn't support nested lists, and there wasn't an obvious workaround. https://go.dev/doc/comment#lists	3 years ago
Karl Persson	bcd7afd1f5	RBAC: Remove service dependency in Evaluator component (#54910) ... * RBAC: Remove service dependency for Evaluator component * RBAC: Add service and load permissions in target org if they are not there * RBAC: Use service if we need to load permissions for org * API: remove service injection into evaluator * API: set new user for each request in tests * PublicDashboards: Use fake service to provide permissions * RBAC: Set org id for dashboard provisioning user	3 years ago
Ezequiel Victorero	bcab0194f1	PublicDashboards: disable form if user does not has permissions (#54853)	3 years ago
owensmallwood	108678a8cc	Public Dashboards: Only use queries from dashboard for caching (#54596) ... Don't accept frontend queries for query caching when its from a public dashboard. Use queries on the dashboard instead.	3 years ago
Karl Persson	ff35e35ce0	RBAC: Move service and evaluator to acimpl package (#54714) ... * RBAC: Move access control evaluator to acimpl package * RBAC: Move service to acimpl package	3 years ago
Ezequiel Victorero	bfa35ff8d8	PublicDashboards: Add RBAC to secured endpoints (#54544)	3 years ago
owensmallwood	f4bbce15a0	Public Dashboards: Add Expressions Support (#54336) ... Adds support for expressions with public dashboards	3 years ago
Ezequiel Victorero	722aca5c53	Public Dashboards: use intervalMs and maxDataPoints from request (#53613)	3 years ago
Jeff Levin	5cb9fca990	public-dashboards: Add log statement when public dashboard enabled or disabled (#54133) ... * refactor apis for consistent outputs * add dashboardUid validation at API layer * add check for empty dashboardUid on SavePublicDashboard * remove public dashboard errors from models package. Co-authored-by: Ezequiel Victorero <evictorero@gmail.com>	3 years ago
Jeff Levin	681bdf1a2d	public-dashboards: refactor query method (#54119) ... This PR refactors the GetPublicDashboard method so we don't need to make extra database calls. Also adds general documentation	3 years ago
Jeff Levin	6128cb60b4	cleanup unused fields (#54115) ... This PR removes unused struct fields in SavePublicDashboardCommand	3 years ago
Karl Persson	55c7b8add2	RBAC: Split up service into several components (#54002) ... * RBAC: Rename interface to Store * RBAC: Move ranme scopeInjector * RBAC: Rename files to service * RBAC: Rename to service * RBAC: Split up accesscontrol into two components * RBAC: Add DeclareFixedRoles to AccessControl interface * Wire: Fix wire bindings * RBAC: Move resolvers to root * RBAC: Remove invalid test * RBAC: Inject access control service * RBAC: Implement the RoleRegistry interface in fake	3 years ago
Karl Persson	d1df896962	Remove unsued dep (#53785)	3 years ago
Karl Persson	c08fe3a53c	RBAC: Enable rbac when creating new settings (#53531) ... * Settings: Set RBACEnabled to true by default * Remove accessControlEnabledFlag and explicitly set to false when needed * Disable rbac for tests	3 years ago
idafurjes	a14621fff6	Chore: Add user service method SetUsingOrg and GetSignedInUserWithCacheCtx (#53343) ... * Chore: Add user service method SetUsingOrg * Chore: Add user service method GetSignedInUserWithCacheCtx * Use method GetSignedInUserWithCacheCtx from user service * Fix lint after rebase * Fix lint * Fix lint error * roll back some changes * Roll back changes in api and middleware * Add xorm tags to SignedInUser ID fields	3 years ago
Guilherme Caulada	7554322327	Fix middleware tests for public dashboards (#53557)	3 years ago