974 Commits (7345ba35a1c7e9948b3da9e01429882fdeed0175)

Author	SHA1	Message	Date
Owen Diehl	93d0f7163f	[Alerting] Forking LoTex ruler (#32138) ... * updates alerting api to master * skeleton for lotex ruler * withPath helper & legacyRulerPrefix const * forked ruler * wires up proxy * safeMacaronWrapper * working proxy * jsonExtractor * lint	4 years ago
Joan López de la Franca Beltran	020108e32d	Chore: Tidy up Go deps (#32127)	4 years ago
Ganesh Vernekar	0b788b5ce8	AlertingNG: Notification channel for emails (#31768) ... * Email notification channel in ngalert Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in> * Use existing templating system Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in> * Update template and add unit tests Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>	4 years ago
dependabot[bot]	b95fd1d1ce	Chore(deps): Bump github.com/aws/aws-sdk-go from 1.37.30 to 1.37.32 (#32058) ... Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.37.30 to 1.37.32. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Changelog](https://github.com/aws/aws-sdk-go/blob/main/CHANGELOG.md) - [Commits](https://github.com/aws/aws-sdk-go/compare/v1.37.30...v1.37.32) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	4 years ago
Sofia Papagiannaki	68b05b8aaa	AlertingNG: Unified alerting API mock (#32040) ... * AlertingNG: Alertmanager mock API * AlertingNG: Remove permissions API routes * Add example POST payloads * Prometheus and testing mock API	4 years ago
Marcus Efraimsson	669a616797	Chore: Remove unused dependencies (#32031)	4 years ago
Ganesh Vernekar	ecbc98ba5d	AlertingNG: Add alert provider and basic structure with dispatcher, silences and delivery stages (#31833) ... * AlertingNG: Add alert provider Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in> * Add unit tests Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in> * Alertmanager WIP * Merge alertmanager into notifier Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in> * Fixes for PR 31833 (#31990) Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in> * Use alertmanager from upgrad-uuid temporarily to unblock Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in> * Fix lint Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in> Co-authored-by: Josue Abreu <josue@grafana.com>	4 years ago
dependabot[bot]	16027770c8	Chore(deps): Bump google.golang.org/api from 0.40.0 to 0.41.0 (#31975) ... Bumps [google.golang.org/api](https://github.com/googleapis/google-api-go-client) from 0.40.0 to 0.41.0. - [Release notes](https://github.com/googleapis/google-api-go-client/releases) - [Changelog](https://github.com/googleapis/google-api-go-client/blob/master/CHANGES.md) - [Commits](https://github.com/googleapis/google-api-go-client/compare/v0.40.0...v0.41.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	4 years ago
dependabot[bot]	a61765d2cc	Chore(deps): Bump github.com/aws/aws-sdk-go from 1.37.26 to 1.37.30 (#31976) ... Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.37.26 to 1.37.30. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Changelog](https://github.com/aws/aws-sdk-go/blob/main/CHANGELOG.md) - [Commits](https://github.com/aws/aws-sdk-go/compare/v1.37.26...v1.37.30) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	4 years ago
Joan López de la Franca Beltran	3e66328deb	Chore: Tidy up Go deps (#31956)	4 years ago
Ryan McKinley	9dd1d5f553	Cloudwatch: use shared library for aws auth (#29550) ... * use sdk for handling auth * fix broken test * lint fixes Co-authored-by: Erik Sundell <erik.sundell87@gmail.com>	4 years ago
Sofia Papagiannaki	fe628c6282	AlertingNG: base API implementation (#31824) ... * AlertingNG: base API implementation * Pass the interface instead of the base impl * Ruler mock draft (WIP) * Update alerting-api dependency * Improve mock implementation	4 years ago
Arve Knudsen	d2aaaeb497	Backend: Tidy go.sum (#31858) ... Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	4 years ago
dependabot[bot]	bac1721546	Chore(deps): Bump go.opentelemetry.io/collector from 0.21.0 to 0.22.0 (#31852) ... Bumps [go.opentelemetry.io/collector](https://github.com/open-telemetry/opentelemetry-collector) from 0.21.0 to 0.22.0. - [Release notes](https://github.com/open-telemetry/opentelemetry-collector/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-collector/blob/main/CHANGELOG.md) - [Commits](https://github.com/open-telemetry/opentelemetry-collector/compare/v0.21.0...v0.22.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	4 years ago
Erik Sundell	d512c5a1b4	Cloudwatch: ListMetrics API page limit (#31788) ... * add list metrics api page limit * Update docs/sources/datasources/cloudwatch.md Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com> Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com>	4 years ago
dependabot[bot]	d60727311e	Chore(deps): Bump github.com/aws/aws-sdk-go from 1.37.25 to 1.37.26 (#31790) ... Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.37.25 to 1.37.26. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Changelog](https://github.com/aws/aws-sdk-go/blob/master/CHANGELOG.md) - [Commits](https://github.com/aws/aws-sdk-go/compare/v1.37.25...v1.37.26) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	4 years ago
Sofia Papagiannaki	4ce0a49eac	AlertingNG: Split into several packages (#31719) ... * AlertingNG: Split into several packages * Move AlertQuery to models	4 years ago
dependabot[bot]	ee96861ce1	Chore(deps): Bump cloud.google.com/go/storage from 1.13.0 to 1.14.0 (#31613) ... Bumps [cloud.google.com/go/storage](https://github.com/googleapis/google-cloud-go) from 1.13.0 to 1.14.0. - [Release notes](https://github.com/googleapis/google-cloud-go/releases) - [Changelog](https://github.com/googleapis/google-cloud-go/blob/master/CHANGES.md) - [Commits](https://github.com/googleapis/google-cloud-go/compare/spanner/v1.13.0...spanner/v1.14.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	4 years ago
Arve Knudsen	fc9381744a	UsageStatsService: Make initialization more robust (#31761) ... * UsageStatsService: Make initialization more robust Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	4 years ago
dependabot[bot]	1a19a0e1e6	Chore(deps): Bump github.com/lib/pq from 1.9.0 to 1.10.0 (#31758) ... Bumps [github.com/lib/pq](https://github.com/lib/pq) from 1.9.0 to 1.10.0. - [Release notes](https://github.com/lib/pq/releases) - [Commits](https://github.com/lib/pq/compare/v1.9.0...v1.10.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	4 years ago
dependabot[bot]	db37a04ded	Chore(deps): Bump github.com/google/go-cmp from 0.5.4 to 0.5.5 (#31757) ... Bumps [github.com/google/go-cmp](https://github.com/google/go-cmp) from 0.5.4 to 0.5.5. - [Release notes](https://github.com/google/go-cmp/releases) - [Commits](https://github.com/google/go-cmp/compare/v0.5.4...v0.5.5) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	4 years ago
dependabot[bot]	bf53b586a6	Chore(deps): Bump github.com/aws/aws-sdk-go from 1.37.20 to 1.37.25 (#31759) ... Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.37.20 to 1.37.25. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Changelog](https://github.com/aws/aws-sdk-go/blob/master/CHANGELOG.md) - [Commits](https://github.com/aws/aws-sdk-go/compare/v1.37.20...v1.37.25) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	4 years ago
Zoltán Bedi	29c998f9eb	Tempo: Convert tempo to backend data source2 ... This reverts commit c15d1f498a.	4 years ago
dependabot[bot]	e65c5572cc	Chore(deps): Bump github.com/influxdata/influxdb-client-go/v2 (#30800) ... Bumps [github.com/influxdata/influxdb-client-go/v2](https://github.com/influxdata/influxdb-client-go) from 2.2.0 to 2.2.2. - [Release notes](https://github.com/influxdata/influxdb-client-go/releases) - [Changelog](https://github.com/influxdata/influxdb-client-go/blob/master/CHANGELOG.md) - [Commits](https://github.com/influxdata/influxdb-client-go/compare/v2.2.0...v2.2.2) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	4 years ago
dependabot[bot]	2dbb66e5c1	Chore(deps): Bump github.com/centrifugal/centrifuge (#31206) ... Bumps [github.com/centrifugal/centrifuge](https://github.com/centrifugal/centrifuge) from 0.13.0 to 0.15.0. - [Release notes](https://github.com/centrifugal/centrifuge/releases) - [Changelog](https://github.com/centrifugal/centrifuge/blob/master/changelog.md) - [Commits](https://github.com/centrifugal/centrifuge/compare/v0.13.0...v0.15.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	4 years ago
Zoltán Bedi	c15d1f498a	Revert "Tempo: convert to backend data source (#31618)" (#31702) ... This reverts commit 862f09376f.	4 years ago
Zoltán Bedi	862f09376f	Tempo: convert to backend data source (#31618) ... * Tempo: Support opentelemetry response * Tempo: convert Tempo to backend data source * Update data source test * Fix lint issues * Apply suggestions from code review Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com> * Return error when trace not found Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>	4 years ago
Kyle Brandt	a488ab8393	SSE: Add "Classic Condition" on backend (#31511) ... This is a translation of services/alerting/conditions. Main Changes: - Work with types in SSE (series/number) which are data frames (no more null.Float). - The query part from alerting/conditions is handled by SSE logic - Convey / simplejson removed. - Time range no longer part of "query" in the condition	4 years ago
dependabot[bot]	83c75237f0	Chore(deps): Bump google.golang.org/api from 0.39.0 to 0.40.0 (#31210) ... Bumps [google.golang.org/api](https://github.com/googleapis/google-api-go-client) from 0.39.0 to 0.40.0. - [Release notes](https://github.com/googleapis/google-api-go-client/releases) - [Changelog](https://github.com/googleapis/google-api-go-client/blob/master/CHANGES.md) - [Commits](https://github.com/googleapis/google-api-go-client/compare/v0.39.0...v0.40.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	4 years ago
dependabot[bot]	c360ac7278	Chore(deps): Bump google.golang.org/grpc from 1.35.0 to 1.36.0 (#31541) ... Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.35.0 to 1.36.0. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](https://github.com/grpc/grpc-go/compare/v1.35.0...v1.36.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	4 years ago
dependabot[bot]	2d7e5ff297	Chore(deps): Bump github.com/aws/aws-sdk-go from 1.37.7 to 1.37.20 (#31538) ... Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.37.7 to 1.37.20. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Changelog](https://github.com/aws/aws-sdk-go/blob/master/CHANGELOG.md) - [Commits](https://github.com/aws/aws-sdk-go/compare/v1.37.7...v1.37.20) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	4 years ago
dependabot[bot]	c69cb85ef6	Chore(deps): Bump github.com/prometheus/common from 0.17.0 to 0.18.0 (#31539) ... Bumps [github.com/prometheus/common](https://github.com/prometheus/common) from 0.17.0 to 0.18.0. - [Release notes](https://github.com/prometheus/common/releases) - [Commits](https://github.com/prometheus/common/compare/v0.17.0...v0.18.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	4 years ago
dependabot[bot]	f36601cdbd	Chore(deps): Bump github.com/prometheus/common from 0.15.0 to 0.17.0 (#31387) ... Bumps [github.com/prometheus/common](https://github.com/prometheus/common) from 0.15.0 to 0.17.0. - [Release notes](https://github.com/prometheus/common/releases) - [Commits](https://github.com/prometheus/common/compare/v0.15.0...v0.17.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	4 years ago
dependabot[bot]	dae5e452a9	Chore(deps): Bump github.com/golang/mock from 1.4.4 to 1.5.0 (#31379) ... Bumps [github.com/golang/mock](https://github.com/golang/mock) from 1.4.4 to 1.5.0. - [Release notes](https://github.com/golang/mock/releases) - [Changelog](https://github.com/golang/mock/blob/master/.goreleaser.yml) - [Commits](https://github.com/golang/mock/compare/v1.4.4...v1.5.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	4 years ago
dependabot[bot]	ad5514eca5	Chore(deps): Bump github.com/getsentry/sentry-go from 0.9.0 to 0.10.0 (#31378) ... Bumps [github.com/getsentry/sentry-go](https://github.com/getsentry/sentry-go) from 0.9.0 to 0.10.0. - [Release notes](https://github.com/getsentry/sentry-go/releases) - [Changelog](https://github.com/getsentry/sentry-go/blob/master/CHANGELOG.md) - [Commits](https://github.com/getsentry/sentry-go/compare/v0.9.0...v0.10.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	4 years ago
Marcus Efraimsson	6aa4db387b	Chore: Upgrade grafana-plugin-sdk-go to v0.88.0 (#30975) ... * Chore: Upgrade grafana-plugin-sdk-go * update plugin sdk Co-authored-by: Will Browne <will.browne@grafana.com>	4 years ago
Will Browne	d33375ade9	use 0.1.0 (#31215)	4 years ago
dependabot[bot]	de338f8e64	Chore(deps): Bump cloud.google.com/go/storage from 1.12.0 to 1.13.0 (#31211) ... Bumps [cloud.google.com/go/storage](https://github.com/googleapis/google-cloud-go) from 1.12.0 to 1.13.0. - [Release notes](https://github.com/googleapis/google-cloud-go/releases) - [Changelog](https://github.com/googleapis/google-cloud-go/blob/master/CHANGES.md) - [Commits](https://github.com/googleapis/google-cloud-go/compare/spanner/v1.12.0...spanner/v1.13.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	4 years ago
dependabot[bot]	4f918e37f4	Chore(deps): Bump xorm.io/xorm from 0.8.1 to 0.8.2 (#30773) ... * Chore(deps): Bump xorm.io/xorm from 0.8.1 to 0.8.2 Bumps xorm.io/xorm from 0.8.1 to 0.8.2. Signed-off-by: dependabot[bot] <support@github.com> * Fix limit for snapshots * Fix limit for org and users Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com>	4 years ago
dependabot[bot]	23621357b0	Chore(deps): Bump github.com/linkedin/goavro/v2 from 2.9.7 to 2.10.0 (#31204) ... Bumps [github.com/linkedin/goavro/v2](https://github.com/linkedin/goavro) from 2.9.7 to 2.10.0. - [Release notes](https://github.com/linkedin/goavro/releases) - [Changelog](https://github.com/linkedin/goavro/blob/master/debug_release.go) - [Commits](https://github.com/linkedin/goavro/compare/v2.9.7...v2.10.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	4 years ago
dependabot[bot]	a2cca8d488	Chore(deps): Bump github.com/jung-kurt/gofpdf from 1.10.1 to 1.16.2 (#30586) ... Bumps [github.com/jung-kurt/gofpdf](https://github.com/jung-kurt/gofpdf) from 1.10.1 to 1.16.2. - [Release notes](https://github.com/jung-kurt/gofpdf/releases) - [Commits](https://github.com/jung-kurt/gofpdf/compare/v1.10.1...v1.16.2) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	4 years ago
dependabot[bot]	dbe2b5004c	Chore(deps): Bump github.com/aws/aws-sdk-go from 1.36.31 to 1.37.7 (#31018) ... Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.36.31 to 1.37.7. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Changelog](https://github.com/aws/aws-sdk-go/blob/master/CHANGELOG.md) - [Commits](https://github.com/aws/aws-sdk-go/compare/v1.36.31...v1.37.7) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	4 years ago
dependabot[bot]	d05e10f792	Chore(deps): Bump github.com/magefile/mage from 1.10.0 to 1.11.0 (#31017) ... Bumps [github.com/magefile/mage](https://github.com/magefile/mage) from 1.10.0 to 1.11.0. - [Release notes](https://github.com/magefile/mage/releases) - [Changelog](https://github.com/magefile/mage/blob/master/.goreleaser.yml) - [Commits](https://github.com/magefile/mage/compare/v1.10.0...v1.11.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	4 years ago
dependabot[bot]	736a50ace4	Chore(deps): Bump github.com/grpc-ecosystem/go-grpc-middleware (#31013) ... Bumps [github.com/grpc-ecosystem/go-grpc-middleware](https://github.com/grpc-ecosystem/go-grpc-middleware) from 1.2.1 to 1.2.2. - [Release notes](https://github.com/grpc-ecosystem/go-grpc-middleware/releases) - [Changelog](https://github.com/grpc-ecosystem/go-grpc-middleware/blob/master/CHANGELOG.md) - [Commits](https://github.com/grpc-ecosystem/go-grpc-middleware/compare/v1.2.1...v1.2.2) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	4 years ago
dependabot[bot]	e2e61878ba	Chore(deps): Bump google.golang.org/api from 0.33.0 to 0.39.0 (#30971) ... Bumps [google.golang.org/api](https://github.com/googleapis/google-api-go-client) from 0.33.0 to 0.39.0. - [Release notes](https://github.com/googleapis/google-api-go-client/releases) - [Changelog](https://github.com/googleapis/google-api-go-client/blob/master/CHANGES.md) - [Commits](https://github.com/googleapis/google-api-go-client/compare/v0.33.0...v0.39.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	4 years ago
Domas	21817055bd	Logging: sourcemap support for frontend stacktraces (#30590)	4 years ago
dependabot[bot]	07e7f47d62	Chore(deps): Bump gonum.org/v1/gonum from 0.6.0 to 0.8.2 (#30343) ... Bumps gonum.org/v1/gonum from 0.6.0 to 0.8.2. Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	4 years ago
dependabot[bot]	c7975f9617	Chore(deps): Bump gopkg.in/yaml.v2 from 2.3.0 to 2.4.0 (#30771) ... Bumps [gopkg.in/yaml.v2](https://github.com/go-yaml/yaml) from 2.3.0 to 2.4.0. - [Release notes](https://github.com/go-yaml/yaml/releases) - [Commits](https://github.com/go-yaml/yaml/compare/v2.3.0...v2.4.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	4 years ago
dependabot[bot]	896d3328b6	Chore(deps): Bump github.com/hashicorp/go-hclog from 0.14.1 to 0.15.0 (#30778) ... Bumps [github.com/hashicorp/go-hclog](https://github.com/hashicorp/go-hclog) from 0.14.1 to 0.15.0. - [Release notes](https://github.com/hashicorp/go-hclog/releases) - [Commits](https://github.com/hashicorp/go-hclog/compare/v0.14.1...v0.15.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	4 years ago
Will Browne	3b7b49a4aa	Auth: Use SigV4 lib from grafana-aws-sdk (#30713) ... * replace with lib * remove test + apply feedback	4 years ago