85 Commits (7767ab6f437630cc7709cc58d671d916035cd35d)

Author	SHA1	Message	Date
Serge Zaitsev	7767ab6f43	Chore: Add folder data migration, fix unique index (#72602) ... * add folder data migration, fix unique index * fix unique index * pass a fake store in tests * pass store into other providers in tests * and now with alerting!	2 years ago
Sofia Papagiannaki	1f742fcf93	Guardian: Split dashboard and folder guardian implementation (#69722) ... * Split dashboard and folder guardian implementations * Replace guardian constructors * Simplify tests * Add tests * Apply suggestion from code review Differentiate errors for dashboard and folders * Remove tests for general folder * Add tests for general scope	2 years ago
Arati R	20ffbbc41e	NestedFolders: Add library panels counting and deletion to folder registry (#69149) ... * Expose library element service's folder service * Register library panels, add count implementation * Expand folder counts test * Update registry deletion method interface * Allow getting library elements from any folder * Add test for library panel deletion * Add test for library panel counting	2 years ago
Ieva	a65cb4d808	RBAC: remove simple RBAC disabled checks (#71137) ... * remove simple RBAC disabled checks * fixing tests * remove old AC tests	2 years ago
Sofia Papagiannaki	22147c6230	NestedFolders: Do not perform guardian checks for subfolders (#69769) ... Nested folders: Do not perform guardian checks for subfolders Permissions are inherited so if the parent has access then the subfolder has access too	2 years ago
Arati R	6cb1a5e368	Nested folders: Add alert rule counts and deletion to folder registry (#67259) ... * Let alert rule service implement registry service * Add count method to RuleStore interface * Add implementation for deletion of alert rules * Rename uid to folderUID in registry methods * Check forceDeleteRule value for registry deletion * Register alerting store with folder service * Move folder test functions to separate package * Add testing for alert rule counting, deletion * Remove redundant count method * Fix deleteChildrenInFolder signature * Update pkg/services/ngalert/store/alert_rule.go Co-authored-by: Sofia Papagiannaki <1632407+papagian@users.noreply.github.com> * Add tests for nested folder deletion * Refactor TestIntegrationNestedFolderService * Add rules store as parameter for alertng provider --------- Co-authored-by: Sofia Papagiannaki <1632407+papagian@users.noreply.github.com>	2 years ago
Eng Zer Jun	7f7b03d794	Chore: Avoid unnecessary byte/string conversions (#69001) ... Avoid unnecessary byte/string conversion We can use alternative functions/methods to avoid unnecessary byte/string conversion calls. Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>	2 years ago
Sofia Papagiannaki	d458292b66	Nested folders: Allow renaming a folder multiple times (#68379) ... Return folder version in response that is required for updating the entry in the dashboard table.	2 years ago
Sofia Papagiannaki	d883404f50	Nested folders: Fix missing URL from folder responses (#68082) ... * Nested folders: Set URL in folder responses always * Apply suggestions from code review Co-authored-by: Arati R. <33031346+suntala@users.noreply.github.com>	2 years ago
Ieva	e51b92991d	Folders: return an error when listing folders if permission guardian returns an error (#68109) ... return an error when listing folders if perm gaurdian returns an error	2 years ago
Arati R	a5206a1cda	Nested folders: Provide count of all descendant dashboards and folders (#67184) ... * Add a method for getting descendant folders * Include dashboard count for descendant folders * Return subfolder count * Replace references to children with descendants * Update openapi specs * Add test for descendant counts * Add logging to GetDescendantCounts	2 years ago
Sofia Papagiannaki	893bf08dcf	Nested folders: Fix API response ordering when fetching subfolders (#67258) ... * Nested folders: Fix ordering when getting subfolders * Update endpoint swagger description * Modify test	2 years ago
Eric Leijonmarck	b93f26f29d	RBAC: Update TestIntegrationFolderService remove RBAC setting (#67052) ... * remove the RBAC configuration setting * add back tests	2 years ago
Arati R	fd434cab58	NestedFolders: Add API endpoint for descendant count in a folder (#66550) ... * Add CountInFolder to RegistryService interface * Add folder children counts api route * Update fake GetFolderChildrenCounts * Add test for getting folder children counts * Add validation to folder children counts handler * Update openapi specs * Update pkg/services/folder/folderimpl/folder.go Co-authored-by: Sofia Papagiannaki <1632407+papagian@users.noreply.github.com> --------- Co-authored-by: Sofia Papagiannaki <1632407+papagian@users.noreply.github.com>	2 years ago
Sofia Papagiannaki	24696d593b	Nested folders: Fix error response codes (#66943) ... * Nested folders: Fix error response codes Fix error handling	2 years ago
Arati R	cab3ba519a	NestedFolders: Add folder service registry with dashboard service implementation (#65033) ... * Delete folders, dashboards with registry service Co-authored-by: Serge Zaitsev <hello@zserge.com> * Update signature of ProvideDashboardServiceImpl * Regenerate mockery file * Add test for DeleteInFolder * Add test for DeleteDashboardsInFolder * Delete child dashboard associations via registry * Add validation of folder uid and org id --------- Co-authored-by: Serge Zaitsev <hello@zserge.com>	2 years ago
Sofia Papagiannaki	a270188f0c	Nested folders: Fix moving folder under root (#65684) ... * Nested folders: Fix moving folder under root * Add store test for not empty parent after update * Modify folder and document store update implementation Move folder only if NewParentUID is not nil * Apply suggestion from code review	2 years ago
Sofia Papagiannaki	c65cd5833a	Nested folders: Fix move (#65526) ... * Nested Folders: Fix move response Fix JSON tags to be consistent with the GET endpoint * Add API test for moving to root folder * Allow move to root folder * Fix failure message * Update OpenAPI specification	2 years ago
Ieva	7860ca6c3d	RBAC: protect folder creation and moving (#64636) ... * protect moving folders to a subfolder and creating folders in a subfolder * folder update endpoint isn't used for folder parent update * lint * move permission check logic to services, fix tests * linting	2 years ago
Sofia Papagiannaki	4ee0be6fdf	Chore: Add function for detecting if the SQL driver supported CTEs (#64441) ... * Add interface method for detecting if the SQL driver supported CTEs * Update nested folder store to call RecursiveQueriesAreSupported()	2 years ago
ying-jeanne	6974f4340b	NestedFolders: Fix nested folder deletion (#63572) ... --------- Co-authored-by: suntala <arati.rana@grafana.com> Co-authored-by: ying-jeanne <ying-jeanne@users.noreply.github.com> Co-authored-by: jeanne0731 <jeanne0731@users.noreply.github.com>	2 years ago
Ieva	a52999a886	Access Control: revert to using folder store from the scope resolvers (#64132) ... * revert to using folder store from the resolvers * fixing tests after revert * api test fixes --------- Co-authored-by: Kristin Laemmert <mildwonkey@users.noreply.github.com>	2 years ago
Kristin Laemmert	bb798e24f3	chore(services): replace dependencies on dashboard store with dashboard service (#63937) ... * chore(services): replace dependencies on dashboard store with dashboard service This continues the backend service/store split by replacing dashboard store dependencies with service dependencies. the folder service remains the single exception for now; otherwise we'd have a dependency cycle between the folder and dashboard services. I have some ideas for that, but I'll take care of all the easy parts first. While doing this, I identified and removed a number of unused arguments from the following functions: NewFolderNameScopeResolver NewFolderIDScopeResolver NewFolderUIDScopeResolver NewDashboardIDScopeResolver NewDashboardUIDScopeResolver resolveDashboardScope I have a small enterprise PR to support this commit. * lingering fmt	2 years ago
Ryan McKinley	22aa09d392	DashboardStore: Provide an interface directly rather than pointer receiver (#63910)	2 years ago
Ieva	4570131fe5	Folders: simplify guardian permissions checks (#63183) ... simplify code	2 years ago
Sofia Papagiannaki	225c8dbba7	Chore: Fix fetching the General folder when nested folders is set and improve error handling (#62951) ... * Nested folders: Modify Get() not to fail fetching the General folder * Add test	2 years ago
Ieva	078639abcd	RBAC: add folder UID scope resolver (#62695) ... * add folder uid scope resolver * undo guardian change, move it to a separate PR * fix test + linting	2 years ago
Ryan McKinley	b1e58eb47e	Chore: Replace short UID generation with more standard UUIDs (#62731)	2 years ago
Sofia Papagiannaki	ee2878f189	Chore: Fix logging message in folder service (#62939)	2 years ago
Josh Hunt	4d268cbcdb	NestedFolders: use guardian.NewByUID to check folder permissions (#62864)	2 years ago
Sofia Papagiannaki	4eaff63eda	SQLStore: Fix folder migration for MySQL < 5.7 (#62521) ... * Nested folders: Do not skip integration tests * SQLStore: Fix folder migration It reduces the length of the title column to be equal with the respective dashboard column.	2 years ago
Sofia Papagiannaki	adaf82ffb7	Nested Folder: Fix for SQLite not to overwrite the parent on restarts (#62709) ... Nested Folder: Fix for SQLite not to overwrite the arent on restarts	2 years ago
Sofia Papagiannaki	f143b0a5b2	Chore: Move folder store interface, implementation and test under pkg/services/folder (#62586) ... * Chore: Move folder store into folder service package * Split folder and dashboard store implementations	2 years ago
Ieva	ee3d742c7d	RBAC: inherit folder permissions when resolving managed permissions (#62244) ... * add nested folder scope inheritance to managed permission services * add a more specific erorr * remove circular dependencies * use errutil for returning erorr * fix tests * fix tests * define a new error in ac package	2 years ago
Serge Zaitsev	bc2813ef06	Chore: Fix goimports grouping in pkg/services (#62420) ... * fix goimports * fix goimports order	2 years ago
Kristin Laemmert	e8b8a9e276	chore: move dashboard_acl models into dashboard service (#62151)	2 years ago
Sofia Papagiannaki	cd27562c76	Access control: Modify dashboard/folder resolvers so that return also the inherited scopes (#62025) ... * Access Control: Add folder service dependency to the dashboard/folder resolvers * Expose the function fetching parents to folder interface * Add generic prepend utility * Modify dashboard resolvers to return inherited scopes	2 years ago
idafurjes	b54b80f473	Chore: Remove Result from dashboard models (#61997) ... * Chore: Remove Result from dashboard models * Fix lint tests * Fix dashboard service tests * Fix API tests * Remove commented out code * Chore: Merge main - cleanup	2 years ago
idafurjes	421976e919	Chore: Remove folders from models pkg (#61853)	2 years ago
Sofia Papagiannaki	c7a7ebd3e0	Chore: Drop search service dependency from folder service (#61789) ... * Chore: Drop search service dependency from folder service	2 years ago
idafurjes	68445a7c77	Chore: Remove dashboard ACL from models (#61749) ... * Remove dashboard ACL from models * Remove unused comment	2 years ago
Sofia Papagiannaki	c104cc7020	Chore: Split folder store and dashboard store interfaces (#61655) ... * update folder store mock * Split folder store and dashboard store interfaces	2 years ago
Sofia Papagiannaki	b80c9bb974	Chore: Drop dashboard service dependency from folder service (#61614) ... * Chore: Drop dashboard dependency from folder service	2 years ago
idafurjes	b573b19ca3	Chore: Remove dashboards from models pkg (#61578) ... * Copy dashboard models to dashboard pkg * Use some models from current pkg instead of models * Adjust api pkg * Adjust pkg services * Fix lint * Chore: Remove dashboards models * Remove dashboards from models pkg * Fix lint in tests * Fix lint in tests 2 * Fix for import in auth * Remove newline * Revert unused fix	2 years ago
Sofia Papagiannaki	f25d5199c5	Chore: Fix folder service tests (#61659) ... * Chore: Fix folder service tests	2 years ago
idafurjes	7c2522c477	Chore: Move dashboard models to dashboard pkg (#61458) ... * Copy dashboard models to dashboard pkg * Use some models from current pkg instead of models * Adjust api pkg * Adjust pkg services * Fix lint	2 years ago
Sofia Papagiannaki	e2ed42c2a3	Nested folders: Do not expose the sequential ID from the folder store (#60702) ... * Nested folders: Do not expose the sequential ID from the folder store	2 years ago
Sofia Papagiannaki	4df78cebc2	Nested Folders: Unify folder services (#60390) ... * Nested Folders: Unify folder services	2 years ago
Sofia Papagiannaki	55b014974d	Nested folders: Refactor folder update (#60323) ... * Nested folders: Refactor folder update * Apply suggestions from code review	2 years ago
Sofia Papagiannaki	b1ef5ab320	Nested Folders: Support listing nested folder children (#58566) ... * Nested Folders: Support listing nested folder children * Filter out subfolders with no permissions * Apply suggestion from code review	2 years ago