grafana

Commit Graph

Author	SHA1	Message	Date
Matthew Jacobson	53cfdf0ef8	Alerting: Remove option to return settings from api/v1/receivers and restrict provisioning action access (#90861 ) * Remove provisioning action access to v1/receivers api * Separate ListOnly functionality to its own method without decryption	10 months ago
William Wernert	a1ee84f757	Alerting: Remove duplicate tracing middleware from prom writer (#91353 ) Remove duplicate tracing middleware from prom writer	10 months ago
Alexander Weaver	4c71cadd5f	Alerting: Detach condition validator from condition evaluator (#91150 ) * Detach validator from evaluator * Drop unnecessary interface and type	10 months ago
Matthew Jacobson	62f67e38b8	Alerting: Implement receiver auth service (#90857 )	10 months ago
Matthew Jacobson	a1f0b599a7	Alerting: Refactor receiver_svc and provisioning config store into legacy_storage package (#90856 ) * Add more receivers api tests * Move provisioning config store to new legacy_storage package	10 months ago
Alexander Weaver	418b077c59	Alerting: Integration testing for recording rules including writes (#90390 ) * Add success case and tests for writer using metrics * Use testable version of clock * Assert a specific series was written * Fix linter * Fix manually constructed writer	11 months ago
Alexander Weaver	0e269db8a9	Alerting: Expose recordingWriter on ngalert (#90573 ) Expose recordingWriter on ngalert	11 months ago
Yuri Tseretyan	970cafa20f	Alerting: Time interval Delete API to check for usages in alert rules (#90500 ) * Check if a time interval is used in alert rules before deleting it * Add time interval to parameters of ListAlertRulesQuery and ListNotificationSettings of DbStore == Refacorings == * refactor isMuteTimeInUse to accept a single route * update getMuteTiming to not return err * update delete to get the mute timing from config first	11 months ago
Santiago	fce03cd724	Alerting: Send static headers to the remote Alertmanager (#89846 )	11 months ago
Yuri Tseretyan	06d5850396	Alerting: Update alerting state history API to authorize access using RBAC (#89579 ) * add method CanReadAllRules to rule authorization service * add alias type Namespace for Folder in ngalert's models package. It implements the Namespacer interface that is used by authz logic * update state history's backends to authorize access to rules. * update Loki to add folders UIDs to query. * Update BuildLogQuery to drop filter by folders if it's too long and fall back to in-memory filtering.	11 months ago
Santiago	fe1309dd96	Alerting: Send external URL to the remote Alertmanager (#89701 ) * Alerting: Send external URL to the remote Alertmanager * test that the URL is sent to the remote Alertmanager * AppURL -> ExternalURL	11 months ago
William Wernert	fcfa89f864	Alerting: Implement Prometheus remote write for recording rules (#89189 ) * Fix timestamp recorded by rule * Implement prometheus remote write * Create http client instead of transport * Address PR comments * Remove status code label	11 months ago
Yuri Tseretyan	b075926202	Alerting: Time Intervals API (#88201 ) * expose ngalert API to public * add delete action to time-intervals * introduce time-interval model generated by app-platform-sdk from CUE model the fields of the model are chosen to be compatible with the current model * implement api server * add feature flag alertingApiServer ---- Test Infra * update helper to support creating custom users with enterprise permissions * add generator for Interval model	11 months ago
Matthew Jacobson	3228b64fe6	Alerting: Resend resolved notifications for ResolvedRetention duration (#88938 ) * Simple replace of State.Resolved with State.ResolvedAt * Retain ResolvedAt time between Normal->Normal transition * Introduce ResolvedRetention to keep sending recently resolved alerts * Make ResolvedRetention configurable with resolved_alert_retention * Tick-based LastSentAt for testing of ResendDelay and ResolvedRetention * Do not reset ResolvedAt during Normal->Pending transition Initially this was done to be inline with Prom ruler. However, Prom ruler doesn't keep track of Inactive->Pending/Alerting using the same alert instance, so it's more understandable that they choose not to retain ResolvedAt. In our case, since we use the same cached instance to represent the transition, it makes more sense to retain it. This should help alleviate some odd situations where temporarily entering Pending will stop future resolved notifications that would have happened because of ResolvedRetention. * Pointers for ResolvedAt & LastSentAt To avoid awkward time.Time{}.Unix() defaults on persist	11 months ago
Alexander Weaver	8491e02caf	Alerting: Instrument outbound requests for Loki Historian and Remote Alertmanager with tracing (#89185 ) * Add TracedClient * Handle errors and status codes * Wire up tracing to normal ASH and loki annotation mapping * Add tracing to remote alertmanager * one more spot * and not or * More consistency with other grafana traces, lower cardinality name	12 months ago
William Wernert	c62cc25513	Alerting: Configure recording rule writer from config.ini (#89056 )	12 months ago
Santiago	b7120c5a30	Alerting: Fix missing argument in call to createRemoteAlertmanager() (#89101 )	12 months ago
Santiago	12d5251c12	Alerting: Alertmanager configuration sync loop (#88822 ) * make the config sync happen on each call to ApplyConfig(), fix tests * send autogen config * add fake autogen function for tests * update stale comments, tidy things up, make linter happy * add auto-gen routes only if the feature toggle is enabled * remove unnecessary fake autogen function * throttle configuration syncs * restore pkg/services/store/entity/sqlstash/sql_storage_server.go * test sync loop in ApplyConfig, skip invalid autogen routes * restore conf/defaults.ini * restore conf/defaults.ini * avoid skipping invalid auto-gen routes in SaveAndApplyConfig * test that autogenFn is called and its errors are returned * add debug message about the sync interval not having elapsed * collapse two log lines into one	12 months ago
Santiago	5f4d07bb75	Alerting: Enable remote primary mode using feature toggles (#88976 )	12 months ago
Santiago	e15e40fbd3	Alerting: Skip setting up clustering in remote primary/only modes (#88968 ) * Alerting: Skip setting up clustering in remote primary mode * Update pkg/services/ngalert/notifier/multiorg_alertmanager.go Co-authored-by: Steve Simpson <steve.simpson@grafana.com> --------- Co-authored-by: Steve Simpson <steve.simpson@grafana.com>	12 months ago
William Wernert	63e9969c1b	Alerting: Recording rule mapping logic for data frames to Prometheus metrics (#88550 ) * Add stub Prometheus writer with mapping logic * Add tests	12 months ago
Sofia Papagiannaki	17ca61d7f8	Alerting: Export and provisioning rules into subfolders (#77450 ) * Folders: Optionally include fullpath in service responses * Alerting: Export folder fullpath instead of title * Escape separator in folder title * Add support for provisiong alret rules into subfolders * Use FolderService for creating folders during provisioning * Export WithFullpath() folder service function --------- Co-authored-by: Tania B <yalyna.ts@gmail.com> Co-authored-by: Yuri Tseretyan <yuriy.tseretyan@grafana.com>	1 year ago
William Wernert	5de7d4d06d	Alerting: Create writer interface for recording rules (#88459 ) * Create writer interface for recording rules Also create fake impl + use it for stub in scheduler	1 year ago
Alexander Weaver	b926b6336d	Alerting: Scheduled recording rules execute their queries (#88309 ) * Basic eval flow * Wiring-up * fix * Extend todo * Start with tests * Include some relevant tests, skip ones that seem to have timing-based race conditions * Some tests, touch up linter and todo * Solve TODO * Add tracing * Tests to make sure an eval went through * Wire up feature toggles * Update pkg/services/ngalert/schedule/recording_rule.go Co-authored-by: Steve Simpson <steve.simpson@grafana.com> * Update pkg/services/ngalert/schedule/recording_rule_test.go Co-authored-by: Steve Simpson <steve.simpson@grafana.com> * Update pkg/services/ngalert/schedule/recording_rule_test.go Co-authored-by: Steve Simpson <steve.simpson@grafana.com> * Update pkg/services/ngalert/schedule/recording_rule_test.go Co-authored-by: Steve Simpson <steve.simpson@grafana.com> --------- Co-authored-by: Steve Simpson <steve.simpson@grafana.com>	1 year ago
Steve Simpson	08b18113d2	Alerting: Wire up alertmanagerRemoteOnly feature toggle. (#88329 ) * Alerting: Wire up alertmanagerRemoteOnly feature toggle. Though the mode isn't feature complete yet, it will be useful to have the feature toggle wired up in order to start testing. * Apply suggestions from code review Co-authored-by: Santiago <santiagohernandez.1997@gmail.com> * Formatting --------- Co-authored-by: Santiago <santiagohernandez.1997@gmail.com>	1 year ago
Steve Simpson	8421919cb5	Alerting: Feature toggle to disallow sending alerts externally (#87982 ) * Define feature toggle * Implement feature toggle	1 year ago
Santiago	e41434c332	Alerting: Promote configuration in the remote Alertmanager (#87388 )	1 year ago
Steve Simpson	67fa96f88d	Alerting: Pass logger into NewAnnotationBackend. (#87812 ) * Alerting: Pass logger into NewAnnotationBackend. Make it possible to pass loggers into more places for code reuse. * Mistake in passing logger	1 year ago
Steve Simpson	fbaa847a3c	Alerting: Pass logger into NewRemoteLokiBackend. (#87029 ) Tiny refactor to allow a logger to be passed into NewRemoteLokiBackend.	1 year ago
Santiago	309a7e7684	Alerting: Implement SaveAndApplyDefaultConfig in the remote Alertmanager struct (#85005 ) * Alerting: Implement SaveAndApplyDefaultConfig in the remote Alertmanager struct * send the hash of the encrypted configuration * tests, default config hash in AM struct * add missing default config to test * restore build directory * go work file... * fix broken test * remove unnecessary conversion to []byte * go work again... * make things work again with latest main branch changes * update error messages in tests for decrypting config	1 year ago
Jean-Philippe Quéméner	7cfd470c91	fix(alerting): only expose metrics if executing alerts (#85512 )	1 year ago
Matthew Jacobson	0c3c5c5607	Alerting: Stop persisting silences and nflog to disk (#84706 ) With this change, we no longer need to persist silence/nflog states to disk in addition to the kvstore	1 year ago
Yuri Tseretyan	b9abb8cabb	Alerting: Update provisioning API to support regular permissions (#77007 ) * allow users with regular actions access provisioning API paths * update methods that read rules skip new authorization logic if user CanReadAllRules to avoid performance impact on file-provisioning update all methods to accept identity.Requester that contains all permissions and is required by access control. * create deltas for single rul e * update modify methods skip new authorization logic if user CanWriteAllRules to avoid performance impact on file-provisioning update all methods to accept identity.Requester that contains all permissions and is required by access control. * implement RuleAccessControlService in provisioning * update file provisioning user to have all permissions to bypass authz * update provisioning API to return errutil errors correctly --------- Co-authored-by: Alexander Weaver <weaver.alex.d@gmail.com>	1 year ago
Santiago	c9bb18101c	Alerting: Decrypt secrets before sending configuration to the remote Alertmanager (#83640 ) * (WIP) Alerting: Decrypt secrets before sending configuration to the remote Alertmanager * refactor, fix tests * test decrypting secrets * tidy up * test SendConfiguration, quote keys, refactor tests * make linter happy * decrypt configuration before comparing * copy configuration struct before decrypting * reduce diff in TestCompareAndSendConfiguration * clean up remote/alertmanager.go * make linter happy * avoid serializing into JSON to copy struct * codeowners	1 year ago
Gilles De Mey	8765c48389	Alerting: Remove legacy alerting (#83671 ) Removes legacy alerting, so long and thanks for all the fish! 🐟 --------- Co-authored-by: Matthew Jacobson <matthew.jacobson@grafana.com> Co-authored-by: Sonia Aguilar <soniaAguilarPeiron@users.noreply.github.com> Co-authored-by: Armand Grillet <armandgrillet@users.noreply.github.com> Co-authored-by: William Wernert <rwwiv@users.noreply.github.com> Co-authored-by: Yuri Tseretyan <yuriy.tseretyan@grafana.com>	1 year ago
William Wernert	8690a42e33	Alerting: Disallow invalid rule namespace UIDs in provisioning API (#83938 ) * Disallow invalid rule namespace UIDs in provisioning Reject requests with rules that reference a nonexistent folder or have an empty folder uid	1 year ago
Yuri Tseretyan	1eebd2a4de	Alerting: Support for simplified notification settings in rule API (#81011 ) * Add notification settings to storage\domain and API models. Settings are a slice to workaround XORM mapping * Support validation of notification settings when rules are updated * Implement route generator for Alertmanager configuration. That fetches all notification settings. * Update multi-tenant Alertmanager to run the generator before applying the configuration. * Add notification settings labels to state calculation * update the Multi-tenant Alertmanager to provide validation for notification settings * update GET API so only admins can see auto-gen	1 year ago
Alexander Weaver	99fa064576	Alerting: Emit warning when creating or updating unusually large groups (#82279 ) * Add config for limit of rules per rule group * Warn when editing big groups through normal API * Warn on prov api writes for groups * Wire up comp root, tests * Also add warning to state manager warm * Drop unnecessary conversion	1 year ago
Alexander Weaver	5bbe9c6e61	Alerting: Enable group-level rule evaluation jittering by default, remove feature toggle (#82212 ) * remove jitter feature flag * Add an out so users can manually disable jitter * Pass in cfg * Add TODO to remove knob in future	1 year ago
George Robinson	90a26e18db	Alerting: Update Alertmanager to e82436c (#82145 ) This commit updates Alertmanager to commit e82436c, which is based on commit f69a508 from Prometheus Alertmanager.	1 year ago
William Wernert	2ea82af6e7	Alerting: Pass in receiver service to API struct (#81978 )	1 year ago
George Robinson	c8ccc4649c	Alerting: Support UTF-8 (#81512 ) This pull request updates our fork of Alertmanager to commit 65bdab0, which is based on commit 5658f8c in Prometheus Alertmanager. It applies the changes from grafana/alerting#155 which removes the overrides for validation of alerts, labels and silences that we had put in place to allow alerts and silences to work for non-Prometheus datasources. However, as this is now supported in Alertmanager with the UTF-8 work, we can use the new upstream functions and remove these overrides. The compat package is a package in Alertmanager that takes care of backwards compatibility when parsing matchers, validating alerts, labels and silences. It has three modes: classic mode, UTF-8 strict mode, fallback mode. These modes are controlled via compat.InitFromFlags. Grafana initializes the compat package without any feature flags, which is the equivalent of fallback mode. Classic and UTF-8 strict mode are used in Mimir. While Grafana Managed Alerts have no need for fallback mode, Grafana can still be used as an interface to manage the configurations of Mimir Alertmanagers and view configurations of Prometheus Alertmanager, and those installations might not have migrated or being running on older versions. Such installations behave as if in classic mode, and Grafana must be able to parse their configurations to interact with them for some period of time. As such, Grafana uses fallback mode until we are ready to drop support for outdated installations of Mimir and the Prometheus Alertmanager.	1 year ago
William Wernert	7e939401dc	Alerting: Introduce initial common receiver service (#81211 ) * Create locking config store that mimics existing provisioning store * Rename existing receivers(_test).go * Introduce shared receiver group service * Fix test * Move query model to models package * ReceiverGroup -> Receiver * Remove locking config store * Move convert methods to compat.go * Cleanup	1 year ago
Jean-Philippe Quéméner	aa25776f81	Alerting: Add a feature flag to periodically save states (#80987 )	1 year ago
Alexander Weaver	00a260effa	Alerting: Add setting to distribute rule group evaluations over time (#80766 ) * Simple, per-base-interval jitter * Add log just for test purposes * Add strategy approach, allow choosing between group or rule * Add flag to jitter rules * Add second toggle for jittering within a group * Wire up toggles to strategy * Slightly improve comment ordering * Add tests for offset generation * Rename JitterStrategyFrom * Improve debug log message * Use grafana SDK labels rather than prometheus labels	1 year ago
Jean-Philippe Quéméner	82638d059f	feat(alerting): add state persister interface (#80384 )	1 year ago
Santiago	9e78faa7ba	Alerting: Add metrics to the remote Alertmanager struct (#79835 ) * Alerting: Add metrics to the remote Alertmanager struct * rephrase http_requests_failed description * make linter happy * remove unnecessary metrics * extract timed client to separate package * use histogram collector from dskit * remove weaveworks dependency * capture metrics for all requests to the remote Alertmanager (both clients) * use the timed client in the MimirAuthRoundTripper * HTTPRequestsDuration -> HTTPRequestDuration, clean up mimir client factory function * refactor * less git diff * gauge for last readiness check in seconds * initialize LastReadinesCheck to 0, tweak metric names and descriptions * add counters for sync attempts/errors * last config sync and last state sync timestamps (gauges) * change latency metric name * metric for remote Alertmanager mode * code review comments * move label constants to metrics package	1 year ago
Matthew Jacobson	aa03b8f8a7	Alerting: Guided legacy alerting upgrade dry-run (#80071 ) This PR has two steps that together create a functional dry-run capability for the migration. By enabling the feature flag alertingPreviewUpgrade when on legacy alerting it will: a. Allow all Grafana Alerting background services except for the scheduler to start (multiorg alertmanager, state manager, routes, …). b. Allow the UI to show Grafana Alerting pages alongside legacy ones (with appropriate in-app warnings that UA is not actually running). c. Show a new “Alerting Upgrade” page and register associated /api/v1/upgrade endpoints that will allow the user to upgrade their organization live without restart and present a summary of the upgrade in a table.	1 year ago
Santiago	a77ba40ed4	Alerting: Use the forked Alertmanager for remote secondary mode (#79646 ) * (WIP) Alerting: Use the forked Alertmanager for remote secondary mode * fall back to using internal AM in case of error * remove TODOs, clean up .ini file, add orgId as part of remote AM config struct * log warnings and errors, fall back to remoteSecondary, fall back to internal AM only * extract logic to decide remote Alertmanager mode to a separate function, switch on mode * tests * make linter happy * remove func to decide remote Alertmanager mode * refactor factory function and options * add default case to switch statement * remove ineffectual assignment	1 year ago
Santiago	9945514baa	Alerting: Validate configuration for the remote Alertmanager struct (#79691 ) * Alerting: Validate configuration for the remote Alertmanager struct * add TenantID to test * add OrgID to config struct in tests	1 year ago

1 2 3 4 5

206 Commits (8044cb50f17a021a32e7ac0b83cf8d723457a9ae)