231 Commits (80f6560c9c7639a3b02dd41bc1a66516903b175c)

Author	SHA1	Message	Date
Karl Persson	e9a93ebfc9	Access Control: Move access control middlewares to domain package (#48322) ... * Move access control middleware to domain package	3 years ago
Alexander Weaver	60ec10566f	Extract Route validation from serialization methods so it can be re-used (#47649) ... * Extract validation and reject invalid policies * Validation in dedicated file * Tests for validation * Extract root route validation * Update call and drop TODO * empty commit to kick actions * Normalization should be idempotent * Cleaner representation of validation errors, chain errors properly * Make internal validate unexported * Fix missed rename * Genericize error message * Improve method names * Rebase, fix * Update asserts	3 years ago
Jean-Philippe Quéméner	a3256bafa7	Alerting: indicate whether contact point is provisioned (#48323)	3 years ago
Joe Blubaugh	103087a1a5	Unified Alerting: Validate PostableSilence API. (#46892) ... Invalid PostableSilences could be passed to the Alerting API - if they are passed all the way down into the alertmanager data layer, they can cause a panic. This change adds validation to avoid a panic in the alertmanager.	3 years ago
Alexander Weaver	078a578803	Drop ProvenanceOrgAdapter and build into store API instead (#48137)	3 years ago
Guilherme Caulada	a367ad730c	Secrets: Implement basic unified secret store service (#45804) ... * wip: Implement kvstore for secrets * wip: Refactor kvstore for secrets * wip: Add format key function to secrets kvstore sql * wip: Add migration for secrets kvstore * Remove unused Key field from secrets kvstore * Remove secret values from debug logs * Integrate unified secrets with datasources * Fix minor issues and tests for kvstore * Create test service helper for secret store * Remove encryption tests from datasources * Move secret operations after datasources * Fix datasource proxy tests * Fix legacy data tests * Add Name to all delete data source commands * Implement decryption cache on sql secret store * Fix minor issue with cache and tests * Use secret type on secret store datasource operations * Add comments to make create and update clear * Rename itemFound variable to isFound * Improve secret deletion and cache management * Add base64 encoding to sql secret store * Move secret retrieval to decrypted values function * Refactor decrypt secure json data functions * Fix expr tests * Fix datasource tests * Fix plugin proxy tests * Fix query tests * Fix metrics api tests * Remove unused fake secrets service from query tests * Add rename function to secret store * Add check for error renaming secret * Remove bus from tests to fix merge conflicts * Add background secrets migration to datasources * Get datasource secure json fields from secrets * Move migration to secret store * Revert "Move migration to secret store" This reverts commit 7c3f872072. * Add secret service to datasource service on tests * Fix datasource tests * Remove merge conflict on wire * Add ctx to data source http transport on prometheus stats collector * Add ctx to data source http transport on stats collector test	3 years ago
George Robinson	c5547123bc	Remove redundant queries in GetAlertRules and GetOrgAlertRules and replace with ListAlertRules (#48108)	3 years ago
Alexander Weaver	8310789ef1	Indicate whether routes are provisioned when GETting Alertmanager configuration (#47857) ... * Test composition simplification from last PR * Policies use proper API model everywhere * Expose policy provenance in API, miss some dep injection * Complete injection * fix args * Tests for provenance value * Extract test helpers so tests are very readable * Single source adapter struct that was copied in 3 places * Drop redundant test * Resolve merge conflicts on changelog	3 years ago
Vardan Torosyan	a0553de8dd	Rename FGAC to RBAC in the codebase (#48051)	3 years ago
Sofia Papagiannaki	54962c2f0c	Alerting: Rename Recipient path parameter to DatasourceID (#47949)	3 years ago
Alexander Weaver	758364e78b	Alerting: Refactor GET/POST alerting config routes to be more extensible (#47229) ... * Refactor GET am config to be extensible * Extract post config route * Fix tests * Remove temporary duplication * Fix broken test due to layer shift * Fix duplicated error message * Properly return 400 on config rejection * Revert weird half method extraction * Move things to notifier package and avoid redundant interface * Simplify documentation * Split encryption service and depend on minimal abstractions * Properly initialize things all the way up to the composition root * Encryption -> Crypto * Address misc feedback * Missing docstring * Few more simple polish improvements * Unify on MultiOrgAlertmanager. Discover bug in existing test * Fix rebase conflicts * Misc feedback, renames, docs * Access crypto hanging off MultiOrgAlertmanager rather than having a separate API to initialize	3 years ago
Jean-Philippe Quéméner	060ccacbf9	Alerting: unwrap upsert into insert and update function (#47731) ... * Alerting: unwrap upsert into insert and update function * add changelog entry * remove changelog entry * rename upsertrule to updaterule * use directly alertrule model for inserts * add test for updating a rule with a conflicting name	3 years ago
Alexander Weaver	c266a4ac81	Alerting: Remove mis-behaving fake and fix masked test failure in AM config API (#47747) ... * Remove misbehaving fake * Fix bug and inject logger	3 years ago
Jean-Philippe Quéméner	388ecb4037	Alerting: Provisioning API - Contact points (#47197)	3 years ago
Yuriy Tseretyan	af9353caec	Alerting: Add check for datasource permission in alert rule read API (#47087) ... * add check for access to rule's data source in GET APIs * use more general method GetAlertRules instead of GetNamespaceAlertRules. * remove unused GetNamespaceAlertRules. Tests: * create a method to generate permissions for rules * extract method to create RuleSrv * add tests for RouteGetNamespaceRulesConfig	3 years ago
Yuriy Tseretyan	48519f9ebb	Alerting: reduce database calls in prometheus-comptible rules API (#47080) ... * move validation at the beginning of method * remove usage of GetOrgRuleGroups because it is not necessary. All information is already available in memory. * remove unused method	3 years ago
Alexander Weaver	dde0b93cf1	Alerting: Provisioning API - Notification Policies (#46755) ... * Base-line API for provisioning notification policies * Wire API up, some simple tests * Return provenance status through API * Fix missing call * Transactions * Clarity in package dependencies * Unify receivers in definitions * Fix issue introduced by receiver change * Drop unused internal test implementation * FGAC hooks for provisioning routes * Polish, swap names * Asserting on number of exposed routes * Don't bubble up updated object * Integrate with new concurrency token feature in store * Back out duplicated changes * Remove redundant tests * Regenerate and create unit tests for API layer * Integration tests for auth * Address linter errors * Put route behind toggle * Use alternative store API and fix feature toggle in tests * Fixes, polish * Fix whitespace * Re-kick drone * Rename services to provisioning	3 years ago
gotjosh	cb6124c921	Alerting: Accurately set value for prom-compatible APIs (#47216) ... * Alerting: Accurately set value for prom-compatible APIs Sets the value fields for the prometheus compatible API based on a combination of condition `refID` and the values extracted from the different frames. * Fix an extra test * Ensure a consitent ordering * Address review comments * address review comments	3 years ago
Konrad Lalik	6992d17924	Alerting: Add support to distinguish Prometheus datasource subtypes (Mimir, Cortex and Vanilla Prometheus) (#46771) ... * Add basic UI for custom ruler URL * Add build info fetching for alerting data sources * Add keeping data sources build info in the store * Use data source build info to construct data source urls * Remove unused code * Add custom ruler support in prometheus api calls * Migrate actions * Use thunk condition to prevent multiple data source buildinfo fetches * Unify prom and ruler rules loading * Upgrade RuleEditor tests * Upgrade RuleList tests * Upgrade PanelAlertTab tests * Upgrade actions tests * Build info refactoring * Get rid of lotex ruler support action * Add prom ruler availability checking when the buildinfo is not available * Add rulerUrlBuilder tests * Improve prometheus data source validation, small build info refactoring * Change prefix based on Prometheus subtype * Use the correct path * Revert config routing * Add deprecation notice for /api/prom prefix * Add tests to the datasource subtype * Remove custom ruler support * Remove deprecation notice * Prevent fetching ruler rules when ruler api is not available * Add build info tests * Unify naming of ruler methods * Fix test * Change buildinfo data source validation * Use strings for subtype params and unveil mimir * organise imports * frontend changes and wordsmithing * fix test suite * add a nicer verbose message for prometheus datasources * detect Mimir datasource * fix test * fix buildinfo test for Mimir * shrink vectors * add some code documentation * DRY prepareRulesFilterQueryParams * clarify that Prometheus does not support managing rules * Improve buildinfo error handling Co-authored-by: gotjosh <josue.abreu@gmail.com> Co-authored-by: gillesdemey <gilles.de.mey@gmail.com>	3 years ago
Yuriy Tseretyan	e94d0c1b96	Alerting: update rule test endpoints to respect data source permissions (#47169) ... * make eval.Evaluator an interface * inject Evaluator to TestingApiSrv * move conditionEval to RouteTestGrafanaRuleConfig because it is the only place where it is used * update rule test api to check data source permissions	3 years ago
Yuriy Tseretyan	51114527dc	Alerting: handle folder permissions when fine-grained access enabled (#47035) ... * Use alert:create action for folder search with edit permissions. This matches the action that is used to query dashboards (the update will be addressed later) * Update rule store to use FindDashboards instead of folder service to list folders the user has access to view alerts. Folder service does not support query type and additional filters. * Do not check whether the user can save to folder if FGAC is enabled because it is checked on API level.	3 years ago
Yuriy Tseretyan	8a2c368031	check that user is authorized to create\update silences (#47163)	3 years ago
Alexander Weaver	502cf8b37f	Alerting: Unify Swagger/OpenAPI generation tooling (#46928) ... * Unify makefiles * Improve documentation	3 years ago
Yuriy Tseretyan	c1dbe7617c	fix scope for datasource:query action (#46973)	3 years ago
Yuriy Tseretyan	e20d157a9b	Alerting: rules delete API to check data source authorization (#46906) ... * merge RuleSrv rule delete methods * remove unused store methods * implement delete by uid for fake store * add scheduler mock * implement tests for RouteDeleteAlertRules	3 years ago
Yuriy Tseretyan	15e4556c2f	Alerting: update authorization logic to use proper legacy roles when fine-grained access is disabled (#46931) ... * require legacy Editor for post, put, delete endpoints * require user to be signed in on group level because handler that checks that user has role Editor does not check it is signed in	3 years ago
Yuriy Tseretyan	8868848e93	Alerting: rule group update API to ignore deletes of rules user is not authorized to access (#46905) ... * verify that the user has access to all data sources used by the rule that needs to be deleted from the group * if a user is not authorized to access the rule, the rule is removed from the list to delete	3 years ago
Yuriy Tseretyan	60d4cd80bf	Alerting: update DeleteAlertRuleByUID to accept many UID (#46890)	3 years ago
Yuriy Tseretyan	4ee48c2e77	Alerting: Update GetRuleGroupAlertRules to accept optional rule group (#46889) ... * rename GetRuleGroupAlertRules to GetAlertRules * make rule group optional in GetAlertRulesQuery * simplify FakeStore. the current structure did not support optional rule group	3 years ago
Yuriy Tseretyan	acd7be1cb4	Alerting: Change getEvaluatorForAlertRule to checkDatasourcePermissionsForRule (#46887) ... update method getEvaluatorForAlertRule to accept permissions evaluator and exit on the first negative result, which is more effective than returning an evaluator that in fact is a bunch of slices.	3 years ago
Eng Zer Jun	b56848f006	test: use `T.TempDir` to create temporary test directory (#44947) ... The directory created by `T.TempDir` is automatically removed when the test and all its subtests complete. Reference: https://pkg.go.dev/testing#T.TempDir Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>	3 years ago
Yuriy Tseretyan	2ade8b56dd	Alerting: support fine-grained access control in ruler update API (#45749) ... * require Editor if FGAC is disabled. Otherwise, check `alert.rule:*` + `datasource:query` permissions when user changes rules.	3 years ago
gotjosh	a338c78ca8	Alerting: Remove internal labels from prometheus compatible API responses (#46548) ... * Alerting: Remove internal labels from prometheus compatible API responses * Appease the linter * Fix integration tests * Fix API documentation & linter * move removal of internal labels to the models	3 years ago
Karl Persson	2727e2503f	Use corrct variable names (#46647)	3 years ago
Yuriy Tseretyan	c42d2e6f5d	Alerting: Add support for fine-grained access to alerting APIs (#46561)	3 years ago
Yuriy Tseretyan	468def0c00	Alerting: fixed roles for fine-grained access control (#46553) ... * move alerting actions to accesscontrol to avoid cycledeps * define new actions and fixed roles for alerting * add folder permission to alert reader role	3 years ago
Alexander Weaver	92716cb602	Alerting: Create abstraction for launching transactions and refactor existing transaction management to use it (#46216) ... * Remove InTransaction from RuleStore and make it its own interface * Ensure that ctx-based is clear from name * Resolve merge conflicts * Refactor tests to work in terms of the introduced abstraction rather than concrete dbstore	3 years ago
gotjosh	a75d4fcbd8	Alerting: Display query from grafana-managed alert rules on `/api/v1/rules` (#45969) ... * Aleting: Extract query from alerting rule model for api/v1/rules * more changes and fixtures * appease the linter	3 years ago
gotjosh	8d4a0a0396	Alerting: Include annotations in prometheus Alert response. (#45970) ... * Alerting: Include annotations in prometheus Alert response. * add tests * re-order depedencies	3 years ago
Yuriy Tseretyan	f7894db99c	Alerting: declare authorization actions, scopes and roles for fine-grained access (#45748) ... * add actions, roles and route mapping for rule permission * add instance\notification actions * do not declare alerting roles if no feature flag is set (temporary)	3 years ago
Yuriy Tseretyan	288e8eeb15	Alerting: Do not update rule in database if it was not changed (#45980) ... * do not include update if no diff * refactor calculate changes to include diff (and log) Co-authored-by: George Robinson <george.robinson@grafana.com>	3 years ago
Gilles De Mey	a9b1a964b0	Alerting: adds support for federated rules (#46037)	3 years ago
Yuriy Tseretyan	016d9e14ed	Add missing option "OK" for Error state (#45262) ... * Add missing OK option to models * add ok to legacy legacy UI does not support it but it is possible to do so via provisioning. * use enums in migration so linter would catch missing cases	3 years ago
Yuriy Tseretyan	f75bea481d	Alerting: validate rules and calculate changes in API controller (#45072) ... * Update API controller - add validation of rules API model - add function to calculate changes between the submitted alerts and existing alerts - update RoutePostNameRulesConfig to validate input models, calculate changes and apply in a transaction * Update DBStore - delete unused storage method. All the logic is moved upstream. - upsert to not modify fields of new by values from the existing alert - if rule has UID do not try to pull it from db. (it is done upstream) * Add rule generator	3 years ago
George Robinson	4e3a72fc2a	Add context.Context to AlertingStore (#45069)	3 years ago
Yuriy Tseretyan	ea236c276e	add missing option to swagger spec (#45070)	3 years ago
Sofia Papagiannaki	35fe58de37	API: Extract OpenAPI specification from source code using go-swagger (#40528) ... * API: Using go-swagger for extracting OpenAPI specification from source code * Merge Grafana Alerting spec * Include enterprise endpoints (if enabled) * Serve SwaggerUI under feature flag * Fix building dev docker images * Configure swaggerUI * Add missing json tags Co-authored-by: Ying WANG <ying.wang@grafana.com> Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com>	3 years ago
George Robinson	a9399ab3cd	Alerting: Add context.Context to RuleStore (#45004) ... Alerting: Add context.Context to RuleStore	3 years ago
Yuriy Tseretyan	ddfe2dce74	Alerting: Split grafana and lotex routes (#44742) ... * split Lotex and Grafana routes * update template to use authorize function for every route	3 years ago
George Robinson	9df43abbb5	Fix evaluation of alert rules for datasources with custom headers (#44862) ... * Fix evaluation of alert rules for datasources with custom headers * Fix unit tests * Fix integration tests * Evaluator fields should be package private	3 years ago