grafana

Commit Graph

Author	SHA1	Message	Date
Andreas Christou	ecaa1dcbfd	AzureMonitor: Migrate to backend checkHealth API (#50448 ) * Add check health functions for each datasource and generic checkHealth function * Log backend errors * Update testDatasource function - Remove unused testDatasource functions from pseudo datasources * Switch datasource to extend DataSourceWithBackend * Improve errors and responses from health endpoint * Fix backend lint issues * Remove unneeded frontend tests * Remove unused/unnecessary datasource methods * Update types * Improve message construction * Stubbing out checkHealth tests * Update tests - Remove comments - Simplify structure * Update log analytics health check to query data rather than retrieve workspace metadata * Fix lint issue * Fix frontend lint issues * Update pkg/tsdb/azuremonitor/azuremonitor.go Co-authored-by: Andres Martinez Gotor <andres.martinez@grafana.com> * Updates based on PR comments - Don't use deprecated default workspace field - Handle situation if no workspace is found by notifying user - Correctly handle health responses * Remove debug line * Make use of defined api versions * Remove field validation functions * Expose errors in frontend * Update errors and tests * Remove instanceSettings * Update error handling * Improve error handling and presentation * Update tests and correctly check error type * Refactor AzureHealthCheckError and update tests * Fix lint errors Co-authored-by: Andres Martinez Gotor <andres.martinez@grafana.com>	3 years ago
Serge Zaitsev	ae9491c3a7	Chore: Make test tracer noop and return no errors (#50797 )	3 years ago
Kat Yang	3c3039f5b3	Chore: Remove Wrap (#50048 ) * Chore: Remove Wrap and Wrapf * Fix: Add error check	3 years ago
Andreas Christou	2780651ea8	AzureMonitor: Fix auto-selection of time-grain for metrics. (#49278 ) * Update query editor to fix auto time-grain selection * Update new query editor to fix auto time-grain selection * Remove log and fix lint issues * Add test for useMetricMetadata - Add necessary types * More test updates - Update old dataHooks test - Ensure query changes Co-authored-by: Kevin Yu <kevinwcyu@users.noreply.github.com> Co-authored-by: Andres Martinez Gotor <andres.mgotor@gmail.com> Co-authored-by: Erik Sundell <erik.sundell87@gmail.com>	3 years ago
Andreas Christou	2bd9e9aca5	AzureMonitor: Add support for selecting multiple options when using the equals and not equals dimension filters (#48650 ) * Add support for multiselect - Add filters param to Dimensions - Update existing tests - Add MultiSelect component - Add helper function to determine valid options - Update labels hook to account for custom values - Update go type - Add function to build valid filters string * Additional go tests - Ensure query targets are built correctly * Update DimensionFields frontend test - Corrently rerender components - Additional test for multiple labels selection - Better selection of options in react-select components * Fix lint issue * Reset filters when operator or dimension changes * Terminology * Update test * Add backend migration - Update types (deprecate Filter field) - Add migration logic - Update tests - Update dimension filters buliding * Add migration test code * Simplify some logic * Add frontend deprecation notice * Add frontend migration logic and migration tests * Update setting of filter values * Update DimensionFields test * Fix linting issues * PR comment updates - Remove unnecessary if/else condition - Don't set filter default value as queries should be migrated - Add comment explaining why sw operator only accepts one value - Remove unnecessary test for merging of old and new filters * Nit on terminology Co-authored-by: Andres Martinez Gotor <andres.martinez@grafana.com> * Rename migrations for clarity Co-authored-by: Andres Martinez Gotor <andres.martinez@grafana.com>	3 years ago
Andreas Christou	d7c16e06d2	AzureMonitor: Add support for not equals and startsWith operators when creating Azure Metrics dimension filters. (#48077 ) * Allow dimension operator selection - Add dimension operators and function to update the operator in the query - Add logic to ensure the same dimension cannot be selected multiple times (Azure restriction) - Add selection component * Update backend logic to default operation and filter to eq '' - This must be done as the ne and sw operators do not work with the wildcard filter Add tests on dimension operators * Correct placement of 'and' when building query * Add comment and simplify filtering logic * Allow multiSelect for eq and ne operators - Pass PanelData to DimensionFields component - Add logic to retrieve labels from PanelData - Add MultiSelect component for relevant operators - Update frontend types to allow filter to be an array of strings - Update backend types to allow filter to be an array of strings - Update filter string building * Improve setting of labels * Update go tests * Update frontend tests - Add panelData mock (to be expanded later) - Update null check in DimensionFields * Allow custom value and set default * Add frontend test and fix lint issues * Improved handling of options for sw operator * Remove changes related to multiselect * Add check on refId to ensure dimension labels are correct for query * Extract custom hook for setting dimension labels * Add documentation around Azure Monitor metrics dimensions * Update MetricQueryEditor tests - Add missing data prop * Correctly set field values * Add additional expect for onQueryChange * Correctly set operators - Simplify onFilterInputChange * Ensure no duplicate filters appear * Ensure that filters are displayed correctly for saved queries * Update dimension filter test * Include additional test around changing dimension labels * Pass panel data through new metrics query editor	3 years ago
Andres Martinez Gotor	6edefe5147	AzureMonitor: Remove deprecated code (#48328 )	3 years ago
Kevin Yu	eef22c05e1	AzureMonitor: build azure portal deep link with resource uri (#47947 ) * AzureMonitor: build azure portal deep link with resource uri * extract resource name from the metrics api query * extract func for getting resource name from metrics url * add additional valid characters to regex	3 years ago
Kevin Yu	9829195829	AzureMonitor: fix the encoding of the metrics query deep link to Azure Portal (#48139 )	3 years ago
Kristin Laemmert	8f6877e12a	chore: remove all remaining uses of golang.org/x/net/context (#47564 ) * chore: remove all remaining uses of golang.org/x/net/context This PR finishes the work started in #47532, replacing all calls to that package with the stdlib context and using http.NewRequestWithContext to include the context where necessary. Bonus: small formatting fixes to goimports in these files. closes #44178 * tweak: use context.Background in favor of TODO for tests	3 years ago
Kevin Yu	ebe5f3646f	AzureMonitor: Use Resource Picker in Metrics Query Editor (#47164 ) * wip: new metrics query editor * prepend subscriptions to url path * remove duplicated setQueryValue file * add tests for new metrics query editor * wip start extracting resource field into a shared component * fix query editor test * fix up backend tests * move azure monitor specific getters to azure_monitor_datasource * use existing useAsyncState hook * extract useAsyncState into separate file * add datahooks tests * extract resource field component * cleanup * clarify variable names * remove logs query specific resource field component * add url_builder test * add azure_monitor_datasources tests * address comments * add types * pass resourceUri to resource field component * add test to check we reset the query fields when changing resources	3 years ago
Sergey Kostrukov	5675496f6b	Migrate to Grafana Azure SDK (#47232 )	3 years ago
Sergey Kostrukov	656ade9884	Shared Azure middleware between Azure Monitor and Prometheus datasources (#46002 ) * Scopes in Azure middleware * Enable Azure middleware without feature flag * Use common Azure middleware in Azure Monitor * Apply feature flag to JsonData configuration of Azure auth * Enforce feature flag in Prometheus datasource * Prometheus provider tests * Datasource service tests * Fix http client provider tests * Pass sdkhttpclient.Options by reference * Add middleware to httpclient.Options * Remove dependency on Grafana settings * Unit-tests updated * Fix ds_proxy_test * Fix service_test	3 years ago
Kevin Yu	1a4b1184bd	Azure Monitor: allow metrics call to use resource uri (#46858 ) * Azure Monitor: allow metrics call to use resource uri * test case when only resource uri is provided * remove logs * Rename json field name from resource to resourceUri * Group legacy URL builder params test cases * move comment to the correct position * Add clarifications in comments Co-authored-by: Sarah Zinger <sarah.zinger@grafana.com> Co-authored-by: Sarah Zinger <sarah.zinger@grafana.com>	3 years ago
Andres Martinez Gotor	48113beeeb	AzureMonitor: Fix missing top parameter when dimensions are set (#47010 )	3 years ago
Andres Martinez Gotor	700f6863f2	AzureMonitor: Move Application Insights and Insight Analytics to a deprecated package (#45834 )	3 years ago
Yaelle Chaudy	530913dd37	Azure Monitor : Adding json formatting of error messages in Panel Header Corner and Inspect Error Tab (#44877 ) * Trying out json formatting of azure graph err from frontend * Added some tests wip * Wrap text in popper tooltip * fix conflict * Wrap text in tooltip * Complete tests * Added invalid json test * Backend changes and tests * removed comments * Added split of message / json and edge cases tests * Addressed comments * moved catch to parseErrorMessage	3 years ago
Will Browne	7fbc7d019a	Plugins: Core plugins register via backend factory provider (#43171 ) * refactoring store interface and init flow * fix import * fix linter * refactor resource calling * load with class * re-order args * fix tests * fix linter * remove old creator * add custom config struct * fix some tests * cleanup * fix * tackle plugins * fix linter * refactor and fix test * add connect failure error * add fix for azure, cloud monitoring and test data * restructure * remove unused err * add fake tracer for test * fix grafana ds plugin	3 years ago
idafurjes	30aa24a183	Chore: Implement OpenTelemtry in Grafana (#42674 ) * Separate Tracer interface to TracerService and Tracer * Fix lint * Fix:Make it possible to start spans for both opentracing and opentelemetry in ds proxy * Add span methods, use span interface for rest of tracing * Fix logs in tracing * Fix tests that are related to tracing * Fix resourcepermissions test * Fix some tests * Fix more tests * Add TracingService to wire cli runner * Remove GlobalTracer from bus * Renaming test function * Remove GlobalTracer from TSDB * Replace GlobalTracer in api * Adjust tests to the InitializeForTests func * Remove GlobalTracer from services * Remove GlobalTracer * Remove bus.NewTest * Remove Tracer interface * Add InitializeForBus * Simplify tests * Clean up tests * Rename TracerService to Tracer * Update pkg/middleware/request_tracing.go Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com> * Initialize tracer before passing it to SQLStore initialization in commands * Remove tests for opentracing * Set span attributes correctly, remove unnecessary trace initiliazation form test * Add tracer instance to newSQLStore * Fix changes due to rebase * Add modified tracing middleware test * Fix opentracing implementation tags Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com>	3 years ago
idafurjes	b8852ef6a3	Chore: Remove context.TODO() (#43409 ) * Remove context.TODO() from services * Fix live test * Remove context.TODO	3 years ago
Will Browne	e4ba5f17dd	add core plugins thru store (#43085 )	3 years ago
Marcus Efraimsson	8927a3ca20	Chore: Query endpoint refactor (#41637 ) Get rid of using legacydata.RequestHandler in HTTPServer, /api/tsdb/query and pkg/expr with the goal of deprecating /api/tsdb/query and remove it completely eventually. This is the first step of cleaning up the HTTP API query endpoint. Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com> Co-authored-by: Alexander Emelin <frvzmb@gmail.com>	4 years ago
Marcus Efraimsson	baab021fec	Chore: Refactor usage of legacy data contracts (#41218 ) Refactor usage of legacy data contracts. Moves legacy data contracts to pkg/tsdb/legacydata package. Refactor pkg/expr to be a proper service/dependency that can be provided to wire to remove some unneeded dependencies to SSE in ngalert and other places. Refactor pkg/expr to not use the legacydata,RequestHandler and use backend.QueryDataHandler instead.	4 years ago
Will Browne	b80fbe03f0	Plugins: Refactor Plugin Management (#40477 ) * add core plugin flow * add instrumentation * move func * remove cruft * support external backend plugins * refactor + clean up * remove comments * refactor loader * simplify core plugin path arg * cleanup loggers * move signature validator to plugins package * fix sig packaging * cleanup plugin model * remove unnecessary plugin field * add start+stop for pm * fix failures * add decommissioned state * export fields just to get things flowing * fix comments * set static routes * make image loading idempotent * merge with backend plugin manager * re-use funcs * reorder imports + remove unnecessary interface * add some TODOs + remove unused func * remove unused instrumentation func * simplify client usage * remove import alias * re-use backendplugin.Plugin interface * re order funcs * improve var name * fix log statements * refactor data model * add logic for dupe check during loading * cleanup state setting * refactor loader * cleanup manager interface * add rendering flow * refactor loading + init * add renderer support * fix renderer plugin * reformat imports * track errors * fix plugin signature inheritance * name param in interface * update func comment * fix func arg name * introduce class concept * remove func * fix external plugin check * apply changes from pm-experiment * fix core plugins * fix imports * rename interface * comment API interface * add support for testdata plugin * enable alerting + use correct core plugin contracts * slim manager API * fix param name * fix filter * support static routes * fix rendering * tidy rendering * get tests compiling * fix install+uninstall * start finder test * add finder test coverage * start loader tests * add test for core plugins * load core + bundled test * add test for nested plugin loading * add test files * clean interface + fix registering some core plugins * refactoring * reformat and create sub packages * simplify core plugin init * fix ctx cancel scenario * migrate initializer * remove Init() funcs * add test starter * new logger * flesh out initializer tests * refactoring * remove unused svc * refactor rendering flow * fixup loader tests * add enabled helper func * fix logger name * fix data fetchers * fix case where plugin dir doesn't exist * improve coverage + move dupe checking to loader * remove noisy debug logs * register core plugins automagically * add support for renderer in catalog * make private func + fix req validation * use interface * re-add check for renderer in catalog * tidy up from moving to auto reg core plugins * core plugin registrar * guards * copy over core plugins for test infra * all tests green * renames * propagate new interfaces * kill old manager * get compiling * tidy up * update naming * refactor manager test + cleanup * add more cases to finder test * migrate validator to field * more coverage * refactor dupe checking * add test for plugin class * add coverage for initializer * split out rendering * move * fixup tests * fix uss test * fix frontend settings * fix grafanads test * add check when checking sig errors * fix enabled map * fixup * allow manual setup of CM * rename to cloud-monitoring * remove TODO * add installer interface for testing * loader interface returns * tests passing * refactor + add more coverage * support 'stackdriver' * fix frontend settings loading * improve naming based on package name * small tidy * refactor test * fix renderer start * make cloud-monitoring plugin ID clearer * add plugin update test * add integration tests * don't break all if sig can't be calculated * add root URL check test * add more signature verification tests * update DTO name * update enabled plugins comment * update comments * fix linter * revert fe naming change * fix errors endpoint * reset error code field name * re-order test to help verify * assert -> require * pm check * add missing entry + re-order * re-check * dump icon log * verify manager contents first * reformat * apply PR feedback * apply style changes * fix one vs all loading err * improve log output * only start when no signature error * move log * rework plugin update check * fix test * fix multi loading from cfg.PluginSettings * improve log output #2 * add error abstraction to capture errors without registering a plugin * add debug log * add unsigned warning * e2e test attempt * fix logger * set home path * prevent panic * alternate * ugh.. fix home path * return renderer even if not started * make renderer plugin managed * add fallback renderer icon, update renderer badge + prevent changes when renderer is installed * fix icon loading * rollback renderer changes * use correct field * remove unneccessary block * remove newline * remove unused func * fix bundled plugins base + module fields * remove unused field since refactor * add authorizer abstraction * loader only returns plugins expected to run * fix multi log output	4 years ago
Serge Zaitsev	a97e4d28a4	Chore: Refactor GoConvey in azuremonitor package (#40878 )	4 years ago
Isabella Siu	bf9be975ac	AzureMonitor: move metric deep link code to backend (#39524 )	4 years ago
Sergey Kostrukov	06a616e630	Update Azure SDK with bug fixes (#38952 )	4 years ago
jcolladokuri	aa45eebf3d	Azure Monitor: changed ARG API version to 2021-06-01-preview (#38951 ) * changed ARG API version to 2021-06-01-preview * Fixing lint error	4 years ago
shuotli	f2c4346cc4	Azure Monitor: Add support for numeric fields in ARG (#38728 ) * Fix todouble/toreal not working * fix test	4 years ago
Andres Martinez Gotor	b25eb0aa74	AzureMonitor: Fix wrong merge (#38623 )	4 years ago
Arve Knudsen	78596a6756	Migrate to Wire for dependency injection (#32289 ) Fixes #30144 Co-authored-by: dsotirakis <sotirakis.dim@gmail.com> Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com> Co-authored-by: Ida Furjesova <ida.furjesova@grafana.com> Co-authored-by: Jack Westbrook <jack.westbrook@gmail.com> Co-authored-by: Will Browne <wbrowne@users.noreply.github.com> Co-authored-by: Leon Sorokin <leeoniya@gmail.com> Co-authored-by: Andrej Ocenas <mr.ocenas@gmail.com> Co-authored-by: spinillos <selenepinillos@gmail.com> Co-authored-by: Karl Persson <kalle.persson@grafana.com> Co-authored-by: Leonard Gram <leo@xlson.com>	4 years ago
Sergey Kostrukov	c6356c5bba	Fix scopes mutation by cloning original array (#37981 )	4 years ago
shuotli	6ecf401cd1	AzureMonitor: Add data links to deep link to Azure Portal Azure Resource Graph (#35591 ) * Add deep link in ARG * add soverigh clouds * add query to Azure portal link * move deep link to backend * cloud specific to ARG * Add unit test * fix lint * fix escape issue * use constant & fix test * fix constant & use pathEscape * use cmp.Equal for test	4 years ago
Sergey Kostrukov	c1963024ec	Infra: Azure authentication in HttpClientProvider (#36932 ) * Azure middleware in HttpClientProxy * Azure authentication under feature flag * Minor fixes * Add prefixes to not clash with JsonData * Return error if JsonData cannot be parsed * Return original string if URL invalid * Tests for datasource_cache	4 years ago
Andres Martinez Gotor	96efbbaed1	Azure Monitor: Implement CallResourceHandler in the backend (#35581 )	4 years ago
Andres Martinez Gotor	114f6714c4	AzureMonitor: Fail rather than warn if Log credentials are set (#36652 )	4 years ago
Sergey Kostrukov	89ba607382	AzureMonitor: strongly-typed AzureCredentials and correct resolution of auth type and cloud (#36284 )	4 years ago
Andres Martinez Gotor	a4368790d5	AzureMonitor: Add an error message if a request failed with deprecated creds (#36136 )	4 years ago
Sergey Kostrukov	52e38c54e5	AzureMonitor: token provider into aztokenprovider and cleanup (#36102 )	4 years ago
Sarah Zinger	493d35ccc6	Azure monitor: ensure that time column has a name (#36144 ) Fixes bug when switching from Timeseries to Table view when viewing Azure Monitor Metrics Data.	4 years ago
Tom Pickles	b05b5d5e3b	AzureMonitor: Fix queries with Microsoft.NetApp/../../volumes resources (#32661 ) * Extend description of existing tests (#28350) * Tests for building MetricNamespaces URL (#28350) * Added tests that break the URL builder (#28350) * Arbitrary length of metric definition (#28350) * Change var to const as requested (#32661) * Adding tests to datasource url builder (#28350) * Fixes to datasource url builder (#28350) * Fixed linting issue that broke build (#28350)	4 years ago
Andres Martinez Gotor	7109285ac9	AzureMonitor: Use auth middleware for QueryData requests (#35343 )	4 years ago
shuotli	05f3985108	Upgrade ARG API version (#35464 )	4 years ago
Andres Martinez Gotor	d225323049	AzureMonitor: Use plugin SDK contracts (#34729 )	4 years ago
Sergey Kostrukov	412bcf1fb0	AzureMonitor: fix Azure Resource Graph queries in Azure China (#35235 ) * Optimize Azure Monitor routes * Update API version compatible with Azure China	4 years ago
Josh Hunt	cf94410e59	AzureMonitor: Update Logs workspace() template variable query to return resource URIs (#34445 ) * Migrate template variables straight into resource field, Display error if unable to migrate * Update workspace() template variable query function to return a resource URI * update backend to support resource uris in workspace field * don't load resource names for variables * throw error when workspace migration returns no results * update testDatasource to work with either resource URI or workspace GUID * fix tests * cleanup types just a little bit, as a treat	4 years ago
Marcus Efraimsson	348e76fc8e	Datasource: Shared HTTP client provider for core backend data sources and any data source using the data source proxy (#33439 ) Uses new httpclient package from grafana-plugin-sdk-go introduced via grafana/grafana-plugin-sdk-go#328. Replaces the GetHTTPClient, GetTransport, GetTLSConfig methods defined on DataSource model. Longer-term the goal is to migrate core HTTP backend data sources to use the SDK contracts and using httpclient.Provider for creating HTTP clients and such. Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>	4 years ago
Josh Hunt	5dca9fd4d8	AzureMonitor: Support querying any Resource for Logs queries (#33879 ) * wip * wip: * ui work for resource picker * disable rows when others are selected * resource picker open button * Azure Monitor: Connect to backend with real data (#34024) * Connect to backend with real data * Fixes from code review. * WIP:Begin thinking about how to make queries with scope determined by the resource picker * More fixes post code review. * Fixes after rebasing * Remove outdated todo * AzureMonitor: Support any resource for Logs queries (#33762) * Apply button for resource picker * scroll table body * secondary cancel button * loading state for nested rows * Display resource components in picker button * fix tests * fix icons * move route function * Migrate from workspace to resource uri for log analytics (#34337) * reword backwards compat comment * remove base url suffix * fix lint error * move migrations to seperate file * cleanup * update regex * cleanup * update plugin routes to use new azure auth type * use AzureDataSourceInstanceSettings alias Co-authored-by: Sarah Zinger <sarahzinger@users.noreply.github.com>	4 years ago
Sergey Kostrukov	e9e80bb4cb	Route fixes for Azure Resource Graph (#34410 )	4 years ago
Sergey Kostrukov	db1191f3ef	AzureMonitor: Refactor cloud and route resolution in the backend (#34342 ) * Determine Azure cloud based on authentication type * Route resolution for clouds * Fix tests * Constants for cloud names * move arg cloud route logic to routes.go Co-authored-by: Erik Sundell <erik.sundell87@gmail.com>	4 years ago

1 2 3

122 Commits (80f6560c9c7639a3b02dd41bc1a66516903b175c)