grafana

Commit Graph

Author	SHA1	Message	Date
Alex Moreno	531b439cf1	Alerting: Add alert pausing feature (#60734 ) * Add field in alert_rule model, add state to alert_instance model, and state to eval * Remove paused state from eval package * Skip paused alert rules in scheduler * Add migration to add is_paused field to alert_rule table * Convert to postable alerts only if not normal, pernding, or paused * Handle paused eval results in state manager * Add Paused state to eval package * Add paused alerts logic in scheduler * Skip alert on scheduler * Remove paused status from eval package * Apply suggestions from code review Co-authored-by: George Robinson <george.robinson@grafana.com> * Remove state * Rethink schedule and manager for paused alerts * Change return to continue * Remove unused var * Rethink alert pausing * Paused alerts storing annotations * Only add one state transition * Revert boolean method renaming refactor * Revert take image refactor * Make registry errors public * Revert method extraction for getting a folder title * Revert variable renaming refactor * Undo unnecessary changes * Revert changes in test * Remove IsPause check in PatchPartiLAlertRule function * Use SetNormal to set state * Fix text by returning to old behaviour on alert rule deletion * Add test in schedule_unit_test.go to test ticks with paused alerts * Add coment to clarify usage of context.Background() * Add comment to clarify resetStateByRuleUID method usage * Move rule get to a more limited scope * Update pkg/services/ngalert/schedule/schedule.go Co-authored-by: George Robinson <george.robinson@grafana.com> * rum gofmt on pkg/services/ngalert/schedule/schedule.go * Remove defer cancel for context * Update pkg/services/ngalert/models/instance_test.go Co-authored-by: Santiago <santiagohernandez.1997@gmail.com> * Update pkg/services/ngalert/models/testing.go Co-authored-by: Santiago <santiagohernandez.1997@gmail.com> * Update pkg/services/ngalert/schedule/schedule_unit_test.go Co-authored-by: Santiago <santiagohernandez.1997@gmail.com> * Update pkg/services/ngalert/schedule/schedule_unit_test.go Co-authored-by: Santiago <santiagohernandez.1997@gmail.com> * Update pkg/services/ngalert/models/instance_test.go Co-authored-by: Santiago <santiagohernandez.1997@gmail.com> * skip scheduler rule state clean up on paused alert rule * Update pkg/services/ngalert/schedule/schedule.go Co-authored-by: Santiago <santiagohernandez.1997@gmail.com> * Fix mock in test * Add (hopefully) final suggestions * Use error channel from recordAnnotationsSync to cancel context * Run make gen-cue * Place pause alert check in channel update after version check * Reduce branching un update channel select * Add if for error and move code inside if in state manager ResetStateByRuleUID * Add reason to logs * Update pkg/services/ngalert/schedule/schedule.go Co-authored-by: George Robinson <george.robinson@grafana.com> * Do not delete alert rule routine, just exit on eval if is paused * Reduce branching and create-close a channel to avoid deadlocks * Separate state deletion and state reset (includes history saving) * Add current pause state in rule route in scheduler * Split clearState and bring errCh closer to RecordStatesAsync call * Change rule to ruleMeta in RecordStatesAsync * copy state to be able to modify it * Add timeout to context creation * Shorten the timeout * Use resetState is rule is paused and deleteState if rule is not paused * Remove Empty state reason * Save every rule change in historian * Add tests for DeleteStateByRuleUID and ResetStateByRuleUID * Remove useless line * Remove outdated comment Co-authored-by: George Robinson <george.robinson@grafana.com> Co-authored-by: Santiago <santiagohernandez.1997@gmail.com> Co-authored-by: Armand Grillet <2117580+armandgrillet@users.noreply.github.com>	3 years ago
Kristin Laemmert	e8b8a9e276	chore: move dashboard_acl models into dashboard service (#62151 )	3 years ago
gotjosh	0bfe150928	Alerting: Fix Test Receivers when settings are non-strings (#62156 ) * Alerting: Fix Test Receivers when settings are non-strings As part of the Alerting extraction, we want to make sure we don't have circular depedencies. As such, I had to move `PostableGrafanaReceiver` to a new struct in `grafana/alerting` called `GrafanaReceiver`. `PostableGrafanaReceiver` has an attribute called `Settings` that uses a Grafana-propietary struct called `RawMessage`, this struct shadows `json.RawMessage`. When I created `GrafanaReceiver`, I turned settings into a `map[string]string` thinking all settings would end up as strings. This was a mistake, and this test proves that it doesn't work, and breaks the API.	3 years ago
George Robinson	a7eab8e46e	Alerting: Support context.Context in Loki interface (#61979 ) This commit adds support for canceleable contexts in the Loki interface.	3 years ago
Sofia Papagiannaki	cd27562c76	Access control: Modify dashboard/folder resolvers so that return also the inherited scopes (#62025 ) * Access Control: Add folder service dependency to the dashboard/folder resolvers * Expose the function fetching parents to folder interface * Add generic prepend utility * Modify dashboard resolvers to return inherited scopes	3 years ago
Alexander Weaver	eb1293ebb1	Alerting: Re-generate swagger definitions (#62154 ) Regenerate swagger, add body binding so parameters work	3 years ago
Alexander Weaver	046a9bb7c1	Alerting: Copy rule definitions into state history (#62032 ) * Copy rules instead of accepting pointer * Deep-copy the rule, for even more guarantees * Create struct just for needed fields * Move RuleMeta to historian/model package, iron out package dependencies * Move tests for dash ID parsing to model package along with code	3 years ago
idafurjes	b54b80f473	Chore: Remove Result from dashboard models (#61997 ) * Chore: Remove Result from dashboard models * Fix lint tests * Fix dashboard service tests * Fix API tests * Remove commented out code * Chore: Merge main - cleanup	3 years ago
idafurjes	421976e919	Chore: Remove folders from models pkg (#61853 )	3 years ago
Santiago	e5920c211e	Chore: Fix random indices for slices in test files (#61884 ) * Fix random indices for slices in test files * Empty commit	3 years ago
George Robinson	239d94205a	Alerting: Return chan <-error for #61811 (#61858 )	3 years ago
Alexander Weaver	7ccc845187	Alerting: Push state history entries to Loki (#61724 ) * Implement push endpoint * Drop duplicated struct * Genericize auth/tenant headers and improve logging in error case * Flesh out the data model * Drop dead code * Drop log line entirely * Drop unused arg * Rename a few type manipulation functions * Extract label keys as constants * Improve logs when loki responds with error * Inline lokiRepresentation function	3 years ago
Sofia Papagiannaki	c7a7ebd3e0	Chore: Drop search service dependency from folder service (#61789 ) * Chore: Drop search service dependency from folder service	3 years ago
gotjosh	0be920e61c	Alerting: Remove unused code after importing from grafana/alerting (#61869 ) * Alerting: Remove unused code after importing from grafana/alerting	3 years ago
gotjosh	511dab3b4b	Update `grafana/alerting` to the latest main (#61810 ) * Update `grafana/alerting` to the latest main Also updates prometheus-alertmanager since we use that one directly for some structs.	3 years ago
Sofia Papagiannaki	c104cc7020	Chore: Split folder store and dashboard store interfaces (#61655 ) * update folder store mock * Split folder store and dashboard store interfaces	3 years ago
Alexander Weaver	c10713ea76	Alerting: Create query interface for state history along with annotation-based implementation (#61646 )	3 years ago
Yuri Tseretyan	2c46f46d37	Alerting: Rule evaluator to get cached data source info (#61305 ) do not skip cache when get data source info	3 years ago
Jean-Philippe Quéméner	44b11d3228	Alerting: support basic auth for the state history loki client (#61696 )	3 years ago
George Robinson	d4256b352d	Docs: Rename Message templates to Notification templates (#59477 ) This commit renames "Message templates" to "Notification templates" in the user interface as it suggests that these templates cannot be used to template anything other than the message. However, message templates are much more general and can be used to template other fields too such as the subject of an email, or the title of a Slack message.	3 years ago
Sofia Papagiannaki	b80c9bb974	Chore: Drop dashboard service dependency from folder service (#61614 ) * Chore: Drop dashboard dependency from folder service	3 years ago
Santiago	b5fa9e3501	Chore: Fix "manger" typo (#61649 ) fix mangers -> managers	3 years ago
Alexander Weaver	1ac89ea040	Alerting: Add client configuration for remote Loki historian backend and test connection (#61114 ) * Create loki client type and ping method * Expose TestConnection on client * Configure and ping Loki URL * Close response body reader if present * Add 30 second timeout * Remove duplicate close	3 years ago
Kristin Laemmert	f6e3252c00	chore: move notifications models into notifications service (#61638 )	3 years ago
Matthew Jacobson	23e05373a7	Alerting: Fix flaky TestIntegrationUpdateAlertRules (#61641 ) Prevents random OrgID=0 in test alert generation causing invalid alert rule.	3 years ago
Alexander Weaver	4f1bdc0607	Alerting: Skip flaky test in TestIntegrationUpdateAlertRules (#61627 ) * Skip flaky test * Add comment	3 years ago
Denis Limarev	e6dee8a723	Perfomance: Preallocate slices (#61580 )	3 years ago
idafurjes	7c2522c477	Chore: Move dashboard models to dashboard pkg (#61458 ) * Copy dashboard models to dashboard pkg * Use some models from current pkg instead of models * Adjust api pkg * Adjust pkg services * Fix lint	3 years ago
Jo	dcfeab2c73	AuthN: User Quota (#61540 ) * remove reqContext from quota checks in login * add guards for nil ScopeParams	3 years ago
Yuri Tseretyan	9d57b1c72e	Alerting: Do not persist noop transition from Normal state. (#61201 ) * add feature flag `alertingNoNormalState` * update instance database to support exclusion of state in list operation * do not save normal state and delete transitions to normal * update get methods to filter out normal state	3 years ago
Ghazanfar	d553a016cc	Alerting: UI changes required to support v3 and Auth in Kafka Contact Point (#61123 )	3 years ago
Alexander Weaver	b289b8ac6e	Alerting: Set error annotation on EvaluationError regardless of underlying error type (#61506 ) Set error annotation regardless of underlying error type	3 years ago
gotjosh	e7cd6eb13c	Alerting: Use `alerting.GrafanaAlertmanager` instead of initialising Alertmanager components directly (#61230 ) * Alerting: Use `alerting.GrafanaAlertmanager` instead of initialising Alertmanager components directly	3 years ago
gotjosh	8f72893076	Alerting: Document not supporting inhibition rules (#61313 ) * Alerting: Document not supporting inhibition rules * Update docs/sources/alerting/manage-notifications/create-silence.md Co-authored-by: brendamuir <100768211+brendamuir@users.noreply.github.com> * Update docs/sources/alerting/manage-notifications/alertmanager.md Co-authored-by: brendamuir <100768211+brendamuir@users.noreply.github.com> Co-authored-by: brendamuir <100768211+brendamuir@users.noreply.github.com>	3 years ago
gotjosh	49ae1bbe63	Introduce `AlertingConfiguration` that implements `alerting.Configuration` (#61427 ) * Introduce `AlertingConfiguration` that implements `alerting.Configuration`	3 years ago
gotjosh	fd6f107ded	Alerting Unification: Use the errors from grafana/alerting in Alerts (#61425 )	3 years ago
gotjosh	ddb85ad6ad	Use the `ClusterPeer` interface from grafana/alerting (#61409 ) * Use the Cluster interface from grafana/alerting	3 years ago
gotjosh	2d1faae0b5	Alerting Unification: Use `alerting.MaintenanceOptions` to configure silences and nflog (#61384 )	3 years ago
gotjosh	39e429a14b	Alerting Unification: Use the errors from grafana/alerting in Silences (#61334 )	3 years ago
gotjosh	f85a948214	Alerting Unification: Use the State interface from the alerting package (#61333 )	3 years ago
Denis Limarev	90badc8729	Performance: Add preallocation for some slices (#59593 )	3 years ago
Yuri Tseretyan	b4e1e1871f	Alerting: Fix evaluation timeout (#61303 )	3 years ago
Yuri Tseretyan	86b5fbbf60	Alerting: Introduce state manager config structure (#61249 )	3 years ago
George Robinson	2a291afbae	Alerting: Use consts from alerting package (#61241 )	3 years ago
George Robinson	d19d8c6625	Alerting: Update Alerting and Alertmanager to v0.25.1 (#61233 ) Update Alerting and Alertmanager to v0.25.1	3 years ago
Yuri Tseretyan	da18c89e91	Alerting: Scheduler to call DeleteAlertRule once when it stops deleted rules (#61189 ) scheduler to call DeleteAlertRule once when it stops deleted rules	3 years ago
Yuri Tseretyan	48f1db63ff	Alerting: Add support for tracing to alerting scheduler (#61057 )	3 years ago
Alexander Weaver	eb960d9725	Alerting: Add un-documented toggle for changing state history backend, add shells for remote loki and sql (#61072 ) * Add toggle for state history backend and shells * Extract some shared logic and add tests	3 years ago
Alexander Weaver	8c3a5f6da0	Alerting: Allow state history to be disabled through configuration (#61006 ) * Add configuration option for if state history should be enabled * Inject no-op when history is disabled	3 years ago
George Robinson	9af7adef76	Alerting: Support customizable timeout for screenshots (#60981 ) This commit adds a customizable timeout for screenshots called capture_timeout. The default value is 10 seconds, and the maximum value is 30 seconds. This timeout should be less than the minimum Interval of all Evaluation Groups to avoid back pressure on alert rule evaluation.	3 years ago

1 2 3 4 5 ...

892 Commits (8379a29b53b27b6f88f0ad71abb1d8fc25a88165)