grafana

Commit Graph

Author	SHA1	Message	Date
Giuseppe Guerra	7b75bc6999	Plugins: Angular detector: Log detection patterns at debug level (#74802 ) * Plugins: Angular detector: Log detection patterns at debug level * Add tests	2 years ago
Will Browne	e855efb13d	Plugins: Move store and plugin dto to pluginsintegration (#74655 ) move store and plugin dto	2 years ago
Jack Westbrook	62821c69b3	Plugins: Bump SystemJS to 6.14.2 (#70068 ) * chore(plugins): bump systemjs to latest version * refactor(plugins): switch runtime over to use latest systemjs, add typings * refactor(plugins): use latest systemjs APIs for runtime dependency resolution * refactor(plugins): return valid urls from backend for latest systemjs import to work * revert(plugins): remove cfg from assetpath in favour of relative paths * fix(plugins): useDefault for systemjs deps to solve undefined errors * feat(plugins): add basic support for loading plugins via CDN * fix(plugins): load nested plugins with latest systemjs * feat(plugins): add back ability to transform plugin src for cdns * feat(plugins): get caching for module.js working, clean up * refactor(plugin_loader): create buildImportMap fn and more clean up * refactor(angularapp): use buildImportMap for dependencies and clean up * test(plugin_loader): fix failing test due to systemjs update * test(jest): mock systemjs amd extra in tests to prevent it breaking tests * chore(plugins): remove systemjs module-types extra, already included with system * fix(plugins): update key for invalidating cached plugins * fix: move systemjs amd define to another global so monaco can load * refactor(plugins): clean up cache buster and tests * chore(plugins): remove debug * refactor(plugins): move systemjs define to keep global cleaner * fix(plugins): set useDefault so system modules lodash references dont fail * feat(plugins): hook systemjs onload so stylesheets are applied to the dom * refactor(plugins): wrap amd formatted plugins in iife to prevent define collision * feat(plugins): support system module format for legacy plugins * test(plugincachebuster): update tests to match latest implementation * test(plugins-loader): fix up tests post module property change * fix test * Update pkg/plugins/manager/loader/assetpath/assetpath.go Co-authored-by: Will Browne <wbrowne@users.noreply.github.com> * chore(plugin_loader): remove stray import from merge conflict * Revert "Update pkg/plugins/manager/loader/assetpath/assetpath.go" This reverts commit 0df57d1cf20f49c22c93369001c70aae46a97c42. * fix(plugin_loader): set use default for shared plugin dependencies * refactor(plugins): use leading slash for Module and BaseUrl * fix(plugins): fix resolve appending extension to cache query param * refactor(plugins): align baseurl and module paths * refactor(plugins): update builtInPlugins keys to match naming convention * refactor(plugins): minor loader clean up, fix up types * test(plugins): fix failing tests * refactor(plugins): rename cache buster systemjs plugin to cache * refactor(plugins): separate plugin_loader into smaller files * chore(plugins): clean up plugin_loader types * chore(plugin_sandbox): fix typescript error * chore(npm): remove unplug debug and pin systemjs to 6.14.1 * refactor(plugins-cdn): update loaders to use absolute module url from backend * fix(plugins): escape period in systemjs module regex * chore(plugins): delete redundant systemjs plugins * refactor(plugin_loader): move hooks into own file, add types * test(plugins): add tests for systemjs loader hooks * chore(plugins): rename systemjshooks file * chore(plugins): remove redundant systemjs cdn backend code * fix(plugins): handle loading with config.appSubUrl * chore(plugins): delete redundant plugin-cdn angular code * test(plugins): fix failing systemjs test missing pluginsCDNBaseUrl * refactor(plugins): backend provides base and module properties with AppSubUrl * fix(plugins): consider AppSubUrl for plugin logos * fix(plugins): use isHostedOnCDN util when checking for cdn hosted plugins * add new appSubURL field to config * refactor relative URL func * fix path for core app * refactor asset path input * fix(plugins): catch errors in loadPluginCss * feat(plugins-cdn): selectively transform sourceMapURL * re-add deleted test case * chore(plugins): bump to latest systemjs@6.14.2 * feat(plugins): add systemjs-cjs-extra for loading commonjs plugins --------- Co-authored-by: Will Browne <will.browne@grafana.com> Co-authored-by: Will Browne <wbrowne@users.noreply.github.com>	2 years ago
Will Browne	3c50db328d	Plugins: Make Installer responsible for removing plugins from file system (#73323 ) * installer is responsible for removing from file system * take plugin as arg * remove resolve step * return plugin in test	2 years ago
Will Browne	75b0788377	Plugins: Remove registry dependency from process manager (#73241 ) simplify	2 years ago
Will Browne	c5e9a82ccb	Plugins: Do not fail bootstrap stage if single decorate step fails (#73147 ) * don't fail all if decorate step fails * fix casing * include err too * cover pluginsintegration too	2 years ago
Will Browne	d29f4a8f76	Plugins: Add context to StaticRouteResolver and ErrorResolver interfaces (#73121 ) * add ctx * fix tests	2 years ago
Will Browne	72da44db0e	Plugins: Add validation stage to plugin loader pipeline (#73053 ) * first pass * change validation signature * err tracking * fix * undo golden * 1 more * fix * adjust doc * add test helper * fix linter	2 years ago
Will Browne	98f827537b	Plugins: Add remaining steps to inititialization stage (#72894 ) add remainder of init steps	2 years ago
Will Browne	60b4a0b2a4	Plugins: Add termination stage to plugin loader pipeline (#72822 ) * add termination stage * uid -> pluginID (for now) * also fix fakes * add simple test * Fix logger name Co-authored-by: Giuseppe Guerra <giuseppe.guerra@grafana.com> * inline stop func call Co-authored-by: Giuseppe Guerra <giuseppe.guerra@grafana.com> --------- Co-authored-by: Giuseppe Guerra <giuseppe.guerra@grafana.com>	2 years ago
Will Browne	ad2705fa0b	Plugins: Add inititialization stage to plugin loader pipeline (#72667 ) * first pass * migrate tests * simplify * fix comments * fix linter * nil checks * remove comment	2 years ago
Will Browne	ec6412bcca	Plugins: Use plugins config to source app URL (#72490 ) * use plugins config for app URL * merge with main * add missing file * add fg * fix tests	2 years ago
Will Browne	758d9884bc	Plugins: Plugins loader pipeline (#71438 ) * discovery * flesh out * add docs * remove unused func * bootstrap stage * fix docs * update docs * undo unnecessary changes * add end tag * update doc * fix linter * fix * tidy * update docs * add class to filter func * apply PR feedback * fix test	2 years ago
Will Browne	162dde5bdd	Plugins: Use suffix for plugin directory (#71375 ) * plugin dir suffix * fix whitespace * fix cli * fix tests * fixup * simplify * undo uninstall changes	3 years ago
Will Browne	9e999b455b	Plugins: Remove redundant dupe checker (#71564 ) remove useless dupe checker	3 years ago
Will Browne	1274979f3f	Plugins: Remove unused config field from SignatureCalculator (#71297 ) remove unused cfg field	3 years ago
Giuseppe Guerra	a8d2a9ae2b	Plugins: Angular detector: Add database cache store for remote patterns (#70693 ) * Plugins: Angular detector: Remote patterns fetching * Renamed PatternType to GCOMPatternType * Renamed files * Renamed more files * Moved files again * Add type checks, unexport GCOM structs * Cache failures, update log messages, fix GCOM URL * Fail silently for unknown pattern types, update docstrings * Fix tests * Rename gcomPattern.Value to gcomPattern.Pattern * Refactoring * Add FlagPluginsRemoteAngularDetectionPatterns feature flag * Fix tests * Re-generate feature flags * Add TestProvideInspector, renamed TestDefaultStaticDetectorsInspector * Add TestProvideInspector * Add TestContainsBytesDetector and TestRegexDetector * Renamed getter to provider * More tests * TestStaticDetectorsProvider, TestSequenceDetectorsProvider * GCOM tests * Lint * Made detector.detect unexported, updated docstrings * Allow changing grafana.com URL * Fix API path, add more logs * Update tryUpdateRemoteDetectors docstring * Use angulardetector http client * Return false, nil if module.js does not exist * Chore: Split angualrdetector into angularinspector and angulardetector packages Moved files around, changed references and fixed tests: - Split the old angulardetector package into angular/angulardetector and angular/angularinspector - angulardetector provides the detection structs/interfaces (Detector, DetectorsProvider...) - angularinspector provides the actual angular detection service used directly in pluginsintegration - Exported most of the stuff that was private and now put into angulardetector, as it is not required by angularinspector * Renamed detector.go -> angulardetector.go and inspector.go -> angularinspector.go Forgot to rename those two files to match the package's names * Renamed angularinspector.ProvideInspector to angularinspector.ProvideService * Renamed "harcoded" to "static" and "remote" to "dynamic" from PR review, matches the same naming schema used for signing keys fetching * WIP: Angular: cache patterns in db, moved gcom into pluginsintegration More similar to signing keys fetching * Rename package, refactoring * try to solve circular import * Fix merge conflict on updated angular patterns * Fix circular imports * Fix wire gen * Add docstrings, refactoring * Removed angualrdetectorsprovider dependency into angularpatternsstore * Moved GCOM test files * Removed GCOM cache * Renamed Detect to DetectAngular and Detector to AngularDetector * Fix call to NewGCOMDetectorsProvider in newDynamicInspector * Removed unused test function newError500GCOMScenario * Added angularinspector service definition in pluginsintegration * refactoring * lint * Fix angularinspector TestProvideService * cleanup * Await initial restore * Register dynamicAngularDetector background service * Removed static detectors provider from pluginsintegration * Add tests for kvstore * Add more tests * order imports in dynamic_test.go * Fix potential panic in dynamic_test * Add "runs the job periodically" test * lint * add timeout to test * refactoring * Removed context.Context from DetectorsProvider * Refactoring, ensure angular dynamic background service is not started if feature flag is off * Fix deadlock on startup * Fix angulardetectorsprovider tests * Revert "Removed context.Context from DetectorsProvider" This reverts commit `4e8c6dded7`. * Fix wrong argument number in dynamic_teset * Standardize gcom http client * Reduce context timeout for angular inspector in plugins loader * Simplify initial restore logic * Fix dynamic detectors provider tests * Chore: removed angulardetector/provider.go * Add more tests * Removed backgroundJob interface, PR review feedback * Update tests * PR review feedback: remove ErrNoCachedValue from kv store Get * Update tests * PR review feedback: add IsDisabled and remove nop background srevice * Update tests * Remove initialRestore channel, use mux instead * Removed backgroundJobInterval, use package-level variable instead * Add TestDynamicAngularDetectorsProviderBackgroundService * Removed timeouts * pr review feedback: restore from store before returning the service * Update tests * Log duration on startup restore and cron run * Switch cron job start log to debug level * Do not attempt to restore if disabled	3 years ago
Giuseppe Guerra	1d8628c0cd	Plugins: Angular detection: Fix detection not being run for CDN plugins (#70960 )	3 years ago
Andres Martinez Gotor	4ff0abd0d1	SaveExternalService (OAuth) on plugin load (#69764 )	3 years ago
Giuseppe Guerra	cca9d89733	Plugins: Angular detector: Remote patterns fetching (#69843 ) * Plugins: Angular detector: Remote patterns fetching * Renamed PatternType to GCOMPatternType * Renamed files * Renamed more files * Moved files again * Add type checks, unexport GCOM structs * Cache failures, update log messages, fix GCOM URL * Fail silently for unknown pattern types, update docstrings * Fix tests * Rename gcomPattern.Value to gcomPattern.Pattern * Refactoring * Add FlagPluginsRemoteAngularDetectionPatterns feature flag * Fix tests * Re-generate feature flags * Add TestProvideInspector, renamed TestDefaultStaticDetectorsInspector * Add TestProvideInspector * Add TestContainsBytesDetector and TestRegexDetector * Renamed getter to provider * More tests * TestStaticDetectorsProvider, TestSequenceDetectorsProvider * GCOM tests * Lint * Made detector.detect unexported, updated docstrings * Allow changing grafana.com URL * Fix API path, add more logs * Update tryUpdateRemoteDetectors docstring * Use angulardetector http client * Return false, nil if module.js does not exist * Chore: Split angualrdetector into angularinspector and angulardetector packages Moved files around, changed references and fixed tests: - Split the old angulardetector package into angular/angulardetector and angular/angularinspector - angulardetector provides the detection structs/interfaces (Detector, DetectorsProvider...) - angularinspector provides the actual angular detection service used directly in pluginsintegration - Exported most of the stuff that was private and now put into angulardetector, as it is not required by angularinspector * Renamed detector.go -> angulardetector.go and inspector.go -> angularinspector.go Forgot to rename those two files to match the package's names * Renamed angularinspector.ProvideInspector to angularinspector.ProvideService * Renamed "harcoded" to "static" and "remote" to "dynamic" from PR review, matches the same naming schema used for signing keys fetching * Fix merge conflict on updated angular patterns * Removed GCOM cache * Renamed Detect to DetectAngular and Detector to AngularDetector * Fix call to NewGCOMDetectorsProvider in newDynamicInspector * Removed unused test function newError500GCOMScenario * Added angularinspector service definition in pluginsintegration * Moved dynamic inspector into pluginsintegration * Move gcom angulardetectorsprovider into pluginsintegration * Log errUnknownPatternType at debug level * re-generate feature flags * fix error log	3 years ago
Giuseppe Guerra	5622f2f43a	Plugins: Angular: Update hardcoded Angular detection patterns (#70053 ) * Plugins: Angular: add ConfigCtrl to Angular patterns * Update angular detection patterns * Add tests	3 years ago
Will Browne	a221e1d226	Plugins: Standardize Golang enum naming convention (#69449 ) * standardize enum pattern * fix up	3 years ago
Will Browne	1fd4953833	Plugins: Optimize creation of Golang errors and slices (#69448 ) * tidy up * fix tests	3 years ago
Giuseppe Guerra	f148b5fb28	Plugins: Forbid loading Angular plugins when Angular is disabled (#69679 ) * Plugins: Forbid loading Angular plugins when Angular is disabled * Plugins: Made angulardetector a service, add tests for angular loader cases * Fix missing import * Add nolint:gocyclo to loadPlugins	3 years ago
Ryan McKinley	e17ef5e504	Pyroscope: Rename phlare to grafana-pyroscope-datasource (#68859 )	3 years ago
Giuseppe Guerra	7a132680ef	Revert "Plugins: Forbid loading Angular plugins when Angular is disabled (#69225 )" (#69657 ) This reverts commit `ff34279ff4`.	3 years ago
Giuseppe Guerra	ff34279ff4	Plugins: Forbid loading Angular plugins when Angular is disabled (#69225 ) * Plugins: Forbid loading Angular plugins when Angular is disabled * Plugins: Made angulardetector a service, add tests for angular loader cases * Fix missing import	3 years ago
Ryan McKinley	422684d8b0	Plugins: Support changing plugin IDs (hardcoded) (#67867 )	3 years ago
Will Browne	ae373c662c	Plugins: Refactor env vars to dedicated service (#68960 ) * add env vars service * fix tests * fix more tests	3 years ago
Giuseppe Guerra	16359c82a2	Plugins: Angular deprecation: Detect Angular plugins and expose in API (#66824 ) * Plugins: Angular deprecation: Detect Angular plugins and expose in API * Plugins: Angular detector: Close module.js * Plugins: Angular detector: consistent error messages * Plugins: Angular detector: Add test for missing module.js * Plugins: Angular detector: Fix integration tests * Plugins: Angular detector: Changed Angular detection patterns * Moved inMemoryFS to test_utils.go * Add different angular detectors * Plugins: Update plugins/data/expectedListResp.json * Plugins: Rename angular property to angularDetected * Plugins: Rename angular to angularDetected in Plugin and PluginDTO * Plugins: Add angularDetected to datasources, apps and plugins frontendsettings * Plugins: Add test for AngularDetected frontend settings	3 years ago
Will Browne	e0e2535c96	Plugins: Tidy up CLI code (#67813 ) * more tidying * move some things around * more tidying * fix linter	3 years ago
Andres Martinez Gotor	aa9838bd25	Chore: Refactor manifest verifier (#67218 )	3 years ago
Giuseppe Guerra	bfe1b68800	Plugins: Fs: Add option to access unallowed files in dev mode (#66492 ) * Plugins: Fs: Add option to access unallowed files in dev mode * Plugins: Fs: allow accessing unallowed files only when in dev mode * Plugins: Fs: Add ProvideLocalFinder * Plugins: FS: Pass whole config in NewLocalFinder() * Plugins: FS: Add AllowListLocalFS * Plugins: FS: Fix some tests * Plugins: FS: Update tests * Plugins: FS: Removed dead code * Plugins: FS: Add tests for AllowListFS * Plugins: FS: Update comments * Plugins: FS: Use variadic arguments for allow list rather than map * Plugins: FS: Remove unnecessary log * Plugins: FS: Do not escape plugin root dir * Fix merge conflict * Plugins: FS: Update comments * Plugins: FS: PR review changes * Fix merge conflict * Fix tests * Cleanup * Fix flaky test * Changes from PR review * Lint * Add comment to LocalFS.Remove * Fix Windows * Renamed devMode to production	3 years ago
Andres Martinez Gotor	9d7c3a101d	Chore: Use KVStore for the manifest public key (#66839 )	3 years ago
Will Browne	739c7f1c68	Plugins: Simplify plugin file removal (#66115 ) * make explicit class check when attempting to remove plugin * simplify plugin file tracking * fix test * apply feedback * fix linter	3 years ago
Andres Martinez Gotor	98c695c68f	Chore: Use Grafana API to retrieve the public key to validate plugins (#66439 )	3 years ago
Giuseppe Guerra	1c3ad81826	Plugins: Fix module.js file not being closed when loading plugins (#66288 ) * Plugins: Loader: Fix module.js file not being closed * Plugins: LocalFS: Add comments, ensure same Read() behaviour as os.File's * Changed comment for Close() * Add tests for LocalFS * "Fix" linter error * "Fix" linter error again	3 years ago
Andres Martinez Gotor	52f39e6fa0	Chore: Soft failure in plugin initialization (#66210 )	3 years ago
Giuseppe Guerra	652c6dbd22	Plugins: Refactoring: Move plugins tracing env vars to separate func (#66170 )	3 years ago
Stephanie Hingtgen	536fad5b61	Plugins: add env variables needed for the secure socks proxy in the plugins sdk (#65878 )	3 years ago
Will Browne	7808e74260	Plugins: Skip instrumenting plugin build info for core and bundled plugins (#66105 ) * only instrument plugin build for non core/bundled plugins * fix import	3 years ago
Will Browne	bff9f4c890	Plugins: Move config factory to pluginsintegration package (#65716 ) * move config to pluginsintegration package * change to all plugin toggle * fixes * fixes * fix lerna * fix test	3 years ago
Giuseppe Guerra	f1eddbad06	Plugins: Tracing: Add test for composite propagation (#65917 )	3 years ago
Will Browne	819c2f4ad8	Plugins: Remove unnecessary CDN code (#65929 ) remove unnecessary code	3 years ago
Giuseppe Guerra	2647b2e0f9	Plugins: Tracing: Disable distributed tracing for plugins by default (#65796 ) * Plugins: Tracing: Disable tracing by default, pass GF_VERSION only if tracing is enabled * Plugins: Tracing: Fix GF_PLUGIN_VERSION instead of GF_VERSION	3 years ago
Giuseppe Guerra	09078b14e1	Plugins: Support for distributed tracing in backend plugins SDK (#63714 ) * Tracing: Pass OTLP address and propagation format to plugins * Fix unit tests * Fix indentation * Fix plugin manager integration tests * Goimports * Pass plugin version to plugins * Do not add GF_PLUGIN_VERSION if plugin version is not set, add tests * Allow disabling plugins distributed tracing on a per-plugin basis * Moved disabled plugins to tracing.opentelemetry config section * Pre-allocate DisabledPlugins map to the correct size * Moved disable tracing setting flags in plugin settings * Renamed plugin env vars for tracing endpoint and propagation * Fix plugin initializer tests * Refactoring: Moved OpentelemetryCfg from pkg/infra to pkg/plugins * Changed GetSection to Section in parseSettingsOpentelemetry * Add tests for NewOpentelemetryCfg * Fix test case names in TestNewOpentelemetryCfg * OpenTelemetry: Remove redundant error checks	3 years ago
Will Browne	ee2dd62a1f	Plugins: Refactor loader + finder to support multiple sourcing methods (#64735 ) * it's cdn time * tidy body closing * auto signed * fix close * update log name * remove comments	3 years ago
lean.dev	0b0140b761	Licensing: Send the app url to plugin (#64258 )	3 years ago
Will Browne	68df83c86d	Plugins: Add Plugin FS abstraction (#63734 ) * unexport pluginDir from dto * first pass * tidy * naming + add mutex * add dupe checking * fix func typo * interface + move logic from renderer * remote finder * remote signing * fix tests * tidy up * tidy markdown logic * split changes * fix tests * slim interface down * fix status code * tidy exec path func * fixup * undo changes * remove unused func * remove unused func * fix goimports * fetch remotely * simultaneous support * fix linter * use var * add exception for gosec warning * fixup * fix tests * tidy * rework cfg pattern * simplify * PR feedback * fix dupe field * remove g304 nolint * apply PR feedback * remove unnecessary gosec nolint * fix finder loop and update comment * fix map alloc * fix test * remove commented code	3 years ago
Jack Westbrook	8c8f584b41	Plugins: Extend panel menu with links from plugins (#63089 ) * feat(plugins): introduce dashboard panel menu placement for adding menu items * test: add test for getPanelMenu() * added an unique identifier for each extension. * added context to getPluginExtensions. * wip * Wip * wiwip * Wip * feat: WWWIIIIPPPP 🧨 * Wip * Renamed some of the types to align a bit better. * added limit to how many extensions a plugin can register per placement. * decreased number of items to 2 * will trim the lenght of titles to max 25 chars. * wrapping configure function with error handling. * added error handling for all scenarios. * moved extension menu items to the bottom of the more sub menu. * added tests for configuring the title. * minor refactorings. * changed so you need to specify the full path in package.json. * wip * removed unused type. * big refactor to make things simpler and to centralize all configure error/validation handling. * added missing import. * fixed failing tests. * fixed tests. * revert(extensions): remove static extensions config in favour of registering via AppPlugin APIs * removed the compose that didn't work for some reason. * added tests just to verify that validation and error handling is tied together in configuration function. * adding some more values to the context. * draft validation. * added missing tests for getPanelMenu. * added more tests. * refactor(extensions): move logic for validating extension link config to function * Fixed ts errors. * Update packages/grafana-data/src/types/app.ts Co-authored-by: Levente Balogh <balogh.levente.hu@gmail.com> * Update packages/grafana-runtime/src/services/pluginExtensions/extensions.test.ts Co-authored-by: Levente Balogh <balogh.levente.hu@gmail.com> * refactor(extensions): rename limiter -> pluginPlacementCount * refactor(getpanelmenu): remove redundant continue statement --------- Co-authored-by: Levente Balogh <balogh.levente.hu@gmail.com> Co-authored-by: Marcus Andersson <marcus.andersson@grafana.com>	3 years ago

1 2

94 Commits (85abf2bebd59bf095d68faa217fac0fcaffe960a)