grafana

Commit Graph

Author	SHA1	Message	Date
Sofia Papagiannaki	d1dab5828d	Alerting: Update rule API to address folders by UID (#74600 ) * Change ruler API to expect the folder UID as namespace * Update example requests * Fix tests * Update swagger * Modify FIle field in /api/prometheus/grafana/api/v1/rules * Fix ruler export * Modify folder in responses to be formatted as <parent UID>/<title> * Add alerting test with nested folders * Apply suggestion from code review * Alerting: use folder UID instead of title in rule API (#77166) Co-authored-by: Sonia Aguilar <soniaaguilarpeiron@gmail.com> * Drop a few more latent uses of namespace_id * move getNamespaceKey to models package * switch GetAlertRulesForScheduling to use folder table * update GetAlertRulesForScheduling to return folder titles in format `parent_uid/title`. * fi tests * add tests for GetAlertRulesForScheduling when parent uid * fix integration tests after merge * fix test after merge * change format of the namespace to JSON array this is needed for forward compatibility, when we migrate to full paths * update EF code to decode nested folder --------- Co-authored-by: Yuri Tseretyan <yuriy.tseretyan@grafana.com> Co-authored-by: Virginia Cepeda <virginia.cepeda@grafana.com> Co-authored-by: Sonia Aguilar <soniaaguilarpeiron@gmail.com> Co-authored-by: Alex Weaver <weaver.alex.d@gmail.com> Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com>	1 year ago
Sonia Aguilar	1654df24da	Alerting: Fix reusing last url in tab when reopening a new tab in rule detail a… (#79801 ) Fix reusing last url in tab when reopening a new tab in rule detail action buttons	1 year ago
Gilles De Mey	e5227550c4	Alerting: Detail view v2 (#77795 )	1 year ago
Gilles De Mey	7dbbdc16a3	Alerting: useAbility hook for alert rules (#78231 )	2 years ago
Ben Sully	35b1e49024	Alerting: Add actions extension point to alert instances table view (#77900 ) This PR adds a new [extension point][] to each row of the alert instances table. This allows plugins to add actions to a dropdown menu in the rightmost column of the table. Those actions are passed the alert instance so can use it for contextual handling. See https://github.com/grafana/machine-learning/pull/3461 for an example of how this can be used (e.g. by Grafana Sift here).	2 years ago
Alex Khomenko	25779bb6e5	Stack: Use the component from grafana/ui (#77543 ) * grafana/ui: Move Stack out of unstable * grafana/ui: Replace imports * Replace the import from experimental * Cleanup * Remove invalid prop * Add flexGrow * Remove Stack used in Field * Remove import	2 years ago
Gilles De Mey	901a6bfa69	Alerting: Use correct URL for modify export (#77714 )	2 years ago
Gilles De Mey	3dac37380d	Alerting: Fix export with modifications URL when mounted on subpath (#77622 )	2 years ago
Konrad Lalik	4fc0294aab	Add logging prometheus and ruler rules totals (#76812 )	2 years ago
Ashley Harrison	5f2fd8935d	Spinner: Fix so that the `size` property is correctly applied (#77135 ) * correctly apply spinner sizes, refactor to have standard sizes * better prop definitions so constant values show in IDEs * 12 is xs, not sm	2 years ago
Gilles De Mey	390408b1ce	Alerting: Fix incorrect decoding for alert rules with % characters (#76148 ) * fixes incorrect decoding for alert rules with % characters * Patch history package to stop decoding path * Rename rule id extraction function, update tests * Fix patch file * Fix copyFrom parameter encoding * Fix conflict commit * Fix test --------- Co-authored-by: Konrad Lalik <konrad.lalik@grafana.com> Co-authored-by: Sonia Aguilar <soniaaguilarpeiron@gmail.com>	2 years ago
Konrad Lalik	42f4244026	Alerting: Add rules export on a folder level (#76016 )	2 years ago
Sonia Aguilar	fbbf9b1a8f	Alerting: Use new endpoints in the Modify Export (#75796 ) Co-authored-by: Konrad Lalik <konrad.lalik@grafana.com>	2 years ago
Jo	28c0fb1cfd	AccessControl: Remove legacy frontend AC checks (#76187 ) * remove legacy ac checks * fix RBAC disabled tests * add permissions for tests to work * fix unifiedalertstatesworker test	2 years ago
Virginia Cepeda	9076904173	Alerting: Show Insights only for cloud users (#75676 ) * Add functions to detect build edition and env * Prevent showing insights for OSS * Use common functions for Declare Incident button * Address review comments	2 years ago
Sonia Aguilar	169c5262a5	Alerting: Add Modify export feature for Grafana-managed alert rules (#75114 ) * Initial POC for modified rule expor * Add rule and group export options to modified export * Add feature toggle for modifier export * Rename GrafanaRuleDesigner to ModifyExportRuleForm to identify it easily as a rule form * Refactor naming and folder for RuleDesigner => ModifyExport * Don't render more action drop-down button when no more actions are allowed * Redirect cancel button to alert list view * Fix modify export page being reloaded correctly without errors * Fix test * Protect modify-export route when toggle-feature is not enabled * Fix css betterer error * Address pr review coments --------- Co-authored-by: Konrad Lalik <konrad.lalik@grafana.com>	2 years ago
Ashley Harrison	0c44a6f9bb	Chore: Improve typings 🧹 (#74599 ) * various type fixes * candlestick panel type fixes * few more fixes * some fixes * more :) * moar! * undo change to SilencesFilter * undo change to configureStore	2 years ago
Gilles De Mey	bd23d48660	Alerting: useAbilities hook (#72626 )	2 years ago
Gilles De Mey	1fa6623e1c	Alerting: Fix flakey test for rule group export (#74665 )	2 years ago
Konrad Lalik	e7a2c95586	Alerting: Add Grafana-managed groups and rules export (#74522 )	2 years ago
Sonia Aguilar	cad39b7397	Alerting: Revert "Alerting: Show annotations markers in TimeSeries panel when u… (#74576 ) Revert "Alerting: Show annotations markers in TimeSeries panel when using Loki as … (#72084)" This reverts commit `de6ef53c8a`.	2 years ago
Ieva	d46208b28a	Chore: remove legacy AC fallback from frontend access control checks (#74385 ) * don't use legacy AC fallback for frontend access control checks * extend tests * more test fixes * more test fixes * more test fixes * final test fix * team test fix * finally fix tests	2 years ago
Gilles De Mey	94dd17a936	Alerting: Adds additional pagination to several views (#74268 )	2 years ago
Virginia Cepeda	27fb922f9b	Alerting: Add new Recording Rule button when the list is empty (#73502 ) * Add button to create RR when there are no alerts * Remove unneeded import * Change cards to be shown vertically	2 years ago
Konrad Lalik	df3d10606d	Alerting: Optimize rule details page data fetching (#72977 )	2 years ago
Gilles De Mey	ddc3784213	Alerting: Fix "see graph button" for cloud rules (#72980 ) Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com> Co-authored-by: Giordano Ricci <me@giordanoricci.com>	2 years ago
Ashley Harrison	e0587dfb30	Chore: Replace deprecated usage of `shape.borderRadius()` (#72672 ) * properly mark borderRadius() as deprecated, replace borderRadius() with default * undo a couple of changes * use radius.pill in FilterPill	2 years ago
Sonia Aguilar	de6ef53c8a	Alerting: Show annotations markers in TimeSeries panel when using Loki as … (#72084 ) * WIP: Show annotations markers in TimeSeries panel when using Loki as alert state history * WIP changes * Fix converting log records to data frame for panel * Move fetching alert state history with Loki to the PannelQueryRunner to keep the panel flow * use dasboardUID and panelUID for requesting Loki ash * fix wrong prettier change * Only request loki ash when having alertstate * Use panelID as param in history query * Refactor: move getRuleHistoryRecordsForPanel and remove filtering code as is not used * Adress PR review comments * Add try catch for ash request * Add tests for updatePanelDataWithASHFromLoki method * Address PR review suggestions * review suggestion * Add test for logRecordsToDataFrameForPanel method * pr Review nit suggestion * Dont show toast messages from Loki request	2 years ago
jakuzure	b503434bd3	Alerting: Fix typo when no rules exist (#72250 )	2 years ago
Virginia Cepeda	5faf5e48ea	Alerting: Changes to evaluation group step (#71251 ) * Initial changes to evaluation group step * Add separate buttons for folder and eval group creation * Implement folder creation from a modal * Reset group upon folder creation * Implement creation of evaluation group in modal * Changes to evaluation group edit modal * Fix tests * Address review comments * Fix tests * Refactor to avoid passing AsyncRequestState as prop * Refactor to avoid passing AsyncRequestState as prop	2 years ago
Ashley Harrison	9852b24d61	Chore: Upgrade prettier to v3 (#71764 ) * Update dependency prettier to v3 (#71586) * Update dependency prettier to v3 * run prettier * ignore prettier update in legacy select scss * update command line arg --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com> * unplug prettier --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>	2 years ago
Ashley Harrison	5ca382c88a	Revert "Update dependency prettier to v3 (#71586 )" (#71755 ) This reverts commit `2e8cd1c021`.	2 years ago
renovate[bot]	2e8cd1c021	Update dependency prettier to v3 (#71586 ) * Update dependency prettier to v3 * run prettier * ignore prettier update in legacy select scss * update command line arg --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com>	2 years ago
Gilles De Mey	0be9658064	Alerting: Adds support for toggling common labels (#71497 )	2 years ago
Gilles De Mey	1945f2b64e	Alerting: Use new "Label" components for alert instance labels (#70997 )	2 years ago
Sonia Aguilar	00e9185b1a	Alerting: Add legend for mixed in Loki alert history and use highlight instead of scroll (#71131 ) * Add legend for mixed in Loki alert history * Highlight row in the log list while hovering in the timeline instead of srcolling into it * update some of the styles --------- Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com>	2 years ago
Alexander Weaver	f94fb765b5	Alerting: Add limit query parameter to Loki-based ASH api, drop default limit from 5000 to 1000, extend visible time range for new ASH UI (#70769 ) * Add limit query parameter * Drop copy paste comment * Extend history query limit to 30 days and 250 entries * Fix history log entries ordering * Update no history message, add empty history test --------- Co-authored-by: Konrad Lalik <konrad.lalik@grafana.com>	2 years ago
Gilles De Mey	dc7e967cd4	Alerting: Fixes clone url for instances hosted on sub path (#70543 )	2 years ago
Matias Chomicki	fd6836e326	Cloud rules: fix hardcoded conditional (#70387 )	2 years ago
Sonia Aguilar	9a252c763a	Alerting: Add notification policies preview in alert creation (#68839 ) * Add notification policies preview in alert rule form Co-authored-by: Konrad Lalik <konrad.lalik@grafana.com> * Refactor using new useGetPotentialInstances hook and apply some style changes * Add notification policy detail modal * Use backtesting api for simulating potential alert instances * Fix logic to travserse all the children from the root route * Split notification preview by alert manager * Add instance count to matching policy header and fix some styles * Move some logic to a new hook useGetAlertManagersSourceNames to make the code more clean * Fix some tests * Add initial test for NotificationPreview * Use button to preview potential instances * Add link to contact point details * Add route matching result details * Show AlertManager image in the routing preview list * Add tests setup, add single AM preview test * Handle no matchers and no labels use case * Update some style in collapse component and fix policy path in modal * Update modal styles * Update styles * Update collapse header styling * Normalize tree nodes should happen before findMatchingRoutes call * Fix findMatchingRoutes and findMatchingAlertGroups methods after reabasing * Move instances matching to the web worker code * Fix config fetching for vanilla prometheus AMs * Add tests * Add tests mocks * Fix tests after adding web worker * Display matching labels for each matching alert instance * Add minor css improvements * Revert changes added in Collapse component as we don't use it anymore * Move the route details modal to a separate file * Move NotificationRoute and preview hook into separate files * Fix Alertmanager preview tests * Fix tests * Move matcher code to a separate file, improve matcher mock * Add permissions control for contact point edit view link * Fix from and to for the temporal use of backtesting api * Fix tests, add lazy loading of the preview component Co-authored-by: Sonia Aguilar <soniaaguilarpeiron@gmail.com> * Fix preview test * Add onclick on the header div so it collapse and expands when clicking on it, and update styles to be consistent with the rest of tables * Adapt the code to the new rule testing endpoint definition * Fix tests * small changes after reviewing the final code * compute entire inherited tree before computing the routes map * Throw error in case of not having receiver in routesByIdMap and add test for the use case of inheriting receiver from parent to check UI throws no errors * Add list of labels in the policy route path that produces the policy matchers to match potential instances * Use color determined by the key, in label tags when hovering matchers in the policy tree * Remove labels in modal and handle empty string as receiver to inherit from parent as we do with undefined * Revert "Add list of labels in the policy route path that produces the policy matchers to match potential instances" This reverts commit `ee73ae9cf9`. * fix inheritance for computeInheritedTree * Fix message shown when preview has not been executed yet * First round for adressing PR review comments * Adress the rest of PR review commments * Update texts and rename id prop in NotificaitonStep to alertUid --------- Co-authored-by: Konrad Lalik <konrad.lalik@grafana.com> Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com>	2 years ago
Ashley Harrison	266751b96d	NestedFolders: stay in the modal whilst actions complete (#69730 ) * stay in the modal whilst actions complete * don't return anything here to fix types * ensure we're always resetting button state	2 years ago
Virginia Cepeda	e796063a1e	Alerting: Reorder new alert and export buttons (#68418 ) * Add component for rule creation and dropdown * Make each route type have a different path * Remove unneeded import * Fix tests * Rename CreateRuleButton to MoreActionRuleButtons * Remove Recording Rule option from new rule form * Use alerting and recording for path params on new rules * Fix tests * Only show new button if permissions are granted * Fix tests	2 years ago
Gilles De Mey	deb13ef611	Alerting: Add more context to delete modals (#69244 )	2 years ago
Gilles De Mey	7e924e0d74	Alerting: Smaller fixes for long namespace / group names (#69095 )	2 years ago
Torkel Ödegaard	debf04eb2c	Modals: Be more consistent with Modal cancel button styling (#68302 ) * Modals: Be more consistent with Modal cancel button styling * Update docs * Fix tests * fixing tests	2 years ago
Sonia Aguilar	49ff85ef54	Alerting: Fix action buttons label and placement in several views following standard and being consistent with the rest of the ui (#67799 ) * Fix action buttons label and placement in several views following standard and being consistent with the rest of the ui * Update public/app/features/alerting/unified/components/mute-timings/MuteTimingForm.tsx Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com> * Fix secondary buttons to not have outline --------- Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com>	2 years ago
Gilles De Mey	dafd202bb2	Alerting: Fix "show all instances" (#67833 )	2 years ago
Virginia Cepeda	471a03328b	Alerting: Allow to tab onto elements for a11y (#67684 ) * Make search popover be tabbed onto Co-Authored-By: Sonia Aguilar <33540275+soniaAguilarPeiron@users.noreply.github.com> * Allow tokens in rule description to be tabbed onto Co-Authored-By: Sonia Aguilar <33540275+soniaAguilarPeiron@users.noreply.github.com> --------- Co-authored-by: Sonia Aguilar <33540275+soniaAguilarPeiron@users.noreply.github.com>	2 years ago
Sonia Aguilar	64ee42d01e	Alerting: Add limits and move state and label matching filters to the BE (#66267 ) * WIP * Add instance totals to combined rule. Use totals to display instances stats in the UI * WIP * add global summaries, fix TS errors * fix useCombined test * fix test * use activeAt from rule when available * Fix NaN in global stats * Add no data total to global summary * Add totals recalculation for filtered rules * Fix instances totals, remove instances filtering from alert list view * Update tests * Fetch alerts considering filtering label matchers * WIP - Fetch alerts appending state filter to endpoint * Fix multiple values for state in request being applyied * fix test * Calculate hidden by for grafana managed alerts * Use INSTANCES_DISPLAY_LIMIT constant for limiting alert instances instead of 1 * Rename matchers parameter according to API changes * Fix calculating total number of grafana instances * Rename matcher prop after previous change * Display button to remove max instances limit * Change matcher query param to be an array of strings * Add test for paramsWithMatcherAndState method * Refactor matcher to be an string array to be consistent with state * Use matcher query string as matcher object type (encoded JSON) * Avoind encoding matcher parameters twice * fix tests * Enable toggle for the limit/show all button and restore limit and filters when we come back from custom view * Move getMatcherListFromString method to utils/alertmanager.ts * Fix limit toggle button being shown when it's not necessary * Use filteredTotals from be response to calculate hidden by count * Fix variables not being replaced correctly * Fix total shown to be all the instances filtered without limits * Adress some PR review comments * Move paramsWithMatcherAndState inside prometheusUrlBuilder method --------- Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com> Co-authored-by: Konrad Lalik <konrad.lalik@grafana.com> Co-authored-by: Virginia Cepeda <virginia.cepeda@grafana.com>	2 years ago
Konrad Lalik	91704cf7de	Alerting: Loki-based alert state history modal (#66595 ) * adds alertstatehistory backend config to grafanaBootData * add alertStateHistory api * show different ASH modal when using loki implementation * group log lines by instance (unique set of labels) Co-Authored-By: Konrad Lalik <konrad.lalik@grafana.com> * render log lines for each instance Co-Authored-By: Konrad Lalik <konrad.lalik@grafana.com> * Add visual improvements to the log record of state changes * Add values to log records * compute common labels and show unique labels * Add state changes visualization * fix common labels extraction * Code cleanup * Add timespan-based log record view * WIP * scroll to timestamp - poc * Use SortedVector for timestamp field * add conditional accessor for frames * update some of the log formats and styles * Timestamp-based visualization with scrolling * minor improvements * Split Loki's state history viewer into multiple files * Add memoization to prevent graph rerender on filter updates * make chart size shrink when fewer instances * style updates * show warning when instances are hidden * Add basic label-based filtering * Improve label-based filtering * Add regex validation * Improve no instances message when everything was filtered out * Update warning message * Move timeline viewer to a separate file, refactor handling timeline pointer changes * Remove unused component, add comments * Fix test snapshot, fix type error * adds tests for common.ts * Add tests for converting log records into data frames * Add basic component test, fix type guards * Use a constant for timeseries limit * Improve a11y, update component test * Memoize AlertStateTag, migrate from deprecated ArrayVector * Update public/app/features/alerting/unified/components/rules/state-history/common.ts * Move helper hook into a separate file. Add Search input component * Change the limit of visible time series on the timeline * Add LogRecordViewer perf improvements, refactor timeline cursor events tracking * Use callback to pass timeline refs * Add grouping tests for the log record viewer --------- Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com>	2 years ago

1 2 3 4 5

248 Commits (9e29c215c38290d2b7120343b76d9e8c1a0c81b0)