34 Commits (a8886ad5ec12cf080e7672bc70ba341dd003d005)

Author	SHA1	Message	Date
Stephanie Hingtgen	a8886ad5ec	Annotations: Use dashboard uids instead of dashboard ids (#106676)	2 weeks ago
Peter Štibraný	c4d3eb1cd0	Remove support for Google Spanner database. (#105846) ... * Remove support for Google Spanner database.	1 month ago
Peter Štibraný	e85acf047a	Remove use of dialect.LikeStr (#104460) ... * Fix TestIntegrationUpdatingProvisionionedDashboards* tests when running on Spanner by fixing case-insensitive search for dashboard title. * Fix use of case-insensitive LIKE when running on Spanner. * Fix use of LikeStr in anonstore. * Fix use of LikeStr in ngalert/store and org/orgimpl. * Fix use of LikeStr in queryhistory search. * Fix use of LikeStr in serviceaccounts. * Fix use of LikeStr in serviceaccounts. * Fix use of LikeStr in services/team. * Remove LikeStr method.	2 months ago
Mariell Hoversholm	757be6365a	CI: Bump golangci-lint to 2.0.2 (#103572)	3 months ago
Mariell Hoversholm	e1e1d3fd9f	Fix: Prints should always include new lines (#102795) ... * CI: Allow Bench conversion to fail We shouldn't mark PRs and commits as X if they fail to convert logs with Bench. * Fix: Prints should always include new lines * fix: remove unused import	3 months ago
Peter Štibraný	3d53968ecb	spanner-annotationsimpls-fixes (#102622) ... * Fix DELETE statements. * Reset sequence generator when truncating tables. * Quote "at", since it's a keyword in Spanner.	3 months ago
Yuri Tseretyan	bbeae46105	Alerting: Fix rule state history with annotations backend (#101174) ... * add alertUID to annotations API query parameter * update state history UI to fetch rule by UID --------- Signed-off-by: Yuri Tseretyan <yuriy.tseretyan@grafana.com>	4 months ago
Alexander Zobnin	bd1741653d	Annotations: Fix composite store read (#94158) ... * Annotations: Fix composite store read * Add test * check error	9 months ago
Alexander Zobnin	5e713673e1	Annotations: Optimize search by tags (#93547) ... * Annotations: Optimize search on large number of dashboards * refactor * fix batch size * Return early if no annotations found * revert go.mod * return nil in case of error * Move default limit to the API package * fix empty access control filter * Set default limit to 100 * optimize query when number of annotations is less than limit * Update pkg/services/annotations/annotationsimpl/annotations.go Co-authored-by: Ieva <ieva.vasiljeva@grafana.com> * remove limit from store since it's set in API * set default limit in Find method (do not break tests) * Only add limit to the query if it's set * use limit trick for all searches without dashboard filter * set default page if not provided --------- Co-authored-by: Ieva <ieva.vasiljeva@grafana.com>	9 months ago
Ryan McKinley	99d8025829	Chore: Move identity and errutil to apimachinery module (#89116)	1 year ago
William Wernert	af528d2f66	Alerting/Annotations: Prevent panics from composite store jobs from crashing Grafana (#83459) ... * Don't directly use pointer to json * Don't crash entire process if a store job panics * Add debug logs when failing to parse/handle Loki entries	1 year ago
Alexander Weaver	68d4e8a930	Annotations: Remove extraneous, debug log messages (#80670) ... * drop log messages * Revert timer * fix returns, no need to capture vars for log lines anymore	1 year ago
Alexander Weaver	81c45bfe44	Annotations: Split cleanup into separate queries and deletes to avoid deadlocks on MySQL (#80329) ... * Split subquery when cleaning annotations * update comment * Raise batch size, now that we pay attention to it * Iterate in batches * Separate cancellable batch implementation to allow for multi-statement callbacks, add overload for single-statement use * Use split-out utility in outer batching loop so it respects context cancellation * guard against empty queries * Use SQL parameters * Use same approach for tags * drop unused function * Work around parameter limit on sqlite for large batches * Bulk insert test data in DB * Refactor test to customise test data creation * Add test for catching SQLITE_MAX_VARIABLE_NUMBER limit * Turn annotation cleanup test to integration tests * lint --------- Co-authored-by: Sofia Papagiannaki <1632407+papagian@users.noreply.github.com>	1 year ago
William Wernert	62bdbe5b44	Annotations/Alerting: Add Loki historian store stub (#78363) ... * Add Loki historian store stub * Add composite store * Use composite store if Loki historian enabled * Split store interface into read/write * Make composite + historian stores read only * Use variadic constructor for composite * Modify Loki store enable logic * Use dskit.concurrency.ForEachJob for parallelism	2 years ago
Ieva	791881f910	RBAC: Change annotation filter to use dashboard based annotation scopes (#78635) ... change annotation filter to use dash based annotation scopes	2 years ago
William Wernert	1a53a716e9	Annotations: Lift parts of RBAC from xorm store into auth service (#76967) ... * [WIP] Lift RBAC from xorm store * Cleanup RBAC, fix tests * Use the scope type map as a map * Remove dependency on dashboard service * Make dashboards a map for constant time lookups (useful later) --- * Lift RBAC tests into a new file to test at service level * Add necessary access resource structs to xorm store tests * Move authorization into separate service * Pass features to searchstore.Builder * Sort imports * Code cleanup * Remove useless scope type check * Lift permission check into `Authorize()` * Use clearer language when checking scope types * Include dashboard permissions in test to ensure they're ignored * Switch to errutil * Cleanup sql.Cfg refs	2 years ago
Jo	c4874f97f8	Identity: Port snapshots and annotations to Requester (#76103) ... * Port snapshots to Requester * Port annotations to Requester	2 years ago
Ieva	6885b3d577	Chore: remove checks for whether RBAC is disabled (#73812) ... * remove checks for whether access control is disabled, as it is always enabled now * linting	2 years ago
Sofia Papagiannaki	2c26a02b82	Search v1: Remove unnecessary subqueries (#72388) ... * Add feature flag * Introduce interface and dummy implementation * Add tests for the new filter * accessControlDashboardPermissionFilterNoFolderSubquery implementation * join only if it's necessary * force ordering for tests * Temporarily enable new query for benchmarks	2 years ago
Emil Tullstedt	ab0a115372	Annotations: Improve updating annotation tags queries (#71201) ... Annotations: Improve annotation tag updates	2 years ago
Emil Tullstedt	56f52dc97e	Annotations: Fix database lock while updating annotations (#71199)	2 years ago
Sofia Papagiannaki	04370f92dc	Annotations: Improve get tags query performance (#66182) ... * Add benchmark * Add fix	2 years ago
Sofia Papagiannaki	988a120d6d	Search v1: Add support for inherited folder permissions if nested folders are enabled (#63275) ... * Add features dependency to SQLBuilder * Add features dependency to AccessControlDashboardPermissionFilter * Add test for folder inheritance * Dashboard permissions: Return recursive query * Recursive query for inherited folders * Modify search builder * Adjust db.SQLBuilder * Pass flag to SQLbuilder if CTEs are supported * Add support for mysql < 8.0 * Add benchmarking for search with nested folders * Set features to AlertStore * Update pkg/infra/db/sqlbuilder.go Co-authored-by: Ieva <ieva.vasiljeva@grafana.com> * Set features to LibraryElementService * SQLBuilder tests with nested folder flag set * Apply suggestion from code review Co-authored-by: IevaVasiljeva <ieva.vasiljeva@grafana.com> Co-authored-by: Emil Tullstedt <emil.tullstedt@grafana.com>	2 years ago
idafurjes	982939111b	Rename Id to ID for annotation models (#62886) ... * Rename Id to ID for annotation models * Add xorm tags * Rename Id to ID for API key models * Add xorm tags	2 years ago
Kristin Laemmert	e8b8a9e276	chore: move dashboard_acl models into dashboard service (#62151)	2 years ago
Yuri Tseretyan	d44de7f20a	Annotations: AddMany to not open session if nothing to save (#61117)	3 years ago
Alexander Weaver	1381fb6dfc	Annotations: Fix EpochEnd being zero for Alert-generated annotations (#60931) ... * Revert linter suggestion * Re-add nolint * Work in terms of pointer rather than copy * Add tests covering validation * Add comment	3 years ago
ying-jeanne	12c292fd44	[Bug] Fix annotations update/patch (#60385) ... * fix annotations update/patch * verify that when update doesn't contain data, we will not update data	3 years ago
Alexander Weaver	cc8c1380e2	Alerting: Persist annotations from multidimensional rules in batches (#56575) ... * Reduce piecemeal state fields * Read data directly off state instead of rule * Unify state and context into single struct * Expose contextual information to layer above setNextState * Work in terms of ContextualState and call historian in batches * Call annotations service in batches * Export format state and reason and remove workaround in unrelated test package * Add new method to annotation service for batch inserting * Fix loop variable aliasing bug caught by linter, didn't change behavior * Incl timerange on annotation tests * Insert one at a time if tags are present * Point to rule from ContextualState rather than copy fields * Build annotations and copy data prior to starting goroutine * Rename to StateTransition * Use new bulk-insert utility * Remove rule from StateTransition and pass in directly to historian * Simplify annotations logic since we have only one rule * Fix logs and context, nilcheck, simplify method name * Regenerate mock	3 years ago
Kristin Laemmert	05709ce411	chore: remove sqlstore & mockstore dependencies from (most) packages (#57087) ... * chore: add alias for InitTestDB and Session Adds an alias for the sqlstore InitTestDB and Session, and updates tests using these to reduce dependencies on the sqlstore.Store. * next pass of removing sqlstore imports * last little bit * remove mockstore where possible	3 years ago
Sofia Papagiannaki	d0e7765c6a	Annotation: Optionally allow storing longer annotation tags (#54754) ... * Annotation: Optionally allow longer annotation tags * Do not accept configuration lower than today's default (500) * Apply suggestion from code review	3 years ago
Sofia Papagiannaki	2f14575dd3	Chore: Move annotations cleanup to the annotations service (#55618)	3 years ago
ying-jeanne	7b4cea8151	Chore: StoreSplit tag service (#55453) ... * move tag service outside * fix dashboard * fix test * lint * fix linter * remove spew	3 years ago
Sofia Papagiannaki	754eea20b3	Chore: SQL store split for annotations (#55089) ... * Chore: SQL store split for annotations * Apply suggestion from code review	3 years ago
idafurjes	a14621fff6	Chore: Add user service method SetUsingOrg and GetSignedInUserWithCacheCtx (#53343) ... * Chore: Add user service method SetUsingOrg * Chore: Add user service method GetSignedInUserWithCacheCtx * Use method GetSignedInUserWithCacheCtx from user service * Fix lint after rebase * Fix lint * Fix lint error * roll back some changes * Roll back changes in api and middleware * Add xorm tags to SignedInUser ID fields	3 years ago
idafurjes	6afad51761	Move SignedInUser to user service and RoleType and Roles to org (#53445) ... * Move SignedInUser to user service and RoleType and Roles to org * Use go naming convention for roles * Fix some imports and leftovers * Fix ldap debug test * Fix lint * Fix lint 2 * Fix lint 3 * Fix type and not needed conversion * Clean up messages in api tests * Clean up api tests 2	3 years ago
Ieva	a5672758d8	Access control: further reduce access control feature toggle checks (#48171) ... * reduce the usage of access control flag further by removing it from SQL store methods * fixing tests * fix another test * linting * remove AC feature toggle use from API keys * remove unneeded function	3 years ago
Kat Yang	098563179b	Chore: Remove final x from sqlstore (#48086) ... * Chore: Remove final x from everywhere * Fix errors * Fix: fix lint and nil pointer err * Remove x from the sqlstore 🎉	3 years ago
Ieva	ef4c2672b3	Access control: SQL filtering for annotation listing (#47467) ... * pass in user to attribute scope resolver * add SQL filter to annotation listing * check annotation FGAC permissions before exposing them for commenting * remove the requirement to be able to list all annotations from annotation listing endpoint * adding tests for annotation listing * remove changes that got moved to a different PR * unused var * Update pkg/services/sqlstore/annotation.go Co-authored-by: Ezequiel Victorero <evictorero@gmail.com> * remove unneeded check * remove unneeded check * undo accidental change * undo accidental change * doc update * move tests * redo the approach for passing the user in for scope resolution * accidental change * cleanup * error handling Co-authored-by: Ezequiel Victorero <evictorero@gmail.com>	3 years ago
Kat Yang	90f2233ea9	Chore: Remove global database engine variable from annotation (#46940) ... * Chore: Remove global database engine variable from annotation * 💩	3 years ago
ying-jeanne	adc0cbf176	remove global variable in annotation (#46746) ... * remove global varaible in annotation * remove todo * replace intransaction with withdbtransaction * fix typo	3 years ago
Daniel Lee	93de61f690	fix for CWE-89 (#43407) ... The sqlOrArgs unpacking seems to confuse CodeQL. Trying something simpler	4 years ago
Hugo Häggmark	44c48ecebb	Chore: Replace util.DynMap with structs (#36332) ... * Chore: Replace util.DynMap * Chore: added comments	4 years ago
Hugo Häggmark	63f9231de1	Annotations: Adds tags endpoint (#36199) ... * Annotations: Adds tags endpoint * Chore: fixes sql statement * Refactor: adds count to the api * Chore: changes after PR comments * Refactor: changes after PR comments	4 years ago
Carl Bergquist	e1458391bb	API: Return 400 on invalid Annotation requests (#32429) ... Signed-off-by: bergquist <carl.bergquist@gmail.com>	4 years ago
Arve Knudsen	b5379c5335	Chore: Fix SQL related Go variable naming (#28887) ... * Chore: Fix variable naming Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	5 years ago
Arve Knudsen	7897c6b7d5	Chore: Fix staticcheck issues (#28854) ... * Chore: Fix issues reported by staticcheck Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> * Undo changes Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	5 years ago
Emil Hessman	9a241a2a4f	Chore: Fix flaky sqlstore annotation test (#28527)	5 years ago
Arve Knudsen	a5d9196a53	Chore/fix lint issues (#27704) ... * Chore: Fix linting issues Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	5 years ago
Arve Knudsen	41d432b5ae	Chore: Enable whitespace linter (#25903) ... Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	5 years ago