31 Commits (a8886ad5ec12cf080e7672bc70ba341dd003d005)

Author	SHA1	Message	Date
Stephanie Hingtgen	a8886ad5ec	Annotations: Use dashboard uids instead of dashboard ids (#106676)	2 weeks ago
Peter Štibraný	e85acf047a	Remove use of dialect.LikeStr (#104460) ... * Fix TestIntegrationUpdatingProvisionionedDashboards* tests when running on Spanner by fixing case-insensitive search for dashboard title. * Fix use of case-insensitive LIKE when running on Spanner. * Fix use of LikeStr in anonstore. * Fix use of LikeStr in ngalert/store and org/orgimpl. * Fix use of LikeStr in queryhistory search. * Fix use of LikeStr in serviceaccounts. * Fix use of LikeStr in serviceaccounts. * Fix use of LikeStr in services/team. * Remove LikeStr method.	2 months ago
Alexander Zobnin	bd1741653d	Annotations: Fix composite store read (#94158) ... * Annotations: Fix composite store read * Add test * check error	9 months ago
Jeff Levin	a21a232a8e	Revert read replica POC (#93551) ... * Revert "chore: add replDB to team service (#91799)" This reverts commit c6ae2d7999. * Revert "experiment: use read replica for Get and Find Dashboards (#91706)" This reverts commit 54177ca619. * Revert "QuotaService: refactor to use ReplDB for Get queries (#91333)" This reverts commit 299c142f6a. * Revert "refactor replCfg to look more like plugins/plugin config (#91142)" This reverts commit ac0b4bb34d. * Revert "chore (replstore): fix registration with multiple sql drivers, again (#90990)" This reverts commit daedb358dd. * Revert "Chore (sqlstore): add validation and testing for repl config (#90683)" This reverts commit af19f039b6. * Revert "ReplStore: Add support for round robin load balancing between multiple read replicas (#90530)" This reverts commit 27b52b1507. * Revert "DashboardStore: Use ReplDB and get dashboard quotas from the ReadReplica (#90235)" This reverts commit 8a6107cd35. * Revert "accesscontrol service read replica (#89963)" This reverts commit 77a4869fca. * Revert "Fix: add mapping for the new mysqlRepl driver (#89551)" This reverts commit ab5a079bcc. * Revert "fix: sql instrumentation dual registration error (#89508)" This reverts commit d988f5c3b0. * Revert "Experimental Feature Toggle: databaseReadReplica (#89232)" This reverts commit 50244ed4a1.	9 months ago
Kristin Laemmert	8a6107cd35	DashboardStore: Use ReplDB and get dashboard quotas from the ReadReplica (#90235) ... * Use ReplDB in dashboard store and update all fixtures - no other changes * just moving dashboard counts for now * find the missing test fixture	12 months ago
Serge Zaitsev	faa1244518	Chore: Replace sqlstore with db interface (#85366) ... * replace sqlstore with db interface in a few packages * remove from stats * remove sqlstore in admin test * remove sqlstore from api plugin tests * fix another createUser * remove sqlstore in publicdashboards * remove sqlstore from orgs * clean up orguser test * more clean up in sso * clean up service accounts * further cleanup * more cleanup in accesscontrol * last cleanup in accesscontrol * clean up teams * more removals * split cfg from db in testenv * few remaining fixes * fix test with bus * pass cfg for testing inside db as an option * set query retries when no opts provided * revert golden test data * rebase and rollback	1 year ago
Ieva	791881f910	RBAC: Change annotation filter to use dashboard based annotation scopes (#78635) ... change annotation filter to use dash based annotation scopes	2 years ago
William Wernert	1a53a716e9	Annotations: Lift parts of RBAC from xorm store into auth service (#76967) ... * [WIP] Lift RBAC from xorm store * Cleanup RBAC, fix tests * Use the scope type map as a map * Remove dependency on dashboard service * Make dashboards a map for constant time lookups (useful later) --- * Lift RBAC tests into a new file to test at service level * Add necessary access resource structs to xorm store tests * Move authorization into separate service * Pass features to searchstore.Builder * Sort imports * Code cleanup * Remove useless scope type check * Lift permission check into `Authorize()` * Use clearer language when checking scope types * Include dashboard permissions in test to ensure they're ignored * Switch to errutil * Cleanup sql.Cfg refs	2 years ago
Ryan McKinley	3509a5abb9	FeatureFlags: Cleanup usage of cfg.IsFeatureToggleEnabled (#78014)	2 years ago
Ryan McKinley	025b2f3011	Chore: use any rather than interface{} (#74066)	2 years ago
Sofia Papagiannaki	2c26a02b82	Search v1: Remove unnecessary subqueries (#72388) ... * Add feature flag * Introduce interface and dummy implementation * Add tests for the new filter * accessControlDashboardPermissionFilterNoFolderSubquery implementation * join only if it's necessary * force ordering for tests * Temporarily enable new query for benchmarks	2 years ago
Emil Tullstedt	56f52dc97e	Annotations: Fix database lock while updating annotations (#71199)	2 years ago
Sofia Papagiannaki	04370f92dc	Annotations: Improve get tags query performance (#66182) ... * Add benchmark * Add fix	2 years ago
Sofia Papagiannaki	988a120d6d	Search v1: Add support for inherited folder permissions if nested folders are enabled (#63275) ... * Add features dependency to SQLBuilder * Add features dependency to AccessControlDashboardPermissionFilter * Add test for folder inheritance * Dashboard permissions: Return recursive query * Recursive query for inherited folders * Modify search builder * Adjust db.SQLBuilder * Pass flag to SQLbuilder if CTEs are supported * Add support for mysql < 8.0 * Add benchmarking for search with nested folders * Set features to AlertStore * Update pkg/infra/db/sqlbuilder.go Co-authored-by: Ieva <ieva.vasiljeva@grafana.com> * Set features to LibraryElementService * SQLBuilder tests with nested folder flag set * Apply suggestion from code review Co-authored-by: IevaVasiljeva <ieva.vasiljeva@grafana.com> Co-authored-by: Emil Tullstedt <emil.tullstedt@grafana.com>	2 years ago
idafurjes	982939111b	Rename Id to ID for annotation models (#62886) ... * Rename Id to ID for annotation models * Add xorm tags * Rename Id to ID for API key models * Add xorm tags	2 years ago
Serge Zaitsev	bc2813ef06	Chore: Fix goimports grouping in pkg/services (#62420) ... * fix goimports * fix goimports order	2 years ago
idafurjes	7c2522c477	Chore: Move dashboard models to dashboard pkg (#61458) ... * Copy dashboard models to dashboard pkg * Use some models from current pkg instead of models * Adjust api pkg * Adjust pkg services * Fix lint	2 years ago
Alexander Weaver	1381fb6dfc	Annotations: Fix EpochEnd being zero for Alert-generated annotations (#60931) ... * Revert linter suggestion * Re-add nolint * Work in terms of pointer rather than copy * Add tests covering validation * Add comment	3 years ago
ying-jeanne	12c292fd44	[Bug] Fix annotations update/patch (#60385) ... * fix annotations update/patch * verify that when update doesn't contain data, we will not update data	3 years ago
Sofia Papagiannaki	9855e74b92	Chore: Refactor quota service (#58643) ... Chore: Refactor quota service (#57586) * Chore: refactore quota service * Apply suggestions from code review	3 years ago
Sofia Papagiannaki	96cdf77995	Revert "Chore: Refactor quota service (#57586)" (#58394) ... This reverts commit 326ea86a57.	3 years ago
Sofia Papagiannaki	326ea86a57	Chore: Refactor quota service (#57586) ... * Chore: refactore quota service * Apply suggestions from code review	3 years ago
Alexander Weaver	cc8c1380e2	Alerting: Persist annotations from multidimensional rules in batches (#56575) ... * Reduce piecemeal state fields * Read data directly off state instead of rule * Unify state and context into single struct * Expose contextual information to layer above setNextState * Work in terms of ContextualState and call historian in batches * Call annotations service in batches * Export format state and reason and remove workaround in unrelated test package * Add new method to annotation service for batch inserting * Fix loop variable aliasing bug caught by linter, didn't change behavior * Incl timerange on annotation tests * Insert one at a time if tags are present * Point to rule from ContextualState rather than copy fields * Build annotations and copy data prior to starting goroutine * Rename to StateTransition * Use new bulk-insert utility * Remove rule from StateTransition and pass in directly to historian * Simplify annotations logic since we have only one rule * Fix logs and context, nilcheck, simplify method name * Regenerate mock	3 years ago
Karl Persson	7386f8652c	RBAC: Improve performance of dashboard filter query (#56813) ... * RBAC: Move UserRolesFilter to domain package * Dashboard Permissions: Rewrite rbac filter to check access in sql * RBAC: Add break when wildcard is found * RBAC: Add tests for dashboard filter * RBAC: Update tests * RBAC: Cover more test cases Co-authored-by: Ieva <ieva.vasiljeva@grafana.com>	3 years ago
Kristin Laemmert	05709ce411	chore: remove sqlstore & mockstore dependencies from (most) packages (#57087) ... * chore: add alias for InitTestDB and Session Adds an alias for the sqlstore InitTestDB and Session, and updates tests using these to reduce dependencies on the sqlstore.Store. * next pass of removing sqlstore imports * last little bit * remove mockstore where possible	3 years ago
Kristin Laemmert	c61b5e85b4	chore: replace sqlstore.Store with db.DB (#57010) ... * chore: replace sqlstore.SQLStore with db.DB * more post-sqlstore.SQLStore cleanup	3 years ago
ying-jeanne	2472777ce2	Chore: implement sqlx into tag service (#55908) ... * add sqlx store to tag service * add sqlx into tag service * fix test * change to camal cases * change in xorm camal case	3 years ago
Sofia Papagiannaki	d0e7765c6a	Annotation: Optionally allow storing longer annotation tags (#54754) ... * Annotation: Optionally allow longer annotation tags * Do not accept configuration lower than today's default (500) * Apply suggestion from code review	3 years ago
Sofia Papagiannaki	2f14575dd3	Chore: Move annotations cleanup to the annotations service (#55618)	3 years ago
ying-jeanne	7b4cea8151	Chore: StoreSplit tag service (#55453) ... * move tag service outside * fix dashboard * fix test * lint * fix linter * remove spew	3 years ago
Sofia Papagiannaki	754eea20b3	Chore: SQL store split for annotations (#55089) ... * Chore: SQL store split for annotations * Apply suggestion from code review	3 years ago
idafurjes	a14621fff6	Chore: Add user service method SetUsingOrg and GetSignedInUserWithCacheCtx (#53343) ... * Chore: Add user service method SetUsingOrg * Chore: Add user service method GetSignedInUserWithCacheCtx * Use method GetSignedInUserWithCacheCtx from user service * Fix lint after rebase * Fix lint * Fix lint error * roll back some changes * Roll back changes in api and middleware * Add xorm tags to SignedInUser ID fields	3 years ago
idafurjes	6afad51761	Move SignedInUser to user service and RoleType and Roles to org (#53445) ... * Move SignedInUser to user service and RoleType and Roles to org * Use go naming convention for roles * Fix some imports and leftovers * Fix ldap debug test * Fix lint * Fix lint 2 * Fix lint 3 * Fix type and not needed conversion * Clean up messages in api tests * Clean up api tests 2	3 years ago
Alexander Emelin	e791a4e576	Search: Move entity events to transaction (#52394)	3 years ago
Kat Yang	bd35e6917a	Chore: Exclude integration tests from running on test-backend step (#50359) ... * Chore: Exclude integration tests from running on test-backend step * Remove -v from go test command * Add check to skip integration tests before each integration test * Try to restart pipeline * Retrying to make pipeline run	3 years ago
Kat Yang	c63ebc887b	Chore: Run integration tests without grabpl (#49448) ... * Chore: Run integration tests without grabpl * Add new step for integration tests in lib.star * Remove old integration test step from lib.star * Change drone signature * Fix: Edit starlark integration step to not affect enterprise * Remove all build tags & rename starlark integration test step * Resync .drone.yml with .drone.star * Fix lint errors * Fix lint errors * Fix lint errors * Fix more lint errors * Fix another lint error * Rename integration test step * Fix last lint error * Recomment enterprise step * Remove comment from Makefile Co-authored-by: Ida Furjesova <ida.furjesova@grafana.com>	3 years ago
Kat Yang	50c2b4682a	Chore: Rename integration tests (#49438) ... * Chore: Rename integration tests * Remove one Integration Co-authored-by: Ida Furjesova <ida.furjesova@grafana.com>	3 years ago
Ieva	f256f625d8	AccessControl: Enable RBAC by default (#48813) ... * Add RBAC section to settings * Default to RBAC enabled settings to true * Update tests to respect RBAC Co-authored-by: Karl Persson <kalle.persson@grafana.com>	3 years ago
Ieva	a5672758d8	Access control: further reduce access control feature toggle checks (#48171) ... * reduce the usage of access control flag further by removing it from SQL store methods * fixing tests * fix another test * linting * remove AC feature toggle use from API keys * remove unneeded function	3 years ago
Karl Persson	2738d1c557	Access Control: Move dashboard actions and create scope provider (#48618) ... * Move dashboard actions and create scope provider	3 years ago
Vardan Torosyan	a0553de8dd	Rename FGAC to RBAC in the codebase (#48051)	3 years ago
Ieva	ef4c2672b3	Access control: SQL filtering for annotation listing (#47467) ... * pass in user to attribute scope resolver * add SQL filter to annotation listing * check annotation FGAC permissions before exposing them for commenting * remove the requirement to be able to list all annotations from annotation listing endpoint * adding tests for annotation listing * remove changes that got moved to a different PR * unused var * Update pkg/services/sqlstore/annotation.go Co-authored-by: Ezequiel Victorero <evictorero@gmail.com> * remove unneeded check * remove unneeded check * undo accidental change * undo accidental change * doc update * move tests * redo the approach for passing the user in for scope resolution * accidental change * cleanup * error handling Co-authored-by: Ezequiel Victorero <evictorero@gmail.com>	3 years ago
Kat Yang	e6726681a9	Chore: Remove x from annotation test (#46935)	3 years ago
Kat Yang	90f2233ea9	Chore: Remove global database engine variable from annotation (#46940) ... * Chore: Remove global database engine variable from annotation * 💩	3 years ago
ying-jeanne	adc0cbf176	remove global variable in annotation (#46746) ... * remove global varaible in annotation * remove todo * replace intransaction with withdbtransaction * fix typo	3 years ago
Ezequiel Victorero	c717320942	Adding FGAC annotations validation for creation and deletion (#46736) ... Access Control: Adding FGAC annotations validation for creation and deletion Co-authored-by: IevaVasiljeva <ieva.vasiljeva@grafana.com>	3 years ago
Daniel Lee	93de61f690	fix for CWE-89 (#43407) ... The sqlOrArgs unpacking seems to confuse CodeQL. Trying something simpler	4 years ago
Serge Zaitsev	643c7fa0cb	Chore: update all +build statements (#38782)	4 years ago
Hugo Häggmark	63f9231de1	Annotations: Adds tags endpoint (#36199) ... * Annotations: Adds tags endpoint * Chore: fixes sql statement * Refactor: adds count to the api * Chore: changes after PR comments * Refactor: changes after PR comments	4 years ago
Arve Knudsen	b5379c5335	Chore: Fix SQL related Go variable naming (#28887) ... * Chore: Fix variable naming Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	5 years ago