147 Commits (a9873db0f94dea418511ecc953bc3d304ab95e3f)

Author	SHA1	Message	Date
sam boyer	78f0340031	plugindef: Move pluginmeta out of coremodels as standalone thema lineage (#56765) ... * Get pluginmeta mostly moved over to pkg/plugins/plugindef * Remove dead func * Fix up pfs, use sync.Once in plugindef * Update to latest thema * Chase Endec->Codec conversion in Thema * Comments on slash header gen; use ToSlash * Also generate JSON schema for plugindef * Generate JSON Schema as well * Fix slot loading from kindsys cue decls * Remove unused vars * skip generating plugin.schema.json for now Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com>	3 years ago
Gabriel MABILLE	d999b5bda0	RBAC: remove redundant role name field from plugin role registrations (#58166) ... * RBAC: Remove name from role registration * Inline accesscontrol service * test fix * use fmt Co-Authored-By: marefr <marcus.efraimsson@gmail.com> Co-authored-by: marefr <marcus.efraimsson@gmail.com>	3 years ago
Gabriel MABILLE	30fae33f66	RBAC: Allow role registration for plugins (#57387) ... * Picking role registration from OnCall POC branch * Fix test * Remove include actions from this PR * Removing unused permission * Adding test to DeclarePluginRoles * Add testcase to RegisterFixed role * Additional test case * Adding tests to validate plugins roles * Add test to plugin loader * Nit. * Scuemata validation * Changing the design to decouple accesscontrol from plugin management Co-authored-by: Kalle Persson <kalle.persson@grafana.com> * Fixing tests Co-authored-by: Jguer <joao.guerreiro@grafana.com> * Add missing files Co-authored-by: Jguer <joao.guerreiro@grafana.com> * Remove feature toggle check from loader * Remove feature toggleimport * Feedback Co-Authored-By: marefr <marcus.efraimsson@gmail.com> * Fix test' * Make plugins.RoleRegistry interface typed * Remove comment question * No need for json tags anymore * Nit. log * Adding the schema validation * Remove group to take plugin Name instead * Revert sqlstore -> db * Nit. * Nit. on tests Co-authored-by: ievaVasiljeva <ieva.vasiljeva@grafana.com> * Update pkg/services/accesscontrol/plugins.go Co-authored-by: Ieva <ieva.vasiljeva@grafana.com> * Log message Co-Authored-By: marefr <marcus.efraimsson@gmail.com> * Log message Co-Authored-By: marefr <marcus.efraimsson@gmail.com> * Remove unecessary method. Update test name. Co-authored-by: ievaVasiljeva <ieva.vasiljeva@grafana.com> * Fix linting * Update cue descriptions * Fix test Co-authored-by: Kalle Persson <kalle.persson@grafana.com> Co-authored-by: Jguer <joao.guerreiro@grafana.com> Co-authored-by: marefr <marcus.efraimsson@gmail.com> Co-authored-by: ievaVasiljeva <ieva.vasiljeva@grafana.com>	3 years ago
Dan Cech	9ea6a43089	Build: clean up and document integration test convention (#58170) ... * clean up and document integration test convention * clarify integration test conventions * clean up integration tests that don't follow convention * mark testIntegration* functions as helpers to avoid confusion	3 years ago
Giuseppe Guerra	7996a1c8ad	Chore: Update grafana-plugin-sdk-go to v0.142.0 (#58115) ... * Chore: Update grafana-plugin-sdk-go to v0.142.0 * Update tests and golden files for 207 status code * Chore: Move update flag definition at the top in response_parser_test.go * retrigger Co-authored-by: Will Browne <will.browne@grafana.com>	3 years ago
Carl Bergquist	06705a49e2	Instrumentation: Log plugin and datasource info for each plugin request. (#54769) ... Signed-off-by: bergquist <carl.bergquist@gmail.com>	3 years ago
Andrej Ocenas	0845ac2f53	Profiling: Add Phlare and Parca datasources (#57809) ... * Add phlare datasource * Rename * Add parca * Add self field to parca * Make sure phlare works with add to dashboard flow * Add profiling category and hide behind feature flag * Update description and logos * Update phlare icon * Cleanup logging * Clean up logging * Fix for shift+enter * onRunQuery to set label * Update type naming * Fix lint * Fix test and quality issues Co-authored-by: Joey Tawadrous <joey.tawadrous@grafana.com>	3 years ago
Will Browne	9f77bd4728	Plugins: Use public store instead of internal registry (#57631) ... * Plugins: Use public store instead of internal registry * update comments * fix import * fix test	3 years ago
Marcus Efraimsson	6f8fcae01b	[main] Plugin fixes (#57399) ... * Plugins: Remove support for V1 manifests * Plugins: Make proxy endpoints not leak sensitive HTTP headers * Security: Fix do not forward login cookie in outgoing requests (cherry picked from commit 4539c33fce) Co-authored-by: Will Browne <wbrowne@users.noreply.github.com>	3 years ago
Kristin Laemmert	05709ce411	chore: remove sqlstore & mockstore dependencies from (most) packages (#57087) ... * chore: add alias for InitTestDB and Session Adds an alias for the sqlstore InitTestDB and Session, and updates tests using these to reduce dependencies on the sqlstore.Store. * next pass of removing sqlstore imports * last little bit * remove mockstore where possible	3 years ago
Artur Wierzbicki	bf264d2f76	Query library: `requiresDevMode` dummy backend (#56466) ... * query library - dummy backend * fix tests * dont explicitly marshall backend dataresponse * skip integration tests * null check for tests * added query library to codeowners * null check for tests * lint	3 years ago
Joey Tawadrous	74c809f544	Plugins: Introduce new Flame graph panel (#56376) ... * Flamegraph * Updated flame graph width/height values * Fix top table rendering issue * Add feature toggle for flamegraph in explore * Update tests * Hide flamegraph from dash panel viz list if feature toggle not enabled * Show table if no flameGraphFrames * Add flame graph to testdata ds * Minor improvement	3 years ago
Will Browne	1038ac7308	DataSources: Remove unused cfg from core Grafana data source (#56188) ... * remove unused cfg from grafana ds * fix test	3 years ago
Will Browne	4087ad413f	re-use fake trace + feature toggles (#56186)	3 years ago
Torkel Ödegaard	e31cb93ec0	NavTree: Make it possible to configure where in nav tree plugins live (#55484) ... * NewIA: Plugin nav config * progress * Progress * Things are working * Add monitoring node * Add alerts and incidents * added experiment with standalone page * Refactoring by adding a type for navtree root * First test working * More tests * more tests * Progress on richer config and sorting * Sort weight working * Path config * Improving logic for not including admin or cfg nodes, making it the last step so that enterprise can add admin nodes without having to worry about the section not existing * fixed index routes * removed file * Fixes * Fixing tests * Fixing more tests and adding support for weight config * Updates * Remove unused fake * More fixes * Minor tweak * Minor fix * Can now control position using sortweight even when existing items have no sortweight * Added tests for frontend standalone page logic * more tests * Remove unused fake and fixed lint issue * Moving reading settings to navtree impl package * remove nav_id setting prefix * Remove old test file * Fix trailing newline * Fixed bug with adding nil node * fixing lint issue * remove some code we have to rethink * move read settings to PrivideService and switch to util.SplitString	3 years ago
Kristin Laemmert	701f6d5436	UserService: use the UserService instead of calling sqlstore directly (#55745) ... * UserService: update callers to use the UserService instead of calling sqlstore directly There is one major change hiding in this PR. UserService.Delete originally called a number of services to delete user-related records. I moved everything except the actual call to the user table, and moved those into the API. This was done to avoid dependencies cycles; many of our services depend on the user service, so the user service itself should have as few dependencies as possible.	3 years ago
Will Browne	d0d8544ded	Plugins: Create single point of entry for adding / removing plugins (#55463) ... * split out plugin manager * remove whitespace * fix tests * split up tests * updating naming conventions * simplify manager * tidy * explorations * fix build * tidy * fix tests * add logger helper * pass the tests * tidying * fix tests * tidy and re-add test * store depends on loader * enrich tests * fix test * undo gomod changes	3 years ago
Artur Wierzbicki	03af63d52e	SearchV2: add tracing to background jobs (#55250) ... * searchv2: add tracing to background jobs * searchv2: lint * searchv2: lint * searchv2: fix context passing * searchv2: add init org index span * searchv2: add traceid to logs * searchv2: add db count to logs	3 years ago
idafurjes	7ce7c9b64c	Chore: Move SearchOrgs to org service (#55416) ... * Chore: Move SearchOrgs to org service * Fix lint * Fix lint 2	3 years ago
Will Browne	cd7a464f7e	Plugins: Ensure plugin uninstall success for "pre-installed" community plugins (#55322) ... * track pre-installed external plugins in store * fix tests	3 years ago
Will Browne	29327cbba2	Plugins: Use error plane for api/ds/query (#54750) ... * plugin client returns error base * fix api test * add plugin client test * add fallback err * fix linting * wip * replace bad query * template is an error * failing test of templated error * add one test passing * fix failing test * move test * rename ErrBadQuery to ErrQueryValidationFailure * tidy diff * Change to one error per specific error kind * last err + fix test * fix imports * more tests * keep req vars together Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com>	3 years ago
Will Browne	0571d98bba	[WIP] Plugins: Introduce Plugins specific config (#54854)	3 years ago
Will Browne	15756ecf86	remove unused cfg (#54770)	3 years ago
Will Browne	ecdcafb258	manager exposes renderer + secrets manager (#54629)	3 years ago
Will Browne	43987e7f8c	Plugins: Fix plugin registered startup log line (#54634) ... * fix plugin registered log * remove stale test	3 years ago
Ryan McKinley	55fe1506ba	Plugins: unlock on plugin startup failure (#54555)	3 years ago
Will Browne	4a707e2a88	Plugins: Split plugin manager into smaller components (#54384) ... * split out plugin manager * remove whitespace * fix tests * split up tests * updating naming conventions * simplify manager * tidy * add more fakes * testing time * add query verif to int test * renaming * add process tests * tidy up manager tests * add extra case to int test * add more coverage to store and process tests * remove comment * fix capatilization * init on provide * remove addfromsource from API	3 years ago
Will Browne	26dfdd5af3	Plugins: Refactor plugin download/installation (#43046) ... * installer -> repo * add semver format checking * add plugin callbacks in test * remove newline * post install only scans new directories * remove unused stuff * everything in own package * add missing cli params * make grafana version part of the API * resolve conflicts * tidy up logger * fix cli and tidy log statements * rename log package * update struct name * fix linter issue * fs -> filestore * reorder imports * alias import * fix test * fix test * inline var * revert jsonc file * make repo dep of manager * actually inject the thing * accept all args for compatability checks * accept compat from store * pass os + arch vals * don't inject fs * tidy up * tidy up * merge with main and tidy fs storage * fix test * fix packages * fix comment + field name * update fs naming * fixed wire * remove unused func * fix mocks * fix storage test * renaming * fix log line * fix test * re-order field * tidying * add test for update with same version * fix wire for CLI * remove use of ioutil * don't pass field * small tidy * ignore code scanning warn * fix testdata link * update lgtm code	3 years ago
sam boyer	4d433084a5	plugins: New static scanner and validator, with Thema slot support (#53754) ... * coremodels: Convert plugin-metadata schema to a coremodel * Newer cuetsy; try quoting field name * Add slot definitions * Start sketching out pfs package * Rerun codegen with fixes, new cuetsy * Catch up dashboard with new cuetsy * Update to go1.18 * Use new vmuxers in thema * Add slot system in Go * Draft finished implementation of pfs * Collapse slot pkg into coremodel dir; add PluginInfo * Add the mux type on top of kernel * Refactor plugin generator for extensibility * Change models.cue package, numerous debugs * Bring new output to parity with old * Remove old plugin generation logic * Misc tweaking * Reintroduce generation of shared schemas * Drop back to go1.17 * Add globbing to tsconfig exclude * Introduce pfs test on existing testdata * Make most existing testdata tests pass with pfs * coremodels: Convert plugin-metadata schema to a coremodel * Newer cuetsy; try quoting field name * Add APIType control concept, regen pluginmeta * Use proper numeric types for schema fields * Make pluginmeta schema follow Go type breakdown * More decomposition into distinct types * Add test case for no plugin.json file * Fix missing ref to #Dependencies * Remove generated TS for pluginmeta * Update dependencies, rearrange go.mod * Regenerate without Model prefix * Use updated thema loader; this is now runnable * Skip app plugin with weird include * Make plugin tree extractor reusable * Split out slot lineage load/validate logic * Add myriad tests for new plugin validation failures * Add test for zip fixtures * One last run of codegen * Proper delinting * Ensure validation order is deterministic * Let there actually be sorting * Undo reliance on builtIn field (#54009) * undo builtIn reliance * fix tests Co-authored-by: Will Browne <wbrowne@users.noreply.github.com>	3 years ago
Jo	ca72cd570e	Remove ioutil.ReadDir from usage (#53550) ... * add depguard rule for ioutil * replace ioutil.ReadDir with os.ReadDir * use legacy option in depguard supported in golangci-lint v1.40 * replace ioutil.ReadDir with os.ReadDir * return error for file info	3 years ago
Jo	062d255124	Handle ioutil deprecations (#53526) ... * replace ioutil.ReadFile -> os.ReadFile * replace ioutil.ReadAll -> io.ReadAll * replace ioutil.TempFile -> os.CreateTemp * replace ioutil.NopCloser -> io.NopCloser * replace ioutil.WriteFile -> os.WriteFile * replace ioutil.TempDir -> os.MkdirTemp * replace ioutil.Discard -> io.Discard	3 years ago
idafurjes	6afad51761	Move SignedInUser to user service and RoleType and Roles to org (#53445) ... * Move SignedInUser to user service and RoleType and Roles to org * Use go naming convention for roles * Fix some imports and leftovers * Fix ldap debug test * Fix lint * Fix lint 2 * Fix lint 3 * Fix type and not needed conversion * Clean up messages in api tests * Clean up api tests 2	3 years ago
Will Browne	6d066a7aa8	Plugins: Add validation for plugin manifest (#52787) ... * add validation for plugin manifest * no more semver checking * undo go.mod changes * undo go.mod changes * only validate v2 fields where necessary * remove manifest version field check	4 years ago
Will Browne	843ff932b7	Plugins: Add signature wildcard globbing for dedicated private plugin type (#52163) ... * it's glob time * add more tests * fix warn log * support new sig type	4 years ago
Will Browne	5d052be6ff	Plugins: Always validate root URL if specified in signature manfiest (#52332) ... * always validate root URL if specified in signature * tidy imports	4 years ago
Gabriel MABILLE	5975c4bc6d	RBAC: Allow app plugins access restriction (#51524) ... * RBAC: Allow app plugins restriction Co-authored-by: Kalle Persson <kalle.persson@grafana.com> * Fix tests * Imports * WIP * Adding RBAC to AppPluginsRoutes * Switching middleware order * Restrict access to resources * Nit * Cosmetic changes * Fix fallback * Moving declaration to HttpServer Co-Authored-By: marefr <marcus.efraimsson@gmail.com> Co-authored-by: Kalle Persson <kalle.persson@grafana.com> Co-authored-by: marefr <marcus.efraimsson@gmail.com>	4 years ago
Will Browne	0b40c8e51e	Plugins: Add missing asserts for Plugin Errors field (#51702) ... * make sure to check plugin errors * remove unused test	4 years ago
Marcus Efraimsson	04df634ef5	Plugins: Improved handling of symlinks (#51324) ... Improves how we handle symlinks in plugin management.	4 years ago
Ryan McKinley	dd5a3b7747	Heatmap: Replace the heatmap panel with new implementation (#50229)	4 years ago
Marcus Efraimsson	b47ec36d0d	CLI: Allow relative symlinks in zip archives when installing plugins (#50537) ... Earlier we only allowed symlinks in plugins starting with grafana- in zip archives when installing plugins using the grafana-cli. This changes so that symlinks in zip archives containing relative links to files in the zip archive are always allowed when installing plugins. The reasoning behind this is that Grafana per default doesn't load a plugin that has an invalid plugin signature meaning that any symlink must be included in the plugin signature manifest. Co-authored-by: Will Browne <will.browne@grafana.com> Co-authored-by: Will Browne <wbrowne@users.noreply.github.com>	4 years ago
Gábor Farkas	8fd9cb4854	loki: add feature-toggle check to live-mode (#49012)	4 years ago
Michael Mandrus	f376c33903	WIP: Add private Secret Manager Plugins support to plugin platform (#49544) ... * Add protobuf config and generated code, and client wrapper * wire up loading of secretsmanager plugin, using renderer plugin as a model * update kvstore provider to check if we should use the grpc plugin. return false always in OSS * add OSS remote plugin check * refactor wire gen file * log which secrets manager is being used * Fix argument types for remote checker * Turns out if err != nil, then the result is always nil. Return empty values if there is an error. * remove duplicate import * Update pkg/services/secrets/kvstore/kvstore.go Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com> * Update pkg/services/secrets/kvstore/kvstore.go Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com> * refactor RemotePluginCheck interface to just return the Plugin client directly * rename struct to something less silly * Update pkg/plugins/backendplugin/secretsmanagerplugin/secretsmanager.proto Co-authored-by: Will Browne <wbrowne@users.noreply.github.com> Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com> Co-authored-by: Will Browne <wbrowne@users.noreply.github.com>	4 years ago
Will Browne	f7cce28cdf	Plugins: Separate manager read/write components (#50313) ... * separate manager read/write * guarantee consistency in test	4 years ago
Kat Yang	31630edf0c	Chore: Remove Wrapf (#50128) ... * Chore: Remove Wrapf * Remove all Wrapf refs * Remove last Wrapf ref * Fix lint errors * Remove Wrap and Wrapf definitions * Remove unnecessary colon	4 years ago
Will Browne	7536647ab6	Plugins: Introduce Plugin Registry (#47200) ... * introduce registry write/read separation * internal + external registries * fix tests * fixup * rename * move interfaces * back to plugins.Store * fix registry name * remove context.TODOs * remove some ctx for now * tidy * remove dupe logic * update naming * move from manager.go to store * amend logger name * new store writer svc * restrict changes * more simplifying * move interfaces around * remove unused * fix linter * tidy * add registry test * fix tests * revert testdata changes * revert testdata changes #1 * revert testdata changes #2 * revert testdata changes #3 * revert testdata changes #4 * revert testdata changes #5 * revert testdata changes * fixup testdata * remove unused log * update naming in test * adjust ctx in test	4 years ago
Kat Yang	3c3039f5b3	Chore: Remove Wrap (#50048) ... * Chore: Remove Wrap and Wrapf * Fix: Add error check	4 years ago
Will Browne	4fae0f49d7	tidy up (#49720)	4 years ago
Sergey Kostrukov	7251115457	Settings: Use Grafana Azure SDK to pass Azure env vars for external plugins (#48954) ... * Azure env vars for plugins via Grafana Azure SDK * Remove tests	4 years ago
Emil Tullstedt	51ff2b8c58	Logging: Unify logging fakes (#48822)	4 years ago
Joey Tawadrous	09634b518c	Traces Panel: Add new Traces Panel visualization (#47534) ... * Panel * Support tempo dash variables * Support tempo explore variables * Only show span links for explore * Cleanup * Added tests * apply variables to search * Tests for search variables * Handling no data * Interpolation and tests * TracesPanel tests * More tests * Fix for backend test * Manager integration test fix * Traces doc and updated visualizations index doc * Logs for this span * Search, scrollToTop, other improvements * Refactor to extract common code * Removed TopOfViewRefType optional * Remove topOfViewRef optional * Removed another optional and fixed tests * Test * Only show search bar if trace * Support traces panel in add to dashboard * Self review * Update betterer * Linter fixes * Updated traces doc * Ahh, moved the for more info too * Updated betterer.results * Added new icon * Updated expectedListResp.json	4 years ago