grafana

Commit Graph

Author	SHA1	Message	Date
Grot (@grafanabot)	5a35850514	[v9.3.x] Alerting: Update migration to put alerts to the default folder if dashboard folder is missing (#66592 ) * Alerting: Update migration to put alerts to the default folder if dashboard folder is missing (#65577) * extract function * use context logger * put alert to general folder if folder is missing * move folderHelper init * add test * Update pkg/services/sqlstore/migrations/ualert/ualert.go Co-authored-by: Matthew Jacobson <matthew.jacobson@grafana.com> --------- Co-authored-by: Matthew Jacobson <matthew.jacobson@grafana.com> (cherry picked from commit `7b2f44762e`) * rename ID to Id and dashboards.Dashboard to models.Dashboard --------- Co-authored-by: Yuri Tseretyan <yuriy.tseretyan@grafana.com>	3 years ago
Horst Gutmann	64f074ca8d	[v9.3.x] CI: Update golangci-lint to 1.51.2 for Go 1.20 compatibility (#65506 ) [v9.3.x] Update golangci-lint to 1.51.2 for Go 1.20 compatibility	3 years ago
ismail simsek	ead3a002df	[v9.3.x] Expressions: Fixes the issue showing expressions editor (#62627 ) Expressions: Fixes the issue showing expressions editor (#62510) * Use suggested value for uid * update the snapshot * use __expr__ * replace all -100 with __expr__ * update snapshot * more changes * revert redundant change * Use expr.DatasourceUID where it's possible * generate files (cherry picked from commit `91221bc436`)	3 years ago
Grot (@grafanabot)	9f639403e6	[v9.3.x] Alerting: Prevent uid collision in migration when db is case-insensitive (#60835 ) Alerting: Prevent uid collision in migration when db is case-insensitive (#60494) * Alerting: Prevent short uid collision in legacy migration when db is case-insensitive Two factors come into play that cause sporadic uid conflicts during legacy alert migration: - MySQL and MySQL-compatible backends use case-insensitive collation. - Our short uid generator is not a uniform RNG and generates uids in such a way that generations in quick succession have a higher probability of creating similar uids. Normally we would be guaranteed unique short uid generation, however if the source alphabet contains duplicate characters (for example, if we use case-insensitive comparison) this guarantee is void. Generating even ~1000 uids in quick succession is nearly guaranteed to create a case-insensitive duplicate. (cherry picked from commit `570b62091c`) Co-authored-by: Matthew Jacobson <matthew.jacobson@grafana.com>	3 years ago
Grot (@grafanabot)	25382580fe	[v9.3.x] RBAC: Handle edge case where there is duplicated acl entries for a role on a single dashboard (#59573 ) RBAC: Handle edge case where there is duplicated acl entries for a role on a single dashboard (#58079) * RBAC: Handle edge case where there is duplicated acl entries for a role on a single dashboard (cherry picked from commit `6aaf36776b`) Co-authored-by: Karl Persson <kalle.persson@grafana.com>	3 years ago
Ryan McKinley	5934407443	Storage: add an admin write flavor that can explicitly set the user/time (#58618 )	3 years ago
ying-jeanne	69b5a9c752	Chore: [Nested Folder] Add db migration at service start time (#58590 ) * add db migration at service start time * make changes for the 3 db * revert migrator * fix feature toggle check Co-authored-by: Serge Zaitsev <serge.zaitsev@grafana.com>	3 years ago
Alex Moreno	45facbba11	Alerting: Remove url based external alertmanagers config (#57918 ) * Remove URL-based alertmanagers from endpoint config * WIP * Add migration and alertmanagers from admin_configuration * Empty comment removed * set BasicAuth true when user is present in url * Remove Alertmanagers from GET /admin_config payload * Remove URL-based alertmanager configuration from UI * Fix new uid generation in external alertmanagers migration * Fix tests for URL-based external alertmanagers * Fix API tests * Add more tests, move migration code to separate file, and remove possible am duplicate urls * Fix edge cases in migration * Fix imports * Remove useless fields and fix created_at/updated_at retrieval Co-authored-by: George Robinson <george.robinson@grafana.com> Co-authored-by: Konrad Lalik <konrad.lalik@grafana.com>	3 years ago
Emil Tullstedt	1ba25b2baa	Preferences: Create indices (#48356 )	3 years ago
Ryan McKinley	eb1cc80941	Storage: include SQL implementation (#58018 )	3 years ago
Sofia Papagiannaki	5c973e58bd	Nested Folders: Add tests for store methods (#57662 ) * Nested Folders: Add store tests * Fix parent order * Fix update * skip tests! * Export test helpers for now	3 years ago
Eric Leijonmarck	fc1b647474	Auth: Add fixed repeat migration w. checks for subset of permissions (#58054 ) * add: added a repeat migration w. fixed checks for permissions * add: migration to migrations * refactor: fix migration instead of making a new one * fix: removed the old id * fix: keep old name but change id * add: migration for patched previous migration * add: migration from missing file	3 years ago
Alexander Weaver	0dfd78c88c	Attempt to preserve UID from migrated channel (#57639 )	3 years ago
Ryan McKinley	9149544086	Store: Add SQL tables for SQL based object store (dev mode only) (#57785 )	3 years ago
Kristin Laemmert	b346ae0310	feat: add new Folder table migration & define nested folder interfaces (#56882 ) * feat: add new Folder table migration Add a new folder table to support the Nested Folders feature. https://github.com/grafana/grafana/issues/56880 * register nested folders feature flag (unused) * feat: nested folder service (experiment) This commit adds a NestedFolderSvc interface and stubbed out implementation as an alternative to the existing folder service. This is an experimental feature to try out different methods for backwards compatibility and parallelization, so that Grafana can continue to store folders in the existing (non-nested) manner while also using the new nested folder service. Eventually the new service will (hopefully) become _the_ service, at which point the legacy service can be deprecated (or remain, with the new service methods replacing the original. whatever makes sense at the time). * nested folders: don't run the new migration This commit removes the nested folder migration from the list of active migrations so we can merge this branch and continue development without impacting Grafana instances built off main.	3 years ago
owensmallwood	0b8fb543fc	Public Dashboards: Can toggle annotations in modal (#57312 ) adds toggle for pubdash annotations	3 years ago
Matthew Jacobson	0db339d82f	Alerting: Improve notification policies created during migration (#52071 ) * Alerting: Improve notification policies created during migration Previously, migrated legacy alerts were connected to notification policies through a `rule_uid` label in a 1:1 fashion. While this correctly mimicked pre-migration routing, it didn't create a notification policy structure that is easy to view/modify. In addition, having one policy per migrated alert is, in some ways, counter to the recommended approach of Unified Alerting. This change replaces `rule_uid`-based migrated notification policies with a private label called `__contacts__`. This label stores a list of double quoted strings containing the names of all contact points an AlertRule should route to (based on legacy notification channels). Finally, one notification policy is created per contact point with each matching AlertRules via regex on this `__contacts__` label. The result is a simpler, clearer, and easier to modify notification policy structure, with the added benefit that you can see which contact points an AlertRule is being routed to from the AlertRule creation page.	3 years ago
Karl Persson	21792fdf37	RBAC: Make uid for managed role names deterministic during migrations (#56620 ) * RBAC: Change the generate uid function to be deterministic so we can avoid collision * RBAC: Use fmt.Errorf * RBAC: Add comment * RBAC: Export GenerateManagedRoleUID	3 years ago
Karl Persson	b1761908c2	RBAC: Add primary key to seed_assignment table (#56540 ) * RBAC: Add seed_assignment migrations from enterprise * RBAC: Create migration to add primary key to seed_assignment table	3 years ago
Yuriy Tseretyan	3487e68d15	Alerting: Fix migration to create rules with group index 1 (#56511 )	3 years ago
Yuriy Tseretyan	e2f1201382	Alerting: Fix migration to not add label "alertname" (#56509 ) * do not add label alertname because it is overridden in state manager anyway * update state manager to not consider labels with same value as dupe	3 years ago
Piotr Jamróz	becdf10f0e	Glue: Add DB migration & support provisioning for user-defined correlations config (#55560 ) * Allow provisioning correlation config * Simplify code * Fix reading correlations test * Fix linting errors * Fix linting errors * remove simpleJson * Clean up * Fix tests * Update swagger docs * Fix linting * Fix linting * Clean up swagger definitions Co-authored-by: Elfo404 <me@giordanoricci.com>	3 years ago
Jean-Philippe Quéméner	f3a307778a	Alerting: cache general folder in migration based on org id (#55620 )	4 years ago
Sofia Papagiannaki	d0e7765c6a	Annotation: Optionally allow storing longer annotation tags (#54754 ) * Annotation: Optionally allow longer annotation tags * Do not accept configuration lower than today's default (500) * Apply suggestion from code review	4 years ago
Emil Tullstedt	647997cc4c	Alerting: Fix flaky test (#55551 ) The length of the identifier from the underlying library is 9 or more characters depending on the rate at which the identifiers are generated. See https://pkg.go.dev/github.com/teris-io/shortid The test previously made the assumption that the length will always be 10, which would intermittently fail.	4 years ago
Ieva	6d5bdf12e8	resolve merge conflicts (#55503 )	4 years ago
Piotr Jamróz	7352c181c2	Migrate user_id to BIGINT (#55084 )	4 years ago
Alexander Weaver	9f45e2e706	Alerting: Fix legacy migration crash when rule name is too long (#55053 ) * Extract standardized UID field length to constant * Extract default length to constant * Truncate rule names that are too long * Add tests for name normalization * Fix whitespace lint error * Another linter fix * Empty commit to kick build	4 years ago
Emil Tullstedt	b287047052	Chore: Upgrade Go to 1.19.1 (#54902 ) * WIP * Set public_suffix to a pre Ruby 2.6 version * we don't need to install python * Stretch->Buster * Bump versions in lib.star * Manually update linter Sort of messy, but the .mod-file need to contain all dependencies that use 1.16+ features, otherwise they're assumed to be compiled with -lang=go1.16 and cannot access generics et al. Bingo doesn't seem to understand that, but it's possible to manually update things to get Bingo happy. * undo reformatting * Various lint improvements * More from the linter * goimports -w ./pkg/ * Disable gocritic * Add/modify linter exceptions * lint + flatten nested list Go 1.19 doesn't support nested lists, and there wasn't an obvious workaround. https://go.dev/doc/comment#lists	4 years ago
Valério Valério	b5142832fa	Alerting: Fix saving of screenshots uploaded with a signed url (#53933 ) The URL of screenshots uploaded to external image storages can be optionally signed, resulting in a long string (800+ chars).	4 years ago
Jo	4a9137ac40	API Keys: Add revocation for SATs (#53896 ) * add apikey is_revoked field * add token store tests * Apply suggestions from code review * remove unused fields	4 years ago
Giordano Ricci	c1b30c56c9	Correlations: Add GetCorrelation(s) HTTP APIs (#52517 ) * Correlations: Get Single correlations * Correlations: Get all correlations for given source ds * Correlations: Get all correlations * add tests * add DB indices * fix lint errors * remove skip from tests * use DatasourceService in test	4 years ago
idafurjes	6afad51761	Move SignedInUser to user service and RoleType and Roles to org (#53445 ) * Move SignedInUser to user service and RoleType and Roles to org * Use go naming convention for roles * Fix some imports and leftovers * Fix ldap debug test * Fix lint * Fix lint 2 * Fix lint 3 * Fix type and not needed conversion * Clean up messages in api tests * Clean up api tests 2	4 years ago
Sofia Papagiannaki	ae101bf935	Alerting: Fix migration (#53253 )	4 years ago
Artur Wierzbicki	449acb56a9	Previews: fix `dashboard.thumbnails.ds_uids` migration (#52960 )	4 years ago
Artur Wierzbicki	18daa6754c	Previews: datasource permissions (#52747 ) * Previews: datasource permissions * lint * simplify - force non-null `ds_uids` * add `canBeDisabled` to search service * add `IncludeThumbnailsWithEmptyDsUids` * remove force refresh migration * refactor main preview service * add safeguard * revert ticker interval * update testdata * fix test * add mock search service * add datasources lookup test * update migration * extract ds lookup to its own package to avoid cyclic imports * lint * fix dashbaord extract, use the real datasource lookup in tests. IS IT BULLETPROOF YET?! * fix dashbaord extract, use the real datasource lookup in tests. IS IT BULLETPROOF YET?! * remove stale log * consistent casing * pass context to `createServiceAccount` * filter out the special grafana ds	4 years ago
Giordano Ricci	5ce4baf6f5	Correlations: Add CreateCorrelation HTTP API (#51630 ) * Correlations: add migration * Correlations: Add CreateCorrelation API * Correlations: Make correlations work with provisioning * Handle version changes * Fix lining error * lint fixes * rebuild betterer results * add a UID to each correlation * Fix lint errors * add docs * better wording in API docs * remove leftover comment * handle ds updates * Fix error message typo * add bad data test * make correlations a separate table * skip readonly check when provisioning correlations * delete stale correlations when datasources are deleted * restore provisioned readonly ds * publish deletion event with full data * generate swagger and HTTP API docs * apply source datasource permission to create correlation API * Fix tests & lint errors * ignore empty deletion events * fix last lint errors * fix more lint error * Only publish deletion event if datasource was actually deleted * delete DS provisioning deletes correlations, added & fixed tests * Fix unmarshalling tests * Fix linting errors * Fix deltion event tests * fix small linting error * fix lint errors * update betterer * fix test * make path singular * Revert "make path singular" This reverts commit `420c3d315e`. * add integration tests * remove unneeded id from correlations table * update spec * update leftover references to CorrelationDTO * fix tests * cleanup tests * fix lint error	4 years ago
Ieva	39025bb4cd	add logs to debug failing migration (#52447 )	4 years ago
idafurjes	f5cace8bbd	Rename Acl to ACL (#52342 ) * Rename Acl to ACL * Fix yaml files * Add xorm tags and fix test	4 years ago
Ieva	c851907fc3	Access Control: Fix missing folder permissions (#52153 ) * add the migration * Update pkg/services/sqlstore/migrations/accesscontrol/dashboard_permissions.go Co-authored-by: Eric Leijonmarck <eric.leijonmarck@gmail.com> Co-authored-by: Eric Leijonmarck <eric.leijonmarck@gmail.com>	4 years ago
Matthew Jacobson	434e94ef2b	Alerting: Update default route groupBy to [grafana_folder, alertname] (#50052 ) * Alerting: Update default route groupBy to [grafana_folder, alertname] Default group by for new routes and migrations is now [grafana_folder, alertname]	4 years ago
Kristin Laemmert	9de00c8eb2	chore/backend: move dashboard errors to dashboard service (#51593 ) * chore/backend: move dashboard errors to dashboard service Dashboard-related models are slowly moving out of the models package and into dashboard services. This commit moves dashboard-related errors; the rest will come in later commits. There are no logical code changes, this is only a structural (package) move. * lint lint lint	4 years ago
Jguer	6d0261263c	ServiceAccounts: Add Service Account Token last used at date (#51446 ) * ServiceAccounts Add api key last used at * ServiceAccounts: LastUpdateAt tests	4 years ago
idafurjes	6c43eb0b4d	Split Create User (#50502 ) * Split Create User * Use new create user and User from package user * Add service to wire * Making create user work * Replace user from user pkg * One more * Move Insert to orguser Service/Store * Remove unnecessary conversion * Cleaunp * Fix Get User and add fakes * Fixing get org id for user logic, adding fakes and other adjustments * Add some tests for ourguser service and store * Fix insert org logic * Add comment about deprecation * Fix after merge with main * Move orguser service/store to org service/store * Remove orguser from wire * Unimplement new Create user and use User from pkg user * Fix wire generation * Fix lint * Fix lint - use only User and CrateUserCommand from user pkg * Remove User and CreateUserCommand from models * Fix lint 2	4 years ago
Emil Tullstedt	7d815a1db5	Alerting: Use google/uuid instead of gofrs/uuid (#51242 )	4 years ago
Kristin Laemmert	945f015770	backend/datasources: move datasources models into the datasources service package (#51267 ) * backend/datasources: move datasources models into the datasources service pkg	4 years ago
owensmallwood	1802cc8aca	Add correct table definition for migrations for old dashboard_public schema (#51292 ) Co-authored-by: Jesse Weaver <jesse.weaver@grafana.com>	4 years ago
Jeff Levin	d076bedb5e	public dashboards: finalize db schema & v1 feature complete (#50467 ) This PR completes public dashboards v1 functionality and simplifies public dashboard conventions. It exists as a large PR so that we are not making constant changes to the database schema. models.PublicDashboardConfig model replaced with models.PublicDashboard directly dashboard_public_config table renamed to dashboard_public models.Dashboard.IsPublic removed from the dashboard and replaced with models.PublicDashboard.isEnabled Routing now uses a uuid v4 as an access token for viewing a public dashboard anonymously, PublicDashboard.Uid only used as database identifier Frontend utilizes uuid for auth'd operations and access token for anonymous access Default to time range defined on dashboard when viewing public dashboard Add audit fields to public dashboard Co-authored-by: Owen Smallwood <owen.smallwood@grafana.com>, Ezequiel Victorero <ezequiel.victorero@grafana.com>, Jesse Weaver <jesse.weaver@grafana.com>	4 years ago
gotjosh	90646e7f41	Alerting: Don't stop the migration when alert rule tags are invalid (#51253 ) * Alerting: Don't stop the migration when alert rule tags are invalid As we migrate we expect the `alertRuleTags` on a dashboard alert to be a JSON object. However, it seems this is not really validated by Grafana and an user can change the format to something else that the JSON parser is not able to marshal into a `map[string]string`. Let's do a bit better by "attempting" to parse the tags and if we can't we'll simple return an empty map. The data is still there so if the user wishes they can go back, fix the data and attemp the migration again.	4 years ago
Yuriy Tseretyan	4d02f73e5f	Alerting: Persist rule position in the group (#50051 ) Migrations: * add a new column alert_group_idx to alert_rule table * add a new column alert_group_idx to alert_rule_version table * re-index existing rules during migration API: * set group index on update. Use the natural order of items in the array as group index * sort rules in the group on GET * update the version of all rules of all affected groups. This will make optimistic lock work in the case of multiple concurrent request touching the same groups. UI: * update UI to keep the order of alerts in a group	4 years ago

1 2 3 4 5 ...

471 Commits (a9873db0f94dea418511ecc953bc3d304ab95e3f)