55 Commits (aaab4775944de7f408dc971872735d1c1956e1c4)

Author	SHA1	Message	Date
Yuri Tseretyan	c5ee4e4ae1	Alerting: Improve rule validation to check if rule uses backend datasources (#58986) ... * validate if rule uses backend datasources * add backend datasource to test * fix tests * another forgotten import * remove unused var	3 years ago
Yuri Tseretyan	b57689e07e	Alerting: Add header X-Grafana-Org-Id to evaluation requests (#58972)	3 years ago
Yuriy Tseretyan	e3a4bde622	Alerting: Condition evaluator with cached pipeline (#57479) ... * create rule evaluator * load header from the context * init one factory * update scheduler	3 years ago
Yuriy Tseretyan	0a4121cef8	Alerting: Contextual log provider for rule key (#57476) ... * create contextual log context provider * use contextual provider in scheduler * init logger in the package * use context for log context * use context in state manager	3 years ago
Yuriy Tseretyan	2d20c8db7b	Chore: Expression engine to support relative time range (#57474) ... * make TimeRange interface and add relative range * make Execute methods support the current time * update resample to support relative time range * update DSNode to support relative time range * update query service to create queries with absolute time * make alerting evaluator create relative time ranges	3 years ago
Alexander Weaver	4eb8e4ff66	Alerting: Add traceability headers for alert queries (#57127) ... * Define EvaluationContext * Refactor ConditionEval to use new context struct * Refactor QueriesAndExpressionsEval to use EvaluationContext * Remove dead field from AlertExecCtx * Refactor Validate to use EvaluationContext * Get rid of privately used AlertExecCtx * Move EvaluationContext to new file and add helper * Add builder pattern and bind rule info to context * Extract header logic and add rule UID header * Fix missing call	3 years ago
George Robinson	a49fcbdbbc	Alerting: Add frames for all queries and expressions (#55609) ... This commit is one of two commits to make the data frames for all queries and expressions in an alert rule available to the state package for rendering a graph. It renames Result to Condition, and creates an additional field called Results that is a map of Ref ID to data.Frames.	3 years ago
Yuriy Tseretyan	2d38664fe6	Alerting: Improve validation of query and expressions on rule submit (#53258) ... * Improve error messages of server-side expression * move validation of alert queries and a condition to eval package	3 years ago
Yuriy Tseretyan	896eeb65a9	Alerting: Fix alerting evaluation to use proper permissions (#55127) ... * access control to log user name if it does not have permissions * update ngalert Evaluator to accept user instead of creating a pseudo one * update alerting eval (rule\query testing) API to provide the real user to the Evaluator * update scheduler to create a pseudo user with proper permissions	3 years ago
Emil Tullstedt	b287047052	Chore: Upgrade Go to 1.19.1 (#54902) ... * WIP * Set public_suffix to a pre Ruby 2.6 version * we don't need to install python * Stretch->Buster * Bump versions in lib.star * Manually update linter Sort of messy, but the .mod-file need to contain all dependencies that use 1.16+ features, otherwise they're assumed to be compiled with -lang=go1.16 and cannot access generics et al. Bingo doesn't seem to understand that, but it's possible to manually update things to get Bingo happy. * undo reformatting * Various lint improvements * More from the linter * goimports -w ./pkg/ * Disable gocritic * Add/modify linter exceptions * lint + flatten nested list Go 1.19 doesn't support nested lists, and there wasn't an obvious workaround. https://go.dev/doc/comment#lists	3 years ago
Marcus Efraimsson	87afd9cadc	Plugins: Remove various custom headers logic (#54146) ... Removes various custom headers logic sprinkled around in the backend. It should automatically be applied to outgoing HTTP requests via the CustomHeadersMiddleware. This also removes decryption of SecureJSONData to populate custom headers in ngalert which seemed to have caused a ton of CPU usage.	3 years ago
idafurjes	a14621fff6	Chore: Add user service method SetUsingOrg and GetSignedInUserWithCacheCtx (#53343) ... * Chore: Add user service method SetUsingOrg * Chore: Add user service method GetSignedInUserWithCacheCtx * Use method GetSignedInUserWithCacheCtx from user service * Fix lint after rebase * Fix lint * Fix lint error * roll back some changes * Roll back changes in api and middleware * Add xorm tags to SignedInUser ID fields	3 years ago
idafurjes	6afad51761	Move SignedInUser to user service and RoleType and Roles to org (#53445) ... * Move SignedInUser to user service and RoleType and Roles to org * Use go naming convention for roles * Fix some imports and leftovers * Fix ldap debug test * Fix lint * Fix lint 2 * Fix lint 3 * Fix type and not needed conversion * Clean up messages in api tests * Clean up api tests 2	3 years ago
Yuriy Tseretyan	0d4c503d3d	update Evaluator interface to accept context (#52151)	3 years ago
Yuriy Tseretyan	554ebd647b	Alerting: Refactor Evaluator (#51673) ... * AlertRule to return condition * update ConditionEval to not return an error because it's always nil * make getExprRequest private * refactor executeCondition to just converter and move execution to the ConditionEval as this makes code more readable. * log error if results have errors * change signature of evaluate function to not return an error	3 years ago
Yuriy Tseretyan	94e709fdcb	Alerting: Simplify eval.Evaluator interface (#51463) ... * remove ExpressionService from argument list of Evaluator's methods	4 years ago
Kristin Laemmert	945f015770	backend/datasources: move datasources models into the datasources service package (#51267) ... * backend/datasources: move datasources models into the datasources service pkg	4 years ago
Joe Blubaugh	1cc034d960	Alerting: Add a "Reason" to Alert Instances to show underlying cause of state. (#49259) ... This change adds a field to state.State and models.AlertInstance that indicate the "Reason" that an instance has its current state. This helps us account for cases where the state is "Normal" but the underlying evaluation returned "NoData" or "Error", for example. Fixes #42606 Signed-off-by: Joe Blubaugh <joe.blubaugh@grafana.com>	4 years ago
gotjosh	cb6124c921	Alerting: Accurately set value for prom-compatible APIs (#47216) ... * Alerting: Accurately set value for prom-compatible APIs Sets the value fields for the prometheus compatible API based on a combination of condition `refID` and the values extracted from the different frames. * Fix an extra test * Ensure a consitent ordering * Address review comments * address review comments	4 years ago
Yuriy Tseretyan	e94d0c1b96	Alerting: update rule test endpoints to respect data source permissions (#47169) ... * make eval.Evaluator an interface * inject Evaluator to TestingApiSrv * move conditionEval to RouteTestGrafanaRuleConfig because it is the only place where it is used * update rule test api to check data source permissions	4 years ago
George Robinson	9df43abbb5	Fix evaluation of alert rules for datasources with custom headers (#44862) ... * Fix evaluation of alert rules for datasources with custom headers * Fix unit tests * Fix integration tests * Evaluator fields should be package private	4 years ago
idafurjes	ff3cf94b56	Chore: Remove context.TODO() from services (#42555) ... * Remove context.TODO() from services * Fix live test	4 years ago
Ryan McKinley	2754e4fdf0	Expressions: use datasource model from the query (#41376) ... * refactor datasource loading * refactor datasource loading * pass uid * use dscache in alerting to get DS * remove expr/translate pacakge * remove dup injection entry * fix DS type on metrics endpoint, remove SQL DS lookup inside SSE * update test and adapter * comment fix * Make eval run as admin when getting datasource info Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com> * fmt and comment * remove unncessary/redundant code Co-authored-by: Kyle Brandt <kyle@grafana.com> Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com> Co-authored-by: Santiago <santiagohernandez.1997@gmail.com>	4 years ago
George Robinson	c932dc959c	Alerting: Add Ref ID to DatasourceNoData and DatasourceError alerts (#42630)	4 years ago
George Robinson	d363e19517	Alerting: Add datasource_uid label to DatasourceNoData alerts (#41621)	4 years ago
Marcus Efraimsson	baab021fec	Chore: Refactor usage of legacy data contracts (#41218) ... Refactor usage of legacy data contracts. Moves legacy data contracts to pkg/tsdb/legacydata package. Refactor pkg/expr to be a proper service/dependency that can be provided to wire to remove some unneeded dependencies to SSE in ngalert and other places. Refactor pkg/expr to not use the legacydata,RequestHandler and use backend.QueryDataHandler instead.	4 years ago
Sofia Papagiannaki	f6f3a54742	Alerting: tune rule evaluation via configuration (#35623) ... * Alerting: Configure max evaluation retries * Alerting: Enforce minimum rule evaluation interval * Alerting: Disable rule evaluation from configuration * Update docs * Alerting: Configure rule evaluation timeout * Move options on unified_alerting config section * Apply suggestions from code review Co-authored-by: gotjosh <josue@grafana.com>	4 years ago
Todd Treece	6e667cacee	Alerting: Skip query cache for alert queries (#39010)	4 years ago
George Robinson	456dac1303	Expand the value of math and reduce expressions in annotations and labels (#36611) ... * Expand the value of math and reduce expressions in annotations and labels This commit makes it possible to use the values of reduce and math expressions in annotations and labels via their RefIDs. It uses the Stringer interface to ensure that "{{ $values.A }}" still prints the value in decimal format while also making the labels for each RefID available with "{{ $values.A.Labels }}" and the float64 value with "{{ $values.A.Value }}"	4 years ago
Andrej Ocenas	ea2ba06b93	CloudWatch/Logs: Fix log alerts in new unified alerting (#36558) ... * Pass FromAlert header from new alerting * Add better error messages	5 years ago
Kyle Brandt	19f764739b	Alerting: Change `__value__` label to `__value_string__` annotation and add `ValueString` variable in notifications (#36032) ... * Alerting: Allow __value__ label in notifications was being removed by removePrivateItems discoverd in #36020, but issue is not about that specifically * __value__ label to __value_string__ annotation and .ValueString extended property for notifications	5 years ago
Sofia Papagiannaki	abe35c8c01	Alerting: Add error recovery during rule evaluations (#35450) ... * Alerting: Eval recovery after query failure * Apply suggestions from code review	5 years ago
Kyle Brandt	b47e7d12e6	Alerting: Extract values from MD expr alerts (#34757) ... When using mulit-dimensional Grafana managed alerts (e.g. SSE math) extract refIds values and labels so they can be shown in the notification and dashboards.	5 years ago
Marcus Andersson	e19b3df1a9	Alerting: added possibility to preview grafana managed alert rules. (#34600) ... * starting to add eval logic. * wip * first version of test rule. * reverted file. * add info colum to result to show error or (with CC evalmatches) * fix labels in evalmatch * fix be test * refactored using observables. * moved widht/height div to outside panel rendere. * adding docs api level. * adding container styles to error div. * increasing size of preview. Co-authored-by: kyle <kyle@grafana.com>	5 years ago
Kyle Brandt	63b2dd06a5	Alerting: Set "value" with evalmatches in G Managed (#34075) ... When, and currently only when using a classic condition, evaluation information is added (which is like the EvalMatches from dashboard alerting). This is returned via the API and can be included in notifications by reading the `__value__` label attached `.Alerts` in the template. It is a string.	5 years ago
Kyle Brandt	d32fcbe2bc	Alerting: Eval pkg tests and more specific error handling (#33496) ... * comment updates * more friendly error messages, in particular if it looks like time series data	5 years ago
David Parrott	788bc2a793	Alerting: refactor state tracker (#33292) ... * set processing time * merge labels and set on response * use state cache for adding alerts to rules * minor cleanup * add support for NoData and Error results * rename test * bring in changes from other PRs tha have been merged * pr feedback * add integration test * close state tracker cleanup on context.Done * fixup test * rename state tracker * set EvaluationDuration on Result * default labels set as constants * separate cache and state from manager * use RWMutex in cache	5 years ago
David Parrott	ca79206498	Alerting: Handle NoData and Error evaluation results (#33194) ... * set processing time * merge labels and set on response * use state cache for adding alerts to rules * minor cleanup * add support for NoData and Error results * rename test * bring in changes from other PRs tha have been merged * pr feedback * add integration test * close state tracker cleanup on context.Done * fixup test * not those annotations	5 years ago
Kyle Brandt	5e818146de	Alerting/Expr: New SSE Request/QueryType, alerting move data source UID (#33282)	5 years ago
Sofia Papagiannaki	b2288f7ef9	[Alerting]: Add alerting endpoint for Query Evaluation (#33174) ... * [Alerting]: Add alerting endpoint for Query Evaluation * Fix passing down now parameter * Add validations and test * Fix eval queries and expressions test * Add eval tests	5 years ago
David Parrott	4be1d84f23	Alerting: Enhancements to /rules (#33085) ... * set processing time * merge labels and set on response * use state cache for adding alerts to rules * minor cleanup * pr feedback * Do not initialize mutex unnecessarily Co-authored-by: Ganesh Vernekar <15064823+codesome@users.noreply.github.com> * linter Co-authored-by: Ganesh Vernekar <15064823+codesome@users.noreply.github.com>	5 years ago
Sofia Papagiannaki	e7ff04a167	[Alerting]: Implement test rule API route (#32837) ... * [Alerting]: Implement test rule API route * Apply suggestions from code review * Call /query instead of /query_range	5 years ago
David Parrott	b1cb74c0c9	Alerting: Send alerts from state tracker to notifier, logging, and cleanup task (#32333) ... * Initial commit for state tracking * basic state transition logic and tests * constructor. test and interface fixup * use new sig for sch.definitionRoutine() * test fixup * make the linter happy * more minor linting cleanup * Alerting: Send alerts from state tracker to notifier * Add evaluation time and test Add evaluation time and test * Add cleanup routine and logging * Pull in compact.go and reconcile differences * pr feedback * pr feedback Pull in compact.go and reconcile differences Co-authored-by: Josue Abreu <josue@grafana.com>	5 years ago
David Parrott	d33a77a67f	Alerting: add state tracker to alerting evaluation (#32298) ... * Initial commit for state tracking * basic state transition logic and tests * constructor. test and interface fixup * use new sig for sch.definitionRoutine() * test fixup * make the linter happy * more minor linting cleanup	5 years ago
gotjosh	58b814bd7d	Alerting: Add StartAt and FiredAt to the alert evaluation result (#32302)	5 years ago
Kyle Brandt	05fa9d6ad9	AlertingNG: rename Condition properties to match front end (#32267)	5 years ago
Kyle Brandt	7bb79158ed	SSE/Alerting: First pass at query/condition translation (#31693) ... - Takes the conditions property from the settings column of an alert from alerts table and turns into an ng alerting condition with the queries and classic condition. - Has temp API rest endpoint that will take the dashboard conditions json, translate it to SEE queries + classic condition, and execute it (only enabled in dev mode). - Changes expressions to catch query responses with a non-nil error property - Adds two new states for an NG instance result (NoData, Error) and updates evaluation to match those states - Changes the AsDataFrame (for frontend) from Bool to string to represent additional states - Fix bug in condition model to accept first Operator as empty string. - In ngalert, adds GetQueryDataRequest, which was part of execute and is still called from there. But this allows me to get the Expression request from a condition to make the "pipeline" can be built. - Update AsDataFrame for evalresult to be row based so it displays a little better for now	5 years ago
Sofia Papagiannaki	53bccf1b77	Replace eval.Condition with models.Condition (#31909)	5 years ago
Sofia Papagiannaki	4ce0a49eac	AlertingNG: Split into several packages (#31719) ... * AlertingNG: Split into several packages * Move AlertQuery to models	5 years ago
Arve Knudsen	b79e61656a	Introduce TSDB service (#31520) ... * Introduce TSDB service Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> Co-authored-by: Erik Sundell <erik.sundell87@gmail.com> Co-authored-by: Will Browne <will.browne@grafana.com> Co-authored-by: Torkel Ödegaard <torkel@grafana.org> Co-authored-by: Will Browne <wbrowne@users.noreply.github.com> Co-authored-by: Zoltán Bedi <zoltan.bedi@gmail.com>	5 years ago