115 Commits (ab36252c86b4e173788478d4cab0c3e5f3398619)

Author	SHA1	Message	Date
Kristina	2055d922f3	Refactor SplitPaneWrapper to be more centralized component, refactor PanelEditor to use it (#58380) ... * Move layout to paneleditor, make SplitPaneWrapper more generic * Read/write the size ratio in local storage * Add min height to enable scrollbar * Enable show/hide panel options * Change back variable name	3 years ago
Torkel Ödegaard	d7f9093ccd	LibrayPanels: Fix unlinking libray panel (#57825)	3 years ago
Zoltán Bedi	c0b778134e	Revert: Query editor components from grafana-ui (#57436) ... * Revert: QueryEditor components from grafana-ui * Use local version of experimental * Use experimental for query editor components * Fix type issues in MSSQL * point to actual version of experimental package * point to latest version of experimental Co-authored-by: Erik Sundell <erik.sundell87@gmail.com>	3 years ago
Torkel Ödegaard	49bc70c812	TopNav: Panel edit changes (#54746) ... * Progress * Progress * Things are working * More tweaks * Fixing unit test * Tweaks and fixing e2e tests * Remove ... in Save as * Fixing unit test * Fixing e2e test * Fixes Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com>	3 years ago
Torkel Ödegaard	e5c32c8cc9	Dashboard: Unsaved changes warning fixes (#54706) ... * Quick test of alternative method * change order of if condition again for better readability * Think I have something that is working * Update	3 years ago
Vadim Beskrovnov	7caba545ec	A11y: Fix a11y for toolbar buttons in PanelEditor (#53864) ... Co-authored-by: Vadim Beskrovnov <vbeskrovnov@fb.com>	3 years ago
kay delaney	06012d51a9	Dashboard: Adjust styles for very long titles (#52452)	3 years ago
Ashley Harrison	803473f479	Chore: Enable `useUnknownInCatchVariables` for stricter type checking in catch blocks (#50591) ... * wrap a bunch of errors * wrap more things! * fix up some unit tests * wrap more errors * tiny bit of tidy up	4 years ago
Josh Hunt	1cd9175075	PanelEdit: Add gap between variables, like in Dashboard view (#48718)	4 years ago
Josh Hunt	2f1d404949	Switch PanelEditor to v2 theme (#48717)	4 years ago
Ryan McKinley	a8f3b17262	SaveDashboard: remove feature flag for save drawer (#48462)	4 years ago
Josh Hunt	3c6e0e8ef8	Chore: ESlint import order (#44959) ... * Add and configure eslint-plugin-import * Fix the lint:ts npm command * Autofix + prettier all the files * Manually fix remaining files * Move jquery code in jest-setup to external file to safely reorder imports * Resolve issue caused by circular dependencies within Prometheus * Update .betterer.results * Fix missing // @ts-ignore * ignore iconBundle.ts * Fix missing // @ts-ignore	4 years ago
kay delaney	f10047b708	Dashboard: Refactor panel cleanup (#47323)	4 years ago
kay delaney	0cff2d5980	Library panels: Fix issue where query editor options wouldn't be updated (#47242) ... Closes #47241	4 years ago
Ryan McKinley	edf384c730	DashboardSave: use a feature flag for drawer behavior (#46972)	4 years ago
Ryan McKinley	15ca294be0	Dashboards: show changes in save dialog (#46557) ... Co-authored-by: Torkel Ödegaard <torkel@grafana.com>	4 years ago
Hugo Häggmark	dbec2b02fd	Variables: move state tree into a keyed state (#44642) ... * Variables: move state tree into a keyed state * Update public/app/features/variables/state/transactionReducer.ts Co-authored-by: kay delaney <45561153+kaydelaney@users.noreply.github.com> * Chore: fix prettier error * Chore: renamed slices and lastUid * Chore: rename toUidAction * Chore: rename dashboardVariableReducer * Chore: rename state prop back to templating * Chore renames variable.dashboardUid * Chore: rename toDashboardVariableIdentifier * Chore: rename getDashboardVariable * Chore: rename getDashboardVariablesState * Chore: rename getDashboardVariables * Chore: some more renames * Chore: small clean up * Chore: small rename * Chore: removes unused function * Chore: rename VariableModel.stateKey * Chore: rename KeyedVariableIdentifier.stateKey * user essentials mob! 🔱 * user essentials mob! 🔱 * user essentials mob! 🔱 * user essentials mob! 🔱 Co-authored-by: kay delaney <45561153+kaydelaney@users.noreply.github.com> Co-authored-by: kay delaney <kay@grafana.com> Co-authored-by: Alexandra Vargas <alexa1866@gmail.com> Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com>	4 years ago
kay delaney	597148f23b	Dashboards: Use IntersectionObserver to manage lazy loading of panels (#42834)	4 years ago
Ryan McKinley	231f17ab20	PanelEditor: remove showCategory on exit (#41174)	4 years ago
Torkel Ödegaard	54af57b8e6	VisualizationSelection: Real previews of suitable visualisation and options based on current data (#40527) ... * Initial pass to move panel state to it's own, and make it by key not panel.id * Progress * Not making much progress, having panel.key be mutable is causing a lot of issues * Think this is starting to work * Began fixing tests * Add selector * Bug fixes and changes to cleanup, and fixing all flicking when switching library panels * Removed console.log * fixes after merge * fixing tests * fixing tests * Added new test for changePlugin thunk * Initial struture in place * responding to state changes in another part of the state * bha * going in a different direction * This is getting exciting * minor * More structure * More real * Added builder to reduce boiler plate * Lots of progress * Adding more visualizations * More smarts * tweaks * suggestions * Move to separate view * Refactoring to builder concept * Before hover preview test * Increase line width in preview * More suggestions * Removed old elements of onSuggestVisualizations * Don't call suggestion suppliers if there is no data * Restore card styles to only borders * Changing supplier interface to support data vs option suggestion scenario * Renamed functions * Add dynamic width support * not sure about this * Improve suggestions * Improve suggestions * Single grid/list * Store vis select pane & size * Prep for option suggestions * more suggestions * Name/title option for preview cards * Improve barchart suggestions * Support suggestions when there are no data * Minor change * reverted some changes * Improve suggestions for stacking * Removed size option * starting on unit tests, hit cyclic dependency issue * muuu * First test for getting suggestion seems to work, going to bed * add missing file * A basis for more unit tests * More tests * More unit tests * Fixed unit tests * Update * Some extreme scenarios * Added basic e2e test * Added another unit test for changePanelPlugin action * More cleanup * Minor tweak * add wait to e2e test * Renamed function and cleanup of unused function * Adding search support and adding search test to e2e test	4 years ago
Torkel Ödegaard	d62ca1283c	PanelState: Introduce a new separate redux panel state not keyed by panel.id (#40302) ... * Initial pass to move panel state to it's own, and make it by key not panel.id * Progress * Not making much progress, having panel.key be mutable is causing a lot of issues * Think this is starting to work * Began fixing tests * Add selector * Bug fixes and changes to cleanup, and fixing all flicking when switching library panels * Removed console.log * fixes after merge * fixing tests * fixing tests * Added new test for changePlugin thunk	4 years ago
kay delaney	78ebac0116	Chore/Nit: Fix minor alignment issue in panel editor (#40232)	4 years ago
Torkel Ödegaard	962745ff21	PanelEditor: Adds panel instance state and a way to share this between panel & option editors (#39637) ... * PanelEditor: Adds panel instance state and a way to share this between panel & option editors * Refactoring to use PanelContext	4 years ago
Ashley Harrison	344c43f2e8	PanelEdit: Fix 'Actual' size by passing the correct panel size to DashboardPanel (#37885)	4 years ago
Torkel Ödegaard	a67eaf6b62	DashboardPage: Refactor state to fix state timing bugs and reduce unnecessary re-renders (#36460) ... * DashboardPage: Refactoring state handling to improve performance and fix bugs with state out of sync * Fixed exit panel editor timing issues * New tests in RTL * Updated comment * Removed unused imports	5 years ago
Torkel Ödegaard	17707d886a	PanelEditor: Fixes issue minor UI issue with editing non data panels (#36463)	5 years ago
Torkel Ödegaard	f0cac149da	DashboardGrid: Refactorings and performance improvements (#35942) ... * add back only re-render dashboard first time on layout change * remove panel refs * Updates * Improved is in view logic * Updates * Remove unnessary auto sizer * Found another approach that works with resize as well * Updates * fixing test * Fixing ref issues * Fixed mobile size handling, and view panel handling, removed now unnessary logic * Updated snapshot	5 years ago
Torkel Ödegaard	e6f2b10a36	ChangeTracker: Unified unsaved changes handling with library panels (#34989) ... * UnsavedChanges: Move Change tracker to use Prompt * Fix a lot of race conditions and stacking of changes in onConfirm and onDismiss * Listen to save event * add missing delay argument * migrated the change tracker unit tests * Updated snapshot * Removed unessary action * removed updateSourcePanel * Fix hiding save library panel modal prompt when clicking discard * change saved libray panel title and buttons so they are a bit different as Prompt and when used from save button * Fixed issue with saving new dashboard * Now all scenarios work * increase wait time * Fixed one more race condition	5 years ago
Maria Alexandra	ff03b456f1	Dashboard: Fix Table view when editing causes the panel data to not update (#34998) ... * Dashboard: Fix Table view when editing causes the panel data to not update - Add event subscription on PanelEditorTableView - Extract runAllPanelQueries into Panel Model in order to use it on PanelChrome and PanelEditorTableView - Add simple unit test for runAllQueryPaneQueries	5 years ago
Jack Westbrook	ad3b0b2272	PageToolbar: add bottom padding (#34602) ... * fix(pagetoolbar): pad elements top and bottom to keep vertical align and wrapper padding * fix(sidemenu): prevent mobile sidemenu squashing dashboard, vertically align mobile sidemenu icon * fix(dashboardsettings): prevent subheader overlap * fix(pagetoolbar): center align all toolbar elements vertically * refactor(pagetoolbar): combine vertical paddings to bring back original padding values * refactor: update padding values for components that use PageToolbar * fix(playlists): update Empty cta link route to prevent 404 * test(dashboard): update snapshot	5 years ago
Ryan McKinley	1e6eb70af0	PanelEditor: leave table view when changing the other display modes (#33826)	5 years ago
Torkel Ödegaard	724cbcd745	PanelEdit: Adds a table view toggle to quickly view data in table form (#33753) ... * PanelEdit: Adds raw data toggle to quickly be able to view data in table form * With transforms * Updated name for toggle * refactoring and added e2e test * Support options * fixing e2e	5 years ago
Torkel Ödegaard	dbcfebac56	TimeSeries: Make timeseries the default panel and remove beta state (#33639) ... * TimeSeries: Make timeseries the default panel and remove beta state * rename old graph * Updated panel descriptions, fixed e2e tests * Updated text * Fixed e2e * Fixing e2e tests	5 years ago
kay delaney	2cc66e548a	Library panels: Normalize feature name as "Library panels" (#33540)	5 years ago
Torkel Ödegaard	629603dd92	Theming: Updates to select styles and theme model progress (#32797) ... * Theming: Updates to select styles and theme model progress * Progress * Update menu * Updated menu group * Improving button styles * Added transitions to theme * solving the hover & selected, focus issues * Updated snapshot * adding some colors from figma, but waiting to use them as not enough components use new layer colors * Updates * Updates * Progress * Renames * Improvements to theme overview * updated test * demo update * More new theme colors * Wip new card styles * Card tweaks hover is not working * Updates more colors from figma * Progress * Progress * Updated radio button styles * Progress on new colors * Progress * New page toolbar and toolbar button design * New toolbar button design * Reverted to older toolbar and button look * Updated snapshot * Updated generated files * Updated design * Updates * Added card hover * Fixed button group * Updates	5 years ago
Torkel Ödegaard	10badea19e	Emotion: Upgrades emotion from 10 to 11 and updates all import paths (#32541) ... * Babel: Updates babel dependencies to latest version * Emotion: Upgrade form 10 to 11 * Fixing tests * Updated to use emotion/css instead in test	5 years ago
Torkel Ödegaard	feaaa32ffd	Shortcuts: Fixes panel shortcuts so they always work (#32385) ... * Shortcuts: Fixes panel shortcuts so they always work * Updated snapshot	5 years ago
kay delaney	298ff3ea01	Library Panels: Improve unsaved changes handling (#32026) ... * Library Panels: Improve unsaved changes handling	5 years ago
Torkel Ödegaard	9d6c8f8512	PanelEdit: v8 Panel Edit UX (#32124) ... * Initial commit * Progress * Update * Progress * updates * Minor fix * fixed ts issue * fixed e2e tests * More explorations * Making progress * Panel options and field options unified * With nested categories * Starting to find something * fix paddings * Progress * Breakthrough ux layout * Progress * Updates * New way of composing options with search * added regex search * Refactoring to react note tree * Show overrides * Adding overrides radio button support * Added popular view * Separate stat/gauge/bargauge options into value options and display options * Initial work on getting library panels into viz picker flow * Fixed issues switching to panel library panel * Move search input put of LibraryPanelsView * Changing design again to have content inside boxes * Style updates * Refactoring to fix scroll issue * Option category naming * Fixed FilterInput issue * Updated snapshots * Fix padding * Updated viz picker design * Unify library panel an viz picker card * Updated card with delete action * Major refactoring back to an object model instead of searching and filtering react node tree * More refactoring * Show option category in label when searching * Nice logic for categories rendering when searching or when only child * Make getSuggestions more lazy for DataLinksEditor * Add missing repeat options and handle conditional options * Prepping options category to be more flexibly and control state from outside * Added option count to search result * Minor style tweak * Added button to close viz picker * Rewrote overrides to enable searching overrides * New search engine and tests * Searching overrides works * Hide radio buttons while searching * Added angular options back * Added memoize for all options so they are not rebuilt for every search key stroke * Added back support for category counters * Started unit test work * Refactoring and base popular options list * Initial update to e2e test, more coming to add e2e test for search features * Minor fix * Review updates * Fixing category open states * Unit test progress * Do not show visualization list mode radio button if library panels is not enabled * Use boolean * More unit tests * Increase library panels per page count and give search focus when switching list mode * field config change test and search test * Feedback updates * Minor tweaks * Minor refactorings * More minimal override collapse state	5 years ago
Dominik Prokop	a55a272276	Routing NG: Replace Angular routing with react-router (#31463) ... * Add router packages * Get react app root work instead of Angular one * Logger util * Patch Angular routing ($routeProvider, $routeParamsProvider) * Use react-router-dom history instead of separate dependency * Add test routes * Sidemenu - use Link instead of anchors * Patch Angular $location service (stub) * WIP: geting rid of $location provider from TimeSrv * Intercept anchor clicks to use history under the hood * Sync Redux location slice with history state * Make login/logout work * Debug routes for testing * Make force login work * Make sure query param change does not recreate page components * Hide side menu in specified locations * Make the dashboar route query parameters work, make panel edit menu work * Enable more routes * Fix side menu * Handle view modes * Disable playlist routes * Make SafeDynamicImport work again * Bring back router-debug * Separate redux location sync from route rendering * Refactor updateLocation to thunk and move force refresh(login) to it * Fixing init dashboard issue * Support switching between dashboards without an unmount of DashboardPage * More fixes for init dashboard and panel edit * More type fixes * Moving angular location wrapper out of main LocationService, and fixing typescript issues * Fixed last typescript errors * LocationService: Move to runtime and remove getLocationService and export singleston const instead (#31523) * Moving location service implementation to runtime and removing get function and making it a package const singleton * Added test that used locationService directly * removed unused import * AngularApp: Moving angular dependencies and the app boot out of the main app into it's own file (#31525) * Fixes angular panels by calling the monkey patch * Moving angular stuff to to it's own files * udpated * Fixing clicking on divs and spans inside anchor * Moving app notifications out of angular app and removing angular directive wrapper * Moving search from angular to react and removing angular search wrapper * Clean up, tried to remove the redux location wrapper but requires a big update for DashboardPage, so adding it back * Moving AppWrapper to root to limit circular dependencies (app/core -> app/routing and back) * Open and close search now works * Hide sidemenu when in kiosk mode * Restoring some keybindings like ESC key * Removed kiosk events and simplified it, just handled through updating URL * Fixing typescript errors * Simplified GrafanaRouteComponentProps and renamed to ContainerProps * renamed back * Changed AlertRuleList to use GrafanaRouteComponentProps and location.search passed to it * Removing the reloadOnSearch property, this is not needed now for react as react by default does not unmount components when only url match or query parmas change * SafeDynamicImport causing unmount un every search update, not sure how to fix yet * Fix signature for SafeDynamicImport so we do not create new route components on every route render * Removing the redux location wrapper as it was causing errors, and making dashboard page work with RouteProps (location, match) etc * Updating DashboardPage and SoloPanelPage to use match params and history location * Fixed DashboardPage tests * Fixing solo route tests * LocationService: Rename getCurrentLocation to just getLocation * do not intercept link clicks with target blank or self * Experimental useUrlParams hook * Update DataSourceSettingsPage to use router match params * fix links with urls that have no starting / to work like before * Fix forceLogin * Add queryParams to GrafanaRouteComponentProps * PanelEditor get rid of updateLocation and location state * Improve grafana route query params typing * Add getSearchObject to LocationService * Use DashboardPAge queryParams instead of location.search parsing * Fix DashboardPage typing * Fix some tests weirdness * Bring back KeyboardSrv * Fixes typescript issues * Team pages now use router match params * Get rid of from GrafanaRouteComponent props * Removed unnessary calls to getSearchObject when calling locationService.partial * Updated DashboardPage tests after queryParams was added * Fixing dashboard settings back * GrafanaRoute: Adding tests and remove use of global locationService * Fixing tests and typescript errors * Bring back kiosk modes and add tests * Fix TimeSrv tests * Fix typecheck errors * Fixing tests * Updated SideMenu test to react-testing and wrapped component in Router, and fixed issue importing createMemoryHistory * Get rid of routeChange event from TimeSrv from * Fixed TopSectionItem test * Trying to make basename work but failing * Update TopSectionItem snapshot * Fix TopSectionItem snapshot test * Fix API keys creation * Remove Angular dependencies from KeybindingSrv (#31617) * Remove Angular dependency from KeybindingsSrv * Fix tests and typecheck issues * basename is starting to work * Make dashboard save work * KeybindingSrv: Remove as angular service and no usage angular scope * So long bridge_srv, we won't miss you * Update snapshots * Dashboard: Refactoring ChangeTracker to use History api and no angular (#31653) * Dashboard: Refactoring ChangeTracker to use History api and no angular * Updated * Removed logging * fixed unit tests * updated snapshots * Mechanism for force reloading routes (#31683) * e2e: Fixes various things in e2e scenarios after router migration (#31685) * Explore: Update reading query params from router props and updating location via locationService (ReactRouter) (#31688) * RoutingNG: Initial explore redux location to router location migration * Updated explore Wrapper tests * Fixing more tests * remove loggin * rename back to make naming consistent * Fixing return to dashboard button * fixing navigation to explore from dashboard * updated routeProps * Updated tests * Make DashboardListPage work * Fixing navigation after add new data source, and fixes explore e2e * Fixing solo panel page * PluginsPage now works * RoutingNG: When parsing and rendering url search/query params preseve old logic of handling booleans and arrays (#31725) * RoutingNG: When parsing and rendering url search/query params preserve old logic of handling booleans and arrays * Fixed test * Make snapshots list work * fixed alert notification channel edit page * Simplify LocationService, did not need special handling for login or forceLogin as target _self on link already handles that * fixed UserAdminPage * fixed edit orgs page * Fixing LdapPage * fixing dashboard import * Fixed new folder page * Fixed data source dashboards page * fixing Folder permissions and folder settings page * fixing snapshot list page nav model * remove unused file * Added placeholder page for playlist * Moved browser compatability to index-template * Restored 404/default page * Fixed reset password page * Fixed SignUpInvited page * Fixing CreateTeam, Create user page, add panel widget * Restore browwser file to make tests happy * Fixed unit tests * Removed unused import * Replacing usage of updateLocation * Fixed test * Updating search filters to use history / location service for filters * remove unused file * AppRootPage fixed * Fixing test and search issue * Changes to support enterprise extensions * remove console.log * Removing more use of redux location * Fixed signup page * removed unused old angular controllers * Fixing bugs * one final bugfix * Removed location from redux state * Fixing ts issues and tests * Fixing test issue * fixing tests * Fixing tests * removed unused stuff * Fixed search test * Adding some doc comments * Routing NG: Angular location provider patch (#31773) * Patch Angulars $location provider * Update public/app/angular/bridgeReactAngularRouting.ts * Remove only test * Update tests, disable loggers in test env * Routing NG: remove $location provider usage (#31816) * Remove dashboard_loaders * Remove $location from Analytics service, track page views form GrafanaRoute * Remove NotificationsEditCtrl * Remove Angular dependencies from uploadDashboardDirective * Update public/app/features/dashboard/containers/DashboardPage.tsx Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com> * Update public/app/features/dashboard/containers/DashboardPage.tsx Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com> * Remove unused test helpers (#31831) * Playlist react (#31829) * playlist list in react * Playlist start * Things started to work * Updated * Handle empty list * Fix ts * Fixes and kiosk mode stuff * Removed unused events * fixing ts issue * Another ts issue * Fixing tests Co-authored-by: Dominik Prokop <dominik.prokop@grafana.com> * fixed test * Update public/app/AppWrapper.tsx Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com> * Update public/app/AppWrapper.tsx Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com> * Remove Angular dependency from DashboardLoaderSrv (#31863) Co-authored-by: Torkel Ödegaard <torkel@grafana.com> Co-authored-by: Torkel Ödegaard <torkel@grafana.org> Co-authored-by: Hugo Häggmark <hugo.haggmark@grafana.com> Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com>	5 years ago
kay delaney	06a6fb405c	Library Panels: Add "Discard" button to panel save modal (#31647) ... * Library Panels: Add "Discard" button to panel save modal	5 years ago
kay delaney	9e0d84f1cf	Library Panels: Change unsaved change detection logic (#31477) ... * Library Panels: Change unsaved change detection logic Change logic from diffing panel models to setting dirty flag	5 years ago
Hugo Häggmark	d306f417d3	LibraryPanels: No save modal when user is on same dashboard (#31606)	5 years ago
kay delaney	47d2a8085b	Frontend changes for library panels feature (#30653) ... Co-authored-by: Hugo Häggmark <hugo.haggmark@gmail.com>	5 years ago
Torkel Ödegaard	02f8a139db	PanelEdit: Get rid of last remaining usage of navbar-button (#30682)	5 years ago
Torkel Ödegaard	75cb6703a6	DashboardSettings & PanelEdit: Use new PageToolbar (#30675) ... * DashboardSettings & PanelEdit: Use new PageToolbar * Update * removed back button	5 years ago
Torkel Ödegaard	72736bd2a1	PanelEdit: Update UI if panel plugin changes field config (#29898)	5 years ago
Alex Khomenko	b1a57c6f77	Chore: Automatically infer types for dashgrid connected components (#29818) ... * Refactor DashboardPanel * Refactor PanelEditor * Fix missing initializer * Update public/app/features/dashboard/components/PanelEditor/PanelEditor.tsx Co-authored-by: Torkel Ödegaard <torkel@grafana.org> * Simplify type * Remove unused type * Move prop connectors on top Co-authored-by: Torkel Ödegaard <torkel@grafana.org>	5 years ago
Peter Holmberg	6118ab415d	Alerting: Next gen Alerting page (#28397) ... * create page and sidebar entry * add components for query editor and definition * split pane things * add reducer and action * implement split pane and update ui actions * making things pretty * Unify toolbar * minor tweak to title prefix and some padding * can create definitions * fix default state * add notificaion channel * add wrappers to get correct spacing between panes * include or exclude description * implement query editor * start on query result component * update from master * some cleanup and remove expressions touch ups Co-authored-by: Torkel Ödegaard <torkel@grafana.com>	5 years ago
Torkel Ödegaard	bba1208c3d	PanelEvents: Refactors and removes unnecessary events, fixes panel editor update issue when panel options change (#29414) ... * Refactoring some events to new events * More refactoring * Make panel editor subscribe to new event * Minor change and comment added * Updated snapshot	5 years ago