79 Commits (ab6cf9e94de7e1a0811bf2eb48cdbde6136448d9)

Author	SHA1	Message	Date
Kristin Laemmert	8f6877e12a	chore: remove all remaining uses of golang.org/x/net/context (#47564) ... * chore: remove all remaining uses of golang.org/x/net/context This PR finishes the work started in #47532, replacing all calls to that package with the stdlib context and using http.NewRequestWithContext to include the context where necessary. Bonus: small formatting fixes to goimports in these files. closes #44178 * tweak: use context.Background in favor of TODO for tests	4 years ago
Will Browne	7fbc7d019a	Plugins: Core plugins register via backend factory provider (#43171) ... * refactoring store interface and init flow * fix import * fix linter * refactor resource calling * load with class * re-order args * fix tests * fix linter * remove old creator * add custom config struct * fix some tests * cleanup * fix * tackle plugins * fix linter * refactor and fix test * add connect failure error * add fix for azure, cloud monitoring and test data * restructure * remove unused err * add fake tracer for test * fix grafana ds plugin	4 years ago
idafurjes	30aa24a183	Chore: Implement OpenTelemtry in Grafana (#42674) ... * Separate Tracer interface to TracerService and Tracer * Fix lint * Fix:Make it possible to start spans for both opentracing and opentelemetry in ds proxy * Add span methods, use span interface for rest of tracing * Fix logs in tracing * Fix tests that are related to tracing * Fix resourcepermissions test * Fix some tests * Fix more tests * Add TracingService to wire cli runner * Remove GlobalTracer from bus * Renaming test function * Remove GlobalTracer from TSDB * Replace GlobalTracer in api * Adjust tests to the InitializeForTests func * Remove GlobalTracer from services * Remove GlobalTracer * Remove bus.NewTest * Remove Tracer interface * Add InitializeForBus * Simplify tests * Clean up tests * Rename TracerService to Tracer * Update pkg/middleware/request_tracing.go Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com> * Initialize tracer before passing it to SQLStore initialization in commands * Remove tests for opentracing * Set span attributes correctly, remove unnecessary trace initiliazation form test * Add tracer instance to newSQLStore * Fix changes due to rebase * Add modified tracing middleware test * Fix opentracing implementation tags Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com>	4 years ago
Will Browne	e4ba5f17dd	add core plugins thru store (#43085)	4 years ago
Yuriy Tseretyan	9139f61105	Alerting: Update alert rule migration to use expanded queries (#42493) ... * move targetData to target * use constants instead of literals. * Update comments and add tests Co-authored-by: gotjosh <josue.abreu@gmail.com>	4 years ago
Marcus Efraimsson	baab021fec	Chore: Refactor usage of legacy data contracts (#41218) ... Refactor usage of legacy data contracts. Moves legacy data contracts to pkg/tsdb/legacydata package. Refactor pkg/expr to be a proper service/dependency that can be provided to wire to remove some unneeded dependencies to SSE in ngalert and other places. Refactor pkg/expr to not use the legacydata,RequestHandler and use backend.QueryDataHandler instead.	4 years ago
Will Browne	b80fbe03f0	Plugins: Refactor Plugin Management (#40477) ... * add core plugin flow * add instrumentation * move func * remove cruft * support external backend plugins * refactor + clean up * remove comments * refactor loader * simplify core plugin path arg * cleanup loggers * move signature validator to plugins package * fix sig packaging * cleanup plugin model * remove unnecessary plugin field * add start+stop for pm * fix failures * add decommissioned state * export fields just to get things flowing * fix comments * set static routes * make image loading idempotent * merge with backend plugin manager * re-use funcs * reorder imports + remove unnecessary interface * add some TODOs + remove unused func * remove unused instrumentation func * simplify client usage * remove import alias * re-use backendplugin.Plugin interface * re order funcs * improve var name * fix log statements * refactor data model * add logic for dupe check during loading * cleanup state setting * refactor loader * cleanup manager interface * add rendering flow * refactor loading + init * add renderer support * fix renderer plugin * reformat imports * track errors * fix plugin signature inheritance * name param in interface * update func comment * fix func arg name * introduce class concept * remove func * fix external plugin check * apply changes from pm-experiment * fix core plugins * fix imports * rename interface * comment API interface * add support for testdata plugin * enable alerting + use correct core plugin contracts * slim manager API * fix param name * fix filter * support static routes * fix rendering * tidy rendering * get tests compiling * fix install+uninstall * start finder test * add finder test coverage * start loader tests * add test for core plugins * load core + bundled test * add test for nested plugin loading * add test files * clean interface + fix registering some core plugins * refactoring * reformat and create sub packages * simplify core plugin init * fix ctx cancel scenario * migrate initializer * remove Init() funcs * add test starter * new logger * flesh out initializer tests * refactoring * remove unused svc * refactor rendering flow * fixup loader tests * add enabled helper func * fix logger name * fix data fetchers * fix case where plugin dir doesn't exist * improve coverage + move dupe checking to loader * remove noisy debug logs * register core plugins automagically * add support for renderer in catalog * make private func + fix req validation * use interface * re-add check for renderer in catalog * tidy up from moving to auto reg core plugins * core plugin registrar * guards * copy over core plugins for test infra * all tests green * renames * propagate new interfaces * kill old manager * get compiling * tidy up * update naming * refactor manager test + cleanup * add more cases to finder test * migrate validator to field * more coverage * refactor dupe checking * add test for plugin class * add coverage for initializer * split out rendering * move * fixup tests * fix uss test * fix frontend settings * fix grafanads test * add check when checking sig errors * fix enabled map * fixup * allow manual setup of CM * rename to cloud-monitoring * remove TODO * add installer interface for testing * loader interface returns * tests passing * refactor + add more coverage * support 'stackdriver' * fix frontend settings loading * improve naming based on package name * small tidy * refactor test * fix renderer start * make cloud-monitoring plugin ID clearer * add plugin update test * add integration tests * don't break all if sig can't be calculated * add root URL check test * add more signature verification tests * update DTO name * update enabled plugins comment * update comments * fix linter * revert fe naming change * fix errors endpoint * reset error code field name * re-order test to help verify * assert -> require * pm check * add missing entry + re-order * re-check * dump icon log * verify manager contents first * reformat * apply PR feedback * apply style changes * fix one vs all loading err * improve log output * only start when no signature error * move log * rework plugin update check * fix test * fix multi loading from cfg.PluginSettings * improve log output #2 * add error abstraction to capture errors without registering a plugin * add debug log * add unsigned warning * e2e test attempt * fix logger * set home path * prevent panic * alternate * ugh.. fix home path * return renderer even if not started * make renderer plugin managed * add fallback renderer icon, update renderer badge + prevent changes when renderer is installed * fix icon loading * rollback renderer changes * use correct field * remove unneccessary block * remove newline * remove unused func * fix bundled plugins base + module fields * remove unused field since refactor * add authorizer abstraction * loader only returns plugins expected to run * fix multi log output	4 years ago
Arve Knudsen	78596a6756	Migrate to Wire for dependency injection (#32289) ... Fixes #30144 Co-authored-by: dsotirakis <sotirakis.dim@gmail.com> Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com> Co-authored-by: Ida Furjesova <ida.furjesova@grafana.com> Co-authored-by: Jack Westbrook <jack.westbrook@gmail.com> Co-authored-by: Will Browne <wbrowne@users.noreply.github.com> Co-authored-by: Leon Sorokin <leeoniya@gmail.com> Co-authored-by: Andrej Ocenas <mr.ocenas@gmail.com> Co-authored-by: spinillos <selenepinillos@gmail.com> Co-authored-by: Karl Persson <kalle.persson@grafana.com> Co-authored-by: Leonard Gram <leo@xlson.com>	4 years ago
Will Browne	1618d5ad6f	use most appropriate func for registering core plugins (#38497)	4 years ago
Piotr Jamróz	f7501ff77f	Graphite: Convert tag values returned as numbers to strings (#37882) ... * Convert tag values returned as numbers to string This is a bug in Graphite <= 1.1.7. Since 1.1.8 all values are converted to strings. * Simplify type conversions * Fix linting errors	4 years ago
ying-jeanne	c22905f864	Graphite: Convert to use grafana-plugin-sdk-go contracts (#35798) ... * Use Dataframes and extract tags from response * Fix timestamp conversion * Add tests for data frame conversion * Add missing RefID and simplify returning an error * draft dataframe/sdk convertion for graphite * intermedia * modify init because registration failed * Allocate memory for each data point value * Remove redundant memory aliasing * Remove redundant new line * Sort imports * Simplify returning nil values * fix lint * remove unused jsondata * add checks on query length * remove basic auth from request Co-authored-by: Piotr Jamróz <pm.jamroz@gmail.com>	5 years ago
Piotr Jamróz	faf25bc4ea	Graphite: Interpolate Graphite alerts with tags (#35887)	5 years ago
Marcus Efraimsson	348e76fc8e	Datasource: Shared HTTP client provider for core backend data sources and any data source using the data source proxy (#33439) ... Uses new httpclient package from grafana-plugin-sdk-go introduced via grafana/grafana-plugin-sdk-go#328. Replaces the GetHTTPClient, GetTransport, GetTLSConfig methods defined on DataSource model. Longer-term the goal is to migrate core HTTP backend data sources to use the SDK contracts and using httpclient.Provider for creating HTTP clients and such. Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>	5 years ago
Ryan McKinley	7627b55ef4	TSDB: add deprecation comments to many tsdb structs (#33281)	5 years ago
Arve Knudsen	b79e61656a	Introduce TSDB service (#31520) ... * Introduce TSDB service Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> Co-authored-by: Erik Sundell <erik.sundell87@gmail.com> Co-authored-by: Will Browne <will.browne@grafana.com> Co-authored-by: Torkel Ödegaard <torkel@grafana.org> Co-authored-by: Will Browne <wbrowne@users.noreply.github.com> Co-authored-by: Zoltán Bedi <zoltan.bedi@gmail.com>	5 years ago
Kyle Brandt	c9dbf5a0d0	Graphite/SSE: update graphite to work with server side expressions (#31455) ... Changes the time value of the response to be milliseconds, which I think is like the other data sources I have seen. Also if it sees the timerange values as numbers, assumes they are unixMS (and come from expressions, or our new backend.TimeRange type). When this timerange is used, the request is sent to graphite with from and until as epoch timestamps	5 years ago
Emil Hessman	874dc3d584	Chore: Rewrite tsdb graphite test to standard library (#30088)	5 years ago
Arve Knudsen	c2cad26ca9	Chore: Disable default golangci-lint filter (#29751) ... * Disable default golangci-lint filter Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> * Chore: Fix linter warnings Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	5 years ago
Arve Knudsen	574553ec7b	Chore: Fix issues found by staticcheck (#28802) ... * Fix linting issues Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	5 years ago
Arve Knudsen	a078e40238	Settings: Rename constants/variables to follow Go naming standards (#28002) ... * settings: Rename constants/variables to follow Go naming standards Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	5 years ago
Arve Knudsen	a5d9196a53	Chore/fix lint issues (#27704) ... * Chore: Fix linting issues Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	5 years ago
Arve Knudsen	41d432b5ae	Chore: Enable whitespace linter (#25903) ... Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	6 years ago
Arve Knudsen	5070f7a75b	Chore: Start harmonizing linting with plugin SDK (#25854) ... * Chore: Harmonize linting with plugin SDK Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> * Chore: Fix linting issues Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	6 years ago
Marcus Efraimsson	58cefe73ee	Datasources: Handle URL parsing error (#25742) ... Adds handling of error returned from URL parsing. Fixes #25714	6 years ago
Sofia Papagiannaki	c6829645c7	Graphite: Don't issue empty "select metric" queries (#22699) ... * Don't issue empty "select metric" queries * Update pkg/tsdb/graphite/graphite.go Co-Authored-By: Carl Bergquist <carl.bergquist@gmail.com> * Fix indentation * Add missing import Co-authored-by: Carl Bergquist <carl.bergquist@gmail.com>	6 years ago
Arve Knudsen	bb50fc5965	pkg/tsdb: Check errors (#19837) ... Check errors in pkg/tsdb.	6 years ago
zhulongcheng	2fff8f77dc	move log package to /infra (#17023) ... ref #14679 Signed-off-by: zhulongcheng <zhulongcheng.me@gmail.com>	7 years ago
Andrej Ocenas	66f6e16916	Security: Store datasource passwords encrypted in secureJsonData (#16175) ... * Store passwords in secureJsonData * Revert unnecessary refactors * Fix for nil jsonSecureData value * Remove copied encryption code from migration * Fix wrong field reference * Remove migration and provisioning changes * Use password getters in datasource proxy * Refactor password handling in datasource configs * Add provisioning warnings * Update documentation * Remove migration command, moved to separate PR * Remove unused code * Set the upgrade version * Remove unused code * Remove double reference	7 years ago
bergquist	f13263eb54	reduce loglevel to debug	7 years ago
Mario Trangoni	bb12a1bc99	pkg/tsdb/graphite/graphite.go: Fix regular expression does not contain any meta characters. ... I found this article benchmarking Replace vs Regexp, https://medium.com/codezillas/golang-replace-vs-regexp-de4e48482f53 See, $ gometalinter --vendor --deadline 10m --disable-all --enable=megacheck ./... pkg/tsdb/graphite/graphite.go:167:28⚠️ regular expression does not contain any meta characters (SA6004) (megacheck) pkg/tsdb/graphite/graphite.go:172:28⚠️ regular expression does not contain any meta characters (SA6004) (megacheck)	7 years ago
bergquist	519fd8b2ba	graphite: adds more traces for alerting	8 years ago
Andrei Kalasok	68d4211c50	grafana-10039: fix query time range ends in the past	8 years ago
bergquist	ed661767f8	follow go idiom and return error as second param	8 years ago
bergquist	a45e2ec9c3	context is reserved for go's context	8 years ago
bergquist	16b5b9f6be	make ds a param for Query	8 years ago
bergquist	7f9f388293	rename executor into tsdbqueryendpoint	8 years ago
bergquist	0229d28d64	remove unused structs	8 years ago
bergquist	55f1b36e31	refactor response flow	8 years ago
bergquist	8c8fdadb78	trace failed executions	8 years ago
bergquist	e128310045	use tags instead of logs	8 years ago
bergquist	f160ad3bc8	add trace parameters for outgoing requests	8 years ago
Carl Bergquist	2c7adccf12	Use cache for http.client in tsdb package. (#6833) ... * datasource: move caching closer to datasource struct * tsdb: use cached version of datasource http transport closes #6825	9 years ago
utkarshcmu	fc91231104	Fixed failing tests	9 years ago
utkarshcmu	33ee85ede9	Commented strange behavior of tests	9 years ago
utkarshcmu	a4a2e35bb2	Verified interval format function and gofmt check	9 years ago
bergquist	d4bc92b267	feat(tsdb): default tsdb httpclient	9 years ago
utkarshcmu	2088363bf9	Added tests for graphite alerting	9 years ago
utkarshcmu	1e8beb8983	Fixed intervalFormat for Graphite Alerting	9 years ago
Torkel Ödegaard	f1905a8485	fix(alerting): fixed issue with using nested queries in graphite query used in alerting rule, fixes #5996	9 years ago
Carl Bergquist	c38f6ff182	Make alerting notifcations sync (#6158) ... * tech(routines): move the async logic from notification to alerting notifier * tech(notification): reduce code dupe * fix(notification): dont touch the response unless its an error * feat(alerting): make alerting exeuction async but flow sync * tech(alerting): remove commented code * tech(alerting): remove unused code * tech(alerting): fix typo * tech(alerting): implement Context on EvalContext * tech(alerting): wait for all alerts to return * feat(alerting): dont allow alert responses to cancel * Revert "feat(alerting): dont allow alert responses to cancel" This reverts commit 324b006c96. * feat(alerting): give alerts some time to finish before closing down	9 years ago