75 Commits (b5379c53356769e3af5a71ab06e1bafbeff10ebc)

Author	SHA1	Message	Date
Arve Knudsen	b5379c5335	Chore: Fix SQL related Go variable naming (#28887) ... * Chore: Fix variable naming Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	5 years ago
Arve Knudsen	7897c6b7d5	Chore: Fix staticcheck issues (#28854) ... * Chore: Fix issues reported by staticcheck Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> * Undo changes Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	5 years ago
Sofia Papagiannaki	48e753d888	Alerting: Log alert warnings for obsolete notifiers when extracting alerts and remove spammy error (#28162) ... * Lower level of notification translation messages * API: Log alert warnings when saving dashboard * Remove spammy error * Rename function parameter * Apply suggestions from code review Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com> * Apply suggestions from code review * Fix test * Change alertValidator return type * Small fix * Rename symbol * Revert "Rename symbol" This reverts commit 40b619b21a. * Revert "Small fix" This reverts commit 2df8319d1d. * Revert "Change alertValidator return type" This reverts commit ad933863e3. * Revert "Fix test" This reverts commit f728ece2db. * Revert "Apply suggestions from code review" This reverts commit f35c5f52af. * Revert "Apply suggestions from code review" This reverts commit 7f95800c5f. * Revert "Rename function parameter" This reverts commit 95d3e75b00. * Revert "API: Log alert warnings when saving dashboard" This reverts commit 1ac5c3f281. * Conditionally log translation failures * Fix issue causing test to fail * Fix test * Log instead of propagating translations failures due to database errors Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>	5 years ago
jgulick48	5bc6c447e3	Alerting: Return proper status code when trying to create alert notification channel with duplicate name or uid (#28043) ... * Alerting: Return proper status code when trying to create an Alert Notification where the name or UID already exists. Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com> Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	5 years ago
Arve Knudsen	a5d9196a53	Chore/fix lint issues (#27704) ... * Chore: Fix linting issues Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	5 years ago
Agnès Toulet	0c4b7d3f5d	Alerting API: send 404 not found error and enrich delete with UID endpoint response with alert notification ID (#27550) ... * Alerting API: Send back 404 not found error for update and delete endpoints * Alerting API: send back alert notification id for delete with uid endpoint	5 years ago
Mitsuhiro Tanda	292c985b76	Alerting: Support storing sensitive notifier settings securely/encrypted (#25114) ... Support storing sensitive notification settings securely/encrypted. Move slack notifier url and api token to secure settings. Migrating slack notifier to store token and url encrypted is currently a manual process by saving an existing slack alert notification channel. saving an existing slack alert notification channel will reset the stored non-secure url and token. Closes #25113 Ref #25967 Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com>	6 years ago
Dima Ryskin	44b7f3ea1c	AlertNotifications: Translate notifications IDs to UIDs in Rule builder (#19882) ... * AlertNotifications: Translate notifications IDs to UIDs in alert Rule builder * Avoid shadowing errors, raise validation error on non-existing notification id * create a cache for notification Uids to minimize db overhead * add cache usage test * avoid caching empty notification Uids * isolate db in alert notificationUid caching tests	6 years ago
Carl Bergquist	f9962eabff	chore: avoid aliasing imports in services (#22499)	6 years ago
Arve Knudsen	2a78d2a61c	pkg/services: Check errors (#19712) ... * pkg/services: Check errors * pkg/services: Don't treat context.Canceled|context.DeadlineExceeded as error	6 years ago
Oleg Gaidarenko	54c1bf0cc9	Chore: a bit of spring cleaning (#16710) ... * Chore: use early return technic everywhere And enable "indent-error-flow" revive rule * Chore: remove if-return rule from revive config * Chore: improve error messages And enable "error-strings" revive rule * Chore: enable "error-naming" revive rule * Chore: make linter happy * Chore: do not duplicate gofmt execution * Chore: make linter happy * Chore: address the pull review comments	7 years ago
Marcus Efraimsson	5da1faf454	Alerting: Notification channel http api fixes (#16379) ... Fixes so it's possible to create new notification channel and providing uid. Fixes better error/result handling when updating a notifcation channel. Fixes #16372 Ref #16219 #16012	7 years ago
Marcus Efraimsson	79b86466fd	Fix: Alerting Notification channel http api fixes (#16288) ... Fix so that uid can be changed when updating notification channels through the http api. Update documentation	7 years ago
Marcus Efraimsson	2ae63e70c0	Alerting: Notification channel http api enhancements (#16219) ... Now returns uid in response to get notification channel by id. Adds GET/PUT/DELETE support for notification channel by uid, /api/alert-notifications/uid/:uid. Break apart alerting and alert notification http api docs in two pages and update documentation to make it up to date with current implementation. Fixes #16012	7 years ago
Torkel Ödegaard	9a598be4f7	Fixed failing unit test	7 years ago
bergquist	e218cc7637	docs: updates docs to refer to using uid	7 years ago
Pavel Bakulev	f461d52004	Converted notification id to uid via fmt for old alert notification settings	7 years ago
Pavel Bakulev	2de32756c2	Returned id for alert notifications which were created without uid	7 years ago
Pavel Bakulev	4bcace567b	Formatted errors to err	7 years ago
Pavel Bakulev	f132e929ce	Added uid for alert notifications	7 years ago
bergquist	70385119bc	removes d in disableResolvedMessage	7 years ago
Dave Waters	c4dcf5a4ee	fix gofmt, add test, correct noted concerns with default value	7 years ago
Dave Waters	6376154b16	add channel option to disable the resolved alert (OK Message) that is sent when condition returns to normal.	7 years ago
Marcus Efraimsson	418f77e70e	get or create alert notification should use transaction	7 years ago
bergquist	7b781e4c3c	use notification state id instead of notifier id	7 years ago
bergquist	67e5f62514	move version conflict logging for mark as complete to sqlstore package	7 years ago
bergquist	9022e871e3	avoid sending full notification state to pending/complete	7 years ago
bergquist	341d8af637	rename GetNotificationStateQuery to GetOrCreateNotificationStateQuery	7 years ago
bergquist	7f1d7cefc0	reminder: uses UpdatedAt to track state changes.	7 years ago
bergquist	75f832cda8	use alert state changes counter as secondary version	7 years ago
Marcus Efraimsson	1be8fb76b8	cleanup alert_notification_state when deleting alert rules and channels	7 years ago
Marcus Efraimsson	5ec086dc56	don't notify if notification state pending ... If notification state is pending and last update of state was made less than a minute ago. In the case of a grafana instance is shut down/crashes between setting pending state and before sending the notification/marks as complete this logic should allow the notification to be sent after some time instead of being left in an inconsistent state where no notifications are being sent.	7 years ago
Marcus Efraimsson	d412aafb7e	remove unused code	7 years ago
Marcus Efraimsson	67c58fa5e4	fix set sent_at on complete	7 years ago
Marcus Efraimsson	c1763508e0	handle pending and completed state for alert notifications	7 years ago
Marcus Efraimsson	69cc24ea3f	wip: test get alert notification state	7 years ago
Leonard Gram	1a75aa54de	wip: impl so that get alertstate also creates it if it does not exist	7 years ago
bergquist	15ce474639	wip	7 years ago
Marcus Efraimsson	d093244282	sqlstore: add support for checking if error is constraint validation error	7 years ago
bergquist	c5278af6c4	add support for mysql and postgres unique index error codes	7 years ago
bergquist	3fab616239	implement sql queries for transactional alert reminders	7 years ago
bergquist	ff79f80685	initial rename refactoring	7 years ago
bergquist	b04052f515	alerting: move all notification conditions to defaultShouldNotify	7 years ago
Mario Trangoni	bb5aaa2dce	pkg/services/sqlstore/alert_notification.go: Simplify err check ... $ gometalinter --vendor --disable=all --enable=megacheck --deadline=10m ./... pkg/services/sqlstore/alert_notification.go:242:3⚠️ 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (megacheck)	7 years ago
Mario Trangoni	f73236f8f4	pkg/services/sqlstore: Fix x.Sql is deprecated: use SQL instead. (megacheck) ... See, $ gometalinter --vendor --disable-all --enable=megacheck --disable=gotype --deadline 6m ./... | grep SQL alert.go:43:9⚠️ x.Sql is deprecated: use SQL instead. (SA1019) (megacheck) alert_notification.go:122:12⚠️ sess.Sql is deprecated: use SQL instead. (SA1019) (megacheck) annotation.go:226:12⚠️ x.Sql is deprecated: use SQL instead. (SA1019) (megacheck) dashboard.go:228:9⚠️ x.Sql is deprecated: use SQL instead. (SA1019) (megacheck) dashboard.go:302:10⚠️ x.Sql is deprecated: use SQL instead. (SA1019) (megacheck) dashboard.go:416:9⚠️ x.Sql is deprecated: use SQL instead. (SA1019) (megacheck) dashboard.go:635:12⚠️ x.Sql is deprecated: use SQL instead. (SA1019) (megacheck) migrations/user_mig.go:137:9⚠️ sess.Sql is deprecated: use SQL instead. (SA1019) (megacheck) plugin_setting.go:29:10⚠️ x.Sql is deprecated: use SQL instead. (SA1019) (megacheck) quota.go:41:12⚠️ x.Sql is deprecated: use SQL instead. (SA1019) (megacheck) quota.go:84:13⚠️ x.Sql is deprecated: use SQL instead. (SA1019) (megacheck) quota.go:143:12⚠️ x.Sql is deprecated: use SQL instead. (SA1019) (megacheck) quota.go:186:13⚠️ x.Sql is deprecated: use SQL instead. (SA1019) (megacheck) quota.go:234:12⚠️ x.Sql is deprecated: use SQL instead. (SA1019) (megacheck) team.go:172:12⚠️ x.Sql is deprecated: use SQL instead. (SA1019) (megacheck) team.go:199:17⚠️ x.Sql is deprecated: use SQL instead. (SA1019) (megacheck) team.go:223:9⚠️ x.Sql is deprecated: use SQL instead. (SA1019) (megacheck) temp_user.go:99:10⚠️ x.Sql is deprecated: use SQL instead. (SA1019) (megacheck) temp_user.go:124:10⚠️ x.Sql is deprecated: use SQL instead. (SA1019) (megacheck) user.go:375:3⚠️ sess.Sql is deprecated: use SQL instead. (SA1019) (megacheck) user.go:377:3⚠️ sess.Sql is deprecated: use SQL instead. (SA1019) (megacheck) user.go:379:3⚠️ sess.Sql is deprecated: use SQL instead. (SA1019) (megacheck)	7 years ago
bergquist	396f8e6464	notifications: read without tran, write with tran	8 years ago
bergquist	83a12afc07	adds tests for journaling sql operations	8 years ago
bergquist	12bf5c225a	tests for defaultShouldNotify	8 years ago
bergquist	f4b089d551	notifications: make journaling ctx aware	8 years ago
bergquist	4a8e9cf93f	removes more unused code	8 years ago