206 Commits (b5429a456ca5170683a6cc310d8fd6621b6ab9be)

Author	SHA1	Message	Date
Brendan O'Handley	b5429a456c	Prometheus: Query advisor new rudderstack events (#78218) ... add event for yesno, no. of prompts per session, suggest instead	2 years ago
ismail simsek	deea9a7243	Prometheus: Fix updating timeRange on builder mode when range is changed (#78007) ... Update languageProvider timeRange when range is changed on builder mode	2 years ago
Edward Qian	9e346616d0	Set temperature to 0 for promql builder llm features (#77520) ... set temperature for openai calls	2 years ago
Gerry Boland	08f6abe4ac	PromQail: use metric type when available else use fallback heuristic (#77702) ... * PromQail: query suggester uses metric type if available * If metadata missing, use heuristic to guess metric type * Fix linter, fix histogram,summary case * Fix bug confusing metric with metric family name * Better method to fetch just metadata from datasource provider	2 years ago
Brendan O'Handley	1d38edc483	Prometheus: AI assistant add rudderstack events (#77837) ... add rudderstack events	2 years ago
ismail simsek	73f25f7ccc	Prometheus: Remove unsupported browser access mode related code (#77316) ... * Remove unused code * More cleaning * Delete more * betterer * Small import fixes * Fix unit test * Fix unit test * uncomment * Remove PromLink component since it was removed from Prometheus data source * Clean the direct/browser access code * Remove directUrl * Big cleaning * unit test fixing * cleaning * fix metric_find_query tests * clean result_transformer tests * betterer * Remove unused type * betterer	2 years ago
Alex Khomenko	25779bb6e5	Stack: Use the component from grafana/ui (#77543) ... * grafana/ui: Move Stack out of unstable * grafana/ui: Replace imports * Replace the import from experimental * Cleanup * Remove invalid prop * Add flexGrow * Remove Stack used in Field * Remove import	2 years ago
ismail simsek	f3fe63e87e	Chore: Remove unused code from prometheus datasource (#76776) ... * Remove unused code * More cleaning * Delete more * betterer * Small import fixes * Fix unit test * Fix unit test * uncomment * Have template_srv from @grafana/runtime	2 years ago
ismail simsek	df3184a94a	Prometheus: Remove timeSrv imports (#76118) ... * Remove timeSrv imports from prometheus datasource * Fix language_provider unit test * Fix datasource unit tests * Remove timeSrv imports from metric_find_query * Remove timeSrv imports * MetricsBrowser with timeRange	2 years ago
Ashley Harrison	07cc7504ee	Icon: Simplify and remove wrapping `<div>` (#76819) ... * remove wrapping div * update tests, just gotta figure out how to handle fontawesome :( * add spinner.svg which matches the font-awesome spinner * add mock for react-inlinesvg * update mock and fix some tests * fix FormField test * fix CorrelationsPage tests * increase timeout	2 years ago
Brendan O'Handley	5580d06101	Prometheus: PromQAIL frontend, drawer, feature toggle, workflow, etc. (#73020) ... * initial commit for PromQAIL * add feature toggle and start button * add drawer * set up drawer and state * fix styles and start the conditional text display * add data info list going to ai * add logos and style * metric display table style, neeed to make responsive * make feature toggle frontend only * add logic for want prompt for list or not, add helpers, addquerysuggestion type * make query suggestion component * add buttons to add or refine prompt * refactor logic to add interactions to have multiple AI or historical interactions * refactor and enable multiple questions, all flow * add colorful AI icon to drawer open button * fix linting * refactor for hooking up promQail app and only giving one suggestion * design fixes * fix next prompt button styling * historical suggestions give us 5, fixed that and some design things * hook up the api, provide defense filler if it's down, refactor lots * use query, fix linting * add metadata to explain for ai suggestions * styling fixes * give metadata for historical suggestions by parsing query on the fly * no prompt field to query-suggestion endpoint if prompt is empty * fix linting * use suggest rte for historical list, fix long code style * use suggest rte for historical list, fix long code style * fix historical bug * added prompt file * updated llm logic in explainer helper * bump @grafana/experimental from 1.7.0 to 1.7.2 * use llmservice and vectorservice * cleanup prompts + streaming explainer * promqail feature toggle: fix re-order * PromQL non-llm failback recommendation logic (#75469) * added template recommendation logic directly in helpers * also added selected labels to recommendation * PromQail: query gen: fix prompt formatting and fetch metric labels to be used (#75450) * PromQail: query gen: fix prompt formatting and fetch metric labels to be used * Code fixes as suggested * Use newly decided collection name for promql templates * Prometheus: Promqail tests and bug fixes (#75852) * add tests for drawer * refine one prompt at a time, fix css * scroll into view on interaction change * fix styles for light * disable prompt input after getting sugestions for that interaction * make buttons disappear after selecting refine prompt or show historical queries to prevent user from clicking many times * fix border radius * fix new eslint rule about css requiring objects and not template literals * add scrollIntoView for test * grafana_prometheus_promqail_explanation_feedback - add feedback rudderstack interaction for explanation * add form link to feedback for query suggestions * fix bugs * for prettier * PromQL Builder Explainer: Added promql documentation and updated prompt (#75593) * added promql documentation and updated prompt * refactor prompt generation into isolated function * updated prompt to answer with a question * removed commented code * updated metadata logic * updated documentation body logic * Prometheus: PromQAIL UI fixes (#76654) * align buttons at 16px * only autoscroll when an interaction has been added or the suggestions have been updated * add 12px below explain for suggested queries * add . after suggestion number * fix linting error * Prometheus: PromQAIL feedback improvements (#76711) * align buttons at 16px * only autoscroll when an interaction has been added or the suggestions have been updated * add 12px below explain for suggested queries * add . after suggestion number * add text indication for explanation feedback * add form for suggestion feedback, add form for not helpful explanation feedback * fix linting error * make radio button feedback required * required text, padding additions, thank you for your feedback * PromQL Builder Suggestion: Added type level templates and removed explainer steps for fallback suggestion logic (#75764) * adding more detailed templates to promql fallback suggest * remove debug logs * added missing explain logic * Fix brendan's type issue --------- Co-authored-by: Brendan O'Handley <brendan.ohandley@grafana.com> Co-authored-by: bohandley <brendan.ohandley@gmail.com> * make yarn.lock equal to current in main * fix feature toggles * fix prettier issues --------- Co-authored-by: Edward Qian <edward.qian@grafana.com> Co-authored-by: Yasir Ekinci <yas.ekinci@grafana.com> Co-authored-by: Edward Qian <edward.c.qian@gmail.com> Co-authored-by: Gerry Boland <gerboland@users.noreply.github.com>	2 years ago
ismail simsek	efec1d976a	Chore: Remove redundant code and update types (#76489) ... Remove redundant code and update types	2 years ago
Ashley Harrison	171e2c1adb	Chore: Improve typings and ignore `Graph` (#75742) ... * fix some types, ignore graph plugin as it'll be gone soon * update comments * more more more * undo renderer change * use Partial in the editor	2 years ago
Kristina	4b3d63dcdc	Correlations: Add an editor in Explore (#73315) ... * Start adding correlations editor mode * Add selector for merge conflict resolution * Enable saving * Build out new corelation helper component * flesh out save with label/description, change color * Have breadcrumb exit correlation editor mode * Add extension property to show/hide, use it for correlations * Bring in feature toggle * Remove unnecessary param * Cleanup * Parse logs json * Work on correlation edit mode bar * Tinker with a top element for the editor mode * Handle various explore state changes with correlations editor mode * WIP - add unsaved changes modal * Have correlation bar always rendered, sometimes hidden * Add various prompt modals * Clear correlations data on mode bar unmount, only use not left pane changes to count as dirty * Move special logic to explore * Remove all shouldShow logic from plugin extensions * remove grafana data changes * WIP - clean up correlations state * Interpolate data before sending to onclick * Override outline button coloring to account for dark background * More cleanup, more color tweaking * Prettier formatting, change state to refer to editor * Fix tests * More state change tweaks * ensure correlation save ability, change correlation editor state vars * fix import * Remove independent selector for editorMode, work close pane into editor exit flow * Add change datasource post action * Clean up based on PR feedback, handle closing left panel with helper better * Remove breadcrumb additions, add section and better ID to cmd palette action * Interpolate query results if it is ran with a helper with vars * Pass the datasource query along with the correlate link to ensure the datasource unique ID requirement passes * Use different onmount function to capture state of panes at time of close instead of time of mount * Fix node graph’s datalink not working * Actually commit the fix to saving * Fix saving correlations with mixed datasource to use the first query correlation UID * Add tracking * Use query datasources in mixed scenario, move exit tracking to click handler * Add correlations to a place where both can be used in the correlations editor * Be more selective on when we await the datasource get * Fix CSS to use objects * Update betterer * Add test around new decorator functionality * Add tests for decorate with correlations * Some reorganization and a few tweaks based on feedback * Move dirty state change to state function and out of component * Change the verbiage around a little * Various suggestions from Gio Co-authored-by: Giordano Ricci <me@giordanoricci.com> * More small Gio-related tweaks * Tie helper data to datasource - clear it out when the datasource changes * Missed another Gio tweak * Fix linter error * Only clear helper data on left pane changes * Add height offset for correlation editor bar so it doesn’t scroll off page --------- Co-authored-by: Piotr Jamróz <pm.jamroz@gmail.com> Co-authored-by: Giordano Ricci <me@giordanoricci.com>	2 years ago
Galen Kistler	8336b8d4c1	Prometheus: Query builder - show warning when converting ambiguous order of operations (#75256) ... * throw error when converting into visual query when parser detects that an aggregation expression node contains a function that contains a binary expression to detect queries that are ambiguously parsed	2 years ago
Galen Kistler	ac98197132	Loki Query Builder: binary expression and numeric literal bugs (#74950) ... * Following similar changes made to prometheus in #47198, reverse the order of binary operator parameter array, and fix bugs introduced by importing prometheus lezer constants into loki parser * add unit test asserting buildVisualQueryFromString does not properly parse queries with nested binary operations * fix onOrIgnoring parsing logic which was always stripping out the value of the matcher when a boolean was found	2 years ago
Gareth Dawson	9def0d2305	Loki: Fix timerange for query stats request (#72193) ... * call query stats with whole query * call stats when query type changes * fix stats request timerange * feedback: extract functions from component * feedback: remove "or string" types * feedback: use ds timerange picker end * partial: fix broken test * changes * update test comment * rename variable * add comment explain message prop * make getStatsTimeRange a datasource method * update tests for getStatsTimeRange * make getStats a datasource method * update failing tests * update failing tests * remove import * Update public/app/plugins/datasource/loki/datasource.test.ts Co-authored-by: Ivana Huckova <30407135+ivanahuckova@users.noreply.github.com> --------- Co-authored-by: Ivana Huckova <30407135+ivanahuckova@users.noreply.github.com>	2 years ago
Brendan O'Handley	9d4b19af48	add feature tracking for regex and null metadata (#74763)	2 years ago
Ashley Harrison	0c44a6f9bb	Chore: Improve typings 🧹 (#74599) ... * various type fixes * candlestick panel type fixes * few more fixes * some fixes * more :) * moar! * undo change to SilencesFilter * undo change to configureStore	2 years ago
Matias Chomicki	9310bb632e	Loki Query Builder: ensure unique ids for labelled fields (#74398) ... * Loki Query Builder: ensure unique ids for labelled fields * Rename refactored argument	2 years ago
Galen Kistler	5ed3ddf344	Prometheus: Fix dropdowns truncating from start of array (#73643) ... * move truncating to helper function, to start of array * Prometheus: Add 1000 result warning as sticky footer in metric select (#73649) add 1000 result warning as sticky footer in metric select * Prometheus: Only show truncated results warning if results have been truncated (#73650) only show truncated warning if results have been truncated * add test to metric select --------- Co-authored-by: Brendan O'Handley <brendan.ohandley@grafana.com> Co-authored-by: bohandley <brendan.ohandley@gmail.com>	2 years ago
Ashley Harrison	e0587dfb30	Chore: Replace deprecated usage of `shape.borderRadius()` (#72672) ... * properly mark borderRadius() as deprecated, replace borderRadius() with default * undo a couple of changes * use radius.pill in FilterPill	2 years ago
Galen Kistler	831e8acf15	Prometheus: Add support for day_of_year (#72403) ... add querybuilder/code editor support for day_of_year	2 years ago
Gareth Dawson	34ee3b09de	Loki / Prometheus: Fix query builder select component in safari (#71966) ... * partial fix * remove unused import * fix that doesnt remove error message	2 years ago
Matias Chomicki	c84d689ce0	Loki: Enable Query Splitting by default (#72094) ... * lokiQuerySplitting: enable feature flag by default * Query stats: add special note for stats + splitting	2 years ago
Ashley Harrison	9852b24d61	Chore: Upgrade prettier to v3 (#71764) ... * Update dependency prettier to v3 (#71586) * Update dependency prettier to v3 * run prettier * ignore prettier update in legacy select scss * update command line arg --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com> * unplug prettier --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>	2 years ago
Ashley Harrison	5ca382c88a	Revert "Update dependency prettier to v3 (#71586)" (#71755) ... This reverts commit 2e8cd1c021.	2 years ago
renovate[bot]	2e8cd1c021	Update dependency prettier to v3 (#71586) ... * Update dependency prettier to v3 * run prettier * ignore prettier update in legacy select scss * update command line arg --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com>	2 years ago
Ashley Harrison	7a2a5dde8b	Chore: Enable remaining jsx-a11y rules (#70990) ... enabling remaining a11y rules + ignore existing violations	2 years ago
Brendan O'Handley	bb7a3be86e	Prometheus: Metrics explorer remove select dropdown behavior (#70722) ... * remove hover style from results * remove metric select keyboard interactions and highlighting for table results * update naming for metrics explorer * fix bug for match highlighting persisting when empty query	2 years ago
Ashley Harrison	9ee2cc742a	Chore: Use theme.shape.radius.circle everywhere (#70896) ... * use theme.shape.radius.circle everywhere * add useTheme2 import	2 years ago
Ashley Harrison	1441c90178	Accessibility: use `Collapse` in `QueryOptionGroup` (#70446) ... * use collapse in QueryOptionGroup * fix unit tests * fix tests after merging main * adjust padding to match	2 years ago
Brendan O'Handley	3425012ee4	Prometheus: Variable query editor improvements (#69884) ... * refactor metric select and label filters, add variables to label names dropdown * use MetricsLabelsSection in variable editor * use variable editor UI with MetricsLabelsSection * filter label names by optional metric and allow metric to be cleared * fix tests * testing types for onChangeLabels * testing types for onChangeLabels * testing types for onChangeLabels * Ismails review, remove comment and indent * wrap label filters * improved behavior for selects and inputs, add tests and document behavior	2 years ago
Galen Kistler	c1fe8e8927	Prometheus: Expr undefined at runtime (#70010) ... * null/undefined expression default to empty string	2 years ago
Galen Kistler	fb290235fd	Prometheus: Fix empty query string (expr) breaking dashboard panel (#69938) ... * empty string if query.expr is undefined or null	2 years ago
Brendan O'Handley	ba97c492f9	Prometheus: Metrics explorer usability test improvements (#69528) ... * remove infer type functionality because usability tests confirmed it was confusing/not helpful * persist button option to open modal when typing in metric select * update copy desc for setting that includes type and description in search * when filtering by type, only return metrics with defined type * give focused metric row more contrast, consistent with metric select focused option * allow selection of metrics with unknown types and undefined types * add highlighting to backend search * augment counters created from summaries with (summary) * remove type from search input setting and only search by name and description * fix test to reflect that type has been removed from the metadata input search as duplicated by the filter * add button to select metric, change wording, make table hover row consistent with grafana table * add tooltip icon with docs link for metric types that are augmented, histogram and summary * remove files slated for future refactoring * style changes based on catherine's review * remove border from settings btn, select btn increase to md, change col size in table, fix responsive inputs ui for sm screens	2 years ago
Galen Kistler	a02bf1104c	Prometheus: fix icons that are only visible on hover (#69731) ... always make icons visible instead of only showing on hover to allow users to see outline when interacting with icons via keyboard navigation	2 years ago
Laura Benz	24502c4c4a	Add tooltip to instances of IconButton (#68880) ... * refactor: tooltip is required * refactor: add tooltips * refactor: add tooltips * refactor: add tooltips * refactor: add tooltips * refactor: add tooltips * refactor: add tooltips * refactor: adjust tests * refactor: apply changes from code review * refactor: adjust component for e2e test * refactor: adjust fallback * refactor: apply changes from code review * refactor: apply changes from code review * refactor: set IconButton default as type=button and remove from use cases * refactor: remove aria-labels when duplicated and type=button from use cases * refactor: clean up * refactor: fix tests * refactor: fix type errors * refactor: remove changes in order in order to add them to a separate PR * refactor: set IconButton default as type=button * refactor: remove tooltip * refactor: apply changes requested in review	2 years ago
Brendan O'Handley	4fdccef7b3	Prometheus: Fix bug when adding a query in mixed datasource (#69424) ... default query needs to not be a function separate from ds	2 years ago
Brendan O'Handley	27c18b8c0c	Prometheus: Bug fix to check default expr is empty string to set legend format as auto (#69255) ... * check default query.expr is empty string to set default legend format * fix tests with default base query * fix tests	2 years ago
Brendan O'Handley	2e6c71fd39	Prometheus: Metric encyclopedia ux collab design (#68421) ... * add class for full story click event on open modal * move feedback link to modal top under header * move results amount to bottom left * move settings into modal, change language from exclude to include * add metadata to backend search, use toggletip for settings, clean code * style input row, remove labels and update settings button design * remove alphabet search as requested by design * display selected metric * update style warning message for labels filtered metrics * organize results footer * update table design w fixed width and sticky header * allow focus row on tab and use key Enter to select metric on keydown * add rudderstack event for disable text wrap * add messages for no metrics found, labels, search and none in data source. * filter by type placeholder * add min width to custom select option * add text wrap for long metric names * Have 4px margin b/w the search row and the 'currently selected' text. 16px between 'currently selected text' and the table * Add some padding inside the first table header row (8 pixels on all sides) * font-size of 12px for additional settings text * 4px padding between additional settings text * 24px margin between the last table cell and the pagination row * # of Results per page font size 0.85rem * 8px margin b/w the '# of results per page' and the dropdown * fix test * add infer type setting for testing * use title on icon instead of wrapping in tooltip to fix test * fix icon issue * italicize inferred types, update setting text and add icon * add space for label filters alert message * make open button style consistent with advanced datasource picker * keep copy for open modal button * refactor rudderstack interactions and add inferType * add event tracking for opening the modal * galen's feedback, fix select horizontal scroll and results perpg bug * ismail's feedback for metric types * revert button in option for accessibility(galen) and style button with ghost mode * change name to Metrics explorer * fix hover/focus styles * ismail's feedbcak, refactor hints, return empty string, remove @return * Fix icon hovering: put tooltips back in over titles on icon * make results not expand to fill table space and fix width for modal open option button	2 years ago
Ashley Harrison	c55c091145	Query Editor: Ensure dropdown menus position correctly (#69062) ... prevent showing menu until options have loaded	2 years ago
Brendan O'Handley	b7c50b3be2	Prometheus: Class added for encyclopedia on open for fullstory (#68325) ... add class to metric encyclopedia option in metric select on open for fullstory	2 years ago
Galen Kistler	a1bc1bd368	Prometheus: bug in creating autocomplete queries with labels (#68003) ... Fix bug formatting multiple prometheus labels when doing metric query	2 years ago
Brendan O'Handley	d31d1576fb	Prometheus: Metric encyclopedia improvements (#67084) ... * move to me directory and sort by relevance * refactor letter search, uFuzzy and styles out of ency * begin state refactor * refactor getMetaData useEffect call with useReducer * refactor pagination with useReducer * refactor fuzzy state for useReducer * refactor all filters for useReducer * remove haystacks arrays in favor of haystack dictionaries w object keys * refactor out functions into state helpers * switch label filter text color to work with light theme * make each row clickable to select metric * add pagination component * fix max results * make a better table with keystrokes, navigate to metric with up&down, select on enter, hide settings, make a nice button * save space, give more real esate to the table * add highlighting for fuzzy search matches * add custom button in metric select option to open metric encyclopedia * open the modal with enter keystroke * remove unnecessary actions and variables from m.e. * fix tests, clean code * remove setting of selected idx on results row when hovering * tests * rename to metrics modal and have select option same as header * reduce width for wider screens * pass in initial metrics list and remove call to labels and series in metrics modal * use createSlice from reduc toolkit to deduce actions * save the metrics modal additional settings * galen alphabet refactor suggestion * remove extra row in results table * fix storing settings, wrap in feature toggle * remove metadata check & load because metric select already handles this * Update public/app/plugins/datasource/prometheus/querybuilder/components/metrics-modal/LetterSearch.tsx Co-authored-by: Leon Sorokin <leeoniya@gmail.com> * fix styles, show cursor as pointer for select option and clickable row * taller modal for larger screens * turn off metadata settings if usebackend is selected * additional settings button space * add pipe to ufuzzy metadata search --------- Co-authored-by: Leon Sorokin <leeoniya@gmail.com>	2 years ago
Gareth Dawson	13c5aadd5d	Loki: Don't request stats with invalid query (#65287) ... * fix: dont call endpoint if invalid query * fix: use latest lezer-logql * refactor: use null instead of undefined * test: returns null when query is invalid * update	2 years ago
ismail simsek	08727b7d6c	Prometheus: Show initial hint on builder mode when metric lookup disabled (#65827) ... * Show initial hint on builder mode when metric lookup disabled * Disable MetricEncyclopedia and label request when metric lookup is disabled	2 years ago
Ashley Harrison	1261345b81	Chore: Upgrade to react 18 (#64428) ... * update react 18 related deps * fix some types * make sure we're on react-router-dom >= 5.3.3 * Use new root API * Remove StrictMode for now - react 18 double rendering causes issues * fix + ignore some @grafana/ui types * fix some more types * use renderHook from @testing-library/react in almost all cases * fix storybook types * rewrite useDashboardSave to not use useEffect * make props optional * only render if props are provided * add correct type for useCallback * make resourcepicker tests more robust * fix ModalManager rendering * fix some more unit tests * store the click coordinates in a ref as setState is NOT synchronous * fix remaining e2e tests * rewrite dashboardpage tests to avoid act warnings * undo lint ignores * fix ExpanderCell types * set SymbolCell type correctly * fix QueryAndExpressionsStep * looks like the types were actually wrong instead :D * undo this for now... * remove spinner waits * more robust tests * rewrite errorboundary test to not explicitly count the number of renders * make urlParam expect async * increase timeout in waitFor * revert ExplorePage test changes * Update public/app/features/dashboard/containers/DashboardPage.test.tsx Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com> * Update public/app/features/dashboard/containers/PublicDashboardPage.test.tsx Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com> * Update public/app/features/dashboard/containers/PublicDashboardPage.test.tsx Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com> * Update public/app/features/dashboard/containers/PublicDashboardPage.test.tsx Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com> * skip fakeTimer test, ignore table types for now + other review comments * update package peerDeps * small tweak to resourcepicker test * update lockfile... * increase timeout in sharepublicdashboard tests * ensure ExplorePaneContainer passes correct queries to initializeExplore * fix LokiContextUI test * fix unit tests * make importDashboard flow more consistent * wait for dashboard name before continuing * more test fixes * readd dashboard name to variable e2e tests * wait for switches to be enabled before clicking * fix modal rendering * don't use @testing-library/dom directly * quick fix for rendering of panels in firefox * make PromQueryField test more robust * don't wait for chartData - in react 18 this can happen before the wait code even gets executed --------- Co-authored-by: kay delaney <kay@grafana.com> Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com>	2 years ago
Galen Kistler	96e9e80739	Prometheus: Browser resource caching (#60711) ... Add cache control headers and range snapping to Prometheus resource API calls.	2 years ago
Gareth Dawson	e04278a920	Prometheus: Update capitalisation of elements (#65724) ... * update capitalization of elements * fix tests	2 years ago