32 Commits (bccc980b902987fc9a2707deca766412b47bbe2a)

Author	SHA1	Message	Date
Vadim Stepanov	bccc980b90	Alerting: Notifiication history (#107644) ... * Add unified_alerting.notification_history to ini files * Parse notification history settings * Move Loki client to a separate package * Loki client: add params for metrics and traces * add NotificationHistorian * rm writeDuration * remove RangeQuery stuff * wip * wip * wip * wip * pass notification historian in tests * unify loki settings * unify loki settings * add test * update grafana/alerting * make update-workspace * add feature toggle * fix configureNotificationHistorian * Revert "add feature toggle" This reverts commit de7af8f7 * add feature toggle * more tests * RuleUID * fix metrics test * met.Info.Set(0)	3 days ago
Yuri Tseretyan	2023821100	Alerting: update Loki backend of state history to batch requests by folder (#89865) ... * refactor `selectorString` and remove Selector struct * move code from selector string to BuildLogQuery * batch requests by folder UID * update historian annotation store to handle multiple queries * sort folder uids to make consistent queries * add logs to loki http * log batch size but not content. content is logged by the client	12 months ago
Yuri Tseretyan	559738ce6a	Alerting: Fix flaky test in historian (#89913)	1 year ago
Gabriel MABILLE	71d31397e5	Fix flaky tests (#89910)	1 year ago
Yuri Tseretyan	06d5850396	Alerting: Update alerting state history API to authorize access using RBAC (#89579) ... * add method CanReadAllRules to rule authorization service * add alias type Namespace for Folder in ngalert's models package. It implements the Namespacer interface that is used by authz logic * update state history's backends to authorize access to rules. * update Loki to add folders UIDs to query. * Update BuildLogQuery to drop filter by folders if it's too long and fall back to in-memory filtering.	1 year ago
Yuri Tseretyan	4a5aab54a5	Alerting: Add max limit for Loki query size in state history API (#89646) ... * add setting for query limit * update BuildLogQuery to return error if limit is exceeded * move tests for BuildLogQuery to separate suite	1 year ago
Alexander Weaver	8491e02caf	Alerting: Instrument outbound requests for Loki Historian and Remote Alertmanager with tracing (#89185) ... * Add TracedClient * Handle errors and status codes * Wire up tracing to normal ASH and loki annotation mapping * Add tracing to remote alertmanager * one more spot * and not or * More consistency with other grafana traces, lower cardinality name	1 year ago
Steve Simpson	fbaa847a3c	Alerting: Pass logger into NewRemoteLokiBackend. (#87029) ... Tiny refactor to allow a logger to be passed into NewRemoteLokiBackend.	1 year ago
William Wernert	48b5ac779b	Alerting/Annotations: Add annotation backend for Loki alert state history (#78156) ... * Move scope type vars to testutil package * Expose parts of state historian for use in annotation backend * Implement Loki ASH Annotation store This store will only implement the `Get` method of a RepositoryImpl since alert state history writes to Loki elsewhere. * Use interface for Loki HTTP Client * Add tests for Loki ASH Annotation store * Add missing test * Fix lint * Organize tests * Add filter tests * Improve tests * Move filter logic into outer function * Fix lint * Add comment * Fix tests * Fix lint * Rename historian store + refactor * Cleanup historian store * Fix tests * Minor cleanup * Use new `ShouldRecordAnnotation` filter * Fix logic and add tests for this check * Fix typos, remove unused variables, `< 1` -> `== 0` * More closely mimic RBAC filter from xorm to ensure correct logic * Move off weaveworks client * Address PR comments	2 years ago
Santiago	9e78faa7ba	Alerting: Add metrics to the remote Alertmanager struct (#79835) ... * Alerting: Add metrics to the remote Alertmanager struct * rephrase http_requests_failed description * make linter happy * remove unnecessary metrics * extract timed client to separate package * use histogram collector from dskit * remove weaveworks dependency * capture metrics for all requests to the remote Alertmanager (both clients) * use the timed client in the MimirAuthRoundTripper * HTTPRequestsDuration -> HTTPRequestDuration, clean up mimir client factory function * refactor * less git diff * gauge for last readiness check in seconds * initialize LastReadinesCheck to 0, tweak metric names and descriptions * add counters for sync attempts/errors * last config sync and last state sync timestamps (gauges) * change latency metric name * metric for remote Alertmanager mode * code review comments * move label constants to metrics package	2 years ago
Alexander Weaver	a8fb01a502	Swap weaveworks/common utilities for equivalents in grafana/dskit (#80051) ... * Replace histogram collector and grpc injectors * Extract request timing utility * Also vendor test file * Suppress erroneous linter warn	2 years ago
William Wernert	9171bf92bb	Alerting: Add rule ID and title to alert state history Loki entry (#79481) ... * Add rule ID and title to Loki entry * Combine related tests	2 years ago
William Wernert	f7bf818527	Alerting: Make alert state history Loki http client public (#78291) ... * Make state history Loki client public * Make historian metrics subsystem configurable	2 years ago
Alexander Weaver	8c8b3ecb5b	Alerting: Add dashboardUID and panelID query parameters for loki state history (#72119) ... * read query parameters * Generate loki query from params	2 years ago
William Wernert	4aa477f48f	Alerting: Move rule UID from Loki stream labels into log lines (#70637) ... Move rule uid into log line to reduce cardinality	2 years ago
Alexander Weaver	3634079b8f	Alerting: Attach hash of instance labels to state history log lines (#65968) ... * Add instanceID which is hash of labels * Rename field to fingerprint * Move to prometheus style signature * Appease linter	2 years ago
Alexander Weaver	cf7157f683	Alerting: Capture refID of rule's condition expression in Loki state history entries (#66419) ... * Capture condition from rule * Add test	2 years ago
Alexander Weaver	5e87ea745d	Alerting: Fix and re-enable `filters instance labels in log line` test (#65618) ... Fix and reenable test	2 years ago
Dimitris Sotirakis	e758b017d0	Alerting: Disable `filters instance labels in log line` test (#65610) ... * Disable filters instance labels in log line test * Add drone reference	2 years ago
Alexander Weaver	a416100abc	Alerting: No longer index state history log streams by instance labels (#65474) ... * Remove private labels * No longer index by instance labels * Labels are now invariant, only build them once * Remove bucketing since everything is in a single stream * Refactor statesToStreams to only return a single unified log stream * Don't query on labels that no longer exist * Move selector logic to loki layer, genericize client to work in terms of straight logQL * Add support for line-level label filters in query * Combine existing selector tests for better parallelism * Tests for logQL construction * Underscore instead of dot for unwrapping labels in logql	2 years ago
Alexander Weaver	de1637afe5	Alerting: Add alert instance labels to Loki log lines in addition to stream labels (#65403) ... Add instance labels to log line	2 years ago
Alexander Weaver	dd04757fc9	Alerting: Add "backend" label to state history writes metrics (#65395) ... * Add backend label to state history writes metrics * Update test expectations	2 years ago
Alexander Weaver	07368dec74	Alerting: Fix attachment of external labels to Loki state history log streams (#65140) ... Fix attachment of external labels, add tests	2 years ago
Alexander Weaver	bf54f2672e	Alerting: Switch to snappy-compressed-protobuf for outgoing push requests to Loki (#65077) ... * Encode with snappy, always * JSON encoder type * Headers * Copy labels formatter from promtail * Implement snappy-proto encoding * Create encoder interface, test both encoders, choose snappy-proto by default * Make encoder configurable at the LokiCfg level * Export both encoders * Touch up comment and tests * Drop unnecessary conversions after move to plain strings to appease linter	2 years ago
Alexander Weaver	cc7e5ce62e	Alerting: Fix ambiguous handling of equals in labels when bucketing Loki state history streams (#65013) ... * Use JSON instead of data.Labels string format as label repr * Drop debug log line	2 years ago
Alexander Weaver	e39d7f44c9	Alerting: Elide requests to Loki if nothing should be recorded (#65011) ... Exit early if no log streams or annotations	2 years ago
Alexander Weaver	a31672fa40	Alerting: Create new state history "fanout" backend that dispatches to multiple other backends at once (#64774) ... * Rename RecordStatesAsync to Record * Rename QueryStates to Query * Implement fanout writes * Implement primary queries * Simplify error joining * Add test for query path * Add tests for writes and error propagation * Allow fanout backend to be configured * Touch up log messages and config validation * Consistent documentation for all backend structs * Parse and normalize backend names more consistently against an enum * Touch-ups to documentation * Improve clarity around multi-record blocking * Keep primary and secondaries more distinct * Rename fanout backend to multiple backend * Simplify config keys for multi backend mode	2 years ago
Alexander Weaver	19d01dff91	Alerting: Expose Prometheus metrics for persisting state history (#63157) ... * Create historian metrics and dependency inject * Record counter for total number of state transitions logged * Track write failures * Track current number of active write goroutines * Record histogram of how long it takes to write history data * Don't copy the registerer * Adjust naming of write failures metric * Introduce WritesTotal to complement WritesFailedTotal * Measure TransitionsFailedTotal to complement TransitionsTotal * Rename all to state_history * Remove redundant Total suffix * Increment totals all the time, not just on success * Drop ActiveWriteGoroutines * Drop PersistDuration in favor of WriteDuration * Drop unused gauge * Make writes and writesFailed per org * Add metric indicating backend and a spot for future metadata * Drop _batch_ from names and update help * Add metric for bytes written * Better pairing of total + failure metric updates * Few tweaks to wording and naming * Record info metric during composition * Create fakeRequester and simple happy path test using it * Blocking test for the full historian and test for happy path metrics * Add tests for failure case metrics * Smoke test for full annotation persistence * Create test for metrics on annotation persistence, both happy and failing paths * Address linter complaints * More linter complaints * Remove unnecessary whitespace * Consistency improvements to help texts * Update tests to match new descs	2 years ago
Alexander Weaver	958fb2c50a	Alerting: Unify structs in Loki client and make them more consistent with Prometheus (#63055) ... * Use existing row struct instead of [2]string, add deserialization helper * Replace Stream struct with stream struct which is exactly the same * Drop unused status field * Don't export queryRes and queryData * Tests for custom marshalling * Rename row fields to T and V for consistency with prometheus samples * Rename row to sample	2 years ago
Jean-Philippe Quéméner	1694a35e0c	Alerting: implement loki query for alert state history (#61992) ... * Alerting: implement loki query for alert state history * extract selector building * add unit tests for selector creation * backup * give selectors their own type * build dataframe * add some tests * small changes after manual testing * use struct client * golint * more golint * Make RuleUID optional for Loki implementation * Drop initial assumption that we only have one series * Pare down to three columns, fix timestamp overflows, improve failure cases in loki responses * Embed structred log lines in the dataframe as objects rather than json strings * Include state history label filter * Remove dead code --------- Co-authored-by: Alex Weaver <weaver.alex.d@gmail.com>	2 years ago
Alexander Weaver	647f73ddc5	Alerting: Add static label to all state history entries (#62817) ... * Add static label to all state history entries * Separate label and value visually	2 years ago
Alexander Weaver	9fa28c11c5	Alerting: Usability adjustments to Loki representation of state history values (#62643) ... * Extract label merge, add test file * Extract error/NoData to first class fields, remove a layer from values * Include dashUID and panelID as line-level fields * Drop unnecessary object receiver * Add tests for stream building * Drop NoData field from log lines	2 years ago