392 Commits (bdce964df6a083b9a3c0d8a344cb39a042297955)

Author	SHA1	Message	Date
Emil Tullstedt	5c19272065	Slug: Use urlencoding to support non-ASCII characters (#70691)	2 years ago
Ieva	a65cb4d808	RBAC: remove simple RBAC disabled checks (#71137) ... * remove simple RBAC disabled checks * fixing tests * remove old AC tests	2 years ago
Jo	4821175d40	Auth: Add auth.azure_ad security improvements (#912) ... * security improvements id_token * add audience validation * add allowOrganizations * add allowOrganizations tests and documentation * add log warn on no configuration * anonymize tenant id * Apply suggestions from code review Co-authored-by: Misi <mgyongyosi@users.noreply.github.com> * Update docs/sources/setup-grafana/configure-security/configure-authentication/azuread/index.md Co-authored-by: Ieva <ieva.vasiljeva@grafana.com> * Update pkg/login/social/azuread_oauth_test.go Co-authored-by: Ieva <ieva.vasiljeva@grafana.com> * Update pkg/login/social/azuread_oauth_test.go Co-authored-by: Ieva <ieva.vasiljeva@grafana.com> * optimize key validation and add mising fields * fix missing key_id * lint * Update docs/sources/setup-grafana/configure-security/configure-authentication/azuread/index.md Co-authored-by: Misi <mgyongyosi@users.noreply.github.com> * lint docs --------- Co-authored-by: Misi <mgyongyosi@users.noreply.github.com> Co-authored-by: Ieva <ieva.vasiljeva@grafana.com>	2 years ago
Bryan Boreham	c45ff94806	Tracing: supply Grafana build version (#69733) ... * tracing: supply Grafana build version Not etcd client version. * go mod tidy	2 years ago
Andreas Deininger	95b1f3c875	Fixing typos (#70487)	2 years ago
ismail simsek	680fc85cdf	Chore: Delete unused cookie forward middleware (#70403) ... Delete unused cookie forward middleware	2 years ago
Juan Cabanas	ee73d41d24	PublicDashboards: Audit table pagination (#69823)	2 years ago
Zoltán Bedi	aedcd651fa	Test: Fix windows test for SQL data sources (#69137)	2 years ago
Will Browne	a221e1d226	Plugins: Standardize Golang enum naming convention (#69449) ... * standardize enum pattern * fix up	2 years ago
Eng Zer Jun	cf1945d0c3	Tests: use `t.Setenv` to set env vars (#69516) ... This commit replaces `os.Setenv` with `t.Setenv` in tests. The environment variable is automatically restored to its original value when the test and all its subtests complete. Reference: https://pkg.go.dev/testing#T.Setenv Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>	2 years ago
Renato Monteiro	63c26e91ee	Metrics: Update Help to mention active viewers (#63384)	2 years ago
Ieva	d8b66d5c4b	RBAC: remove some `IsDisabled` checks (#69272) ... * remove some access contorl IsDisabled() checks * cleaning up tests * update tests * linting	2 years ago
Ieva	4980b64274	RBAC: Remove legacy ac from authorization middleware (#68898) ... remove legacy AC fallback from RBAC middleware, and some unused auth logic	2 years ago
Ieva	900348f3d9	Chore: remove tests for legacy AC, update other tests to work with RBAC (#68895) ... * remove tests for legacy AC, update other tests to work with RBAC * update usage stat tests to use RBAC	2 years ago
Serge Zaitsev	6d8f9c5bf4	Chore: Remove opentracing and use opentelemetry instead (#67200) ... * remove opentracing and use otel instead * add various samplers for jaeger * remove useless test that is covered in otel now * we do not need a struct there * remove old tests * restore tests that parse various configurations * check errors in tests * Update pkg/infra/tracing/tracing_test.go fix typo Co-authored-by: Sofia Papagiannaki <1632407+papagian@users.noreply.github.com> * add test for both legacy and new config formats * use named constants --------- Co-authored-by: Sofia Papagiannaki <1632407+papagian@users.noreply.github.com>	2 years ago
Stephanie Hingtgen	255d8f3326	Plugins: Remove secure socks proxy feature toggle (#66611)	2 years ago
Eric Leijonmarck	15c9ced944	Revert "APIkeys: Add metrics for apikey endpoints (#66732)" (#66754) ... This reverts commit c505d26430.	2 years ago
Eric Leijonmarck	c505d26430	APIkeys: Add metrics for apikey endpoints (#66732) ... add metrics for apikey endpoints	2 years ago
Ryan McKinley	15b469bd12	UsageStats: Add database age and driver (#66535) ... Co-authored-by: Dan Cech <dcech@grafana.com>	2 years ago
Ryan McKinley	fef490e4f8	Analytics: Add total dashboard byte size to reporting (#66425) ... Co-authored-by: Dan Cech <dcech@grafana.com>	2 years ago
Michael Mandrus	5626461b3c	Caching: Refactor enterprise query caching middleware to a wire service (#65616) ... * define initial service and add to wire * update caching service interface * add skipQueryCache header handler and update metrics query function to use it * add caching service as a dependency to query service * working caching impl * propagate cache status to frontend in response * beginning of improvements suggested by Lean - separate caching logic from query logic. * more changes to simplify query function * Decided to revert renaming of function * Remove error status from cache request * add extra documentation * Move query caching duration metric to query package * add a little bit of documentation * wip: convert resource caching * Change return type of query service QueryData to a QueryDataResponse with Headers * update codeowners * change X-Cache value to const * use resource caching in endpoint handlers * write resource headers to response even if it's not a cache hit * fix panic caused by lack of nil check * update unit test * remove NONE header - shouldn't show up in OSS * Convert everything to use the plugin middleware * revert a few more things * clean up unused vars * start reverting resource caching, start to implement in plugin middleware * revert more, fix typo * Update caching interfaces - resource caching now has a separate cache method * continue wiring up new resource caching conventions - still in progress * add more safety to implementation * remove some unused objects * remove some code that I left in by accident * add some comments, fix codeowners, fix duplicate registration * fix source of panic in resource middleware * Update client decorator test to provide an empty response object * create tests for caching middleware * fix unit test * Update pkg/services/caching/service.go Co-authored-by: Arati R. <33031346+suntala@users.noreply.github.com> * improve error message in error log * quick docs update * Remove use of mockery. Update return signature to return an explicit hit/miss bool * create unit test for empty request context * rename caching metrics to make it clear they pertain to caching * Update pkg/services/pluginsintegration/clientmiddleware/caching_middleware.go Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com> * Add clarifying comments to cache skip middleware func * Add comment pointing to the resource cache update call * fix unit tests (missing dependency) * try to fix mystery syntax error * fix a panic * Caching: Introduce feature toggle to caching service refactor (#66323) * introduce new feature toggle * hide calls to new service behind a feature flag * remove licensing flag from toggle (misunderstood what it was for) * fix unit tests * rerun toggle gen --------- Co-authored-by: Arati R. <33031346+suntala@users.noreply.github.com> Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com>	2 years ago
Piotr Jamróz	b68be999f7	Correlations: Add usage stats about correlations (#66021) ... * Add usage stats about correlations * Add stats.correlations.count to collected stats * Expose grafana_stat_totals_correlations metric * Organize imports	2 years ago
Stephanie Hingtgen	536fad5b61	Plugins: add env variables needed for the secure socks proxy in the plugins sdk (#65878)	2 years ago
Sofia Papagiannaki	988a120d6d	Search v1: Add support for inherited folder permissions if nested folders are enabled (#63275) ... * Add features dependency to SQLBuilder * Add features dependency to AccessControlDashboardPermissionFilter * Add test for folder inheritance * Dashboard permissions: Return recursive query * Recursive query for inherited folders * Modify search builder * Adjust db.SQLBuilder * Pass flag to SQLbuilder if CTEs are supported * Add support for mysql < 8.0 * Add benchmarking for search with nested folders * Set features to AlertStore * Update pkg/infra/db/sqlbuilder.go Co-authored-by: Ieva <ieva.vasiljeva@grafana.com> * Set features to LibraryElementService * SQLBuilder tests with nested folder flag set * Apply suggestion from code review Co-authored-by: IevaVasiljeva <ieva.vasiljeva@grafana.com> Co-authored-by: Emil Tullstedt <emil.tullstedt@grafana.com>	2 years ago
Will Browne	bff9f4c890	Plugins: Move config factory to pluginsintegration package (#65716) ... * move config to pluginsintegration package * change to all plugin toggle * fixes * fixes * fix lerna * fix test	2 years ago
Sofia Papagiannaki	caac9838d8	Build: Fix Redis/Memcached integration tests (#64298) ... * Build: Fix integration cache tests * Allow REDIS_URL with scheme * Reduce cache integration tests timeout to 5m * Apply suggestion from code review * Run redis/memcached integration tests in OSS pipelines * Change redis image	2 years ago
Alexander Weaver	fb520edd72	Alerting: Use a completely isolated context for state history writes (#64989) ... * Add fresh context with timeout and same log properties, re-derive logger * Unify timeout constants * Move ctx after shortcut that got added through rebasing * Unify timeouts * Port opentracing's SpanFromContext and ContextFromSpan to the grafana tracing package * Support both opentracing and otel variants * Better document why we're creating a new ctx * Add new func to FakeSpan which was added after rebase * Support grafana-specific traceID key in both tracer implementations	2 years ago
Joan López de la Franca Beltran	87a0c95164	Rendering: Experimental support to use JWTs as auth method (#60841) ... * Rendering: Add support for auth through JWT * Goimports * Apply review suggestions * Correct feature toggle ref * Minor changes	2 years ago
Gábor Farkas	3ae39ff02b	elasticsearch: removed code related to removed esVersion field (#65439) ... elastic: remove code that references obsolete json field	2 years ago
Giuseppe Guerra	09078b14e1	Plugins: Support for distributed tracing in backend plugins SDK (#63714) ... * Tracing: Pass OTLP address and propagation format to plugins * Fix unit tests * Fix indentation * Fix plugin manager integration tests * Goimports * Pass plugin version to plugins * Do not add GF_PLUGIN_VERSION if plugin version is not set, add tests * Allow disabling plugins distributed tracing on a per-plugin basis * Moved disabled plugins to tracing.opentelemetry config section * Pre-allocate DisabledPlugins map to the correct size * Moved disable tracing setting flags in plugin settings * Renamed plugin env vars for tracing endpoint and propagation * Fix plugin initializer tests * Refactoring: Moved OpentelemetryCfg from pkg/infra to pkg/plugins * Changed GetSection to Section in parseSettingsOpentelemetry * Add tests for NewOpentelemetryCfg * Fix test case names in TestNewOpentelemetryCfg * OpenTelemetry: Remove redundant error checks	2 years ago
Serge Zaitsev	2025c1dac1	Chore: Remove result field from stats (#65166) ... remove result field from stats	2 years ago
Giuseppe Guerra	a89202eab2	Plugins: Improve instrumentation by adding metrics and tracing (#61035) ... * WIP: Plugins tracing * Trace ID middleware * Add prometheus metrics and tracing to plugins updater * Add TODOs * Add instrumented http client * Add tracing to grafana update checker * Goimports * Moved plugins tracing to middleware * goimports, fix tests * Removed X-Trace-Id header * Fix comment in NewTracingHeaderMiddleware * Add metrics to instrumented http client * Add instrumented http client options * Removed unused function * Switch to contextual logger * Refactoring, fix tests * Moved InstrumentedHTTPClient and PrometheusMetrics to their own package * Tracing middleware: handle errors * Report span status codes when recording errors * Add tests for tracing middleware * Moved fakeSpan and fakeTracer to pkg/infra/tracing * Add TestHTTPClientTracing * Lint * Changes after PR review * Tests: Made "ended" in FakeSpan private, allow calling End only once * Testing: panic in FakeSpan if span already ended * Refactoring: Simplify Grafana updater checks * Refactoring: Simplify plugins updater error checks and logs * Fix wrong call to checkForUpdates -> instrumentedCheckForUpdates * Tests: Fix wrong call to checkForUpdates -> instrumentedCheckForUpdates * Log update checks duration, use Info log level for check succeeded logs * Add plugin context span attributes in tracing_middleware * Refactor prometheus metrics as httpclient middleware * Fix call to ProvidePluginsService in plugins_test.go * Propagate context to update checker outgoing http requests * Plugin client tracing middleware: Removed operation name in status * Fix tests * Goimports tracing_middleware.go * Goimports * Fix imports * Changed span name to plugins client middleware * Add span name assertion in TestTracingMiddleware * Removed Prometheus metrics middleware from grafana and plugins updatechecker * Add span attributes for ds name, type, uid, panel and dashboard ids * Fix http header reading in tracing middlewares * Use contexthandler.FromContext, add X-Query-Group-Id * Add test for RunStream * Fix imports * Changes from PR review * TestTracingMiddleware: Changed assert to require for didPanic assertion * Lint * Fix imports	2 years ago
Dave Henderson	c0b5d2dfaa	Tracing: Support multiple OTel propagators (#61199) ... * tracing: Support multiple OTel propagators Signed-off-by: Dave Henderson <dave.henderson@grafana.com> * tracing: add TraceIDString method to fix up tests This method will be useful elsewhere if we want to log the trace ID. * improve propagation docs Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com> * doc style fix Signed-off-by: Dave Henderson <dave.henderson@grafana.com> * Use tracing.TraceIDFromContext instead of adding TraceIDString method Signed-off-by: Dave Henderson <dave.henderson@grafana.com> --------- Signed-off-by: Dave Henderson <dave.henderson@grafana.com> Co-authored-by: Bryan Boreham <bjboreham@gmail.com> Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>	2 years ago
Bryan Boreham	7731a4d6af	Tracing: Add more detail to HTTP Outgoing Request (#64757) ... Add more detail to HTTP Outgoing Request. As events rather than sub-spans, to save cluttering the view.	2 years ago
Andres Martinez Gotor	10adb1ff66	Chore: Split usagestats service (#65191)	2 years ago
Eric Leijonmarck	3cd952b8ba	Auth: Fix orgrole picker disabled if isSynced user (#64033) ... * fix: disable orgrolepicker if externaluser is synced * add disable to role picker * just took me 2 hours to center the icon * wip * fix: check externallySyncedUser for API call * remove check from store * add: tests * refactor authproxy and made tests run * add: feature toggle * set feature toggle for tests * add: IsProviderEnabled * refactor: featuretoggle name * IsProviderEnabled tests * add specific tests for isProviderEnabled * fix: org_user tests * add: owner to featuretoggle * add missing authlabels * remove fmt * feature toggle * change config * add test for a different authmodule * test refactor * gen feature toggle again * fix basic auth user able to change the org role * test for basic auth role * make err.base to error * lowered lvl of log and input mesg	2 years ago
Gabriel MABILLE	895d4cc60b	Prometheus Metrics: Add missing stat_total_teams metric (#65133) ... * Prometheus Metrics: Add missing stat_total_teams metric	2 years ago
Dan Cech	cc5211119b	switch from github.com/gofrs/uuid to github.com/google/uuid (#65016) ... * switch from github.com/gofrs/uuid to github.com/google/uuid * add golangci rule to prevent inadvertent reintroduction	2 years ago
Sofia Papagiannaki	4ee0be6fdf	Chore: Add function for detecting if the SQL driver supported CTEs (#64441) ... * Add interface method for detecting if the SQL driver supported CTEs * Update nested folder store to call RecursiveQueriesAreSupported()	2 years ago
gotjosh	02a8f62021	Alerting: Fix stats that display alert count when using unified alerting (#64852) ... * Alerting: Fix stats when using unified alerting	2 years ago
Stephanie Hingtgen	10db808ea1	Plugins: Add sql support for the secure socks proxy (#64630)	2 years ago
Carl Bergquist	6d5688ed94	remotecache: set secret service on encryptionstorage (#64849) ... Signed-off-by: bergquist <carl.bergquist@gmail.com>	2 years ago
Carl Bergquist	eb507dca89	Remotecache: rename setbytearray/getbytearray to set/get and remove codec (#64470) ... Signed-off-by: bergquist <carl.bergquist@gmail.com>	2 years ago
Ieva	ed11c32c1d	Support bundles: fix user collector permissions and format collector output (#64531) ... * fix user collector permissions and format collector output * lint	2 years ago
Jo	4ee389676e	RemoteCache: Cleanup infra remote cache (#64381) ... * add warning on Count * add usagestats service * fix typo * remove unused glog * remote cache stats collect * add encrypt usage stat * rename handler * Update pkg/infra/remotecache/remotecache.go Co-authored-by: Dan Cech <dcech@grafana.com> * Update pkg/infra/remotecache/remotecache_test.go --------- Co-authored-by: Dan Cech <dcech@grafana.com>	2 years ago
Carl Bergquist	7c55dbf37d	Remotecache: Migrates get/set calls to use bytearrays and remove get/set functions (#63525) ... Signed-off-by: bergquist <carl.bergquist@gmail.com>	2 years ago
Dan Cech	9276f11388	Chore: Add stat for remote cache config (#64276) ... * add stat for remote cache config	2 years ago
Sofia Papagiannaki	89569be3a6	SQLStore: Fix wrong usage of xorm's insert functions in tests (#63850) ... * SQLStore: Fix InsertId * Prefs: Fix Insert return value * Fix tests * Add guidelines	2 years ago
Serge Zaitsev	2f8ee38c5e	Chore: Let wire inject prometheus.Registerer (#62195) ... let wire inject prometheus.Registerer	2 years ago
zhichli	3c218d742f	Datasources: Add user_agent header customization for outgoing HTTP requests (#63769)	2 years ago