grafana

Commit Graph

Author	SHA1	Message	Date
Alexander Zobnin	bd1741653d	Annotations: Fix composite store read (#94158 ) * Annotations: Fix composite store read * Add test * check error	1 year ago
Arati R.	e399fe6d09	Folders: Set folder creation permission as part of legacy create (#94040 ) * Add folder store to dashboard permissions * Include folder store in annotation scope resolver * Add folder store when initialising library elements * Include folder store in search v2 service initialisation * Include folder store in GetInheritedScopes * Add folder store to folder permissions provider * Include cfg, folder permissions in folder service * Move setting of folder permissions for folder service create method	1 year ago
Arati R.	ed75aea21d	Folders: Export folder store implementation (#93897 ) * Export folder store implementation * Rename folder store * Add folder store as a parameter to folder service * Add folder store to dash service implementation * Fix folder store comments	1 year ago
Jeff Levin	a21a232a8e	Revert read replica POC (#93551 ) * Revert "chore: add replDB to team service (#91799)" This reverts commit `c6ae2d7999`. * Revert "experiment: use read replica for Get and Find Dashboards (#91706)" This reverts commit `54177ca619`. * Revert "QuotaService: refactor to use ReplDB for Get queries (#91333)" This reverts commit `299c142f6a`. * Revert "refactor replCfg to look more like plugins/plugin config (#91142)" This reverts commit `ac0b4bb34d`. * Revert "chore (replstore): fix registration with multiple sql drivers, again (#90990)" This reverts commit `daedb358dd`. * Revert "Chore (sqlstore): add validation and testing for repl config (#90683)" This reverts commit `af19f039b6`. * Revert "ReplStore: Add support for round robin load balancing between multiple read replicas (#90530)" This reverts commit `27b52b1507`. * Revert "DashboardStore: Use ReplDB and get dashboard quotas from the ReadReplica (#90235)" This reverts commit `8a6107cd35`. * Revert "accesscontrol service read replica (#89963)" This reverts commit `77a4869fca`. * Revert "Fix: add mapping for the new mysqlRepl driver (#89551)" This reverts commit `ab5a079bcc`. * Revert "fix: sql instrumentation dual registration error (#89508)" This reverts commit `d988f5c3b0`. * Revert "Experimental Feature Toggle: databaseReadReplica (#89232)" This reverts commit `50244ed4a1`.	1 year ago
Alexander Zobnin	5e713673e1	Annotations: Optimize search by tags (#93547 ) * Annotations: Optimize search on large number of dashboards * refactor * fix batch size * Return early if no annotations found * revert go.mod * return nil in case of error * Move default limit to the API package * fix empty access control filter * Set default limit to 100 * optimize query when number of annotations is less than limit * Update pkg/services/annotations/annotationsimpl/annotations.go Co-authored-by: Ieva <ieva.vasiljeva@grafana.com> * remove limit from store since it's set in API * set default limit in Find method (do not break tests) * Only add limit to the query if it's set * use limit trick for all searches without dashboard filter * set default page if not provided --------- Co-authored-by: Ieva <ieva.vasiljeva@grafana.com>	1 year ago
Yuri Tseretyan	f8fa5286a1	Alerting: Introduce alert rule models in storage (#93187 ) * introduce storage model for alert rule tables * remove AlertRuleVersion from models because it's not used anywhere other than in storage * update historian xorm store to use alerting store to fetch rules * fix folder tests --------- Co-authored-by: Matthew Jacobson <matthew.jacobson@grafana.com>	1 year ago
Dave Henderson	df3d8915ba	Chore: Bump Go to 1.23.0 (#92105 ) * chore: Bump Go to 1.23.0 Signed-off-by: Dave Henderson <dave.henderson@grafana.com> * update swagger files Signed-off-by: Dave Henderson <dave.henderson@grafana.com> * chore: update .bingo/README.md formatting to satisfy prettier Signed-off-by: Dave Henderson <dave.henderson@grafana.com> * chore(lint): Fix new lint errors found by golangci-lint 1.60.1 and Go 1.23 Signed-off-by: Dave Henderson <dave.henderson@grafana.com> * keep golden file * update openapi * add name to expected output * chore(lint): rearrange imports to a sensible order Signed-off-by: Dave Henderson <dave.henderson@grafana.com> --------- Signed-off-by: Dave Henderson <dave.henderson@grafana.com> Co-authored-by: Ryan McKinley <ryantxu@gmail.com>	1 year ago
Alexander Akhmetov	b2eeb0dd6e	Alerting: update rule versions on folder move (#88376 ) * Alerting: update rule versions on folder move (#88361) * Add tracing to folder.Move and folder.Update	1 year ago
Ieva	2e2ddc5c42	Folders: Allow folder editors and admins to create subfolders without any additional permissions (#91215 ) * separate permissions for root level folder creation and subfolder creation * fix tests * fix tests * fix tests * frontend fix * Update pkg/api/accesscontrol.go Co-authored-by: Eric Leijonmarck <eric.leijonmarck@gmail.com> * fix frontend when action sets are disabled --------- Co-authored-by: Eric Leijonmarck <eric.leijonmarck@gmail.com>	1 year ago
Yuri Tseretyan	2023821100	Alerting: update Loki backend of state history to batch requests by folder (#89865 ) * refactor `selectorString` and remove Selector struct * move code from selector string to BuildLogQuery * batch requests by folder UID * update historian annotation store to handle multiple queries * sort folder uids to make consistent queries * add logs to loki http * log batch size but not content. content is logged by the client	1 year ago
Kristin Laemmert	8a6107cd35	DashboardStore: Use ReplDB and get dashboard quotas from the ReadReplica (#90235 ) * Use ReplDB in dashboard store and update all fixtures - no other changes * just moving dashboard counts for now * find the missing test fixture	1 year ago
Alexander Zobnin	87d86e81ce	Zanzana: Evaluate permissions alongside with RBAC engine (#90064 ) * Zanzana: Evaluate permissions if feature flag enabled * Fix tests * adjust logs * fix spelling * remove unused * only evaluate implemented resources * refactor	2 years ago
Jeff Levin	cfe8317d45	Add auth spans and remove deduplication code for scopes (#89804 ) Adds more spans for timing in accesscontrol and remove permission deduplicating code after benchmarking --------- Signed-off-by: Dave Henderson <dave.henderson@grafana.com> Co-authored-by: Dave Henderson <dave.henderson@grafana.com> Co-authored-by: Ieva <ieva.vasiljeva@grafana.com>	2 years ago
Yuri Tseretyan	06d5850396	Alerting: Update alerting state history API to authorize access using RBAC (#89579 ) * add method CanReadAllRules to rule authorization service * add alias type Namespace for Folder in ngalert's models package. It implements the Namespacer interface that is used by authz logic * update state history's backends to authorize access to rules. * update Loki to add folders UIDs to query. * Update BuildLogQuery to drop filter by folders if it's too long and fall back to in-memory filtering.	2 years ago
Yuri Tseretyan	4a5aab54a5	Alerting: Add max limit for Loki query size in state history API (#89646 ) * add setting for query limit * update BuildLogQuery to return error if limit is exceeded * move tests for BuildLogQuery to separate suite	2 years ago
Alexander Weaver	8491e02caf	Alerting: Instrument outbound requests for Loki Historian and Remote Alertmanager with tracing (#89185 ) * Add TracedClient * Handle errors and status codes * Wire up tracing to normal ASH and loki annotation mapping * Add tracing to remote alertmanager * one more spot * and not or * More consistency with other grafana traces, lower cardinality name	2 years ago
Ryan McKinley	99d8025829	Chore: Move identity and errutil to apimachinery module (#89116 )	2 years ago
Ieva	167151b211	Chore: Remove use of deprecated method in AC code (#87541 ) * switch from using cfg to using featuremgmt for checking a feature toggle in AC code * merge test fixes	2 years ago
Serge Zaitsev	ad5613d7d4	Chore: Remove cfg from folder service (#87212 ) remove cfg from folder service	2 years ago
Yuri Tseretyan	052082a927	Alerting: Refactor Alert Rule Generators (#86813 )	2 years ago
Serge Zaitsev	522a98c126	Chore: Make Cfg field private in SQLStore (#85593 ) * make cfg private in sqlstore * fix db init in tests * fix case * fix folder test init * fix imports * make another Cfg private * remove another Cfg * remove unused variable * use store cfg, it has side-effects * fix mutated cfg in tests	2 years ago
Serge Zaitsev	faa1244518	Chore: Replace sqlstore with db interface (#85366 ) * replace sqlstore with db interface in a few packages * remove from stats * remove sqlstore in admin test * remove sqlstore from api plugin tests * fix another createUser * remove sqlstore in publicdashboards * remove sqlstore from orgs * clean up orguser test * more clean up in sso * clean up service accounts * further cleanup * more cleanup in accesscontrol * last cleanup in accesscontrol * clean up teams * more removals * split cfg from db in testenv * few remaining fixes * fix test with bus * pass cfg for testing inside db as an option * set query retries when no opts provided * revert golden test data * rebase and rollback	2 years ago
William Wernert	cad8190a91	Alerting/Annotations: Return nothing from historian store if filtering by tags and matchAny is false (#85488 ) * Return nothing from historian store if filtering by tag	2 years ago
William Wernert	97f37b2e6f	Alerting: Clamp Loki ASH range query to configured max_query_length (#83986 ) * Clamp range in loki http client to configured max_query_length Defaults to 721h to match Loki default	2 years ago
William Wernert	af528d2f66	Alerting/Annotations: Prevent panics from composite store jobs from crashing Grafana (#83459 ) * Don't directly use pointer to json * Don't crash entire process if a store job panics * Add debug logs when failing to parse/handle Loki entries	2 years ago
Serge Zaitsev	d0679f0993	Chore: Add support bundle for folders (#83360 ) * add support bundle for folders * fix ProvideService in tests * add a test for collector	2 years ago
Alexander Zobnin	e7a1ecca28	Annotations: Improve query performance when using dashboard filter (#83112 ) * Annotations: Improve query performance when using dashboard filter * Add dashboard id filter	2 years ago
Dan Cech	790e1feb93	Chore: Update test database initialization (#81673 ) * streamline initialization of test databases, support on-disk sqlite test db * clean up test databases * introduce testsuite helper * use testsuite everywhere we use a test db * update documentation * improve error handling * disable entity integration test until we can figure out locking error	2 years ago
William Wernert	de662810cf	Alerting: Create instance of alert rule generator in historian annotation tests (#81394 ) * Create generator variable to ensure closures have correct context	2 years ago
William Wernert	2af8158f99	Remove Loki annotation toggle (#81296 )	2 years ago
William Wernert	e74313e171	Alerting/Annotations: Return nothing from Loki historian store if query type is `annotation` (#80742 ) * Return empty slice if query type is `annotation` * Add test + fix related test	2 years ago
Alexander Weaver	68d4e8a930	Annotations: Remove extraneous, debug log messages (#80670 ) * drop log messages * Revert timer * fix returns, no need to capture vars for log lines anymore	2 years ago
Alexander Weaver	81c45bfe44	Annotations: Split cleanup into separate queries and deletes to avoid deadlocks on MySQL (#80329 ) * Split subquery when cleaning annotations * update comment * Raise batch size, now that we pay attention to it * Iterate in batches * Separate cancellable batch implementation to allow for multi-statement callbacks, add overload for single-statement use * Use split-out utility in outer batching loop so it respects context cancellation * guard against empty queries * Use SQL parameters * Use same approach for tags * drop unused function * Work around parameter limit on sqlite for large batches * Bulk insert test data in DB * Refactor test to customise test data creation * Add test for catching SQLITE_MAX_VARIABLE_NUMBER limit * Turn annotation cleanup test to integration tests * lint --------- Co-authored-by: Sofia Papagiannaki <1632407+papagian@users.noreply.github.com>	2 years ago
William Wernert	48b5ac779b	Alerting/Annotations: Add annotation backend for Loki alert state history (#78156 ) * Move scope type vars to testutil package * Expose parts of state historian for use in annotation backend * Implement Loki ASH Annotation store This store will only implement the `Get` method of a RepositoryImpl since alert state history writes to Loki elsewhere. * Use interface for Loki HTTP Client * Add tests for Loki ASH Annotation store * Add missing test * Fix lint * Organize tests * Add filter tests * Improve tests * Move filter logic into outer function * Fix lint * Add comment * Fix tests * Fix lint * Rename historian store + refactor * Cleanup historian store * Fix tests * Minor cleanup * Use new `ShouldRecordAnnotation` filter * Fix logic and add tests for this check * Fix typos, remove unused variables, `< 1` -> `== 0` * More closely mimic RBAC filter from xorm to ensure correct logic * Move off weaveworks client * Address PR comments	2 years ago
William Wernert	62bdbe5b44	Annotations/Alerting: Add Loki historian store stub (#78363 ) * Add Loki historian store stub * Add composite store * Use composite store if Loki historian enabled * Split store interface into read/write * Make composite + historian stores read only * Use variadic constructor for composite * Modify Loki store enable logic * Use dskit.concurrency.ForEachJob for parallelism	2 years ago
Alexander Zobnin	959ebf82da	Folders: Show dashboards and folders with directly assigned permissions in "Shared" folder (#78465 ) * Folders: Show folders user has access to at the root level * Refactor * Refactor * Hide parent folders user has no access to * Skip expensive computation if possible * Fix tests * Fix potential nil access * Fix duplicated folders * Fix linter error * Fix querying folders if no managed permissions set * Update benchmark * Add special shared with me folder and fetch available non-root folders on demand * Fix parents query * Improve db query for folders * Reset benchmark changes * Fix permissions for shared with me folder * Simplify dedup * Add option to include shared folder permission to user's permissions * Fix nil UID * Remove duplicated folders from shared list * Folders: Fix fetching empty folder * Nested folders: Show dashboards with directly assigned permissions * Fix slow dashboards fetch * Refactor * Fix cycle dependencies * Move shared folder to models * Fix shared folder links * Refactor * Use feature flag for permissions * Use feature flag * Review comments * Expose shared folder UID through frontend settings * Add frontend type for sharedWithMeFolderUID option * Refactor: apply review suggestions * Fix parent uid for shared folder * Fix listing shared dashboards for users with access to all folders * Prevent creating folder with "shared" UID * Add tests for shared folders * Add test for shared dashboards * Fix linter * Add metrics for shared with me folder * Add metrics for shared with me dashboards * Fix tests * Tests: add metrics as a dependency * Fix access control metadata for shared with me folder * Use constant for shared with me * Optimize parent folders access check, fetch all folders in one query. * Use labels for metrics	2 years ago
Ieva	791881f910	RBAC: Change annotation filter to use dashboard based annotation scopes (#78635 ) change annotation filter to use dash based annotation scopes	2 years ago
Kat Yang	2f2ce3edbb	Chore: Deprecate ID from Folder (#78281 ) * Chore: Deprecate ID from Folder * chore: add more linter comments * chore: add missing lint comment	2 years ago
William Wernert	1a53a716e9	Annotations: Lift parts of RBAC from xorm store into auth service (#76967 ) * [WIP] Lift RBAC from xorm store * Cleanup RBAC, fix tests * Use the scope type map as a map * Remove dependency on dashboard service * Make dashboards a map for constant time lookups (useful later) --- * Lift RBAC tests into a new file to test at service level * Add necessary access resource structs to xorm store tests * Move authorization into separate service * Pass features to searchstore.Builder * Sort imports * Code cleanup * Remove useless scope type check * Lift permission check into `Authorize()` * Use clearer language when checking scope types * Include dashboard permissions in test to ensure they're ignored * Switch to errutil * Cleanup sql.Cfg refs	2 years ago
Ryan McKinley	3509a5abb9	FeatureFlags: Cleanup usage of cfg.IsFeatureToggleEnabled (#78014 )	2 years ago
Jo	c4874f97f8	Identity: Port snapshots and annotations to Requester (#76103 ) * Port snapshots to Requester * Port annotations to Requester	2 years ago
Ryan McKinley	025b2f3011	Chore: use any rather than interface{} (#74066 )	2 years ago
Ieva	6885b3d577	Chore: remove checks for whether RBAC is disabled (#73812 ) * remove checks for whether access control is disabled, as it is always enabled now * linting	2 years ago
Sofia Papagiannaki	2c26a02b82	Search v1: Remove unnecessary subqueries (#72388 ) * Add feature flag * Introduce interface and dummy implementation * Add tests for the new filter * accessControlDashboardPermissionFilterNoFolderSubquery implementation * join only if it's necessary * force ordering for tests * Temporarily enable new query for benchmarks	2 years ago
Emil Tullstedt	ab0a115372	Annotations: Improve updating annotation tags queries (#71201 ) Annotations: Improve annotation tag updates	2 years ago
Emil Tullstedt	56f52dc97e	Annotations: Fix database lock while updating annotations (#71199 )	3 years ago
Sofia Papagiannaki	04370f92dc	Annotations: Improve get tags query performance (#66182 ) * Add benchmark * Add fix	3 years ago
Sofia Papagiannaki	988a120d6d	Search v1: Add support for inherited folder permissions if nested folders are enabled (#63275 ) * Add features dependency to SQLBuilder * Add features dependency to AccessControlDashboardPermissionFilter * Add test for folder inheritance * Dashboard permissions: Return recursive query * Recursive query for inherited folders * Modify search builder * Adjust db.SQLBuilder * Pass flag to SQLbuilder if CTEs are supported * Add support for mysql < 8.0 * Add benchmarking for search with nested folders * Set features to AlertStore * Update pkg/infra/db/sqlbuilder.go Co-authored-by: Ieva <ieva.vasiljeva@grafana.com> * Set features to LibraryElementService * SQLBuilder tests with nested folder flag set * Apply suggestion from code review Co-authored-by: IevaVasiljeva <ieva.vasiljeva@grafana.com> Co-authored-by: Emil Tullstedt <emil.tullstedt@grafana.com>	3 years ago
idafurjes	982939111b	Rename Id to ID for annotation models (#62886 ) * Rename Id to ID for annotation models * Add xorm tags * Rename Id to ID for API key models * Add xorm tags	3 years ago
Serge Zaitsev	bc2813ef06	Chore: Fix goimports grouping in pkg/services (#62420 ) * fix goimports * fix goimports order	3 years ago

1 2

68 Commits (c440bd2bdaec8fed13f47fdfe76dda63e7d0008a)