grafana

Commit Graph

Author	SHA1	Message	Date
Alexander Zobnin	1366197522	Zanzana: Search with check server side (#96268 ) * pass zclient into dashboard service * Search then check implementation * Use GetNamespace() for user * remove unused orgID * simple batch check * refactor * add tests * fix batchCheckItem * client implements batch check * use batch check in search * remove unused * remove All field from response * refactor: extract checkNamespace * fix search result uniqueness * comment fix * Apply suggestions from code review Co-authored-by: Karl Persson <kalle.persson@grafana.com> * refactor * cleanup * remove unnecessary check * fix tests * fix protobuf def * Fix query page * fix type --------- Co-authored-by: Karl Persson <kalle.persson@grafana.com>	1 year ago
Ieva	0a85f15214	RBAC: Remove folder name scope resolver (#96484 ) * remove folder name scope resolver * update test	1 year ago
Ryan McKinley	2f40fd6741	Dashboards: Remove unique name constraints (#90687 )	1 year ago
William Wernert	19a9a79467	Alerting: Publish event when one or more rules are created or changed (#93637 ) * Publish event when one or more rules are changed * Publish affected rules * Use a fake bus to test publish event without listening * Wire alerting store into provisioning service	1 year ago
Arati R.	011978e81b	K8s/Folders: Remove folder service from client (#94450 ) * Support getting full path of UIDs * Use full path to set parents field * Update get folder test * Add folder store test for getting with full path UIDs * Add test for parsing parent titles * Test nested folder create payload	1 year ago
Arati R.	e399fe6d09	Folders: Set folder creation permission as part of legacy create (#94040 ) * Add folder store to dashboard permissions * Include folder store in annotation scope resolver * Add folder store when initialising library elements * Include folder store in search v2 service initialisation * Include folder store in GetInheritedScopes * Add folder store to folder permissions provider * Include cfg, folder permissions in folder service * Move setting of folder permissions for folder service create method	1 year ago
Arati R.	ed75aea21d	Folders: Export folder store implementation (#93897 ) * Export folder store implementation * Rename folder store * Add folder store as a parameter to folder service * Add folder store to dash service implementation * Fix folder store comments	1 year ago
Jeff Levin	a21a232a8e	Revert read replica POC (#93551 ) * Revert "chore: add replDB to team service (#91799)" This reverts commit `c6ae2d7999`. * Revert "experiment: use read replica for Get and Find Dashboards (#91706)" This reverts commit `54177ca619`. * Revert "QuotaService: refactor to use ReplDB for Get queries (#91333)" This reverts commit `299c142f6a`. * Revert "refactor replCfg to look more like plugins/plugin config (#91142)" This reverts commit `ac0b4bb34d`. * Revert "chore (replstore): fix registration with multiple sql drivers, again (#90990)" This reverts commit `daedb358dd`. * Revert "Chore (sqlstore): add validation and testing for repl config (#90683)" This reverts commit `af19f039b6`. * Revert "ReplStore: Add support for round robin load balancing between multiple read replicas (#90530)" This reverts commit `27b52b1507`. * Revert "DashboardStore: Use ReplDB and get dashboard quotas from the ReadReplica (#90235)" This reverts commit `8a6107cd35`. * Revert "accesscontrol service read replica (#89963)" This reverts commit `77a4869fca`. * Revert "Fix: add mapping for the new mysqlRepl driver (#89551)" This reverts commit `ab5a079bcc`. * Revert "fix: sql instrumentation dual registration error (#89508)" This reverts commit `d988f5c3b0`. * Revert "Experimental Feature Toggle: databaseReadReplica (#89232)" This reverts commit `50244ed4a1`.	1 year ago
Yuri Tseretyan	f8fa5286a1	Alerting: Introduce alert rule models in storage (#93187 ) * introduce storage model for alert rule tables * remove AlertRuleVersion from models because it's not used anywhere other than in storage * update historian xorm store to use alerting store to fetch rules * fix folder tests --------- Co-authored-by: Matthew Jacobson <matthew.jacobson@grafana.com>	1 year ago
Alexander Akhmetov	b2eeb0dd6e	Alerting: update rule versions on folder move (#88376 ) * Alerting: update rule versions on folder move (#88361) * Add tracing to folder.Move and folder.Update	1 year ago
Ieva	2e2ddc5c42	Folders: Allow folder editors and admins to create subfolders without any additional permissions (#91215 ) * separate permissions for root level folder creation and subfolder creation * fix tests * fix tests * fix tests * frontend fix * Update pkg/api/accesscontrol.go Co-authored-by: Eric Leijonmarck <eric.leijonmarck@gmail.com> * fix frontend when action sets are disabled --------- Co-authored-by: Eric Leijonmarck <eric.leijonmarck@gmail.com>	1 year ago
Ieva	c2e0952553	Folders: Improve folder move permission checks (#90588 ) * check that a user doesn't have higher plugin access on the destination folder than they have on the source folder when moving folders * Update pkg/services/folder/folderimpl/folder_test.go --------- Co-authored-by: Jo <joao.guerreiro@grafana.com>	1 year ago
Kristin Laemmert	8a6107cd35	DashboardStore: Use ReplDB and get dashboard quotas from the ReadReplica (#90235 ) * Use ReplDB in dashboard store and update all fixtures - no other changes * just moving dashboard counts for now * find the missing test fixture	1 year ago
Alexander Zobnin	87d86e81ce	Zanzana: Evaluate permissions alongside with RBAC engine (#90064 ) * Zanzana: Evaluate permissions if feature flag enabled * Fix tests * adjust logs * fix spelling * remove unused * only evaluate implemented resources * refactor	2 years ago
Sofia Papagiannaki	0afbaa39df	Dashboards: Fix restoring dashboard to root folder (#89020 ) * Fix restoring dashboard to root folder * use a root folder representation instead of nil * change root folder by general folder --------- Co-authored-by: Ezequiel Victorero <ezequiel.victorero@grafana.com>	2 years ago
Aaron Godin	59a6a6513f	Prevent moving a k6 folder (#88884 ) * iam-716 - prevent a folder move operation when the folder's uid or any of its parents uids begin with k6-app * fox folder move check and only list non-k6 folders to users * adding tests for moving * add a test for listing folders * fix the other tests * use method that adds folder parent --------- Co-authored-by: IevaVasiljeva <ieva.vasiljeva@grafana.com>	2 years ago
Sofia Papagiannaki	17ca61d7f8	Alerting: Export and provisioning rules into subfolders (#77450 ) * Folders: Optionally include fullpath in service responses * Alerting: Export folder fullpath instead of title * Escape separator in folder title * Add support for provisiong alret rules into subfolders * Use FolderService for creating folders during provisioning * Export WithFullpath() folder service function --------- Co-authored-by: Tania B <yalyna.ts@gmail.com> Co-authored-by: Yuri Tseretyan <yuriy.tseretyan@grafana.com>	2 years ago
Sofia Papagiannaki	4f999f2b6c	Dashboards: Fix regression when deleting folder (#88311 ) * Fix regression when deleting folder * Apply suggestion from code review	2 years ago
Ezequiel Victorero	42d75ac737	Dashboards: Add feature restore dashboards backend (#83131 ) Co-authored-by: Sofia Papagiannaki <1632407+papagian@users.noreply.github.com>	2 years ago
Ieva	167151b211	Chore: Remove use of deprecated method in AC code (#87541 ) * switch from using cfg to using featuremgmt for checking a feature toggle in AC code * merge test fixes	2 years ago
Serge Zaitsev	ad5613d7d4	Chore: Remove cfg from folder service (#87212 ) remove cfg from folder service	2 years ago
Serge Zaitsev	6ddb8aeae3	Chore: Moving to slog (folders) (#87000 ) * moving folders to slog * trying to fix the tests * fix per-logger filters in slog * allow using slog.Default() * bring cfg back to keep the pr small * fix tests * back to the roots	2 years ago
Serge Zaitsev	522a98c126	Chore: Make Cfg field private in SQLStore (#85593 ) * make cfg private in sqlstore * fix db init in tests * fix case * fix folder test init * fix imports * make another Cfg private * remove another Cfg * remove unused variable * use store cfg, it has side-effects * fix mutated cfg in tests	2 years ago
idafurjes	5c4a2de59b	Add FolderUID for library elements (#83819 ) * Revert "Revert "Add FolderUID for library elements" (#83776)" This reverts commit `0dfdb2ae47`. * Fix bug, dashboard id and library element fodler_id are the corresponding values Dashboard table hold both dahboards and tables	2 years ago
Dave Henderson	5687243d0b	Feature Flags: use FeatureToggles interface where possible (#85131 ) * Feature Flags: use FeatureToggles interface where possible Signed-off-by: Dave Henderson <dave.henderson@grafana.com> * Replace TestFeatureToggles with existing WithFeatures Signed-off-by: Dave Henderson <dave.henderson@grafana.com> --------- Signed-off-by: Dave Henderson <dave.henderson@grafana.com>	2 years ago
Sofia Papagiannaki	1208888bb6	Folders: Allow listing folders with write permission (#83527 ) * Folders: Allow listing folders with write permission * Check for subfolder access if parent does not have * Add test * GetFolders: fix ordering * Apply suggestion from code review	2 years ago
Gilles De Mey	8765c48389	Alerting: Remove legacy alerting (#83671 ) Removes legacy alerting, so long and thanks for all the fish! 🐟 --------- Co-authored-by: Matthew Jacobson <matthew.jacobson@grafana.com> Co-authored-by: Sonia Aguilar <soniaAguilarPeiron@users.noreply.github.com> Co-authored-by: Armand Grillet <armandgrillet@users.noreply.github.com> Co-authored-by: William Wernert <rwwiv@users.noreply.github.com> Co-authored-by: Yuri Tseretyan <yuriy.tseretyan@grafana.com>	2 years ago
owensmallwood	0dfdb2ae47	Revert "Add FolderUID for library elements" (#83776 ) Revert "Add FolderUID for library elements (#79572)" This reverts commit `2532047e7a`.	2 years ago
idafurjes	2532047e7a	Add FolderUID for library elements (#79572 ) * Add FolderUID in missing places for libraryelements * Add migration for FolderUID in library elements table * Add Folder UIDs tolibrary panels * Adjust dashboard import with folder uid * Fix lint * Rename back FolderUID to UID * Remove default * Check if folderUID is nil * Add unique indes on org_id,folder_uid,name and kind * Update pkg/services/libraryelements/database.go Co-authored-by: Sofia Papagiannaki <1632407+papagian@users.noreply.github.com> * Fix folder integration test, with unique index on library elements * Make folder uids nullable and rewrite migration query * Use dashboard uid instead of folder_uid * Adjust test --------- Co-authored-by: Sofia Papagiannaki <1632407+papagian@users.noreply.github.com>	2 years ago
Serge Zaitsev	d0679f0993	Chore: Add support bundle for folders (#83360 ) * add support bundle for folders * fix ProvideService in tests * add a test for collector	2 years ago
Ieva	4d53385d5f	RBAC: allow listing permissions on the root folder (#82184 ) * allow returning AC metadata for the root folder * add a test * share the reserved root folder UID with frontend	2 years ago
Sofia Papagiannaki	28de94f6a2	Folders: Modify folder service Get() to optionally return fullpath (#81972 ) * Folders: Modify Get() to optionally return fullpath * Set FullPath to folder title if feature flag is off * Apply suggestion from code review	2 years ago
Yuri Tseretyan	15223a4b85	Folders: Set FullPath and FullPathUIDs when feature flag is off and query requests (#81896 ) * set FullPath and FullPathUIDs if feature flag is off and query requests Co-authored-by: Sofia Papagiannaki <1632407+papagian@users.noreply.github.com>	2 years ago
Alexander Zobnin	1bcd597bc0	Nested folders: Improve performance of shared with me dashboards listing (#81590 ) * Nested folders: Improve performance of shared with me dashboards listing * Fix tests * Clean up guardian	2 years ago
Sofia Papagiannaki	89d3b55bec	Folders: Reduce DB queries when counting and deleting resources under folders (#81153 ) * Add folder store method for fetching all folder descendants * Modify GetDescendantCounts() to fetch folder descendants at once * Reduce DB calls when counting library panels under dashboard * Reduce DB calls when counting dashboards under folder * Reduce DB calls during folder delete * Modify folder registry to count/delete entities under multiple folders * Reduce DB calls when counting * Reduce DB calls when deleting	2 years ago
Yuri Tseretyan	a081abdd25	Folders: GetFolders to return empty respons if user does not have any permissions (#81304 ) add check for list of permissions	2 years ago
Sofia Papagiannaki	478d7d58fa	Nested folders: Allow creating folders with duplicate names in different locations (#77076 ) * Add API test * Add move tests * Fix create folder * Fix move * Fix test * Drop and re-create index so that allows a folder to contain a dashboard and a subfolder with same name * Get folder by title defaults to root folder and optionally fetches folder by provided parent folder * Apply suggestions from code review	2 years ago
Sofia Papagiannaki	6e827889b4	Chore: Fix folders flaky test (#81234 ) It used to wrongly assume slice ordering	2 years ago
Sofia Papagiannaki	5e88d29814	Folders: Introduce folder service function for fetching folders by org and UIDs that contain optionally the folder full path (#80716 ) * Folders: Expose function for getting all org folders with specific UIDs * Return all org folders if UIDs is empty * Filter out not accessible folders by the user * Modify query to optionally returning a string that contains the UIDs of all parent folders separated by slash.	2 years ago
Sofia Papagiannaki	4243079cb5	Folders: Fix creating/updating a folder whose title has leading and trailing spaces (#80909 ) * Add tests * Folders: Fix creating folder whose title has leading and trailing spaces * Fix folder update * Remove redundant argument * Fix test	2 years ago
idafurjes	cb419e799b	Remove folderid service test (#80433 ) * Remove FolderID from service tests * Add models * Add folderID pack to publicdashboard tests * Remove folderID from dashboard tests * Remove folderID from folders * Remove folderID from ngalert tests * Remove nolint comment * Add back some tests after rebase	2 years ago
Ryan McKinley	1caaa56de0	FeatureFlags: Use interface rather than manager (#80000 )	2 years ago
Alexander Zobnin	959ebf82da	Folders: Show dashboards and folders with directly assigned permissions in "Shared" folder (#78465 ) * Folders: Show folders user has access to at the root level * Refactor * Refactor * Hide parent folders user has no access to * Skip expensive computation if possible * Fix tests * Fix potential nil access * Fix duplicated folders * Fix linter error * Fix querying folders if no managed permissions set * Update benchmark * Add special shared with me folder and fetch available non-root folders on demand * Fix parents query * Improve db query for folders * Reset benchmark changes * Fix permissions for shared with me folder * Simplify dedup * Add option to include shared folder permission to user's permissions * Fix nil UID * Remove duplicated folders from shared list * Folders: Fix fetching empty folder * Nested folders: Show dashboards with directly assigned permissions * Fix slow dashboards fetch * Refactor * Fix cycle dependencies * Move shared folder to models * Fix shared folder links * Refactor * Use feature flag for permissions * Use feature flag * Review comments * Expose shared folder UID through frontend settings * Add frontend type for sharedWithMeFolderUID option * Refactor: apply review suggestions * Fix parent uid for shared folder * Fix listing shared dashboards for users with access to all folders * Prevent creating folder with "shared" UID * Add tests for shared folders * Add test for shared dashboards * Fix linter * Add metrics for shared with me folder * Add metrics for shared with me dashboards * Fix tests * Tests: add metrics as a dependency * Fix access control metadata for shared with me folder * Use constant for shared with me * Optimize parent folders access check, fetch all folders in one query. * Use labels for metrics	2 years ago
Sofia Papagiannaki	6d4625ad52	Alerting: Fix deleting rules in a folder with matching UID in another organization (#78258 ) * Remove usage of obsolete function for deleting alert rules under folder * Apply suggestion from code review * Update tests	2 years ago
Tania	39754ba2d6	Nested Folders: Wrap create/update operations with transactions (#78000 ) * Nested Folders: Add transaction to create and update methods * Update tests * Make IncreaseVersionForAllRulesInNamespace synchronous * Resolve merge conflicts	2 years ago
Kat Yang	2f2ce3edbb	Chore: Deprecate ID from Folder (#78281 ) * Chore: Deprecate ID from Folder * chore: add more linter comments * chore: add missing lint comment	2 years ago
Ieva	b0448b92e5	Dashboards: Allow updating a dashboard if the user doesn't have access to the parent folder (#78075 ) * change where folder checks are done for dash creation/updates * add test for folder not being found * test fixes * more test fixes * add nlint directive to where folder IDs are used * fix bad merge * fix test	2 years ago
Kat Yang	8d581b8358	Chore: Deprecate ID in GetFolderQuery (#77647 )	2 years ago
Ryan McKinley	3509a5abb9	FeatureFlags: Cleanup usage of cfg.IsFeatureToggleEnabled (#78014 )	2 years ago
Tania	6b4337a842	Nested folders: Write to folders table even if the feature toggle is off (#77788 ) * Update folders table even if the feature toggle is off * Fix failing test * Apply review feedback * Revert test changes	2 years ago

1 2

98 Commits (c440bd2bdaec8fed13f47fdfe76dda63e7d0008a)