grafana

Commit Graph

Author	SHA1	Message	Date
Peter Štibraný	c4d3eb1cd0	Remove support for Google Spanner database. (#105846 ) * Remove support for Google Spanner database.	2 months ago
Matheus Macabu	4b426238bd	Dependencies: Bump github.com/openfga/openfga from v1.8.6 to v1.8.12 (#105193 ) * Dependencies: Bump github.com/openfga/openfga from v1.8.6 to v1.8.12 * Linter: Replace x/exp/rand with math/rand/v2 * NGAlert: Fix test after linter fixes	2 months ago
Yuri Tseretyan	3e2296acd3	Alerting: Support for active time intervals in notification policies (#104252 ) * add active_time_intervals to route model * update k8s compat layer * update notification policies service to validate active time intervals * update integration tests * update openapi * add active time interval to model * update route generator to include active time interval * Update storage list and rename methods to handle active intervals * update api model * update provisioning and export models * update ui to allow active timing config * update i18n * fix snapshots for ui tests * run prettier * Alerting: Active time intervals UI naming (#104402) * update naming in UI * update naming in the edit page title * update translations * update alerting module --------- Signed-off-by: Yuri Tseretyan <yuriy.tseretyan@grafana.com> Co-authored-by: Sonia Aguilar <33540275+soniaAguilarPeiron@users.noreply.github.com> Co-authored-by: Sonia Aguilar <soniaaguilarpeiron@gmail.com>	2 months ago
Serge Zaitsev	694b9dfe50	Chore: Replace xorm.io/xorm imports (#104458 ) * replace xorm.io/xorm imports * replace xorm from other go.mod files * clean up workspace * nolint does not make sense anymore as it is not a module * try if nolint directive helps * use nolint:all for xorm * add more nolints * try to skip xorm in linter config * exclude xorm differently * retrigger ci	3 months ago
Peter Štibraný	e85acf047a	Remove use of dialect.LikeStr (#104460 ) * Fix TestIntegrationUpdatingProvisionionedDashboards* tests when running on Spanner by fixing case-insensitive search for dashboard title. * Fix use of case-insensitive LIKE when running on Spanner. * Fix use of LikeStr in anonstore. * Fix use of LikeStr in ngalert/store and org/orgimpl. * Fix use of LikeStr in queryhistory search. * Fix use of LikeStr in serviceaccounts. * Fix use of LikeStr in serviceaccounts. * Fix use of LikeStr in services/team. * Remove LikeStr method.	3 months ago
Yuri Tseretyan	14f4620835	Alerting: Optimize clean up rule versions (#102561 ) * improve removal of old versions Signed-off-by: Yuri Tseretyan <yuriy.tseretyan@grafana.com> * Apply suggestions from code review Co-authored-by: Alexander Akhmetov <me@alx.cx> --------- Signed-off-by: Yuri Tseretyan <yuriy.tseretyan@grafana.com> Co-authored-by: Alexander Akhmetov <me@alx.cx>	3 months ago
Moustafa Baiou	032299011a	Alerting: Relax permissions for access a rule (#103664 ) This makes it so that it is: - No longer required to have datasource permissions to delete a rule. - No longer required to have datasource permissions to update non-query related fields of a rule.	3 months ago
Mariell Hoversholm	757be6365a	CI: Bump golangci-lint to 2.0.2 (#103572 )	3 months ago
maicon	d8c5c2d3b8	K8s: Folders: Modify GetChildren to return only Folder References (#103072 ) * Return FolderReference instead of Folder on GetChildren Signed-off-by: Maicon Costa <maiconscosta@gmail.com> --------- Signed-off-by: Maicon Costa <maiconscosta@gmail.com>	4 months ago
Yuri Tseretyan	d10fdc0f02	Alerting: ListDeletedRules to return rules sorted by date (#102945 ) --------- Signed-off-by: Yuri Tseretyan <yuriy.tseretyan@grafana.com>	4 months ago
Peter Štibraný	5b5f433a26	spanner: Disable running alerting integration tests when using spanner. (#102730 ) * Disable running alerting integration tests when using spanner. * Disable tests for templategroup.	4 months ago
Yuri Tseretyan	69a62777c5	Fix flaky test TestIntegration_ListDeletedRules (#102383 ) Signed-off-by: Yuri Tseretyan <yuriy.tseretyan@grafana.com>	4 months ago
Yuri Tseretyan	e39b17d701	Alerting: Remove constraints for uniqueness of rule title (#102067 ) * fix having duplicated names in same group in the UI --------- Co-authored-by: Sonia Aguilar <soniaaguilarpeiron@gmail.com>	4 months ago
Alexander Akhmetov	695ac91290	Alerting: Add backend support for keep_firing_for (#100750 ) What is this feature? This PR introduces a new alert rule configuration option, keep_firing_for (Prometheus documentation). keep_firing_for prevents alerts from resolving immediately after the alert condition returns to normal. Instead, they transition into a "Recovering" state and are not considered resolved by the Alertmanager. Once the recovery period ends (or after the next evaluation if it is bigger than keep_firing_for), the alert transitions to "Normal" if it doesn't start alerting again: Before +----------+ +----------+ \| Alerting \|---->\| Normal \| +----------+ +----------+ ----- After +----------+ +------------+ +----------+ \| Alerting \|----->\| Recovering \|---->\| Normal \| +----------+ +------------+ +----------+ Why do we need this feature? This feature prevents flapping alerts by adding a recovery period. This helps avoid false resolutions caused by brief alert	4 months ago
Yuri Tseretyan	309a2eb4e9	Alerting: Allow administrators delete rules permanently via UI (#101974 ) * add query parameter to existing APIs to control the permanent deletion of rules * add GUID to gettable rule * add new endpoint /ruler/grafana/api/v1/trash/rule/guid/{RuleGUID} to delete rules from trash permanently --------- Signed-off-by: Yuri Tseretyan <yuriy.tseretyan@grafana.com>	4 months ago
Alexander Akhmetov	7dd6f52630	Alerting: Add MissingSeriesEvalsToResolve option to the AlertRule (#101184 )	4 months ago
Yuri Tseretyan	943b73a682	Alerting: Add scheduled clean-up of deleted rules (#101963 ) * add scheduled clean up of deleted rules --------- Signed-off-by: Yuri Tseretyan <yuriy.tseretyan@grafana.com>	4 months ago
Yuri Tseretyan	7e4beb2074	Alerting: API to return deleted rules (#101429 )	4 months ago
Alexander Akhmetov	0fa2dbdcdc	Alerting: Generate deterministic UID for folders created for Prometheus rule conversion (#101760 )	5 months ago
Alexander Akhmetov	aa5f2e43d4	Alerting: Use upsert to set or update provenance (#101688 ) Alerting: Use upsert to update provenance	5 months ago
Yuri Tseretyan	374380d1f6	Alerting: Keep the latest version of deleted rule in version table (#101481 ) * add feature toggle alertRuleRestore * Update delete rule to require UserUID, remove all versions and create "delete" version that holds information about who and when deleted the rule	5 months ago
Alexander Akhmetov	d44728f4e5	Alerting: Metric to count imported from Prometheus rules (#100847 )	5 months ago
Alexander Akhmetov	c7c68322b1	Alerting: Allow specifying a folder for Prometheus rule import (#101406 ) What is this feature? Allows the creation of alert rules with mimirtool in a specified folder. Why do we need this feature? Currently, the APIs for mimirtool create namespaces and rule groups in the root folder without the ability to set a custom folder. For example, it could be a special "Imported" folder, etc. This PR makes it possible with a special header: mimirtool ... --extra-headers="X-Grafana-Alerting-Folder-UID=123". If it's not present, the root folder is used, otherwise, the specified one is used. mimirtool does not support nested folder structures, while Grafana allows folder nesting. To keep compatibility, we return only direct child folders of the working folder (as namespaces) with rule groups and rules that are directly in these child folders as if there are no nested folders. For example, given this folder structure in Grafana: ``` grafana/ ├── production/ │ ├── service1/ │ │ └── alerts/ │ └── service2/ └── testing/ └── service3/ ``` If the working folder is "grafana": Only namespaces "production" and "testing" are returned Only rule groups directly within these folders are included If the working folder is "production": - Only namespaces "service1" and "service2" are returned Only rule groups directly within these folders are included	5 months ago
Yuri Tseretyan	1d54850a68	Alerting: Get alert rule versions by GUID (#101469 ) * get alert rule versions by GUID * protect guid field from accidental update	5 months ago
Yuri Tseretyan	879b121136	Alerting: Add GUID to alert rule tables (#101321 ) * add column guid to alert rule table and rule_guid to rule version table + populate the new field with UUID * update storage and domain models * patch GUID * ignore GUID in fingerprint tests	5 months ago
Alexander Akhmetov	ae2074ef55	Alerting: Fix updating Prometheus definition in the metadata (#101440 ) Initially, Metadata had only the EditorSettings, and HasMetadata was used to understand if the incoming update request had metadata in the body because it could be omitted if it was empty. For example, when the rule is updated via the provisioning API or has only false values. If it was in the request, we used that; if not, we used the metadata from the existing rule from the database. If the rule was updated via the AlertRuleService, we didn't change Metadata at all if the rule already existed. But now, Metadata also has the Prometheus rule definition, and we always need to update it with the new version of the AlertRuleService when the rule exists in the DB and has the same UID. HasMetadata is renamed to HasEditorSettings to keep the old behaviour only for EditorSettings. Now, the provisioning API and the conversion API will overwrite everything except EditorSettings with the new data.	5 months ago
Ryan McKinley	806c043e45	UnifiedStorage: Rename Batch processing to Bulk (#101413 )	5 months ago
Alexander Akhmetov	d947433d19	Alerting: API to delete rule groups using mimirtool (#100687 ) * Alerting: API to delete rule groups using mimirtool	5 months ago
Alexander Akhmetov	6eb335a8ce	Alerting: API to read rule groups using mimirtool (#100674 )	5 months ago
Alexander Akhmetov	b641fd64f9	Alerting: API to create rule groups using mimirtool (#100558 ) What is this feature? Adds an API endpoint to create alert rules with mimirtool: - POST /convert/prometheus/config/v1/rules/{NamespaceTitle} - Accepts a single rule group in a Prometheus YAML format and creates or updates a Grafana rule group from it. The endpoint uses the conversion package from #100224. Key parts The API works similarly to the provisioning API. If the rule does not exist, it will be created, otherwise updated. Any rules not present in the new group will be deleted, ensuring the group is fully synchronized with the provided configuration. Since the API works with namespace titles (folders), the handler automatically creates a folder in the root based on the provided title if it does not exist. It also requires a special header, X-Grafana-Alerting-Datasource-UID. This header specifies which datasource to use for the new rules. If the rule group's evaluation interval is not specified, it uses the DefaultRuleEvaluationInterval from settings.	5 months ago
Alexander Akhmetov	cbae35c28b	Alerting: Delete protobuf alert rule state on alert rule deletion (#100736 )	5 months ago
Yuri Tseretyan	28f21e0a0d	Alerting: Do not record rule version if no difference (#100364 )	5 months ago
Yuri Tseretyan	4cac3158c7	Alerting: Fix alert rule copy to include metadata (#100212 ) * copy metadata * add tests for copy and generator * extract copy rule to a production method and update usages * fix tests	5 months ago
Moustafa Baiou	7dee4d1808	Alerting: Allow specifying uid for new rules added to groups (#99858 ) When modifying rule groups the `uid` can be specified but only if the rule already existed in the DB. If the rule is new the update would be rejected. This updates the RuleGroup provisioning apis to allow specifying the `uid` when creating/updating rule groups. Additionally, the RuleGroupIdx was not being updated when rules were reordered in the group. Context: https://github.com/grafana/terraform-provider-grafana/pull/1971#issuecomment-2599223897 Relates to: https://github.com/grafana/terraform-provider-grafana/issues/1928 Fixes: #98283	5 months ago
Yuri Tseretyan	1b8db233a7	Alerting: Rule Version API to Ignore versions without diff (#100093 )	5 months ago
Yuri Tseretyan	68f1730461	Alerting: set updated_by for system owned operations (#100068 )	6 months ago
Yuri Tseretyan	ac41c19350	Alerting: Rule version history API (#99041 ) * implement store method to read rule versions * implement request handler * declare a new endpoint * fix fake to return correct response * add tests * add integration tests * rename history to versions * apply diff from swagger CI step Signed-off-by: Yuri Tseretyan <yuriy.tseretyan@grafana.com> --------- Signed-off-by: Yuri Tseretyan <yuriy.tseretyan@grafana.com>	6 months ago
Yuri Tseretyan	807f94b2c7	Alerting: Remove feature toggle alertingNoNormalState (#99905 )	6 months ago
Alexander Akhmetov	d6c1e3bb45	Alerting: Use org store to read organization IDs (#99938 )	6 months ago
Moustafa Baiou	b820fd6bef	Alerting: Fix Alertmanager configuration updates (#99610 ) * Alerting: Fix Alertmanager configuration updates Alertmanager configuration updates would behave inconsistently when performing no-op updates with `mysql` as the store. In particular this bug manifested as a failure to reload the provisioned alertmanager configuration components with no changes to the configuration itself. This would result in a 500 error with mysql store only. The core issue is that we were relying on the number of rows affected by the update query to determine if the configuration was found in the db or not. While this behavior works for certain sql dialects, mysql does not return the number of rows matched by the update query but rather the number of rows actually updated. Also discovered and fixed the mismatched `xorm` tag for the `CreatedAt` field to match the actual column name in the db. References: https://dev.mysql.com/doc/refman/8.4/en/update.html	6 months ago
Alexander Akhmetov	cb43f4b696	Alerting: Add compressed protobuf-based alert state storage (#99193 )	6 months ago
Yuri Tseretyan	92d6762a3a	Alerting: Store information about user that created\updated alert rule (#99395 ) * introduce new fields created_by in rule tables * update domain model and compat layer to support UpdatedBy * add alert rule generator mutators for UpdatedBy * ignore UpdatedBy in diff and hash calculation * Add user context to alert rule insert/update operations Updated InsertAlertRules and UpdateAlertRules methods to accept a user context parameter. This change ensures auditability and better tracking of user actions when creating or updating alert rules. Adjusted all relevant calls and interfaces to pass the user context accordingly. * set UpdatedBy in PreSave because this is where Updated is set * Use nil userID for system-initiated updates This ensures differentiation between system and user-initiated changes for better traceability and clarity in update origins. --------- Signed-off-by: Yuri Tseretyan <yuriy.tseretyan@grafana.com>	6 months ago
ismail simsek	e96b5a68c4	Prometheus: Support utf8 metrics and labels in scopes (#99015 ) * support utf8 in scopes * separate the utf8 tests * remove redundant test after enabling utf8 validation in prometheus	6 months ago
Alexander Akhmetov	1f8f9a45d7	Alerting: Add state_periodic_save_batch_size config option (#98019 ) * Alerting: Add state_periodic_save_batch_size config option --------- Co-authored-by: brendamuir <100768211+brendamuir@users.noreply.github.com>	7 months ago
Nihal	e73bb34cc0	Alerting: Fix Conflicting Alert Rule Response Has Wrong 'rule_uid' (#95013 ) * change to return the right conflicting alert rule uid. see https://github.com/grafana/grafana/issues/89755 Signed-off-by: wasim-nihal <sswasim64@gmail.com> * correcting the code comment Signed-off-by: wasim-nihal <sswasim64@gmail.com> * changes to return the conflicting uid for both insert and update operations Signed-off-by: wasim-nihal <sswasim64@gmail.com> * changes to return verbose conflicting alert rule response payload Signed-off-by: wasim-nihal <sswasim64@gmail.com> * changes to return verbose conflicting alert rule response payload Signed-off-by: wasim-nihal <sswasim64@gmail.com> * Update pkg/services/ngalert/store/alert_rule.go Co-authored-by: Matthew Jacobson <JacobsonMT@gmail.com> --------- Signed-off-by: wasim-nihal <sswasim64@gmail.com> Co-authored-by: Matthew Jacobson <JacobsonMT@gmail.com>	8 months ago
Alexander Akhmetov	0b804e720f	Alerting: Add RuleGroup field to ListAlertInstancesQuery struct (#94615 ) Alerting: add RuleGroup field to ListAlertInstancesQuery struct	9 months ago
William Wernert	19a9a79467	Alerting: Publish event when one or more rules are created or changed (#93637 ) * Publish event when one or more rules are changed * Publish affected rules * Use a fake bus to test publish event without listening * Wire alerting store into provisioning service	9 months ago
Alexander Akhmetov	0a4e6ff86b	Alerting: Add SaveAlertInstancesForRule instance store method (#94505 ) Alerting: Add SaveAlertInstancesForRule method to the InstanceStore interface	9 months ago
Brandon	fbad76007d	Alerting: Limit and clean up old alert rules versions (#89754 )	10 months ago
Jeff Levin	a21a232a8e	Revert read replica POC (#93551 ) * Revert "chore: add replDB to team service (#91799)" This reverts commit `c6ae2d7999`. * Revert "experiment: use read replica for Get and Find Dashboards (#91706)" This reverts commit `54177ca619`. * Revert "QuotaService: refactor to use ReplDB for Get queries (#91333)" This reverts commit `299c142f6a`. * Revert "refactor replCfg to look more like plugins/plugin config (#91142)" This reverts commit `ac0b4bb34d`. * Revert "chore (replstore): fix registration with multiple sql drivers, again (#90990)" This reverts commit `daedb358dd`. * Revert "Chore (sqlstore): add validation and testing for repl config (#90683)" This reverts commit `af19f039b6`. * Revert "ReplStore: Add support for round robin load balancing between multiple read replicas (#90530)" This reverts commit `27b52b1507`. * Revert "DashboardStore: Use ReplDB and get dashboard quotas from the ReadReplica (#90235)" This reverts commit `8a6107cd35`. * Revert "accesscontrol service read replica (#89963)" This reverts commit `77a4869fca`. * Revert "Fix: add mapping for the new mysqlRepl driver (#89551)" This reverts commit `ab5a079bcc`. * Revert "fix: sql instrumentation dual registration error (#89508)" This reverts commit `d988f5c3b0`. * Revert "Experimental Feature Toggle: databaseReadReplica (#89232)" This reverts commit `50244ed4a1`.	10 months ago

1 2 3 4 5 ...

293 Commits (c4d3eb1cd03f30ea8e6aab71b2597bf3c6a6f46f)