1861 Commits (c4d3eb1cd03f30ea8e6aab71b2597bf3c6a6f46f)

Author	SHA1	Message	Date
William Wernert	a5288db624	Alerting: Remove the POST endpoint for the internal Grafana Alertmanager config (#103819) ... * Remove POST config for Grafana Alertmanager * Delete auth + test for removed path * Alerting: Remove check for `alertingApiServer` toggle in UI (#103805) * Remove check for alertingApiServer in UI * Update tests to no longer care about alertingApiServer * Add contact points handlers now that we use alertingApiServer all the time * Fix test broken from removing camelCase for UIDs --------- Co-authored-by: Tom Ratcliffe <tom.ratcliffe@grafana.com>	3 months ago
Matthew Jacobson	9e933882ed	Alerting: Webhook Improvements - Templateable Payloads (#103818) ... * Template editor syntax highlighting when preview is json-like * Add new template editor language examples, snippets, and functions * Use updated NewTemplate function * Add new fields to webhook notifier - CustomPayload - ExtraHeaders * Documentation * Update grafana/alerting to in-progress PR (needs updating after merge) * Fix integration test * Remove docs reference to .Extra template context No longer exists, was part of a previous iteration * make update-workspace * Update grafana/alerting to actual merged commit	3 months ago
Matthew Jacobson	9f9c4b3da3	Alerting: Template preview enhancements (#103817) ... API Changes: - Fixes validation in template CRUD API to be closer to how the running alertmanager will use the template. Should remove some incorrect validation errors. - Adds some missing default placeholder labels to receiver testing that are used during template testing but missing during receiver testing Template Preview: - Replaced basic preview with a readonly CodeEditor for better whitespace and alignment clarity (also adds support for future syntax highlighting in template previews for upcoming webhook payload templates) Template Selector (Receiver Form): - Refactored to use same components as Template editor for preview. - Fixed preview to work with multi-definition templates - Fixed copy to correctly copy the template contents instead of {{ template "<name>" . }}. Template Editor: - Fixed detection of when to display functions vs snippets in multi-line expressions	3 months ago
Konrad Lalik	0a8dccc19a	Alerting: New alert list filter improvements (#103107) ... * Move filtering code to generators for performance reasons Discarding rules and groups early in the iterable chain limits the number of promises we need to wait for which improves performance significantly * Add error handling for generators * Add support for data source filter for GMA rules * search WIP fix * Fix datasource filter * Move filtering back to filtered rules hook, use paged groups for improved performance * Add queriedDatasources field to grafana managed rules and update filtering logic to rely on it - Introduced a new field `queriedDatasources` in the AlertingRule struct to track data sources used in rules. - Updated the Prometheus API to populate `queriedDatasources` when creating alerting rules. - Modified filtering logic in the ruleFilter function to utilize the new `queriedDatasources` field for improved data source matching. - Adjusted related tests to reflect changes in rule structure and filtering behavior. * Add FilterView performance logging * Improve GMA Prometheus types, rename queried datasources property * Use custom generator helpers for flattening and filtering rule groups * Fix lint errors, add missing translations * Revert test condition * Refactor api prom changes * Fix lint errors * Update backend tests * Refactor rule list components to improve error handling and data source management - Enhanced error handling in FilterViewResults by logging errors before returning an empty iterable. - Simplified conditional rendering in GrafanaRuleLoader for better readability. - Updated data source handling in PaginatedDataSourceLoader and PaginatedGrafanaLoader to use new individual rule group generator. - Renamed toPageless function to toIndividualRuleGroups for clarity in prometheusGroupsGenerator. - Improved filtering logic in useFilteredRulesIterator to utilize a dedicated function for data source type validation. - Added isRulesDataSourceType utility function for better data source type checks. - Removed commented-out code in PromRuleDTOBase for cleaner interface definition. * Fix abort controller on FilterView * Improve generators filtering * fix abort controller * refactor cancelSearch * make states exclusive * Load full page in one loadResultPage call * Update tests, update translations * Refactor filter status into separate component * hoist hook * Use the new function for supported rules source type --------- Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com>	3 months ago
Moustafa Baiou	032299011a	Alerting: Relax permissions for access a rule (#103664) ... This makes it so that it is: - No longer required to have datasource permissions to delete a rule. - No longer required to have datasource permissions to update non-query related fields of a rule.	3 months ago
Kevin Yu	fd6fd91115	Prometheus: Add support for cloud partners Prometheus data sources (#103482) ... * wip * Add prom flavor support for data source variables and export/import dashboards (#103321) * add dashboard and data source var selection * use match plugin id instead * use updated matchpluginid * formatting * cleanup * regex anchor * update error msg * Alerting: Clean up prometheus-flavored types and functions (#103703) * clean up types and utility functions for dealing with prometheus-flavored data sources * Refactor alerting datasource types to use constants as source of truth * Alerting: Clean up prometheus-flavored types and functions on the bac… (#103716) Alerting: Clean up prometheus-flavored types and functions on the backend * add matchPluginId tests * Update matchPluginId func to bidirectional (#103746) * update matchpluginid func to bidirectional * lint * formatting * use actual isSupportedExternalRulesSourceType in test * add tests in datasource_srv * betterer * remove type assertion * remove unnecessary case * use satisifies to not have to convert tuple to an array of string * add prometheus_flavor test --------- Co-authored-by: Andrew Hackmann <5140848+bossinc@users.noreply.github.com> Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com> Co-authored-by: Alexander Akhmetov <me@alx.cx>	3 months ago
Mariell Hoversholm	757be6365a	CI: Bump golangci-lint to 2.0.2 (#103572)	3 months ago
Steve Simpson	870d401f75	Alerting: Update grafana/alerting (#103607) ... * Alerting: Update grafana/alerting * Run make update-workspace	3 months ago
Alexander Akhmetov	97897b796e	Alerting: Do not export MissingSeriesEvalsToResolve if it is not set (#103736)	3 months ago
Alexander Akhmetov	babe188e31	Alerting: Fix path for cortex-style Prometheus namespaces conversion endpoint (#103655)	3 months ago
William Wernert	a8f60de620	Alerting: Remove feature toggles relating to Loki Alert State History (#103540) ... * Remove feature toggles relating to Loki Alert State History	3 months ago
Alexander Akhmetov	c4a2f99d8b	Alerting: Allow importing Prometheus rules with keep_firing_for (#103557)	3 months ago
Alexander Akhmetov	66006928b8	Alerting: Set ExecErrState to Normal for imported Prometheus rules (#103556)	3 months ago
Alexander Akhmetov	09a7f9ba1c	Alerting: Update external alert manager notifier (#103530)	3 months ago
Will Assis	9bc4fbe900	alerting: batch user service calls (#103403) ... * update alerting endpoints to batch requests to the user service via ListByIdOrUID	3 months ago
Alexander Akhmetov	cf5da1d366	Alerting: Fix swagger in pkg/services/ngalert/api/tooling (#103500)	3 months ago
Alexander Akhmetov	bdbe94abc8	Alerting: Remove alertingConversionAPI feature flag (#103380)	4 months ago
Will Browne	48877f9187	Alerting: Fix plugin not found error during condition validation (#102437) ... improve error	4 months ago
Alexander Akhmetov	b49c532999	Alerting: Fix state transition from Recovering back to Alerting (#103286) ... What is this feature? This PR fixes a state transition issue where alerts transitioning from the Recovering state back to the Alerting state incorrectly entered the Pending state first if the rule had a For duration configured. Why do we need this feature? When an alert goes from Alerting to Recovering (when using the Keep firing for) and then back to Alerting, the existing logic would incorrectly put the alert into Pending state while it should be alerting and still sending notifications to the Alertmanager.	4 months ago
Yuri Tseretyan	dc0083d879	Alerting: Sequential evaluation of rules in group (#98829) ... * introduce RulesGroupComparer * extract runJob method * implement sequential evaluation * Make sequence building testable & add comments * Also run callback in recording rules + add tests * Improve tests * Address PR comments --------- Co-authored-by: William Wernert <william.wernert@grafana.com>	4 months ago
maicon	d8c5c2d3b8	K8s: Folders: Modify GetChildren to return only Folder References (#103072) ... * Return FolderReference instead of Folder on GetChildren Signed-off-by: Maicon Costa <maiconscosta@gmail.com> --------- Signed-off-by: Maicon Costa <maiconscosta@gmail.com>	4 months ago
Alexander Akhmetov	7347083f98	Alerting: Validate target datasource type only when importing recording rules (#103214)	4 months ago
Yuri Tseretyan	d10fdc0f02	Alerting: ListDeletedRules to return rules sorted by date (#102945) ... --------- Signed-off-by: Yuri Tseretyan <yuriy.tseretyan@grafana.com>	4 months ago
Fayzal Ghantiwala	68d8810ecb	Alerting: API to convert submitted Prometheus rules to GMA (#102231) ... * placeholder commit * Complete function in api_convert_prometheus.go * MVP before extensive testing * Cleanup * Updated tests * cleanup * Fix random logs and lint * Remove comment * Fix errors after rebase * Update test * Update swagger * swagger * Refactor to accept groups in body * Fix auth tests and some cleanup * Some cleanup before refactoring * Remove unnecessary fields * Also refactor RouteConvertPrometheusPostRuleGroup * Remove unused code * Rebase + cleanup * Update authorization_test * address comments * Regen swagger files * Remove namespace and group filters * Final comments	4 months ago
Mariell Hoversholm	d0d7078953	App Platform: Remove mutable globals (#102962) ... * App Platform: Remove mutable globals * chore: clarify why this exists * fix: support multi-tenant mode * refactor: call builder providers directly * CI: Force re-build	4 months ago
alerting-team[bot]	6df99a6224	Alerting: Update alerting module to 58ba6c617ff05eb1d6f65c59d369a6a16923dff6 (#102812) ... * remove feature flag alertingAlertmanagerExtraDedupStage * use most recent version of fork of alertmanager --------- Co-authored-by: Yuri Tseretyan <yuriy.tseretyan@grafana.com>	4 months ago
William Wernert	88d23fe5be	Alerting: Remove transitional notifications API endpoints (#102713) ... * Remove transitional notifications API endpoints * Fix openapi spec * Fix path test * Remove API tests related to removed endpoints	4 months ago
Alexander Akhmetov	f49a88ab72	Alerting: Add MissingSeriesEvalsToResolve to the APIs (#102150) ... What is this feature? A follow-up for #101184, adds AlertRule.MissingSeriesEvalsToResolve to the APIs. missing_series_evals_to_resolve must be specified too and it must be > 0. POST /api/ruler/grafana/api/v1/rules/{folderUID} works in the following way: If missing_series_evals_to_resolve is not sent or null, the rule keeps its existing value If missing_series_evals_to_resolve > 0: updates to that value If missing_series_evals_to_resolve = 0: resets to default (nil). AlertRule.MissingSeriesEvalsToResolve can't be 0, so I used it to reset In the Provisioning API, the value is just set if present and > 0. Otherwise it's reset: PUT to /api/v1/provisioning/alert-rules/{UID}: If missing_series_evals_to_resolve is nil, it's reset to the default value If missing_series_evals_to_resolve > 0, it's updated	4 months ago
Alexander Akhmetov	f7aa17f2e4	Alerting: Add default values to AlertRule.Data queries in Prometheus conversion (#102843) ... What is this feature? Prometheus conversion: ensures that AlertRule.Data queries always have default parameters set (intervalMs, maxDataPoints). Without this, updates of the same rule can cause version increments. Why do we need this feature? Currently, when converting Prometheus rules to Grafana alerts, some default parameters are not explicitly set in the query model. This creates a problem during rule updates: When a user updates a rule that hasn't changed, we still detect differences in the AlertQuery.Model because the newly converted rules are missing the default fields, such as intervalMs and maxDataPoints. This causes unnecessary version increments of alert rules.	4 months ago
Peter Štibraný	5b5f433a26	spanner: Disable running alerting integration tests when using spanner. (#102730) ... * Disable running alerting integration tests when using spanner. * Disable tests for templategroup.	4 months ago
Alexander Akhmetov	c54da8f955	Alerting: Make $value return the query value in case when a single datasource is used (#102301) ... What is this feature? This PR changes the behavior of the $value and .Value variables in alerting templating to be more compatible with Prometheus templating. When a single datasource is used in the alerting rule, these variables will now return the numeric value from the query instead of the evaluation string. Why do we need this feature? It makes Grafana templating more compatible with Prometheus templates. In Prometheus, $value returns the numeric value of the query, but in Grafana it's the evaluation string: [ var='A' labels={instance=instance1} value=81.234 ]. This is because in Grafana multiple datasources can be used in the alert rule, and it's not always possible to get a single value. This change makes Grafana's behavior consistent with Prometheus when a single datasource is used, and in case when multiple datasources are used in the query, it keeps the old behaviour. Both $value and .Value are not recommended to use (documentation), and it's better to use .Values instead.	4 months ago
Steve Simpson	0ffb7518cd	Alerting: Ignore external alert sending errors when shutting down. (#102705)	4 months ago
Alexander Akhmetov	b4758d06a3	Alerting: Support JSON Content-Type in the Prometheus conversion API (#102627) ... Alerting: Support content-type: json in conversion API	4 months ago
Marco de Abreu	543c0bbccb	App platform: Add cleanup job for dashboards when going through /apis (kubectl) (#102506) ... * Add dashboard cleanup job Change log message Adjust logic to account for new head RV logic Don't update lastResourceVersion due to pagination Save improvements * Address review feedback * Update docs. * Remove docs * Rename config --------- Co-authored-by: Marco de Abreu <18629099+marcoabreu@users.noreply.github.com>	4 months ago
Alexander Akhmetov	3ef583aa05	Alerting: Set MissingSeriesEvalsToResolve to 1 for Prometheus-imported rules (#101973)	4 months ago
Alexander Akhmetov	ad71270ee0	Alerting: Support query_offset in the Prometheus conversion (#102499) ... Adds support for rule group-level query_offset in Prometheus to Grafana rule conversion. It allows specifying a time offset for rule evaluation, which gets applied and saved during the conversion.	4 months ago
Alexander Akhmetov	756b45402c	Alerting: Add rule_query_offset setting for Prometheus rule conversion (#102500) ... Adds a new configuration option to specify a time offset for rule evaluation, which gets applied and saved during the Prometheus -> Grafana conversion. For example: [unified_alerting.prometheus_conversion] rule_query_offset = 1m Changing this option affects only the rules imported after the change. If query_offset is set at the group level, it takes precedence over this setting. Default is set to 1m.	4 months ago
Matthew Jacobson	371ea5cda7	Alerting: Fix loss of TimeInterval location on remote AM apply (#102510) ... * Alerting: Fix loss of TimeInterval location on remote AM apply deepcopy.Copy does not correctly copy PostableUserConfig because it ignores unexported fields. As a result, TimeInterval locations default to UTC instead of retaining their original values. * make update-workspace	4 months ago
Yuri Tseretyan	c3f00eb403	Alerting: log body of unexpected response from Mimir (#102382) ... log body of unexpected response Signed-off-by: Yuri Tseretyan <yuriy.tseretyan@grafana.com>	4 months ago
Tito Lins	42472dbe7e	Alerting: handle mimir BadRequest write errors (#102027)	4 months ago
Alexander Akhmetov	a8a88f858a	Alerting: Remove uniqueness checks from the Prometheus conversion (#102261)	4 months ago
Yuri Tseretyan	69a62777c5	Fix flaky test TestIntegration_ListDeletedRules (#102383) ... Signed-off-by: Yuri Tseretyan <yuriy.tseretyan@grafana.com>	4 months ago
Yuri Tseretyan	e39b17d701	Alerting: Remove constraints for uniqueness of rule title (#102067) ... * fix having duplicated names in same group in the UI --------- Co-authored-by: Sonia Aguilar <soniaaguilarpeiron@gmail.com>	4 months ago
Alexander Akhmetov	695ac91290	Alerting: Add backend support for keep_firing_for (#100750) ... What is this feature? This PR introduces a new alert rule configuration option, keep_firing_for (Prometheus documentation). keep_firing_for prevents alerts from resolving immediately after the alert condition returns to normal. Instead, they transition into a "Recovering" state and are not considered resolved by the Alertmanager. Once the recovery period ends (or after the next evaluation if it is bigger than keep_firing_for), the alert transitions to "Normal" if it doesn't start alerting again: Before +----------+ +----------+ | Alerting |---->| Normal | +----------+ +----------+ ----- After +----------+ +------------+ +----------+ | Alerting |----->| Recovering |---->| Normal | +----------+ +------------+ +----------+ Why do we need this feature? This feature prevents flapping alerts by adding a recovery period. This helps avoid false resolutions caused by brief alert	4 months ago
Alexander Akhmetov	1d0a86252e	Alerting: Add target datasource support to Prometheus conversion (#102307)	4 months ago
Dominik Broj	f7e0f095a2	Alerting: use 'Grafana IRM' wording in alerting contact point (#102014) ... * chore: use 'Grafana IRM' wording in alerting contact point * revert temp condition change * remove unneeded ts assertion * more renaming * use translations * update test * running make i18n-extract * avoid "simple" word in copy	4 months ago
Yuri Tseretyan	309a2eb4e9	Alerting: Allow administrators delete rules permanently via UI (#101974) ... * add query parameter to existing APIs to control the permanent deletion of rules * add GUID to gettable rule * add new endpoint /ruler/grafana/api/v1/trash/rule/guid/{RuleGUID} to delete rules from trash permanently --------- Signed-off-by: Yuri Tseretyan <yuriy.tseretyan@grafana.com>	4 months ago
Yuri Tseretyan	e30034a42a	Alerting: Remove feature flag `alertingNoDataErrorExecution` (#102156) ... * remove feature flag * remove feature flag in state manager * make sure no data with empty results is handled Signed-off-by: Yuri Tseretyan <yuriy.tseretyan@grafana.com> --------- Signed-off-by: Yuri Tseretyan <yuriy.tseretyan@grafana.com>	4 months ago
Alexander Akhmetov	ef5cc12b33	Alerting: Add HMAC signature config to the webhook integration (#100960) ... Adds HMAC-SHA256 signature support to webhook notifications, providing a way to verify the authenticity and integrity of webhook requests. The implementation allows to specify the header in which the signature will be sent. The signature is calculated from the request body. An optional timestamp header name can be provided. If set, the HMAC signature will be generated by concatenating the timestamp, a ":" and the request body: {timestamp}:{body}. The timestamp will also be sent in the provided header name.	4 months ago
Steve Simpson	87638c0170	Alerting: Start splitting apart ngalert/api package. (#102075)	4 months ago