41 Commits (c525db9cd89e24a5dbbf522188f85d7da688c936)

Author	SHA1	Message	Date
Yuriy Tseretyan	e94d0c1b96	Alerting: update rule test endpoints to respect data source permissions (#47169) ... * make eval.Evaluator an interface * inject Evaluator to TestingApiSrv * move conditionEval to RouteTestGrafanaRuleConfig because it is the only place where it is used * update rule test api to check data source permissions	3 years ago
gotjosh	84e5f336fe	Alerting: Classic conditions can now display multiple values (#46971) ... * Alerting: Extract classic condition values by RefID * uncapitalise function * update documentation * Update pkg/services/ngalert/eval/extract_md.go Co-authored-by: George Robinson <george.robinson@grafana.com> * Update pkg/services/ngalert/state/state.go Co-authored-by: George Robinson <george.robinson@grafana.com> * Update pkg/services/ngalert/state/state.go Co-authored-by: George Robinson <george.robinson@grafana.com> * Update pkg/services/ngalert/eval/extract_md.go Co-authored-by: George Robinson <george.robinson@grafana.com> * Update docs/sources/alerting/unified-alerting/alerting-rules/alert-annotation-label.md Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com> * Update pkg/services/ngalert/eval/extract_md.go Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com> * Run prettier Co-authored-by: George Robinson <george.robinson@grafana.com> Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com>	3 years ago
George Robinson	9df43abbb5	Fix evaluation of alert rules for datasources with custom headers (#44862) ... * Fix evaluation of alert rules for datasources with custom headers * Fix unit tests * Fix integration tests * Evaluator fields should be package private	3 years ago
idafurjes	ff3cf94b56	Chore: Remove context.TODO() from services (#42555) ... * Remove context.TODO() from services * Fix live test	3 years ago
Ryan McKinley	2754e4fdf0	Expressions: use datasource model from the query (#41376) ... * refactor datasource loading * refactor datasource loading * pass uid * use dscache in alerting to get DS * remove expr/translate pacakge * remove dup injection entry * fix DS type on metrics endpoint, remove SQL DS lookup inside SSE * update test and adapter * comment fix * Make eval run as admin when getting datasource info Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com> * fmt and comment * remove unncessary/redundant code Co-authored-by: Kyle Brandt <kyle@grafana.com> Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com> Co-authored-by: Santiago <santiagohernandez.1997@gmail.com>	3 years ago
George Robinson	c932dc959c	Alerting: Add Ref ID to DatasourceNoData and DatasourceError alerts (#42630)	4 years ago
George Robinson	5f5298ad25	Alerting: Use require.ElementsMatch in TestEvaluateExecutionResultsNoData	4 years ago
George Robinson	4d288cc6c7	Alerting: Fix NoData tests (#41759)	4 years ago
George Robinson	d363e19517	Alerting: Add datasource_uid label to DatasourceNoData alerts (#41621)	4 years ago
Marcus Efraimsson	baab021fec	Chore: Refactor usage of legacy data contracts (#41218) ... Refactor usage of legacy data contracts. Moves legacy data contracts to pkg/tsdb/legacydata package. Refactor pkg/expr to be a proper service/dependency that can be provided to wire to remove some unneeded dependencies to SSE in ngalert and other places. Refactor pkg/expr to not use the legacydata,RequestHandler and use backend.QueryDataHandler instead.	4 years ago
Sofia Papagiannaki	f6f3a54742	Alerting: tune rule evaluation via configuration (#35623) ... * Alerting: Configure max evaluation retries * Alerting: Enforce minimum rule evaluation interval * Alerting: Disable rule evaluation from configuration * Update docs * Alerting: Configure rule evaluation timeout * Move options on unified_alerting config section * Apply suggestions from code review Co-authored-by: gotjosh <josue@grafana.com>	4 years ago
Todd Treece	6e667cacee	Alerting: Skip query cache for alert queries (#39010)	4 years ago
George Robinson	456dac1303	Expand the value of math and reduce expressions in annotations and labels (#36611) ... * Expand the value of math and reduce expressions in annotations and labels This commit makes it possible to use the values of reduce and math expressions in annotations and labels via their RefIDs. It uses the Stringer interface to ensure that "{{ $values.A }}" still prints the value in decimal format while also making the labels for each RefID available with "{{ $values.A.Labels }}" and the float64 value with "{{ $values.A.Value }}"	4 years ago
Andrej Ocenas	ea2ba06b93	CloudWatch/Logs: Fix log alerts in new unified alerting (#36558) ... * Pass FromAlert header from new alerting * Add better error messages	4 years ago
Kyle Brandt	19f764739b	Alerting: Change `__value__` label to `__value_string__` annotation and add `ValueString` variable in notifications (#36032) ... * Alerting: Allow __value__ label in notifications was being removed by removePrivateItems discoverd in #36020, but issue is not about that specifically * __value__ label to __value_string__ annotation and .ValueString extended property for notifications	4 years ago
Sofia Papagiannaki	abe35c8c01	Alerting: Add error recovery during rule evaluations (#35450) ... * Alerting: Eval recovery after query failure * Apply suggestions from code review	4 years ago
Kyle Brandt	b47e7d12e6	Alerting: Extract values from MD expr alerts (#34757) ... When using mulit-dimensional Grafana managed alerts (e.g. SSE math) extract refIds values and labels so they can be shown in the notification and dashboards.	4 years ago
Marcus Andersson	e19b3df1a9	Alerting: added possibility to preview grafana managed alert rules. (#34600) ... * starting to add eval logic. * wip * first version of test rule. * reverted file. * add info colum to result to show error or (with CC evalmatches) * fix labels in evalmatch * fix be test * refactored using observables. * moved widht/height div to outside panel rendere. * adding docs api level. * adding container styles to error div. * increasing size of preview. Co-authored-by: kyle <kyle@grafana.com>	4 years ago
Kyle Brandt	63b2dd06a5	Alerting: Set "value" with evalmatches in G Managed (#34075) ... When, and currently only when using a classic condition, evaluation information is added (which is like the EvalMatches from dashboard alerting). This is returned via the API and can be included in notifications by reading the `__value__` label attached `.Alerts` in the template. It is a string.	4 years ago
Kyle Brandt	d32fcbe2bc	Alerting: Eval pkg tests and more specific error handling (#33496) ... * comment updates * more friendly error messages, in particular if it looks like time series data	4 years ago
David Parrott	788bc2a793	Alerting: refactor state tracker (#33292) ... * set processing time * merge labels and set on response * use state cache for adding alerts to rules * minor cleanup * add support for NoData and Error results * rename test * bring in changes from other PRs tha have been merged * pr feedback * add integration test * close state tracker cleanup on context.Done * fixup test * rename state tracker * set EvaluationDuration on Result * default labels set as constants * separate cache and state from manager * use RWMutex in cache	4 years ago
David Parrott	ca79206498	Alerting: Handle NoData and Error evaluation results (#33194) ... * set processing time * merge labels and set on response * use state cache for adding alerts to rules * minor cleanup * add support for NoData and Error results * rename test * bring in changes from other PRs tha have been merged * pr feedback * add integration test * close state tracker cleanup on context.Done * fixup test * not those annotations	4 years ago
Kyle Brandt	5e818146de	Alerting/Expr: New SSE Request/QueryType, alerting move data source UID (#33282)	4 years ago
Sofia Papagiannaki	b2288f7ef9	[Alerting]: Add alerting endpoint for Query Evaluation (#33174) ... * [Alerting]: Add alerting endpoint for Query Evaluation * Fix passing down now parameter * Add validations and test * Fix eval queries and expressions test * Add eval tests	4 years ago
David Parrott	4be1d84f23	Alerting: Enhancements to /rules (#33085) ... * set processing time * merge labels and set on response * use state cache for adding alerts to rules * minor cleanup * pr feedback * Do not initialize mutex unnecessarily Co-authored-by: Ganesh Vernekar <15064823+codesome@users.noreply.github.com> * linter Co-authored-by: Ganesh Vernekar <15064823+codesome@users.noreply.github.com>	4 years ago
Sofia Papagiannaki	e7ff04a167	[Alerting]: Implement test rule API route (#32837) ... * [Alerting]: Implement test rule API route * Apply suggestions from code review * Call /query instead of /query_range	4 years ago
David Parrott	b1cb74c0c9	Alerting: Send alerts from state tracker to notifier, logging, and cleanup task (#32333) ... * Initial commit for state tracking * basic state transition logic and tests * constructor. test and interface fixup * use new sig for sch.definitionRoutine() * test fixup * make the linter happy * more minor linting cleanup * Alerting: Send alerts from state tracker to notifier * Add evaluation time and test Add evaluation time and test * Add cleanup routine and logging * Pull in compact.go and reconcile differences * pr feedback * pr feedback Pull in compact.go and reconcile differences Co-authored-by: Josue Abreu <josue@grafana.com>	4 years ago
David Parrott	d33a77a67f	Alerting: add state tracker to alerting evaluation (#32298) ... * Initial commit for state tracking * basic state transition logic and tests * constructor. test and interface fixup * use new sig for sch.definitionRoutine() * test fixup * make the linter happy * more minor linting cleanup	4 years ago
gotjosh	58b814bd7d	Alerting: Add StartAt and FiredAt to the alert evaluation result (#32302)	4 years ago
Kyle Brandt	05fa9d6ad9	AlertingNG: rename Condition properties to match front end (#32267)	4 years ago
Kyle Brandt	7bb79158ed	SSE/Alerting: First pass at query/condition translation (#31693) ... - Takes the conditions property from the settings column of an alert from alerts table and turns into an ng alerting condition with the queries and classic condition. - Has temp API rest endpoint that will take the dashboard conditions json, translate it to SEE queries + classic condition, and execute it (only enabled in dev mode). - Changes expressions to catch query responses with a non-nil error property - Adds two new states for an NG instance result (NoData, Error) and updates evaluation to match those states - Changes the AsDataFrame (for frontend) from Bool to string to represent additional states - Fix bug in condition model to accept first Operator as empty string. - In ngalert, adds GetQueryDataRequest, which was part of execute and is still called from there. But this allows me to get the Expression request from a condition to make the "pipeline" can be built. - Update AsDataFrame for evalresult to be row based so it displays a little better for now	4 years ago
Sofia Papagiannaki	53bccf1b77	Replace eval.Condition with models.Condition (#31909)	4 years ago
Sofia Papagiannaki	4ce0a49eac	AlertingNG: Split into several packages (#31719) ... * AlertingNG: Split into several packages * Move AlertQuery to models	4 years ago
Arve Knudsen	b79e61656a	Introduce TSDB service (#31520) ... * Introduce TSDB service Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> Co-authored-by: Erik Sundell <erik.sundell87@gmail.com> Co-authored-by: Will Browne <will.browne@grafana.com> Co-authored-by: Torkel Ödegaard <torkel@grafana.org> Co-authored-by: Will Browne <wbrowne@users.noreply.github.com> Co-authored-by: Zoltán Bedi <zoltan.bedi@gmail.com>	4 years ago
Sofia Papagiannaki	9ada4b6052	Expressions: Add option to disable feature (#30541) ... * Expressions: Add option to disable feature * Apply suggestions from code review Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com>	4 years ago
Sofia Papagiannaki	b1debc9c46	AlertingNG: Enforce unique alert definition title (non empty)/UID per organisation (#30380) ... * Enforce unique alert definition title/uid per org * Remove print statement from test * Do not allow empty alert definition titles * update error message on dup title * also add title error to update * CamelCase json properties * Add test for title unique enforcement in updates Co-authored-by: kyle <kyle@grafana.com>	4 years ago
Sofia Papagiannaki	2b15581339	AlertingNG: Modify queries and transform endpoint to get datasource UIDs (#30297) ... * Pass skipCache from context * Use macaron Params instead of ParamsEscape for UIDs * Modify queries and transform to get datasource UIDs * Update github.com/grafana/grafana-plugin-sdk-go to v0.83.0	4 years ago
Sofia Papagiannaki	3cac10e598	AlertingNG: Create a scheduler to evaluate alert definitions (#29305) ... * Always use cache: stop passing skipCache among ngalert functions * Add updated column * Scheduler initial draft * Add retry on failure * Allow settting/updating alert definition interval Set default interval if no interval is provided during alert definition creation. Keep existing alert definition interval if no interval is provided during alert definition update. * Parameterise alerting.Ticker to run on custom interval * Allow updating alert definition interval without having to provide the queries and expressions * Add schedule tests * Use xorm tags for having initialisms with consistent case in Go * Add ability to pause/unpause the scheduler * Add alert definition versioning * Optimise scheduler to fetch alert definition only when it's necessary * Change MySQL data column to mediumtext * Delete alert definition versions * Increase default scheduler interval to 10 seconds * Fix setting OrgID on updates * Add validation for alert definition name length * Recreate tables	4 years ago
Kyle Brandt	6d64c603c2	Expr: fix failure to execute due to OrgID (#29653) ... * Expr: fix failure to execute due to OrgID Get orgID from the plugin context, which makes more sense anyways. makes expressions work again after https://github.com/grafana/grafana/pull/29449 changes. * Do not save organisation on its alert query model Co-authored-by: Sofia Papagiannaki <sofia@grafana.com>	5 years ago
Kyle Brandt	0cb29d337a	Expressions: Move GEL into core as expressions (#29072) ... * comes from grafana/gel-app * remove transform plugin code * move __expr__ and -100 constants to expr pkg * set OrgID on request plugin context * use gtime for resample duration * in resample, rename "rule" to "window", use gtime for duration, parse duration before exec * remove gel entry from plugins-bundled/external.json which creates an empty array for plugins	5 years ago
Sofia Papagiannaki	43f580c299	AlertingNG: manage and evaluate alert definitions via the API (#28377) ... * Alerting NG: prototype v2 (WIP) * Separate eval package * Modify eval alert definition endpoint * Disable migration if ngalert is not enabled * Remove premature test * Fix lint issues * Delete obsolete struct * Apply suggestions from code review * Update pkg/services/ngalert/ngalert.go Co-authored-by: Kyle Brandt <kyle@grafana.com> * Add API endpoint for listing alert definitions * Introduce index for alert_definition table * make ds object for expression to avoid panic * wrap error * Update pkg/services/ngalert/eval/eval.go * Swith to backend.DataQuery * Export TransformWrapper callback * Fix lint issues * Update pkg/services/ngalert/ngalert.go Co-authored-by: Kyle Brandt <kyle@grafana.com> * Validate alert definitions before storing them * Introduce AlertQuery * Add test * Add QueryType in AlertQuery * Accept only float64 (seconds) durations * Apply suggestions from code review * Get rid of bus * Do not export symbols * Fix failing test * Fix failure due to service initialization order Introduce MediumHigh service priority and assign it to backendplugin service * Fix test * Apply suggestions from code review * Fix renamed reference Co-authored-by: Kyle Brandt <kyle@grafana.com>	5 years ago