55 Commits (c5a0d64652b03b506e3f9a60add80ffe585db223)

Author	SHA1	Message	Date
Piotr Jamróz	975edf14dc	Explore: Unify spec setup (#73994) ... * Simplify Explore spec setup * Update public/app/features/explore/spec/helper/setup.tsx Co-authored-by: Giordano Ricci <me@giordanoricci.com> --------- Co-authored-by: Giordano Ricci <me@giordanoricci.com>	2 years ago
Piotr Jamróz	fdd384ab56	Explore: Decouple TimeSrv from Explore (#73559)	2 years ago
Piotr Jamróz	f11cc0e60e	Explore: Improve handling time range keyboard shortcuts inside Explore (#73600) ... * Handle time keyboard shortcuts inside Explore * Remove unused handler for make absolute * Remove unused code * Unify handling keyboard shorcuts logic	2 years ago
Giordano Ricci	35818fa9ab	Explore: Relabel secondary actions buttons (#73605)	2 years ago
Haris Rozajac	e586c4549b	Explore: Moved 'handles open/close splits in UI and URL' test to the spec folder (#71674) ... * Move handles open/close splits in UI and URL test to the spec folder * Remove reference to explore * Fix what was missing * Remove afterEach * Use standard, non-compact format	2 years ago
Giordano Ricci	c5d2d55654	Explore: Remove exploreMixedDatasource feature toggle (#71534)	2 years ago
Haris Rozajac	4b3050e02e	Explore: Test deleting comments in query history (#70934) ... * Working test	2 years ago
Piotr Jamróz	c191a20591	Explore: Fix Query History flakey test (#71190) ... * Baseline benchmark * Baseline benchmark * Re-trigger the build * Use test id * Re-trigger the build * Re-trigger the build * Use test id to speed up the test * Split query history sync tests	2 years ago
Kristina	f18a02149a	Correlations: Create paginated API (#65241) ... * Add pagination params and apply to sql * Create getCorrelationsResponse that returns metadata * Set up pagination, change correlations fetch to only get source datasource correlations * Move correlations from root to pane, only fetch correlations for one datasource when initialized or datasource is changed * Fix tests * Fix remaining tests * Use functional component to handle state * Remove unneeded mocks, fix tests * Change perPage to limit * Fix Go Tests * Fix linter * Remove parameter * Account for mixed datasources * Delete unused hook * add source UID filter to API, start backing out front end hook changes * add source IDs to API, use when loading or changing datasource * Fix prettier * Mock correlations response * Get correlations for all datasources in mixed scenario * Add documentation for new parameters * Attempt to fix swagger * Fix correlations page * add swagger and openapi docs * Add mocks to failing test * Change API for consistency, remove extra hooks and unused function * Add max to limit and re-gen api docs * Move the page to the previous page if deleting all the rows on the page * Only fetch if remove does not have value * Change page to a reference hook * Fix documentation, a test and some logic thinking page could be 0	2 years ago
Marcus Andersson	f1529997f2	Explore: Make toolbar action extendable by plugins (#65524) ... * Cleaned up solution and starting to make it work properly. * will disable add button if no queries available. * Changed so 'add to dashboard' is registered as an extension in explore. * moved utility function to utils * hides button if insufficent permissions. * Fixed ts issue. * cleaned up the code and change to using the 'getPluginLinkExtensions' * Added values to explore context. * truncating title in menu. * added tests to verify explore extension point. * fixed failing tests in explore. * made excludeModal optional. * removed temporary fix to force old button. * reverted generated files. * fixed according to feedback. * Update public/app/features/explore/extensions/ToolbarExtensionPoint.test.tsx Co-authored-by: Levente Balogh <balogh.levente.hu@gmail.com> * Update public/app/features/explore/extensions/ToolbarExtensionPoint.test.tsx Co-authored-by: Levente Balogh <balogh.levente.hu@gmail.com> * added tests suggested in reviews. * fixed failing tests after sync with main. * replaced exploreId type with stirng. * cleaned up code a bit more. --------- Co-authored-by: Levente Balogh <balogh.levente.hu@gmail.com>	2 years ago
Giordano Ricci	d3450d75a4	Explore: URL migrations & improved state management (#69692) ... Co-authored-by: Piotr Jamróz <pm.jamroz@gmail.com>	2 years ago
Giordano Ricci	6a3c6eb174	Explore: Ensure datasource is present in the URL for every query (#70307)	2 years ago
Giordano Ricci	2675f90eaa	Chore: Skip Explore flaky test (#70157)	2 years ago
Giordano Ricci	067bbcbe56	Explore: Refactor & centralize URL/state sync (#66286) ... Co-authored-by: Piotr Jamróz <pm.jamroz@gmail.com>	2 years ago
Andreas Christou	51c15f3a89	E2E: Fix configurePanel flow (#68487) ... * Updates for new datasource picker * Correct typing to ensure datasource selection * Remove unused import * Update labels * Update labels and fix test * Fix another test	2 years ago
Haris Rozajac	cee838c8a8	Explore: Remove data source onboarding page (#68131) ... * Remove EmptyStateWrapper	2 years ago
Giordano Ricci	f03d0698d3	Explore: move panes into a keyed object (#66117)	2 years ago
Giordano Ricci	b5a2c3c7f5	Query History: Remove migration (#67470)	2 years ago
Ashley Harrison	1261345b81	Chore: Upgrade to react 18 (#64428) ... * update react 18 related deps * fix some types * make sure we're on react-router-dom >= 5.3.3 * Use new root API * Remove StrictMode for now - react 18 double rendering causes issues * fix + ignore some @grafana/ui types * fix some more types * use renderHook from @testing-library/react in almost all cases * fix storybook types * rewrite useDashboardSave to not use useEffect * make props optional * only render if props are provided * add correct type for useCallback * make resourcepicker tests more robust * fix ModalManager rendering * fix some more unit tests * store the click coordinates in a ref as setState is NOT synchronous * fix remaining e2e tests * rewrite dashboardpage tests to avoid act warnings * undo lint ignores * fix ExpanderCell types * set SymbolCell type correctly * fix QueryAndExpressionsStep * looks like the types were actually wrong instead :D * undo this for now... * remove spinner waits * more robust tests * rewrite errorboundary test to not explicitly count the number of renders * make urlParam expect async * increase timeout in waitFor * revert ExplorePage test changes * Update public/app/features/dashboard/containers/DashboardPage.test.tsx Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com> * Update public/app/features/dashboard/containers/PublicDashboardPage.test.tsx Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com> * Update public/app/features/dashboard/containers/PublicDashboardPage.test.tsx Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com> * Update public/app/features/dashboard/containers/PublicDashboardPage.test.tsx Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com> * skip fakeTimer test, ignore table types for now + other review comments * update package peerDeps * small tweak to resourcepicker test * update lockfile... * increase timeout in sharepublicdashboard tests * ensure ExplorePaneContainer passes correct queries to initializeExplore * fix LokiContextUI test * fix unit tests * make importDashboard flow more consistent * wait for dashboard name before continuing * more test fixes * readd dashboard name to variable e2e tests * wait for switches to be enabled before clicking * fix modal rendering * don't use @testing-library/dom directly * quick fix for rendering of panels in firefox * make PromQueryField test more robust * don't wait for chartData - in react 18 this can happen before the wait code even gets executed --------- Co-authored-by: kay delaney <kay@grafana.com> Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com>	2 years ago
Ashley Harrison	e0e6165f70	Chore: adjust more unit tests to work with react 18 (#64759) ... adjust unit tests to work with react 18	2 years ago
Laura Benz	c83e02ce02	Laura/refactor/move tests for handling datasource states (#63638) ... refactor: move tests to a new file and clean up original file	2 years ago
Laura Benz	df6572b53f	Laura/refactor/move tests for running queries (#63581) ... * refactor: move tests to a new file and clean up original file * refactor: restructure test * refactor: remove linting error * refactor: change wording in test description	2 years ago
Giordano Ricci	c66ab3a9e4	QueryHistory: Improve handling of mixed datasource entries (#62214) ... * QueryHistory: Improve handling of mixed datasource entries * remove todo * remove todo * fix comment submit test * disable running queries if at least one doesn't have a datasource * remove unnecessary code * add tests for diabled buttons state	2 years ago
Torkel Ödegaard	9f7ddf1f0b	QueryEditorRow: Fixes issue loading query editor when data source variable selected (#61927) ... * QueryEditorRow: Fixes issue loading query editor when data source variable selected * Fix func name * Removed wait * restore waiting for with better check * restore waiting for with better check	2 years ago
Aashish Illa	fbfb79afce	Explore: Changed references to DataQuery and DataSourceRef (#62034)	2 years ago
Giordano Ricci	9ff3bf4849	Explore: Use Datasource Onboarding page when visiting without any datasource set up (#60399) ... * allow DatasourceOnboarding title and cta text customization * Explore: use Datasource Onboarding page when visiting without any datasource set up * move & rename DatasourceOnboarding * Rename component	2 years ago
Giordano Ricci	838cbf22da	Chore: remove various type assertions in Explore (#60501)	2 years ago
Kristina	d5274dfdda	Explore: Skip flaky query history test (#59135) ... Skip flaky query history test	3 years ago
Ashley Harrison	e5c68f40c2	Accessibility: enable rule `jsx-a11y/label-has-associated-control` (#57964) ... * use labels correctly * fix opentsdb labels * fix unit tests * use aria-label instead of data-testid	3 years ago
Piotr Jamróz	ae927eab73	Glue: Enrich query results data frames in Explore with correlations to generate static links from correlations (#56295) ... * Attach static generic data link to data frames in Explore * WIP * Always load correlations config when the query is run This will be moved to Wrapper.tsx and called only once Explore is mounted * remove comment * Load the config when Explore is loaded * Clean up * Check for feature toggle, simplify cod * Simplify the code * Remove unused code * Fix types * Add a test for attaching links * Revert package.json changes * Display title provided in the correlation label * Add missing mocks * Fix tests * Merge branch 'main' into ifrost/integration/attach-generic-data-link # Conflicts: # public/app/features/explore/Wrapper.tsx # public/app/features/explore/state/main.ts * Remove redundant async calls * Do not block Wrapper before correlations are loaded (only delay the query) * Test showing results after correlations are loaded * Post-merge fix * Use more consistent naming * Avoid null assertions Co-authored-by: Elfo404 <me@giordanoricci.com>	3 years ago
Kristina	38c1f3d054	Explore: Add Mixed Datasource (#53429) ... * Toggle on the mixed mode option * Ensure switching to mixed gives existing query prev datasource * WIP - Populate datasource when switching between mixed and not * WIP - handle change from mixed * Remove preimport filter, refine filter to work for queries * WIP debugging datasource transition * Ensure creating a new query gets target data source if switching with no matches between * Add mixed datasource to rich history display * Cleanup console logs, add relevant comments * Add feature toggle for mixed datasource * Fix Wrapper tests * Fix tests! * Fix test types and add feature tracking * Remove unnecessary default, remove explore/mixed workarounds for D2E * Move display text logic to mixed datasource file * Add in the default query parameters to a generated empty query * Condense some code * Apply suggestions from code review Co-authored-by: Giordano Ricci <me@giordanoricci.com> * Add more logic around mixed datasource being off for explore * Build out logic to handle different datasource scenarios * Add tests * Finalize last test * Fix mixed URL with mixed ds off, and relevant test * Fix datasource to explore workflow * Add datasource change function, call import queries if needed * add logic for changing single query ds Co-authored-by: Giordano Ricci <me@giordanoricci.com>	3 years ago
Giordano Ricci	c68d7f1e35	Correlations: Add CorrelationSettings Page (#53821) ... * GrafanaUI: add option to close DeleteButton on confirm click * add datasource readOnly info to frontend settings * move isTruthy utility type guard * add generic non-visualization table component * Add correlations settings page * add missing readOnly in mock * Fix typo * avoid reloading correlations after add/remove * use DeepPartial from rhf * validate source data source * fix validation logic * fix navmodel test * add missing readonly property * remove unused styles * handle multiple clicks on elements * better UX for loading states * fix remove handler * add glue icon	3 years ago
Kristina	6ecc420534	Revert "Explore: Add Mixed Datasource (#51605)" (#52889) ... This reverts commit e2258120e7.	3 years ago
Kristina	e2258120e7	Explore: Add Mixed Datasource (#51605) ... * Toggle on the mixed mode option * Ensure switching to mixed gives existing query prev datasource * WIP - Populate datasource when switching between mixed and not * WIP - handle change from mixed * Remove preimport filter, refine filter to work for queries * WIP debugging datasource transition * Ensure creating a new query gets target data source if switching with no matches between * Add mixed datasource to rich history display * Cleanup console logs, add relevant comments * Add feature toggle for mixed datasource * Fix Wrapper tests * Fix tests! * Fix test types and add feature tracking * Remove unnecessary default, remove explore/mixed workarounds for D2E * Move display text logic to mixed datasource file * Add in the default query parameters to a generated empty query * Condense some code * Apply suggestions from code review Co-authored-by: Giordano Ricci <me@giordanoricci.com> Co-authored-by: Giordano Ricci <me@giordanoricci.com>	3 years ago
Kristina	0e13ee345d	Explore: Change datasourceName usage to datasourceUID or datasourceRef where appropriate (#52479) ... * First pass at using datasource UID when appropriate * Fix tests * be more lenient with lookup to accomodate different URLs * Make test setup get mock work like real datasource get * Fix the typing issue and remaining tests * Fix PR feedback	3 years ago
Torkel Ödegaard	b782d9aa12	GrafanaContext: Exploring a way to get rid of global scope singletons (#52128) ... * Context start * More progress on more generic react context for services * Update * Update Page test * Fixing tests * Moving to core app	3 years ago
Gábor Farkas	c412a3b052	logs: track the usage of certain features (#50325) ... * logs: track the usage of certain features * Add report interaction for logs interactions * mock reportInteraction in test * mock reportInteraction Co-authored-by: Ivana Huckova <ivana.huckova@gmail.com>	3 years ago
Piotr Jamróz	84860ffc96	Query History: Hide query history when anonymous user uses Explore (#49896) ... * Hide query history when anonymous user uses Explore * Show query history to anonymous users when local storage is used * Fix integration test	3 years ago
Piotr Jamróz	d41b0f0a21	Test commenting query history (#49802)	3 years ago
Piotr Jamróz	e0adb41e80	Query History: Add feature tracking for query history (#49685) ... * Add feature tracking for query history * Fix unit tests * Update event names	3 years ago
Kristina	a95ba8eb3f	Explore: Use Dashboard permissions in Explore To Dashboard (#49539) ... * Look for dashboard permissions in e2d button * Get tests to pass * Add permissions tests	3 years ago
Piotr Jamróz	a008a01315	Chore: Re-enable skipped test (#49484) ... * Re-enable skipped test	3 years ago
Piotr Jamróz	060f0e5633	Query History: Results pagination (#49217) ... * Load Rich History when the container is opened * Store rich history for each pane separately * Do not update currently opened query history when an item is added It's impossible to figure out if the item should be added or not, because filters are applied in the backend. We don't want to replicate that filtering logic in frontend. One way to make it work could be by refreshing both panes. * Test starring and deleting query history items when both panes are open * Remove e2e dependency on ExploreId * Fix unit test * Assert exact queries * Simplify test * Fix e2e tests * Fix toolbar a11y * Reload the history after an item is added * Fix unit test * Remove references to Explore from generic PageToolbar component * Update test name * Fix test assertion * Add issue item to TODO * Improve test assertion * Simplify test setup * Move query history settings to persistence layer * Fix test import * Fix unit test * Fix unit test * Test local storage settings API * Code formatting * Fix linting errors * Add an integration test * Add missing aria role * Fix a11y issues * Fix a11y issues * Use divs instead of ul/li Otherwis,e pa11y-ci reports the error below claiming there are no children with role=tab: Certain ARIA roles must contain particular children (https://dequeuniversity.com/rules/axe/4.3/aria-required-children?application=axeAPI) (#reactRoot > div > main > div:nth-child(3) > div > div:nth-child(1) > div > div:nth-child(1) > div > div > nav > div:nth-child(2) > ul) <ul class="css-af3vye" role="tablist"><li class="css-1ciwanz"><a href...</ul> * Clean up settings tab * Remove redundant aria label * Remove redundant container * Clean up test assertions * Move filtering to persistence layer * Move filtering to persistence layer * Simplify applying filters * Split applying filters and reloading the history * Debounce updating filters * Update tests * Fix waiting for debounced results * Clear results when switching tabs * Improve test coverage * Update docs * Revert extra handling for uid (will be added when we introduce remote storage) * Create basic plan * Rename query history toggle * Add list of supported features and add ds name to RichHistoryQuery object * Clean up Removed planned items will be addressed in upcoming prs (filtering and pagination) * Handle data source filters * Simplify DTO conversion * Clean up * Fix betterer conflicts * Fix imports * Fix imports * Post-merge fixes * Use config instead of a feature flag * Use config instead of a feature flag * Update converter tests * Add tests for RichHistoryRemoteStorage * Simplify test setup * Simplify assertion * Add e2e test for query history * Remove duplicated entry * Fix unit tests * Improve readability * Remove unnecessary casting * Mock backend in integration tests * Remove unnecessary casting * Fix integration test * Update betterer results * Fix unit tests * Simplify testing with DataSourceSrv * Fix sorting and add to/from filtering * Basic pagination * Show load more only if there are items to load * Post-merge fixes * Change initial page limit to 100 * Fix unit tests * Fix linting errors * Test pagination * Fix query migration * Fix unit tests * Fix prettier * Remove full stop * Do not show number of queries with partial results to avoid confusion * Show number of displayed results when partial results are shown	3 years ago
Piotr Jamróz	16a948fc88	Query History: Implement RemoteStorage methods: settings (#49320) ... * Implement methods to get an update user preferences * Update integration test * Update label * Remove unused type * Simplify async code	3 years ago
Piotr Jamróz	c6c79a9360	Query History: Migrate local storage to remote storage (#48572) ... * Load Rich History when the container is opened * Store rich history for each pane separately * Do not update currently opened query history when an item is added It's impossible to figure out if the item should be added or not, because filters are applied in the backend. We don't want to replicate that filtering logic in frontend. One way to make it work could be by refreshing both panes. * Test starring and deleting query history items when both panes are open * Remove e2e dependency on ExploreId * Fix unit test * Assert exact queries * Simplify test * Fix e2e tests * Fix toolbar a11y * Reload the history after an item is added * Fix unit test * Remove references to Explore from generic PageToolbar component * Update test name * Fix test assertion * Add issue item to TODO * Improve test assertion * Simplify test setup * Move query history settings to persistence layer * Fix test import * Fix unit test * Fix unit test * Test local storage settings API * Code formatting * Fix linting errors * Add an integration test * Add missing aria role * Fix a11y issues * Fix a11y issues * Use divs instead of ul/li Otherwis,e pa11y-ci reports the error below claiming there are no children with role=tab: Certain ARIA roles must contain particular children (https://dequeuniversity.com/rules/axe/4.3/aria-required-children?application=axeAPI) (#reactRoot > div > main > div:nth-child(3) > div > div:nth-child(1) > div > div:nth-child(1) > div > div > nav > div:nth-child(2) > ul) <ul class="css-af3vye" role="tablist"><li class="css-1ciwanz"><a href...</ul> * Clean up settings tab * Remove redundant aria label * Remove redundant container * Clean up test assertions * Move filtering to persistence layer * Move filtering to persistence layer * Simplify applying filters * Split applying filters and reloading the history * Debounce updating filters * Update tests * Fix waiting for debounced results * Clear results when switching tabs * Improve test coverage * Update docs * Revert extra handling for uid (will be added when we introduce remote storage) * Create basic plan * Rename query history toggle * Add list of supported features and add ds name to RichHistoryQuery object * Clean up Removed planned items will be addressed in upcoming prs (filtering and pagination) * Handle data source filters * Simplify DTO conversion * Clean up * Fix betterer conflicts * Fix imports * Fix imports * Post-merge fixes * Use config instead of a feature flag * Use config instead of a feature flag * Update converter tests * Add tests for RichHistoryRemoteStorage * Simplify test setup * Simplify assertion * Add e2e test for query history * Remove duplicated entry * Fix unit tests * Improve readability * Remove unnecessary casting * Mock backend in integration tests * Remove unnecessary casting * Fix integration test * Update betterer results * Fix unit tests * Simplify testing with DataSourceSrv * Fix sorting and add to/from filtering * Add migration for local storage query history * Test query history migration * Simplify testing DataSourceSettings * Skip redundant migrations * Revert error logging test * Fix tests * Update betterer results * Change notification message after migration * Ensure previous request is canceled when getting search results * Add loading message when results are being loaded * Show info message only if local storage is enabled * Fix unit test * Post-merge fixes * Fix intergration tests * Fix incorrect filtering	3 years ago
Piotr Jamróz	f252e89339	Query History: Implement RemoteStorage methods: get all, add new (#48330) ... * Load Rich History when the container is opened * Store rich history for each pane separately * Do not update currently opened query history when an item is added It's impossible to figure out if the item should be added or not, because filters are applied in the backend. We don't want to replicate that filtering logic in frontend. One way to make it work could be by refreshing both panes. * Test starring and deleting query history items when both panes are open * Remove e2e dependency on ExploreId * Fix unit test * Assert exact queries * Simplify test * Fix e2e tests * Fix toolbar a11y * Reload the history after an item is added * Fix unit test * Remove references to Explore from generic PageToolbar component * Update test name * Fix test assertion * Add issue item to TODO * Improve test assertion * Simplify test setup * Move query history settings to persistence layer * Fix test import * Fix unit test * Fix unit test * Test local storage settings API * Code formatting * Fix linting errors * Add an integration test * Add missing aria role * Fix a11y issues * Fix a11y issues * Use divs instead of ul/li Otherwis,e pa11y-ci reports the error below claiming there are no children with role=tab: Certain ARIA roles must contain particular children (https://dequeuniversity.com/rules/axe/4.3/aria-required-children?application=axeAPI) (#reactRoot > div > main > div:nth-child(3) > div > div:nth-child(1) > div > div:nth-child(1) > div > div > nav > div:nth-child(2) > ul) <ul class="css-af3vye" role="tablist"><li class="css-1ciwanz"><a href...</ul> * Clean up settings tab * Remove redundant aria label * Remove redundant container * Clean up test assertions * Move filtering to persistence layer * Move filtering to persistence layer * Simplify applying filters * Split applying filters and reloading the history * Debounce updating filters * Update tests * Fix waiting for debounced results * Clear results when switching tabs * Improve test coverage * Update docs * Revert extra handling for uid (will be added when we introduce remote storage) * Create basic plan * Rename query history toggle * Add list of supported features and add ds name to RichHistoryQuery object * Clean up Removed planned items will be addressed in upcoming prs (filtering and pagination) * Handle data source filters * Simplify DTO conversion * Clean up * Fix betterer conflicts * Fix imports * Fix imports * Post-merge fixes * Use config instead of a feature flag * Use config instead of a feature flag * Update converter tests * Add tests for RichHistoryRemoteStorage * Simplify test setup * Simplify assertion * Add e2e test for query history * Remove duplicated entry * Fix unit tests * Improve readability * Remove unnecessary casting * Mock backend in integration tests * Remove unnecessary casting * Fix integration test * Update betterer results * Fix unit tests * Simplify testing with DataSourceSrv * Fix sorting and add to/from filtering * Simplify testing DataSourceSettings * Update betterer results * Ensure previous request is canceled when getting search results * Add loading message when results are being loaded * Show info message only if local storage is enabled * Fix unit test * Reuse sort order options * Reuse sort order options * Fix footer spacing	3 years ago
Piotr Jamróz	361cc18b45	Query History: Move filtering to service layer (#48008) ... * Load Rich History when the container is opened * Store rich history for each pane separately * Do not update currently opened query history when an item is added It's impossible to figure out if the item should be added or not, because filters are applied in the backend. We don't want to replicate that filtering logic in frontend. One way to make it work could be by refreshing both panes. * Test starring and deleting query history items when both panes are open * Remove e2e dependency on ExploreId * Fix unit test * Assert exact queries * Simplify test * Fix e2e tests * Fix toolbar a11y * Reload the history after an item is added * Fix unit test * Remove references to Explore from generic PageToolbar component * Update test name * Fix test assertion * Add issue item to TODO * Improve test assertion * Simplify test setup * Move query history settings to persistence layer * Fix test import * Fix unit test * Fix unit test * Test local storage settings API * Code formatting * Fix linting errors * Add an integration test * Add missing aria role * Fix a11y issues * Fix a11y issues * Use divs instead of ul/li Otherwis,e pa11y-ci reports the error below claiming there are no children with role=tab: Certain ARIA roles must contain particular children (https://dequeuniversity.com/rules/axe/4.3/aria-required-children?application=axeAPI) (#reactRoot > div > main > div:nth-child(3) > div > div:nth-child(1) > div > div:nth-child(1) > div > div > nav > div:nth-child(2) > ul) <ul class="css-af3vye" role="tablist"><li class="css-1ciwanz"><a href...</ul> * Clean up settings tab * Remove redundant aria label * Remove redundant container * Clean up test assertions * Move filtering to persistence layer * Move filtering to persistence layer * Simplify applying filters * Split applying filters and reloading the history * Debounce updating filters * Update tests * Fix waiting for debounced results * Clear results when switching tabs * Improve test coverage * Update docs * Revert extra handling for uid (will be added when we introduce remote storage) * Fix betterer conflicts * Fix imports * Fix imports * Simplify test setup * Simplify assertion * Improve readability * Remove unnecessary casting * Mock backend in integration tests	3 years ago
Josh Hunt	3c6e0e8ef8	Chore: ESlint import order (#44959) ... * Add and configure eslint-plugin-import * Fix the lint:ts npm command * Autofix + prettier all the files * Manually fix remaining files * Move jquery code in jest-setup to external file to safely reorder imports * Resolve issue caused by circular dependencies within Prometheus * Update .betterer.results * Fix missing // @ts-ignore * ignore iconBundle.ts * Fix missing // @ts-ignore	3 years ago
Ashley Harrison	d832bde270	Upgrade `@testing-library/user-event` to v14 (#47898) ... * Update dependency @testing-library/user-event to v14 * everything is async... * everything is async pt.2 * Fix cascader tests * hack the yarn.lock file to remove the old version of @testing-library/dom * some more fixes! * MOAR FIXES * more fixes * remove a bunch of places where we're wrapping in act() * down to 7 failing tests... * Fix arrow tests * Fix rest of NavBarItem tests * Fix last tests * Use {Enter} instead of {enter} * Revert "Use {Enter} instead of {enter}" This reverts commit e72453bb52. * remove some unused act imports * Fix LibraryPanelsSearch tests * more stable test * More consistent test... Co-authored-by: Renovate Bot <bot@renovateapp.com>	3 years ago
Piotr Jamróz	5cb5141c72	Query History: Move local storage specific settings to persistence layer (#47500) ... * Load Rich History when the container is opened * Store rich history for each pane separately * Do not update currently opened query history when an item is added It's impossible to figure out if the item should be added or not, because filters are applied in the backend. We don't want to replicate that filtering logic in frontend. One way to make it work could be by refreshing both panes. * Test starring and deleting query history items when both panes are open * Remove e2e dependency on ExploreId * Fix unit test * Assert exact queries * Simplify test * Fix e2e tests * Fix toolbar a11y * Reload the history after an item is added * Fix unit test * Remove references to Explore from generic PageToolbar component * Update test name * Fix test assertion * Add issue item to TODO * Improve test assertion * Simplify test setup * Move query history settings to persistence layer * Fix test import * Fix unit test * Fix unit test * Test local storage settings API * Code formatting * Fix linting errors * Add an integration test * Add missing aria role * Fix a11y issues * Fix a11y issues * Use divs instead of ul/li Otherwis,e pa11y-ci reports the error below claiming there are no children with role=tab: Certain ARIA roles must contain particular children (https://dequeuniversity.com/rules/axe/4.3/aria-required-children?application=axeAPI) (#reactRoot > div > main > div:nth-child(3) > div > div:nth-child(1) > div > div:nth-child(1) > div > div > nav > div:nth-child(2) > ul) <ul class="css-af3vye" role="tablist"><li class="css-1ciwanz"><a href...</ul> * Clean up settings tab * Remove redundant aria label * Remove redundant container * Clean up test assertions	3 years ago