24 Commits (c761f2e4d93e1361b9c156f4aa479fd1bab7d46e)

Author	SHA1	Message	Date
Torkel Ödegaard	3ee26df41e	PublicDashboards: Variables refactor (#73476) ... Co-authored-by: Juan Cabanas <juan.cabanas@grafana.com> Co-authored-by: Ezequiel Victorero <ezequiel.victorero@grafana.com> Co-authored-by: Ryan McKinley <ryantxu@gmail.com>	2 years ago
Dominik Prokop	34c9faf140	PanelContext: Provide events scope identifier (#71561) ... * PanelContext: Provide events scope identifier * What a console log	2 years ago
Alexa V	b4a7427f31	[Chore] Refactor Panel Menu Rudderstack events and add missing instrumentation (#66850)	2 years ago
Juan Cabanas	47aa8c7654	PublicDashboards: HoverWidget in panel fix (#66685) ... Hover widget modified for public dashboards.	2 years ago
Alexa V	2a67b8ad32	Panel Header Fix: Implement new Panel Header on Angular Panels (#66826) ... Co-authored-by: Dominik Prokop <dominik.prokop@grafana.com>	2 years ago
Torkel Ödegaard	de18ed6659	PanelContext: Add functionality to update data from panel (#66993)	2 years ago
Agnès Toulet	fe5a07f336	Rendering: Fix panel rendered count on error (#67027) ... Rendering: fix panel rendered count on error	2 years ago
Ryan McKinley	39c04a8e36	Chore: Remove deprecated dashboardId from panel query runner (#64786)	2 years ago
Alexa V	fef0ee913c	Panel Header: Add CancelQuery option to panel header (#64796) ... Co-authored-by: Ivan Ortega <ivanortegaalba@gmail.com>	2 years ago
Ivan Ortega Alba	cde1b5b162	PanelHeader: Add analytics for non-menu items (#64729)	2 years ago
Torkel Ödegaard	fb55dd5df6	PanelChrome: Improve error state design (#63776) ... * PanelChrome: Improve error state design * Simplify logic for hoverHeader * padding for the title only for the title, not the whole header * Review fixes * missed saving file --------- Co-authored-by: polinaboneva <polina.boneva@grafana.com>	2 years ago
Andres Martinez Gotor	15aae5e8a9	Panel: Show multiple errors info in the inspector (#64340)	2 years ago
kay delaney	36e474d109	PanelHeaderMenu: Use UI/Menu component (#63040)	2 years ago
kay delaney	40ec4ef5b8	PanelChrome: Implement hover header (#61774) ... Closes #59078 Co-authored-by: polinaboneva <polina.boneva@grafana.com> Co-authored-by: Ivan Ortega <ivanortegaalba@gmail.com> Co-authored-by: Alexandra Vargas <alexa1866@gmail.com>	2 years ago
Torkel Ödegaard	533c8e4b7a	PanelChrome: Adds display mode to support transparent option (#62647) ... * PanelChrome: Add transparent displayMode * Remove comment * Fixes to storybook and new example * no background on TitleItem --------- Co-authored-by: polinaboneva <polina.boneva@grafana.com>	3 years ago
Alexa V	db51e963de	PanelChrome: Allow panel to be dragged if set as draggable from the outside (#61698)	3 years ago
Torkel Ödegaard	9b82e65b7a	TablePanel: Refactor to functional component and move add ad hoc filter action to PanelContext (#61360) ... * FieldOptions: Add filterable as registry added field item * Refactor to functional component, move ad hoc filter to PanelStateWrapper * review tweaks	3 years ago
Torkel Ödegaard	c1d3b59643	PanelChrome: Simplify props and code a bit (#61595) ... * PanelChrome: Simplify props and code a bit * Don't set a default empty array for leftItems so we can know user has set it * fix 'this' is undefined * add storybook examples of statusMessage; remove SB examples of loadingState === Error; simplify loadingState checks in PanelChrome; Co-authored-by: polinaboneva <polina.boneva@grafana.com>	3 years ago
Alexa V	0eeeeef08b	PanelChrome: Refactor and refine items next to title (#60514) ... Co-authored-by: Torkel Ödegaard <torkel@grafana.com> Co-authored-by: Polina Boneva <13227501+polibb@users.noreply.github.com> Co-authored-by: polinaboneva <polina.boneva@grafana.com>	3 years ago
Polina Boneva	84eb275c8d	PanelChrome: Menu is wrapped in a render prop for full outside control (#60537) ... * setup menu as a render prop sent down from PanelStateWrapper to PanelChrome * let the Dropdown take care of opening the menu in PanelChrome * menu and leftItems are on the right side of the header together * add storybook examples with menu * menu does not need to be a callback because it's opened in a Dropdown anyway * pass down to getPanelMenu whether or not data is streaming atm * stop loading data as well as streaming from menu * override menu's style where needed * reduce snapshot matching in tests	3 years ago
Polina Boneva	3f1908464d	PanelChrome: Implement Panel header with error, loading, and streaming data status (#60147) ... * dashboards squad mob! 🔱 lastFile:packages/grafana-ui/src/components/LoadingBar/LoadingBar.tsx * dashboards squad mob! 🔱 * dashboards squad mob! 🔱 lastFile:packages/grafana-ui/src/components/LoadingBar/LoadingBar.tsx * user essentials mob! 🔱 * create grafana/ui LoadingBar and set it up in Storybook * Remove test changes on PanelChrome * Fix mdx page reference * dashboards squad mob! 🔱 lastFile:public/api-merged.json * dashboards squad mob! 🔱 * dashboards squad mob! 🔱 * dashboards squad mob! 🔱 * dashboards squad mob! 🔱 lastFile:public/app/features/dashboard/dashgrid/PanelHeader/PanelHeaderState.tsx * Implemented basic draft of panel header states. Using ToolbarButton instead of IconButton. * use 'warning' styled Button in ToolbarButton * make LoadingBar a simple JSX Element; do not use containerWidth; have a wrapper around the loading bar itself; * fix wrapper around LoadingBar: willChange css prop makes performance of rerendering better * States: Render general panel query error states and render notices next to the title * add streaming to PanelChrome if data is streaming instead of loading * PanelHeaderState with its own state 'mode' * clean up useEffect * notices have their own square space in the size of the panel header * clean up * minor fixes * moving the LoadingBar to core * LoadingBar is not in grafana/ui * always have a place for the loading bar in the PanelChrome, otherwise it moves everything when appearing; remove titleItemsNodes for now - in later development make no changes to Notice component, not part of this PR * Revert "moving the LoadingBar to core" This reverts commit 11f0f4ff2f. * do not use internal comment as it doesn't do anything * integrate LoadingBar in PanelChrome from grafana/ui directly * fix deprecated leftItems comment * Modify annimation to 1 second * remove comments * remove streaming stopped UI because we cannot know when the streaming has stopped * skip unnecessary test for now * no point in removing hoverHeader now, even though it's not yet implemented * small fixes * error state of the data in a panel is positioned in PanelChrome itself, not in PanelHeaderState * Fixed loading state jitter * remove warning state as we have none of it * streaming cannot be stopped from the icon * explicit content container width and height * explicit content container width and height * edit deprecated comment * fix LoadingBar to be relative to width of panel; remove explicit width and height on content strict * no warning state of the data * status of the panel data given directly to PanelChrome, not a node * clean up * clean up console log Co-authored-by: kay delaney <45561153+kaydelaney@users.noreply.github.com> * panel title design fits typography h6 styles; render error status only if error or error message are passed to PanelChrome * add storybook examples; prepare PanelChrome for hoverHeader because this will be a breaking change and it will affect how the storybook example shows up * show storybook example for streaming panel with title because that's the condition for having a header * override margin-bottom: 0.45em of h6 Co-authored-by: Alexandra Vargas <alexa1866@gmail.com> Co-authored-by: Torkel Ödegaard <torkel@grafana.com> Co-authored-by: kay delaney <45561153+kaydelaney@users.noreply.github.com>	3 years ago
Selene	a0334a92f5	Solo Panel: Configurable timezone (#59153) ... * Allow to set timezone in query * Use optional timestamp * Update timeZone	3 years ago
Marcus Andersson	b804b2f073	Plugins: Added hook to make it easier to track interactions in plugins (#56126) ... * first stab at context away plugin tracking. * adding a plugin context and a hook to get hold of a tracker that always appends the plugin context information. * wip * improved the code a bit. * wip * Fixed type errors. * added datasource_uid to data sources. * fixed error message when trying to use hook outside of context. * small refactoring according to feedback. * using the correct provider for data source context. * check not needed. * enforcing the interaction name to start with grafana_plugin_ * exposing guards for the other context type. * added structure for writing reporter hook tests. * added some more tests. * added tests. * reverted back to inheritance between context types. * adding mock for getDataSourceSrv	3 years ago
Alexa V	6524a0b437	Chore: Rename grafana core `PanelChrome` and use `grafana-ui - PanelChrome` component (#56659)	3 years ago
Leo	c4984854b6	added dashboard uid when tracing header in browsermode (#53232)	3 years ago
Leo	1fc9f6f1c6	Annotations: Migrate dashboardId to dashboardUID (#52588) ... * Annotations: replaced dashboardId with dashboardUID when fetching annotations * Annotations: Replaced dashboardID with dashboardUID when adding and updating annotations * Annotations: Used dashboardUID for PanelChrome related methods * Annotations: Used dashboarduid in annolistpanel * Annotations: Used dashboardUID in graph plugin * used boolean in canEditDashboard	3 years ago
Jeff Levin	d076bedb5e	public dashboards: finalize db schema & v1 feature complete (#50467) ... This PR completes public dashboards v1 functionality and simplifies public dashboard conventions. It exists as a large PR so that we are not making constant changes to the database schema. models.PublicDashboardConfig model replaced with models.PublicDashboard directly dashboard_public_config table renamed to dashboard_public models.Dashboard.IsPublic removed from the dashboard and replaced with models.PublicDashboard.isEnabled Routing now uses a uuid v4 as an access token for viewing a public dashboard anonymously, PublicDashboard.Uid only used as database identifier Frontend utilizes uuid for auth'd operations and access token for anonymous access Default to time range defined on dashboard when viewing public dashboard Add audit fields to public dashboard Co-authored-by: Owen Smallwood <owen.smallwood@grafana.com>, Ezequiel Victorero <ezequiel.victorero@grafana.com>, Jesse Weaver <jesse.weaver@grafana.com>	3 years ago
owensmallwood	1bb2d2599c	Public Dashboards: Pubdash panels get data from pubdash api (#50556) ... * Public dashboard query API * Create new API on service for building metric request * Flesh out testing, implement BuildPublicDashboardMetricRequest * Test for errors and missing panels * WIP: Test for multiple datasources * Refactor tests, add supporting code for multiple datasources * Gets the panel data from the pubdash query api * Adds tests to make sure we get the correct api url from retrieving panel data * Public dashboard query API * Create new API on service for building metric request * Flesh out testing, implement BuildPublicDashboardMetricRequest * Test for errors and missing panels * WIP: Test for multiple datasources * Refactor tests, add supporting code for multiple datasources * Handle queries from multiple datasources * Replace dashboard time range with pubdash time range settings * Fix comments from review, build failure * removes changes to DataSourceWithBackend.ts regarding getting the pubdash panel query url. Going to do this in a new class, PublicDashboardDataSource.ts * Include pubdash Uid in dashboard meta * Creates new PublicDashboardDataSource.ts and adds test * Passes pubdash uid down to PanelQueryRunner.ts to a PublicDashboardDatasource can be chosen when were looking at a public dashboard * removes comment * checks for error when unmarshalling json * Only replace dashboard time settings with pubdash time settings when pubdash time settings exist * formatting and added comment Co-authored-by: Jesse Weaver <jesse.weaver@grafana.com> Co-authored-by: Jeff Levin <jeff@levinology.com>	3 years ago
owensmallwood	cfdea1ee30	PublicDashboards: Frontend routing for public dashboards (#48834) ... * add isPublic to dashboard * refactor routes to use route group and add placeholder method for sharing apii * add sharing pane and utils for public dashboard config to sharing modal * Sharing modal now persists data through the api * moves ShareDashboard endpoint to new file and starts adding tests * generates mocks. Adds tests for public dashboard feature flag * Adds ability to pass in array of features to enable for the test * test to update public flag on dashboard WIP * Adds mock for SaveDashboardSharingConfig * Fixes tests. Had to use FakeDashboardService * Adds React tests for public dashboards toggle * removes semicolons * refactors SharePublic component to use hooks * rename from `share publicly` to `public dashboard config` * checkpoint. debugging tests. need to verify name changes * checkpoint. test bugs fixed. need to finish returning proper response codes * finish renaming. fix test * Update pkg/api/api.go Co-authored-by: Torkel Ödegaard <torkel@grafana.com> * update backend url * rename internal objects and commands. fix configuration modal labels * add endpoint for retrieving public dashboard configuration and populate the frontend state from it * add test for dashboardCanBePublic * adds backend routes * copy DashboardPage component into component for public dashboards. WIP * adds react routes, and doesnt render main nav bar when viewing a public route * removes extra react route from testing * updates component name * Wrap the original dashboard component so we can pass props relevant to public dashboards, turn kiosk mode on/off, etc * Wraps DashboardPage in PublicDashboardPage component. DashboardPage gets rendered in kiosk mode when public prop is passed. * removes commented out code from exploratory work * Makes public dashboard routes require no auth * extracts helper to own util file to check if were viewing a public page * Hides panel dropdown when its being viewed publicly * formatting * use function from utils file for determining if publicly viewed. If public, hides app notifications, searchwrapper, and commandpalette. * adds unit tests for util function used to see if page is being viewed publicly * cant added annotations to panel when being publicly viewed * removes useless comment * hides backend and frontend pubdash routes behind feature flag * consider feature flag when checking url path to see if on public dashboard * renames function * still render app notifications when in public view * Extract pubdash route logic into own file * fixes failing tests * Determines path using location locationUtils. This covers the case when grafana is being hosted on a subpath. Updates tests. * renames pubdash web route to be more understandable * rename route * fixes failing test * fixes failing test. Needed to update pubdash urls * sets flag on grafana boot config for if viewing public dashboard. Removes hacky check that looks at the url * fixes failing tests. Uses config to determine if viewing public dashboard * renders the blue panel timeInfo on public dashboard panel * Extracts conditional logic for rendering components out into their own functions * removes publicDashboardView check, and uses dashboard meta instead * the timeInfo is always displayed on the panel * After fetch of public dashboard dto, the meta isPublic flag gets set and used to determine if viewing public dashboard for child components. Fixes tests for PanelHeader. * Fixes failing test. Needed to add isPublic flag to dashboard meta. Co-authored-by: Jeff Levin <jeff@levinology.com> Co-authored-by: Torkel Ödegaard <torkel@grafana.com>	3 years ago
Josh Hunt	3c6e0e8ef8	Chore: ESlint import order (#44959) ... * Add and configure eslint-plugin-import * Fix the lint:ts npm command * Autofix + prettier all the files * Manually fix remaining files * Move jquery code in jest-setup to external file to safely reorder imports * Resolve issue caused by circular dependencies within Prometheus * Update .betterer.results * Fix missing // @ts-ignore * ignore iconBundle.ts * Fix missing // @ts-ignore	3 years ago
Ezequiel Victorero	6a059dcb4d	Access Control: hiding add annotation button without permissions (#47223) ... * Access Control: hiding add annotation button without permissions	3 years ago
Ezequiel Victorero	76b221e9d5	Access Control: hiding annotation edition and deletion without permissions (#46904) ... * Access Control: disabling annotation edition without FGAC permissions	3 years ago
Dominik Prokop	7bf25f62e1	Cursor sync: Apply the settings without saving the dashboard (#44270) ... * Cursor sync: Apply the settings without saving the dashboard * Remove unnecessary code * Lint god damn	4 years ago
Torkel Ödegaard	54af57b8e6	VisualizationSelection: Real previews of suitable visualisation and options based on current data (#40527) ... * Initial pass to move panel state to it's own, and make it by key not panel.id * Progress * Not making much progress, having panel.key be mutable is causing a lot of issues * Think this is starting to work * Began fixing tests * Add selector * Bug fixes and changes to cleanup, and fixing all flicking when switching library panels * Removed console.log * fixes after merge * fixing tests * fixing tests * Added new test for changePlugin thunk * Initial struture in place * responding to state changes in another part of the state * bha * going in a different direction * This is getting exciting * minor * More structure * More real * Added builder to reduce boiler plate * Lots of progress * Adding more visualizations * More smarts * tweaks * suggestions * Move to separate view * Refactoring to builder concept * Before hover preview test * Increase line width in preview * More suggestions * Removed old elements of onSuggestVisualizations * Don't call suggestion suppliers if there is no data * Restore card styles to only borders * Changing supplier interface to support data vs option suggestion scenario * Renamed functions * Add dynamic width support * not sure about this * Improve suggestions * Improve suggestions * Single grid/list * Store vis select pane & size * Prep for option suggestions * more suggestions * Name/title option for preview cards * Improve barchart suggestions * Support suggestions when there are no data * Minor change * reverted some changes * Improve suggestions for stacking * Removed size option * starting on unit tests, hit cyclic dependency issue * muuu * First test for getting suggestion seems to work, going to bed * add missing file * A basis for more unit tests * More tests * More unit tests * Fixed unit tests * Update * Some extreme scenarios * Added basic e2e test * Added another unit test for changePanelPlugin action * More cleanup * Minor tweak * add wait to e2e test * Renamed function and cleanup of unused function * Adding search support and adding search test to e2e test	4 years ago
Zoltán Bedi	e6d2324516	Time series/Bar chart panel: Add ability to sort series via legend (#40226) ... * Make legend sorting work in Time series panel * Import from schema Add properties to the cue schema as well * Order stacking * Add tests for orderIdsByCalcs * Add check for legend options * Fix cue schema * UI fixes * Order bars as well in barchart * Use different index when ordered * Legend sort series doc * Fix nits * Update docs/sources/panels/legend-options.md Co-authored-by: Dominik Prokop <dominik.prokop@grafana.com> * Fix linting * Apply suggestions from code review Co-authored-by: Ursula Kallio <73951760+osg-grafana@users.noreply.github.com> * Update docs/sources/panels/legend-options.md Co-authored-by: Dominik Prokop <dominik.prokop@grafana.com> Co-authored-by: Ursula Kallio <73951760+osg-grafana@users.noreply.github.com>	4 years ago
Torkel Ödegaard	a091d35f11	ErrorBoundary: Support recovering from errors in PanelChrome & PanelRenderer (#40785) ... * ErrorBoundary: Support recovering from errors in PanelChrome & PanelRenderer * Rename recover to dependencies * Pushed an update that fixed test and adds new error mode to DebugPanel	4 years ago
Ryan McKinley	ad69de4a10	AppEvents: export appEvents in @grafana/runtime and support copy panel (#40715)	4 years ago
Torkel Ödegaard	d62ca1283c	PanelState: Introduce a new separate redux panel state not keyed by panel.id (#40302) ... * Initial pass to move panel state to it's own, and make it by key not panel.id * Progress * Not making much progress, having panel.key be mutable is causing a lot of issues * Think this is starting to work * Began fixing tests * Add selector * Bug fixes and changes to cleanup, and fixing all flicking when switching library panels * Removed console.log * fixes after merge * fixing tests * fixing tests * Added new test for changePlugin thunk	4 years ago
Domas	571257226e	Alerting: make alert state indicator in panel header work with Grafana 8 alerts (#38713)	4 years ago
Torkel Ödegaard	e0b576fff4	PanelContext: Adds app property of type CoreApp enum to inform panel about what the outer container/app is (#39952) ... * PanelContext: Adds a container enum / string to inform panel about what the outer container/app state is * Changing to use existing CoreApp * fixing unified alerting type errors	4 years ago
Torkel Ödegaard	962745ff21	PanelEditor: Adds panel instance state and a way to share this between panel & option editors (#39637) ... * PanelEditor: Adds panel instance state and a way to share this between panel & option editors * Refactoring to use PanelContext	4 years ago
Sofia Papagiannaki	012d4f0905	Alerting: Remove `ngalert` feature toggle and introduce two new settings for enabling Grafana 8 alerts and disabling them for specific organisations (#38746) ... * Remove `ngalert` feature toggle * Update frontend Remove all references of ngalert feature toggle * Update docs * Disable unified alerting for specific orgs * Add backend tests * Apply suggestions from code review Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com> * Disabled unified alerting by default * Ensure backward compatibility with old ngalert feature toggle * Apply suggestions from code review Co-authored-by: gotjosh <josue@grafana.com>	4 years ago
Peter Holmberg	4f7e1db57c	Graphs: Fix threshold handle being visible in dashboards (#39270)	4 years ago
Peter Holmberg	74beb9a64c	Alerting: Edit thresholds by handle in timeseries panel (#38881) ... * POC/Thresholds: Allow thresholds modification directly from the time series panel * Snapshot updates * Optimize styles memoization * change threshold from graph * renames and logging * using useeffect to update graph * Fix react worning about setting state on unmounted component * revert panelrenderer * using onFieldConfig change * use a useeffect * simplied fieldConfig state * Do not use plot context in ThresholdControlsPlugin * Do not throw setState warnings when drag handle is dropped * Update thresholds position on the graph when updating threshold drag handle * fix issues with rerenders * prevent thresholds on conditions with range * only edit the first threshold Co-authored-by: Dominik Prokop <dominik.prokop@grafana.com>	4 years ago
Ryan McKinley	8c4c05493b	Dashboard: keep live timeseries moving left (v2) (#37769)	4 years ago
Hugo Häggmark	4ba2636aba	Dashboard: Fix so panels are rendered correctly on SoloPanelPage (#38050) ... * Dashboard: Fix so panels are rendered correctly on SoloPanelPage * Refactor: narrows down the path	4 years ago
Ashley Harrison	344c43f2e8	PanelEdit: Fix 'Actual' size by passing the correct panel size to DashboardPanel (#37885)	4 years ago
Ryan McKinley	ffa0ef9b3d	Annotations: fire an event when changing annotations (#37175)	4 years ago
Ryan McKinley	be4b753aa0	Panels: allow interaction in corners when no title exists (#37169)	4 years ago
Tobias Skarhed	cfd06775c0	Dashboard: Add accessible landmark markup (#36753) ... * Add landmark markup * Make panel titles h2 * Descibe panel landmarks * Add nav elements and heading 1 * Reset line height and remove margin * Make focus styles visible * Change nav to section * Add desc * Fix focus styles cutoff	4 years ago