35 Commits (cf684ed38f8a45c1dbdb76b7ce2256120f3aec23)

Author	SHA1	Message	Date
Jean-Philippe Quéméner	cf684ed38f	Alerting: bump rule version when updating rule group interval (#50295) ... * Alerting: move group update to alert rule service * rename validateAlertRuleInterval to validateRuleGroupInterval * init baseinterval correctly * add seconds suffix * extract validation function for reusability * add context to err message	4 years ago
Yuriy Tseretyan	a89d4a5be7	Alerting: Scheduler to drop ticks if a rule's evaluation is too slow (#48885) ... * drop ticks if evaluation of a rule is too slow. * add metric schedule_rule_evaluations_missed_total	4 years ago
Yuriy Tseretyan	49d93fb67e	Alerting: Update alert rule diff to not see difference between nil and empty map (#50192)	4 years ago
Yuriy Tseretyan	ad25e2a20c	Alerting: Update RBAC for alert rules to consider access to rule as access to group it belongs (#49033) ... * update authz to exclude entire group if user does not have access to rule * change rule update authz to not return changes because if user does not have access to any rule in group, they do not have access to the rule * a new query that returns alerts in group by UID of alert that belongs to that group * collect all affected groups during calculate changes * update authorize to check access to groups * update tests for calculateChanges to assert new fields * add authorization tests	4 years ago
Joe Blubaugh	1d724810de	Alerting: State Manager takes screenshots. (#49338) ... The State Manager will now take screenshots when an alert instance switches to an Alerting or Resolved state. Signed-off-by: Joe Blubaugh joe.blubaugh@grafana.com	4 years ago
George Robinson	43358c7248	Alerting: Keep private annotations across evaluations (#49080)	4 years ago
Yuriy Tseretyan	952cb4fc0b	Alerting: introduce AlertRuleGroupKey and use it in API handlers (#48945) ... * create AlertGroupKey structure * update PrometheusSrv. - extract creation of RuleGroup to a separate method. Use group key for grouping * update RuleSrv - update calculateChanges to use groupKey - authorize to use groupkey	4 years ago
Yuriy Tseretyan	369fcc5e9a	Alerting: scheduler to use short version of model for alert rule (#48916) ... * scheduler to use a short version of alert rule model	4 years ago
George Robinson	c5547123bc	Remove redundant queries in GetAlertRules and GetOrgAlertRules and replace with ListAlertRules (#48108)	4 years ago
George Robinson	d66fc6ed1a	Alerting: Add GetRuleGroups to RuleStore (#48036) ... This commit adds a new method GetRuleGroups to RuleStore which returns the set of rule groups across all organizations.	4 years ago
Yuriy Tseretyan	4ee48c2e77	Alerting: Update GetRuleGroupAlertRules to accept optional rule group (#46889) ... * rename GetRuleGroupAlertRules to GetAlertRules * make rule group optional in GetAlertRulesQuery * simplify FakeStore. the current structure did not support optional rule group	4 years ago
gotjosh	a338c78ca8	Alerting: Remove internal labels from prometheus compatible API responses (#46548) ... * Alerting: Remove internal labels from prometheus compatible API responses * Appease the linter * Fix integration tests * Fix API documentation & linter * move removal of internal labels to the models	4 years ago
Yuriy Tseretyan	4502e40ed8	Alerting: Revert Revert "Alerting: Calculate diff for two AlertRules" (#46034) ... * Revert "Revert "Alerting: Calculate diff for two AlertRules (#45877)" (#46023)" This reverts commit 82aa5acba6. * remove flakiness	4 years ago
Jean-Philippe Quéméner	82aa5acba6	Revert "Alerting: Calculate diff for two AlertRules (#45877)" (#46023) ... This reverts commit 4e19d7df63.	4 years ago
Yuriy Tseretyan	4e19d7df63	Alerting: Calculate diff for two AlertRules (#45877) ... * add custom diff reporter DiffReporter that reports only paths that have a difference * create Diff method for AlertRule that returns DiffReport, which is an alias for []Diff Tests: * create copy method for AlertRule in testing * create GenerateAlertQuery method in testing	4 years ago
Yuriy Tseretyan	f75bea481d	Alerting: validate rules and calculate changes in API controller (#45072) ... * Update API controller - add validation of rules API model - add function to calculate changes between the submitted alerts and existing alerts - update RoutePostNameRulesConfig to validate input models, calculate changes and apply in a transaction * Update DBStore - delete unused storage method. All the logic is moved upstream. - upsert to not modify fields of new by values from the existing alert - if rule has UID do not try to pull it from db. (it is done upstream) * Add rule generator	4 years ago
Alexander Weaver	935059a376	Alerting: Create basic storage layer for provisioning (#44679) ... * Simplistic store API for provenance lookups on arbitrary types * Add a few notes in comments * Improved type safety for provisioned objects * Clean-up TODOs for future PRs * Clean up provisioning model * Clean up tests * Restrict allowable types in interface * Fix linter error * Move AlertRule domain methods to same file as AlertRule definition * Update pkg/services/ngalert/models/provisioning.go Co-authored-by: George Robinson <george.robinson@grafana.com> * Complete interface rename * Pass context through store API * More idiomatic method names * Better error description * Improve code-docs * Use ORM language instead of raw sql * Add support for records in different orgs * ResourceTypeID -> ResourceType since it's not an ID Co-authored-by: George Robinson <george.robinson@grafana.com>	4 years ago
George Robinson	1b26d4d88e	Alerting: Create DatasourceError alert if evaluation returns error (#41869) ... * Alerting: Create DatasourceError alert if evaluation returns error * Alerting: Add docs for DatasourceError alert * Alerting: Fix DatasourceError alert does not have dashboard_uid label * Alerting: Add break when datasource_uid found * Alerting: Update TestProcessEvalResults	4 years ago
Yuriy Tseretyan	5836def6c2	Alerting: declare constants for __dashboardUid__ and __panelId__ literals (#39976)	4 years ago
George Robinson	2a4c1b1aa6	You can now get alert rules for a dashboard or a panel using /api/v1/rules endpoints. (#39476) ... Get alert rules for a dashboard and panel in /api/v1/rules	4 years ago
Sofia Papagiannaki	012d4f0905	Alerting: Remove `ngalert` feature toggle and introduce two new settings for enabling Grafana 8 alerts and disabling them for specific organisations (#38746) ... * Remove `ngalert` feature toggle * Update frontend Remove all references of ngalert feature toggle * Update docs * Disable unified alerting for specific orgs * Add backend tests * Apply suggestions from code review Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com> * Disabled unified alerting by default * Ensure backward compatibility with old ngalert feature toggle * Apply suggestions from code review Co-authored-by: gotjosh <josue@grafana.com>	4 years ago
Sofia Papagiannaki	7815ed511f	Alerting: Refactor API endpoints for fetching alert rules (#37055) ... * Refactor ruler API endpoint for listing rules * Refactor prometheus API endpoint for listing rules * Update HTTP API docs	5 years ago
Ganesh Vernekar	dcd4bf1615	Alerting: Fill the empty GeneratorURL (#35740) ... Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>	5 years ago
Sofia Papagiannaki	8cda1f5153	Alerting: Allow rules with same title across folders (#35270) ... * Alerting: Allow rules with same title across folders * Add test	5 years ago
David Parrott	bbb7bbf891	Alerting: Remove back end logic for supporting KeepLastState (#34242) ... * Removed back end logic for supporting KeepLastState * Map keep_state correctly in migrations	5 years ago
Kyle Brandt	b590e95682	AlertingAPI: Change list response query prop (#33419) ... * Alerting: change to full []AlertQuery as json in a string and not just model.	5 years ago
David Parrott	788bc2a793	Alerting: refactor state tracker (#33292) ... * set processing time * merge labels and set on response * use state cache for adding alerts to rules * minor cleanup * add support for NoData and Error results * rename test * bring in changes from other PRs tha have been merged * pr feedback * add integration test * close state tracker cleanup on context.Done * fixup test * rename state tracker * set EvaluationDuration on Result * default labels set as constants * separate cache and state from manager * use RWMutex in cache	5 years ago
Sofia Papagiannaki	87a70af7eb	[Alerting]: Fix updating rule group and add tests (#33074) ... * [Alerting]: Fix updating rule group and add test * Fix updating rule labels * Set default values for rule no data and error states if they are missing * Add test for updating rule * Test updating annotations * Apply suggestions from code review Co-authored-by: gotjosh <josue@grafana.com> * add test for posting an unknown rule UID * Fix alert rule validation and add tests * Remove org id from PostableGrafanaRule This field was not used; each rule gets the organisation of the user making the rerquest * Update pkg/tests/api/alerting/api_alertmanager_test.go Co-authored-by: gotjosh <josue@grafana.com>	5 years ago
gotjosh	362c4d4276	Alerting: Integration test rule creation (#33047) ... * Alerting: Integration test rule creation * Appease the linter * Cleanup * Make anonymous user role a parameter	5 years ago
David Parrott	2276e9556a	Alerting: set query in rules response (#33010) ... * set query in rules response * Theme: tweaking dark theme colors (#33007) * Library Panels: Add library panel tab to share modal (#32953) * Explore: Scroll split panes in Explore independently (#32978) * Change default prometheus to latest and prometheus v1 to prometheus1 * Update README * Remove prometheus1 block as not used * Explore: Separatae scrolling in split view * Update snapshot * Allow skip migrations in tests via environment variable (#32958) * Dashboard: Fix issue where Slack notifications won't link to users (#32861) * DashboardPage: refactored styles from sass to emotion (#32955) * DashboardPage: refactored styles from sass to emotion * refactored dashboardPage component to be alot easier to read and understand * more refactoring... * more cleaning... * fixes frontend test * fixes frontend test- I hope * fixes frontend test- I hope * moves dashboard scss styles back to it's standalone file * GraphNG: use theme font family and size for axis labels (#33009) * GraphNG: use theme font family and size for axis labels * fix test * AlertingNG: Slack notification channel (#32675) * AlertingNG: Slack notification channel Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * Add tests Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * Fix review comments Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * Fix review comments and small refactoring Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * GraphNG: stacking (#30749) * First iteration * Dev dash * Re-use StackingMode type * Fix ts and api issues * Stacking work resurected * Fix overrides * Correct values in tooltip and updated test dashboard * Update dev dashboard * Apply correct bands for stacking * Merge fix * Update snapshot * Revert go.sum * Handle null values correctyl and make filleBelowTo and stacking mutual exclusive * Snapshots update * Graph->Time series stacking migration * Review comments * Indicate overrides in StandardEditorContext * Change stacking UI editor, migrate stacking to object option * Small refactor, fix for hiding series and dev dashboard * VizLegend: sets a min and max value of the seriesCount control in Storybook (#33022) * Alerting: Filter rules list (#32818) * Chore: Reduces strict errors (#33012) * Chore: reduces strict error in OptionPicker tests * Chore: reduces strict errors in FormDropdownCtrl * Chore: reduces has no initializer and is not definitely assigned in the constructor errors * Chore: reduces has no initializer and is not definitely assigned in the constructor errors * Chore: lowers strict count limit * Tests: updates snapshots * Tests: updates snapshots * Chore: updates after PR comments * Refactor: removes throw and changes signature for DashboardSrv.getCurrent * [Alerting]: Several modifications in alert rules (#32983) * [Alerting]: Use common properties for all rules * Add Labels in rules * Fix update ruleGroup API Return 400 Bad Request response when the request contains a UID that does not exist * Check permissions and return namespace id * Apply suggestions from code review Co-authored-by: gotjosh <josue@grafana.com> * WIP (#33025) * Chore: Bump strict error count limit (#33035) * set query in rules response Co-authored-by: Torkel Ödegaard <torkel@grafana.org> Co-authored-by: kay delaney <45561153+kaydelaney@users.noreply.github.com> Co-authored-by: Ivana Huckova <30407135+ivanahuckova@users.noreply.github.com> Co-authored-by: Dafydd <72009875+dafydd-t@users.noreply.github.com> Co-authored-by: n-wbrown <n-wbrown@users.noreply.github.com> Co-authored-by: Uchechukwu Obasi <obasiuche62@gmail.com> Co-authored-by: Leon Sorokin <leeoniya@gmail.com> Co-authored-by: Ganesh Vernekar <15064823+codesome@users.noreply.github.com> Co-authored-by: Dominik Prokop <dominik.prokop@grafana.com> Co-authored-by: Nathan Rodman <nathanrodman@gmail.com> Co-authored-by: Hugo Häggmark <hugo.haggmark@grafana.com> Co-authored-by: Sofia Papagiannaki <papagian@users.noreply.github.com> Co-authored-by: gotjosh <josue@grafana.com> Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com>	5 years ago
Sofia Papagiannaki	6bbb2fd4ba	[Alerting]: Several modifications in alert rules (#32983) ... * [Alerting]: Use common properties for all rules * Add Labels in rules * Fix update ruleGroup API Return 400 Bad Request response when the request contains a UID that does not exist * Check permissions and return namespace id * Apply suggestions from code review Co-authored-by: gotjosh <josue@grafana.com>	5 years ago
Sofia Papagiannaki	624fbf5dda	[Alerting]: Fix empty rules evaluation statuses (#32997) ... * [Alerting]: Fix empty rules evaluation statuses `GetRuleGroupAlertRules()` requires an non empty namespaceUID * Include the namespace into the response	5 years ago
David Parrott	567a6a09bd	Alerting: Return RuleResponse for api/prometheus/grafana/api/v1/rules (#32919) ... * Return RuleResponse for api/prometheus/grafana/api/v1/rules * change TODO to note Co-authored-by: gotjosh <josue@grafana.com> * pr feedback * test fixup Co-authored-by: gotjosh <josue@grafana.com>	5 years ago
Kyle Brandt	80dfa83380	AlertingNG: Add For+Annotations to Grafana_Alert (#32793) ... * add db columns * Fix deserialisation issue of AlertRule For field (#32848) * Update to latest alerting-api Co-authored-by: Sofia Papagiannaki <papagian@users.noreply.github.com>	5 years ago
Sofia Papagiannaki	ee06970d72	[Alerting]: Grafana managed ruler API implementation (#32537) ... * [Alerting]: Grafana managed ruler API impl * Apply suggestions from code review * fix lint * Add validation for ruleGroup name length * Fix MySQL migration Co-authored-by: kyle <kyle@grafana.com>	5 years ago