112 Commits (d0c2b19c51a94e4cb5e8d1393bc8e739e66594a9)

Author	SHA1	Message	Date
bergquist	c817aecd66	provisioning: only update dashboard if hash of json changed	8 years ago
Mario Trangoni	91fb2e07ce	pkg: fix codespell issues	8 years ago
Marcus Efraimsson	4f44376564	remove comment/unused variable	8 years ago
Marcus Efraimsson	b4863002c9	permission: fix user with org viewer save/move permissions ... User with org viewer role should not be able to save/move dashboards in/to general folder.	8 years ago
bergquist	949484b949	provisioning: simplify db query ... the GetProvisionedDashboardQuery wasent used for anything else than check if a dashboard is provisioned or not. So we simplified this query to make it more maintainable.	8 years ago
bergquist	7845eab502	provisioning: fixes typo	8 years ago
bergquist	5596707531	alert: fixes broken link back to grafana ... If Grafana was configured to use a subpath it was included twice in the link from the alert notification back to Grafana. closes #11403	8 years ago
bergquist	627df67992	dashboards: reject updates of provisioned dashboards	8 years ago
bergquist	d6faa3d06f	provisioning: improve UX when saving provisioned dashboards	8 years ago
Marcus Efraimsson	3f588b4c48	dashboards: created/updated and createdby/updatedby should be set before save ... If creating a new folder/dashboard created/updated and createdby/updatedby should always be set. If updating an existing folder/dashboard updated and updatedby should always be set.	8 years ago
Marcus Efraimsson	53cd39fde5	Shouldn't be able to overwrite a dashboard if you don't have permissions (#10900) ... * dashboards: new command for validating dashboard before update Removes validation logic from saveDashboard and later on use the new command for validating dashboard before saving a dashboard. This due to the fact that we need to validate permissions for overwriting other dashboards by uid and title. * dashboards: use the new command for validating dashboard before saving Had to refactor dashboard provisioning a bit to be able to sidetrack the permission validation in a somewhat reasonable way. Adds some initial tests of the dashboard repository, but needs to be extended later. At least now you can mock the dashboard guardian * dashboards: removes validation logic in the save dashboard api layer Use the dashboard repository solely for create/update dashboards and let it do all the validation. One exception regarding quota validation which still is in api layer since that logic is in a macaron middleware. Need to move out-commented api tests later. * dashboards: fix database tests for validate and saving dashboards * dashboards: rename dashboard repository to dashboard service Split the old dashboard repository interface in two new interfaces, IDashboardService and IDashboardProvisioningService. Makes it more explicit when using it from the provisioning package and there's no possibility of calling an incorrect method for saving a dashboard. * database: make the InitTestDB function available to use from other packages * dashboards: rename ValidateDashboardForUpdateCommand and some refactoring * dashboards: integration tests of dashboard service * dashboard: fix sqlstore test due to folder exist validation * dashboards: move dashboard service integration tests to sqlstore package Had to move it to the sqlstore package due to concurrency problems when running against mysql and postgres. Using InitTestDB from two packages added conflicts when clearing and running migrations on the test database * dashboards: refactor how to find id to be used for save permission check * dashboards: remove duplicated dashboard tests * dashboards: cleanup dashboard service integration tests * dashboards: handle save dashboard errors and return correct http status * fix: remove log statement * dashboards: import dashboard should use dashboard service Had to move alerting commands to models package due to problems with import cycles of packages. * dashboards: cleanup dashboard api tests and add some tests for post dashboard * dashboards: rename dashboard service interfaces * dashboards: rename dashboard guardian interface	8 years ago
Leonard Gram	fa1b92a12b	provisioning: uses unix epoch timestamps. (#10907) ... * provisioning: uses unix epoch timestamps.	8 years ago
Torkel Ödegaard	8e8f3c4332	dashboard and folder search with permissions	8 years ago
Marcus Efraimsson	0e8377a9f4	Update logic for create/update dashboard, validation and plugin dashboard links (#10809) ... * enables overwrite if dashboard allready exist in folder * dashboard: Don't allow creating a folder named General * dashboards: update logic for save/update dashboard No id and uid creates a new dashboard/folder. No id and uid, with an existing title in folder allows overwrite of dashboard. Id without uid, allows update of existing dashboard/folder without overwrite. Uid without id allows update of existing dashboard/folder without overwrite. Id without uid, with an existing title in folder allows overwrite of dashboard/folder and updated will have the uid of overwritten. Uid without id, with an existing title in folder allows overwrite of dashboard/folder and new will have the same uid as provided. Trying to change an existing folder to a dashboard yields error. Trying to change an existing dashboard to a folder yields error. * dashboards: include folder id when confirmed to save with overwrite * dashboards: fixes due to new url structure Return importedUrl property in response to importing dashboards and getting plugin dashboards and use this for redirects/links in the frontend.	8 years ago
Carl Bergquist	cc0cc8dd73	changes to new urlformat for home dashboard (#10738)	8 years ago
bergquist	fcd86fb24f	make it easier for dashboards to generate ur;	8 years ago
bergquist	992fd37010	alert: use new url format	8 years ago
Marcus Efraimsson	90933b0621	dashboard: refactor logic for retrieving url for folder/dashboard	8 years ago
Marcus Efraimsson	b23560ed5a	dashboards: add validation to delete dashboard by slug ... Validates that there are only one folder/dashboard having that slug, otherwise returns 412 Precondition Failed	8 years ago
bergquist	58cfb23625	retry uid generation	8 years ago
bergquist	7e96052594	ensure dashboard title is unique in folder	8 years ago
bergquist	bb3183f6cd	removes uniqnes check on slug when saving dashboards	8 years ago
Daniel Lee	eb765d288c	alertlist: disable pause button when user does not have permission	8 years ago
Marcus Efraimsson	fd59241e35	dashboards: revert adding api for retrieving uid by slug ... Since we're already have possibility to get a dashboard by slug it makes little sense to have a separate endpoint in api for retrieving uid by slug. #7883	8 years ago
Marcus Efraimsson	4829ea0e9f	util: remove retry logic in shortid_generator ... Use shortid.MustGenerate() instead of shortid.Generate(). Instead of returning errors it will panic.	8 years ago
Marcus Efraimsson	9fb7b887db	dashboards: add url property to dashboard meta and search api responses ... #7883	8 years ago
Marcus Efraimsson	7ee691dc48	dashboards: api for retrieving uid by slug. #7883	8 years ago
Marcus Efraimsson	13d5db7d19	dashboards: add support for retrieving a dashboard by uid ... Introduces new url in api /dashboards/<uid> for fetching dashboard by unique id Leave the old dashboard by slug url /dashboards/db/<slug> for backward compatibility and for supporting fallback WIP for #7883	8 years ago
Marcus Efraimsson	e229f8aea8	dashboards: extract short uid generator to util package. #7883	8 years ago
Marcus Efraimsson	5b35c694dc	dashboard: generate and include uid in dashboard model. #7883	8 years ago
Marcus Efraimsson	f08932b78a	WIP: folder api. #10630	8 years ago
bergquist	d62d5c7418	provisioning: delete dashboards from db when file is missing	8 years ago
bergquist	67a9e6a71d	provisioing: add lookup table provisioned dashboards	8 years ago
Daniel Lee	94a54248c1	dashfolders: show folders use can save to in picker ... Instead of returning all folders a user has some sort of access to, this change creates a new end point that returns folders the user has write access to. This new endpoint is used in the folder picker	8 years ago
bergquist	237d469ed4	dashboards as cfg: create dashboard folders if missing ... closes #10259	8 years ago
bergquist	16f072b320	dashboards as cfg: move saving logic for dashboards into its own service	8 years ago
bergquist	d69b63cbc0	dashboards as cfg: read first cfg version	8 years ago
Marcus Efraimsson	a335150ad1	dashfolders: Add a helper for creating a dashboard folder	8 years ago
Torkel Ödegaard	fc69d59cae	dashboard folder search fix	9 years ago
Torkel Ödegaard	cbbbccf12a	refactoring dashoard folder guardian	9 years ago
Daniel Lee	dd02bf7c9b	WIP: adds API check to stop folders being included in folders	9 years ago
Daniel Lee	9f79b9b8c5	WIP: fix go fmt error	9 years ago
Daniel Lee	97c13b77bf	WIP: Add or update Dashboard ACL ... SQL Integration Tests for the guardian class too.	9 years ago
Daniel Lee	3785894b40	WIP: guardian service for search ... Removes restricted dashboards from search result.	9 years ago
Daniel Lee	1248728d7f	WIP: rough prototype of dashboard folders ... Breaks some stuff like selected dash in the search result. In dashboard search, if the user is not searching then the result is returned as a tree structure. No ACL's or user group ux yet.	9 years ago
Torkel Ödegaard	cabbfe9adc	refactoring: moved dashboard history item formating (message) and fixed dashboard history migration issue, and removed from frontend tests that where no longer needed	9 years ago
Torkel Ödegaard	c87418d060	refactoring: Dashboard history restore operation is now reusing existing ... operations instead of duplicating a bunch of get & save logic.	9 years ago
Torkel Ödegaard	e18007153d	refactoring: Renamed dashboard version queries that wrongly had Command suffix, added missing OrgId to dashboard history commands and queries	9 years ago
Ben Tranter	b6e46c9eb8	History and Version Control for Dashboard Updates ... A simple version control system for dashboards. Closes #1504. Goals 1. To create a new dashboard version every time a dashboard is saved. 2. To allow users to view all versions of a given dashboard. 3. To allow users to rollback to a previous version of a dashboard. 4. To allow users to compare two versions of a dashboard. Usage Navigate to a dashboard, and click the settings cog. From there, click the "Changelog" button to be brought to the Changelog view. In this view, a table containing each version of a dashboard can be seen. Each entry in the table represents a dashboard version. A selectable checkbox, the version number, date created, name of the user who created that version, and commit message is shown in the table, along with a button that allows a user to restore to a previous version of that dashboard. If a user wants to restore to a previous version of their dashboard, they can do so by clicking the previously mentioned button. If a user wants to compare two different versions of a dashboard, they can do so by clicking the checkbox of two different dashboard versions, then clicking the "Compare versions" button located below the dashboard. From there, the user is brought to a view showing a summary of the dashboard differences. Each summarized change contains a link that can be clicked to take the user a JSON diff highlighting the changes line by line. Overview of Changes Backend Changes - A `dashboard_version` table was created to store each dashboard version, along with a dashboard version model and structs to represent the queries and commands necessary for the dashboard version API methods. - API endpoints were created to support working with dashboard versions. - Methods were added to create, update, read, and destroy dashboard versions in the database. - Logic was added to compute the diff between two versions, and display it to the user. - The dashboard migration logic was updated to save a "Version 1" of each existing dashboard in the database. Frontend Changes - New views - Methods to pull JSON and HTML from endpoints New API Endpoints Each endpoint requires the authorization header to be sent in the format, ``` Authorization: Bearer <jwt> ``` where `<jwt>` is a JSON web token obtained from the Grafana admin panel. `GET "/api/dashboards/db/:dashboardId/versions?orderBy=<string>&limit=<int>&start=<int>"` Get all dashboard versions for the given dashboard ID. Accepts three URL parameters: - `orderBy` String to order the results by. Possible values are `version`, `created`, `created_by`, `message`. Default is `versions`. Ordering is always in descending order. - `limit` Maximum number of results to return - `start` Position in results to start from `GET "/api/dashboards/db/:dashboardId/versions/:id"` Get an individual dashboard version by ID, for the given dashboard ID. `POST "/api/dashboards/db/:dashboardId/restore"` Restore to the given dashboard version. Post body is of content-type `application/json`, and must contain. ```json { "dashboardId": <int>, "version": <int> } ``` `GET "/api/dashboards/db/:dashboardId/compare/:versionA...:versionB"` Compare two dashboard versions by ID for the given dashboard ID, returning a JSON delta formatted representation of the diff. The URL format follows what GitHub does. For example, visiting [/api/dashboards/db/18/compare/22...33](http://ec2-54-80-139-44.compute-1.amazonaws.com:3000/api/dashboards/db/18/compare/22...33) will return the diff between versions 22 and 33 for the dashboard ID 18. Dependencies Added - The Go package [gojsondiff](https://github.com/yudai/gojsondiff) was added and vendored.	9 years ago
Pavlos Daoglou	7f7f080ad8	[5443] Check if title is empty before save a new dashboard	9 years ago