4174 Commits (d1b98499462d5e21e13c306ae7e659a33c936b7f)

Author	SHA1	Message	Date
Karl Persson	d1b9849946	RBAC: Fix background users to include permissions (#55147) ... * RBAC: add function to construct background users * PluginDashboards: Set rbac permissions for user * Dashboards: use background user constructor	3 years ago
Karl Persson	870929b463	RBAC: Add cache for oss rbac permissions (#55098) ... * RBAC: Add cache for oss permissions * RBAC: include service account actions * RBAC: revert changes to fetch service account permissions * Update comment for setting * RBAC: Disable permission chache for tests	3 years ago
Alexander Weaver	9f45e2e706	Alerting: Fix legacy migration crash when rule name is too long (#55053) ... * Extract standardized UID field length to constant * Extract default length to constant * Truncate rule names that are too long * Add tests for name normalization * Fix whitespace lint error * Another linter fix * Empty commit to kick build	3 years ago
Guilherme Caulada	b06eaf66b6	Public Dashboards: Replace simplejson with TimeSettings on dashboard struct (#55047) ... * Replace simplejson for TimeSettings on PublicDashboard struct * Implement xorm conversion interface to TimeSettings * Fix minor test assertion issue	3 years ago
Artur Wierzbicki	e19f36649f	Storage: `Content` root storage (#54929) ... Co-authored-by: Ryan McKinley <ryantxu@gmail.com>	3 years ago
Emil Tullstedt	b287047052	Chore: Upgrade Go to 1.19.1 (#54902) ... * WIP * Set public_suffix to a pre Ruby 2.6 version * we don't need to install python * Stretch->Buster * Bump versions in lib.star * Manually update linter Sort of messy, but the .mod-file need to contain all dependencies that use 1.16+ features, otherwise they're assumed to be compiled with -lang=go1.16 and cannot access generics et al. Bingo doesn't seem to understand that, but it's possible to manually update things to get Bingo happy. * undo reformatting * Various lint improvements * More from the linter * goimports -w ./pkg/ * Disable gocritic * Add/modify linter exceptions * lint + flatten nested list Go 1.19 doesn't support nested lists, and there wasn't an obvious workaround. https://go.dev/doc/comment#lists	3 years ago
Carl Bergquist	72ae4a5aa3	toggles: add feature toggle to increase in mem caching (#55014) ... Signed-off-by: bergquist <carl.bergquist@gmail.com>	3 years ago
Jean-Philippe Quéméner	bc4d929c67	Alerting: remove interpolation of annotations from alert rule file provisioning (#54975)	3 years ago
Misi	c5be9605a2	Chore: Use TimeNow instead of time.Now in user sql store to make it testable (#54983)	3 years ago
Joe Blubaugh	22c937340e	Revert "Alerting: Write and Delete multiple alert instances. (#54072)" (#54885) ... This reverts commit 5e4fd94413.	3 years ago
Nicholas Wiersma	faf8eb3afb	JWT: Allow conventional bearer token in Authorization header (#54821) ... * fix: allow JWT to accept standard bearer token * fix: linter issues * fix: linter gosec false positive * fix: refactor logic into JWT handler * fix: move bearer trimming earlier	3 years ago
Jean-Philippe Quéméner	d88f1c8e35	Alerting: validate am config changes before persisting (#54908)	3 years ago
Gabriel MABILLE	101349fe49	RBAC: Add permissions to install and configure plugins (#51829) ... * RBAC: Allow app plugins restriction Co-authored-by: Kalle Persson <kalle.persson@grafana.com> * Moving declaration to HttpServer Co-Authored-By: marefr <marcus.efraimsson@gmail.com> * Picking changes from the other branch Co-authored-by: Alexander Zobnin <alexanderzobnin@gmail.com> * Rename plugins.settings to plugins Co-authored-by: Kalle Persson <kalle.persson@grafana.com> * Account for PluginAdminExternalManageEnabled Co-authored-by: Will Browne <will.browne@grafana.com> * Set metadata on instantiation Co-authored-by: Jguer <joao.guerreiro@grafana.com> Co-authored-by: Kalle Persson <kalle.persson@grafana.com> Co-authored-by: marefr <marcus.efraimsson@gmail.com> Co-authored-by: Alexander Zobnin <alexanderzobnin@gmail.com> Co-authored-by: Will Browne <will.browne@grafana.com> Co-authored-by: Jguer <joao.guerreiro@grafana.com>	3 years ago
Karl Persson	bcd7afd1f5	RBAC: Remove service dependency in Evaluator component (#54910) ... * RBAC: Remove service dependency for Evaluator component * RBAC: Add service and load permissions in target org if they are not there * RBAC: Use service if we need to load permissions for org * API: remove service injection into evaluator * API: set new user for each request in tests * PublicDashboards: Use fake service to provide permissions * RBAC: Set org id for dashboard provisioning user	3 years ago
Guilherme Caulada	942be4215a	Secrets: Improve error handling for secrets manager plugin (#54811) ... * Improve error handling for secrets manager plugin * Update sever lock log for secret migration to Error * Move plugin started check to a separate function * Fix nil pointer exception on HasPluginStarted	3 years ago
Jean-Philippe Quéméner	e41f78a56d	Alerting: make sure to update contact point references when updating (#54896)	3 years ago
Artur Wierzbicki	1353177e15	Search: Add substring matcher (#54813) ... * search: bring back substring search * lint fix * search: bring back ngram * search: bring back ngram * search: more tests	3 years ago
Carl Bergquist	b4e3c89f60	instrumentation: dont instrument ErrSkip at all (#54880) ... Signed-off-by: bergquist <carl.bergquist@gmail.com>	3 years ago
Ezequiel Victorero	bcab0194f1	PublicDashboards: disable form if user does not has permissions (#54853)	3 years ago
owensmallwood	108678a8cc	Public Dashboards: Only use queries from dashboard for caching (#54596) ... Don't accept frontend queries for query caching when its from a public dashboard. Use queries on the dashboard instead.	3 years ago
Matthew Jacobson	940d18ad57	Alerting: Sanitize invalid label/annotation names for external alertmanagers (#54537) ... * Alerting: Sanitize invalid label/annotation names for external alertmanagers Grafana's built-in Alertmanager supports both Unicode label keys and values; however, if using an external Prometheus Alertmanager label keys must be compatible with their data model. This means label keys must only contain ASCII letters, numbers, as well as underscores and match the regex `[a-zA-Z_][a-zA-Z0-9_]*`. Any invalid characters will now be removed or replaced by the Grafana alerting engine before being sent to the external Alertmanager according to the following rules: - `Whitespace` will be removed. - `ASCII characters` will be replaced with `_`. - `All other characters` will be replaced with their lower-case hex representation. * Prefix hex replacements with `0x` * Refactor for clarity * Apply suggestions from code review Co-authored-by: brendamuir <100768211+brendamuir@users.noreply.github.com> Co-authored-by: brendamuir <100768211+brendamuir@users.noreply.github.com>	3 years ago
Alexander Weaver	b193eaed6e	Alerting: Resetting the notification policy tree to the default policy will also restore default contact points (#54608) ... * Add test that resetting the route restores the default receiver * Return error instead of panic * Adjust error string to match styleguide	3 years ago
mhuangwm	39102c6656	Admin: Add support to configure default admin email (#54363)	3 years ago
Nicholas Wiersma	9e704fec3c	JWT: Add support for assigning org roles (#54277) ... * feat: allow jwt role to be set * chore: update documentation * fix: cr suggestions * fix: lint issues * respect org auto assign and default org ID * add server admin to devenv Co-authored-by: jguer <joao.guerreiro@grafana.com>	3 years ago
Alexander Weaver	b8d1474609	Fix incorrect propagation of org ID in rule endpionts (#54603)	3 years ago
Guilherme Caulada	20589f76f4	Secrets: Convert secret migration to a background service (#54676) ... * Convert secret migration to a background service * Fix merge conflicts * Return concrete type for secret migration provider	3 years ago
Ilya Galimyanov	b593d371ef	Alerting: Telegram: truncate long messages (#54339) ... Truncate messages longer than 4096 characters	3 years ago
George Robinson	77e53f9986	Alerting: Fix boolean comparison on PostgreSQL (#54730)	3 years ago
George Robinson	c4d32dd687	Fix nil logger in SqlStore (#54726)	3 years ago
Karl Persson	ff35e35ce0	RBAC: Move service and evaluator to acimpl package (#54714) ... * RBAC: Move access control evaluator to acimpl package * RBAC: Move service to acimpl package	3 years ago
Kevin Yu	34fe7a1119	Plugins: Add feature toggles for long running queries (#54349) ... * Add feature toggles for long running queries * update feature flag name * make feature toggle frontend only	3 years ago
Ezequiel Victorero	bfa35ff8d8	PublicDashboards: Add RBAC to secured endpoints (#54544)	3 years ago
kay delaney	65c3ad6721	LibraryElements: Fix inability to delete library panels under MySQL (#54600) ... Closes #53456	3 years ago
Carl Bergquist	78978048c3	Instrumentation: log the total number of db queries per request (#54647) ... Signed-off-by: bergquist <carl.bergquist@gmail.com> Co-authored-by: Emil Tullstedt <emil.tullstedt@grafana.com> Co-authored-by: Dave Henderson <dave.henderson@grafana.com>	3 years ago
linoman	d2bb72fb3c	Login: Remove single admin team restriction (#54534) ... * Remove single member team restriction * Add label when permissions list is empty * Fix unit tests * Add co-author. Co-authored-by: Ieva <ieva.vasiljeva@grafana.com>	3 years ago
Guilherme Caulada	f4a35a4645	Secrets: Implement secrets manager plugin fallback store (#54496) ... * Refactor fallback to be isolated to plugin secret store * Check for error value on replace fallback test helper * Move ResetPlugin from test_helpers.go to plugin.go * Add check to GetUnwrappedStoreFromCache * Add fallback GetAll query to WithFallbackEnabled * Add mutex lock to WithFallbackEnabled * Add cache to fallback store * Fix linter issues * Fix linter issues * Fix linter issues	3 years ago
Ieva	de6584b976	Auth: Extend auth token errors with user ID (#54633) ... * add user ID to user token errors * remove colon * move user ID to debug log, so it wouldn't accidentally be added in response	3 years ago
Will Browne	ecdcafb258	manager exposes renderer + secrets manager (#54629)	3 years ago
Joe Blubaugh	5e4fd94413	Alerting: Write and Delete multiple alert instances. (#54072) ... Prior to this change, all alert instance writes and deletes happened individually, in their own database transaction. This change batches up writes or deletes for a given rule's evaluation loop into a single transaction before applying it. Before: ``` goos: darwin goarch: arm64 pkg: github.com/grafana/grafana/pkg/services/ngalert/store BenchmarkAlertInstanceOperations-8 398 2991381 ns/op 1133537 B/op 27703 allocs/op --- BENCH: BenchmarkAlertInstanceOperations-8 util.go:127: alert definition: {orgID: 1, UID: FovKXiRVzm} with title: "an alert definition FTvFXmRVkz" interval: 60 created util.go:127: alert definition: {orgID: 1, UID: foDFXmRVkm} with title: "an alert definition fovFXmRVkz" interval: 60 created util.go:127: alert definition: {orgID: 1, UID: VQvFuigVkm} with title: "an alert definition VwDKXmR4kz" interval: 60 created PASS ok github.com/grafana/grafana/pkg/services/ngalert/store 1.619s ``` After: ``` goos: darwin goarch: arm64 pkg: github.com/grafana/grafana/pkg/services/ngalert/store BenchmarkAlertInstanceOperations-8 1440 816484 ns/op 352297 B/op 6529 allocs/op --- BENCH: BenchmarkAlertInstanceOperations-8 util.go:127: alert definition: {orgID: 1, UID: 302r_igVzm} with title: "an alert definition q0h9lmR4zz" interval: 60 created util.go:127: alert definition: {orgID: 1, UID: 71hrlmR4km} with title: "an alert definition nJ29_mR4zz" interval: 60 created util.go:127: alert definition: {orgID: 1, UID: Cahr_mR4zm} with title: "an alert definition ja2rlmg4zz" interval: 60 created PASS ok github.com/grafana/grafana/pkg/services/ngalert/store 1.383s ``` So we cut time by about 75% and memory allocations by about 60% when storing and deleting 100 instances. This change also updates some of our tests so that they run successfully against postgreSQL - we were using random Int64s, but postgres integers, which our tables use, max out at 2^31-1	3 years ago
Michael Mandrus	39c31416a4	improve log in plugin check (#54599)	3 years ago
Timur Olzhabayev	b5b41988cf	Docs: Deprecating packages_api and removing it from our pipelines (#54473)	3 years ago
Serge Zaitsev	927ddf9376	Chore: Move login attempt methods to separate service (#54479) ... * Chore: Move login attempt methods to separate service * attempt to fix tests * fix syntax * better time mocking * initialise now func	3 years ago
Karl Persson	be6b8d91eb	Correlations: Use correct fallback handlers (#54511) ... * Correlations: Use correct fallback handlers * Add signed in middleware to all routes	3 years ago
Kat Yang	58449d42ed	Chore: Add dashboard thumbnails service (#54500) ... * Chore: Add dashboard thumbnails service * Fix errors in dashboard thumbs impl * Inject dashboardThumbsService into wire	3 years ago
owensmallwood	f4bbce15a0	Public Dashboards: Add Expressions Support (#54336) ... Adds support for expressions with public dashboards	3 years ago
Yuriy Tseretyan	76ea0b15ae	Alerting: Scheduler to fetch folders along with rules (#52842) ... * Update GetAlertRulesForScheduling to query for folders (if needed) * Update scheduler's alertRulesRegistry to cache folder titles along with rules * Update rule eval loop to take folder title from the * Extract interface RuleStore * Pre-fetch the rule keys with the version to detect changes, and query the full table only if there are changes.	3 years ago
Kristina	38c1f3d054	Explore: Add Mixed Datasource (#53429) ... * Toggle on the mixed mode option * Ensure switching to mixed gives existing query prev datasource * WIP - Populate datasource when switching between mixed and not * WIP - handle change from mixed * Remove preimport filter, refine filter to work for queries * WIP debugging datasource transition * Ensure creating a new query gets target data source if switching with no matches between * Add mixed datasource to rich history display * Cleanup console logs, add relevant comments * Add feature toggle for mixed datasource * Fix Wrapper tests * Fix tests! * Fix test types and add feature tracking * Remove unnecessary default, remove explore/mixed workarounds for D2E * Move display text logic to mixed datasource file * Add in the default query parameters to a generated empty query * Condense some code * Apply suggestions from code review Co-authored-by: Giordano Ricci <me@giordanoricci.com> * Add more logic around mixed datasource being off for explore * Build out logic to handle different datasource scenarios * Add tests * Finalize last test * Fix mixed URL with mixed ds off, and relevant test * Fix datasource to explore workflow * Add datasource change function, call import queries if needed * add logic for changing single query ds Co-authored-by: Giordano Ricci <me@giordanoricci.com>	3 years ago
Dave Henderson	713075c494	Metrics: Fixed `grafana_database_conn_*` metrics, and added new `go_sql_stats_*` metrics as eventual replacement (#54405) ... * metrics: Fix broken DBStats metrics Signed-off-by: Dave Henderson <dave.henderson@grafana.com> * Register the sqlstats metrics by default Signed-off-by: Dave Henderson <dave.henderson@grafana.com> Signed-off-by: Dave Henderson <dave.henderson@grafana.com>	3 years ago
Artur Wierzbicki	9284216880	Search: ordering tests (#54432) ... * search ordering tests * lintt	3 years ago
Will Browne	4a707e2a88	Plugins: Split plugin manager into smaller components (#54384) ... * split out plugin manager * remove whitespace * fix tests * split up tests * updating naming conventions * simplify manager * tidy * add more fakes * testing time * add query verif to int test * renaming * add process tests * tidy up manager tests * add extra case to int test * add more coverage to store and process tests * remove comment * fix capatilization * init on provide * remove addfromsource from API	3 years ago