183 Commits (d338b7ea7bf5b4561b77d779233030fc40c5dec8)

Author	SHA1	Message	Date
Karsten Weiss	f61e69ce75	Simplify comparison to bool constant (gosimple) ... This fixes: build.go:553:6: should omit comparison to bool constant, can be simplified to !strings.Contains(path, ".sha256") (S1002) pkg/cmd/grafana-cli/commands/ls_command.go:27:5: should omit comparison to bool constant, can be simplified to !pluginDirInfo.IsDir() (S1002) pkg/components/dynmap/dynmap_test.go:24:5: should omit comparison to bool constant, can be simplified to !value (S1002) pkg/components/dynmap/dynmap_test.go:122:14: should omit comparison to bool constant, can be simplified to b (S1002) pkg/components/dynmap/dynmap_test.go:125:14: should omit comparison to bool constant, can be simplified to !b (S1002) pkg/components/dynmap/dynmap_test.go:128:14: should omit comparison to bool constant, can be simplified to !b (S1002) pkg/models/org_user.go:51:5: should omit comparison to bool constant, can be simplified to !(*r).IsValid() (S1002) pkg/plugins/datasource/wrapper/datasource_plugin_wrapper_test.go:77:12: should omit comparison to bool constant, can be simplified to !haveBool (S1002) pkg/services/alerting/conditions/evaluator.go:23:9: should omit comparison to bool constant, can be simplified to !reducedValue.Valid (S1002) pkg/services/alerting/conditions/evaluator.go:48:5: should omit comparison to bool constant, can be simplified to !reducedValue.Valid (S1002) pkg/services/alerting/conditions/evaluator.go:91:5: should omit comparison to bool constant, can be simplified to !reducedValue.Valid (S1002) pkg/services/alerting/conditions/query.go:56:6: should omit comparison to bool constant, can be simplified to !reducedValue.Valid (S1002) pkg/services/alerting/extractor.go:107:20: should omit comparison to bool constant, can be simplified to !enabled.MustBool() (S1002) pkg/services/alerting/notifiers/telegram.go:222:41: should omit comparison to bool constant, can be simplified to this.UploadImage (S1002) pkg/services/sqlstore/apikey.go:58:12: should omit comparison to bool constant, can be simplified to !has (S1002) pkg/services/sqlstore/apikey.go:72:12: should omit comparison to bool constant, can be simplified to !has (S1002) pkg/services/sqlstore/dashboard.go:66:33: should omit comparison to bool constant, can be simplified to !cmd.Overwrite (S1002) pkg/services/sqlstore/dashboard.go:175:12: should omit comparison to bool constant, can be simplified to !has (S1002) pkg/services/sqlstore/dashboard.go:311:13: should omit comparison to bool constant, can be simplified to !has (S1002) pkg/services/sqlstore/dashboard.go:444:12: should omit comparison to bool constant, can be simplified to !exists (S1002) pkg/services/sqlstore/dashboard.go:472:12: should omit comparison to bool constant, can be simplified to !exists (S1002) pkg/services/sqlstore/dashboard.go:554:32: should omit comparison to bool constant, can be simplified to !cmd.Overwrite (S1002) pkg/services/sqlstore/dashboard_snapshot.go:83:12: should omit comparison to bool constant, can be simplified to !has (S1002) pkg/services/sqlstore/plugin_setting.go:39:12: should omit comparison to bool constant, can be simplified to !has (S1002) pkg/services/sqlstore/quota.go:34:12: should omit comparison to bool constant, can be simplified to !has (S1002) pkg/services/sqlstore/quota.go:111:6: should omit comparison to bool constant, can be simplified to !has (S1002) pkg/services/sqlstore/quota.go:136:12: should omit comparison to bool constant, can be simplified to !has (S1002) pkg/services/sqlstore/quota.go:213:6: should omit comparison to bool constant, can be simplified to !has (S1002) pkg/services/sqlstore/temp_user.go:129:12: should omit comparison to bool constant, can be simplified to !has (S1002) pkg/services/sqlstore/user.go:157:12: should omit comparison to bool constant, can be simplified to !has (S1002) pkg/services/sqlstore/user.go:182:5: should omit comparison to bool constant, can be simplified to !has (S1002) pkg/services/sqlstore/user.go:191:12: should omit comparison to bool constant, can be simplified to !has (S1002) pkg/services/sqlstore/user.go:212:12: should omit comparison to bool constant, can be simplified to !has (S1002) pkg/services/sqlstore/user.go:307:12: should omit comparison to bool constant, can be simplified to !has (S1002) pkg/social/generic_oauth.go:185:5: should omit comparison to bool constant, can be simplified to !s.extractToken(&data, token) (S1002) pkg/tsdb/mssql/mssql.go:148:39: should omit comparison to bool constant, can be simplified to ok (S1002) pkg/tsdb/mssql/mssql.go:212:6: should omit comparison to bool constant, can be simplified to !query.Model.Get("fillNull").MustBool(false) (S1002) pkg/tsdb/mssql/mssql.go:247:56: should omit comparison to bool constant, can be simplified to ok (S1002) pkg/tsdb/mssql/mssql.go:274:7: should omit comparison to bool constant, can be simplified to !exist (S1002) pkg/tsdb/mssql/mssql.go:282:8: should omit comparison to bool constant, can be simplified to !exist (S1002) pkg/tsdb/mysql/mysql.go:221:6: should omit comparison to bool constant, can be simplified to !query.Model.Get("fillNull").MustBool(false) (S1002) pkg/tsdb/mysql/mysql.go:256:56: should omit comparison to bool constant, can be simplified to ok (S1002) pkg/tsdb/mysql/mysql.go:283:7: should omit comparison to bool constant, can be simplified to !exist (S1002) pkg/tsdb/mysql/mysql.go:291:8: should omit comparison to bool constant, can be simplified to !exist (S1002) pkg/tsdb/postgres/postgres.go:134:39: should omit comparison to bool constant, can be simplified to ok (S1002) pkg/tsdb/postgres/postgres.go:201:6: should omit comparison to bool constant, can be simplified to !query.Model.Get("fillNull").MustBool(false) (S1002) pkg/tsdb/postgres/postgres.go:236:56: should omit comparison to bool constant, can be simplified to ok (S1002) pkg/tsdb/postgres/postgres.go:263:7: should omit comparison to bool constant, can be simplified to !exist (S1002) pkg/tsdb/postgres/postgres.go:271:8: should omit comparison to bool constant, can be simplified to !exist (S1002)	8 years ago
Mario Trangoni	ce941a004d	fix unconvert issues	8 years ago
Mario Trangoni	91fb2e07ce	pkg: fix codespell issues	8 years ago
Marcus Efraimsson	87284d284e	dashboard: fix import dashboard with alert rule ... Importing a dashboard with alert rule(s) should be possible without receiving invalid alert data error. This fix reverts the import logic to how it worked before Grafana v5.0, that is import will allow dashboard with alert rule(s) but no alerts will be created. After an import the user will need to update the dashboard for the alerts to be created. Fixes #11227	8 years ago
Dobrosław Żybort	5a368f99ec	Fix urls in plugin update_checker logs	8 years ago
Aleksandar Gyorev	89a17a4ace	Correct typo in DashboardInputMissingError	8 years ago
Marcus Efraimsson	53cd39fde5	Shouldn't be able to overwrite a dashboard if you don't have permissions (#10900) ... * dashboards: new command for validating dashboard before update Removes validation logic from saveDashboard and later on use the new command for validating dashboard before saving a dashboard. This due to the fact that we need to validate permissions for overwriting other dashboards by uid and title. * dashboards: use the new command for validating dashboard before saving Had to refactor dashboard provisioning a bit to be able to sidetrack the permission validation in a somewhat reasonable way. Adds some initial tests of the dashboard repository, but needs to be extended later. At least now you can mock the dashboard guardian * dashboards: removes validation logic in the save dashboard api layer Use the dashboard repository solely for create/update dashboards and let it do all the validation. One exception regarding quota validation which still is in api layer since that logic is in a macaron middleware. Need to move out-commented api tests later. * dashboards: fix database tests for validate and saving dashboards * dashboards: rename dashboard repository to dashboard service Split the old dashboard repository interface in two new interfaces, IDashboardService and IDashboardProvisioningService. Makes it more explicit when using it from the provisioning package and there's no possibility of calling an incorrect method for saving a dashboard. * database: make the InitTestDB function available to use from other packages * dashboards: rename ValidateDashboardForUpdateCommand and some refactoring * dashboards: integration tests of dashboard service * dashboard: fix sqlstore test due to folder exist validation * dashboards: move dashboard service integration tests to sqlstore package Had to move it to the sqlstore package due to concurrency problems when running against mysql and postgres. Using InitTestDB from two packages added conflicts when clearing and running migrations on the test database * dashboards: refactor how to find id to be used for save permission check * dashboards: remove duplicated dashboard tests * dashboards: cleanup dashboard service integration tests * dashboards: handle save dashboard errors and return correct http status * fix: remove log statement * dashboards: import dashboard should use dashboard service Had to move alerting commands to models package due to problems with import cycles of packages. * dashboards: cleanup dashboard api tests and add some tests for post dashboard * dashboards: rename dashboard service interfaces * dashboards: rename dashboard guardian interface	8 years ago
bergquist	5bbe047eaa	Revert "removes dependencies install for plugins" ... This reverts commit 47e363ea15.	8 years ago
bergquist	47e363ea15	removes dependencies install for plugins ... this features was never intended for production.	8 years ago
Marcus Efraimsson	0e8377a9f4	Update logic for create/update dashboard, validation and plugin dashboard links (#10809) ... * enables overwrite if dashboard allready exist in folder * dashboard: Don't allow creating a folder named General * dashboards: update logic for save/update dashboard No id and uid creates a new dashboard/folder. No id and uid, with an existing title in folder allows overwrite of dashboard. Id without uid, allows update of existing dashboard/folder without overwrite. Uid without id allows update of existing dashboard/folder without overwrite. Id without uid, with an existing title in folder allows overwrite of dashboard/folder and updated will have the uid of overwritten. Uid without id, with an existing title in folder allows overwrite of dashboard/folder and new will have the same uid as provided. Trying to change an existing folder to a dashboard yields error. Trying to change an existing dashboard to a folder yields error. * dashboards: include folder id when confirmed to save with overwrite * dashboards: fixes due to new url structure Return importedUrl property in response to importing dashboards and getting plugin dashboards and use this for redirects/links in the frontend.	8 years ago
Alexander Zobnin	db7890ec1e	plugins: return table with empty rows array insteaf of nil	8 years ago
bergquist	56d5ece340	plugins: return empty tables array insteaf of nil	8 years ago
bergquist	8fed56e334	test: fixes failing test in go1.10	8 years ago
bergquist	8c8328eac5	test: fixes failing test in go1.10	8 years ago
bergquist	2782ad0955	plugins: only set error if errorstring is not empty	8 years ago
bergquist	6a6eab5ea1	plugins: map error property on query result	8 years ago
bergquist	7858965117	codestyle: extract code into methods	8 years ago
bergquist	a32644198c	gofmt my dear friend	8 years ago
bergquist	b6e6935821	plugins: send secureJsonData unencrypted	8 years ago
bergquist	a183ea97bb	moves datasource plugin model to grafana/grafana_plugin_model	8 years ago
bergquist	5eb36e65f2	use context over golang.org/x/net/context	8 years ago
bergquist	b511788c51	code style fixes	8 years ago
Leonard Gram	b63c834a4b	Adds Table in backend datasource contract.	8 years ago
bergquist	ce4beb730d	Review tsdb protobuf contract	8 years ago
bergquist	1fd40a48d9	supports windows compatible plugin binaries	8 years ago
bergquist	ebd8677607	moves plugin proxy to plugin package	8 years ago
bergquist	acb7d802d1	improves name for plugin logger	8 years ago
bergquist	50db9810e8	uses pluginmanagers log instead of global	8 years ago
bergquist	dbd1ba465f	makes datasource handshake more explicit	8 years ago
bergquist	44e485af41	backend plugins: improves logging	8 years ago
Daniel Lee	ccf1a5124b	plugin: fix path for app plugins on windows ... This fixes when an app that contains a plugin (which means it has a filepath with more parts) gets a back slash in the path for the plugin module. The string replace now replaces all back slashes and not just the first one.	8 years ago
bergquist	75a54e85dc	dont spawn new subprocess while shutting down	8 years ago
bergquist	05362a9666	plugins: restart killed plugins	8 years ago
Carl Bergquist	d2ea5415da	test for plugin path builder	8 years ago
Carl Bergquist	20284f7745	merge backend datasources and datasources	8 years ago
bergquist	7977d6b669	merge backend-datasource and datasource type	8 years ago
bergquist	97c5498093	fixes broken unit test	8 years ago
bergquist	7c0fc59dfb	execute process directly instead of creating sub shell	8 years ago
bergquist	411e8a16c2	backend plugins: manage plugins lifecycle with context	8 years ago
bergquist	9edd7701b2	fixes failing tests	8 years ago
bergquist	e1d4bf2607	kill plugin processes when grafana shuts down	8 years ago
bergquist	a2d47427ba	separate plugin impl and proto files	8 years ago
Marcus Efraimsson	82cd24491e	dashfolders: revert automatic creation of folders for plugins	8 years ago
Marcus Efraimsson	368a4d7aed	dashfolders: don't create app folder on dashboard import if already exists	8 years ago
Daniel Lee	4356e980f0	dashfolders: create app folder on dashboard import	8 years ago
Daniel Lee	7863a0417c	plugins: fixes path issue on Windows ... When loading a plugin and setting the path, an extra backslash sneaks when running on Windows. Fixes #9597	8 years ago
Torkel Ödegaard	2789c4f1e1	dsfix: include routes in plugin model	8 years ago
Torkel Ödegaard	07e192ff47	change: more work on changing default group by time interval to min interval setting	8 years ago
Torkel Ödegaard	84d4958a3c	plugin change: make interval, cache timeout & max data points options in plugin.json, remove query.options component feature, add help markdown feature and toggle for data sources	8 years ago
Torkel Ödegaard	3c9798bec9	datasource-proxy: token exchange	8 years ago