grafana

Commit Graph

Author	SHA1	Message	Date
Pavlos Daoglou	53007e07e3	ApiUser: Fix response when enabling, disabling or deleting a nonexistent user (#21391 ) * ApiUser: Fix response when enabling, disabling or deleting a nonexistent user	5 years ago
Sofia Papagiannaki	0b7a5d4ed1	SQLStore: Test admins/editors/viewers stats validity (#20751 ) * Test admins/editors/viewers stats validity * Use standard testing library instead of Convey	6 years ago
Sofia Papagiannaki	02d7d00560	SQLStore: Rewrite system statistics query to count users once (#20711 ) Fix system statistics query to count only once users that are part of several organisations. Fixes #20681	6 years ago
Eric Leijonmarck	f05607d4c0	UserTableView: Show user name in table view (#18108 ) * refactor to multiple rows * added name for org user struct * added name getorgusers * added user name to tableview * made test pass * updated userMocks to user name field * added missing UsersTable snapshot * added name on teammembers page, be able to search query for name, login and email * added the updated snapshots * conform to same sorting as output form * conform to previous way of using it * sort first by login and after by email, as it was before	6 years ago
Sofia Papagiannaki	ea7ccda647	Alerting: Propagate failures to delete dashboard alerts (#20507 ) * Propagate failures to delete dashboard alerts	6 years ago
Sofia Papagiannaki	d1c523838b	API: Optionally list expired keys (#20468 ) * API: Optionally list expired keys * Update docs	6 years ago
Shavonn Brown	3e5abe7c21	Admin: Adds setting to disable creating initial admin user (#19505 ) Adds a new setting disable_admin_user and when true the default admin user will not be created when Grafana starts for the first time (or no users exists in the system). Closes #19038	6 years ago
Jon Gyllenswärd	a45ce36566	Allow saving of provisioned dashboards (#19820 ) Allows saving of provisioned dashboards if the config value allowUiUpdates is set to true Fixes #11778	6 years ago
Arve Knudsen	35e0e078b7	pkg/util: Check errors (#19832 ) * pkg/util: Check errors * pkg/services: DRY up code	6 years ago
Arve Knudsen	2a78d2a61c	pkg/services: Check errors (#19712 ) * pkg/services: Check errors * pkg/services: Don't treat context.Canceled\|context.DeadlineExceeded as error	6 years ago
Arve Knudsen	b858a5f496	Don't truncate IPv6 addresses (#19573 ) * Bugfix: Fix parsing of IPv6 addresses Make sure that IPv6 addresses aren't truncated when parsing. Fixes #18924 * util: Change network address parsing funcs to return error * pkg/api: Return NetworkAddress instead of host/port	6 years ago
Ben Patterson	9904e14f8e	Alerting: Fix dates stored in local time when pausing alerts (#19525 ) * Make tests more sensitive to timezone. * Time stamps should use UTC for consistency. * Test: Assert state is paused after pauseAllAlerts call.	6 years ago
Rafael George	e1b2bf711d	API: Add createdAt field to /api/users/:id (#19475 ) It would help for auditing purposes to have the user's created date exposed via the API along with the other fields already exposed via the API.	6 years ago
Sofia Papagiannaki	56f5106717	SQL: Rewrite statistics query (#19178 ) * Rewrite statistics query	6 years ago
gotjosh	fa007423e3	API: Add `updatedAt` to api/users/:id (#19004 ) * API: Add `updatedAt` to api/users/:id This adds the timestamp of when a particular user was last updated to the `api/users/:id` endpoint. This helps our administrators understand when was the user information last updated. Particularly when it comes from external systems e.g. LDAP	6 years ago
gotjosh	0cbbb43222	LDAP: Add API endpoint to debug user mapping from LDAP (#18833 ) * Move the ReloadLDAPCfg function to the debug file Appears to be a better suite place for this. * LDAP: Return the server information when we find a specific user We allow you to specify multiple LDAP servers as part of LDAP authentication integration. As part of searching for specific users, we need to understand from which server they come from. Returning the server configuration as part of the search will help us do two things: - Understand in which server we found the user - Have access the groups specified as part of the server configuration * LDAP: Adds the /api/admin/ldap/:username endpoint This endpoint returns a user found within the configured LDAP server(s). Moreso, it provides the mapping information for the user to help administrators understand how the users would be created within Grafana based on the current configuration. No changes are executed or saved to the database, this is all an in-memory representation of how the final result would look like.	6 years ago
Ryan McKinley	6335509a23	Annotations: use a single row to represent a region (#17673 ) * SQLite migrations * cleanup * migrate end times * switch to update with a query * real migration * anno migrations * remove old docs * set isRegion from time changes * use <> for is not * add comment and fix index decleration * single validation place * add test * fix test * add upgrading docs * use AnnotationEvent * fix import * remove regionId from typescript	6 years ago
Marcus Efraimsson	8fd153edb7	API: Restrict anonymous user information access (#18422 ) Existing /api/alert-notifications now requires at least editor access. Existing /api/alert-notifiers now requires at least editor access. New /api/alert-notifications/lookup returns less information than /api/alert-notifications and can be access by any authenticated user. Existing /api/org/users now requires org admin role. New /api/org/users/lookup returns less information than /api/org/users and can be access by users that are org admins, admin in any folder or admin of any team. UserPicker component now uses /api/org/users/lookup instead of /api/org/users. Fixes #17318	6 years ago
Kyle Brandt	172464e91e	alerting: return err when SetAlertState fails to save to sql (#18216 ) fix duplicate alert states when the alert fails to save to the database. fixes #18176	6 years ago
Oleg Gaidarenko	d9f01cb822	SQLStore: use bool pointer instead of string (#18111 )	6 years ago
Oleg Gaidarenko	75fa1f0207	Metrics: use consistent naming for exported variables (#18134 ) * Metrics: remove unused metrics Metric `M_Grafana_Version` is not used anywhere, nor the mentioned `M_Grafana_Build_Version`. Seems to be an artefact? * Metrics: make the naming consistent * Metrics: add comments to exported vars * Metrics: use proper naming Fixes #18110	6 years ago
Oleg Gaidarenko	8e0f091f14	SQLStore: allow to look for `is_disabled` flag (#18032 ) * Add support for `is_disabled` to `CreateUser()` * Add support for `is_disabled` to `SearchUsers()` Had to add it as a `string` type not as `bool`, since if that's property is omitted, we would have add it to SQL request, which might be dangerous * Restructure desctructive tests and add more	6 years ago
Anthony Templeton	3680b95b44	Auth: Duplicate API Key Name Handle With Useful HTTP Code (#17905 ) * API: Duplicate API Key Name Handle With Useful HTTP Code * 17447: make changes requested during review - use dialect.IsUniqueContraintViolation - change if statement to match others - return error properly * Revert "17447: make changes requested during review" This reverts commit `a4a674ea83`. * API: useful http code on duplicate api key error w/ tests * API: API Key Duplicate Handling fixed small typo associated with error	6 years ago
Alexander Zobnin	3d848d0fdf	Teams: show proper label for each auth provider (#17860 ) * Teams: show proper label for each auth provider Teams: don't sore AuthModule in team_member table, use JOIN to get it instead * Teams: fix AddTeamMember after last changes * Teams: add more auth provider labels * Teams: show external sync badge if LDAP is not enabled * Teams: tests for getting auth module	6 years ago
Oleg Gaidarenko	caa1314f44	Build: use golangci-lint as a make command (#17739 ) * Build: use golangci-lint as a make command * Since gometalinter was deprecated in favor of golangci-lint so it was replaced by it. Responsibilities held by the gometalinter was moved to golangci-lint * There was some changes in implementation (that was also mentioned in the code comment) between the tools, which uncovered couple errors in the code. Those issues were either solved or disabled by the inline comments * Introduce the golangci-lint config, to make their configuration more manageable * Build: replace backend-lint.sh script with make	6 years ago
Sofia Papagiannaki	dc9ec7dc91	Auth: Allow expiration of API keys (#17678 ) * Modify backend to allow expiration of API Keys * Add middleware test for expired api keys * Modify frontend to enable expiration of API Keys * Fix frontend tests * Fix migration and add index for `expires` field * Add api key tests for database access * Substitude time.Now() by a mock for test usage * Front-end modifications * Change input label to `Time to live` * Change input behavior to comply with the other similar * Add tooltip * Modify AddApiKey api call response Expiration should be time.Time instead of string Present expiration date in the selected timezone * Use kbn for transforming intervals to seconds * Use `assert` library for tests * Frontend fixes Add checks for empty/undefined/null values * Change expires column from datetime to integer * Restrict api key duration input It should be interval not number * AddApiKey must complain if SecondsToLive is negative * Declare ErrInvalidApiKeyExpiration * Move configuration to auth section * Update docs * Eliminate alias for models in modified files * Omit expiration from api response if empty * Eliminate Goconvey from test file * Fix test Do not sleep, use mocked timeNow() instead * Remove index for expires from api_key table The index should be anyway on both org_id and expires fields. However this commit eliminates completely the index for now since not many rows are expected to be in this table. * Use getTimeZone function * Minor change in api key listing The frontend should display a message instead of empty string if the key does not expire.	6 years ago
Alexander Zobnin	dad894f1cc	API: get list of users with additional auth info (#17305 ) * batch disable users * batch revoke users tokens * split batch disable user and revoke token * API: get users with auth info and isExternal flag * fix tests for batch disable users * Users: refactor /api/users/search endpoint * Users: use alias for "user" table * Chore: add BatchDisableUsers() to the bus * Users: order user list by id explicitly * Users: return AuthModule from /api/users/:id endpoint * Users: do not return unused fields * Users: fix SearchUsers method after last changes * User: return auth module as array for future purposes * User: tests for SearchUsers() * User: return only latest auth module in SearchUsers() * User: fix JOIN, get only most recent auth module	6 years ago
Oleg Gaidarenko	c853ef7318	SQLStore: extend `user.SearchUsers` method (#17514 ) * SQLStore: extend `user.SearchUsers` method Allow `user.SearchUsers` to search users based on their auth type	6 years ago
Sofia Papagiannaki	7b70e7db2d	AuthProxy: Optimistic lock pattern for remote cache Set (#17485 ) * Implementation of optimistic lock pattern Try to insert the remote cache key and handle integrity error * Remove transaction Integrity error inside a transaction results in deadlock * Remove check for existing remote cache key Is no longer needed since integrity constrain violations are handled * Add check for integrity constrain violation Do not update the row if the insert statement fails for other than an integrity constrain violation * Handle failing inserts because of deadlocks If the insert statement fails because of a deadlock try to update the row * Add utility function for returning SQL error code Useful for debugging * Add logging for failing expired cache key deletion Do not shallow it completely * Revert "Add utility function for returning SQL error code" This reverts commit 8e0b82c79633e7d8bc350823cbbab2ac7a58c0a5. * Better log for failing deletion of expired cache key * Add some comments * Remove check for existing cache key Attempt to insert the key without checking if it's already there and handle the error situations * Do not propagate deadlocks created during update Most probably somebody else is trying to insert/update the key at the same time so it is safe enough to ignore it	6 years ago
Carl Bergquist	6809d2bb29	codestyle: moves cache to infra (#17519 )	6 years ago
Maxim Ivanov	151fe240fc	OAuth: Fix for wrong user token updated on OAuth refresh in DS proxy (#17541 )	6 years ago
Kyle Brandt	a95c7bfa6f	sqlstore: clean quota and user_auth_tokens when removing users (#17487 ) fixes #17392	6 years ago
Carl Bergquist	1aadb4426a	metrics: expose stats about roles as metrics (#17469 )	6 years ago
Thibault Chataigner	e06abb30aa	Alerting: Add tags to alert rules (#10989 ) Ref #6552	6 years ago
Andrej Ocenas	1c3ad78672	Perf: Fix slow dashboards ACL query (#17427 ) Fix slow ACL query for dashboards that was used as subquery on multiple places slowing down search and login in instances with many dashboards.	6 years ago
Marcus Efraimsson	b7a9533476	Database: Initialize xorm with an empty schema for postgres (#17357 ) xorm introduced some changes in https://github.com/go-xorm/xorm/pull/824 and https://github.com/go-xorm/xorm/pull/876 which by default will use public as the postgres schema and this was a breaking change compared to before. Grafana has implemented a custom postgres dialect so above changes wasn't a problem here. However, Grafana's custom database migration was using xorm dialect to check if the migration table exists or not. For those using a custom search_path (schema) in postgres configured on server, database or user level the migration table check would not find the migration table since it was looking in public schema due to xorm changes above. This had the consequence that Grafana's database migration failed the second time since migration had already run migrations in another schema. This change will make xorm use an empty default schema for postgres and by that mimic the functionality of how it was functioning before xorm's changes above. Fixes #16720 Co-Authored-By: Carl Bergquist <carl@grafana.com>	6 years ago
Alexander Zobnin	60ddad8fdb	Batch disable users (#17254 ) * batch disable users * batch revoke users tokens * split batch disable user and revoke token * fix tests for batch disable users * Chore: add BatchDisableUsers() to the bus	6 years ago
Marcus Efraimsson	5884e235fc	database: retry transaction if sqlite returns database is locked error (#17276 ) Adds an additional sqlite error code 5 (SQLITE_BUSY) to the transaction retry handler to add retries when sqlite returns database is locked error. More info: https://www.sqlite.org/rescode.html#busy Ref #17247 #16638	6 years ago
Alexander Zobnin	2d03815770	Users: Disable users removed from LDAP (#16820 ) * Users: add is_disabled column * Users: disable users removed from LDAP * Auth: return ErrInvalidCredentials for failed LDAP auth * User: return isDisabled flag in user search api * User: mark disabled users at the server admin page * Chore: refactor according to review * Auth: prevent disabled user from login * Auth: re-enable user when it found in ldap * User: add api endpoint for disabling user * User: use separate endpoints to disable/enable user * User: disallow disabling external users * User: able do disable users from admin UI * Chore: refactor based on review * Chore: use more clear error check when disabling user * Fix login tests * Tests for disabling user during the LDAP login * Tests for disable user API * Tests for login with disabled user * Remove disable user UI stub * Sync with latest LDAP refactoring	6 years ago
Mario Trangoni	66ba2aa524	Fix gosimple issues (#17179 ) Signed-off-by: Mario Trangoni <mjtrangoni@gmail.com>	6 years ago
Oleg Gaidarenko	35f227de11	Feature: LDAP refactoring (#16950 ) * incapsulates multipleldap logic under one module * abstracts users upsert and get logic * changes some of the text error messages and import sort sequence * heavily refactors the LDAP module – LDAP module now only deals with LDAP related behaviour * integrates affected auth_proxy module and their tests * refactoring of the auth_proxy logic	6 years ago
Oleg Gaidarenko	756da8a134	Fix: tighten revive exit code & make it happy (#17127 ) * Revive should fail the build * Fix the associated errors	6 years ago
Tom Petr	73e405978b	add support for periodically reloading mysql client certs (#14892 )	6 years ago
Andrej Ocenas	3dbc3251d1	Chore: Deduplicate sqlstore transaction code (#17069 ) * Deduplicate transaction code * More deduplication	6 years ago
zhulongcheng	2fff8f77dc	move log package to /infra (#17023 ) ref #14679 Signed-off-by: zhulongcheng <zhulongcheng.me@gmail.com>	6 years ago
Andrej Ocenas	eb82a75668	Provisioning: Show file path of provisioning file in save/delete dialogs (#16706 ) * Add file path to metadata and show it in dialogs * Make path relative to config directory * Fix tests * Add test for the relative path * Refactor to use path relative to provisioner path * Change return types * Rename attribute * Small fixes from review	6 years ago
Tom Petr	2d6b33ab61	sqlstore: use column name in order by (#16583 ) Use column name in ORDER BY in GetDashboardAclInfoList().	6 years ago
Carl Bergquist	eb8af01a8a	admin: add more stats about roles (#16667 ) closes #14967	6 years ago
Oleg Gaidarenko	54c1bf0cc9	Chore: a bit of spring cleaning (#16710 ) * Chore: use early return technic everywhere And enable "indent-error-flow" revive rule * Chore: remove if-return rule from revive config * Chore: improve error messages And enable "error-strings" revive rule * Chore: enable "error-naming" revive rule * Chore: make linter happy * Chore: do not duplicate gofmt execution * Chore: make linter happy * Chore: address the pull review comments	6 years ago
Torkel Ödegaard	36d64fecea	Search: Fixed search issue introduced in recent PR (#16652 )	6 years ago

1 2 3 4 5 ...

1108 Commits (d40b66f1c170d0927382854f9b36351937c05757)