grafana

Commit Graph

Author	SHA1	Message	Date
Yuriy Tseretyan	c314ce48c7	Alerting: Support for optimistic locking for alert rules (#50274 ) * add support for optimistic locking for alert_rule table * return 409 in the case of opitimistic lock	3 years ago
Jean-Philippe Quéméner	1ed7280363	Alerting: add right provenance when creating mute timings (#50707 )	3 years ago
Jean-Philippe Quéméner	ed6a887737	Alerting: remove unused function in alert rule store (#50696 )	3 years ago
Kat Yang	bd35e6917a	Chore: Exclude integration tests from running on test-backend step (#50359 ) * Chore: Exclude integration tests from running on test-backend step * Remove -v from go test command * Add check to skip integration tests before each integration test * Try to restart pipeline * Retrying to make pipeline run	3 years ago
Yuriy Tseretyan	b0ae4d460e	Alerting: Make ticker to tick at predictable time (#50197 )	3 years ago
Jean-Philippe Quéméner	862f51216b	Alerting: improve provisioning docs (#50347 ) * Alerting: improve provisioning docs * add new provisioning page * add api docs * fix formatting and add better descriptions * fix typo	3 years ago
Gabriel MABILLE	840a442796	RBAC: Rename alerting roles to match naming convention (#50504 )	3 years ago
Alexander Weaver	7dd78fee2c	Alerting: Fix provisioning validation status codes and panics (#50464 ) * Updates to all except alert rules * Return 400 when rules fail to validate, add testinfra * More sane package aliases * More package alias renames * One more bug in contact point validation * remove unused function Co-authored-by: Jean-Philippe Quémémer <jeanphilippe.quemener@grafana.com> Co-authored-by: Jean-Philippe Quéméner <JohnnyQQQQ@users.noreply.github.com>	3 years ago
Jean-Philippe Quéméner	cf684ed38f	Alerting: bump rule version when updating rule group interval (#50295 ) * Alerting: move group update to alert rule service * rename validateAlertRuleInterval to validateRuleGroupInterval * init baseinterval correctly * add seconds suffix * extract validation function for reusability * add context to err message	3 years ago
Yuriy Tseretyan	54fa04263b	Alerting: Add RBAC actions and role for provisioning API routes (#50459 ) * add alert provisioning actions and role * linter	3 years ago
Joe Blubaugh	ecf080825e	Alerting: Fix image embed in email template. (#50370 ) The ng_alert_notification email template did not include templating for linked or embedded images. This change updates that. Additionally, this change supports embedding an image for each alert in an email batch. Fixes #50315	3 years ago
Santiago	9dc7e752b7	Optional custom title and description for OpsGenie (#50131 ) * optional custom description for OpsGenie * custom title and message, tests * update changelog * check for empty / whitespace only strings * truncate the title to 130 characters if needed * unnecessary validation removed * truncate title to 127 characters and add three dots	3 years ago
gotjosh	c59938b235	Alerting: Schedule Alert rules metric tracking (#50415 ) * Alerting: Schedule Alert rules metric tracking Change the record of metrics from one place to two as an attempt to have a semi-accurate record.	3 years ago
Yuriy Tseretyan	a89d4a5be7	Alerting: Scheduler to drop ticks if a rule's evaluation is too slow (#48885 ) * drop ticks if evaluation of a rule is too slow. * add metric schedule_rule_evaluations_missed_total	3 years ago
Jean-Philippe Quéméner	fd664e4beb	Alerting: replace a duplicated configuration key (#50350 ) This PR renames the configuration key enabled to capture. This is needed as we already have a configuration key with the name enabled. Fixes #50328 Co-authored-by: Jean-Philippe Quéméner <JohnnyQQQQ@users.noreply.github.com>	3 years ago
Alexander Weaver	28a47b56d2	Bump provisioning to admin-only in lieu of dedicated RBAC permissions (#50366 )	3 years ago
gotjosh	0cde283505	Alerting: Logs should not be capitalized and the errors key should be "err" (#50333 ) * Alerting: decapitalize log lines and use "err" as the key for errors Found using (logger\|log).(Warn\|Debug\|Info\|Error)\([A-Z] and (logger\|log).(Warn\|Debug\|Info\|Error)\(.+"error"	3 years ago
George Robinson	c83f84348c	Alerting: Fix database unavailable removes rules from scheduler (#49874 )	3 years ago
Karl Persson	c4a75f9eb3	RBAC: Add scope resolvers for dashboards (#50110 ) * Inject access control into dashboard service * Add function to parse id scopes * Add dashboard as return value * Update mock * Return only err to keep service interface * Add scope resolvers for dashboard id scopes * Add function to parse uid scopes * Add dashboard uid scope resolver * Register scope resolvers for dashboards Co-authored-by: Gabriel MABILLE <gamab@users.noreply.github.com>	3 years ago
Jean-Philippe Quéméner	4b8a4449ed	Alerting: remove feature toggle for provisioning API (#50167 ) * Alerting: remove feature toggle for provisioning API * remove missed code parts * remove unused import * remove empty line * mark routes as stable	3 years ago
Jean-Philippe Quéméner	4cc8c6f745	Alerting: Add provenance guard to config api (#50147 ) * Alerting: add provenance guard to config api * add tests * only guard if config valid * adapt error message * simplify logic * rename arguments * make logic more straight forward * rename opt to options * remove useless maps	3 years ago
Jean-Philippe Quéméner	8de4ffe61f	Alerting: only delete mute time if not used by route (#50193 ) * Alerting: only delete mute time if not used by route * add a testcase * import package only once * replace apimodels with definitions	3 years ago
Yuriy Tseretyan	49d93fb67e	Alerting: Update alert rule diff to not see difference between nil and empty map (#50192 )	3 years ago
Jean-Philippe Quéméner	d2f3631a47	Alerting: add mute timings provenance to config api (#50149 )	3 years ago
Alexander Weaver	67290aa49f	Alerting: Add version segment to all provisioning routes (#49121 ) Co-authored-by: Jean-Philippe Quémémer <jeanphilippe.quemener@grafana.com>	3 years ago
Gilles De Mey	e6ceee501f	Alerting: Use correct permission scope for external AM updates (#50159 ) Co-authored-by: konrad147 <konrad.lalik@grafana.com>	3 years ago
Jean-Philippe Quéméner	468ed68d64	Alerting: allow custom UID for contact points through API (#50089 ) * Alerting: allow custom UID for contact points through API * fix auth	3 years ago
Jean-Philippe Quéméner	81d360529b	Alerting: Provisioning API - Alert rules (#47930 )	3 years ago
Ieva	5dbea9996b	RBAC: Make RBAC action names more consistent (#49730 ) * update action names * correctly retrieve teams for signed in user * remove test * undo swagger changes * undo swagger changes pt2 * add migration from old action names to the new ones * rename from list to read * linting * also update alertign actions * fix migration	3 years ago
Joe Blubaugh	9759eeda17	Alerting: Remove Image Upload code from Slack notifier. (#50062 ) The image file upload code as it is now simply doesn't work - it's missing several important steps in the file upload process. There is more information in the fixed issue as to the steps required. After this change, screenshots will still be attached to slack messages when external image storage is used with Grafana (an S3 bucket, for example). Fixes #50056	3 years ago
gotjosh	1a50b0dbb7	Alerting: Remove double quotes from matchers (#50038 ) * Alerting: Remove double quotes from matchers With #38629 a new Alertmanager configuration object was introduced with `object_matchers`, it was meant to circumvent around the fact that Prometheus label names don't support a set of characters that Grafana needs to support for alerts, silences, matchers, etc. (with a common example being elasticsearch's `.`). This new object does not include the label of sanitzation or validation that its Prometheus equivalent supports in `matchers` and therefore are semantically not equivalent. This triggered the problem that when the migration is run, we use `matchers` as the object to populate in configuration for routing policies, but when the UI does its first save this object is transformed to `object_matchers`. Matchers that were previously running just fine would immediately stop working as soon as the configuration is saved. This problem surfaced with the introduction of #49952 where we stopped stripping double quotes from matchers (not just regex but _all_ of them). * Add comment explaining rationale and future removal Co-authored-by: Alex Weaver <weaver.alex.d@gmail.com>	3 years ago
Kat Yang	c63ebc887b	Chore: Run integration tests without grabpl (#49448 ) * Chore: Run integration tests without grabpl * Add new step for integration tests in lib.star * Remove old integration test step from lib.star * Change drone signature * Fix: Edit starlark integration step to not affect enterprise * Remove all build tags & rename starlark integration test step * Resync .drone.yml with .drone.star * Fix lint errors * Fix lint errors * Fix lint errors * Fix more lint errors * Fix another lint error * Rename integration test step * Fix last lint error * Recomment enterprise step * Remove comment from Makefile Co-authored-by: Ida Furjesova <ida.furjesova@grafana.com>	3 years ago
Yuriy Tseretyan	c8d891785d	Alerting: Ticker to support stopping (#48142 ) * add stop for ticker * stop ticker when scheduler stops * stop ticker when legacy engine stops	3 years ago
Yuriy Tseretyan	ad25e2a20c	Alerting: Update RBAC for alert rules to consider access to rule as access to group it belongs (#49033 ) * update authz to exclude entire group if user does not have access to rule * change rule update authz to not return changes because if user does not have access to any rule in group, they do not have access to the rule * a new query that returns alerts in group by UID of alert that belongs to that group * collect all affected groups during calculate changes * update authorize to check access to groups * update tests for calculateChanges to assert new fields * add authorization tests	3 years ago
Joe Blubaugh	56f40bd413	Alerting: Add Go error message to warning log for screenshots. (#49870 ) Makes debugging problems with alert screenshotting easier.	3 years ago
kyamau	8b2a3a018d	Alerting: Chore: Fix event name in ngalert/README.md (#49829 ) Fix event name from evalContext to evaluation as #45144.	3 years ago
Matthew Jacobson	d92625125b	Alerting: Add templated subject config to email notifier (#49742 ) * Add subject templating to email notifier * Fix linting	3 years ago
George Robinson	47a3ddd968	Alerting: Add GetImages to ImageStore (#49717 ) * Alerting: Add GetImages to ImageStore * Use assert.ElementsMatch instead of sort.Sort	3 years ago
Joe Blubaugh	d5a327f43d	Alerting: Add tests for Slack Notifier Image Upload (#49669 ) Tests that file bytes are correctly read from storage when an image is available without a URL. Tests that not found and success cases are both handled.	3 years ago
Alexander Weaver	909ebcf979	Alerting: Endpoints for provisioning mute timings (#49635 ) * Add validator for mute timing and make it provisionable * Add tests to ensure prometheus validators are running and errors are propagated * Internal API for manipulating mute timings * Define and generate API layer * Wire up generated code * Implement API handlers * Tests for golang layer * Fix reference bug * Fix linter and auth tests * Resolve semantic errors and regenerate * Remove pointless comment * Extract out provisioning path param keys, simplify * Expected number of paths	3 years ago
Johannes Hertenstein	16d738a03a	Alerting: Do not include button in googlechat notification if URL invalid (#47317 ) * Alerting: Do not include button in googlechat notification if URL invalid * Apply suggestions from code review Co-authored-by: Alexander Weaver <weaver.alex.d@gmail.com> * Alerting: Add test case for invalid external URL in googlechat notifier Co-authored-by: Alexander Weaver <weaver.alex.d@gmail.com>	3 years ago
Sofia Papagiannaki	7cf321d7bd	Alerting: Fix swagger specification (#49273 ) * Alerting: fix specification * Update merged swagger specification	3 years ago
Joe Blubaugh	9e8efaa459	Alerting: Add stored screenshot utilities to the channels package. (#49470 ) Adds three functions: `withStoredImages` iterates over a list of models.Alerts, extracting a stored image's data from storage, if available, and executing a user-provided function. `withStoredImage` does this for an image attached to a specific alert. `openImage` finds and opens an image file on disk. Moves `store.Image` to `models.Image` Simplifies `channels.ImageStore` interface and updates notifiers that use it to use the simpler methods. Updates all pkg/alert/notifier/channels to use withStoredImage routines.	3 years ago
sh0rez	3ca3a59079	pkg/web: remove dependency injection (#49123 ) * pkg/web: store http.Handler internally * pkg/web: remove injection Removes any injection code from pkg/web. It already was no longer functional, as we already only injected into `http.Handler`, meaning we only inject ctx.Req and ctx.Resp. Any other types (Context, ReqContext) were already accessed using the http.Request.Context.Value() method. * : remove type mappings Removes any call to the previously removed TypeMapper, as those were non-functional already. pkg/web: remove Context.Invoke was no longer used outside of pkg/web and also no longer functional	3 years ago
Kristin Laemmert	debbb8d59d	sqlstore: finish removing Find and SearchDashboards (#49347 ) * chore: replace artisnal FakeDashboardService with generated mock Maintaining a handcrafted FakeDashboardService is not sustainable now that we are in the process of moving the dashboard-related functions out of sqlstore. * sqlstore: finish removing Find and SearchDashboards Find and SearchDashboards were previously copied into the dashboard service. This commit completes that work, removing Find and SearchDashboards from the sqlstore and updating callers to use the dashboard service. * dashboards: remove SearchDashboards from Store interface SearchDashboards is a wrapper around FindDashboard that transforms the results, so it's been moved out of the Store entirely and the functionality moved into the Dashboard Service's search implementation. The database tests depended heavily on the transformation, so I added testSearchDashboards, a copy of search dashboards, instead of (heavily) refactoring all the tests.	3 years ago
Kat Yang	50c2b4682a	Chore: Rename integration tests (#49438 ) * Chore: Rename integration tests * Remove one Integration Co-authored-by: Ida Furjesova <ida.furjesova@grafana.com>	3 years ago
Joe Blubaugh	a0193c248f	Alerting: Add entries to ngAlert changelog for screenshots. (#49457 ) Notes the PRs that added the feature.	3 years ago
Alexander Weaver	a92f85a87b	Alerting: Factor out shared code for working with configs in provisioning package (#49419 ) * Factor out shared code for working with configs * Refactor in notification policies and contact points * Better file ordering * Address feedback	3 years ago
Alexander Weaver	2ba4f7ed7d	Alerting: Attach image URLs to Google Chat notifications. (#49445 ) * Add a test card to see what styles look like * Add text and image cards * Address feedback	3 years ago
Alexander Weaver	d7c65d3323	Alerting: Attach image URLs or upload files to Discord notifications. (#49439 ) * Images in discord * Drop duplicated field initialization * Fix tests * Use the proper context	3 years ago

1 2 3 4 5 ...

640 Commits (e14c91d5d43e7c5a81267894033cb4769c069fd0)