30 Commits (e2ba6fbb00f6fef1b174fb718c7ecbf297091ce7)

Author	SHA1	Message	Date
Marcus Efraimsson	53cd39fde5	Shouldn't be able to overwrite a dashboard if you don't have permissions (#10900) ... * dashboards: new command for validating dashboard before update Removes validation logic from saveDashboard and later on use the new command for validating dashboard before saving a dashboard. This due to the fact that we need to validate permissions for overwriting other dashboards by uid and title. * dashboards: use the new command for validating dashboard before saving Had to refactor dashboard provisioning a bit to be able to sidetrack the permission validation in a somewhat reasonable way. Adds some initial tests of the dashboard repository, but needs to be extended later. At least now you can mock the dashboard guardian * dashboards: removes validation logic in the save dashboard api layer Use the dashboard repository solely for create/update dashboards and let it do all the validation. One exception regarding quota validation which still is in api layer since that logic is in a macaron middleware. Need to move out-commented api tests later. * dashboards: fix database tests for validate and saving dashboards * dashboards: rename dashboard repository to dashboard service Split the old dashboard repository interface in two new interfaces, IDashboardService and IDashboardProvisioningService. Makes it more explicit when using it from the provisioning package and there's no possibility of calling an incorrect method for saving a dashboard. * database: make the InitTestDB function available to use from other packages * dashboards: rename ValidateDashboardForUpdateCommand and some refactoring * dashboards: integration tests of dashboard service * dashboard: fix sqlstore test due to folder exist validation * dashboards: move dashboard service integration tests to sqlstore package Had to move it to the sqlstore package due to concurrency problems when running against mysql and postgres. Using InitTestDB from two packages added conflicts when clearing and running migrations on the test database * dashboards: refactor how to find id to be used for save permission check * dashboards: remove duplicated dashboard tests * dashboards: cleanup dashboard service integration tests * dashboards: handle save dashboard errors and return correct http status * fix: remove log statement * dashboards: import dashboard should use dashboard service Had to move alerting commands to models package due to problems with import cycles of packages. * dashboards: cleanup dashboard api tests and add some tests for post dashboard * dashboards: rename dashboard service interfaces * dashboards: rename dashboard guardian interface	8 years ago
bergquist	ad42883fc7	provisioning: adds setting to disable dashboard deletes	8 years ago
Leonard Gram	fa1b92a12b	provisioning: uses unix epoch timestamps. (#10907) ... * provisioning: uses unix epoch timestamps.	8 years ago
Leonard Gram	ba0285a3ec	provisioning: Warns the user when uid or title is re-used. (#10892) ... * provisioning: Warns the user when uid or title is re-used. Closes #10880	8 years ago
bergquist	f01890c3ff	provisioning: better variable naming	8 years ago
bergquist	84fea7c148	provisioning: dont return error unless you want to cancel all operations	8 years ago
bergquist	5a76624003	provisioning: createWalkFn doesnt have to be attached to the filereader anymore	8 years ago
bergquist	59cd2d5102	provisioning: avoid caching and use updated field from db	8 years ago
bergquist	31f3fdcba3	provisioning: delete dashboards before insert/update	8 years ago
bergquist	d62d5c7418	provisioning: delete dashboards from db when file is missing	8 years ago
bergquist	57e7048b8f	provisioning: enables title changes for dashboards	8 years ago
bergquist	77a4ccb822	dashboards: save provisioning meta data	8 years ago
bergquist	67a9e6a71d	provisioing: add lookup table provisioned dashboards	8 years ago
bergquist	7858965117	codestyle: extract code into methods	8 years ago
stobin	f1813ae3a3	Make file_reader follow symlinks	8 years ago
bergquist	34d7f8a44f	dashboards as cfg: property path replaces folder	8 years ago
bergquist	1a6c2ea8d8	dashboards as cfg: logs error when trying to import dashboard with id ... dashboard json cannot contain fixed id when importing from disk. We used to override this but it didnt caught all problems so now we block dashboards from beeing imported instead. closes #10504	8 years ago
bergquist	f5e00e133b	dashboards as cfg: moves dashcash into its own file	8 years ago
bergquist	237d469ed4	dashboards as cfg: create dashboard folders if missing ... closes #10259	8 years ago
bergquist	f4078e1935	tests: for skipping with hidden folders	8 years ago
Simon Aquino	5dbbf1826c	Avoid ID validation before provisioning dashboards ... Attempting to provision grafana using a previously exported JSON dashboard with the ID field already set, might result in an error. In fact, Grafana might believe that a dashboard with that given ID already exists in the database, throwing an error if it doesn't. (see pkg/services/sqlstore/dashboard.go#L32) The dashboard provisioner should set the dashboard id to zero in order to avoid this behaviour inducing the dashboard to be written to the DB without ID validation.	8 years ago
bergquist	1dfa529941	dashboards as cfg: avoid walking fs in parallel	8 years ago
bergquist	b28ea0b407	dashboards as cfg: type	8 years ago
bergquist	099178466d	dashboards as cfg: wire up dashboard repo	8 years ago
bergquist	288cc35529	dashboards as cfg: use gocache for caching	8 years ago
bergquist	f5eac2e91d	dashboards as cfg: expose dashboard service as interface	8 years ago
bergquist	16f072b320	dashboards as cfg: move saving logic for dashboards into its own service	8 years ago
bergquist	9cebb23e01	dashboards as cfg: revert minor changes	8 years ago
bergquist	74e12c260f	dashboards as cfg: move dashboard saving into its own service	8 years ago
bergquist	09cb0f378b	dashboards as cfg: minor tweaks	8 years ago
bergquist	93e1d8a19c	dashboards as cfg: make dashboard none editable by default	8 years ago
bergquist	dc0fb8be06	dashboards as cfg: code cleanup	8 years ago
bergquist	d69b63cbc0	dashboards as cfg: read first cfg version	8 years ago