19 Commits (e422a92eaec1edee5ae3a1631e7901f594468e51)

Author	SHA1	Message	Date
Matias Chomicki	9cb303c3f7	Log Rows: Added popover menu with filter options when a log line is selected (#75306) ... * LogRow: detect text selection * LogRow: refactor menu as component * LogRow: add actions to menu * LogRow: hack menu position * Remove unsused imports * LogRowMessage: remove popover code * PopoverMenu: refactor * LogRows: implement PopoverMenu at log rows level * PopoverMenu: implement copy * PopoverMenu: receive row model * PopoverMenu: fix onClick capture issue * Explore: add new filter methods and props for line filters * PopoverMenu: use new filter props * Explore: separate toggleable and non toggleable filters * PopoverMenu: improve copy * ModifyQuery: extend line filter with value argument * PopoverMenu: close with escape * Remove unused import * Prettier * PopoverMenu: remove label filter options * LogRow: rename text selection handling prop * Update test * Remove unused import * Popover menu: add unit test * LogRows: update unit test * Log row: hide the log row menu if the user is selecting text * Log row: dont hide row menu if popover is not in scope * Log rows: rename state variable * Popover menu: allow menu to scroll * Log rows: fix classname prop * Log rows: close popover if mouse event comes from outside the log rows * Declare new class using object style * Fix style declaration * Logs Popover Menu: add string filtering functions (#76757) * Loki modifyQuery: add line does not contain query modification * Elastic modifyQuery: implement line filters * Modify query: change action name to not be loki specific * Prettier * Prettier * Elastic: escape filter values * Popover menu: create feature flag * Log Rows: integrate logsRowsPopoverMenu flag * Rename feature flag * Popover menu: track interactions * Prettier * logRowsPopoverMenu: update stage * Popover menu: add ds type to tracking data * Log rows: move feature flag check * Improve handle deselection	2 years ago
Matias Chomicki	91ed2a6afe	Loki Query Editor: Add support for new logfmt features (#74619) ... * Loki autocomplete: add IN_LOGFMT situation for log queries * Loki autocomplete: add IN_LOGFMT situation for metric queries * Loki autocomplete: improve handling of trailing pipes and spaces * Loki autocomplete: add logfmt arguments completion * Loki autocomplete: add flags support to IN_LOGFMT * Loki autocomplete: extend IN_LOGFMT situation with labels and flag * Loki autocomplete: return logQuery in IN_LOGFMT situation * Loki autocomplete: offer label completions when IN_LOGFMT * Query utils: update parser detection method * Validation: update test * Loki autocomplete: improve IN_LOGFMT detection when in metric query * Loki autocomplete: improve logfmt suggestions * Loki autocomplete: improve logfmt suggestions in different scenarios * Loki autocomplete situation: refactor resolvers to support multiple paths * Situation: add test case * Loki autocomplete: allow user to use 2 flags * Situation: change flag to flags * Remove console log * Validation: import test parser * Completions: better handling of trailing comma scenario * Upgrade lezer-logql * Revert temporary imports * Loki Query Builder: Add support for new logfmt features (#74858) * Query builder: add params to logfmt definition * Logfmt operation: add default params * Query builder: update deprecated JsonExpression * Operation utils: update logfmt renderer * Query builder: parse LogfmtParser * Query builder: parse LogfmtExpressionParser * Remove console log * Remove unused variable * Remove extra character from render * Update unit tests * Fix unit tests * Operations: remove restParams from logfmt booleans * Parsing: group cases * Formatting * Formatting * Update modifyQuery * LogContextProvider: update with parser changes * LogContextProvider: remove unnecessary type castings It takes more energy to write `as unknow as LokiQuery` than to write a refId. * Formatting * Situation: use charAt instead of substring with endsWith * Situation: explain logfmt suggestions * Logfmt: improve flag suggestions * Remove console log * Completions: update test	2 years ago
Sven Grossmann	480aa1ccca	Loki: Fix filters not being added with multiple expressions and parsers (#75152) ... * determine last positions per expr * fix lint	2 years ago
Sven Grossmann	423a451858	Loki: Fix filtering with structured metadata (#73955) ... * check languageProvider to work with non-indexed metadata * change loki devenv to work with non-indexed metadata * trigger ci * add forced labels after parsers * add comment * Update public/app/plugins/datasource/loki/modifyQuery.ts Co-authored-by: Ivana Huckova <30407135+ivanahuckova@users.noreply.github.com> --------- Co-authored-by: Ivana Huckova <30407135+ivanahuckova@users.noreply.github.com>	2 years ago
Matias Chomicki	84f94cdc24	Logs: Show active state of "filter for value" buttons in Logs Details (#70328) ... * Datasource test: fix describe nesting * Parsing: export handleQuotes function * Modify query: add functions to detect the presence of a label and remove it * Loki: add support to toggle filters if already present * Datasource test: fix describe nesting * Loki: add support to toggle filter out if present * Remove label: handle escaped values * Datasource: add test case for escaped label values * Loki: remove = filter when applying != * Remove selector: add support for Selector node being far from Matcher * Modify query: add unit tests * Elasticsearch: create modifyQuery for elastic * Elastic modify query: implement functions * Elasticsearch: implement modifyQuery functions in datasource * Elasticsearch: update datasource test * Loki modify query: check for streamSelectorPositions length * Elasticsearch query has filter: escape filter value in regex * Remove unused type * Modify query: add functions to detect the presence of a label and remove it * Remove label: handle escaped values * Logs: create props to check for label filters in the query * Log Details Row: use label state props to show visual feedback * Make isCallbacks async * Explore: add placeholder for checking for filter in query * Datasource: define new API method * Inspect query: add base implementation * Remove isFilterOutLabelActive as it will not be needed * Check for "isActive" on every render Otherwise the active state will be out of sync * Elasticsearch: implement inspectQuery in the datasource * Logs: update test * Log details: update test * Datasources: update tests * Inspect query: rename to analize query to prevent confusion * Datasource types: mark method as alpha * Explore: add comment to log-specific functions * Remove duplicated code from bad rebase * Remove label filter: check node type * getMatchersWithFilter: rename argument * Fix bad rebase * Create DataSourceWithQueryManipulationSupport interface * Implement type guard for DataSourceWithQueryManipulationSupport * DataSourceWithQueryManipulationSupport: move to logs module * hasQueryManipulationSupport: change implementation `modifyQuery` comes from the prototype. * DataSourceWithQueryManipulationSupport: expand code comments * AnalyzeQueryOptions: move to logs module * DataSourceWithQueryManipulationSupport: add support for more return types * Fix merge error * Update packages/grafana-data/src/types/logs.ts Co-authored-by: Sven Grossmann <sven.grossmann@grafana.com> * DatasourceAPI: deprecate modifyQuery * Explore: refactor isFilterLabelActive * DataSourceWithQueryModificationSupport: rename interface * Split interfaces into Analyze and Modify * Query analysis: better name for interface * Fix guard * Create feature flag for active state * Use new feature flag in Explore * DataSourceToggleableQueryFiltersSupport: create a specific interface for this feature * Rename feature flag * De-deprecate modifyQuery * DataSourceToggleableQueryFiltersSupport: Rethink types and methods * Explore: adjust modifyQuery and isFilterLabelActive to new methods * Loki: implement new interface and revert modifyQuery * DataSourceToggleableQueryFiltersSupport: better name for arguments * Elasticsearch: implement new interface and revert modifyQuery * Loki: better name for arguments * Explore: document current limitation on isFilterLabelActive * Explore: place toggleable filters under feature flag * Loki: add tests for the new methods * Loki: add legacy modifyQuery tests * Elasticsearch: add tests for the new methods * Elasticsearch: add legacy modifyQuery tests * Toggle filter action: improve type values * Logs types: update interface description * DataSourceWithToggleableQueryFiltersSupport: update interface name * Update feature flag description * Explore: add todo comment for isFilterLabelActive --------- Co-authored-by: Sven Grossmann <sven.grossmann@grafana.com>	2 years ago
Sven Grossmann	13dd821961	Loki: Fix wrong query expression with inline comments (#70947) ... fix remove comments from query	2 years ago
Matias Chomicki	4c4bd69eb6	Logs: Add toggle behavior support for "filter for" and "filter out" label within Logs Details (#70091) ... * Datasource test: fix describe nesting * Parsing: export handleQuotes function * Modify query: add functions to detect the presence of a label and remove it * Loki: add support to toggle filters if already present * Datasource test: fix describe nesting * Loki: add support to toggle filter out if present * Remove label: handle escaped values * Datasource: add test case for escaped label values * Loki: remove = filter when applying != * Remove selector: add support for Selector node being far from Matcher * Modify query: add unit tests * Elasticsearch: create modifyQuery for elastic * Elastic modify query: implement functions * Elasticsearch: implement modifyQuery functions in datasource * Elasticsearch: update datasource test * Loki modify query: check for streamSelectorPositions length * Elasticsearch query has filter: escape filter value in regex * Remove unused type * Modify query: use query modeller instance from module	2 years ago
Sven Grossmann	d7337e4f9c	Loki: Preserve pipeline stages in context query (#70472) ... * add pipeline stages to context query * add ui * improve `Postion` * add `processPipelineStagesToExpr` to logcontextprovider * add ui toggle * fix lokicontextui tests * remove import * contextually hide the toggle * Update `SHOULD_INCLUDE_PIPELINE_OPERATIONS` name Co-authored-by: Ivana Huckova <30407135+ivanahuckova@users.noreply.github.com> * add setIncludePipelineOperations to false in revert * add prepareExpression method * remove unused method * fix test and add `runContextQuery` * set correct revert state * let let be const * remove argument --------- Co-authored-by: Ivana Huckova <30407135+ivanahuckova@users.noreply.github.com>	2 years ago
Ivana Huckova	2509dec0cb	Loki: Fix ad hoc filters when used with number and > and < operators (#66579) ... Loki: Fix ad hoc filters when used with number and >< operators	2 years ago
Ivana Huckova	a996344e14	Loki: Add autocomplete updates for improved suggestions (#64744) ... * Loki: Add autocomplete updates for improved suggestions * Use trimEnd for trailing pipeline * Update public/app/plugins/datasource/loki/components/monaco-query-field/monaco-completion-provider/completions.ts Co-authored-by: Matias Chomicki <matyax@gmail.com> * Fix unused imports --------- Co-authored-by: Matias Chomicki <matyax@gmail.com>	2 years ago
Gareth Dawson	b2c8126e6e	Loki: Show query size approximation (#62109) ... * feat: make api request to /loki/api/v1/index/stats * fix: add /index/stats to callResource valid urls * feat: make call to getQueryStats when the query changes * feat: render user tooltip displaying the estimated value for processed data * fix: add new props to component tests * test: add tests for query size estimation * fix: disable error message on request failure * refactor: add suggestions from code review * refactor: only pass required query string	3 years ago
Ivana Huckova	8bda8b8272	Log volume: Fix functionality if query has multiple comments (#61306) ... * Log volume: Fix functionality if query has comments * Add additional test	3 years ago
Gareth Dawson	bd9cce2866	Loki: Add hints for query filters (#60293) ... * add hint for label filter * add hint for line filter * add feature tracking for hints click * fix failing tests * add tests for new query builder hints * update hint labels * fix: hint continues to render after adding operation * add missing title property to hints * make use of isQueryWithParser and remove isQueryWithLogFmt * refactor isQueryWithLabelFilter * always render label operation, even if incomplete * suggestion * fix oversight in feature tracking name on hint click * update query hint label * improvements * add missing test for ADD_NO_PIPELINE_ERROR	3 years ago
Sven Grossmann	932349b5ab	Loki: Fix wrongly escaped label values when using LabelFilter (#59812) ... * change backticks to quotes * add unescaping to `addFilterAsLabelFilter` * fix removal of wrong quotes * change unescape order	3 years ago
Ivana Huckova	28c390bc90	Loki: Fix adhoc parsing if multiple stream selectors and some empty (#58658)	3 years ago
Ivana Huckova	7928f170ce	Loki: Fix adding of adhoc filters to stream selector when query with empty stream selector (#57280) ... * disable double stringify * Refactor test for addLabelToQuery * Add tests (TDD for expected behaviour) * Fix adding ad hoc filters to correct place when no stream selector * Update * Update comment * Fix getAllPositionsInNodeByType Co-authored-by: Sven Grossmann <svennergr@gmail.com>	3 years ago
GitStart	46f0672215	Loki: Remove hardcoded values for parsed query parts (#54755) ... Co-authored-by: Nitesh Singh <nitesh.singh@gitstart.dev> Co-authored-by: gitstart <gitstart@users.noreply.github.com> Co-authored-by: Rafael Toledo <87545086+Toledodev@users.noreply.github.com> Co-authored-by: Murilo Amaral <87545137+MuriloAmarals@users.noreply.github.com> Co-authored-by: gitstart <gitstart@gitstart.com> Co-authored-by: Matheus Benini Ferreira <88898100+MatheusBeniniF@users.noreply.github.com> Co-authored-by: Matheus Benini <matheus_benini@hotmail.com> Co-authored-by: Rubens Rafael <70234898+RubensRafael@users.noreply.github.com> Co-authored-by: Júlio Piubello da Silva Cabral <julio.piubello@gitstart.dev> Co-authored-by: gitstart <gitstart@users.noreply.github.com> Co-authored-by: Nitesh Singh <nitesh.singh@gitstart.dev> Co-authored-by: Rafael Toledo <87545086+Toledodev@users.noreply.github.com> Co-authored-by: Murilo Amaral <87545137+MuriloAmarals@users.noreply.github.com> Co-authored-by: gitstart <gitstart@gitstart.com> Co-authored-by: Matheus Benini Ferreira <88898100+MatheusBeniniF@users.noreply.github.com> Co-authored-by: Matheus Benini <matheus_benini@hotmail.com> Co-authored-by: Rubens Rafael <70234898+RubensRafael@users.noreply.github.com> Co-authored-by: Júlio Piubello da Silva Cabral <julio.piubello@gitstart.dev>	3 years ago
renovate[bot]	4c8ea0bb89	Update dependency @lezer/common to v1 (#50866) ... * Update dependency @lezer/common to v1 * Bump lezer/lr as well * Fix broken code * Add new lezer-promql and update lezer-logql * Change to prometheus lezer-promql, fix lezer-logql code * Update tests for Loki * fix typeErrors * fix tests by adding new error node to expected objects * refactor usages of node references to differentiate usage from node object Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: Zoltán Bedi <zoltan.bedi@gmail.com> Co-authored-by: Ivana Huckova <ivana.huckova@gmail.com> Co-authored-by: gtk-grafana <galen.kistler@grafana.com>	3 years ago
Ivana Huckova	bf3fa4a445	Loki: Fix producing correct log volume query for query with comments (#53254) ... * Loki: Remove comments from log volume query * Update, add more tests * Update based on suggestions * Update * Update tests to use it.each	3 years ago
Ivana Huckova	772b6396f5	Loki: Add hints for level-like labels (#52414) ... * Loki: Add hint for level-like label * Add test to addToQuery * Add tests * Update tests * Update copy * Get log position in metrics query and add test * Update	3 years ago
Ivana Huckova	c087198b1b	Loki: Fix adding of multiple label filters when parser (#52335) ... * Loki: Fix adding multiple filters * Update logic in sorting	3 years ago
Ivana Huckova	1d077e84ce	Loki: Add hint for pipeline error to query builder (#52134) ... * WIP * Update * Add tests * Fix lint/betterer errors * Update public/app/plugins/datasource/loki/addToQuery.ts * Update copy	3 years ago
Ivana Huckova	10cb84e401	Loki: Implement hints for query builder (#51795) ... * Loki: Implement hints for query builder * Update name of file * Update imports * Refactor * Remove unused import * Unify * Revert "Unify" This reverts commit 78da0e27e3. * Unify * Fix types * Fix tests * Fix type error * Simplify * Update test * Add documentation * Update comment * Add tests for addParserToQuery * Smaller updates	3 years ago
Ivana Huckova	d3dd3042d6	Loki: Fix support of ad-hoc filters for specific queries (#51232) ... * Loki: Refactor ad-hoc filters to use parser * Remove renaming of files for easier review * Update * Update * Add previously buggy test * Fix tests * Fix typos * Update, improve typing * Move reused code up * Update order * Update betterer statss	3 years ago
Josh Hunt	3c6e0e8ef8	Chore: ESlint import order (#44959) ... * Add and configure eslint-plugin-import * Fix the lint:ts npm command * Autofix + prettier all the files * Manually fix remaining files * Move jquery code in jest-setup to external file to safely reorder imports * Resolve issue caused by circular dependencies within Prometheus * Update .betterer.results * Fix missing // @ts-ignore * ignore iconBundle.ts * Fix missing // @ts-ignore	3 years ago
Ivana Huckova	64cf0aa813	Loki: Fix adding of ad hoc filters for queries with parser and line_format expressions (#42590) ... * Loki: Fix ad hoc filtewrs for queries with line_format * Fix tests	4 years ago
kay delaney	bad048b7ba	Performance: Standardize lodash imports to use destructured members (#33040) ... * Performance: Standardize lodash imports to use destructured members Changes lodash imports of the form `import x from 'lodash/x'` to `import { x } from 'lodash'` to reduce bundle size. * Remove unnecessary _ import from Graph component * Enforce lodash import style * Fix remaining lodash imports	4 years ago
Ivana Huckova	b2ca9cbda6	Prometheus: Fix issues with ad-hoc filters (#30931) ... * Don't add {} to non-metrics starting with quotes * Fix for using template variables * Fix adding of filter to timerange * Fix adding of filter to labels provided with group modifier * Fix adding of filters to Grafana's variables * Shorten tests * Refactor and split	5 years ago
Zoltán Bedi	f33158dcdf	Prometheus: parse value as number when label is le (#26375) ... * Prometheus: parse value as number when label is le * Convert prometheus table value back to string for modify query	5 years ago
Lukas Siatka	60e7b63c33	Loki/Prometheus: updates addLabelToQuery method to prevent it from adding labels outside of selector when using Loki datasource (#25059) ... * Chore: updates add label to query method in prometheus datasource to fix loki label insert * Chore: adds addLabelToQuery test covering differences between adding label to loki vs non-loki queries * Chore: adds an additional comment to addLabelToQuery * Chore: renames isLokiDatasource to hasNoMetrics in addLabelToQuery	5 years ago
Ivana Huckova	4f5ce48b2a	Loki: Fix label matcher for log metrics queries (#24238) ... * Fix switched filter buttons * Fix filter for and filter out for metrics queries * Add test coverage	5 years ago
Ivana Huckova	c6a9a83bf3	Explore: Keep logQL filters when selecting labels in log row details (#20570)	6 years ago
Hugo Häggmark	3424b64299	Typescript: Removes implicit anys (#17625) ... * Chore: Remove implicit anys from ResultProcessor and tests * Chore: Removes implicit anys for /loki/**/*.ts * Chore: Removes implicit anys for prometheus/**/*	6 years ago
tolwi	f0109be2bc	fix(prometheus): issue with click label to filter for recording rules in Explore	6 years ago
Mitsuhiro Tanda	d2968c73e6	add PromQL keyword for adhoc filter (#16426)	6 years ago
David Kaltschmidt	c3b67f3a13	Explore: Logging label filtering ... - adds a custom label renderer to Logs viewer in Explore - labels are no longer treated as strings, they are passed as parsed objects to the log row - label renderer supports onClick handler for an action - renamed Explore's `onClickTableCell` to `onClickLabel` and wired up log label renderers - reuse Prometheus `addLabelToSelector` to modify Logging queries via click on label - added tests to `addLabelToSelector`, changed to include the surrounding `{}` - use label render also for common labels in the controls panel - logging meta data section has now a custom renderer that can render numbers, strings, and labels - style adjustments	7 years ago
praveensastry	61bbe280ed	Remove duplicate labels in the datasource query	7 years ago
David Kaltschmidt	6aac8610eb	Explore: Fix click to filter for recording rule expressions ... - recording rule names contain ':' - include this in the pattern for metric names	7 years ago
David	a5bcd4b8e4	Adhoc-filtering for prometheus dashboards (#13212) ... * Basic adhoc-filtering support for prometheus	7 years ago