52 Commits (e51b92991d6efa40456924f7572fb69d35c8989c)

Author	SHA1	Message	Date
Ieva	e51b92991d	Folders: return an error when listing folders if permission guardian returns an error (#68109) ... return an error when listing folders if perm gaurdian returns an error	3 years ago
Arati R	a5206a1cda	Nested folders: Provide count of all descendant dashboards and folders (#67184) ... * Add a method for getting descendant folders * Include dashboard count for descendant folders * Return subfolder count * Replace references to children with descendants * Update openapi specs * Add test for descendant counts * Add logging to GetDescendantCounts	3 years ago
Arati R	fd434cab58	NestedFolders: Add API endpoint for descendant count in a folder (#66550) ... * Add CountInFolder to RegistryService interface * Add folder children counts api route * Update fake GetFolderChildrenCounts * Add test for getting folder children counts * Add validation to folder children counts handler * Update openapi specs * Update pkg/services/folder/folderimpl/folder.go Co-authored-by: Sofia Papagiannaki <1632407+papagian@users.noreply.github.com> --------- Co-authored-by: Sofia Papagiannaki <1632407+papagian@users.noreply.github.com>	3 years ago
Sofia Papagiannaki	24696d593b	Nested folders: Fix error response codes (#66943) ... * Nested folders: Fix error response codes Fix error handling	3 years ago
Arati R	cab3ba519a	NestedFolders: Add folder service registry with dashboard service implementation (#65033) ... * Delete folders, dashboards with registry service Co-authored-by: Serge Zaitsev <hello@zserge.com> * Update signature of ProvideDashboardServiceImpl * Regenerate mockery file * Add test for DeleteInFolder * Add test for DeleteDashboardsInFolder * Delete child dashboard associations via registry * Add validation of folder uid and org id --------- Co-authored-by: Serge Zaitsev <hello@zserge.com>	3 years ago
Sofia Papagiannaki	a270188f0c	Nested folders: Fix moving folder under root (#65684) ... * Nested folders: Fix moving folder under root * Add store test for not empty parent after update * Modify folder and document store update implementation Move folder only if NewParentUID is not nil * Apply suggestion from code review	3 years ago
Ieva	7860ca6c3d	RBAC: protect folder creation and moving (#64636) ... * protect moving folders to a subfolder and creating folders in a subfolder * folder update endpoint isn't used for folder parent update * lint * move permission check logic to services, fix tests * linting	3 years ago
ying-jeanne	6974f4340b	NestedFolders: Fix nested folder deletion (#63572) ... --------- Co-authored-by: suntala <arati.rana@grafana.com> Co-authored-by: ying-jeanne <ying-jeanne@users.noreply.github.com> Co-authored-by: jeanne0731 <jeanne0731@users.noreply.github.com>	3 years ago
Ieva	a52999a886	Access Control: revert to using folder store from the scope resolvers (#64132) ... * revert to using folder store from the resolvers * fixing tests after revert * api test fixes --------- Co-authored-by: Kristin Laemmert <mildwonkey@users.noreply.github.com>	3 years ago
Kristin Laemmert	bb798e24f3	chore(services): replace dependencies on dashboard store with dashboard service (#63937) ... * chore(services): replace dependencies on dashboard store with dashboard service This continues the backend service/store split by replacing dashboard store dependencies with service dependencies. the folder service remains the single exception for now; otherwise we'd have a dependency cycle between the folder and dashboard services. I have some ideas for that, but I'll take care of all the easy parts first. While doing this, I identified and removed a number of unused arguments from the following functions: NewFolderNameScopeResolver NewFolderIDScopeResolver NewFolderUIDScopeResolver NewDashboardIDScopeResolver NewDashboardUIDScopeResolver resolveDashboardScope I have a small enterprise PR to support this commit. * lingering fmt	3 years ago
Ieva	4570131fe5	Folders: simplify guardian permissions checks (#63183) ... simplify code	3 years ago
Sofia Papagiannaki	225c8dbba7	Chore: Fix fetching the General folder when nested folders is set and improve error handling (#62951) ... * Nested folders: Modify Get() not to fail fetching the General folder * Add test	3 years ago
Ieva	078639abcd	RBAC: add folder UID scope resolver (#62695) ... * add folder uid scope resolver * undo guardian change, move it to a separate PR * fix test + linting	3 years ago
Ryan McKinley	b1e58eb47e	Chore: Replace short UID generation with more standard UUIDs (#62731)	3 years ago
Sofia Papagiannaki	ee2878f189	Chore: Fix logging message in folder service (#62939)	3 years ago
Josh Hunt	4d268cbcdb	NestedFolders: use guardian.NewByUID to check folder permissions (#62864)	3 years ago
Sofia Papagiannaki	adaf82ffb7	Nested Folder: Fix for SQLite not to overwrite the parent on restarts (#62709) ... Nested Folder: Fix for SQLite not to overwrite the arent on restarts	3 years ago
Sofia Papagiannaki	f143b0a5b2	Chore: Move folder store interface, implementation and test under pkg/services/folder (#62586) ... * Chore: Move folder store into folder service package * Split folder and dashboard store implementations	3 years ago
Ieva	ee3d742c7d	RBAC: inherit folder permissions when resolving managed permissions (#62244) ... * add nested folder scope inheritance to managed permission services * add a more specific erorr * remove circular dependencies * use errutil for returning erorr * fix tests * fix tests * define a new error in ac package	3 years ago
Serge Zaitsev	bc2813ef06	Chore: Fix goimports grouping in pkg/services (#62420) ... * fix goimports * fix goimports order	3 years ago
Kristin Laemmert	e8b8a9e276	chore: move dashboard_acl models into dashboard service (#62151)	3 years ago
Sofia Papagiannaki	cd27562c76	Access control: Modify dashboard/folder resolvers so that return also the inherited scopes (#62025) ... * Access Control: Add folder service dependency to the dashboard/folder resolvers * Expose the function fetching parents to folder interface * Add generic prepend utility * Modify dashboard resolvers to return inherited scopes	3 years ago
idafurjes	b54b80f473	Chore: Remove Result from dashboard models (#61997) ... * Chore: Remove Result from dashboard models * Fix lint tests * Fix dashboard service tests * Fix API tests * Remove commented out code * Chore: Merge main - cleanup	3 years ago
Sofia Papagiannaki	c7a7ebd3e0	Chore: Drop search service dependency from folder service (#61789) ... * Chore: Drop search service dependency from folder service	3 years ago
idafurjes	68445a7c77	Chore: Remove dashboard ACL from models (#61749) ... * Remove dashboard ACL from models * Remove unused comment	3 years ago
Sofia Papagiannaki	c104cc7020	Chore: Split folder store and dashboard store interfaces (#61655) ... * update folder store mock * Split folder store and dashboard store interfaces	3 years ago
Sofia Papagiannaki	b80c9bb974	Chore: Drop dashboard service dependency from folder service (#61614) ... * Chore: Drop dashboard dependency from folder service	3 years ago
idafurjes	b573b19ca3	Chore: Remove dashboards from models pkg (#61578) ... * Copy dashboard models to dashboard pkg * Use some models from current pkg instead of models * Adjust api pkg * Adjust pkg services * Fix lint * Chore: Remove dashboards models * Remove dashboards from models pkg * Fix lint in tests * Fix lint in tests 2 * Fix for import in auth * Remove newline * Revert unused fix	3 years ago
idafurjes	7c2522c477	Chore: Move dashboard models to dashboard pkg (#61458) ... * Copy dashboard models to dashboard pkg * Use some models from current pkg instead of models * Adjust api pkg * Adjust pkg services * Fix lint	3 years ago
Sofia Papagiannaki	e2ed42c2a3	Nested folders: Do not expose the sequential ID from the folder store (#60702) ... * Nested folders: Do not expose the sequential ID from the folder store	3 years ago
Sofia Papagiannaki	4df78cebc2	Nested Folders: Unify folder services (#60390) ... * Nested Folders: Unify folder services	3 years ago
Sofia Papagiannaki	55b014974d	Nested folders: Refactor folder update (#60323) ... * Nested folders: Refactor folder update * Apply suggestions from code review	3 years ago
Sofia Papagiannaki	b1ef5ab320	Nested Folders: Support listing nested folder children (#58566) ... * Nested Folders: Support listing nested folder children * Filter out subfolders with no permissions * Apply suggestion from code review	3 years ago
Sofia Papagiannaki	11d8bcbea9	Guardian: Introduce additional constructors (#59577) ... * Guardian: Use dashboard UID instead of ID * Apply suggestions from code review Introduce several guardian constructors and each time use the most appropriate one.	3 years ago
ying-jeanne	b059296cb0	[nested folder]Add circular reference detection in create nested folder (#60163) ... * add circulic reference detection in create neste folder * redeclare mock * add log for getHeight when depassing limit	3 years ago
ying-jeanne	1131bac5da	[Nested Folder] Block move operation that could introduce more than 8 level of depth,… (#59832) ... * block move operation that could introduce more than 8 level of depth, forbid circular reference * move getHeight to store, mock store in service * fix linter	3 years ago
Sofia Papagiannaki	798a8ceb9c	Nested folders: Fix delete (#59627) ... * Fix deleting subfolder It used to fail with beause of missing signed in user * Add logging * fixup * Fail request if deleting nested folder has failed Before we only used to log the error * Fix failing test During failed nested folder creation call the dashboard store deletion instead of the service one.	3 years ago
Sofia Papagiannaki	f5c41ea497	Nested Folders: More API fixes (#59316) ... * Nested Folder: Fix create, use camel case for JSON properties * Fix get parents if the folder does not exist * Add store test for get parents	3 years ago
Sofia Papagiannaki	8e6d343981	Nested Folders: Some API fixes (#59298) ... * Nested Folders: Fix API responses * Fix panic during deletions * Add test	3 years ago
Sofia Papagiannaki	ad96b240fc	Nested Folder: Enforce maximum nested folder depth (#59213) ... * Nested Folder: Enforce maximum nested folder depth * Cleanup * Fix logging	3 years ago
Sofia Papagiannaki	0af96936be	Nested Folders: Do not refer to the configuration for checking for the flag (#59197) ... * Nested Folders: Do not refer to the configuration for checking for the flag Use always features.IsEnabled() instead * Depend on the interface instead	3 years ago
Sofia Papagiannaki	02b6b09121	Nested Folders: Set user in the API level (#59148)	3 years ago
ying-jeanne	69b5a9c752	Chore: [Nested Folder] Add db migration at service start time (#58590) ... * add db migration at service start time * make changes for the 3 db * revert migrator * fix feature toggle check Co-authored-by: Serge Zaitsev <serge.zaitsev@grafana.com>	3 years ago
idafurjes	080ea88af7	Nested Folders: Support getting of nested folder in folder service wh… (#58597) ... * Nested Folders: Support getting of nested folder in folder service when feature flag is set * Fix lint * Fix some tests * Fix ngalert test * ngalert fix * Fix API tests * Fix some tests and lint * Fix lint 2 * Fix library elements and panels * Add access control to get folder * Cleanup and minor test change	3 years ago
ying-jeanne	b13b58ebf8	Add move endpoint into folder service (#58575) ... * add move endpoint * change signatures	3 years ago
idafurjes	30f0d66983	Folder: Add implementation for Update for nested folder (#58479) ... * Add implementation for Update nested folder * Remove parent uid from Update * Fix update	3 years ago
Sofia Papagiannaki	bf5a08e039	API: Support creating a nested folder (#58508) ... * API: Support nested folder creation * Update swagger * fixup * Update pkg/api/dtos/folder.go Co-authored-by: Serge Zaitsev <serge.zaitsev@grafana.com> * Fix some tests * create legacy folder url from title and uid Co-authored-by: idafurjes <36131195+idafurjes@users.noreply.github.com> Co-authored-by: Serge Zaitsev <serge.zaitsev@grafana.com> Co-authored-by: Ida Furjesova <ida.furjesova@grafana.com>	3 years ago
ying-jeanne	accb4dea55	[Nested Folder] Delete folder methode (#58444) ... * transfer DeleteFolder changes from larger PR * finish some thingies * add the simplest delete logics * some intermedia steps * fix tests * add test * fix some comments Co-authored-by: yangkb09 <yangkb09@gmail.com>	3 years ago
Kristin Laemmert	a255c32e1a	nested folders: support creation of nested folders in folder service when feature flag is set (#58364) ... * nested folders: support creation of nested folders in folder service when feature flag is set	3 years ago
idafurjes	af2f51f196	Folder: Add folder service implementation (#58182) ... * Folder: Add folder service implementation * Add Move * Add tests * Add new servie method and adjust Update, Delete and Move * Remove contains * GetTree return children of depth one	3 years ago