69 Commits (e9b932c8f69c3d2f49c1cd9ae35b7dd6157c71e7)

Author	SHA1	Message	Date
Fayzal Ghantiwala	df25e9197e	Alerting: Get grafana-managed alert rule by UID (#86845) ... * Add auth checks and test * Check user is authorized to view rule and add tests * Change naming * Update Swagger params * Update auth test and swagger gen * Update swagger gen * Change response to GettableExtendedRuleNode * openapi3-gen * Update tests with refactors models pkg	1 year ago
Yuri Tseretyan	48de8657c9	Alerting: Editor role can access all provisioning API (#85022)	1 year ago
Yuri Tseretyan	b9abb8cabb	Alerting: Update provisioning API to support regular permissions (#77007) ... * allow users with regular actions access provisioning API paths * update methods that read rules skip new authorization logic if user CanReadAllRules to avoid performance impact on file-provisioning update all methods to accept identity.Requester that contains all permissions and is required by access control. * create deltas for single rul e * update modify methods skip new authorization logic if user CanWriteAllRules to avoid performance impact on file-provisioning update all methods to accept identity.Requester that contains all permissions and is required by access control. * implement RuleAccessControlService in provisioning * update file provisioning user to have all permissions to bypass authz * update provisioning API to return errutil errors correctly --------- Co-authored-by: Alexander Weaver <weaver.alex.d@gmail.com>	1 year ago
Yuri Tseretyan	e593d36ed8	Alerting: Update rule access control to explicitly check for permissions "alert.rules:read" and "folders:read" (#78289) ... * require "folders:read" and "alert.rules:read" in all rules API requests (write and read). * add check for permissions "folders:read" and "alert.rules:read" to AuthorizeAccessToRuleGroup and HasAccessToRuleGroup * check only access to datasource in rule testing API --------- Co-authored-by: William Wernert <william.wernert@grafana.com>	1 year ago
Gilles De Mey	8765c48389	Alerting: Remove legacy alerting (#83671) ... Removes legacy alerting, so long and thanks for all the fish! 🐟 --------- Co-authored-by: Matthew Jacobson <matthew.jacobson@grafana.com> Co-authored-by: Sonia Aguilar <soniaAguilarPeiron@users.noreply.github.com> Co-authored-by: Armand Grillet <armandgrillet@users.noreply.github.com> Co-authored-by: William Wernert <rwwiv@users.noreply.github.com> Co-authored-by: Yuri Tseretyan <yuriy.tseretyan@grafana.com>	1 year ago
Joe Blubaugh	b905777ba9	Alerting: Support deleting rule groups in the provisioning API (#83514) ... * Alerting: feat: support deleting rule groups in the provisioning API Adds support for DELETE to the provisioning API's alert rule groups route, which allows deleting the rule group with a single API call. Previously, groups were deleted by deleting rules one-by-one. Fixes #81860 This change doesn't add any new paths to the API, only new methods. --------- Co-authored-by: Yuri Tseretyan <yuriy.tseretyan@grafana.com>	1 year ago
William Wernert	2ab7d3c725	Alerting: Receivers API (read only endpoints) (#81751) ... * Add single receiver method * Add receiver permissions * Add single/multi GET endpoints for receivers * Remove stable tag from time intervals See end of PR description here: https://github.com/grafana/grafana/pull/81672	1 year ago
Yuri Tseretyan	d1073deefd	Alerting: Time intervals API (read only endpoints) (#81672) ... * declare new API and models GettableTimeIntervals, PostableTimeIntervals * add new actions alert.notifications.time-intervals:read and alert.notifications.time-intervals:write. * update existing alerting roles with the read action. Add to all alerting roles. * add integration tests	1 year ago
Sofia Papagiannaki	b1eec36df3	Alerting: Fix authorisation to use namespace UIDs for scope (#81231)	1 year ago
Matthew Jacobson	aa03b8f8a7	Alerting: Guided legacy alerting upgrade dry-run (#80071) ... This PR has two steps that together create a functional dry-run capability for the migration. By enabling the feature flag alertingPreviewUpgrade when on legacy alerting it will: a. Allow all Grafana Alerting background services except for the scheduler to start (multiorg alertmanager, state manager, routes, …). b. Allow the UI to show Grafana Alerting pages alongside legacy ones (with appropriate in-app warnings that UA is not actually running). c. Show a new “Alerting Upgrade” page and register associated /api/v1/upgrade endpoints that will allow the user to upgrade their organization live without restart and present a summary of the upgrade in a table.	1 year ago
Yuri Tseretyan	8af08d0df2	Alerting: Add export of mute timings to file provisioning formats (#79225) ... * add export of mute timings to file provisioning formats * support export of mute timings to HCL	1 year ago
Yuri Tseretyan	7cec741bae	Alerting: Extract alerting rules authorization logic to a service (#77006) ... * extract alerting authorization logic to separate package * convert authorization logic to service	2 years ago
Yuri Tseretyan	0a50ca7231	Alerting: Let users with regular permissions access export endpoints (#76082) ... let users with regular permissions access export endpoints	2 years ago
Yuri Tseretyan	027bd9356f	Alerting: Rule Modify Export APIs (#75322) ... * extend RuleStore interface to get namespace by UID * add new export API endpoints * implement request handlers * update authorization and wire handlers to paths * add folder error matchers to errorToResponse * add tests for export methods	2 years ago
Yuri Tseretyan	6b4a9d73d7	Alerting: Export contact points to check access control action instead legacy role (#71990) ... * introduce a new action "alert.provisioning.secrets:read" and role "fixed:alerting.provisioning.secrets:reader" * update alerting API authorization layer to let the user read provisioning with the new action * let new action use decrypt flag * add action and role to docs	2 years ago
Matthew Jacobson	cfb1656968	Alerting: Add notification policy provisioning file export (#70009) ... * Alerting: Add notification policy provisioning file export - Add provisioning API endpoint for exporting notification policies. - Add option in notification policy view ellipsis dropdown for exporting. - Update various provisioning documentation.	2 years ago
Matthew Jacobson	13121d3234	Alerting: Add contact point provisioning file export (#71692) ... * Add contact point provisioning file export apis * Regenerate api * docs * frontend * add mock to tests * Fix missing row-level export button on viewer role w/ prov. read * Address review comments --------- Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com>	2 years ago
Horst Gutmann	f4c04d4055	Alerting: Update patch for #865 after #68898 (#890)	2 years ago
dsotirakis	f9c310dbaf	Require alert.notifications:write permissions to test receivers and templates (#865) ... # Conflicts: # pkg/services/ngalert/api/authorization.go	2 years ago
Ieva	4980b64274	RBAC: Remove legacy ac from authorization middleware (#68898) ... remove legacy AC fallback from RBAC middleware, and some unused auth logic	2 years ago
Matthew Jacobson	91471ac7ae	Alerting: Template Testing API (#67450)	2 years ago
Matthew Jacobson	85f738cdf9	Alerting: Add endpoint to revert to a previous alertmanager configuration (#65751) ... * Alerting: Add endpoint to revert to a previous alertmanager configuration This endpoint is meant to be used in conjunction with /api/alertmanager/grafana/config/history to revert to a previously applied alertmanager configuration. This is done by ID instead of raw config string in order to avoid secure field complications.	2 years ago
Santiago	aba91d3053	Alerting: Fetch all applied alerting configurations (#65728) ... * WIP * skip invalid historic configurations instead of erroring * add warning log when bad historic config is found * remove unused custom marshaller for GettableHistoricUserConfig * add id to historic user config, move limit check to store, fix typo * swagger spec	2 years ago
Alexander Weaver	6ad1cfef38	Alerting: Add endpoint for querying state history (#62166) ... * Define endpoint and generate * Wire up and register endpoint * Cleanup, define authorization * Forgot the leading slash * Wire up query and SignedInUser * Wire up timerange query params * Add todo for label queries * Drop comment * Update path to rules subtree	2 years ago
ismail simsek	91221bc436	Expressions: Fixes the issue showing expressions editor (#62510) ... * Use suggested value for uid * update the snapshot * use __expr__ * replace all -100 with __expr__ * update snapshot * more changes * revert redundant change * Use expr.DatasourceUID where it's possible * generate files	2 years ago
Matthew Jacobson	c006df375a	Alerting: Create endpoints for exporting in provisioning file format (#58623) ... This adds provisioning endpoints for downloading alert rules and alert rule groups in a format that is compatible with file provisioning. Each endpoint supports both json and yaml response types via Accept header as well as a query parameter download=true/false that will set Content-Disposition to recommend initiating a download or inline display. This also makes some package changes to keep structs with potential to drift closer together. Eventually, other alerting file structs should also move into this new file package, but the rest require some refactoring that is out of scope for this PR.	2 years ago
Yuri Tseretyan	ad09feed83	Alerting: rule backtesting API (#57318) ... * Implement backtesting engine that can process regular rule specification (with queries to datasource) as well as special kind of rules that have data frame instead of query. * declare a new API endpoint and model * add feature toggle `alertingBacktesting`	2 years ago
Alexander Weaver	e97b43cd58	Alerting: Add provisioning endpoint to fetch all rules (#59989) ... * Domain layer api for fetching all rules * Add endpoint for getting all rules	2 years ago
Santiago	cdb5d4230a	Alerting: Fix "Not Implemented" responses (#57710) ... * fix swagger spec, return 404 instead of 501 when an endpoint does not exist * update number of paths in authorization_test.go	3 years ago
Santiago	09f8e026a1	Alerting: Expose info about notification delivery errors in a new /receivers endpoint (#55429) ... * (WIP) switch to fork AM, first implementation of the API, generate spec * get receivers avoiding race conditions * use latest version of our forked AM, tests * make linter happy, delete TODO comment * update number of expected paths to += 2 * delete unused endpoint code, code review comments, tests * Update pkg/services/ngalert/notifier/alertmanager.go Co-authored-by: Matthew Jacobson <matthew.jacobson@grafana.com> * remove call to fmt.Println * clear naming for fields * shorter variable names in GetReceivers Co-authored-by: Matthew Jacobson <matthew.jacobson@grafana.com>	3 years ago
Yuriy Tseretyan	8a62020211	Alerting: New API endpoint GET /api/v1/ngalert (#55134) ... * declare new endpoint /api/v1/ngalert * add authorization for new path * add request handler for the new path	3 years ago
Alexander Weaver	c50cbea0bb	Alerting: Extract alert rule diff logic into separate file with exported API (#53083) ... * Refactor diff logic into separate file with exported API * Fix linter complaint	3 years ago
Alexander Weaver	fce283d73e	Alerting: Add method to reset notification policy tree back to the default (#51934) ... * Define route and run codegen * Wire up HTTP layer * Update API layer and test fakes * Implement reset of policy tree * Implement service layer test and authorization bindings * API layer testing * Be more specific when injecting settings	3 years ago
Alexander Weaver	b9c7eb1380	Alerting: Add method to provisioning API for obtaining a group and its rules (#51398) ... * Generate shell for new route * Propagate path parameters * Implement route logic * Add a couple simple tests * Use NotFound error for not found, avoid returning pointer * Regenerate	3 years ago
Yuriy Tseretyan	54fa04263b	Alerting: Add RBAC actions and role for provisioning API routes (#50459) ... * add alert provisioning actions and role * linter	3 years ago
Alexander Weaver	28a47b56d2	Bump provisioning to admin-only in lieu of dedicated RBAC permissions (#50366)	3 years ago
Alexander Weaver	67290aa49f	Alerting: Add version segment to all provisioning routes (#49121) ... Co-authored-by: Jean-Philippe Quémémer <jeanphilippe.quemener@grafana.com>	3 years ago
Gilles De Mey	e6ceee501f	Alerting: Use correct permission scope for external AM updates (#50159) ... Co-authored-by: konrad147 <konrad.lalik@grafana.com>	3 years ago
Jean-Philippe Quéméner	468ed68d64	Alerting: allow custom UID for contact points through API (#50089) ... * Alerting: allow custom UID for contact points through API * fix auth	3 years ago
Jean-Philippe Quéméner	81d360529b	Alerting: Provisioning API - Alert rules (#47930)	3 years ago
Yuriy Tseretyan	ad25e2a20c	Alerting: Update RBAC for alert rules to consider access to rule as access to group it belongs (#49033) ... * update authz to exclude entire group if user does not have access to rule * change rule update authz to not return changes because if user does not have access to any rule in group, they do not have access to the rule * a new query that returns alerts in group by UID of alert that belongs to that group * collect all affected groups during calculate changes * update authorize to check access to groups * update tests for calculateChanges to assert new fields * add authorization tests	3 years ago
Alexander Weaver	909ebcf979	Alerting: Endpoints for provisioning mute timings (#49635) ... * Add validator for mute timing and make it provisionable * Add tests to ensure prometheus validators are running and errors are propagated * Internal API for manipulating mute timings * Define and generate API layer * Wire up generated code * Implement API handlers * Tests for golang layer * Fix reference bug * Fix linter and auth tests * Resolve semantic errors and regenerate * Remove pointless comment * Extract out provisioning path param keys, simplify * Expected number of paths	3 years ago
Yuriy Tseretyan	3dfafbadef	Alerting: Fix access to alerts for viewer with editor permissions when RBAC is disabled (#49270) ... * Add folder edit permission for users with Viewer role * relax permissions required to create an alert when RBAC is disabled	3 years ago
Yuriy Tseretyan	258b3ab18b	Alerting: Fix RBAC actions for notification policies (#49185) ... * squash actions "alert.notifications:update", "alert.notifications:create", "alert.notifications:delete" to "alert.notifications:write" * add migration * update UI to use the write action * update docs * changelog	3 years ago
Alexander Weaver	9af30f6570	Alerting: Provisioning GET routes for mute timings (#49044) ... * Define GET routes and run codegen * Wire up forked and non-generated API * Implement and wire * Tests, authorization * Fix linter error	3 years ago
Sofia Papagiannaki	925784f514	Alerting: Modify endpoint for testing a datasource rule using the UID (#48070) ... * Modify testing endpoint to expect the datasource UID * Update docs	3 years ago
Yuriy Tseretyan	952cb4fc0b	Alerting: introduce AlertRuleGroupKey and use it in API handlers (#48945) ... * create AlertGroupKey structure * update PrometheusSrv. - extract creation of RuleGroup to a separate method. Use group key for grouping * update RuleSrv - update calculateChanges to use groupKey - authorize to use groupkey	3 years ago
Yuriy Tseretyan	e528f2e430	Alerting: Use UID scope for folders authorization (#48970)	3 years ago
Alexander Weaver	99eaa0fc20	Put identifier in path (#48831)	3 years ago
Alexander Weaver	809aa38103	POST routes to PUT routes (#48828)	3 years ago