1350 Commits (ef5d71711a523efc65da089d45083e28201b58ab)

Author	SHA1	Message	Date
Pepe Cano	2d6586952d	Alerting: Add placeholder to the Email Contact Point Message (#84064)	1 year ago
Matthew Jacobson	fbd057b258	Alerting: Stop returning autogen routes for non-admin on api/v2/status (#84864) ... * Alerting: Stop returning autogen routes for non-admin on api/v2/status * Improve api/v2/status integration tests for user roles	1 year ago
William Wernert	6d16cf2699	Alerting: Marshal incoming json.RawMessage in diff (#84692) ... This will ensure the encoding is correct when comparing to the existing rule.	1 year ago
Yuri Tseretyan	04c9f459ec	Alerting: do not check for folder in file provisioning (#84822) ... provide nil folder service in file provisioning	1 year ago
Yuri Tseretyan	e593d36ed8	Alerting: Update rule access control to explicitly check for permissions "alert.rules:read" and "folders:read" (#78289) ... * require "folders:read" and "alert.rules:read" in all rules API requests (write and read). * add check for permissions "folders:read" and "alert.rules:read" to AuthorizeAccessToRuleGroup and HasAccessToRuleGroup * check only access to datasource in rule testing API --------- Co-authored-by: William Wernert <william.wernert@grafana.com>	1 year ago
Yuri Tseretyan	9dc4221508	Alerting: Log expression command types during evaluation (#84614)	1 year ago
Santiago	4ad6d66479	Alerting: Remove ID from UserGrafanaConfig struct (#84602) ... * Alerting: Remove ID from UserGrafanaConfig struct * user custom mimir image withoud id in grafana config * change mimir image name	1 year ago
Santiago	c9bb18101c	Alerting: Decrypt secrets before sending configuration to the remote Alertmanager (#83640) ... * (WIP) Alerting: Decrypt secrets before sending configuration to the remote Alertmanager * refactor, fix tests * test decrypting secrets * tidy up * test SendConfiguration, quote keys, refactor tests * make linter happy * decrypt configuration before comparing * copy configuration struct before decrypting * reduce diff in TestCompareAndSendConfiguration * clean up remote/alertmanager.go * make linter happy * avoid serializing into JSON to copy struct * codeowners	1 year ago
Matthew Jacobson	3ea5c08c88	Alerting: External AM fix parsing basic auth with escape characters (#84681)	1 year ago
William Wernert	97f37b2e6f	Alerting: Clamp Loki ASH range query to configured max_query_length (#83986) ... * Clamp range in loki http client to configured max_query_length Defaults to 721h to match Loki default	1 year ago
Yuri Tseretyan	827860d459	Alerting: Alerting accesscontrol utilities (#84508) ... * create fake for accesscontrol.RuleService * make errAuthorizationGeneric public	1 year ago
Yuri Tseretyan	f7d836feed	Alerting: Update rule provisioning service to accept user (#84480)	1 year ago
Gilles De Mey	8765c48389	Alerting: Remove legacy alerting (#83671) ... Removes legacy alerting, so long and thanks for all the fish! 🐟 --------- Co-authored-by: Matthew Jacobson <matthew.jacobson@grafana.com> Co-authored-by: Sonia Aguilar <soniaAguilarPeiron@users.noreply.github.com> Co-authored-by: Armand Grillet <armandgrillet@users.noreply.github.com> Co-authored-by: William Wernert <rwwiv@users.noreply.github.com> Co-authored-by: Yuri Tseretyan <yuriy.tseretyan@grafana.com>	1 year ago
William Wernert	8690a42e33	Alerting: Disallow invalid rule namespace UIDs in provisioning API (#83938) ... * Disallow invalid rule namespace UIDs in provisioning Reject requests with rules that reference a nonexistent folder or have an empty folder uid	1 year ago
Yuri Tseretyan	cfc3957894	Alerting: move store.ErrAlertRuleGroupNotFound to models package (#84308) ... move ErrAlertRuleGroupNotFound to models to avoid future circular dependencies	1 year ago
Andres Martinez Gotor	265200799d	Chore: Update grafana-plugin-sdk (#84289)	1 year ago
William Wernert	10dc6c6d75	Alerting: Add "Keep Last State" backend functionality (#83940) ... * Implement keep last state for state transitions * Respect For duration when keeping state * Only keep transition from recording an annotation * Add keep last state option for nodata/error in UI	1 year ago
Alexander Weaver	6c5e94095d	Alerting: Scheduler and registry handle rules by an interface (#84044) ... * export Evaluation * Export Evaluation * Export RuleVersionAndPauseStatus * export Eval, create interface * Export update and add to interface * Export Stop and Run and add to interface * Registry and scheduler use rule by interface and not concrete type * Update factory to use interface, update tests to work over public API rather than writing to channels directly * Rename map in registry * Rename getOrCreateInfo to not reference a specific implementation * Genericize alertRuleInfoRegistry into ruleRegistry * Rename alertRuleInfo to alertRule * Comments on interface * Update pkg/services/ngalert/schedule/schedule.go Co-authored-by: Jean-Philippe Quéméner <JohnnyQQQQ@users.noreply.github.com> --------- Co-authored-by: Jean-Philippe Quéméner <JohnnyQQQQ@users.noreply.github.com>	1 year ago
Alexander Weaver	201f5d3ac9	Alerting: Extract large closures in ruleRoutine (#84035) ... * extract notify * extract resetState * move evaluate metrics inside evaluate * split out evaluate	1 year ago
Alexander Weaver	7a171fd14a	Regenerate openapidocs at 1.21.8 to match ci (#84037) ... * Regenerate openapidocs at 1.21.8 to match ci * Adjust trigger to work on the actual outputted files * Also put go.mod and go.sum in the triggers * manually fix * Make an arbitrary change rather than touching the trigger to force a run * Drop all triggers - run all the time * Print diff - taken from @papagian's PR * Manual fixes to swagger doc --------- Co-authored-by: Ryan McKinley <ryantxu@gmail.com>	1 year ago
gotjosh	948c8c45d6	Alerting: Use Alertmanager types extracted into grafana/alerting (#83824) ... * Alerting: Use Alertmanager types extracted into grafana/alerting We're in the process of exporting all Alertmanager types into grafana/alerting so that they can be imported in the Mimir Alertmanager, without a neeed to import Grafana directly. This change introduces type aliasing for all Alertmanager types based on their 1:1 copy that now live in grafana/alerting. Signed-off-by: gotjosh <josue.abreu@gmail.com> --------- Signed-off-by: gotjosh <josue.abreu@gmail.com>	1 year ago
Alexander Weaver	d5fda06147	Alerting: Decouple rule routine from scheduler (#84018) ... * create rule factory for more complicated dep injection into rules * Rules get direct access to metrics, logs, traces utilities, use factory in tests * Use clock internal to rule * Use sender, statemanager, evalfactory directly * evalApplied and stopApplied * use schedulableAlertRules behind interface * loaded metrics reader * 3 relevant config options * Drop unused scheduler parameter * Rename ruleRoutine to run * Update READMED * Handle long parameter lists * remove dead branch	1 year ago
Alexander Weaver	1bb38e8f95	Alerting: Move ruleRoutine to be a method on ruleInfo (#83866) ... * Move ruleRoutine to ruleInfo file * Move tests as well * swap ruleInfo and scheduler parameters on ruleRoutine * Fix linter complaint, receiver name	1 year ago
Alexander Weaver	f2a9d0a89d	Alerting: Refactor ruleRoutine to take an entire ruleInfo instance (#83858) ... * Make stop a real method * ruleRoutine takes a ruleInfo reference directly rather than pieces of it * Fix whitespace	1 year ago
Matthew Jacobson	2e8c514cfd	Alerting: Stop persisting user-defined templates to disk (#83456) ... Updates Grafana Alertmanager to work with new interface from grafana/alerting#161. This change stops passing user-defined templates to the Grafana Alertmanager by persisting them to disk and instead passes them by string.	1 year ago
Alexander Weaver	fa51724bc6	Alerting: Move alertRuleInfo and tests to new files (#83854) ... Move ruleinfo and tests to new files	1 year ago
Ryan McKinley	3036b50df3	Expressions: expose ConvertDataFramesToResults (#83805)	1 year ago
Ryan McKinley	5f6bf93dd5	Expressions: Use enumerations rather than strings (#83741)	1 year ago
Santiago	8ad367e4ad	Chore: Remove redundant error check (#83769)	1 year ago
Alexander Weaver	a862a4264d	Alerting: Export rule validation logic and make it portable (#83555) ... * ValidateInterval doesn't need the entire config * Validation no longer depends on entire folder now that we've dropped foldertitle from api * Don't depend on entire config struct * Export validate group	1 year ago
Joe Blubaugh	b905777ba9	Alerting: Support deleting rule groups in the provisioning API (#83514) ... * Alerting: feat: support deleting rule groups in the provisioning API Adds support for DELETE to the provisioning API's alert rule groups route, which allows deleting the rule group with a single API call. Previously, groups were deleted by deleting rules one-by-one. Fixes #81860 This change doesn't add any new paths to the API, only new methods. --------- Co-authored-by: Yuri Tseretyan <yuriy.tseretyan@grafana.com>	1 year ago
김은빈	96dfb385ca	Grafana: Replace magic number with a constant variable in response status (#80132) ... * Chore: Replace response status with const var * Apply suggestions from code review Co-authored-by: Sofia Papagiannaki <1632407+papagian@users.noreply.github.com> * Add net/http import --------- Co-authored-by: Sofia Papagiannaki <1632407+papagian@users.noreply.github.com>	1 year ago
Takashi Idobe	f209a5a8b8	fix typos (#83414)	1 year ago
Serge Zaitsev	d0679f0993	Chore: Add support bundle for folders (#83360) ... * add support bundle for folders * fix ProvideService in tests * add a test for collector	1 year ago
George Robinson	a0353b237a	Alerting: Update swagger specs (#83260)	1 year ago
George Robinson	a564c8c439	Alerting: Keep order of time and mute time intervals consistent (#83257)	1 year ago
George Robinson	1ed1242358	Alerting: Basic support for time_intervals (#83216) ... This commit adds basic support for time_intervals, as mute_time_intervals is deprecated in Alertmanager and scheduled to be removed before 1.0. It does not add support for time_intervals in API or file provisioning, nor does it support exporting time intervals. This will be added in later commits to keep the changes as simple as possible.	1 year ago
Matthew Jacobson	87ab98ea95	Alerting: Fix panic in provisioning filter contacts by unknown name (#83070)	1 year ago
Matthew Jacobson	46a77c0074	Alerting: Validate upgraded receivers early to display in preview (#82956) ... Previously receivers were only validated before saving the alertmanager configuration. This is a suboptimal experience for those upgrading with preview as the failed channel upgrade will return an API error instead of being summarized in the table.	1 year ago
William Wernert	fabaff9a24	Alerting: Create metric for rules using simple notifications (#82904) ... --------- Co-authored-by: Matthew Jacobson <matthew.jacobson@grafana.com>	1 year ago
Matthew Jacobson	dfaf6d1e2e	Alerting: Dry-run legacy upgrade on startup (#82835) ... Adds a feature flag (alertingUpgradeDryrunOnStart) that will dry-run the legacy alert upgrade on startup. It is enabled by default. When on legacy alerting, this feature flag will log the results of the legacy alerting upgrade on startup and draw attention to anything in the current legacy alerting configuration that will cause issues when the upgrade is eventually performed. It acts as a log warning for those where action is required before upgrading to Grafana v11 where legacy alerting will be removed.	1 year ago
Matthew Jacobson	e7c6e9c5c9	Alerting: Fix migration edge-case race condition for silences (#81206) ... If the db already has an entry in the kvstore for the silences of an alertmanager before the migration has taken place, then it's possible that the active alertmanager will overwrite the silence file created by the migration before it has a chance to load it into memory. This should not happen normally but is possible in edge-cases. This change opts to bypass the unnecessary step of writing the silences to disk during the migration and instead write them directly to the kvstore. This avoids the race condition entirely and is more correct as we treat the database as the source of truth for AM state.	1 year ago
Gabriel MABILLE	846eadff63	RBAC Search: Replace `userLogin` filter by `namespacedID` filter (#81810) ... * Add namespace ID * Refactor and add tests * Rename maxOneOption -> atMostOneOption * Add ToDo * Remove UserLogin & UserID for NamespaceID Co-authored-by: jguer <joao.guerreiro@grafana.com> * Remove unecessary import of the userSvc * Update pkg/services/accesscontrol/acimpl/service.go * fix 1 -> userID * Update pkg/services/accesscontrol/accesscontrol.go --------- Co-authored-by: jguer <joao.guerreiro@grafana.com>	1 year ago
Sven Kirschbaum	86c618a6d6	Alerting: Escape namespace and group path parameters (#80504) ... Co-authored-by: Jean-Philippe Quéméner <JohnnyQQQQ@users.noreply.github.com>	1 year ago
Matthew Jacobson	118e4a50b7	Alerting: Remove start page of legacy upgrade preview (#82010) ... Alerting: Remove start page of upgrade preview Alerting upgrade page will now always show the summary table even before upgrading any alerts or notification channels. There a few reasons for this: - The information on the start page is redundant as it's now contained in the documentation. - Previously, if some unexpected issue prevented performing a full upgrade, a user would have limited to no means to using the preview tool to help fix the problem. This is because you could not see the summary table until the full upgrade was performed at least once. Now, you can upgrade individual alerts and notification channels from the beginning.	1 year ago
Julien Duchesne	ba63e62311	Alerting: Return provenance of notification templates (#82274)	1 year ago
William Wernert	b7bbc5058f	Alerting: Don't validate rules on group update if they've only been reordered (#81841) ... --------- Co-authored-by: Yuri Tseretyan <yuriy.tseretyan@grafana.com>	1 year ago
Yuri Tseretyan	1eebd2a4de	Alerting: Support for simplified notification settings in rule API (#81011) ... * Add notification settings to storage\domain and API models. Settings are a slice to workaround XORM mapping * Support validation of notification settings when rules are updated * Implement route generator for Alertmanager configuration. That fetches all notification settings. * Update multi-tenant Alertmanager to run the generator before applying the configuration. * Add notification settings labels to state calculation * update the Multi-tenant Alertmanager to provide validation for notification settings * update GET API so only admins can see auto-gen	1 year ago
Alexander Weaver	d4ae10ecc6	Alerting: Small refactor, move unrelated functions out of fetcher (#82459) ... Move unrelated functions out of fetcher	1 year ago
Diego Augusto Molina	ff08c0a790	Chore: improve test readability in ngalert/schedule (#82453) ... Chore: improve test readability	1 year ago